Re: [PATCH net] bpf/verifier: reject invalid LD_ABS | BPF_DW instruction

2016-04-13 Thread David Miller
From: Alexei Starovoitov Date: Tue, 12 Apr 2016 10:26:19 -0700 > verifier must check for reserved size bits in instruction opcode and > reject BPF_LD | BPF_ABS | BPF_DW and BPF_LD | BPF_IND | BPF_DW instructions, > otherwise interpreter will WARN_RATELIMIT on them during execution.

Re: [PATCH net v3] net: sched: do not requeue a NULL skb

2016-04-13 Thread David Miller
From: Lars Persson Date: Tue, 12 Apr 2016 08:45:52 +0200 > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > > We

Re: [PATCH net-next] gre: eliminate holes in ip_tunnel

2016-04-13 Thread David Miller
From: Stephen Hemminger Date: Wed, 13 Apr 2016 17:02:21 -0700 > The structure can be packed denser by doing minor rearrangement > of existing elements. > > Signed-off-by: Stephen Hemminger Applied, thank you.

[PATCH net-next 0/2] tcp: final work on SYNFLOOD behavior

2016-04-13 Thread Eric Dumazet
In the first patch, I remove the costly association of SYNACK+COOKIES to a listener. I believe other parts of the stack should be ready. The second patch removes a useless write into listener socket in tcp_rcv_state_process(), incurring false sharing in tcp_conn_request() Performance under

[PATCH net-next 1/2] tcp: do not mess with listener sk_wmem_alloc

2016-04-13 Thread Eric Dumazet
When removing sk_refcnt manipulation on synflood, I missed that using skb_set_owner_w() was racy, if sk->sk_wmem_alloc had already transitioned to 0. We should hold sk_refcnt instead, but this is a big deal under attack. (Doing so increase performance from 3.2 Mpps to 3.8 Mpps only) In this

[PATCH net-next 2/2] tcp: remove false sharing in tcp_rcv_state_process()

2016-04-13 Thread Eric Dumazet
Last known hot point during SYNFLOOD attack is the clearing of rx_opt.saw_tstamp in tcp_rcv_state_process() It is not needed for a listener, so we move it where it matters. Performance while a SYNFLOOD hits a single listener socket went from 5 Mpps to 6 Mpps on my test server (24 cores, 8 NIC RX

Re: [PATCH] ravb: make ravb_ptp_interrupt() *void*

2016-04-13 Thread David Miller
From: Sergei Shtylyov Date: Sun, 10 Apr 2016 23:55:15 +0300 > When we have the ISS.CGIS bit set, we already know that gPTP interrupt has > happened, so an extra GIS register check at the end of ravb_ptp_interrupt() > seems superfluous. We can model the gPTP

Re: [PATCH net] packet: fix heap info leak in PACKET_DIAG_MCLIST sock_diag interface

2016-04-13 Thread David Miller
From: Mathias Krause Date: Sun, 10 Apr 2016 12:52:28 +0200 > Because we miss to wipe the remainder of i->addr[] in packet_mc_add(), > pdiag_put_mclist() leaks uninitialized heap bytes via the > PACKET_DIAG_MCLIST netlink attribute. > > Fix this by explicitly memset(0)ing

Re: [PATCH net-next 0/4] qed*: [mostly] Ethtool RSS configuration

2016-04-13 Thread David Miller
From: Yuval Mintz Date: Sun, 10 Apr 2016 12:42:58 +0300 > Most of the content [code-wise] in this series is for allowing various > RSS-related configuration via ethtool. > > In addition, this also removed an unnecessary versioning scheme between > the drivers and bump

Re: [git pull] sock_recvmsg() redundant argument

2016-04-13 Thread David Miller
From: Al Viro Date: Sat, 9 Apr 2016 21:07:05 +0100 > Preparation for a bunch of iov_iter stuff; I'm not sure if all of those should > go via net-next (e.g. cifs stuff almost certainly doesn't, etc.), but this > bit is common to all those series and it would be better off

Re: [PATCH net-next] net: remove netdevice gso_min_segs

2016-04-13 Thread David Miller
From: Eric Dumazet Date: Sat, 09 Apr 2016 11:29:58 -0700 > From: Eric Dumazet > > After introduction of ndo_features_check(), we believe that very > specific checks for rare features should not be done in core > networking stack. > > No driver uses

Re: [PATCH] qdisc: constify meta_type_ops structures

2016-04-13 Thread David Miller
From: Julia Lawall Date: Sat, 9 Apr 2016 10:49:22 +0200 > The meta_type_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Applied, thank you.

Re: [PATCH net-next v2] net: bcmgenet: add BQL support

2016-04-13 Thread David Miller
From: Petri Gynther Date: Sat, 9 Apr 2016 00:20:36 -0700 > Add Byte Queue Limits (BQL) support to bcmgenet driver. > > Signed-off-by: Petri Gynther Applied, thank you.

Re: [net 0/2][pull request] Intel Wired LAN Driver Updates 2016-04-13

2016-04-13 Thread David Miller
From: Jeff Kirsher Date: Wed, 13 Apr 2016 20:47:10 -0700 > This series contains updates to i40e, i40evf and fm10k. Pulled, thanks Jeff.

[PATCH V3 00/29] bitops: add parity functions

2016-04-13 Thread zengzhaoxiu
From: Zhaoxiu Zeng When I do "grep parity -r linux", I found many parity calculations distributed in many drivers. This patch series does: 1. provide generic and architecture-specific parity calculations 2. remove drivers' local parity calculations, use bitops'

Re: [PATCH net-next v2 1/2] rtnetlink: add new RTM_GETSTATS message to dump link stats

2016-04-13 Thread David Miller
From: Roopa Prabhu Date: Fri, 8 Apr 2016 23:38:11 -0700 > This patch adds a new RTM_GETSTATS message to query link stats via netlink > from the kernel. RTM_NEWLINK also dumps stats today, but RTM_NEWLINK > returns a lot more than just stats and is expensive in some

Re: [PATCH net-next] net: ipv6: Use passed in table for nexthop lookups

2016-04-13 Thread David Ahern
On 4/13/16 7:41 PM, David Miller wrote: This is semantically different from the referenced ipv4 change. Lack of a matching table for cfg->fc_table does not result in a failure on the ipv4 side. It falls back in that case. But here in this ipv6 patch, you do fail if fib6_get_table() gives

RE: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-13 Thread Dexuan Cui
> From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, April 14, 2016 10:30 > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com;

[net 1/2] i40e/i40evf: Limit TSO to 7 descriptors for payload instead of 8 per packet

2016-04-13 Thread Jeff Kirsher
From: Alexander Duyck This patch addresses a bug introduced based on my interpretation of the XL710 datasheet. Specifically section 8.4.1 states that "A single transmit packet may span up to 8 buffers (up to 8 data descriptors per packet including both the header and

[net 2/2] fm10k: fix multi-bit VLAN update requests from VF

2016-04-13 Thread Jeff Kirsher
From: Jacob Keller The VF uses a multi-bit update request to clear unused VLANs whenever it resets. However, an accident in a previous refector broke multi-bit updates for VFs, due to misreading a comment in fm10k_vf.c and attempting to reduce code duplication. The

[net 0/2][pull request] Intel Wired LAN Driver Updates 2016-04-13

2016-04-13 Thread Jeff Kirsher
This series contains updates to i40e, i40evf and fm10k. Alex fixes a bug introduced earlier based on his interpretation of the XL710 datasheet. The actual limit for fragments with TSO and a skbuff that has payload data in the header portion of the buffer is actually only 7 fragments and the

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Weidong Wang
On 2016/4/14 2:41, Florian Fainelli wrote: > On 13/04/16 04:59, Weidong Wang wrote: >> When tested the PHY SGMII Loopback,: >> 1.set the LOOPBACK bit, >> 2.set the autoneg to AUTONEG_DISABLE, it calls the >> genphy_setup_forced which will clear the bit. >> >> So just keep the LOOPBACK bit while

Re: [PATCH net-next] net: bcmgenet: use __napi_schedule_irqoff()

2016-04-13 Thread David Miller
From: Eric Dumazet Date: Fri, 08 Apr 2016 22:30:56 -0700 > From: Florian Fainelli > > bcmgenet_isr1() and bcmgenet_isr0() run in hard irq context, > we do not need to block irq again. > > Signed-off-by: Florian Fainelli >

Re: [PATCH net-next] net: bcmgenet: use napi_complete_done()

2016-04-13 Thread David Miller
From: Eric Dumazet Date: Fri, 08 Apr 2016 22:06:40 -0700 > From: Eric Dumazet > > By using napi_complete_done(), we allow fine tuning > of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation > efficiency for a Gbit NIC. > > Check

Re: [net-next][PATCH 0/2] RDS: couple of fixes for 4.6

2016-04-13 Thread David Miller
From: Santosh Shilimkar Date: Fri, 8 Apr 2016 15:26:38 -0700 > Patches are also available at below git tree. > > git://git.kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git > for_4.6/net-next/rds-fixes "Bug fixes for 4.6" do not get targetted at the

Re: [PATCH v4] route: do not cache fib route info on local routes with oif

2016-04-13 Thread David Miller
From: Chris Friesen Date: Fri, 8 Apr 2016 15:21:30 -0600 > For local routes that require a particular output interface we do not want > to cache the result. Caching the result causes incorrect behaviour when > there are multiple source addresses on the interface.

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on net/master] [also build test WARNING on v4.6-rc3 next-20160413] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Timur-Tabi/net-emac-emac-gigabit-ethernet

[PATCH V3 23/29] ethernet: use parity8 in sun/niu.c

2016-04-13 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/net/ethernet/sun/niu.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c index

[PATCH V3 29/29] ethernet: use parity8 in broadcom/tg3.c

2016-04-13 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- drivers/net/ethernet/broadcom/tg3.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index

Re: [PATCH] net: ipv6: Do not keep linklocal and loopback addresses

2016-04-13 Thread David Ahern
On 4/13/16 9:00 PM, David Miller wrote: Applied, but two things: Please do not put an empty line between the Fixes: and other tags. All tags are equal and should be placed together as an unsegmented unit. ack. Second, please be really sure this is the final set of semantics you want. If

[PATCH V3 10/29] sunrpc: use parity8

2016-04-13 Thread zengzhaoxiu
From: Zhaoxiu Zeng Signed-off-by: Zhaoxiu Zeng --- net/sunrpc/auth_gss/gss_krb5_keys.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/net/sunrpc/auth_gss/gss_krb5_keys.c b/net/sunrpc/auth_gss/gss_krb5_keys.c index

Re: [PATCH v3 0/2] sctp: delay calls to sk_data_ready() as much as possible

2016-04-13 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 8 Apr 2016 16:41:26 -0300 > 1st patch is a preparation for the 2nd. The idea is to not call > ->sk_data_ready() for every data chunk processed while processing > packets but only once before releasing the socket. > > v2:

Re: [PATCH] mISDN: Fixing missing validation in base_sock_bind()

2016-04-13 Thread David Miller
From: Emrah Demir Date: Fri, 8 Apr 2016 22:16:11 +0300 > From: Emrah Demir > > Add validation code into mISDN/socket.c > > Signed-off-by: Emrah Demir Applied, thanks.

Re: [PATCH] net: ipv6: Do not keep linklocal and loopback addresses

2016-04-13 Thread David Miller
From: David Ahern Date: Fri, 8 Apr 2016 12:01:21 -0700 > f1705ec197e7 added the option to retain user configured addresses on an > admin down. A comment to one of the later revisions suggested using the > IFA_F_PERMANENT flag rather than adding a user_managed boolean

Re: [PATCH net-next 0/2] fix two more udp pull header issues

2016-04-13 Thread Willem de Bruijn
On Wed, Apr 13, 2016 at 10:25 PM, David Miller wrote: > From: Willem de Bruijn > Date: Thu, 7 Apr 2016 18:12:57 -0400 > >> Follow up patches to the fixes to RxRPC and SunRPC. A scan of the >> code showed two other interfaces that expect UDP

Re: [PATCH] drivers/net/ethernet/jme.c: Deinline jme_reset_mac_processor, save 2816 bytes

2016-04-13 Thread David Miller
From: Denys Vlasenko Date: Fri, 8 Apr 2016 20:39:47 +0200 > This function compiles to 895 bytes of machine code. > > Clearly, this isn't a time-critical function. > For one, it has a number of udelay(1) calls. > > Signed-off-by: Denys Vlasenko No

Re: [PATCH net-next v3] packet: uses kfree_skb() for errors.

2016-04-13 Thread David Miller
From: Weongyo Jeong Date: Fri, 8 Apr 2016 09:25:48 -0700 > diff --git a/net/packet/af_packet.c b/net/packet/af_packet.c > index 1ecfa71..4e054bb 100644 > --- a/net/packet/af_packet.c > +++ b/net/packet/af_packet.c > @@ -2042,6 +2042,7 @@ static int packet_rcv(struct

Re: [PATCH RESEND] net: ethernet: renesas: ravb_main: test clock rate to avoid division by 0

2016-04-13 Thread David Miller
From: Wolfram Sang Date: Fri, 8 Apr 2016 13:28:42 +0200 > From: Wolfram Sang > > The clk API may return 0 on clk_get_rate, so we should check the result before > using it as a divisor. > > Signed-off-by: Wolfram Sang

Re: [PATCH] net: force inlining of netif_tx_start/stop_queue, sock_hold, __sock_put

2016-04-13 Thread David Miller
From: Denys Vlasenko Date: Fri, 8 Apr 2016 17:51:54 +0200 > Sometimes gcc mysteriously doesn't inline > very small functions we expect to be inlined. See > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66122 > Arguably, gcc should do better, but gcc people aren't willing

Re: [PATCH] [linux-next] Doc: networking: Fix typo in dsa

2016-04-13 Thread David Miller
From: Masanari Iida Date: Sat, 9 Apr 2016 00:00:25 +0900 > This patch fix typos in Documentation/networking/dsa. > > Signed-off-by: Masanari Iida Applied.

Re: [PATCH net-next] net: ethernet: stmmac: GMAC4.xx: Fix TX descriptor preparation

2016-04-13 Thread David Miller
From: Alexandre TORGUE Date: Fri, 8 Apr 2016 11:18:03 +0200 > On GMAC4.xx each descriptor contains 2 buffers of 16KB (each). > Initially, those 2 buffers was filled in dwmac4_rd_prepare_tx_desc but > it is actually not needed. Indeed, stmmac driver supports frame up to >

Re: [PATCH net-next] sock: tigthen lockdep checks for sock_owned_by_user

2016-04-13 Thread David Miller
From: Hannes Frederic Sowa Date: Fri, 8 Apr 2016 15:11:27 +0200 > sock_owned_by_user should not be used without socket lock held. It seems > to be a common practice to check .owned before lock reclassification, so > provide a little help to abstract this check away.

Re: [PATCH net-next] ipv6, token: allow for clearing the current device token

2016-04-13 Thread David Miller
From: Daniel Borkmann Date: Fri, 8 Apr 2016 15:55:00 +0200 > The original tokenized iid support implemented via f53adae4eae5 ("net: ipv6: > add tokenized interface identifier support") didn't allow for clearing a > device token as it was intended that this addressing mode

Re: [PATCHv3 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl

2016-04-13 Thread David Miller
From: Xin Long Date: Sat, 9 Apr 2016 00:03:27 +0800 > This patchset is used to support sending rntl info to user in some places, > and ensure that whenever those attributes change internally or from sysfs, > that a netlink notification is sent out to listeners. > > It

Urgent Loans!

2016-04-13 Thread Fidelity Mortgage Loan
Loan Offer at 3%, Feel Free to REPLY back to us for more info

Re: [PATCH v8 net-next 1/1] hv_sock: introduce Hyper-V Sockets

2016-04-13 Thread David Miller
From: Dexuan Cui Date: Thu, 7 Apr 2016 18:36:51 -0700 > +struct vmpipe_proto_header { > + u32 pkt_type; > + u32 data_size; > +} __packed; There is no reason to specify __packed here. The types are strongly sized to word aligned quantities. No holes are possible in

Re: [PATCH net-next 0/2] fix two more udp pull header issues

2016-04-13 Thread David Miller
From: Willem de Bruijn Date: Thu, 7 Apr 2016 18:12:57 -0400 > Follow up patches to the fixes to RxRPC and SunRPC. A scan of the > code showed two other interfaces that expect UDP packets to have > a udphdr when queued: read packet length with ioctl SIOCINQ and >

Re: [PATCH] net-next: mediatek: add support for IRQ grouping

2016-04-13 Thread David Miller
From: John Crispin Date: Thu, 7 Apr 2016 20:24:59 +0200 > The ethernet core has 3 IRQs. Using the IRQ grouping registers we are able > to separate TX and RX IRQs, which allows us to service them on separate > cores. This patch splits the IRQ handler into 2 separate

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Weidong Wang
On 2016/4/13 22:19, Sergei Shtylyov wrote: > Hello. > > On 4/13/2016 2:59 PM, Weidong Wang wrote: > >> When tested the PHY SGMII Loopback,: >> 1.set the LOOPBACK bit, >> 2.set the autoneg to AUTONEG_DISABLE, it calls the >> genphy_setup_forced which will clear the bit. >> >> So just keep the

Re: [PATCH RFC 2/5] net: phy: sun8i-h3-ephy: Add driver for Allwinner H3 Ethernet PHY

2016-04-13 Thread Chen-Yu Tsai
On Tue, Apr 12, 2016 at 3:23 AM, Florian Fainelli wrote: > On 04/04/16 09:22, Chen-Yu Tsai wrote: >> The Allwinner H3 SoC incorporates an Ethernet PHY. This is enabled and >> configured through a memory mapped hardware register. >> >> This same register also configures the

Re: [PATCH net-next 4/8] dsa: Move gpio reset into switch driver

2016-04-13 Thread David Miller
From: Andrew Lunn Date: Thu, 14 Apr 2016 01:59:54 +0200 > @@ -3178,6 +3178,7 @@ int mv88e6xxx_probe(struct mdio_device *mdiodev, struct > dsa_switch_driver *ops, > struct mv88e6xxx_priv_state *ps; > struct dsa_switch *ds; > const char *name; > + int err; >

Re: [PATCH 0/3] Netfilter fixes for net

2016-04-13 Thread David Miller
From: Pablo Neira Ayuso Date: Thu, 14 Apr 2016 00:54:51 +0200 > The following patchset contains Netfilter fixes for your net tree. More > specifically, they are: > > 1) Fix missing filter table per-netns registration in arptables, from >Florian Westphal. > > 2) Resolve

Re: [PATCH net-next] net: ipv6: Use passed in table for nexthop lookups

2016-04-13 Thread David Miller
From: David Ahern Date: Thu, 7 Apr 2016 11:11:14 -0700 > Similar to 3bfd847203c6 ("net: Use passed in table for nexthop lookups") > for IPv4, if the route spec contains a table id use that to lookup the > next hop first and fall back to a full lookup if it fails (per

Re: [RFC] Is it a bug for nfs on udp6 mode or kernel?

2016-04-13 Thread Ding Tianhong
On 2016/4/14 0:17, Eric Dumazet wrote: > On Wed, 2016-04-13 at 19:28 +0800, Ding Tianhong wrote: >> Hi everyone: >> >> I have met this problem when I try to test udp6 for nfs connection, my >> environment is: >> >> Server: >> kernel: 4.1.15 >> IP:::36/64 >> MTU:1500 >> Setting:

Re: [PATCH v2 01/15] wcn36xx: Clean up wcn36xx_smd_send_beacon

2016-04-13 Thread Bjorn Andersson
On Sun 03 Apr 15:16 PDT 2016, Bjorn Andersson wrote: > From: Pontus Fuchs > > Needed for coming improvements. No functional changes. > Kalle, Eugene, Have you picked up these patches yet? As I was debugging a firmware crash when trying to start hostap on the

Re: [RFC] Is it a bug for nfs on udp6 mode or kernel?

2016-04-13 Thread Ding Tianhong
On 2016/4/13 22:11, Benjamin Coddington wrote: > On Wed, 13 Apr 2016, Ding Tianhong wrote: > >> Hi everyone: >> >> I have met this problem when I try to test udp6 for nfs connection, my >> environment is: >> >> Server: >> kernel: 4.1.15 >> IP:::36/64 >> MTU:1500 >> Setting:

[PATCH net-next 7/8] dsa: mv88e6xxx: Use the name table to determine number of ports

2016-04-13 Thread Andrew Lunn
Extend the ID to name table to also include the number of ports. Saves a few switch statements and it is likely other entries will be added to the table later. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 30 +-

[PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-13 Thread Andrew Lunn
Export all the functions so that we can later turn the module into a library module. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx.c

[PATCH net-next 2/8] dsa: mv88e6xxx: Add macro for registering the drivers

2016-04-13 Thread Andrew Lunn
The macro cuts down on boilerplate. The switch driver needs to both register itself as an MDIO driver and register itself as a switch driver. This second registration is needed to retain backwards compatibility with the old binding. Signed-off-by: Andrew Lunn ---

[PATCH net-next] gre: eliminate holes in ip_tunnel

2016-04-13 Thread Stephen Hemminger
The structure can be packed denser by doing minor rearrangement of existing elements. Signed-off-by: Stephen Hemminger --- a/include/net/ip_tunnels.h 2016-04-11 13:42:06.654666930 -0700 +++ b/include/net/ip_tunnels.h 2016-04-13 16:47:59.821692189 -0700 @@ -105,24

[PATCH net-next 3/8] dsa: Add mdio device support to Marvell switches

2016-04-13 Thread Andrew Lunn
Allow Marvell switches to be mdio devices. Currently they just probe and allocate there private structure. Later patches will make them register with the DSA framework. At the same time, make them separate modules, and make mv88e6xxx a library module. Signed-off-by: Andrew Lunn

[PATCH net-next 6/8] dsa: mv88e6xxx: Replace ds with ps where possible

2016-04-13 Thread Andrew Lunn
The dsa_switch structure ds is actually needed in very few places, mostly during setup of the switch. The private structure ps is however needed nearly everywhere. Pass ps, not ds internally. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 11 +-

[PATCH net-next 4/8] dsa: Move gpio reset into switch driver

2016-04-13 Thread Andrew Lunn
Resetting the switch is something the driver does, not the framework. So move the parsing of this property into the driver. There are no in kernel users of this property, so moving it does not break anything. There is a board which will make use of this property making its way into the kernel.

[PATCH net-next 5/8] dsa: mv88e6xxx: Kill the REG_READ and REG_WRITE macros

2016-04-13 Thread Andrew Lunn
These macros hide a ds variable and a return statement on error, which can lead to locking issues. Kill them off. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6123.c | 13 ++- drivers/net/dsa/mv88e6131.c | 41 drivers/net/dsa/mv88e6171.c | 16 +--

[PATCH net-next 8/8] dsa: mv88e6131: Don't special case a single device

2016-04-13 Thread Andrew Lunn
When multiple switches are interconnected in a tree, a routing table is used for directing packets out the correct port towards a remote destination. This works equally well for a single switch, since the routing table is empty. So don't special case for a single switch. This makes the mv88e6131

[PATCH net-next 0/8] DSA refactoring: set 2

2016-04-13 Thread Andrew Lunn
More preparatory patches for the DSA probe refactoring. The first three patches turn the Marvell drivers into individual modules, and a shared library module. They also become real Linux devices, with probe functions. However, at the moment, this is just stub code to be filled out with later

[PATCH 0/3] Netfilter fixes for net

2016-04-13 Thread Pablo Neira Ayuso
Hi David, The following patchset contains Netfilter fixes for your net tree. More specifically, they are: 1) Fix missing filter table per-netns registration in arptables, from Florian Westphal. 2) Resolve out of bound access when parsing TCP options in nf_conntrack_tcp, patch from Jozsef

[PATCH 2/3] netfilter: nf_conntrack_tcp: Fix stack out of bounds when parsing TCP options

2016-04-13 Thread Pablo Neira Ayuso
From: Jozsef Kadlecsik Baozeng Ding reported a KASAN stack out of bounds issue - it uncovered that the TCP option parsing routines in netfilter TCP connection tracking could read one byte out of the buffer of the TCP options. Therefore in the patch we check that the

[PATCH 3/3] netfilter: ebtables: Fix extension lookup with identical name

2016-04-13 Thread Pablo Neira Ayuso
From: Phil Sutter If a requested extension exists as module and is not loaded, ebt_check_match() might accidentally use an NFPROTO_UNSPEC one with same name and fail. Reproduced with limit match: Given xt_limit and ebt_limit both built as module, the following would fail:

[PATCH 1/3] netfilter: arp_tables: register table in initns

2016-04-13 Thread Pablo Neira Ayuso
From: Florian Westphal arptables is broken since we didn't register the table anymore -- even 'arptables -L' fails. Fixes: b9e69e127397187b ("netfilter: xtables: don't hook tables by default") Signed-off-by: Florian Westphal Signed-off-by: Pablo Neira Ayuso

Re: [PATCH 0/3] crypto: af_alg - add TLS type encryption

2016-04-13 Thread Tadeusz Struk
Hi Fridolin, On 04/12/2016 04:13 AM, Fridolin Pokorny wrote: > we were experimenting with this. We have a prove of concept of a kernel > TLS type socket, so called AF_KTLS, which is based on Dave Watson's > RFC5288 patch. It handles both TLS and DTLS, unfortunately it is not > ready now to be

[PATCH 1/1] hv_netvsc: Implement support for VF drivers on Hyper-V

2016-04-13 Thread K. Y. Srinivasan
Support VF drivers on Hyper-V. On Hyper-V, each VF instance presented to the guest has an associated synthetic interface that shares the MAC address with the VF instance. Typically these are bonded together to support live migration. By default, the host delivers all the incoming packets on the

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread Florian Fainelli
On 13/04/16 10:59, Timur Tabi wrote: > From: Gilad Avidov > > Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. > This driver supports the following features: > 1) Checksum offload. > 2) Runtime power management support. > 3) Interrupt coalescing

[PATCH iproute2] ss: take care of unknown min_rtt

2016-04-13 Thread Eric Dumazet
From: Eric Dumazet Kernel sets info->tcpi_min_rtt to ~0U when no RTT sample was ever taken for the session, thus min_rtt is unknown. Signed-off-by: Eric Dumazet --- misc/ss.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 net-next 0/7] DSA refactoring: set 1

2016-04-13 Thread David Miller
From: Andrew Lunn Date: Wed, 13 Apr 2016 02:40:38 +0200 > There has been a long running effort to refractor DSA probing to make > the switches true linux devices. Here are a small collection of > patches moving in this direction. Most have been seen before. > > We take a little

[PATCH] sctp: simplify sk_receive_queue locking

2016-04-13 Thread Marcelo Ricardo Leitner
SCTP already serializes access to rcvbuf through its sock lock: sctp_recvmsg takes it right in the start and release at the end, while rx path will also take the lock before doing any socket processing. On sctp_rcv() it will check if there is an user using the socket and, if there is, it will

Re: pull-request: mac80211-next 2016-04-13

2016-04-13 Thread David Miller
From: Johannes Berg Date: Wed, 13 Apr 2016 21:36:31 +0200 > For a while now I've wanted to remove enum ieee80211_band, and in > order to synchronize more easily with Kalle that's (apart from a > documentation change I already had pending) all in this pull. > > Let me

Re: pull-request: wireless-drivers 2016-04-13

2016-04-13 Thread David Miller
From: Kalle Valo Date: Wed, 13 Apr 2016 21:23:21 +0300 > few very small fixes for 4.6. All but one are either build fixes or > memory leaks. More info in the signed tag below. > > Please let me know if there are any problems. Pulled, thanks.

Re: [PATCH for-next V1 1/2] net/mlx5: Fix mlx5 ifc cmd_hca_cap bad offsets

2016-04-13 Thread Saeed Mahameed
On Wed, Apr 13, 2016 at 8:48 PM, Jason Gunthorpe wrote: > On Wed, Apr 13, 2016 at 07:11:03PM +0300, Saeed Mahameed wrote: > >> Fixes: b084590e ("net/mlx5_core: Introduce access function to read >> internal timer ") >> Fixes: b4ff3a36d3e4 ("net/mlx5: Use

Re: [PATCH net-next 1/1] tipc: remove remnants of old broadcast code

2016-04-13 Thread David Miller
From: Jon Maloy Date: Wed, 13 Apr 2016 11:45:47 -0400 > We remove a couple of leftover fields in struct tipc_bearer. Those > were used by the old broadcast implementation, and are not needed > any longer. There is no functional changes in this commit. > > Acked-by: Ying

Re: [PATCH iproute2] ss: 64bit inode numbers

2016-04-13 Thread Eric Dumazet
On Wed, 2016-04-13 at 13:55 -0700, Stephen Hemminger wrote: > On Tue, 12 Apr 2016 15:22:29 -0700 > Eric Dumazet wrote: > > > From: Eric Dumazet > > > > Lets prepare for a possibility to have 64bit inode numbers for sockets, > > even if the kernel

Re: [PATCH iproute2] ss: 64bit inode numbers

2016-04-13 Thread Stephen Hemminger
On Tue, 12 Apr 2016 15:22:29 -0700 Eric Dumazet wrote: > From: Eric Dumazet > > Lets prepare for a possibility to have 64bit inode numbers for sockets, > even if the kernel currently enforces 32bit numbers. > > Presumably, if both kernel and

RE: TCP reaching to maximum throughput after a long time

2016-04-13 Thread Machani, Yaniv
On Wed, Apr 13, 2016 at 17:32:29, Neal Cardwell wrote: > Miller; Eric Dumazet; Nandita Dukkipati; open list; Kama, Meirav > Subject: Re: TCP reaching to maximum throughput after a long time > > I like the idea to disable hystart ack-train. > > > Yaniv, can you please re-run your test with CUBIC

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread Bjørn Mork
Timur Tabi writes: > Shanker Donthineni wrote: >> drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function >> 'emac_mac_up': >>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: >>large integer implicitly truncated to

[iproute PATCH 2/2] ss: Fix accidental state filter override

2016-04-13 Thread Phil Sutter
Passing a filter expression and selecting an address family using the '-f' flag would overwrite the state filter by accident. Therefore calling e.g. 'ss -nl -f inet '(sport = :22)' would not only print listening sockets (as requested by '-l' flag) but connected ones, as well. Fix this by reusing

[iproute PATCH 0/2] Minor ss filter fix and review

2016-04-13 Thread Phil Sutter
While looking for a solution to the problem described in patch 2/2, I discovered the overly complicated assignment in filter_states_set() which is simplified in patch 1/2. Phil Sutter (2): ss: Drop silly assignment ss: Fix accidental state filter override misc/ss.c | 5 +++-- 1 file

[iproute PATCH 1/2] ss: Drop silly assignment

2016-04-13 Thread Phil Sutter
An expression of the form '(a | b) & b' will evaluate to the value of b for any value of a or b. Signed-off-by: Phil Sutter --- misc/ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/ss.c b/misc/ss.c index 38cf3312a746e..d6090018c5dbb 100644 ---

pull-request: mac80211-next 2016-04-13

2016-04-13 Thread Johannes Berg
Hi Dave, For a while now I've wanted to remove enum ieee80211_band, and in order to synchronize more easily with Kalle that's (apart from a documentation change I already had pending) all in this pull. Let me know if there's any problem. Thanks, johannes The following changes since commit

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread Timur Tabi
Shanker Donthineni wrote: >> drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': >>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow] >> writel(~DIS_INT, adpt->base +

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread Shanker Donthineni
On 04/13/2016 02:31 PM, Timur Tabi wrote: > kbuild test robot wrote: >> >> drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': >>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large >>integer implicitly truncated to unsigned type [-Woverflow]

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread Timur Tabi
kbuild test robot wrote: drivers/net/ethernet/qualcomm/emac/emac-mac.c: In function 'emac_mac_up': >>drivers/net/ethernet/qualcomm/emac/emac-mac.c:1076:9: warning: large integer implicitly truncated to unsigned type [-Woverflow] writel(~DIS_INT, adpt->base + EMAC_INT_STATUS);

Re: [PATCH v2 net-next 6/7] dsa: Rename phys_port_mask to enabled_port_mask

2016-04-13 Thread Florian Fainelli
On 12/04/16 17:40, Andrew Lunn wrote: > The phys in phys_port_mask suggests this mask is about PHYs. In fact, > it means physical ports. Rename to enabled_port_mask, indicating > external enabled ports of the switch, which is hopefully less > confusing. > > Signed-off-by: Andrew Lunn

Re: [PATCH v2 net-next 5/7] net: dsa: Rename DSA probe function.

2016-04-13 Thread Florian Fainelli
On 12/04/16 17:40, Andrew Lunn wrote: > Rename the function called from the DSA to perform a probe for the > switch. This makes the normal _probe() name available for a standard > Linux device driver probe function. > > Signed-off-by: Andrew Lunn > Tested-by: Vivien Didelot

Re: [PATCH v2 net-next 0/7] DSA refactoring: set 1

2016-04-13 Thread Florian Fainelli
On 12/04/16 17:40, Andrew Lunn wrote: > There has been a long running effort to refractor DSA probing to make > the switches true linux devices. Here are a small collection of > patches moving in this direction. Most have been seen before. > > We take a little step forward by passing the dsa

Re: [PATCH 1/2] [v4] net: emac: emac gigabit ethernet controller driver

2016-04-13 Thread kbuild test robot
Hi Gilad, [auto build test WARNING on net/master] [also build test WARNING on v4.6-rc3 next-20160413] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Timur-Tabi/net-emac-emac-gigabit-ethernet

Re: [RESEND PATCH net-next] phy: keep the BCMR_LOOPBACK bit while setup forced mode

2016-04-13 Thread Florian Fainelli
On 13/04/16 04:59, Weidong Wang wrote: > When tested the PHY SGMII Loopback,: > 1.set the LOOPBACK bit, > 2.set the autoneg to AUTONEG_DISABLE, it calls the > genphy_setup_forced which will clear the bit. > > So just keep the LOOPBACK bit while setup forced mode. Humm, it makes sense why we want

Re: qdisc spin lock

2016-04-13 Thread Michael Ma
2016-03-31 20:44 GMT-07:00 John Fastabend : > On 16-03-31 04:48 PM, Michael Ma wrote: >> I didn't really know that multiple qdiscs can be isolated using MQ so >> that each txq can be associated with a particular qdisc. Also we don't >> really have multiple interfaces... >

pull-request: wireless-drivers 2016-04-13

2016-04-13 Thread Kalle Valo
Hi Dave, few very small fixes for 4.6. All but one are either build fixes or memory leaks. More info in the signed tag below. Please let me know if there are any problems. Kalle The following changes since commit 9a3492194eca6253ae7ba93c7a402cecad7f1c94: Merge branch

[PATCH nf] netfilter: ipv6: Orphan skbs in nf_ct_frag6_gather()

2016-04-13 Thread Joe Stringer
This is the IPv6 equivalent of commit 8282f27449bf ("inet: frag: Always orphan skbs inside ip_defrag()"). Prior to commit 029f7f3b8701 ("netfilter: ipv6: nf_defrag: avoid/free clone operations"), ipv6 fragments sent to nf_ct_frag6_gather() would be cloned (implicitly orphaning) prior to queueing

[PATCH 2/2] MAINTAINERS: add Qualcomm EMAC network driver maintainer

2016-04-13 Thread Timur Tabi
The driver was originally written by Gilad Avidov, but it's now being supported by Timur Tabi. Signed-off-by: Timur Tabi --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4851f02..8c580f8 100644 --- a/MAINTAINERS +++

  1   2   >