The USB to ethernet can be detached and free netdev after
rtnl mutex is released. It can cause null reference during
the dynamic IP configuration.
sequence is:
ic_open_devs
rtnl_lock();
wait for a carrier
hub_event()
I forgot to change the variable in the conditional, too.
Fixes: 8fe58d58941f4 ("iplink: Check address length via netlink")
Signed-off-by: Phil Sutter
---
ip/iplink.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/iplink.c b/ip/iplink.c
index
On 2016年06月22日 00:44, Michael S. Tsirkin wrote:
On Tue, May 24, 2016 at 05:36:22PM +0800, Jason Wang wrote:
This patch tries to implement an device IOTLB for vhost. This could be
used with for co-operation with userspace IOMMU implementation (qemu)
for a secure DMA environment (DMAR) in
Currently classification and enqueue is done in a single step.
core acquires the qdisc lock, then calls the ->enqueue() function
of the qdisc.
Its the job of the qdisc and its attached classifiers to figure out what
to do next.
Typically the enqueue function will call tc_classify() to lookup a
Ignore this version please. Fengguang's magic box of tricks spotted a bug in
it.
David
The rxrpc_transport struct is now redundant, given that the rxrpc_peer
struct is now per peer port rather than per peer host, so get rid of it.
Service connection lists are transferred to the rxrpc_peer struct, as is
the conn_lock. Previous patches moved the client connection handling out
of the
here also:
http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite
Tagged thusly:
git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
rxrpc-rewrite-20160622
David
---
Arnd Bergmann (1):
rxrpc: fix uninitialized variabl
Replace accesses of conn->trans->{local,peer} with
conn->params.{local,peer} thus making it easier for a future commit to
remove the rxrpc_transport struct.
This also reduces the number of memory accesses involved.
Signed-off-by: David Howells
---
net/rxrpc/call_event.c
From: Arnd Bergmann
Hashing the peer key was introduced for AF_INET, but gcc
warns about the rxrpc_peer_hash_key function returning uninitialized
data for any other value of srx->transport.family:
net/rxrpc/peer_object.c: In function 'rxrpc_peer_hash_key':
"Exclusive connections" are meant to be used for a single client call and
then scrapped. The idea is to limit the use of the negotiated security
context. The current code, however, isn't doing this: it is instead
restricting the socket to a single virtual connection and doing all the
calls over
Use the IDR facility to allocate client connection IDs on a machine-wide
basis so that each client connection has a unique identifier. When the
connection ID space wraps, we advance the epoch by 1, thereby effectively
having a 62-bit ID space. The IDR facility is then used to look up client
rxrpc_connection_lock shouldn't be accessed as a BH-excluding lock. It's
only accessed in a few places and none of those are in BH-context.
rxrpc_transport::conn_lock, however, *is* a BH-excluding lock and should be
accessed so consistently.
Signed-off-by: David Howells
Allocated rxrpc calls displayed in /proc/net/rxrpc_calls may in future be
on the proc list before they're connected or after they've been
disconnected - in which case they may not have a pointer to a connection
struct that can be used to get data from there.
Deal with this by using stuff from the
Pass a pointer to struct sk_buff rather than struct rxrpc_host_header to
functions so that they can in the future get at transport protocol parameters
rather than just RxRPC parameters.
Signed-off-by: David Howells
---
net/rxrpc/ar-internal.h |6 +++---
Validate the net address given to rxrpc_kernel_begin_call() before using
it.
Whilst this should be mostly unnecessary for in-kernel users, it does clear
the tail of the address struct in case we want to hash or compare the whole
thing.
Signed-off-by: David Howells
---
Define and use a structure to hold connection parameters. This makes it
easier to pass multiple connection parameters around.
Define and use a structure to hold protocol information used to hash a
connection for lookup on incoming packet. Most of these fields will be
disposed of eventually,
Provide refcount helper functions for connections so that the code doesn't
touch local or connection usage counts directly.
Also make it such that local and peer put functions can take a NULL
pointer.
Signed-off-by: David Howells
---
net/rxrpc/af_rxrpc.c |7
Make rxrpc_send_packet() take a connection not a transport as part of the
phasing out of the rxrpc_transport struct.
Whilst we're at it, rename the function to rxrpc_send_data_packet() to
differentiate it from the other packet sending functions.
Signed-off-by: David Howells
This patch tries to implement an device IOTLB for vhost. This could be
used with for co-operation with userspace IOMMU implementation (qemu)
for a secure DMA environment (DMAR) in guest.
The idea is simple. When vhost meets an IOTLB miss, it will request
the assistance of userspace to do the
This patch tries to implement an device IOTLB for vhost. This could be
used with for co-operation with userspace(qemu) implementation of DMA
remapping.
The idea is simple, cache the translation in a software device IOTLB
(which was implemented as interval tree) in vhost and use vhost_net
file
This patch introduces vhost memory accessors which were just wrappers
for userspace address access helpers. This is a requirement for vhost
device iotlb implementation which will add iotlb translations in those
accessors.
Signed-off-by: Jason Wang
---
drivers/vhost/net.c
Current pre-sorted memory region array has some limitations for future
device IOTLB conversion:
1) need extra work for adding and removing a single region, and it's
expected to be slow because of sorting or memory re-allocation.
2) need extra work of removing a large range which may intersect
Kill off the concept of maintaining a bundle of connections to a particular
target service to increase the number of call slots available for any
beyond four for that service (there are four call slots per connection).
This will make cleaning up the connection handling code easier and
facilitate
From: Dan Carpenter
rxrpc_lookup_peer_rcu() and rxrpc_lookup_peer() return NULL on error, never
error pointers, so IS_ERR() can't be used.
Fix three callers of those functions.
Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table and
RCU')
On Wed, Jun 22, 2016 at 11:29 AM CEST, Phil Sutter wrote:
> On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote:
>> On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote:
>> > This big patch was compiled by vimgrepping for memset calls and changing
>> > to
On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote:
>
> 在 2016/6/21 18:32, Andy Shevchenko 写道:
> > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote:
> > > From: Daode Huang
> > >
> > > For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC,
> > > so
Hi Jakub,
On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote:
> On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote:
> > This big patch was compiled by vimgrepping for memset calls and changing
> > to C99 initializer if applicable. One notable exception is the
> >
This patch adds support to do necessary processing
for hardware assisted GRE tunnel GRO packets before
driver delivers them upto the stack.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede_main.c
This patch adds support to do necessary processing
for hardware assisted VXLAN tunnel GRO packets before
driver delivers them upto the stack.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qede/qede.h
This patch actually enables the hardware to perform GRO over
encapsulated Ipv4/Ipv6 packets.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 ++
1 file changed, 2 insertions(+)
diff
This patch exports relevant APIs needed to be used by this driver
to handle hardware assisted encapsulated GRO packets.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
include/net/gre.h | 3 +++
include/net/udp.h | 6
Hi David,
This series adds driver support for the processing of tunnel
[specifically vxlan/geneve/gre tunnels] packets which are
aggregated [GROed] by the hardware before driver passes
such packets upto the stack.
Patch 1 - General infrastructure change
Exported UDP and GRE gro_complete APIs to
Hi Phil,
On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote:
> This big patch was compiled by vimgrepping for memset calls and changing
> to C99 initializer if applicable. One notable exception is the
> initialization of union bpf_attr in tc/tc_bpf.c: changing it would break
>
This patch adds support to do necessary processing
for hardware assisted GENEVE tunnel GRO packets before
driver delivers them upto the stack.
Signed-off-by: Manish Chopra
Signed-off-by: Yuval Mintz
---
Hello Tien Hock
On 6/21/2016 10:46 AM, th...@altera.com wrote:
From: Tien Hock Loh
This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
the dwmac is set to sgmii
Signed-off-by: Tien Hock Loh
IIUC, you are keeping the two timers w/o
(Adding ath6k list)
Chaehyun Lim writes:
> It replaces struct semaphore sem with struct mutex mutex
>
> Reported-by: kbuild test robot
> Signed-off-by: Chaehyun Lim
> ---
> V2: fix build failure reported by kbuild test robot
I
This patch adds support for host driver support for new Xaui
interfaces.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Signed-off-by: Felix Manlunas
Signed-off-by: Raghu
On Mon, Feb 22, 2016 at 11:09 AM, Dmitry Vyukov wrote:
> Hello,
>
> The following program causes a memory leak of an object allocated in
> lapb_register:
>
> // autogenerated by syzkaller (http://github.com/google/syzkaller)
> #include
> #include
> #include
> #include
>
On 21/06/16, Sascha Hauer wrote:
> On Mon, Jun 20, 2016 at 07:14:06PM +0200, Oliver Graute wrote:
> > On 20/06/16, Andrew Lunn wrote:
> > > > {
> > > > pinctrl-names = "default";
> > > > pinctrl-0 = <_enet1>;
> > > > phy-mode = "rmii";
> > > >
This patch introduces 2 changes:
* use mlx5_buf_alloc_node() insteaf of mlx5_buf_alloc() in
mlx5_wq_ll_create
* Update the failure warn messages with _node postfix for mlx5_*_alloc
function names
Signed-off-by: Wang Sheng-Hui
---
Adds support for ddr_timeout during device init.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Signed-off-by: Felix Manlunas
Signed-off-by: Raghu Vatsavayi
We already get child qdisc qlen, we also can get its backlog
so that class dumps can report it.
Also replace qstats by a single drop counter, but move it in
a separate cache line so that drops do not dirty useful cache lines.
Tested:
$ tc -s cl sh dev eth0
class htb 1:1 root leaf 3: prio 0 rate
On 2016/06/21 11:47AM, Thadeu Lima de Souza Cascardo wrote:
> On Tue, Jun 21, 2016 at 09:15:48PM +1000, Michael Ellerman wrote:
> > On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote:
> > > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote:
> > > > On Sun, Jun 19, 2016 at 11:19:14PM
On 2016/06/21 09:04PM, Michael Ellerman wrote:
> On Tue, 2016-06-21 at 12:28 +0530, Naveen N. Rao wrote:
> > On 2016/06/21 09:38AM, Michael Ellerman wrote:
> > > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote:
> > > >
> > > > #include
> > > >
> > > > in bpf_jit_comp64.c
> > > >
> > > >
On 2016/6/22 12:54, Leon Romanovsky wrote:
On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote:
On 2016/6/21 19:28, Leon Romanovsky wrote:
On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote:
On 2016/6/20 21:33, Leon Romanovsky wrote:
On Thu, Jun 16, 2016 at
First patch adds an additional parameter to ->enqueue() qdisc method
so that drops can be done outside of critical section
(after locks are released).
Then fq_codel can have a small optimization to reduce number of cache
lines misses during a drop event
(possibly accumulating hundreds of packets
Javier Martinez Canillas writes:
>>> Patch 3/3 applies cleanly even after dropping patch 2/3.
>>> Is that Ok for you or do you want me to re-resend a v3
>>> with only patches 1/3 and 3/3?
>>
>> I can drop patch 2, no need to resend. Thanks.
>>
>
> I saw that you sent
When qdisc bulk dequeue was added in linux-3.18 (commit
5772e9a3463b "qdisc: bulk dequeue support for qdiscs
with TCQ_F_ONETXQUEUE"), it was constrained to some
specific qdiscs.
With some extra care, we can extend this to all qdiscs,
so that typical traffic shaping solutions can benefit from
Now we defer skb drops, it makes sense to keep a copy
of skb->truesize in struct codel_skb_cb to avoid one
cache line miss per dropped skb in fq_codel_drop(),
to reduce latencies a bit further.
Signed-off-by: Eric Dumazet
---
include/net/codel_qdisc.h | 1 +
Qdisc performance suffers when packets are dropped at enqueue()
time because drops (kfree_skb()) are done while qdisc lock is held,
delaying a dequeue() draining the queue.
Nominal throughput can be reduced by 50 % when this happens,
at a time we would like the dequeue() to proceed as fast as
On Tue, Jun 21, 2016 at 06:15:13PM -0700, Alexei Starovoitov wrote:
> On Tue, Jun 21, 2016 at 05:23:21PM -0700, Martin KaFai Lau wrote:
> > Adds a bpf helper, bpf_skb_in_cgroup, to decide if a skb->sk
> > belongs to a descendant of a cgroup2. It is similar to the
> > feature added in netfilter:
>
This patch has minor changes for proper ptp info retreival.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Signed-off-by: Felix Manlunas
Signed-off-by: Raghu Vatsavayi
This patch adds support for private flags for the driver.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Signed-off-by: Felix Manlunas
Signed-off-by: Raghu Vatsavayi
This patch increases the limits of soft command buffer size and
num command buffers. This patch also has changes for queue macros
and limit related changes for new chips.
Signed-off-by: Derek Chickles
Signed-off-by: Satanand Burla
Dave,
Please consider following patch series for liquidio bug fixes
and updates on top of net-next. Following patches should be
applied in the following order as some of them depend on
earlier patches in the series.
-Raghu.
Raghu Vatsavayi (13):
liquidio: soft command buffer limits
> >
> > - all wilink family needs special init command for entering wspi mode.
> > extra clock cycles should be sent after the spi init command while the
> > cs pin is high.
> > - Use inverted chip select for sending a dummy 4 bytes command that
> > completes the init stage and puts the
201 - 256 of 256 matches
Mail list logo