[PATCH RESEND] ipconfig : Fix null reference to the freed dev_addr

2016-06-22 Thread Chanho Min
The USB to ethernet can be detached and free netdev after rtnl mutex is released. It can cause null reference during the dynamic IP configuration. sequence is: ic_open_devs rtnl_lock(); wait for a carrier hub_event()

[iproute PATCH] Fix MAC address length check

2016-06-22 Thread Phil Sutter
I forgot to change the variable in the conditional, too. Fixes: 8fe58d58941f4 ("iplink: Check address length via netlink") Signed-off-by: Phil Sutter --- ip/iplink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iplink.c b/ip/iplink.c index

Re: [RFC PATCH V3 0/3] basic device IOTLB support

2016-06-22 Thread Jason Wang
On 2016年06月22日 00:44, Michael S. Tsirkin wrote: On Tue, May 24, 2016 at 05:36:22PM +0800, Jason Wang wrote: This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace IOMMU implementation (qemu) for a secure DMA environment (DMAR) in

[PATCH RFC] sched: split classification and enqueue

2016-06-22 Thread Florian Westphal
Currently classification and enqueue is done in a single step. core acquires the qdisc lock, then calls the ->enqueue() function of the qdisc. Its the job of the qdisc and its attached classifiers to figure out what to do next. Typically the enqueue function will call tc_classify() to lookup a

Re: [PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs

2016-06-22 Thread David Howells
Ignore this version please. Fengguang's magic box of tricks spotted a bug in it. David

[PATCH net-next 14/14] rxrpc: Kill off the rxrpc_transport struct

2016-06-22 Thread David Howells
The rxrpc_transport struct is now redundant, given that the rxrpc_peer struct is now per peer port rather than per peer host, so get rid of it. Service connection lists are transferred to the rxrpc_peer struct, as is the conn_lock. Previous patches moved the client connection handling out of the

[PATCH net-next 00/14] rxrpc: Get rid of conn bundle and transport structs

2016-06-22 Thread David Howells
here also: http://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git/log/?h=rxrpc-rewrite Tagged thusly: git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-rewrite-20160622 David --- Arnd Bergmann (1): rxrpc: fix uninitialized variabl

[PATCH net-next 04/14] rxrpc: Replace conn->trans->{local, peer} with conn->params.{local, peer}

2016-06-22 Thread David Howells
Replace accesses of conn->trans->{local,peer} with conn->params.{local,peer} thus making it easier for a future commit to remove the rxrpc_transport struct. This also reduces the number of memory accesses involved. Signed-off-by: David Howells --- net/rxrpc/call_event.c

[PATCH net-next 02/14] rxrpc: fix uninitialized variable use

2016-06-22 Thread David Howells
From: Arnd Bergmann Hashing the peer key was introduced for AF_INET, but gcc warns about the rxrpc_peer_hash_key function returning uninitialized data for any other value of srx->transport.family: net/rxrpc/peer_object.c: In function 'rxrpc_peer_hash_key':

[PATCH net-next 05/14] rxrpc: Fix exclusive connection handling

2016-06-22 Thread David Howells
"Exclusive connections" are meant to be used for a single client call and then scrapped. The idea is to limit the use of the negotiated security context. The current code, however, isn't doing this: it is instead restricting the socket to a single virtual connection and doing all the calls over

[PATCH net-next 08/14] rxrpc: Use IDR to allocate client conn IDs on a machine-wide basis

2016-06-22 Thread David Howells
Use the IDR facility to allocate client connection IDs on a machine-wide basis so that each client connection has a unique identifier. When the connection ID space wraps, we advance the epoch by 1, thereby effectively having a 62-bit ID space. The IDR facility is then used to look up client

[PATCH net-next 07/14] rxrpc: rxrpc_connection_lock shouldn't be a BH lock, but conn_lock is

2016-06-22 Thread David Howells
rxrpc_connection_lock shouldn't be accessed as a BH-excluding lock. It's only accessed in a few places and none of those are in BH-context. rxrpc_transport::conn_lock, however, *is* a BH-excluding lock and should be accessed so consistently. Signed-off-by: David Howells

[PATCH net-next 10/14] rxrpc: Calls displayed in /proc may in future lack a connection

2016-06-22 Thread David Howells
Allocated rxrpc calls displayed in /proc/net/rxrpc_calls may in future be on the proc list before they're connected or after they've been disconnected - in which case they may not have a pointer to a connection struct that can be used to get data from there. Deal with this by using stuff from the

[PATCH net-next 06/14] rxrpc: Pass sk_buff * rather than rxrpc_host_header * to functions

2016-06-22 Thread David Howells
Pass a pointer to struct sk_buff rather than struct rxrpc_host_header to functions so that they can in the future get at transport protocol parameters rather than just RxRPC parameters. Signed-off-by: David Howells --- net/rxrpc/ar-internal.h |6 +++---

[PATCH net-next 09/14] rxrpc: Validate the net address given to rxrpc_kernel_begin_call()

2016-06-22 Thread David Howells
Validate the net address given to rxrpc_kernel_begin_call() before using it. Whilst this should be mostly unnecessary for in-kernel users, it does clear the tail of the address struct in case we want to hash or compare the whole thing. Signed-off-by: David Howells ---

[PATCH net-next 03/14] rxrpc: Use structs to hold connection params and protocol info

2016-06-22 Thread David Howells
Define and use a structure to hold connection parameters. This makes it easier to pass multiple connection parameters around. Define and use a structure to hold protocol information used to hash a connection for lookup on incoming packet. Most of these fields will be disposed of eventually,

[PATCH net-next 12/14] rxrpc: Provide more refcount helper functions

2016-06-22 Thread David Howells
Provide refcount helper functions for connections so that the code doesn't touch local or connection usage counts directly. Also make it such that local and peer put functions can take a NULL pointer. Signed-off-by: David Howells --- net/rxrpc/af_rxrpc.c |7

[PATCH net-next 11/14] rxrpc: Make rxrpc_send_packet() take a connection not a transport

2016-06-22 Thread David Howells
Make rxrpc_send_packet() take a connection not a transport as part of the phasing out of the rxrpc_transport struct. Whilst we're at it, rename the function to rxrpc_send_data_packet() to differentiate it from the other packet sending functions. Signed-off-by: David Howells

[PATCH 0/3] basic device IOTLB support

2016-06-22 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace IOMMU implementation (qemu) for a secure DMA environment (DMAR) in guest. The idea is simple. When vhost meets an IOTLB miss, it will request the assistance of userspace to do the

[PATCH 3/3] vhost: device IOTLB API

2016-06-22 Thread Jason Wang
This patch tries to implement an device IOTLB for vhost. This could be used with for co-operation with userspace(qemu) implementation of DMA remapping. The idea is simple, cache the translation in a software device IOTLB (which was implemented as interval tree) in vhost and use vhost_net file

[PATCH 1/3] vhost: introduce vhost memory accessors

2016-06-22 Thread Jason Wang
This patch introduces vhost memory accessors which were just wrappers for userspace address access helpers. This is a requirement for vhost device iotlb implementation which will add iotlb translations in those accessors. Signed-off-by: Jason Wang --- drivers/vhost/net.c

[PATCH 2/3] vhost: convert pre sorted vhost memory array to interval tree

2016-06-22 Thread Jason Wang
Current pre-sorted memory region array has some limitations for future device IOTLB conversion: 1) need extra work for adding and removing a single region, and it's expected to be slow because of sorting or memory re-allocation. 2) need extra work of removing a large range which may intersect

[PATCH net-next 13/14] rxrpc: Kill the client connection bundle concept

2016-06-22 Thread David Howells
Kill off the concept of maintaining a bundle of connections to a particular target service to increase the number of call slots available for any beyond four for that service (there are four call slots per connection). This will make cleaning up the connection handling code easier and facilitate

[PATCH net-next 01/14] rxrpc: checking for IS_ERR() instead of NULL

2016-06-22 Thread David Howells
From: Dan Carpenter rxrpc_lookup_peer_rcu() and rxrpc_lookup_peer() return NULL on error, never error pointers, so IS_ERR() can't be used. Fix three callers of those functions. Fixes: be6e6707f6ee ('rxrpc: Rework peer object handling to use hash table and RCU')

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Jakub Sitnicki
On Wed, Jun 22, 2016 at 11:29 AM CEST, Phil Sutter wrote: > On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote: >> On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: >> > This big patch was compiled by vimgrepping for memset calls and changing >> > to

Re: [PATCH net-next 10/19] net: hns: bugfix about pfc pause frame statistics

2016-06-22 Thread Andy Shevchenko
On Wed, 2016-06-22 at 09:43 +0800, Yisen Zhuang wrote: > > 在 2016/6/21 18:32, Andy Shevchenko 写道: > > On Tue, 2016-06-21 at 11:56 +0800, Yisen Zhuang wrote: > > > From: Daode Huang > > > > > > For SoC hip06, PFC pause handled in dsaf, while hip05 in XGMAC, > > > so

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Phil Sutter
Hi Jakub, On Wed, Jun 22, 2016 at 11:12:14AM +0200, Jakub Sitnicki wrote: > On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: > > This big patch was compiled by vimgrepping for memset calls and changing > > to C99 initializer if applicable. One notable exception is the > >

[PATCH net-next 4/5] qede: Add support to handle GRE hardware GRO packets

2016-06-22 Thread Manish Chopra
This patch adds support to do necessary processing for hardware assisted GRE tunnel GRO packets before driver delivers them upto the stack. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_main.c

[PATCH net-next 2/5] qede: Add support to handle VXLAN hardware GRO packets

2016-06-22 Thread Manish Chopra
This patch adds support to do necessary processing for hardware assisted VXLAN tunnel GRO packets before driver delivers them upto the stack. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h

[PATCH net-next 5/5] qed: Enable hardware GRO feature for encapsulated packets

2016-06-22 Thread Manish Chopra
This patch actually enables the hardware to perform GRO over encapsulated Ipv4/Ipv6 packets. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_l2.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH net-next 1/5] net: export udp and gre gro_complete() APIs

2016-06-22 Thread Manish Chopra
This patch exports relevant APIs needed to be used by this driver to handle hardware assisted encapsulated GRO packets. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- include/net/gre.h | 3 +++ include/net/udp.h | 6

[PATCH net-next 0/5] qed/qede: Tunnel hardware GRO support

2016-06-22 Thread Manish Chopra
Hi David, This series adds driver support for the processing of tunnel [specifically vxlan/geneve/gre tunnels] packets which are aggregated [GROed] by the hardware before driver passes such packets upto the stack. Patch 1 - General infrastructure change Exported UDP and GRE gro_complete APIs to

Re: [iproute PATCH v2 2/7] Use C99 style initializers everywhere

2016-06-22 Thread Jakub Sitnicki
Hi Phil, On Tue, Jun 21, 2016 at 06:18 PM CEST, Phil Sutter wrote: > This big patch was compiled by vimgrepping for memset calls and changing > to C99 initializer if applicable. One notable exception is the > initialization of union bpf_attr in tc/tc_bpf.c: changing it would break >

[PATCH net-next 3/5] qede: Add support to handle GENEVE hardware GRO packets

2016-06-22 Thread Manish Chopra
This patch adds support to do necessary processing for hardware assisted GENEVE tunnel GRO packets before driver delivers them upto the stack. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz ---

Re: [PATCH V4 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-22 Thread Giuseppe CAVALLARO
Hello Tien Hock On 6/21/2016 10:46 AM, th...@altera.com wrote: From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of the dwmac is set to sgmii Signed-off-by: Tien Hock Loh IIUC, you are keeping the two timers w/o

Re: [PATCH V2 2/2] ath6kl: replace semaphore with mutex

2016-06-22 Thread Valo, Kalle
(Adding ath6k list) Chaehyun Lim writes: > It replaces struct semaphore sem with struct mutex mutex > > Reported-by: kbuild test robot > Signed-off-by: Chaehyun Lim > --- > V2: fix build failure reported by kbuild test robot I

[PATCH net-next 10/13] liquidio: New xaui info

2016-06-22 Thread Raghu Vatsavayi
This patch adds support for host driver support for new Xaui interfaces. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

Re: net: memory leak in lapb_register

2016-06-22 Thread Dmitry Vyukov
On Mon, Feb 22, 2016 at 11:09 AM, Dmitry Vyukov wrote: > Hello, > > The following program causes a memory leak of an object allocated in > lapb_register: > > // autogenerated by syzkaller (http://github.com/google/syzkaller) > #include > #include > #include > #include >

Re: Micrel Phy KSZ8031 clock select setting in dts

2016-06-22 Thread Oliver Graute
On 21/06/16, Sascha Hauer wrote: > On Mon, Jun 20, 2016 at 07:14:06PM +0200, Oliver Graute wrote: > > On 20/06/16, Andrew Lunn wrote: > > > > { > > > > pinctrl-names = "default"; > > > > pinctrl-0 = <_enet1>; > > > > phy-mode = "rmii"; > > > >

[PATCH] net/mlx5: use mlx5_buf_alloc_node insteaf of mlx5_buf_alloc in mlx5_wq_ll_create

2016-06-22 Thread Wang Sheng-Hui
This patch introduces 2 changes: * use mlx5_buf_alloc_node() insteaf of mlx5_buf_alloc() in mlx5_wq_ll_create * Update the failure warn messages with _node postfix for mlx5_*_alloc function names Signed-off-by: Wang Sheng-Hui ---

[PATCH net-next 13/13] liquidio: ddr timeout

2016-06-22 Thread Raghu Vatsavayi
Adds support for ddr_timeout during device init. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 3/4] net_sched: sch_htb: export class backlog in dumps

2016-06-22 Thread Eric Dumazet
We already get child qdisc qlen, we also can get its backlog so that class dumps can report it. Also replace qstats by a single drop counter, but move it in a separate cache line so that drops do not dirty useful cache lines. Tested: $ tc -s cl sh dev eth0 class htb 1:1 root leaf 3: prio 0 rate

Re: [PATCH] ppc: Fix BPF JIT for ABIv2

2016-06-22 Thread Naveen N. Rao
On 2016/06/21 11:47AM, Thadeu Lima de Souza Cascardo wrote: > On Tue, Jun 21, 2016 at 09:15:48PM +1000, Michael Ellerman wrote: > > On Tue, 2016-06-21 at 14:28 +0530, Naveen N. Rao wrote: > > > On 2016/06/20 03:56PM, Thadeu Lima de Souza Cascardo wrote: > > > > On Sun, Jun 19, 2016 at 11:19:14PM

Re: [6/6] ppc: ebpf/jit: Implement JIT compiler for extended BPF

2016-06-22 Thread Naveen N. Rao
On 2016/06/21 09:04PM, Michael Ellerman wrote: > On Tue, 2016-06-21 at 12:28 +0530, Naveen N. Rao wrote: > > On 2016/06/21 09:38AM, Michael Ellerman wrote: > > > On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote: > > > > > > > > #include > > > > > > > > in bpf_jit_comp64.c > > > > > > > >

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

2016-06-22 Thread Wei Hu (Xavier)
On 2016/6/22 12:54, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote: On 2016/6/21 19:28, Leon Romanovsky wrote: On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: On 2016/6/20 21:33, Leon Romanovsky wrote: On Thu, Jun 16, 2016 at

[PATCH net-next 0/4] net_sched: bulk dequeue and deferred drops

2016-06-22 Thread Eric Dumazet
First patch adds an additional parameter to ->enqueue() qdisc method so that drops can be done outside of critical section (after locks are released). Then fq_codel can have a small optimization to reduce number of cache lines misses during a drop event (possibly accumulating hundreds of packets

Re: [PATCH v2 2/3] mwifiex: move .get_tx_power logic to station ioctl file

2016-06-22 Thread Kalle Valo
Javier Martinez Canillas writes: >>> Patch 3/3 applies cleanly even after dropping patch 2/3. >>> Is that Ok for you or do you want me to re-resend a v3 >>> with only patches 1/3 and 3/3? >> >> I can drop patch 2, no need to resend. Thanks. >> > > I saw that you sent

[PATCH net-next 4/4] net_sched: generalize bulk dequeue

2016-06-22 Thread Eric Dumazet
When qdisc bulk dequeue was added in linux-3.18 (commit 5772e9a3463b "qdisc: bulk dequeue support for qdiscs with TCQ_F_ONETXQUEUE"), it was constrained to some specific qdiscs. With some extra care, we can extend this to all qdiscs, so that typical traffic shaping solutions can benefit from

[PATCH net-next 2/4] net_sched: fq_codel: cache skb->truesize into skb->cb

2016-06-22 Thread Eric Dumazet
Now we defer skb drops, it makes sense to keep a copy of skb->truesize in struct codel_skb_cb to avoid one cache line miss per dropped skb in fq_codel_drop(), to reduce latencies a bit further. Signed-off-by: Eric Dumazet --- include/net/codel_qdisc.h | 1 +

[PATCH net-next 1/4] net_sched: drop packets after root qdisc lock is released

2016-06-22 Thread Eric Dumazet
Qdisc performance suffers when packets are dropped at enqueue() time because drops (kfree_skb()) are done while qdisc lock is held, delaying a dequeue() draining the queue. Nominal throughput can be reduced by 50 % when this happens, at a time we would like the dequeue() to proceed as fast as

Re: [PATCH -next 3/4] cgroup: bpf: Add bpf_skb_in_cgroup_proto

2016-06-22 Thread Martin KaFai Lau
On Tue, Jun 21, 2016 at 06:15:13PM -0700, Alexei Starovoitov wrote: > On Tue, Jun 21, 2016 at 05:23:21PM -0700, Martin KaFai Lau wrote: > > Adds a bpf helper, bpf_skb_in_cgroup, to decide if a skb->sk > > belongs to a descendant of a cgroup2. It is similar to the > > feature added in netfilter: >

[PATCH net-next 11/13] liquidio: ptp info

2016-06-22 Thread Raghu Vatsavayi
This patch has minor changes for proper ptp info retreival. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 12/13] liquidio: Support priv flag

2016-06-22 Thread Raghu Vatsavayi
This patch adds support for private flags for the driver. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 01/13] liquidio: soft command buffer limits

2016-06-22 Thread Raghu Vatsavayi
This patch increases the limits of soft command buffer size and num command buffers. This patch also has changes for queue macros and limit related changes for new chips. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla

[PATCH net-next 00/13] liquidio: updates and bug fixes

2016-06-22 Thread Raghu Vatsavayi
Dave, Please consider following patch series for liquidio bug fixes and updates on top of net-next. Following patches should be applied in the following order as some of them depend on earlier patches in the series. -Raghu. Raghu Vatsavayi (13): liquidio: soft command buffer limits

RE: [PATCHv3] wlcore: spi: add wl18xx support

2016-06-22 Thread Reizer, Eyal
> > > > - all wilink family needs special init command for entering wspi mode. > > extra clock cycles should be sent after the spi init command while the > > cs pin is high. > > - Use inverted chip select for sending a dummy 4 bytes command that > > completes the init stage and puts the

<    1   2   3