Re: [PATCH net] sock: fix sendmmsg for partial sendmsg

2016-11-04 Thread Maciej Żenczykowski
Acked-by: Maciej Żenczykowski

[net PATCH] fib_trie: Correct /proc/net/route off by one error

2016-11-04 Thread Alexander Duyck
The display of /proc/net/route has had a couple issues due to the fact that when I originally rewrote most of fib_trie I made it so that the iterator was tracking the next value to use instead of the current. In addition it had an off by 1 error where I was tracking the first piece of data as

Re: [PATCH net-next 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-04 Thread kbuild test robot
Hi Pravin, [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Pravin-B-Shelar/vxlan-General-improvements/20161105-060958 config: i386-randconfig-x077-201644 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save

[PATCH iproute2 4/7] l2tp: fix L2TP_ATTR_{RECV,SEND}_SEQ handling

2016-11-04 Thread Asbjørn Sloth Tønnesen
L2TP_ATTR_RECV_SEQ and L2TP_ATTR_SEND_SEQ are declared as NLA_U8 attributes in the kernel, so let's threat them accordingly. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/ip/ipl2tp.c

[PATCH iproute2 1/7] man: ip-l2tp.8: fix l2spec_type documentation

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 5b7041f..4a3bb20 100644 --- a/man/man8/ip-l2tp.8 +++ b/man/man8/ip-l2tp.8 @@ -239,7 +239,7 @@ find in

[PATCH iproute2 5/7] l2tp: support sequence numbering

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c| 23 +++ man/man8/ip-l2tp.8 | 15 +++ 2 files changed, 38 insertions(+) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index af89e2f..6d00d09 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@

[PATCH iproute2 6/7] l2tp: read IPv6 UDP checksum attributes from kernel

2016-11-04 Thread Asbjørn Sloth Tønnesen
In case of an older kernel that doesn't set L2TP_ATTR_UDP_ZERO_CSUM6_{R,T}X the old hard-coded value is being preserved, since the attribute flag will be missing. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 9 +++-- 1 file changed, 3 insertions(+), 6

[PATCH iproute2 3/7] l2tp: fix integers with too few significant bits

2016-11-04 Thread Asbjørn Sloth Tønnesen
udp6_csum{,_tx,_rx}, tunnel and session are the only ones currently used. recv_seq, send_seq, lns_mode and data_seq are partially implemented in a useless way. Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 18 +- 1 file changed, 9 insertions(+), 9

[PATCH iproute2 2/7] man: ip-l2tp.8: remove non-existent tunnel parameter name

2016-11-04 Thread Asbjørn Sloth Tønnesen
The name parameter is only valid for sessions, not tunnels. Signed-off-by: Asbjørn Sloth Tønnesen --- man/man8/ip-l2tp.8 | 3 --- 1 file changed, 3 deletions(-) diff --git a/man/man8/ip-l2tp.8 b/man/man8/ip-l2tp.8 index 4a3bb20..991d097 100644 --- a/man/man8/ip-l2tp.8 +++

[PATCH iproute2 7/7] l2tp: show tunnel: expose UDP checksum state

2016-11-04 Thread Asbjørn Sloth Tønnesen
Signed-off-by: Asbjørn Sloth Tønnesen --- ip/ipl2tp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/ip/ipl2tp.c b/ip/ipl2tp.c index 8f3268d..27dc184 100644 --- a/ip/ipl2tp.c +++ b/ip/ipl2tp.c @@ -218,9 +218,24 @@ static void

Re: [PATCH net-next RFC WIP] Patch for XDP support for virtio_net

2016-11-04 Thread John Fastabend
On 16-11-03 05:34 PM, Michael S. Tsirkin wrote: > On Thu, Nov 03, 2016 at 04:29:22PM -0700, John Fastabend wrote: >> [...] >> > - when XDP is attached disable all LRO using > VIRTIO_NET_CTRL_GUEST_OFFLOADS_SET > (not used by driver so far, designed to allow dynamic LRO control with

[PATCH net-next 5/5] net: l2tp: fix negative assignment to unsigned int

2016-11-04 Thread Asbjoern Sloth Toennesen
recv_seq, send_seq and lns_mode mode are all defined as unsigned int foo:1; Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_core.c | 2 +- net/l2tp/l2tp_ppp.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/l2tp/l2tp_core.c

[PATCH net-next 1/5] net: l2tp: fix L2TP_ATTR_UDP_CSUM attribute type

2016-11-04 Thread Asbjoern Sloth Toennesen
L2TP_ATTR_UDP_CSUM is a flag, and gets read with nla_get_flag, but it is defined as NLA_U8 in the nla_policy. It appears that this is only publicly used in iproute2, where it's broken, because it's used as a NLA_FLAG, and fails validation as a NLA_U8. The only place it's used as a NLA_U8 is in

[PATCH net-next 2/5] net: l2tp: fix L2TP_ATTR_UDP_ZERO_CSUM6_{RX,TX} attribute types

2016-11-04 Thread Asbjoern Sloth Toennesen
The attributes L2TP_ATTR_UDP_ZERO_CSUM6_RX and L2TP_ATTR_UDP_ZERO_CSUM6_TX are used as flags, but is defined as a u8 in a comment. This patch redocuments them as flags, and adds them to the nla_policy, so they gets validated. The only publicly user, iproute2, already treat these attributes as

[PATCH net-next 3/5] net: l2tp: netlink: l2tp_nl_tunnel_send: set UDP6 checksum flags

2016-11-04 Thread Asbjoern Sloth Toennesen
This patch causes the proper attribute flags to be set, in the case that IPv6 UDP checksums are disabled, so that userspace ie. `ip l2tp show tunnel` knows about it. Signed-off-by: Asbjoern Sloth Toennesen --- net/l2tp/l2tp_netlink.c | 10 ++ 1 file changed, 10

[PATCH net-next 4/5] net: l2tp: cleanup: remove redundant condition

2016-11-04 Thread Asbjoern Sloth Toennesen
These assignments follow this pattern: unsigned int foo:1; struct nlattr *nla = info->attrs[bar]; if (nla) foo = nla_get_flag(nla); /* expands to: foo = !!nla */ This could be simplified to: if (nla) foo = 1; but lets just remove the condition and use the

[PATCH] net-ipv6: on device mtu change do not add mtu to mtu-less routes

2016-11-04 Thread Maciej Żenczykowski
From: Maciej Żenczykowski Routes can specify an mtu explicitly or inherit the mtu from the underlying device - this inheritance is implemented in dst->ops->mtu handlers ip6_mtu() and ip6_blackhole_mtu(). Currently changing the mtu of a device adds mtu explicitly to routes using

Re: [PATCH net] ipv4: update comment to document GSO fragmentation cases.

2016-11-04 Thread Shmulik Ladkani
Hi, On Fri, 4 Nov 2016 12:22:38 -0400 Lance Richardson wrote: > This is a follow-up to commit eb96202f1e34 ("ipv4: allow local > fragmentation in ip_finish_output_gso()"), updating the comment > documenting cases in which fragmentation is needed for egress > GSO packets. >

[PATCH net-next 7/7] vxlan: remove unsed vxlan_dev_dst_port()

2016-11-04 Thread Pravin B Shelar
Signed-off-by: Pravin B Shelar --- include/net/vxlan.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/include/net/vxlan.h b/include/net/vxlan.h index 308adc4..49a5920 100644 --- a/include/net/vxlan.h +++ b/include/net/vxlan.h @@ -281,16 +281,6 @@ struct vxlan_dev

[PATCH net-next 6/7] vxlan: simplify vxlan xmit

2016-11-04 Thread Pravin B Shelar
Existing vxlan xmit function handles two distinct cases. 1. vxlan net device 2. vxlan lwt device. By seperating initilization these two cases the egress path looks better. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 79

[PATCH net-next 2/7] vxlan: simplify exception handling

2016-11-04 Thread Pravin B Shelar
vxlan egress path error handling has became complicated, it need to handle IPv4 and IPv6 tunnel cases. Earlier patch removes vlan handling from vxlan_build_skb(), so vxlan_build_skb does not need to free skb and we can simplify the xmit path by having single error handling for both type of

[PATCH net-next 5/7] vxlan: simplify RTF_LOCAL handling.

2016-11-04 Thread Pravin B Shelar
Avoid code duplicate code for handling RTF_LOCAL routes. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 78 + 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c

[PATCH net-next 4/7] vxlan: improve vxlan route lookup checks.

2016-11-04 Thread Pravin B Shelar
Move route sanity check to respective vxlan[4/6]_get_route functions. This allows us to perform all sanity checks before caching the dst so that we can avoid these checks on subsequent packets. This give move accurate metadata information for packet from fill_metadata_dst(). Signed-off-by: Pravin

[PATCH net-next 0/7] vxlan: General improvements.

2016-11-04 Thread Pravin B Shelar
Following patch series improves vxlan fast path, removes duplicate code and simplifies vxlan xmit code path. Pravin B Shelar (7): vxlan: avoid vlan processing in vxlan device. vxlan: simplify exception handling vxlan: avoid checking socket multiple times. vxlan: improve vxlan route lookup

[PATCH net-next 3/7] vxlan: avoid checking socket multiple times.

2016-11-04 Thread Pravin B Shelar
Check the vxlan socket in vxlan6_getroute(). Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index a1e707f..6435d6a 100644 --- a/drivers/net/vxlan.c +++

[PATCH net-next 1/7] vxlan: avoid vlan processing in vxlan device.

2016-11-04 Thread Pravin B Shelar
VxLan device does not have special handling for vlan taging on egress. Therefore it does not make sense to expose vlan offloading feature. Signed-off-by: Pravin B Shelar --- drivers/net/vxlan.c | 9 + include/linux/if_vlan.h | 16 2 files changed,

Re: [PATCH net] r8152: Fix broken RX checksums.

2016-11-04 Thread Mark Lord
On 16-11-04 09:50 AM, Mark Lord wrote: > Yeah, the device or driver is definitely getting confused with rx_desc > structures. > I added code to check for unlikely rx_desc values, and it found this for > starters: > > rx_desc: 00480801 00480401 00480001 0048fc00 0048f800 0048f400 pkt_len=2045 >

Re: Coding Style: Reverse XMAS tree declarations ?

2016-11-04 Thread Lino Sanfilippo
On 04.11.2016 18:44, Joe Perches wrote: > On Fri, 2016-11-04 at 11:07 -0400, David Miller wrote: >> From: Lino Sanfilippo >> > On 04.11.2016 07:53, Joe Perches wrote: >> >> CHECK:REVERSE_XMAS_TREE: Prefer ordering declarations longest to >> >> shortest >> >> #446: FILE:

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread David VomLehn
On Fri, Nov 04, 2016 at 10:05:15AM -0700, Randy Dunlap wrote: > On 11/03/16 23:53, Joe Perches wrote: > > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: > >> From: Madalin Bucur > >> Date: Wed, 2 Nov 2016 22:17:26 +0200 > >> > >>> This introduces the Freescale Data

[PATCH net] sock: fix sendmmsg for partial sendmsg

2016-11-04 Thread Soheil Hassas Yeganeh
From: Soheil Hassas Yeganeh Do not send the next message in sendmmsg for partial sendmsg invocations. sendmmsg assumes that it can continue sending the next message when the return value of the individual sendmsg invocations is positive. It results in corrupting the data for

Re: [PATCH net-next] sock: do not set sk_err in sock_dequeue_err_skb

2016-11-04 Thread Willem de Bruijn
On Thu, Nov 3, 2016 at 7:10 PM, Hannes Frederic Sowa wrote: > [also cc'ed Andy, albeit this doesn't seem to solve his initial problem, > right? ] Indeed, this does not help disambiguate the source of an error

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Alexander Duyck
On Fri, Nov 4, 2016 at 12:07 PM, Jason Baron wrote: > > > On 11/04/2016 02:43 PM, Alexander Duyck wrote: >> >> On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: >>> >>> From: Jason Baron >>> >>> When read() is called on /proc/net/route

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Jason Baron
On 11/04/2016 02:43 PM, Alexander Duyck wrote: On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: From: Jason Baron When read() is called on /proc/net/route requesting a size that is one entry size (128 bytes) less than m->size or greater, the

Re: [PATCH net 0/6] Mellanox 100G mlx5 fixes 2016-11-04

2016-11-04 Thread David Miller
From: Saeed Mahameed Date: Fri, 4 Nov 2016 01:48:41 +0200 > This series contains six hot fixes of the mlx5 core and mlx5e driver. > > Huy fixed an invalid pointer dereference on initialization flow for when > the selected mlx5 load profile is out of range. > > Or provided

Re: [PATCH net-next resend 00/13] ring reconfiguration and XDP support

2016-11-04 Thread David Miller
From: Jakub Kicinski Date: Thu, 3 Nov 2016 17:11:56 + > This set adds support for ethtool channel API and XDP. Series applied, thank you!

[PATCH net-next 2/2] tcp: no longer hold ehash lock while calling tcp_get_info()

2016-11-04 Thread Eric Dumazet
We had various problems in the past in tcp_get_info() and used specific synchronization to avoid deadlocks. We would like to add more instrumentation points for TCP, and avoiding grabing socket lock in tcp_getinfo() was too costly. Being able to lock the socket allows to provide consistent set

[PATCH net-next 1/2] tcp: shortcut listeners in tcp_get_info()

2016-11-04 Thread Eric Dumazet
Being lockless in tcp_get_info() is hard, because we need to add specific synchronization in TCP fast path, like seqcount. Following patch will change inet_diag_dump_icsk() to no longer hold any lock for non listeners, so that we can properly acquire socket lock in get_tcp_info() and let it

[PATCH net-next 0/2] tcp: tcp_get_info() locking changes

2016-11-04 Thread Eric Dumazet
This short series prepares tcp_get_info() for more detailed infos. In order to not slow down fast path, our goal is to use the normal socket spinlock instead of custom synchronization. All we need to ensure is that tcp_get_info() is not called with ehash lock, which might dead lock, since packet

Re: [PATCH net-next v1 00/10] amd-xgbe: AMD XGBE driver updates 2016-11-03

2016-11-04 Thread David Miller
From: Tom Lendacky Date: Thu, 3 Nov 2016 13:17:28 -0500 > This patch series is targeted at preparing the driver for a new PCI version > of the hardware. After this series is applied, a follow-on series will > introduce the support for the PCI version of the hardware. >

Re: [PATCH net-next v2] net: inet: Support UID-based routing

2016-11-04 Thread David Miller
From: Lorenzo Colitti Date: Fri, 4 Nov 2016 02:23:40 +0900 > This patchset adds support for per-UID routing. Looks great, thanks for all of the hard work. Series applied. Please submit the necessary iproute2 patches, as needed. Thanks again.

Re: [PATCH net] fib_trie: correct /proc/net/route for large read buffer

2016-11-04 Thread Alexander Duyck
On Fri, Nov 4, 2016 at 7:45 AM, Jason Baron wrote: > From: Jason Baron > > When read() is called on /proc/net/route requesting a size that is one > entry size (128 bytes) less than m->size or greater, the resulting output > has missing and/or duplicate

Re: [PATCH net-next v2 00/11] net: dsa: mv88e6xxx: refine port operations

2016-11-04 Thread David Miller
From: Vivien Didelot Date: Fri, 4 Nov 2016 03:23:25 +0100 > The Marvell chips have one internal SMI device per port, containing a > set of registers used to configure a port's link, STP state, default > VLAN or addresses database, etc. > > This patchset

Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Sebastian Frias
Hi David, On 11/04/2016 06:54 PM, David Miller wrote: > From: Sebastian Frias > Date: Fri, 4 Nov 2016 18:02:15 +0100 > >> Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") >> and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal >> delay

[PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Sebastian Frias
Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal delay for tx and rx only") added several RGMII definitions: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and PHY_INTERFACE_MODE_RGMII_TXID to

[PATCH v3 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias

[PATCH v3 0/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
This is v3 of the series, it fixes formatting issues of v2. In v2 of the series, only the second patch: "net: ethernet: nb8800: handle all RGMII definitions" is modified to account for Florian's suggestion. Sebastian Frias (2): net: ethernet: nb8800: Do not apply TX delay at MAC level net:

[PATCH v2 2/2] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Sebastian Frias
Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal delay for tx and rx only") added several RGMII definitions: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and PHY_INTERFACE_MODE_RGMII_TXID to

[PATCH v2 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
The delay can be applied at PHY or MAC level, but since PHY drivers will apply the delay at PHY level when using one of the "internal delay" declinations of RGMII mode (like PHY_INTERFACE_MODE_RGMII_TXID), applying it again at MAC level causes issues. Signed-off-by: Sebastian Frias

[PATCH v2 0/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
This is v2 of the series, only the second patch: "net: ethernet: nb8800: handle all RGMII definitions" is modified to account for Florian's suggestion. Sebastian Frias (2): net: ethernet: nb8800: Do not apply TX delay at MAC level net: ethernet: nb8800: handle all RGMII definitions

[net-next v2 1/7] stmmac: dwmac-sti: remove useless of_node check

2016-11-04 Thread Joachim Eastwood
Since dwmac-sti is a DT only driver checking for OF node is not necessary. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Giuseppe Cavallaro --- drivers/net/ethernet/stmicro/stmmac/dwmac-sti.c | 3 ---

[net-next v2 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-04 Thread Joachim Eastwood
This patch set aims to remove the init/exit callbacks from the dwmac-sti driver and instead use standard PM callbacks. Doing this will also allow us to cleanup the driver. Eventually the init/exit callbacks will be deprecated and removed from all drivers dwmac-* except for dwmac-generic. Drivers

[net-next v2 3/7] stmmac: dwmac-sti: add PM ops and resume function

2016-11-04 Thread Joachim Eastwood
Implement PM callbacks and driver remove in the driver instead of relying on the init/exit hooks in stmmac_platform. This gives the driver more flexibility in how the code is organized. Eventually the init/exit callbacks will be deprecated in favor of the standard PM callbacks and driver remove

[net-next v2 5/7] stmmac: dwmac-sti: move clk_prepare_enable out of init and add error handling

2016-11-04 Thread Joachim Eastwood
Add clock error handling to probe and in the process move clock enabling out of sti_dwmac_init() to make this easier. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Giuseppe Cavallaro ---

[net-next v2 6/7] stmmac: dwmac-sti: clean up and rename sti_dwmac_init

2016-11-04 Thread Joachim Eastwood
Rename sti_dwmac_init to sti_dwmac_set_mode which is a better description for what it really does. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Giuseppe Cavallaro ---

Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread David Miller
From: Sebastian Frias Date: Fri, 4 Nov 2016 18:02:15 +0100 > Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") > and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal > delay for tx and rx only") added several RGMII definitions: >

[net-next v2 7/7] stmmac: dwmac-sti: remove unused priv dev member

2016-11-04 Thread Joachim Eastwood
The dev member of struct sti_dwmac is not used anywhere in the driver so lets just remove it. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Giuseppe Cavallaro ---

[net-next v2 2/7] stmmac: dwmac-sti: remove clk NULL checks

2016-11-04 Thread Joachim Eastwood
Since sti_dwmac_parse_data() sets dwmac->clk to NULL if not clock was provided in DT and NULL is a valid clock there is no need to check for NULL before using this clock. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro Tested-by: Giuseppe

[net-next v2 4/7] stmmac: dwmac-sti: move st,gmac_en parsing to sti_dwmac_parse_data

2016-11-04 Thread Joachim Eastwood
The sti_dwmac_init() function is called both from probe and resume. Since DT properties doesn't change between suspend/resume cycles move parsing of this parameter into sti_dwmac_parse_data() where it belongs. Signed-off-by: Joachim Eastwood Acked-by: Giuseppe Cavallaro

Re: [PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-11-04 Thread 张谦
yes, tipc_l2_device_event() only change MTU of bearer rather than the MTU of link, tipc_enable_l2_media() will be the right place to test a tiny MTU. Qian Sent from my iPhone On 5 Nov 2016, at 00:00, Jon Maloy wrote: >> -Original Message- >> From:

Re: Coding Style: Reverse XMAS tree declarations ?

2016-11-04 Thread Joe Perches
On Fri, 2016-11-04 at 11:07 -0400, David Miller wrote: > From: Lino Sanfilippo > > On 04.11.2016 07:53, Joe Perches wrote: > >> CHECK:REVERSE_XMAS_TREE: Prefer ordering declarations longest to > >> shortest > >> #446: FILE: drivers/net/ethernet/ethoc.c:446: > >> + 

Re: [PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Måns Rullgård
Sebastian Frias writes: > Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") > and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal > delay for tx and rx only") added several RGMII definitions: > PHY_INTERFACE_MODE_RGMII_ID,

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Mason
On 04/11/2016 17:55, Måns Rullgård wrote: > Florian Fainelli writes: > >> On 11/04/2016 08:22 AM, Måns Rullgård wrote: >>> Andrew Lunn writes: >>> On Fri, Nov 04, 2016 at 03:05:00PM +, Måns Rullgård wrote: > Andrew Lunn

Re: Coding Style: Reverse XMAS tree declarations ? (was Re: [PATCH net-next v6 02/10] dpaa_eth: add support for DPAA Ethernet)

2016-11-04 Thread Randy Dunlap
On 11/03/16 23:53, Joe Perches wrote: > On Thu, 2016-11-03 at 15:58 -0400, David Miller wrote: >> From: Madalin Bucur >> Date: Wed, 2 Nov 2016 22:17:26 +0200 >> >>> This introduces the Freescale Data Path Acceleration Architecture >>> +static inline size_t

[PATCH net-next 2/2] RDS: TCP: start multipath acceptor loop at 0

2016-11-04 Thread Sowmini Varadhan
The for() loop in rds_tcp_accept_one() assumes that the 0'th rds_tcp_conn_path is UP and starts multipath accepts at index 1. But this assumption may not always be true: if the 0'th path has failed (ERROR or DOWN state) an incoming connection request should be used to resurrect this path.

[PATCH net-next 0/2] RDS: TCP: bug fixes

2016-11-04 Thread Sowmini Varadhan
A couple of bug fixes identified during testing. Sowmini Varadhan (2): RDS: TCP: report addr/port info based on TCP socket in rds-info RDS: TCP: start multipath acceptor loop at 0 net/rds/tcp.c| 20 +--- net/rds/tcp_listen.c |2 +- 2 files changed, 14

[PATCH net-next 1/2] RDS: TCP: report addr/port info based on TCP socket in rds-info

2016-11-04 Thread Sowmini Varadhan
The socket argument passed to rds_tcp_tc_info() is a PF_RDS socket, so it is incorrect to report the address port info based on rds_getname() as part of TCP state report. Invoke inet_getname() for the t_sock associated with the rds_tcp_connection instead. Signed-off-by: Sowmini Varadhan

[PATCH v2 2/2 ] net: ethernet: nb8800: handle all RGMII definitions

2016-11-04 Thread Sebastian Frias
Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal delay for tx and rx only") added several RGMII definitions: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and PHY_INTERFACE_MODE_RGMII_TXID to

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Måns Rullgård
Florian Fainelli writes: > On 11/04/2016 08:22 AM, Måns Rullgård wrote: >> Andrew Lunn writes: >> >>> On Fri, Nov 04, 2016 at 03:05:00PM +, Måns Rullgård wrote: Andrew Lunn writes: >>> I agree with you. But fixing it is

Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Måns Rullgård
Florian Fainelli writes: > On 11/04/2016 08:36 AM, Sebastian Frias wrote: >> Hi Måns, >> >> On 11/04/2016 04:18 PM, Måns Rullgård wrote: >>> Sebastian Frias writes: >>> The delay can be applied at PHY or MAC level, but since PHY drivers will

[PATCH for-next 05/11] IB/hns: Modify the condition of notifying hardware loopback

2016-11-04 Thread Salil Mehta
From: Lijun Ou This patch modified the condition of notifying hardware loopback. In hip06, RoCE Engine has several ports, one QP is related to one port. hardware only support loopback in the same port, not in the different ports. So, If QP related to port N, the dmac in the

[PATCH for-next 06/11] IB/hns: Fix the bug for qp state in hns_roce_v1_m_qp()

2016-11-04 Thread Salil Mehta
From: Lijun Ou In old code, the value of qp state from qpc was assigned for attr->qp_state. The value may be an error while attr_mask & IB_QP_STATE is zero. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by:

[PATCH for-next 00/11] Code improvements & fixes for HNS RoCE driver

2016-11-04 Thread Salil Mehta
This patchset introduces some code improvements and fixes for the identified problems in the HNS RoCE driver. Lijun Ou (4): IB/hns: Add the interface for querying QP1 IB/hns: add self loopback for CM IB/hns: Modify the condition of notifying hardware loopback IB/hns: Fix the bug for qp

[PATCH for-next 02/11] IB/hns: Add code for refreshing CQ CI using TPTR

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch added the code for refreshing CQ CI using TPTR in hip06 SoC. We will send a doorbell to hardware for refreshing CQ CI when user succeed to poll a cqe. But it will be failed if the doorbell has been blocked. So hardware will read a

[PATCH for-next 04/11] IB/hns: add self loopback for CM

2016-11-04 Thread Salil Mehta
From: Lijun Ou This patch mainly adds self loopback support for CM. Signed-off-by: Lijun Ou Signed-off-by: Peter Chen Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta ---

Re: Ethernet not working on a different SoC with same eth HW

2016-11-04 Thread Florian Fainelli
On 11/04/2016 08:22 AM, Måns Rullgård wrote: > Andrew Lunn writes: > >> On Fri, Nov 04, 2016 at 03:05:00PM +, Måns Rullgård wrote: >>> Andrew Lunn writes: >>> >> I agree with you. But fixing it is likely to break boards which >> currently have

[PATCH for-next 07/11] IB/hns: Modify the macro for the timeout when cmd process

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the macro for the timeout when cmd is processing as follows: Before modification: enum { HNS_ROCE_CMD_TIME_CLASS_A = 1, HNS_ROCE_CMD_TIME_CLASS_B = 1, HNS_ROCE_CMD_TIME_CLASS_C

[PATCH for-next 09/11] IB/hns: Change qpn allocation to round-robin mode.

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" When using CM to establish connections, qp number that was freed just now will be rejected by ib core. To fix these problem, We change qpn allocation to round-robin mode. We added the round-robin mode for allocating resources using bitmap. We use

[PATCH for-next 01/11] IB/hns: Add the interface for querying QP1

2016-11-04 Thread Salil Mehta
From: Lijun Ou In old code, It only added the interface for querying non-specific QP. This patch mainly adds an interface for querying QP1. Signed-off-by: Lijun Ou Reviewed-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta

[PATCH for-next 03/11] IB/hns: Optimize the logic of allocating memory using APIs

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the logic of allocating memory using APIs in hns RoCE driver. We used kcalloc instead of kmalloc_array and bitmap_zero. And When kcalloc failed, call vzalloc to alloc memory. Signed-off-by: Wei Hu (Xavier)

[PATCH for-next 11/11] IB/hns: Fix for Checkpatch.pl comment style errors

2016-11-04 Thread Salil Mehta
This patch correct the comment style errors caught by checkpatch.pl script Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_cmd.c|8 ++-- drivers/infiniband/hw/hns/hns_roce_device.h | 28 +++--- drivers/infiniband/hw/hns/hns_roce_eq.c

[PATCH for-next 08/11] IB/hns: Modify query info named port_num when querying RC QP

2016-11-04 Thread Salil Mehta
From: "Wei Hu (Xavier)" This patch modified the output query info qp_attr->port_num to fix bug in hip06. Signed-off-by: Wei Hu (Xavier) Signed-off-by: Salil Mehta --- drivers/infiniband/hw/hns/hns_roce_hw_v1.c |4

[PATCH for-next 10/11] IB/hns: Implement the add_gid/del_gid and optimize the GIDs management

2016-11-04 Thread Salil Mehta
From: Shaobo Xu IB core has implemented the calculation of GIDs and the management of GID tables, and it is now responsible to supply query function for GIDs. So the calculation of GIDs and the management of GID tables in the RoCE driver is redundant. The patch is to

Re: [PATCH v6 7/7] arm64: dts: NS2: add AMAC ethernet support

2016-11-04 Thread Jon Mason
On Fri, Nov 04, 2016 at 04:31:40PM +0300, Sergei Shtylyov wrote: > Hello. > > On 11/4/2016 8:11 AM, Jon Mason wrote: > > >Add support for the AMAC ethernet to the Broadcom Northstar2 SoC device > >tree > > > >Signed-off-by: Jon Mason > >--- > >

Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations

2016-11-04 Thread Sebastian Frias
On 11/04/2016 05:23 PM, Florian Fainelli wrote: > > > On 11/04/2016 08:05 AM, Sebastian Frias wrote: >> Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") >> and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal >> delay for tx and rx only") added several

Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Florian Fainelli
On 11/04/2016 08:36 AM, Sebastian Frias wrote: > Hi Måns, > > On 11/04/2016 04:18 PM, Måns Rullgård wrote: >> Sebastian Frias writes: >> >>> The delay can be applied at PHY or MAC level, but since >>> PHY drivers will apply the delay at PHY level when using >>> one of the

Re: [PATCH net-next v4 3/9] ipv6: sr: add support for SRH encapsulation and injection with lwtunnels

2016-11-04 Thread Tom Herbert
On Fri, Nov 4, 2016 at 3:29 AM, David Lebrun wrote: > This patch creates a new type of interfaceless lightweight tunnel (SEG6), > enabling the encapsulation and injection of SRH within locally emitted > packets and forwarded packets. > > From a configuration viewpoint,

Re: [PATCH 2/2] net: ethernet: nb8800: handle all RGMII declinations

2016-11-04 Thread Florian Fainelli
On 11/04/2016 08:05 AM, Sebastian Frias wrote: > Commit a999589ccaae ("phylib: add RGMII-ID interface mode definition") > and commit 7d400a4c5897 ("phylib: add PHY interface modes for internal > delay for tx and rx only") added several RGMII declinations: > PHY_INTERFACE_MODE_RGMII_ID,

[PATCH net] ipv4: update comment to document GSO fragmentation cases.

2016-11-04 Thread Lance Richardson
This is a follow-up to commit eb96202f1e34 ("ipv4: allow local fragmentation in ip_finish_output_gso()"), updating the comment documenting cases in which fragmentation is needed for egress GSO packets. Suggested-by: Shmulik Ladkani Signed-off-by: Lance Richardson

Re: [PATCH] Documentation: networking: dsa: Update tagging protocols

2016-11-04 Thread Florian Fainelli
On 11/04/2016 05:16 AM, Fabian Mewes wrote: > Add Qualcomm QCA tagging introduced in cafdc45c9 to the > list of supported protocols. > > Signed-off-by: Fabian Mewes Acked-by: Florian Fainelli -- Florian

Re: [PATCH net-next 1/2] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes

2016-11-04 Thread Florian Fainelli
On 11/04/2016 08:51 AM, Neil Armstrong wrote: > In order to support PHY switching on Amlogic GXL SoCs, add support for > 16bit and 32bit registers sizes. > > Reviewed-by: Andrew Lunn > Signed-off-by: Neil Armstrong Reviewed-by: Florian Fainelli

Re: [PATCH net-next 2/2] net: phy: Add Meson GXL Internal PHY driver

2016-11-04 Thread Florian Fainelli
On 11/04/2016 08:51 AM, Neil Armstrong wrote: > Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. > > This PHY seems to only implement some standard registers and need some > workarounds to provide autoneg values from vendor registers. > > Some magic values are

Re: [net-next PATCH 0/7] stmmac: dwmac-sti refactor+cleanup

2016-11-04 Thread Joachim Eastwood
Hi Giuseppe, On 4 November 2016 at 14:49, Giuseppe CAVALLARO wrote: > Hello Joachim. > > I have tested the patches on STiH390 with GMAC4 and the driver is ok. > > So you can add my Acked-by/Tested-by in the V2. Thanks! I'll send a V2 later today or tomorrow. > I just

RE: [PATCH net] tipc: Guard against tiny MTU in tipc_msg_build()

2016-11-04 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of ?? > Sent: Friday, 04 November, 2016 03:24 > To: Jon Maloy ; Ben Hutchings > ; Ying Xue > Cc:

[PATCH net-next 0/2] ARM64: Add Internal PHY support for Meson GXL

2016-11-04 Thread Neil Armstrong
The Amlogic Meson GXL SoCs have an internal RMII PHY that is muxed with the external RGMII pins. In order to support switching between the two PHYs links, extended registers size for mdio-mux-mmioreg must be added. The DT related patches submitted as RFC in [3] will be sent in a separate

[PATCH net-next 1/2] net: mdio-mux-mmioreg: Add support for 16bit and 32bit register sizes

2016-11-04 Thread Neil Armstrong
In order to support PHY switching on Amlogic GXL SoCs, add support for 16bit and 32bit registers sizes. Reviewed-by: Andrew Lunn Signed-off-by: Neil Armstrong --- .../devicetree/bindings/net/mdio-mux-mmioreg.txt | 4 +-

[PATCH net-next 2/2] net: phy: Add Meson GXL Internal PHY driver

2016-11-04 Thread Neil Armstrong
Add driver for the Internal RMII PHY found in the Amlogic Meson GXL SoCs. This PHY seems to only implement some standard registers and need some workarounds to provide autoneg values from vendor registers. Some magic values are currently used to configure the PHY, and this a temporary setup

Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
Hi Andrew, On 11/04/2016 04:11 PM, Andrew Lunn wrote: > On Fri, Nov 04, 2016 at 04:02:24PM +0100, Sebastian Frias wrote: >> The delay can be applied at PHY or MAC level, but since >> PHY drivers will apply the delay at PHY level when using >> one of the "internal delay" declinations of RGMII mode

Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Sebastian Frias
Hi Måns, On 11/04/2016 04:18 PM, Måns Rullgård wrote: > Sebastian Frias writes: > >> The delay can be applied at PHY or MAC level, but since >> PHY drivers will apply the delay at PHY level when using >> one of the "internal delay" declinations of RGMII mode >> (like

Re: [PATCH 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level

2016-11-04 Thread Måns Rullgård
Andrew Lunn writes: > On Fri, Nov 04, 2016 at 04:02:24PM +0100, Sebastian Frias wrote: >> The delay can be applied at PHY or MAC level, but since >> PHY drivers will apply the delay at PHY level when using >> one of the "internal delay" declinations of RGMII mode >> (like

Re: [PATCH (net.git) 0/3] stmmac: fix PTP support

2016-11-04 Thread David Miller
From: Giuseppe CAVALLARO Date: Fri, 4 Nov 2016 14:53:09 +0100 > the series have some Acked-by, do you prefer a new > series (I can rebase them if you ask me) or you can keep > this one? Or you have some advice or issue to warn? If it's not in an "Action Required" state

  1   2   >