Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Tue, Jan 17, 2017 at 1:08 AM, Ariel Levkovich wrote: > + MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, > > It's there. I'll look, but please bring a cake to the office, we started doing that in order to prevent people from replying in top posting to linux mailing list. Or.

Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Tue, Jan 17, 2017 at 1:08 AM, Ariel Levkovich wrote: > + MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, > > It's there. It would be good to spare few words on that aspect in the change log.

Re: fq_codel and skb->hash

2017-01-16 Thread Tom Herbert
On Mon, Jan 16, 2017 at 6:34 PM, Eric Dumazet wrote: > On Mon, 2017-01-16 at 17:44 -0800, Eric Dumazet wrote: >> On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > >> > Is there a better way to manage flow separation in routed+encapsulated >> > traffic? >> >>

[PATCH] bpf: Fix test_lru_sanity5() in test_lru_map.c

2017-01-16 Thread Martin KaFai Lau
test_lru_sanity5() fails when the number of online cpus is fewer than the number of possible cpus. It can be reproduced with qemu by using cmd args "--smp cpus=2,maxcpus=8". The problem is the loop in test_lru_sanity5() is testing 'i' which is incorrect. This patch: 1. Make sched_next_online()

[PATCH net] lwtunnel: fix autoload of lwt modules

2017-01-16 Thread David Ahern
Trying to add an mpls encap route when the MPLS modules are not loaded hangs. For example: CONFIG_MPLS=y CONFIG_NET_MPLS_GSO=m CONFIG_MPLS_ROUTING=m CONFIG_MPLS_IPTUNNEL=m $ ip route add 10.10.10.10/32 encap mpls 100 via inet 10.100.1.2 The ip command hangs: root 880

[no subject]

2017-01-16 Thread Andy Lutomirski
;; This buffer is for text that is not saved, and for Lisp evaluation. ;; To create a file, visit it with C-x C-f and enter text in its buffer. On Sun, Jan 15, 2017 at 5:19 PM, Tejun Heo wrote: > Hello, > > Sorry about the delay. Some fire fighthing followed the holidays. > >

Re: [PATCHv3 net-next 2/7] sctp: add support for generating stream reconf ssn reset request chunk

2017-01-16 Thread Xin Long
On Mon, Jan 16, 2017 at 11:56 AM, Xin Long wrote: > On Sun, Jan 15, 2017 at 11:51 PM, Marcelo Ricardo Leitner > wrote: >> On Sat, Jan 14, 2017 at 03:15:36AM +0800, Xin Long wrote: >>> This patch is to add asoc strreset_outseq and strreset_inseq

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread Richard Guy Briggs
On 2017-01-16 13:27, David Miller wrote: > From: Richard Guy Briggs > Date: Fri, 13 Jan 2017 04:51:48 -0500 > > > diff --git a/include/linux/audit.h b/include/linux/audit.h > > index 9d4443f..43d8003 100644 > > --- a/include/linux/audit.h > > +++ b/include/linux/audit.h > > @@

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread Richard Guy Briggs
On 2017-01-16 15:04, Paul Moore wrote: > On Fri, Jan 13, 2017 at 9:42 AM, Eric Paris wrote: > > On Fri, 2017-01-13 at 04:51 -0500, Richard Guy Briggs wrote: > >> diff --git a/include/linux/audit.h b/include/linux/audit.h > >> index 9d4443f..43d8003 100644 > >> ---

Re: [PATCHv3 net-next 1/7] sctp: add a common helper function to generate stream reconf chunk

2017-01-16 Thread Xin Long
On Tue, Jan 17, 2017 at 2:50 AM, David Miller wrote: > From: Xin Long > Date: Sat, 14 Jan 2017 03:15:35 +0800 > >> diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c >> index a15d824..fd58097 100644 >> --- a/net/sctp/sm_make_chunk.c >> +++

Re: [PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Mon, Jan 16, 2017 at 02:58:19PM -0500, David Miller wrote: > From: Shyam Saini > Date: Tue, 17 Jan 2017 00:21:38 +0530 > > > Use eth_zero_addr to assign zero address to the given address array > > instead of memset when the second argument in memset is address > > of

Re: [PATCH] stmicro: rename it to dwc to improve future development

2017-01-16 Thread kbuild test robot
Hi Joao, [auto build test WARNING on net-next/master] [also build test WARNING on next-20170116] [cannot apply to v4.10-rc4] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Joao-Pinto/stmicro

[GIT] Networking

2017-01-16 Thread David Miller
1) Handle multicast packets properly in fast-RX path of mac80211, from Johannes Berg. 2) Because of a logic bug, the user can't actually force SW checksumming on r8152 devices. This makes diagnosis of hw checksumming bugs really annoying. Fix from Hayes Wang. 3) VXLAN route lookup

Re: fq_codel and skb->hash

2017-01-16 Thread Eric Dumazet
On Mon, 2017-01-16 at 17:44 -0800, Eric Dumazet wrote: > On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > > Is there a better way to manage flow separation in routed+encapsulated > > traffic? > > Encapsulated traffic is fine, since flow dissector skips encap header(s) > up to the L4

[PATCH net-next 1/1] net: ping: Use right format specifier to avoid type casting

2017-01-16 Thread fgao
From: Gao Feng The inet_num is u16, so use %hu instead of casting it to int. And the sk_bound_dev_if is int actually, so it needn't cast to int. Signed-off-by: Gao Feng --- net/ipv4/ping.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-16 Thread David Ahern
On 1/16/17 5:51 PM, David Miller wrote: > From: David Ahern > Date: Sun, 15 Jan 2017 12:07:04 -0800 > >> @@ -2143,6 +2143,26 @@ int ip6_del_rt(struct rt6_info *rt) >> return __ip6_del_rt(rt, ); >> } >> >> +/* called with table lock held */ > ... >> @@ -2176,10

Re: fq_codel and skb->hash

2017-01-16 Thread Eric Dumazet
On Mon, 2017-01-16 at 17:04 -0700, Andrew Collins wrote: > The fq_codel packet scheduler always regenerates the skb flow hash. Is there > any reason > to do this other than the recent hash perturbation additions? > > I ask because I have a case where an incoming set of TCP flows is >

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-16 Thread David Ahern
On 1/16/17 6:37 PM, David Miller wrote: > Is it clear now? yes. time for a trip to the eye doctor

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-16 Thread David Miller
From: David Ahern Date: Mon, 16 Jan 2017 18:27:36 -0700 > On 1/16/17 5:51 PM, David Miller wrote: >> From: David Ahern >> Date: Sun, 15 Jan 2017 12:07:04 -0800 >> >>> @@ -2143,6 +2143,26 @@ int ip6_del_rt(struct rt6_info *rt) >>> return

Re: [PATCH v2 net-next 0/2] mvneta xmit_more and bql support

2017-01-16 Thread David Miller
From: Marcin Wojtas Date: Mon, 16 Jan 2017 18:08:30 +0100 > This is a delayed v2 of short patchset, which introduces xmit_more and BQL > to mvneta driver. The only one change was added in xmit_more support - > condition check preventing excessive descriptors concatenation

Re: [PATCH net-next v2 1/3] net: ipv6: Allow shorthand delete of all nexthops in multipath route

2017-01-16 Thread David Miller
From: David Ahern Date: Sun, 15 Jan 2017 12:07:04 -0800 > @@ -2143,6 +2143,26 @@ int ip6_del_rt(struct rt6_info *rt) > return __ip6_del_rt(rt, ); > } > > +/* called with table lock held */ ... > @@ -2176,10 +2196,9 @@ static int ip6_route_del(struct

Re: [PATCH net 1/1] net sched actions: fix refcnt when GETing of action after bind

2017-01-16 Thread David Miller
From: Jamal Hadi Salim Date: Sun, 15 Jan 2017 10:14:06 -0500 > From: Jamal Hadi Salim ... > Fixes: aecc5cefc389 ("net sched actions: fix GETing actions") > Signed-off-by: Jamal Hadi Salim Applied and queued up for -stable, thanks

RE: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-16 Thread YUAN Linyu
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Tuesday, January 17, 2017 5:54 AM > To: f.faine...@gmail.com > Cc: cug...@163.com; and...@lunn.ch; netdev@vger.kernel.org; YUAN Linyu > Subject: Re: [PATCH] net: add regs attribute to phy device for user

fq_codel and skb->hash

2017-01-16 Thread Andrew Collins
The fq_codel packet scheduler always regenerates the skb flow hash. Is there any reason to do this other than the recent hash perturbation additions? I ask because I have a case where an incoming set of TCP flows is encapsulated in a single ipsec tunnel, which is then classified on egress

[PATCH 1/1] ip: fix igmp parsing when iface is long

2017-01-16 Thread Petr Vorel
Entries with long vhost names in /proc/net/igmp have no whitespace between name and colon, so sscanf() adds it to vhost and 'ip maddr show iface' doesn't include inet result. Signed-off-by: Petr Vorel --- ip/ipmaddr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[PATCH net] vxlan: fix byte order of vxlan-gpe port number

2017-01-16 Thread Lance Richardson
vxlan->cfg.dst_port is in network byte order, so an htons() is needed here. Also reduced comment length to stay closer to 80 column width (still slightly over, however). Fixes: e1e5314de08b ("vxlan: implement GPE") Signed-off-by: Lance Richardson --- drivers/net/vxlan.c | 2

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Mon, Jan 16, 2017 at 11:06 PM, Tom Herbert wrote: > On Mon, Jan 16, 2017 at 12:30 PM, Saeed Mahameed > wrote: >> On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed >> wrote: >>> On Fri, Jan 13, 2017 at 7:14 PM, David

[PATCH net-next] bridge: sparse fixes in br_ip6_multicast_alloc_query()

2017-01-16 Thread Lance Richardson
Changed type of csum field in struct igmpv3_query from __be16 to __sum16 to eliminate type warning, made same change in struct igmpv3_report for consistency. Fixed up an ntohs() where htons() should have been used instead. Signed-off-by: Lance Richardson ---

RE: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Ariel Levkovich
+ MLX4_PTYS_AN_DISABLE_CAP = 1 << 5, It's there. Best Regards, Ariel Levkovich Staff Engineer, SW Mellanox Technologies Beit Mellanox, Yokneam, P.O.Box 586, Israel 20692 Office: +972-74723-7652, Mobile: +972-52-3947-704 www.mellanox.com Follow us on Facebook and Twitter >

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Daniel Jurgens
On 1/16/2017 3:59 PM, Or Gerlitz wrote: > On Mon, Jan 16, 2017 at 11:54 PM, Daniel Jurgens wrote: >> On 1/16/2017 3:44 PM, Or Gerlitz wrote: >>> On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: From: Daniel Jurgens

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Tue, 17 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread David Miller
From: Dan Carpenter Date: Tue, 17 Jan 2017 00:56:15 +0300 > (It would be better if one of the stmmac people were responding here > insead of a random fix the indenting weenie like myself.) They are all too busy trying to rename the driver, because that's so much more

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 11:54 PM, Daniel Jurgens wrote: > On 1/16/2017 3:44 PM, Or Gerlitz wrote: >> On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: >>> From: Daniel Jurgens >>> >>> Use CPUs on the close NUMA when setting the

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread David Miller
From: Daniel Jurgens Date: Mon, 16 Jan 2017 21:54:36 + > I don't understand your 2nd sentence there. "Ms installs"? I think he meant "Mellanox's installs", meaning installations of Linux using Mellanox hardware. At least that's how I read it.

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread David Miller
From: Chad Dupuis Date: Mon, 16 Jan 2017 16:47:52 -0500 > I forgot to add netdev-next to the subject line. Is a repost needed > here? Not this time, no.

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Dan Carpenter
On Mon, Jan 16, 2017 at 10:46:22PM +0100, Julia Lawall wrote: > > > On Mon, 16 Jan 2017, Dan Carpenter wrote: > > > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > > From: Dan Carpenter

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread David Miller
From: Paul Moore Date: Mon, 16 Jan 2017 15:38:33 -0500 > David, assuming Richard makes your requested changes, any objection if > I merge this via the audit tree instead of the netdev tree? It's a > bit easier for us from a testing perspective this way ... No objection.

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Daniel Jurgens
On 1/16/2017 3:44 PM, Or Gerlitz wrote: > On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: >> From: Daniel Jurgens >> >> Use CPUs on the close NUMA when setting the EQ affinity hints. > Dan, are we sure there are no down-sides for always doing this?

Re: [net-next 0/3] tipc: improve interaction socket-link

2017-01-16 Thread David Miller
From: Jon Maloy Date: Mon, 16 Jan 2017 20:35:08 + > > >> -Original Message- >> From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] >> On Behalf Of David Miller >> Sent: Monday, 16 January, 2017 14:45 >> To: Jon Maloy

Re: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-16 Thread David Miller
From: Florian Fainelli Date: Mon, 16 Jan 2017 12:22:16 -0800 > On 01/16/2017 04:59 AM, yuan linyu wrote: >> On 日, 2017-01-15 at 18:21 +0100, Andrew Lunn wrote: >>> On Sun, Jan 15, 2017 at 09:51:03AM +0800, yuan linyu wrote: I hope user/developer can read this

Re: [PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 7:30 PM, Tariq Toukan wrote: 0644 > --- a/include/linux/mlx4/device.h > +++ b/include/linux/mlx4/device.h > @@ -1539,8 +1539,13 @@ enum mlx4_ptys_proto { > MLX4_PTYS_EN = 1<<2, > }; > > +enum mlx4_ptys_flags { > +

Re: [PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread Chad Dupuis
I forgot to add netdev-next to the subject line. Is a repost needed here? On Mon, 16 Jan 2017, 7:53pm -, Dupuis, Chad wrote: > From: Arun Easi > > This adds the backbone required for the various HW initalizations > which are necessary for the FCoE driver (qedf) for

[PATCH v2] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. The callback set_link_ksettings no longer update the value of advertising, as the struct ethtool_link_ksettings is defined as const. As I don't have the hardware, I'd be very pleased if

Re: [patch net-next] stmmac: indent an if statement

2017-01-16 Thread Julia Lawall
On Mon, 16 Jan 2017, Dan Carpenter wrote: > On Mon, Jan 16, 2017 at 12:19:24PM +0300, Dan Carpenter wrote: > > On Sun, Jan 15, 2017 at 10:14:38PM -0500, David Miller wrote: > > > From: Dan Carpenter > > > Date: Thu, 12 Jan 2017 21:46:32 +0300 > > > > > > > The break

Re: [PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Or Gerlitz
On Mon, Jan 16, 2017 at 7:29 PM, Tariq Toukan wrote: > From: Daniel Jurgens > > Use CPUs on the close NUMA when setting the EQ affinity hints. Dan, are we sure there are no down-sides for always doing this? this code is probably there for many years

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Philippe Reynes
Hi Stephen, On 1/16/17, Stephen Hemminger wrote: > On Mon, 16 Jan 2017 12:36:17 -0500 (EST) > David Miller wrote: > >> From: Stephen Hemminger >> Date: Mon, 16 Jan 2017 09:29:51 -0800 >> >> > On Sat, 14 Jan 2017

Re: [PATCH v2] net/irda: fix lockdep annotation

2017-01-16 Thread Dmitry Vyukov
On Mon, Jan 16, 2017 at 7:09 PM, kbuild test robot <l...@intel.com> wrote: > Hi Dmitry, > > [auto build test ERROR on tip/locking/core] > [also build test ERROR on v4.10-rc4 next-20170116] > [if your patch is applied to the wrong git tree, please drop us a note to >

[PATCH v3] net/irda: fix lockdep annotation

2017-01-16 Thread Dmitry Vyukov
The current annotation uses a global variable as recursion counter. The variable is not atomic nor protected with a mutex, but mutated by multiple threads. This causes lockdep bug reports episodically: BUG: looking up invalid subclass: 4294967295 ... _raw_spin_lock_irqsave_nested+0x120/0x180

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Tom Herbert
On Mon, Jan 16, 2017 at 12:30 PM, Saeed Mahameed wrote: > On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed > wrote: >> On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: >>> From: Saeed Mahameed

Re: [PATCH] net: constify mdiobb_ops structures

2017-01-16 Thread Sergei Shtylyov
Hello! On 01/13/2017 09:02 PM, Bhumika Goyal wrote: Declare mdiobb_ops structures as const as they are only stored in the ops field of mdiobb_ctrl structures. This field is of type const, so mdiobb_ops structures having this property can be declared const too. Done using Coccinelle: [...]

Re: [PATCH/RFC v2 net-next] ravb: unmap descriptors when freeing rings

2017-01-16 Thread Sergei Shtylyov
Hello! On 01/12/2017 04:18 PM, Simon Horman wrote: ... Here, it stop once an untransmitted buffer is encountered... Yes, I see that now. I wonder if we should: a) paramatise ravb_tx_free() so it may either clear all transmitted buffers (current behaviour) or all buffers (new

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread Paul Moore
On Mon, Jan 16, 2017 at 1:27 PM, David Miller wrote: > From: Richard Guy Briggs > Date: Fri, 13 Jan 2017 04:51:48 -0500 > >> diff --git a/include/linux/audit.h b/include/linux/audit.h >> index 9d4443f..43d8003 100644 >> --- a/include/linux/audit.h >> +++

RE: [net-next 0/3] tipc: improve interaction socket-link

2017-01-16 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > On Behalf Of David Miller > Sent: Monday, 16 January, 2017 14:45 > To: Jon Maloy > Cc: netdev@vger.kernel.org; v...@zeniv.linux.org.uk; Parthasarathy Bhuvaragan >

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Sat, Jan 14, 2017 at 12:07 AM, Saeed Mahameed wrote: > On Fri, Jan 13, 2017 at 7:14 PM, David Miller wrote: >> From: Saeed Mahameed >> Date: Thu, 12 Jan 2017 19:22:34 +0200 >> >>> This pull request includes one patch from

Re: [PATCH] net: add regs attribute to phy device for user diagnose

2017-01-16 Thread Florian Fainelli
On 01/16/2017 04:59 AM, yuan linyu wrote: > On 日, 2017-01-15 at 18:21 +0100, Andrew Lunn wrote: >> On Sun, Jan 15, 2017 at 09:51:03AM +0800, yuan linyu wrote: >>> >>> I hope user/developer can read this attribute file "regs" to do >>> a full check of all registers value, and they can write any

Re: [PATCH net 0/3] mlx4 core fixes

2017-01-16 Thread David Miller
From: Tariq Toukan Date: Mon, 16 Jan 2017 18:31:36 +0200 > This patchset contains bug fixes from Jack to the mlx4 Core driver. > > Patch 1 solves a race in the flow of CQ free. > Patch 2 moves some qp context flags update to the correct qp transition. > Patch 3 eliminates

Re: [pull request][for-next] Mellanox mlx5 Reorganize core driver directory layout

2017-01-16 Thread Saeed Mahameed
On Sat, Jan 14, 2017 at 12:56 AM, Tom Herbert wrote: > On Fri, Jan 13, 2017 at 2:45 PM, Saeed Mahameed > wrote: >> On Sat, Jan 14, 2017 at 12:06 AM, Tom Herbert wrote: >>> Btw, we did hit one issue in the backport. We

[PATCH 1/2] qed: Add support for hardware offloaded FCoE.

2017-01-16 Thread Dupuis, Chad
From: Arun Easi This adds the backbone required for the various HW initalizations which are necessary for the FCoE driver (qedf) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi

[PATCH 0/2] Add QLogic FastLinQ FCoE (qedf) driver

2017-01-16 Thread Dupuis, Chad
From: "Dupuis, Chad" This series introduces the hardware offload FCoE initiator driver for the 41000 Series Converged Network Adapters (579xx chip) by Cavium. The overall driver design includes a common module ('qed') and protocol specific dependent modules ('qedf' for

Re: [PATCH net-next] net/sched: cls_flower: Disallow duplicate internal elements

2017-01-16 Thread David Miller
From: Paul Blakey Date: Mon, 16 Jan 2017 10:45:13 +0200 > Flower currently allows having the same filter twice with the same > priority. Actions (and statistics update) will always execute on the > first inserted rule leaving the second rule unused. > This patch disallows

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread Paul Moore
On Fri, Jan 13, 2017 at 9:42 AM, Eric Paris wrote: > On Fri, 2017-01-13 at 04:51 -0500, Richard Guy Briggs wrote: >> diff --git a/include/linux/audit.h b/include/linux/audit.h >> index 9d4443f..43d8003 100644 >> --- a/include/linux/audit.h >> +++ b/include/linux/audit.h >> @@

Re: [PATCH] net: stmmac: don't use netdev_[dbg, info, ..] before net_device is registered

2017-01-16 Thread David Miller
From: Heiner Kallweit Date: Sun, 15 Jan 2017 19:19:00 +0100 > Don't use netdev_info and friends before the net_device is registered. > This avoids ugly messages like > "meson8b-dwmac c941.ethernet (unnamed net_device) (uninitialized): > Enable RX Mitigation via HW

Re: [PATCH net-next v3 06/10] net: dsa: Migrate to device_find_class()

2017-01-16 Thread Florian Fainelli
On 01/15/2017 11:16 AM, Andrew Lunn wrote: >>> What exactly is the relationship between these devices (a ascii-art tree >>> or sysfs tree output might be nice) so I can try to understand what is >>> going on here. > > Hi Greg, Florian > > A few diagrams and trees which might help understand what

Re: [PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread David Miller
From: Shyam Saini Date: Tue, 17 Jan 2017 00:21:38 +0530 > Use eth_zero_addr to assign zero address to the given address array > instead of memset when the second argument in memset is address > of zero. Also, it makes the code clearer > > Signed-off-by: Shyam Saini

Re: [PATCH net V2] net/mlx5e: Fix a -Wmaybe-uninitialized warning

2017-01-16 Thread David Miller
From: Or Gerlitz Date: Sun, 15 Jan 2017 19:50:46 +0200 > From: Arnd Bergmann > > As found by Olof's build bot, we gain a harmless warning about a > potential uninitialized variable reference in mlx5: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c: In

Re: [PATCH net-next v2] ipv6: sr: add missing Kbuild export for header files

2017-01-16 Thread David Miller
From: David Lebrun Date: Sun, 15 Jan 2017 15:26:16 +0100 > Add missing IPv6-SR header files in include/uapi/linux/Kbuild. > > Also, prevent seg6_lwt_headroom() from being exported and add > missing linux/types.h include. > > Signed-off-by: David Lebrun

Re: [PATCH net-next v3 1/1] net sched actions: Add support for user cookies

2017-01-16 Thread David Miller
Jamal, please don't mix coding style and real changes. Have one patch that adds the user cookies and one that cleans up the coding style stuff. Thanks.

Re: [net-next 0/3] tipc: improve interaction socket-link

2017-01-16 Thread David Miller
From: Jon Maloy Date: Tue, 3 Jan 2017 10:26:45 -0500 > We fix a very real starvation problem that may occur when a link > encounters send buffer congestion. At the same time we make the > interaction between the socket and link layer simpler and more > consistent.

Re: [PATCH net-next] bpf, trace: make ctx access checks more robust

2017-01-16 Thread David Miller
From: Daniel Borkmann Date: Sun, 15 Jan 2017 01:34:25 +0100 > Make sure that ctx cannot potentially be accessed oob by asserting > explicitly that ctx access size into pt_regs for BPF_PROG_TYPE_KPROBE > programs must be within limits. In case some 32bit archs have pt_regs >

Re: [PATCH 1/1] ax25: Fix segfault after sock connection timeout

2017-01-16 Thread David Miller
From: Basil Gunn Date: Sat, 14 Jan 2017 12:18:55 -0800 > The ax.25 socket connection timed out & the sock struct has been > previously taken down ie. sock struct is now a NULL pointer. Checking > the sock_flag causes the segfault. Check if the socket struct pointer > is

Re: [PATCH next] ipvlan: fix dev_id creation corner case.

2017-01-16 Thread David Miller
From: Mahesh Bandewar Date: Fri, 13 Jan 2017 15:48:30 -0800 > From: Mahesh Bandewar > > In the last patch da36e13cf65 ("ipvlan: improvise dev_id generation > logic in IPvlan") I missed some part of Dave's suggestion and because > of that the dev_id

Re: [PATCH net] bpf: rework prog_digest into prog_tag

2017-01-16 Thread David Miller
From: Daniel Borkmann Date: Fri, 13 Jan 2017 23:38:15 +0100 > Commit 7bd509e311f4 ("bpf: add prog_digest and expose it via > fdinfo/netlink") was recently discussed, partially due to > admittedly suboptimal name of "prog_digest" in combination > with sha1 hash usage, thus

Re: [PATCH net-next 0/2] sfc: TX PIO fixes

2017-01-16 Thread David Miller
From: Edward Cree Date: Fri, 13 Jan 2017 21:18:38 + > Edward Cree (2): > sfc: allow PIO more often > sfc: get PIO buffer size from the NIC Both patches applied, thanks. When you give me a completely content free header posting like this, it is basically worthless

Re: [PATCH] stmicro: rename it to dwc to improve future development

2017-01-16 Thread David Miller
From: Joao Pinto Date: Mon, 16 Jan 2017 13:26:31 + > The goal of this patch is to create an oficial Designware Ethernet place > to deploy new drivers based on this family of IPs. stmmac was left > untouched since it is a designware based driver. New ethernet

Re: [PATCH net-next] sctp: remove useless code from sctp_apply_peer_addr_params

2017-01-16 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 13 Jan 2017 18:31:15 -0200 > sctp_frag_point() doesn't store anything, and thus just calling it > cannot do anything useful. > > sctp_apply_peer_addr_params is only called by > sctp_setsockopt_peer_addr_params. When operating

Re: [PATCH net-next] sctp: remove unused var from sctp_process_asconf

2017-01-16 Thread David Miller
From: Marcelo Ricardo Leitner Date: Fri, 13 Jan 2017 18:27:33 -0200 > Assigned but not used. > > Signed-off-by: Marcelo Ricardo Leitner Applied.

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-

Re: [PATCHv3 net-next 1/7] sctp: add a common helper function to generate stream reconf chunk

2017-01-16 Thread David Miller
From: Xin Long Date: Sat, 14 Jan 2017 03:15:35 +0800 > diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c > index a15d824..fd58097 100644 > --- a/net/sctp/sm_make_chunk.c > +++ b/net/sctp/sm_make_chunk.c > @@ -3526,3 +3526,36 @@ struct sctp_chunk

Re: [PATCH][V2] flow dissector: check if arp_eth is null rather than arp

2017-01-16 Thread David Miller
From: Colin King Date: Fri, 13 Jan 2017 18:48:20 + > From: Colin Ian King > > arp is being checked instead of arp_eth to see if the call to > __skb_header_pointer failed. Fix this by checking arp_eth is > null instead of arp. Also fix

Re: [PATCH] net: constify mdiobb_ops structures

2017-01-16 Thread David Miller
From: Bhumika Goyal Date: Fri, 13 Jan 2017 23:32:26 +0530 > Declare mdiobb_ops structures as const as they are only stored in the > ops field of mdiobb_ctrl structures. This field is of type const, so > mdiobb_ops structures having this property can be declared const too.

Re: [PATCH net-next] netlink: do not enter direct reclaim from netlink_trim()

2017-01-16 Thread David Miller
From: Eric Dumazet Date: Fri, 13 Jan 2017 09:11:22 -0800 > From: Eric Dumazet > > In commit d35c99ff77ecb ("netlink: do not enter direct reclaim from > netlink_dump()") we made sure to not trigger expensive memory reclaim. > > Problem is that a bit

Re: [PATCH 1/3] powerpc: bpf: remove redundant check for non-null image

2017-01-16 Thread David Miller
I'm assuming these patches will go via the powerpc tree. If you want them to go into net-next, I kindly ask that you always explicitly say so, and furthermore always submit a patch series with a proper "[PATCH 0/N] ..." header posting. Thanks.

Re: [PATCH V2] audit: log 32-bit socketcalls

2017-01-16 Thread David Miller
From: Richard Guy Briggs Date: Fri, 13 Jan 2017 04:51:48 -0500 > diff --git a/include/linux/audit.h b/include/linux/audit.h > index 9d4443f..43d8003 100644 > --- a/include/linux/audit.h > +++ b/include/linux/audit.h > @@ -387,6 +387,18 @@ static inline int audit_socketcall(int

Re: [PATCH net-next] cxgb4: Shutdown adapter if firmware times out or errors out

2017-01-16 Thread David Miller
From: Hariprasad Shenai Date: Fri, 13 Jan 2017 21:55:26 +0530 > Perform an emergency shutdown of the adapter and stop it from > continuing any further communication on the ports or DMA to the > host. This is typically used when the adapter and/or firmware > have crashed

Re: [PATCH net v1 1/1] tipc: allocate user memory with GFP_KERNEL flag

2017-01-16 Thread David Miller
From: Parthasarathy Bhuvaragan Date: Fri, 13 Jan 2017 15:46:25 +0100 > Until now, we allocate memory always with GFP_ATOMIC flag. > When the system is under memory pressure and a user tries to send, > the send fails due to low memory. However, the user

Re: [PATCH net-next] afs: Conditionalise a new unused variable

2017-01-16 Thread David Miller
From: David Howells Date: Fri, 13 Jan 2017 14:46:19 + > From: Arnd Bergmann > > The bulk readpages support introduced a harmless warning: > > fs/afs/file.c: In function 'afs_readpages_page_done': > fs/afs/file.c:270:20: error: unused variable 'vnode'

Re: [PATCH] net: phy: dp83867: allow RGMII_TXID/RGMII_RXID interface types

2017-01-16 Thread David Miller
From: Murali Karicheri Date: Fri, 13 Jan 2017 09:32:34 -0500 > Currently dp83867 driver returns error if phy interface type > PHY_INTERFACE_MODE_RGMII_RXID is used to set the rx only internal > delay. Similarly issue happens for PHY_INTERFACE_MODE_RGMII_TXID. > Fix this by

Re: [PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread David Miller
From: Shyam Saini Date: Mon, 16 Jan 2017 23:33:30 +0530 > Use eth_zero_addr to assign zero address to the given address array > instead of memset when the second argument in memset is address > of zero. Also, it makes the code clearer > > Signed-off-by: Shyam Saini

Re: [PATCH net] ip6_tunnel: Account for tunnel header in tunnel MTU

2017-01-16 Thread David Miller
From: Jakub Sitnicki Date: Fri, 13 Jan 2017 10:12:20 +0100 > With ip6gre we have a tunnel header which also makes the tunnel MTU > smaller. We need to reserve room for it. Previously we were using up > space reserved for the Tunnel Encapsulation Limit option > header (RFC 2473).

Re: [PATCH v2] net/irda: fix lockdep annotation

2017-01-16 Thread kbuild test robot
Hi Dmitry, [auto build test ERROR on tip/locking/core] [also build test ERROR on v4.10-rc4 next-20170116] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Dmitry-Vyukov/net-irda-fix-lockdep

[PATCH] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
Use eth_zero_addr to assign zero address to the given address array instead of memset when the second argument in memset is address of zero. Also, it makes the code clearer Signed-off-by: Shyam Saini --- drivers/net/ethernet/qlogic/qed/qed_l2.c| 2 +-

Re: [PATCH iproute2 1/1] utils: make hex2mem available to all users

2017-01-16 Thread Stephen Hemminger
On Sat, 14 Jan 2017 17:09:58 -0500 Jamal Hadi Salim wrote: > Sorry, messed up Stephen's address. Resending.. > > cheers, > jamal No problem. I get almost all patches only from patchwork anyway.

Re: [PATCH] net: marvell: skge: use new api ethtool_{get|set}_link_ksettings

2017-01-16 Thread Stephen Hemminger
On Mon, 16 Jan 2017 12:36:17 -0500 (EST) David Miller wrote: > From: Stephen Hemminger > Date: Mon, 16 Jan 2017 09:29:51 -0800 > > > On Sat, 14 Jan 2017 13:08:28 +0100 > > Philippe Reynes wrote: > > > >> The ethtool api

Re: [PATCH net] mld: do not remove mld souce list info when set link down

2017-01-16 Thread David Miller
From: Hangbin Liu Date: Thu, 12 Jan 2017 21:19:37 +0800 > This is an IPv6 version of commit 24803f38a5c0 ("igmp: do not remove igmp > souce list..."). In mld_del_delrec(), we will restore back all source filter > info instead of flush them. > > Move mld_clear_delrec() from

Re: [PATCH net-next 3/3] net: ipv6: Add option to dump multipath routes via RTA_MULTIPATH attribute

2017-01-16 Thread David Ahern
upon further review ... On 1/15/17 1:07 PM, David Ahern wrote: > To maintain backwards compatibility, a user has to request the change > in behavior. Unfortunately, adding a flag to the header similar to a > previous patch does not work here as the netlink header for route dumps > can be either

Re: [PATCH 1/2] qed: Replace memset with eth_zero_addr

2017-01-16 Thread Shyam Saini
On Mon, Jan 16, 2017 at 11:46:06AM -0500, David Miller wrote: > From: Shyam Saini > Date: Mon, 16 Jan 2017 14:54:35 +0530 > > > On Sun, Jan 15, 2017 at 11:38:30PM -0500, David Miller wrote: > >> > >> Please do not ever submit two patches which have the same exact commit

[PATCH net-next 1/9] net/mlx4: Replace ENOSYS with better fitting error codes

2017-01-16 Thread Tariq Toukan
Conform the following warning: WARNING: ENOSYS means 'invalid syscall nr' and nothing else. Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 2 +- drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-

[PATCH net-next 3/9] net/mlx4_core: Set EQ affinity hint to local NUMA CPUs

2017-01-16 Thread Tariq Toukan
From: Daniel Jurgens Use CPUs on the close NUMA when setting the EQ affinity hints. Signed-off-by: Daniel Jurgens Signed-off-by: Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/main.c | 3 ++- 1 file changed, 2

[PATCH net-next 6/9] net/mlx4_en: Adding support of turning off link autonegotiation via ethtool

2017-01-16 Thread Tariq Toukan
From: Ariel Levkovich This feature will allow the user to disable auto negotiation on the port for mlx4 devices while setting the speed is limited to 1GbE speeds. Other speeds will not be accepted in autoneg off mode. Signed-off-by: Ariel Levkovich

  1   2   >