[PATCH v2 net-next] virtio: Fix affinity for #VCPUs != #queue pairs

From: Benjamin Serebrin If the number of virtio queue pairs is not equal to the number of VCPUs, the virtio guest driver doesn't assign any CPU affinity for the queue interrupts or the xps aggregation interrupt. (In contrast, the driver does assign both if the counts of

Re: [PATCHv4 net-next 0/7] net: dst_confirm replacement

From: Julian Anastasov Date: Mon, 6 Feb 2017 23:14:10 +0200 > This patchset addresses the problem of neighbour > confirmation where received replies from one nexthop > can cause confirmation of different nexthop when using > the same dst. Thanks to YueHaibing

Re: [PATCH 3/3] rhashtable: Add nested tables

Herbert Xu wrote: > On Tue, Feb 07, 2017 at 02:17:28PM +0100, Florian Westphal wrote: > > > > Ok, but why? > > Because people expect the hash table insertion to succeed, even > on softirq paths where you cannot vmalloc. I can't really say anything here because *I*

Re: kernel data plane

On 7 February 2017 at 09:45, David Miller wrote: > > Since I see that you guys have marked the kernel data plane of > openvswitch as experimental and that it "has not been thoroughly > tested" what is your long term plan for deprecation and eventual > removal of it from the

Re: [PATCH net-next] net: phy: bcm7xxx: Add BCM74371 PHY ID

From: Florian Fainelli Date: Mon, 6 Feb 2017 13:01:16 -0800 > Add the BCM74371 PHY ID to the list of supported chips. This is a 28nm > technology Gigabit PHY SoC. > > Signed-off-by: Florian Fainelli Applied.

Re: [PATCH net-next v2 1/3] tools: Sync {,tools/}include/uapi/linux/bpf.h

Again, I need to see a proper "[PATCH net-next v2 0/3]" header posting explaining this series. Thanks.

Re: [PATCH v2 1/5] bpf: Add missing header to the library

I don't see a proper "[PATCH v2 0/5] ..." posting, and I can't tell what tree you are targetting this series at.

Re: [PATCH 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

From: Stefan Brüns Date: Mon, 6 Feb 2017 21:20:33 +0100 > > /* Validate the protocol - only support UMTS for now */ > - if (lsi->protocol != SIERRA_NET_PROTOCOL_UMTS) { > + if (lsi->protocol == SIERRA_NET_PROTOCOL_UMTS) { ... > + } else if

Re: [PATCH net] sctp: avoid BUG_ON on sctp_wait_for_sndbuf

From: Marcelo Ricardo Leitner Date: Mon, 6 Feb 2017 18:10:31 -0200 > Alexander Popov reported that an application may trigger a BUG_ON in > sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is > waiting on it to queue more data and meanwhile another

kernel data plane

Since I see that you guys have marked the kernel data plane of openvswitch as experimental and that it "has not been thoroughly tested" what is your long term plan for deprecation and eventual removal of it from the tree?

Re: [PATCH net v2] mlx4: Invoke softirqs after napi_reschedule

From: Benjamin Poirier Date: Mon, 6 Feb 2017 10:14:31 -0800 > mlx4 may schedule napi from a workqueue. Afterwards, softirqs are not run > in a deterministic time frame and the following message may be logged: > NOHZ: local_softirq_pending 08 > > The problem is the same as

RE: Extending socket timestamping API for NTP

Hi Miroslav, > -Original Message- > From: Miroslav Lichvar [mailto:mlich...@redhat.com] > Sent: Tuesday, February 07, 2017 6:02 AM > To: netdev@vger.kernel.org > Cc: Richard Cochran ; Jiri Benc > ; Keller, Jacob E ;

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

From: Tom Herbert Date: Tue, 7 Feb 2017 09:36:20 -0800 > Okay, but can you give us an idea of how many more of these protocols > are going to be added to flow_dissector. TBH I'm not very enthused > about making more flow_dissector more complex for the benefit of OVS.

Re: [oss-drivers] Re: [PATCH/RFC net-next 1/2] flow dissector: ND support

On Mon, Feb 6, 2017 at 1:12 AM, Simon Horman wrote: > On Thu, Feb 02, 2017 at 10:36:31AM -0800, Tom Herbert wrote: >> On Thu, Feb 2, 2017 at 9:48 AM, Jiri Pirko wrote: >> > Thu, Feb 02, 2017 at 06:24:40PM CET, t...@herbertland.com wrote: >> >>On Thu,

Re: [RFC PATCH net-next 1/2] bpf: Save original ebpf instructions

On 2/6/17 12:21 PM, Alexei Starovoitov wrote: >> Well, worst case cost would be ~8 additional pages per program that >> are very rarely used; assume you want to attach a prog per netdevice, >> or worse, one for ingress, one for egress ... and yet we already >> complain that netdevice itself is way

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

On Mon, Feb 6, 2017 at 9:15 AM, David Miller wrote: > From: Pravin Shelar > Date: Mon, 6 Feb 2017 09:06:29 -0800 > >> On Sun, Feb 5, 2017 at 2:28 PM, David Miller wrote: >>> From: Jarno Rajahalme >>> Date: Thu, 2 Feb

Re: [PATCH net-next 6/7] openvswitch: Add force commit.

On Mon, Feb 6, 2017 at 11:28 PM, Joe Stringer wrote: > On 6 February 2017 at 09:08, Pravin Shelar wrote: >> On Thu, Feb 2, 2017 at 5:10 PM, Jarno Rajahalme wrote: >>> Stateful network admission policy may allow connections to one >>> direction and

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

On 2/6/17 4:03 PM, David Ahern wrote: >> This doesn't look like a good solution, you loose the value of unspec. >> >> Just to clarify. You added a custom protocol value to netlink. >> And then you are using upstream iproute2 source to display the value. > > no. I am saying the string displayed

Re: [PATCH net-next] bridge: avoid unnecessary read of jiffies

On 07/02/17 17:46, Stephen Hemminger wrote: > > Jiffies is volatile so read it once. > > Signed-off-by: Stephen Hemminger > --- > net/bridge/br_fdb.c | 6 -- > net/bridge/br_input.c | 6 -- > 2 files changed, 8 insertions(+), 4 deletions(-) > Yep, good

Re: [PATCH iproute2/net-next 7/7] tc: flower: Support matching on ND

On Mon, 6 Feb 2017 09:44:00 +0100 Simon Horman wrote: > On Thu, Feb 02, 2017 at 06:27:48PM +0100, Jiri Pirko wrote: > > Thu, Feb 02, 2017 at 11:38:40AM CET, simon.hor...@netronome.com wrote: > > >Allow matching on Neighbour Discovery target IP, and source and > >

Re: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

On Tue, 7 Feb 2017 12:59:11 + Nogah Frankel wrote: > > -Original Message- > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Friday, February 03, 2017 8:07 PM > > To: Nogah Frankel > > Cc: netdev@vger.kernel.org;

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

On Tue, 7 Feb 2017 17:09:08 +0100 Jesper Dangaard Brouer wrote: > > > Question: What kernel tree should this go into??? > > > > > > If going through Jonathan Corbet, will it appear sooner here??? > > > https://www.kernel.org/doc/html/latest/ > > What about this question?

[PATCH net-next] bridge: avoid unnecessary read of jiffies

Jiffies is volatile so read it once. Signed-off-by: Stephen Hemminger --- net/bridge/br_fdb.c | 6 -- net/bridge/br_input.c | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index

Re: [PATCH] [net-next] mlxsw: add psample dependency for spectrum

From: Arnd Bergmann Date: Mon, 6 Feb 2017 17:26:30 +0100 > When PSAMPLE is a loadable module, spectrum must not be built-in: > > drivers/net/built-in.o: In function `mlxsw_sp_rx_listener_sample_func': > spectrum.c:(.text+0xe357e): undefined reference to `psample_sample_packet' >

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

Hi Jesper, On 02/07/2017 03:30 PM, Jesper Dangaard Brouer wrote: Question: What kernel tree should this go into??? If going through Jonathan Corbet, will it appear sooner here??? https://www.kernel.org/doc/html/latest/ If it will not appear sooner that way, then it's likely best to keep it

Re: [PATCH net-next v2] net: wan: slic_ds26522: Remove .owner field for driver

From: Wei Yongjun Date: Mon, 6 Feb 2017 15:26:17 + > From: Wei Yongjun > > Remove .owner field if calls are used which set it automatically. > > Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci > > Signed-off-by: Wei Yongjun

Re: [PATCH net-next] net/sched: act_mirred: remove duplicated include from act_mirred.c

From: Wei Yongjun Date: Mon, 6 Feb 2017 16:07:13 + > From: Wei Yongjun > > Remove duplicated include. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next] ipv6: sr: fix non static symbol warnings

From: Wei Yongjun Date: Mon, 6 Feb 2017 16:15:05 + > From: Wei Yongjun > > Fixes the following sparse warnings: > > net/ipv6/seg6_iptunnel.c:58:5: warning: > symbol 'nla_put_srh' was not declared. Should it be static? >

Re: [PATCH net-next v2] net: wan: slic_ds26522: Use module_spi_driver to simplify the code

From: Wei Yongjun Date: Mon, 6 Feb 2017 15:25:52 + > From: Wei Yongjun > > module_spi_driver() makes the code simpler by eliminating > boilerplate code. > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next 9/9] mlx4: add page recycling in receive path

On Tue, Feb 7, 2017 at 8:20 AM, Tariq Toukan wrote: > > > On 07/02/2017 5:02 AM, Eric Dumazet wrote: >> >> Same technique than some Intel drivers, for arches where PAGE_SIZE = 4096 >> >> In most cases, pages are reused because they were consumed >> before we could loop

Re: [Bug 194241] New: LXC - setns() performance issue with more than 1vCPU

From: Stephen Hemminger Date: Tue, 7 Feb 2017 08:30:32 -0800 > Kernel Version: 3.6.57 , 3.16.7 Yeah, we've made thousands of network namespace performance improvements since then.

Fw: [Bug 194241] New: LXC - setns() performance issue with more than 1vCPU

Begin forwarded message: Date: Tue, 07 Feb 2017 02:18:18 + From: bugzilla-dae...@bugzilla.kernel.org To: step...@networkplumber.org Subject: [Bug 194241] New: LXC - setns() performance issue with more than 1vCPU https://bugzilla.kernel.org/show_bug.cgi?id=194241 Bug ID:

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

On Tue, 2017-02-07 at 08:26 -0800, Eric Dumazet wrote: > In most cases, using exactly 12 bytes per slot would allow better typo : 24 bytes on 64bit arches. (Instead of 128 bytes with the current implementation) > packing. Only one cpu is using this area, no need to force strange > alignments,

[patch net-next v2] spectrum: acl_tcam: Fix catchall prio value

From: Jiri Pirko This fixes an issue reported by smatch: mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == (-1)) => (0-u32max == u64max)' Reported-by: Or Gerlitz Reported-by: Ido Schimmel Reported-by: Dan

Re: Disabling msix interrupts

From: David Laight Date: Tue, 7 Feb 2017 09:55:47 + > From: David Miller >> Sent: 06 February 2017 19:15 >> From: David Laight >> Date: Mon, 6 Feb 2017 17:23:54 + >> >> > Although the 'store buffer' on the sparc cpus I used to use would

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

On Tue, 2017-02-07 at 08:06 -0800, Eric Dumazet wrote: > /* >* make sure we read the CQE after we read the ownership bit >*/ > dma_rmb(); > + prefetch(frags[0].page); Note that I would like to instead do a

Re: [PATCH net-next 9/9] mlx4: add page recycling in receive path

On 07/02/2017 5:02 AM, Eric Dumazet wrote: Same technique than some Intel drivers, for arches where PAGE_SIZE = 4096 In most cases, pages are reused because they were consumed before we could loop around the RX ring. This might not be true when multiple streams are handled in the same ring.

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

On Tue, 7 Feb 2017 08:37:17 -0700 Jonathan Corbet wrote: > On Tue, 07 Feb 2017 15:30:11 +0100 > Jesper Dangaard Brouer wrote: > > > Question: What kernel tree should this go into??? > > > > If going through Jonathan Corbet, will it appear sooner here??? > >

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

On Tue, 2017-02-07 at 17:50 +0200, Tariq Toukan wrote: > Hi Eric, > > Thanks for your series. > > On 07/02/2017 5:02 AM, Eric Dumazet wrote: > > As mentioned half a year ago, we better switch mlx4 driver to order-0 > > allocations and page recycling. > > > > This reduces vulnerability surface

Re: [PATCH net-next v5 0/4] net: dsa: Support for pdata in dsa2

From: Florian Fainelli Date: Sat, 4 Feb 2017 12:57:07 -0800 > This is not exactly new, and was sent before, although back then, I did not > have an user of the pre-declared MDIO board information, but now we do. Note > that I have additional changes queued up to have b53

[PATCH] net: intel: ixgbevf: use new api ethtool_{get|set}_link_ksettings

The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 22

Re: [PATCHv2 net-next] net: dsa: mv88e6xxx: Implement Clause 45 access to SMI devices

From: Andrew Lunn Date: Sat, 4 Feb 2017 20:12:24 +0100 > The mv88e6390 MDIO bus controllers can support for clause 45 accesses. > The internal SERDES interfaces need this, and it is likely external > 10GHz PHYs will be clause 45. > > Signed-off-by: Andrew Lunn

Re: [PATCH net-next] net: dsa: mv88e6xxx: Refactor remaining port setup

From: Andrew Lunn Date: Sat, 4 Feb 2017 20:15:28 +0100 > Move the remaining port configuration code which varies per device > into port.c, using ops were necessary. This makes > mv88e6xxx_6185_family() and mv88e6xxx_6095_family() unused, so remove > them. > > Signed-off-by:

Re: [PATCH] Revert "net: Remove state argument from skb_find_text()"

From: Igor Pylypiv Date: Sat, 4 Feb 2017 21:48:30 -0800 > This reverts commit 059a2440fd3cf4ec57735db2c0a90401cde84fca. > > Textsearch state parameter should be passed by pointer because > its resulting value is needed for call to textsearch_next(). > > Signed-off-by:

Re: [PATCH net-next 0/9] mlx4: order-0 allocations and page recycling

Hi Eric, Thanks for your series. On 07/02/2017 5:02 AM, Eric Dumazet wrote: As mentioned half a year ago, we better switch mlx4 driver to order-0 allocations and page recycling. This reduces vulnerability surface thanks to better skb->truesize tracking and provides better performance in most

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

On Tue, 07 Feb 2017 15:30:11 +0100 Jesper Dangaard Brouer wrote: > Question: What kernel tree should this go into??? > > If going through Jonathan Corbet, will it appear sooner here??? > https://www.kernel.org/doc/html/latest/ > If it will not appear sooner that way, then

Re: [PATCH v2 net-next 0/2] Set the CMODE for mv88e6390 ports

From: Andrew Lunn Date: Sat, 4 Feb 2017 20:02:48 +0100 > The mv88e6390 ports 9 & 10 allow there CMODE to be set. CMODE is part > of what linux defines as phy-mode. Add the needed phy-modes to linux, > and add code which will act upon the phy-mode property to configure > the

Re: [PATCH for bnxt_re V4 00/21] Broadcom RoCE Driver (bnxt_re)

On Wed, 2016-12-21 at 03:41 -0800, Selvin Xavier wrote: > This series introduces the RoCE driver for the Broadcom > NetXtreme-E 10/25/40/50G RoCE HCAs. > This driver is dependent on the bnxt_en NIC driver and is > based on the bnxt_re branch in linux-rdma repository. > bnxt_en changes required for

Re: [PATCH net 0/4] Fix on-stack USB buffers

From: Ben Hutchings Date: Sat, 4 Feb 2017 16:54:51 + > Allocating USB buffers on the stack is not portable, and no longer > works on x86_64 (with VMAP_STACK enabled as per default). This > series fixes all the instances I could find where USB networking > drivers do

Re: [net-next PATCH v2 0/5] XDP adjust head support for virtio

From: "Michael S. Tsirkin" Date: Tue, 7 Feb 2017 06:15:13 +0200 > On Thu, Feb 02, 2017 at 07:14:05PM -0800, John Fastabend wrote: >> This series adds adjust head support for virtio. The following is my >> test setup. I use qemu + virtio as follows, >> >>

[PATCH v2] xen-netfront: Improve error handling during initialization

This fixes a crash when running out of grant refs when creating many queues across many netdevs. * If creating queues fails (i.e. there are no grant refs available), call xenbus_dev_fatal() to ensure that the xenbus device is set to the closed state. * If no queues are created, don't call

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:14:30, David Laight wrote: > From: Petko Manolov > > Sent: 07 February 2017 13:21 > ... > > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > > for 4.11, > > > > for example? I for one will use something like that in all my drivers. > > > > > > Sure,

Re: [PATCH 1/3] ath10k: remove ath10k_vif_to_arvif()

On 02/07/2017 01:14 AM, Valo, Kalle wrote: Adrian Chadd writes: Removing this method makes the diff to FreeBSD larger, as "vif" in FreeBSD is a different pointer. (Yes, I have ath10k on freebsd working and I'd like to find a way to reduce the diff moving forward.) I

[PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range

From: Roopa Prabhu vtbegin should not be NULL in this function, Its already checked by the caller. this should silence the below smatch complaint: net/bridge/br_netlink_tunnel.c:144 br_fill_vlan_tinfo_range() error: we previously assumed 'vtbegin' could be null

Re: net/icmp: null-ptr-deref in ping_v4_push_pending_frames

On Mon, Feb 6, 2017 at 11:50 PM, Cong Wang wrote: > On Mon, Feb 6, 2017 at 11:39 AM, Andrey Konovalov > wrote: >> Hi, >> >> I've got the following error report while running the syzkaller fuzzer. >> >> The null-ptr-deref is caused by sendto() on

RE: [patch net-next] spectrum: acl_tcam: Fix catchall prio value

From: Jiri Pirko > Sent: 07 February 2017 14:27 > From: Jiri Pirko > > This fixes an issue reported by smatch: > mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == > (-1)) => (0-u32max == > u64max)' ... > diff --git

[net-next PATCH 1/4] doc/bpf: start eBPF documentation tree bpf/

The learning curve for eBPF programs is hard. The purpose of this documentation (subtree) is to make it easier for developers to get started using and writing eBPF programs. Including bpf/index under section User-oriented documentation. Thanks to Quentin Monnet for

[net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

Question: What kernel tree should this go into??? If going through Jonathan Corbet, will it appear sooner here??? https://www.kernel.org/doc/html/latest/ If it will not appear sooner that way, then it's likely best to keep it in sync with the tree that takes eBPF code changes. This marks the

[net-next PATCH 3/4] doc/bpf: describes the different types of eBPF maps available

The purpose is to help choose the right map type based on the individual use-case. To start with, only BPF_MAP_TYPE_ARRAY is described. It is the plan that all types should have descriptions here. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/ebpf_maps.rst

[net-next PATCH 4/4] doc/bpf: describe BCC the BPF Compiler Collection

It is worth mentioning BCC (BPF Compiler Collection) in-order to direct developers into that community. Reviewed-by: Alexander Alemayhu Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/bcc_tool_chain.rst | 37

[net-next PATCH 2/4] doc/bpf: document interacting with eBPF maps

Describe what eBPF maps are, how to create them, and how to interact with them. Thanks to Quentin Monnet for improving this document by fixing many typos and early review. Signed-off-by: Jesper Dangaard Brouer --- Documentation/bpf/ebpf_maps.rst |

[patch net-next] spectrum: acl_tcam: Fix catchall prio value

From: Jiri Pirko This fixes an issue reported by smatch: mlxsw_sp_acl_tcam_chunk_create() warn: impossible condition '(priority == (-1)) => (0-u32max == u64max)' Reported-by: Or Gerlitz Reported-by: Ido Schimmel Reported-by: Dan

Re: fs, net: deadlock between bind/splice on af_unix

On Sun, Feb 05, 2017 at 11:22:12PM -0800, Cong Wang wrote: > On Tue, Jan 31, 2017 at 10:14 AM, Mateusz Guzik wrote: > > On Mon, Jan 30, 2017 at 10:44:03PM -0800, Cong Wang wrote: > >> Mind being more specific? > > > > Consider 2 threads which bind the same socket, but with

Re: mlxsw: spectrum: Introduce ACL core with simple TCAM implementation

Hi Jiri, mlxsw_sp_acl_tcam_chunk_create has an issue picked up by static analysis: 816struct mlxsw_sp_acl_tcam_chunk *chunk; 817int err; 818 CID 1400029 (#1 of 1): Operands don't affect result (CONSTANT_EXPRESSION_RESULT)result_independent_of_operands: priority ==

RE: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

From: Petko Manolov > Sent: 07 February 2017 13:21 ... > > > Would you consider what David proposed (usb_control_msg_with_malloc()) > > > for 4.11, > > > for example? I for one will use something like that in all my drivers. > > > > Sure, but you might want to make it a bit smaller of a function

[PATCH ipsec-next 6/6] xfrm: policy: make policy backend const

Signed-off-by: Florian Westphal --- net/ipv4/xfrm4_policy.c | 2 +- net/ipv6/xfrm6_policy.c | 2 +- net/xfrm/xfrm_policy.c | 18 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/net/ipv4/xfrm4_policy.c b/net/ipv4/xfrm4_policy.c index

[PATCH ipsec-next 3/6] xfrm: policy: remove garbage_collect callback

Just call xfrm_garbage_collect_deferred() directly. This gets rid of a write to afinfo in register/unregister and allows to constify afinfo later on. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 2 +- net/ipv4/xfrm4_policy.c | 2 +- net/ipv6/xfrm6_policy.c | 2

[PATCH ipsec-next 4/6] xfrm: policy: remove family field

Only needed it to register the policy backend at init time. Signed-off-by: Florian Westphal --- include/net/xfrm.h | 5 ++--- net/ipv4/xfrm4_policy.c | 5 + net/ipv6/xfrm6_policy.c | 5 + net/xfrm/xfrm_policy.c | 34 +- 4 files

[PATCH ipsec-next 5/6] xfrm: policy: remove xfrm_policy_put_afinfo

Alternative is to keep it an make the (unused) afinfo arg const to avoid the compiler warnings once the afinfo structs get constified. Signed-off-by: Florian Westphal --- net/xfrm/xfrm_policy.c | 21 - 1 file changed, 8 insertions(+), 13 deletions(-) diff

[PATCH ipsec-next 2/6] xfrm: policy: xfrm_policy_unregister_afinfo can return void

Nothing checks the return value. Also, the errors returned on unregister are impossible (we only support INET and INET6, so no way xfrm_policy_afinfo[afinfo->family] can be anything other than 'afinfo' itself). Signed-off-by: Florian Westphal --- include/net/xfrm.h | 2 +-

[PATCH ipsec-next 1/6] xfrm: policy: xfrm_get_tos cannot fail

The comment makes it look like get_tos() is used to validate something, but it turns out the comment was about xfrm_find_bundle() which got removed years ago. xfrm_get_tos will return either the tos (ipv4) or 0 (ipv6). Signed-off-by: Florian Westphal --- net/xfrm/xfrm_policy.c

[PATCH ipsec-next 0/6] xfrm: policy: make policy backend const

Hi Steffen, This series removes all places that need to write to the afinfo policy backends. This then allows us to make the structures const.

Extending socket timestamping API for NTP

I'd like to propose some changes and new options for the timestamping interface that I think would be useful for NTP implementations and maybe also other applications. Before I or someone else tries to implement them, do you think they would actually make sense and fit well in the current code?

[PATCH ipsec-next] xfrm: input: constify xfrm_input_afinfo

Nothing writes to these structures (the module owner was not used). While at it, size xfrm_input_afinfo[] by the highest existing xfrm family (INET6), not AF_MAX. Signed-off-by: Florian Westphal --- include/net/xfrm.h| 5 ++--- net/ipv4/xfrm4_protocol.c | 3 +--

[PATCH net-next/iproute v2 1/5] tc: bash-completion: Add the _from variant to _tc_one* funcs

The _tc_one_of_list and _tc_once_attr functions simplfy the bash completion task by validating each attr exist only once on the command line. For example, for the command line: $ a b c d e and the call to _tc_once_attr with "a f g", the function will suggest "f g" as "a" existed in the command

[PATCH net-next/iproute v2 5/5] tc: bash-completion: Add support for matchall

Add support for the matchall classifier and its parameters. Signed-off-by: Yotam Gigi --- bash-completion/tc | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/bash-completion/tc b/bash-completion/tc index e4c6804..80d1297 100644 ---

[PATCH net-next/iproute v2 2/5] tc: bash-completion: Prepare action autocomplete to support several actions

The action autocomplete routine (_tc_action_options) currently does not support several actions statements in one tc command line as it uses the _tc_once_attr and _tc_one_from_list. For example, in that case: $ tc filter add dev eth0 handle : u32 [...] \ action sample group 5

[PATCH net-next/iproute v2 4/5] tc: bash-completion: Add support for filter actions

Previously, the autocomplete routine did not complete actions after a filter keyword, for example: $ tc filter add dev eth0 u32 [...] action did not suggest the actions list, and: $ tc filter add dev eth0 u32 [...] action mirred did not suggest the specific mirred parameters. Add the support

[PATCH net-next/iproute v2 3/5] tc: bash-completion: Make the *_KIND variables global

The QDISC_KIND, FILTER_KIND, ACTION_KIND variables may be used by other routines, thus make them global variables. Signed-off-by: Yotam Gigi --- bash-completion/tc | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/bash-completion/tc

[PATCH net-next/iproute v2 0/5] tc: bash-completion: Add features

The first 4 patches add support for autompletion of filter actions, thus allowing the following tab completions: $ tc filter add dev eth0 u32 [...] action bpf gactmirred sample $ tc filter add dev eth0 u32 [...] action sample action group ratetrunc $ tc filter add dev eth0 u32

[PATCH v3 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

From: Raju Lakkaraju LED Mode: Microsemi PHY support 2 LEDs (LED[0] and LED[1]) to display different status information that can be selected by setting LED mode. LED Mode parameter (vsc8531, led-0-mode) and (vsc8531, led-1-mode) get from Device Tree.

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi

Hi Florian, Thank you for review comments. On Wed, Feb 01, 2017 at 10:04:08AM -0800, Florian Fainelli wrote: > EXTERNAL EMAIL > > > On 02/01/2017 04:53 AM, Raju Lakkaraju wrote: > > From: Raju Lakkaraju > > > > LED Mode: > > Microsemi PHY support 2 LEDs (LED[0]

[PATCH net-next] sctp: drop __packed from almost all SCTP structures

__packed is considered harmful as it potentially generates code that doesn't perform well and its usage should be avoided as much as possible. This patch drops __packed from all SCTP structures except one, which is sctp_signed_cookie. In there it's required, as per changelog on commit

Re: [PATCH 3/3] rhashtable: Add nested tables

On Tue, Feb 07, 2017 at 02:17:28PM +0100, Florian Westphal wrote: > > Ok, but why? Because people expect the hash table insertion to succeed, even on softirq paths where you cannot vmalloc. > It seems to add a whole lot of complexity... > > What users can't handle the insert failure case until

Re: [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote: > These checks should go after the attributes have been parsed otherwise > we're using tb uninitialized. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-by: Colin Ian King >

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On 17-02-07 14:01:02, Greg KH wrote: > On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > > On 17-02-07 11:51:31, Greg KH wrote: > > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > > On Mon, Feb 06, 2017 at

Re: [PATCH 3/3] rhashtable: Add nested tables

Herbert Xu wrote: > This patch adds code that handles GFP_ATOMIC kmalloc failure on > insertion. As we cannot use vmalloc, we solve it by making our > hash table nested. That is, we allocate single pages at each level > and reach our desired table size by nesting

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

On Tue, Feb 07, 2017 at 06:20:23AM +0100, Lukasz Majewski wrote: > This patch adds support for enabling or disabling the lane swapping (called > "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY > device. > > One use case is when bootstrap configuration enables this feature

[patch net-next] net: dsa: bcm_sf2: cleanup bcm_sf2_cfp_rule_get() a little

This patch doesn't affect how the code works. My static checker complains that the mask and shift doesn't make sense because 0xff << 16 goes beyond the end of 32 bits. It should be 0x instead but the existing code won't cause runtime bugs. Also the casting here is not needed and not

Re: [PATCH net-next 4/4] net: dsa: Do not clobber PHY link outside of state machine

> Related is that polling the phy status every second can be bad news for > system latency. > Typically it involves bit-bashing an interface with spin-delays to > meet the slow timings (with extra delays to allow for posted writes). > An alternative would be to do a very slow bit-bang on each

Re: [PATCH v2 net-next] net: phy: Add LED mode driver for Microsemi PHYs.

> > > +- vsc8531,led-1-mode : LED mode. Specify how the LED[1] should behave. > > > + Allowed values are define in > > > + int rc; > > > + > > > + if (!of_node) > > > + return -ENODEV; > > > + > > > + rc = of_property_read_u8(of_node, led, _mode); > >

Re: [PATCH v3 1/3] Documentation: devicetree: Add PHY no lane swap binding

On Tue, Feb 07, 2017 at 06:21:34AM +0100, Lukasz Majewski wrote: > Add the documentation to avoid PHY lane swapping. This is a boolean > entry to notify the phy device drivers that the TX/RX lanes NO need > to be swapped. > The use case for this binding mostly happens after wrong HW >

Re: [PATCH net] sctp: avoid BUG_ON on sctp_wait_for_sndbuf

On Tue, Feb 7, 2017 at 4:10 AM, Marcelo Ricardo Leitner wrote: > Alexander Popov reported that an application may trigger a BUG_ON in > sctp_wait_for_sndbuf if the socket tx buffer is full, a thread is > waiting on it to queue more data and meanwhile another thread

Re: [PATCH v3 3/3] net: phy: dp83867: Recover from "port mirroring" N/A MODE4

On Tue, Feb 07, 2017 at 06:20:24AM +0100, Lukasz Majewski wrote: > The DP83867 when not properly bootstrapped - especially with LED_0 pin - > can enter N/A MODE4 for "port mirroring" feature. > > To provide normal operation of the PHY, one needs not only to explicitly > disable the port mirroring

Re: [PATCH v3 2/3] net: phy: dp83867: Add lane swapping support in the DP83867 TI's PHY driver

On Tue, Feb 07, 2017 at 06:20:23AM +0100, Lukasz Majewski wrote: > This patch adds support for enabling or disabling the lane swapping (called > "port mirroring" in PHY's CFG4 register) feature of the DP83867 TI's PHY > device. > > One use case is when bootstrap configuration enables this feature

Re: [PATCH net 2/4] rtl8150: Use heap buffers for all register access

On Tue, Feb 07, 2017 at 02:53:24PM +0200, Petko Manolov wrote: > On 17-02-07 11:51:31, Greg KH wrote: > > On Tue, Feb 07, 2017 at 12:34:52PM +0200, Petko Manolov wrote: > > > On 17-02-06 16:25:20, Ben Hutchings wrote: > > > > On Mon, Feb 06, 2017 at 04:09:18PM +, David Laight wrote: > > > > >

RE: [PATCH iproute2 v5 2/4] ifstat: Add extended statistics to ifstat

> -Original Message- > From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, February 03, 2017 8:07 PM > To: Nogah Frankel > Cc: netdev@vger.kernel.org; ro...@cumulusnetworks.com; roszenr...@gmail.com; > jb...@redhat.com;

Re: [PATCH net] sctp: check af before verify address in sctp_addr_id2transport

On Tue, Feb 07, 2017 at 08:56:08PM +0800, Xin Long wrote: > Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the > addr before looking up assoc") invoked sctp_verify_addr to verify the > addr. > > But it didn't check af variable beforehand, once users pass an address > with family

ANNOUNCE: Netdev 2.1 Location and Hotel

Two important announcements 1) We are pleased to announce a location for netdev 2.1: Le Westin Montréal 270 Rue St. Antoine Ouest, Montreal, QC H2Y 0A3, Canada Le Westin will also be the conference hotel. We have a speacial arrangement for all attendees to get speacial rates at the hotel. We

[PATCH net] sctp: check af before verify address in sctp_addr_id2transport

Commit 6f29a1306131 ("sctp: sctp_addr_id2transport should verify the addr before looking up assoc") invoked sctp_verify_addr to verify the addr. But it didn't check af variable beforehand, once users pass an address with family = 0 through sockopt, sctp_get_af_specific will return NULL and NULL

<    1   2   3   4   >