[PATCH net-next] bpf: enhance verifier to understand stack pointer arithmetic

2017-04-29 Thread Alexei Starovoitov
From: Yonghong Song llvm 4.0 and above generates the code like below: 440: (b7) r1 = 15 441: (05) goto pc+73 515: (79) r6 = *(u64 *)(r10 -152) 516: (bf) r7 = r10 517: (07) r7 += -112 518: (bf) r2 = r7 519: (0f) r2 += r1 520: (71) r1 = *(u8 *)(r8 +0) 521: (73) *(u8 *)(r2 +45) =

[PATCH] net: phy: Allow BCM5481x PHYs to setup internal TX/RX clock delay

2017-04-29 Thread Abhishek Shah
This patch allows users to enable/disable internal TX and/or RX clock delay for BCM5481x series PHYs so as to satisfy RGMII timing specifications. On a particular platform, whether TX and/or RX clock delay is required depends on how PHY connected to the MAC IP. This requirement can be specified

[PATCH net-next iproute2] ip: increase number of MPLS labels

2017-04-29 Thread David Ahern
Kernel now supports more than 2 labels. Increase ip to handle up to 16 labels. Signed-off-by: David Ahern --- include/utils.h | 8 lib/utils.c | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/utils.h b/include/utils.h index

Re: [net-next v2 00/11][pull request] 10GbE Intel Wired LAN Driver Updates 2017-04-29

2017-04-29 Thread David Miller
From: Jeff Kirsher Date: Sat, 29 Apr 2017 20:07:59 -0700 > This series contains updates to ixgbe and ixgbevf only, most notable is > the addition of XDP support to our 10GbE drivers. Awesome, pulled, thanks Jeff.

[net-next v2 11/11] ixgbevf: Check for RSS key before setting value

2017-04-29 Thread Jeff Kirsher
From: Tony Nguyen The RSS key is being repopulated every time the interface is brought up regardless of whether there is an existing value. If the user sets the RSS key and the interface is brought up (e.g. reset), the user specified RSS key will be overwritten. This

[net-next v2 10/11] ixgbevf: Fix errors in retrieving RETA and RSS from PF

2017-04-29 Thread Jeff Kirsher
From: Tony Nguyen Mailbox support for getting RETA and RSS is available for only 82599 and x540; a previous patch reversed the logic and these adapters were returning not supported. Also, the NACK check in ixgbevf_get_rss_key_locked() was checking for the command

[net-next v2 06/11] ixgbevf: fix size of queue stats length

2017-04-29 Thread Jeff Kirsher
From: Emil Tantilov IXGBEVF_QUEUE_STATS_LEN is based on ixgebvf_stats, not ixgbe_stats. This change fixes a bug where ethtool -S displayed some empty fields. Signed-off-by: Emil Tantilov Tested-by: Andrew Bowers

[net-next v2 03/11] ixgbe: add support for XDP_TX action

2017-04-29 Thread Jeff Kirsher
From: John Fastabend A couple design choices were made here. First I use a new ring pointer structure xdp_ring[] in the adapter struct instead of pushing the newly allocated XDP TX rings into the tx_ring[] structure. This means we have to duplicate loops around rings

[net-next v2 05/11] ixgbe: clean macvlan MAC filter table on VF reset

2017-04-29 Thread Jeff Kirsher
From: Emil Tantilov Flush the macvlan filters on VF reset to avoid conflict with other VFs that may end up using the same MAC address. The main change here is the call to ixgbe_set_vf_macvlan() with index 0. Moved ixgbe_set_vf_macvlan() in front of

[net-next v2 07/11] ixgbe: Allow setting zero MAC address for VF

2017-04-29 Thread Jeff Kirsher
From: Tony Nguyen Currently, there is no logic that allows a VF's MAC address to be removed from the RAR table. Allow the user to specify a zero MAC address in order to clear the VF's MAC address from the RAR table. This functionality is also utilized by libvirt

[net-next v2 09/11] ixgbe: Check for RSS key before setting value

2017-04-29 Thread Jeff Kirsher
From: Tony Nguyen The RSS key is being repopulated every time the interface is brought up regardless of whether there is an existing value. If the user sets the RSS key and the interface is brought up (e.g. reset), the user specified RSS key will be overwritten. This

[net-next v2 08/11] ixgbe: Add 1000Base-T device based on X550EM_X MAC

2017-04-29 Thread Jeff Kirsher
From: Paul Greenwalt Add support for new 1000Base-T device based on X550EM_X MAC type. All PHY operations are disabled as the PHY is controlled by FW. Signed-off-by: Paul Greenwalt Tested-by: Krishneil Singh

[net-next v2 00/11][pull request] 10GbE Intel Wired LAN Driver Updates 2017-04-29

2017-04-29 Thread Jeff Kirsher
This series contains updates to ixgbe and ixgbevf only, most notable is the addition of XDP support to our 10GbE drivers. Paul fixes ixgbe to acquire the PHY semaphore before accessing PHY registers when issuing a device reset. John adds XDP support (yeah!) for ixgbe. Emil fixes an issue by

[net-next v2 02/11] ixgbe: add XDP support for pass and drop actions

2017-04-29 Thread Jeff Kirsher
From: John Fastabend Basic XDP drop support for ixgbe. Uses READ_ONCE/xchg semantics on XDP programs instead of RCU primitives as suggested by Daniel Borkmann and Alex Duyck. v2: fix the build issues seen w/ XDP when page sizes are larger than 4K and made minor

[net-next v2 04/11] ixgbe: delay tail write to every 'n' packets

2017-04-29 Thread Jeff Kirsher
From: John Fastabend Current XDP implementation hits the tail on every XDP_TX return code. This patch changes driver behavior to only hit the tail after packet processing is complete. With this patch I can run XDP drop programs @ 14+Mpps and XDP_TX programs are at

[net-next v2 01/11] ixgbe: Acquire PHY semaphore before device reset

2017-04-29 Thread Jeff Kirsher
From: Paul Greenwalt A recent firmware change fixed an issue to acquire the PHY semaphore before accessing PHY registers. This led to a case where SW can issue a device reset clearing the MDIO registers. This patch makes SW acquire the PHY semaphore before issuing a

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread David Miller
From: David Miller Date: Sat, 29 Apr 2017 22:24:50 -0400 (EDT) > Some of your bugs should be fixed by this patch below, I'll add > test cases soon: Ok, here are all the local changes in my tree. I made the relocs match LLVM and I fixed some dwarf debugging stuff. With

Re: prog ID and next steps. Was: [RFC net-next 0/2] Introduce bpf_prog ID and iteration

2017-04-29 Thread Hannes Frederic Sowa
Hi, just quickly, because I am on a run: On Sun, Apr 30, 2017, at 04:06, Alexei Starovoitov wrote: > On 4/28/17 2:13 PM, Hannes Frederic Sowa wrote: > > > > Let's assume the following program with a constant key lookup and > > different tables: > > > > action = bpf_map_lookup_elem(, 0); > > if

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread Alexei Starovoitov
On 4/29/17 7:13 PM, David Miller wrote: From: Alexei Starovoitov Date: Sat, 29 Apr 2017 17:48:43 -0700 /w/binutils-gdb/bld/binutils/objdump: invalid relocation type 10 /w/binutils-gdb/bld/binutils/objdump: Dwarf Error: found address size I discussed this in another email, the

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread David Miller
From: Alexei Starovoitov Date: Sat, 29 Apr 2017 17:48:43 -0700 > $ bld/binutils/objdump -S test.o > > test.o: file format elf64-bpfbe > > Disassembly of section .text: > > : >0: 18 10 00 00 83 98 47 39 ldimm64 r1, 590618314553 >8: 00 00 00 00

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread David Miller
From: Alexei Starovoitov Date: Sat, 29 Apr 2017 17:48:43 -0700 > /w/binutils-gdb/bld/binutils/objdump: invalid relocation type 10 > /w/binutils-gdb/bld/binutils/objdump: Dwarf Error: found address size I discussed this in another email, the relocation numbers I used in binutils do

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread David Miller
From: Alexei Starovoitov Date: Sat, 29 Apr 2017 17:48:43 -0700 > On 4/28/17 1:33 PM, David Miller wrote: >> New in this version: >> >> 1) All the relocation work I posted earlier today. >> 2) Teach readelf about a few bpf relocs as needed >> 3) Add a 'nop' instruction which

Re: prog ID and next steps. Was: [RFC net-next 0/2] Introduce bpf_prog ID and iteration

2017-04-29 Thread Alexei Starovoitov
On 4/28/17 2:13 PM, Hannes Frederic Sowa wrote: Let's assume the following program with a constant key lookup and different tables: action = bpf_map_lookup_elem(, 0); if (!*action) return XDP_DROP; else return bpf_redirect(skb->ifindex, 0); It does something completely

Re: xdp_redirect ifindex vs port. Was: best API for returning/setting egress port?

2017-04-29 Thread Alexei Starovoitov
On 4/28/17 12:43 PM, Hannes Frederic Sowa wrote: On 28.04.2017 07:30, Alexei Starovoitov wrote: On 4/27/17 10:06 PM, John Fastabend wrote: That is more or less what I was thinking as well. The other question I have though is should we have a bpf_redirect() call for the simple case where I use

Re: xdp_redirect ifindex vs port. Was: best API for returning/setting egress port?

2017-04-29 Thread Alexei Starovoitov
On 4/28/17 3:58 AM, Jesper Dangaard Brouer wrote: On Thu, 27 Apr 2017 16:31:14 -0700 Alexei Starovoitov wrote: On 4/27/17 1:41 AM, Jesper Dangaard Brouer wrote: When registering/attaching a XDP/bpf program, we would just send the file-descriptor for this port-map along (like we

Re: [PATCH v3 binutils] Add BPF support to binutils...

2017-04-29 Thread Alexei Starovoitov
On 4/28/17 1:33 PM, David Miller wrote: New in this version: 1) All the relocation work I posted earlier today. 2) Teach readelf about a few bpf relocs as needed 3) Add a 'nop' instruction which facilitates the gas testsuite. I used "mov r0,r0" The whole gas testsuite passes now. :-) But

Re: ipsec doesn't route TCP with 4.11 kernel

2017-04-29 Thread Don Bowman
On 28 April 2017 at 03:13, Steffen Klassert wrote: > On Thu, Apr 27, 2017 at 06:13:38PM -0400, Don Bowman wrote: >> On 27 April 2017 at 04:42, Steffen Klassert >> wrote: >> > On Wed, Apr 26, 2017 at 10:01:34PM -0700, Cong Wang wrote: >>

[PATCH] net: sunhme: fix spelling mistakes: "ParityErro" -> "ParityError"

2017-04-29 Thread Colin King
From: Colin Ian King trivial fix to spelling mistakes in printk message. Signed-off-by: Colin Ian King --- drivers/net/ethernet/sun/sunhme.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Low speed MPLS to virtio-net

2017-04-29 Thread David Ahern
On 4/26/17 1:15 PM, Алексей Болдырев wrote: > Started MPLS on the branch - Everything was fine. When I tried to run MPLS on > a real network of virtual machines, there were problems with the speed: > root@containers:~# iperf3 -c 10.194.10.2 -B 10.194.10.1 -Z > Connecting to host

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Al Viro
On Sat, Apr 29, 2017 at 05:37:38PM +0800, Ding Tianhong wrote: > Looks good, if so, we don't need the csum_error any more, Acked-by: Al Viro Dave, I could put that through my tree, but I think it would be better off in net.git; either way, it needs to go into mainline

Re: [PATCH RFC net-next v4 3/7] sk_buff: remove support for csum_bad in sk_buff

2017-04-29 Thread Tom Herbert
On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti wrote: > This bit was introduced with 5a21232983aa ("net: Support for csum_bad in > skbuff") to reduce the stack workload when processing RX packets carrying > a wrong Internet Checksum. Up to now, only one driver (besides GRO

Re: [PATCH RFC net-next v4 7/7] sk_buff.h: improve description of CHECKSUM_{COMPLETE,UNNECESSARY}

2017-04-29 Thread Tom Herbert
On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti wrote: > Add FCoE to the list of protocols that can set CHECKSUM_UNNECESSARY; add a > note to CHECKSUM_COMPLETE section to specify that it does not apply to SCTP > and FCoE protocols. > > Suggested-by: Tom Herbert

Re: [PATCH RFC net-next v4 4/7] net: use skb->csum_not_inet to identify packets needing crc32c

2017-04-29 Thread Tom Herbert
On Thu, Apr 20, 2017 at 6:38 AM, Davide Caratti wrote: > skb->csum_not_inet carries the indication on which algorithm is needed to > compute checksum on skb in the transmit path, when skb->ip_summed is equal > to CHECKSUM_PARTIAL. If skb carries a SCTP packet and crc32c

Re: assembler mnenomics for call/tailcall plus maps...

2017-04-29 Thread David Miller
From: Alexei Starovoitov Date: Thu, 27 Apr 2017 19:06:14 -0700 > So in asm the map lookup will look like: > .sectionmaps,"aw",@progbits > .globl hashmap_def > hashmap_def: > .long 1 # type > .long 24 # key_size > .long 40 #

Re: [PATCH net-next 11/11] ibmvnic: Move queue restart

2017-04-29 Thread kbuild test robot
Hi Nathan, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Nathan-Fontenot/ibmvnic-Updated-reset-handler-and-code-fixes/20170430-004245 config: powerpc-allmodconfig (attached as .config) compiler: powerpc64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1

[no subject]

2017-04-29 Thread Dmitry Bazhenov
unsubscribe

Re: [PATCH net-next] lwtunnel: fix error path in lwtunnel_fill_encap()

2017-04-29 Thread David Ahern
On 4/28/17 7:03 AM, Dan Carpenter wrote: > We recently added a check to see if nla_nest_start() fails. There are > two issues with that. First, if it fails then I don't think we should > call nla_nest_cancel(). Second, it's slightly convoluted but the > current code returns success but we

URGENT

2017-04-29 Thread KATIE HIGGINS
Ahoj zlato, Jmenuji se Katie Higginsová, Z Spojené státy americké, mám o tebe zájem, představím si mé lépe, jakmile obdržím svou poštu, doufám, že slyším od vás. Díky a polibkům. Katie Higginsová.

Re: [PATCH v2] iov_iter: don't revert iov buffer if csum error

2017-04-29 Thread Ding Tianhong
On 2017/4/29 10:46, Al Viro wrote: > On Sat, Apr 29, 2017 at 10:38:48AM +0800, Ding Tianhong wrote: >> The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve >> ->msg_iter on error) will revert the iov buffer if copy to iter >> failed, but it didn't copy any datagram if the

Re: [net-next PATCH V1] samples/bpf: bpf_load.c detect and abort if ELF maps section size is wrong

2017-04-29 Thread Jesper Dangaard Brouer
On Fri, 28 Apr 2017 20:35:21 -0700 Alexei Starovoitov wrote: > On Fri, Apr 28, 2017 at 04:25:04PM +0200, Jesper Dangaard Brouer wrote: > > The struct bpf_map_def was extended in commit fb30d4b71214 ("bpf: Add tests > > for map-in-map") with member unsigned int