[no subject]

2017-07-08 Thread Alfred chow
Good Day, I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $38,980,369.00. All confirmable documents to back up the claims will be made available

[PATCH] net-next: Fix minor code bug in timestamping.txt

2017-07-08 Thread Ahmad Fatoum
Passing (void*)val instead of would make a pointer out of an integer and cause sock_setsockopt to -EFAULT. See tools/testing/selftests/networking/timestamping/timestamping.c for a working example. Cc: David S. Miller Cc: netdev@vger.kernel.org Signed-off-by: Ahmad Fatoum

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-08 Thread Jesper Dangaard Brouer
On Sat, 08 Jul 2017 10:46:18 +0100 (WEST) David Miller wrote: > From: John Fastabend > Date: Fri, 07 Jul 2017 10:48:36 -0700 > > > On 07/07/2017 10:34 AM, John Fastabend wrote: > >> This series adds two new XDP helper routines bpf_redirect() and

Re: [RFC PATCH 08/12] bpf: add devmap, a map for storing net device references

2017-07-08 Thread Jesper Dangaard Brouer
On Fri, 07 Jul 2017 10:37:12 -0700 John Fastabend wrote: > Device map (devmap) is a BPF map, primarily useful for networking > applications, that uses a key to lookup a reference to a netdevice. > > The map provides a clean way for BPF programs to build virtual port >

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-08 Thread Cong Wang
On Fri, Jul 7, 2017 at 5:39 AM, Nicolas Dichtel wrote: > Le 06/07/2017 à 20:16, Cong Wang a écrit : >> On Thu, Jul 6, 2017 at 5:08 AM, Nicolas Dichtel >> wrote: >>> Le 06/07/2017 à 00:43, Cong Wang a écrit : On Wed, Jul 5, 2017 at 8:57

Re: [Patch] mqueue: fix the retry logic for netlink_attachskb()

2017-07-08 Thread Linus Torvalds
On Sat, Jul 8, 2017 at 11:04 AM, Cong Wang wrote: >> >> Can you confirm that? I don't know where the original report is. > > Yes of course, setting 'sock' to NULL before 'goto retry' is sufficient > to fix it, that is in fact my initial thought. And I realized retry'ing

Re: [PATCH 00/17] v3 net generic subsystem refcount conversions

2017-07-08 Thread Levin, Alexander (Sasha Levin)
On Mon, Jul 03, 2017 at 02:28:56AM -0700, Eric Dumazet wrote: >On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: >> Changes in v3: >> Rebased on top of the net-next tree. >> >> Changes in v2: >> No changes in patches apart from rebases, but now by >> default refcount_t = atomic_t (*) and

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-08 Thread Cong Wang
On Sat, Jul 8, 2017 at 3:02 AM, David Miller wrote: > From: Nicolas Dichtel > Date: Wed, 5 Jul 2017 17:57:25 +0200 > >> From: Hongjun Li >> >> When the netdev event NETDEV_CHANGEMTU is triggered, the inet[6]dev may be >>

[RFC] get_compat_bpf_fprog(): don't copyin field-by-field

2017-07-08 Thread Al Viro
Signed-off-by: Al Viro --- diff --git a/net/compat.c b/net/compat.c index dba5e222a0e5..6ded6c821d7a 100644 --- a/net/compat.c +++ b/net/compat.c @@ -313,15 +313,15 @@ struct sock_fprog __user *get_compat_bpf_fprog(char __user *optval) { struct compat_sock_fprog

[RFC] copy_msghdr_from_user(): get rid of field-by-field copyin

2017-07-08 Thread Al Viro
Signed-off-by: Al Viro --- diff --git a/net/socket.c b/net/socket.c index c2564eb25c6b..af33d929135a 100644 --- a/net/socket.c +++ b/net/socket.c @@ -1870,22 +1870,18 @@ static int copy_msghdr_from_user(struct msghdr *kmsg, struct

[RFC] get_compat_msghdr(): get rid of field-by-field copyin

2017-07-08 Thread Al Viro
There are 3 commits in vfs.git#misc.compat I hadn't pushed to Linus yet; they touch net/* and I'd like to see at least "no objections" from networking folks before asking to pull that; all of those are about getting rid of field-by-field copyin. Please, review and comment. Signed-off-by: Al Viro

Re: [Patch] mqueue: fix the retry logic for netlink_attachskb()

2017-07-08 Thread Cong Wang
On Fri, Jul 7, 2017 at 5:23 PM, Linus Torvalds wrote: > On Fri, Jul 7, 2017 at 11:32 AM, Cong Wang wrote: >> so we when retry and the fd has been closed during this small >> window, we end up calling netlink_detachskb() on the error path

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Alan Stern
Pardon me for barging in, but I found this whole interchange extremely confusing... On Sat, 8 Jul 2017, Ingo Molnar wrote: > * Paul E. McKenney wrote: > > > On Sat, Jul 08, 2017 at 10:35:43AM +0200, Ingo Molnar wrote: > > > > > > * Manfred Spraul

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Paul E. McKenney
On Sat, Jul 08, 2017 at 02:30:19PM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > On Sat, Jul 08, 2017 at 10:35:43AM +0200, Ingo Molnar wrote: > > > > > > * Manfred Spraul wrote: > > > > > > > Hi Ingo, > > > > > > > > On

[no subject]

2017-07-08 Thread Alfred chow
Good Day, I am Mr. Alfred Cheuk Yu Chow, the Director for Credit & Marketing Chong Hing Bank, Hong Kong, Chong Hing Bank Centre, 24 Des Voeux Road Central, Hong Kong. I have a business proposal of $38,980,369.00. All confirmable documents to back up the claims will be made available

Loan Offer

2017-07-08 Thread Roy Wood
Exclusive guaranteed loan offer of any amount at a 3% rate. Contact Mr. Roy Wood from Save and see for yourself that you will be satisfied. please contact FCS Directly only via roywoodsavingsunitedloans@gmail. com if yes,apply now with your details 1.Full Name: 2.Sex: 3.Age: 4. Phone:

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Ingo Molnar
* Paul E. McKenney wrote: > On Sat, Jul 08, 2017 at 10:35:43AM +0200, Ingo Molnar wrote: > > > > * Manfred Spraul wrote: > > > > > Hi Ingo, > > > > > > On 07/07/2017 10:31 AM, Ingo Molnar wrote: > > > > > > > > There's another, probably

Re: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c

2017-07-08 Thread Marcel Holtmann
Hi Sundar, > I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth > chip that needs the r8723bs (coexisting RTL 8723BS wifi and > bluetooth). > > I am using linux-next (20150817) with the r8723bs staging driver and > the firmware and utility from

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Paul E. McKenney
On Sat, Jul 08, 2017 at 10:43:24AM +0200, Ingo Molnar wrote: > > * Paul E. McKenney wrote: > > > On Fri, Jul 07, 2017 at 10:31:28AM +0200, Ingo Molnar wrote: > > > > [ . . . ] > > > > > In fact I'd argue that any future high performance spin_unlock_wait() > > >

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Paul E. McKenney
On Sat, Jul 08, 2017 at 10:35:43AM +0200, Ingo Molnar wrote: > > * Manfred Spraul wrote: > > > Hi Ingo, > > > > On 07/07/2017 10:31 AM, Ingo Molnar wrote: > > > > > > There's another, probably just as significant advantage: > > > queued_spin_unlock_wait() > > > is

[GIT] Networking

2017-07-08 Thread David Miller
Mostly fixing some light fallout from the changes that went into the merge window. 1) Fix memory leaks on network namespace teardown in netfilter, from Liping Zhang. 2) When comparing ipv6 nexthops, we have to take the lightweight tunnel state into account as well. From David Ahern. 3)

Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_probe()

2017-07-08 Thread David Miller
From: "Gustavo A. R. Silva" Date: Fri, 7 Jul 2017 15:23:34 -0500 > Remove useless local variables _match_, _soc_ and the code related. > > Notice that > > const struct of_device_id of_mtk_match[] = { > { .compatible = "mediatek,mt2701-eth" }, > {}, > };

Re: [PATCH net] mpls: fix uninitialized in_label var warning in mpls_getroute

2017-07-08 Thread David Miller
From: Roopa Prabhu Date: Fri, 7 Jul 2017 11:21:49 -0700 > From: Roopa Prabhu > > Fix the below warning generated by static checker: > net/mpls/af_mpls.c:2111 mpls_getroute() > error: uninitialized symbol 'in_label'." > > Fixes:

Re: [PATCH net] doc: SKB_GSO_[IPIP|SIT] have been replaced

2017-07-08 Thread David Miller
From: Nicolas Dichtel Date: Fri, 7 Jul 2017 14:08:25 +0200 > Those enum values don't exist anymore. > > Fixes: 7e13318daa4a ("net: define gso types for IPx over IPv4 and IPv6") > CC: Tom Herbert > Signed-off-by: Nicolas Dichtel

Re: [Patch net] bonding: avoid NETDEV_CHANGEMTU event when unregistering slave

2017-07-08 Thread David Miller
From: Cong Wang Date: Thu, 6 Jul 2017 15:01:57 -0700 > As Hongjun/Nicolas summarized in their original patch: > > " > When a device changes from one netns to another, it's first unregistered, > then the netns reference is updated and the dev is registered in the new >

Re: [PATCH net 0/2] rds-tcp: sock_graft() leak

2017-07-08 Thread David Miller
From: Sowmini Varadhan Date: Thu, 6 Jul 2017 08:15:05 -0700 > Following up on the discussion at > https://www.spinics.net/lists/netdev/msg442859.html > - make rds_tcp_accept_one() call sock_create_lite() > - add a WARN_ON() to sock_graft() > > Tested by running

Re: [PATCH net V2 0/2] Bugfixs for hns ethernet driver

2017-07-08 Thread David Miller
From: Lin Yun Sheng Date: Thu, 6 Jul 2017 10:21:58 +0800 > This patchset fix skb used after free and C45 op code issues > in hns driver. > > Patch V2: > 1. Remove ndev->feature checking in TX description patch. > 2. Add Fixes: Tag in patch description. > >

Re: [PATCH net] ip[6]: don't register inet[6]dev when dev is down

2017-07-08 Thread David Miller
From: Nicolas Dichtel Date: Wed, 5 Jul 2017 17:57:25 +0200 > From: Hongjun Li > > When the netdev event NETDEV_CHANGEMTU is triggered, the inet[6]dev may be > created even if the corresponding device is down. This may lead to a leak > in the

Re: [PATCH v2 RFC 0/13] Remove UDP Fragmentation Offload support

2017-07-08 Thread David Miller
From: Michal Kubecek Date: Fri, 7 Jul 2017 14:45:31 +0200 > On Fri, Jul 07, 2017 at 10:43:26AM +0100, David Miller wrote: >> >> This is an RFC patch series, based upon some discussions with >> various developers, that removes UFO offloading. >> >> Very few devices support

Re: [RFC PATCH 00/12] Implement XDP bpf_redirect vairants

2017-07-08 Thread David Miller
From: John Fastabend Date: Fri, 07 Jul 2017 10:48:36 -0700 > On 07/07/2017 10:34 AM, John Fastabend wrote: >> This series adds two new XDP helper routines bpf_redirect() and >> bpf_redirect_map(). The first variant bpf_redirect() is meant >> to be used the same way it

Re: [PATCH] net: macb: Adding Support for Jumbo Frames up to 10240 Bytes in SAMA5D3

2017-07-08 Thread David Miller
From: Nicolas Ferre Date: Wed, 5 Jul 2017 17:36:16 +0200 > From: vishnuvardhan > > As per the SAMA5D3 device specification it supports Jumbo frames. > But the suggested flag and length of bytes it supports was not updated > in this driver

Fwd: Request to add bluetooth module identifier to net/rfkill/rfkill-gpio.c

2017-07-08 Thread Sundar Nagarajan
Hi, I have a Cherry Trail laptop with an Atom X5-Z8300. It has a bluetooth chip that needs the r8723bs (coexisting RTL 8723BS wifi and bluetooth). I am using linux-next (20150817) with the r8723bs staging driver and the firmware and utility from https://github.com/lwfinger/rtl8723bs_bt by Larry

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Ingo Molnar
* Paul E. McKenney wrote: > On Fri, Jul 07, 2017 at 10:31:28AM +0200, Ingo Molnar wrote: > > [ . . . ] > > > In fact I'd argue that any future high performance spin_unlock_wait() user > > is > > probably better off open coding the unlock-wait poll loop (and

[PATCH v2] mrf24j40: Fix en error handling path in 'mrf24j40_probe()'

2017-07-08 Thread Christophe JAILLET
If this check fails, we must release some resources as done everywhere else in this function before returning an error code. Signed-off-by: Christophe JAILLET --- V2: initialization of ret in this erro path ws missing. Stupid me! ---

Re: [PATCH v2 0/9] Remove spin_unlock_wait()

2017-07-08 Thread Ingo Molnar
* Manfred Spraul wrote: > Hi Ingo, > > On 07/07/2017 10:31 AM, Ingo Molnar wrote: > > > > There's another, probably just as significant advantage: > > queued_spin_unlock_wait() > > is 'read-only', while spin_lock()+spin_unlock() dirties the lock cache > > line. On

[PATCH] mrf24j40: Fix en error handling path in 'mrf24j40_probe()'

2017-07-08 Thread Christophe JAILLET
If this check fails, we must release some resources as done everywhere else in this function before returning an error code. Signed-off-by: Christophe JAILLET --- drivers/net/ieee802154/mrf24j40.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 3/3] net: stmmac: Make 'alloc_dma_[rt]x_desc_resources()' look even closer

2017-07-08 Thread Christophe JAILLET
'alloc_dma_[rt]x_desc_resources()' functions look very close. Remove a useless initialization and use the same label name for error handling path in order to get them even closer. Signed-off-by: Christophe JAILLET ---

[PATCH 1/3] net: stmmac: Fix error handling path in 'alloc_dma_rx_desc_resources()'

2017-07-08 Thread Christophe JAILLET
If the first 'kmalloc_array' within the loop fails, we should free what as already been allocated, as done in all other error handling path. Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx") Signed-off-by: Christophe JAILLET ---

[PATCH 2/3] net: stmmac: Fix error handling path in 'alloc_dma_tx_desc_resources()'

2017-07-08 Thread Christophe JAILLET
If the first 'kmalloc_array' within the loop fails, we should free what as already been allocated, as done in all other error handling path. Fixes: ce736788e8a9 ("net: stmmac: adding multiple buffers for TX") Signed-off-by: Christophe JAILLET ---

[PATCH 0/3] net: stmmac: Fixes and cleanups in 'alloc_dma_[rt]x_desc_resources()'

2017-07-08 Thread Christophe JAILLET
These patchs are all related to 'alloc_dma_[rt]x_desc_resources()' functions. The 2 first fix an error path where some resources are leaking. I've separated them into 2 patches because the issues have been introduced by 2 deferent commits. The 3rd patch is just a clean-up. Christophe JAILLET

Re: [PATCH] net: ethernet: mediatek: remove useless code in mtk_probe()

2017-07-08 Thread Sean Wang
Hi, Gustavo It indeed is useless at the current time point. but actually I will add new SoC support to the driver in the next week, which requires the variable match :-( Sean On Fri, 2017-07-07 at 15:23 -0500, Gustavo A. R. Silva wrote: > Remove useless local variables _match_,

Re: [PATCH iproute2] ip: change flag names to an array

2017-07-08 Thread Lorenzo Colitti
On Sat, Jul 8, 2017 at 12:39 AM, Stephen Hemminger wrote: > For the most of the address flags, use a table of bit values rather > than open coding every value. This allows for easier inevitable > expansion of flags. Thanks for doing this. > +static unsigned int