Re: [PATCH net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission.

On Tue, Jul 25, 2017 at 7:12 PM, maowenan wrote: > > > > > -Original Message- > > From: Neal Cardwell [mailto:ncardw...@google.com] > > Sent: Tuesday, July 25, 2017 9:30 PM > > To: maowenan > > Cc: Netdev; David Miller; weiyongjun (A); Chenweilong; Yuchung Cheng; > >

Re: [PATCH RFC 00/13] phylink and sfp support

On Tue, Jul 25, 2017 at 03:01:39PM +0100, Russell King - ARM Linux wrote: > Hi, > > This patch series introduces generic support for SFP sockets found on > various Marvell based platforms. The idea here is to provide common > SFP socket support which can be re-used by network drivers as >

Re: [PATCH net] udp: unbreak build lacking CONFIG_XFRM

From: Paolo Abeni Date: Wed, 26 Jul 2017 11:33:49 +0200 > We must use pre-processor conditional block or suitable accessors to > manipulate skb->sp elsewhere builds lacking the CONFIG_XFRM will break. > > Fixes: dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC") >

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: > Add documentation to describe usage of the new fixed transceiver binding. > This new binding is applicable for any CAN device therefore it exists as > its own document. > > Signed-off-by: Franklin S Cooper Jr

Re: [PATCH] hamradio: dmascc: avoid -Wformat-overflow warning

From: Arnd Bergmann Date: Wed, 26 Jul 2017 09:55:33 +0200 > gcc warns that the device name might overflow: > > drivers/net/hamradio/dmascc.c: In function 'dmascc_init': > drivers/net/hamradio/dmascc.c:584:22: error: 'sprintf' may write a > terminating nul past the end of the

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

On Mon, Jul 24, 2017 at 03:48:40PM +0200, Antoine Tenart wrote: > This patch adds the GoP link interrupt support for when a port isn't > connected to a PHY. Because of this the phylib callback is never called > and the link status management isn't done. This patch use the GoP link > interrupt in

Re: [PATCH iproute2] bridge: Assume master at FDB modification

On 07/26/2017 07:08 PM, Stephen Hemminger wrote: > On Wed, 26 Jul 2017 18:36:34 +0300 > Arkadi Sharshevsky wrote: > >> According to the man page the master flag should be the default, yet, the >> current code assumes otherwise. >> >> Signed-off-by: Arkadi Sharshevsky

Re: [PATCH net-next 08/18] net: mvpp2: make the phy optional

On Mon, Jul 24, 2017 at 03:48:38PM +0200, Antoine Tenart wrote: > SFP ports do not necessarily need to have an Ethernet PHY between the > SoC and the actual physical port. However, the driver currently makes > the "phy" property mandatory, contrary to what is stated in the Device > Tree binding. >

Re: [PATCH net-next 07/18] net: mvpp2: initialize the GoP

> + switch (port->phy_interface) { > + case PHY_INTERFACE_MODE_RGMII: Here as well, Andrew

Re: [PATCH net-next 05/18] net: mvpp2: initialize the GMAC when using a port

> + } else if (port->phy_interface == PHY_INTERFACE_MODE_RGMII) { Don't forget: PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, > + val = readl(port->base + MVPP22_GMAC_CTRL_4_REG); > + val |=

[PULL] vhost: fixes, cleanups

All's quiet here this cycle, just some minor fixes. A block printk message bugfix is still pending for the next pull, didn't want to delay this one as people are getting impatient. The following changes since commit 520eccdfe187591a51ea9ab4c1a024ae4d0f68d9: Linux 4.13-rc2 (2017-07-23 16:15:17

Re: [PATCH net-next 04/18] net: mvpp2: move the mii configuration in the ndo_open path

On Mon, Jul 24, 2017 at 03:48:34PM +0200, Antoine Tenart wrote: > This moves the mii configuration in the ndo_open path, to allow handling > different mii configurations later and to switch between these > configurations at runtime. > > Signed-off-by: Antoine Tenart

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On Wed, Jul 26, 2017 at 09:37:15PM +0800, Jason Wang wrote: > > > On 2017年07月26日 21:18, Jason Wang wrote: > > > > > > On 2017年07月26日 20:57, Michael S. Tsirkin wrote: > > > On Wed, Jul 26, 2017 at 04:03:17PM +0800, Jason Wang wrote: > > > > This reverts commit

Re: [PATCH net-next 03/18] net: mvpp2: set the SMI PHY address when connecting to the PHY

On Mon, Jul 24, 2017 at 03:48:33PM +0200, Antoine Tenart wrote: > When connecting to the PHY, explicitly set the SMI PHY address in the > controller registers to configure a given port to be connected to the > selected PHY. > > Signed-off-by: Antoine Tenart >

Re: [PATCH iproute2] bridge: Assume master at FDB modification

On Wed, 26 Jul 2017 18:36:34 +0300 Arkadi Sharshevsky wrote: > According to the man page the master flag should be the default, yet, the > current code assumes otherwise. > > Signed-off-by: Arkadi Sharshevsky Agree that the documentation and code

[PATCH iproute2] bridge: Assume master at FDB modification

According to the man page the master flag should be the default, yet, the current code assumes otherwise. Signed-off-by: Arkadi Sharshevsky --- bridge/fdb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bridge/fdb.c b/bridge/fdb.c index

[PATCH net] udp6: fix socket leak on early demux

When an early demuxed packet reaches __udp6_lib_lookup_skb(), the sk reference is retrieved and used, but the relevant reference count is leaked and the socket destructor is never called. Beyond leaking the sk memory, if there are pending UDP packets in the receive queue, even the related

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On Wed, Jul 26, 2017 at 09:18:02PM +0800, Jason Wang wrote: > > > On 2017年07月26日 20:57, Michael S. Tsirkin wrote: > > On Wed, Jul 26, 2017 at 04:03:17PM +0800, Jason Wang wrote: > > > This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it > > > was reported to break vhost_net. We

[PATCH 2/2] phy: bcm-ns-usb3: fix MDIO_BUS dependency

The driver attempts to 'select MDIO_DEVICE', but the code is actually a loadable module when PHYLIB=m: drivers/phy/broadcom/phy-bcm-ns-usb3.o: In function `bcm_ns_usb3_mdiodev_phy_write': phy-bcm-ns-usb3.c:(.text.bcm_ns_usb3_mdiodev_phy_write+0x28): undefined reference to `mdiobus_write'

[PATCH 1/2] net: phy: rework Kconfig settings for MDIO_BUS

I still see build errors in randconfig builds and have had this patch for a while to locally work around it: drivers/built-in.o: In function `xgene_mdio_probe': mux-core.c:(.text+0x352154): undefined reference to `of_mdiobus_register' mux-core.c:(.text+0x352168): undefined reference to

Re: [PATCH V2 3/4] net-next: dsa: fix flow dissection

On Fri, Jul 21, 2017 at 10:58:12AM +0200, John Crispin wrote: > RPS and probably other kernel features are currently broken on some if not > all DSA devices. The root cause of this is that skb_hash will call the > flow_dissector. At this point the skb still contains the magic switch header > and

[no subject]

Greetings Netdev http://mondesign.jp/list-view.php?result=2b7f5x3fc4gxussdn venkatvenkatsubra

Re: [PATCH V2 1/4] net-next: dsa: move struct dsa_device_ops to the global header file

On Fri, Jul 21, 2017 at 10:58:10AM +0200, John Crispin wrote: > We need to access this struct from within the flow_dissector to fix > dissection for packets coming in on DSA devices. > > Signed-off-by: John Crispin Reviewed-by: Andrew Lunn Andrew

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 07:32:12AM -0700, Eric Dumazet wrote: > On Wed, 2017-07-26 at 15:42 +0200, Willy Tarreau wrote: > > On Wed, Jul 26, 2017 at 06:31:21AM -0700, Eric Dumazet wrote: > > > On Wed, 2017-07-26 at 14:18 +0200, Klavs Klavsen wrote: > > > > the 192.168.32.44 is a Centos 7 box. > > >

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

On 26. juli 2017 16:30, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: I'd suggest you to split up this one commit in several *atomic* and easy to review patches and send them separately as on thread named "net: dsa: lan9303: fix MDIO interface" (also note

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 04:25:29PM +0200, Klavs Klavsen wrote: > Thank you very much guys for your insight.. its highly appreciated. > > Next up for me, is waiting till the network guys come back from summer > vacation, and convince them to sniff on the devices in between to pinpoint > the

Re: netlink: NULL timer crash

Wo, thanks! On Wed, Jul 26, 2017 at 9:13 PM, Dmitry Vyukov wrote: > On Wed, Jul 26, 2017 at 3:09 PM, wrote: >> Hi Dmitry, >> >> By trying to apply your reproducer to normal kernels, this scenery can not >> be reproduced (on fedora). Does this C

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

Hi Egil, Egil Hjelmeland writes: >> I'd suggest you to split up this one commit in several *atomic* and easy >> to review patches and send them separately as on thread named "net: dsa: >> lan9303: fix MDIO interface" (also note that imperative is prefered for >>

Re: TCP fast retransmit issues

On Wed, 2017-07-26 at 15:42 +0200, Willy Tarreau wrote: > On Wed, Jul 26, 2017 at 06:31:21AM -0700, Eric Dumazet wrote: > > On Wed, 2017-07-26 at 14:18 +0200, Klavs Klavsen wrote: > > > the 192.168.32.44 is a Centos 7 box. > > > > Could you grab a capture on this box, to see if the bogus packets

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 04:08:19PM +0200, Klavs Klavsen wrote: > Grabbed on both ends. > > http://blog.klavsen.info/fast-retransmit-problem-junos-linux (updated to new > dump - from client scp'ing) > http://blog.klavsen.info/fast-retransmit-problem-junos-linux-receiving-side > (receiving host)

Re: TCP fast retransmit issues

Thank you very much guys for your insight.. its highly appreciated. Next up for me, is waiting till the network guys come back from summer vacation, and convince them to sniff on the devices in between to pinpoint the culprit :) Willy Tarreau skrev den 2017-07-26 16:18: On Wed, Jul 26, 2017

Re: [patch net-next 2/2] mlxsw: spectrum: Add support for access cable info via ethtool

> +static int mlxsw_sp_get_module_info(struct net_device *netdev, > + struct ethtool_modinfo *modinfo) > +{ > + struct mlxsw_sp_port *mlxsw_sp_port = netdev_priv(netdev); > + u8 module_info[MLXSW_SP_EEPROM_MODULE_INFO_SIZE]; > + u8 module_rev_id,

Re: TCP fast retransmit issues

Grabbed on both ends. http://blog.klavsen.info/fast-retransmit-problem-junos-linux (updated to new dump - from client scp'ing) http://blog.klavsen.info/fast-retransmit-problem-junos-linux-receiving-side (receiving host) Eric Dumazet skrev den 2017-07-26 15:31: On Wed, 2017-07-26 at 14:18

Re: [BUG] /net/hsr: prune_timer

On Tue, Jul 18, 2017 at 1:07 AM, Dmitry wrote: Hello! void hsr_prune_nodes(unsigned long data) called once by timer. hsr_prune_nodes must be called periodically every PRUNE_PERIOD (60s). This code want be added to tail of hsr_prune_nodes function

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 06:31:21AM -0700, Eric Dumazet wrote: > On Wed, 2017-07-26 at 14:18 +0200, Klavs Klavsen wrote: > > the 192.168.32.44 is a Centos 7 box. > > Could you grab a capture on this box, to see if the bogus packets are > sent by it, or later mangled by a middle box ? Given the

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On 2017年07月26日 21:18, Jason Wang wrote: On 2017年07月26日 20:57, Michael S. Tsirkin wrote: On Wed, Jul 26, 2017 at 04:03:17PM +0800, Jason Wang wrote: This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it was reported to break vhost_net. We want to cache used event and use it

Re: TCP fast retransmit issues

On Wed, 2017-07-26 at 14:18 +0200, Klavs Klavsen wrote: > the 192.168.32.44 is a Centos 7 box. Could you grab a capture on this box, to see if the bogus packets are sent by it, or later mangled by a middle box ? > > Could you help me by elaborating on how to see why the "dup ack" (sack >

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On 2017年07月26日 20:57, Michael S. Tsirkin wrote: On Wed, Jul 26, 2017 at 04:03:17PM +0800, Jason Wang wrote: This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it was reported to break vhost_net. We want to cache used event and use it to check for notification. We try to valid

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Wed, Jul 26, 2017 at 12:54 PM, Sathya Perla wrote: > On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: > [...] >>> Sathya already sent 3 patches to fix some of these issues. But I need >>> to rework one of his patch and resend. >> >> Ok, thanks.

Re: linux-next: Tree for Jul 26

Hello, On (07/26/17 13:09), Rosen, Rami wrote: > Hi Sergey, > Paolo Abeni had sent a patch: > https://www.mail-archive.com/netdev@vger.kernel.org/msg179192.html yep, this should do the trick. thanks. -ss

Re: [PATCH net] sctp: fix the check for _sctp_walk_params and _sctp_walk_errors

On Wed, Jul 26, 2017 at 04:24:59PM +0800, Xin Long wrote: > Commit b1f5bfc27a19 ("sctp: don't dereference ptr before leaving > _sctp_walk_{params, errors}()") tried to fix the issue that it > may overstep the chunk end for _sctp_walk_{params, errors} with > 'chunk_end > offset(length) +

Re: netlink: NULL timer crash

On Wed, Jul 26, 2017 at 3:09 PM, wrote: > Hi Dmitry, > > By trying to apply your reproducer to normal kernels, this scenery can not > be reproduced (on fedora). Does this C source only for KASAN kernels? No, NULL derefs are detected without KASAN. > On Thursday,

[PATCH v2 net-next 0/7] qed/qede: Enhancements

Hi David, This patch series adds these below features support in qed/qede 1) Ntuple filter configuration [via ethtool -n/N] 2) EEE (energy efficient ethernet) support [ethtool --set-eee/show-eee] 3) Coalescing configuration support for VFs [via ethtool -c/C] Please consider applying this to

RE: linux-next: Tree for Jul 26

Hi Sergey, Paolo Abeni had sent a patch: https://www.mail-archive.com/netdev@vger.kernel.org/msg179192.html Regards, Rami Rosen -Original Message- From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On Behalf Of Sergey Senozhatsky Sent: Wednesday, July 26, 2017

[PATCH v2 net-next 3/7] qed: Add support for Energy efficient ethernet.

From: Sudarsana Reddy Kalluru The patch adds required driver support for reading/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz

[PATCH v2 net-next 7/7] qed: enhanced per queue max coalesce value.

From: Rahul Verma Maximum coalesce per Rx/Tx queue is extended from 255 to 511. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- include/linux/qed/qed_if.h |2 +- 1 files changed, 1 insertions(+), 1

[PATCH v2 net-next 4/7] qede: Add ethtool support for Energy efficient ethernet.

From: Sudarsana Reddy Kalluru The patch adds ethtool callback implementations for querying/configuring the Energy Efficient Ethernet (EEE) parameters. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz

[PATCH v2 net-next 1/7] qede: Add getter APIs support for RX flow classification

This patch adds support for ethtool getter APIs to query RX flow classification rules. Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede.h | 10 ++-

[PATCH v2 net-next 6/7] qed: Read per queue coalesce from hardware

From: Rahul Verma Retrieve the actual coalesce value from hardware for every Rx/Tx queue, instead of Rx/Tx coalesce value cached during set coalesce. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz ---

[PATCH v2 net-next 5/7] qed: Add support for vf coalesce configuration.

From: Rahul Verma This patch add the ethtool support to set RX/Tx coalesce value to the VF associated Rx/Tx queues. Signed-off-by: Rahul Verma Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/qed_dev.c

[PATCH v2 net-next 2/7] qed/qede: Add setter APIs support for RX flow classification

This patch adds support for adding and deleting rx flow classification rules. Using this user can classify RX flow constituting of TCP/UDP 4-tuples [src_ip/dst_ip and src_port/dst_port] to be steered on a given RX queue Signed-off-by: Manish Chopra Signed-off-by: Yuval

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On Wed, Jul 26, 2017 at 04:03:17PM +0800, Jason Wang wrote: > This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it > was reported to break vhost_net. We want to cache used event and use > it to check for notification. We try to valid cached used event by > checking whether or not

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

OK, we will use module_pci_driver although it is not very common in the same segment. On 7/25/2017 11:02 PM, Francois Romieu wrote: > Aviad Krawczyk : > [...] >> module_pci_driver - is not used in other drivers in the same segments, it >> is necessary ? > > /me

Re: TCP fast retransmit issues

the 192.168.32.44 is a Centos 7 box. Could you help me by elaborating on how to see why the "dup ack" (sack blocks) are bogus? Thank you very much. I'll try to capture the same scp done on mac - and see if it also gets DUP ACK's - and how they look in comparison (since it works on Mac

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

On 25. juli 2017 21:15, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: Fixes after testing on actual HW: - lan9303_mdio_write()/_read() must multiply register number by 4 to get offset - Indirect access (PMI) to phy register only work in I2C mode. In

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On 2017年07月26日 18:53, Christian Borntraeger wrote: On 07/26/2017 10:03 AM, Jason Wang wrote: This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it was reported to break vhost_net. We want to cache used event and use it to check for notification. We try to valid cached used

Re: TCP fast retransmit issues

On Wed, 2017-07-26 at 13:07 +0200, Klavs Klavsen wrote: > Hi guys, > > Me and my colleagues have an annoying issue with our Linux desktops and > the company's Junos VPN. > > We connect with openconnect (some use the official Pulse client) - which > then opens up a tun0 device - and traffic

Re: mlx5 still has lots of warnings

On Mon, Jul 24, 2017 at 7:51 PM, Stephen Hemminger wrote: > I sent patches for this, and you said you were going to solve this (back in > April). > Still see lots of warnings from MLX5. > Hi Stephen, You are right, we were planning to do some code refactoring to

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Wed, Jul 26, 2017 at 2:35 PM, Arnd Bergmann wrote: [...] >> Sathya already sent 3 patches to fix some of these issues. But I need >> to rework one of his patch and resend. > > Ok, thanks. I just ran into one more issue, and don't know if that's included > as well. If not,

Re: [PATCH net] Revert "vhost: cache used event for better performance"

On 07/26/2017 10:03 AM, Jason Wang wrote: > This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it > was reported to break vhost_net. We want to cache used event and use > it to check for notification. We try to valid cached used event by > checking whether or not it was ahead of

Re: linux-next: Tree for Jul 26

Hello, On (07/26/17 16:12), Stephen Rothwell wrote: > Hi all, > > Changes since 20170725: > > Non-merge commits (relative to Linus' tree): 2358 > 2466 files changed, 86994 insertions(+), 44655 deletions(-) dce4551cb2adb1ac ("udp: preserve head state for IP_CMSG_PASSSEC") causes a build error

[net-next 14/14] i40e: handle setting administratively set MAC address back to zero

From: Stefan Assmann When an administratively set MAC was previously set and should now be switched back to 00:00:00:00:00:00 the pf_set_mac flag did not get toggled back to false. As a result VFs were still treated as if an administratively set MAC was present.

[net-next 13/14] i40evf: remove unnecessary __packed

From: Tushar Dave This is similar to 'commit 9588397d24eec ("i40e: remove unnecessary __packed")' to avoid unaligned access. Signed-off-by: Tushar Dave Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher

[net-next 12/14] i40evf: Use le32_to_cpu before evaluating HW desc fields

From: Tushar Dave i40e hardware descriptor fields are in little-endian format. Driver must use le32_to_cpu while evaluating these fields otherwise on big-endian arch we end up evaluating incorrect values, cause errors like: i40evf :03:0a.0: Expected response 24 from

[net-next 10/14] i40evf: add some missing includes

From: Jesse Brandeburg These includes were all being used in the driver, but weren't being directly included. Since the current advised method is to directly include anything that you need, this implements that. Signed-off-by: Jesse Brandeburg

[net-next 11/14] i40e: report BPF prog id during XDP_QUERY_PROG

From: Daniel Borkmann Fill the XDP prog_id with the id just like we do in other XDP enabled drivers such as ixgbe. This is needed so that on dump we can retrieve the attached program based on the id, and dump BPF insns, opcodes, etc back to user space. Only XDP driver

[net-next 08/14] i40e/i40evf: remove mismatched type warnings

From: Jesse Brandeburg Compiler reported several places where driver compared signed and unsigned types. Cast or change the types to remove the warnings. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers

[net-next 09/14] i40e: display correct UDP tunnel type name

From: Jacob Keller The i40e driver attempts to display the UDP tunnel name by doing a check against the type, where for non-zero types we use "vxlan" and for zero type we use "geneve". This is not future proof, because if new tunnel types get added, we'll incorrectly

[net-next 07/14] i40e/i40evf: make IPv6 ATR code clearer

From: Jesse Brandeburg This just reorders some local vars and makes the code flow clearer. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher ---

[net-next 06/14] i40e: fix odd formatting and indent

From: Jesse Brandeburg The compiler warned on an oddly indented bit of code, and when investigating that, noted that the functions themselves had an odd flow. The if condition was checked, and would exclude a call to AQ, but then the aq_ret would be checked

[net-next 05/14] i40e: fix up 32 bit timespec references

From: Jesse Brandeburg As it turns out there was only a small set of errors on 32 bit, and we just needed to be using the right calls for dealing with timespec64 variables. Signed-off-by: Jesse Brandeburg Tested-by: Andrew Bowers

[net-next 03/14] i40e: remove WQ_UNBOUND and the task limit of our workqueue

From: Jacob Keller During certain events such as a CORER, multiple devices will run a work task to handle some cleanup. This can cause issues due to a single-threaded workqueue which can mean that a device doesn't cleanup in time. Prevent this by removing the

[net-next 04/14] i40e: Handle admin Q timeout when releasing NVM

From: Paul M Stillwell Jr There are some rare cases where the release resource call will return an admin Q timeout. In these cases the code needs to try to release the resource again until it succeeds or it times out. Signed-off-by: Paul M Stillwell Jr

[net-next 02/14] i40e: Fix for trace found with S4 state

From: Carolyn Wyborny This patch fixes a problem found in systems when entering S4 state. This patch fixes the problem by ensuring that the misc vector's IRQ is disabled as well. Without this patch a stack trace can be seen upon entering S4 state. Signed-off-by:

[net-next 01/14] i40e: fix incorrect variable assignment

From: Gustavo A R Silva Fix incorrect variable assignment. Based on line 1511: aq_ret = I40_ERR_PARAM; the correct variable to be used in this instance is aq_ret instead of ret. Also, variable ret is updated at line 1602 just before return, so assigning a value to this

[net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2017-07-25

This series contains updates to i40e and i40evf only. Gustavo Silva fixes a variable assignment, where the incorrect variable was being used to store the error parameter. Carolyn provides a fix for a problem found in systems when entering S4 state, by ensuring that the misc vector's IRQ is

Re: [PATCH V2 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

On 7/26/2017 12:44 PM, Mao Wenan wrote: If there is one TLP probe went out(TLP use the write_queue_tail packet as TLP probe, we assume this first TLP probe named A), and this TLP probe was not acked by receive side. Then the transmit side sent the next two packetes out(named B,C), but

[PATCH V2 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

If there is one TLP probe went out(TLP use the write_queue_tail packet as TLP probe, we assume this first TLP probe named A), and this TLP probe was not acked by receive side. Then the transmit side sent the next two packetes out(named B,C), but unfortunately these two packets are also not acked

Re: [PATCH net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission.

Hi Mao, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Mao-Wenan/TLP-Don-t-reschedule-PTO-when-there-s-one-outstanding-TLP-retransmission/20170726-17 config: x86_64-randconfig-x000-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3

[PATCH net] udp: unbreak build lacking CONFIG_XFRM

We must use pre-processor conditional block or suitable accessors to manipulate skb->sp elsewhere builds lacking the CONFIG_XFRM will break. Fixes: dce4551cb2ad ("udp: preserve head state for IP_CMSG_PASSSEC") Signed-off-by: Paolo Abeni --- net/ipv4/udp.c | 2 +- 1 file

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Wed, Jul 26, 2017 at 11:13 AM, Jakub Kicinski wrote: > On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: >> I think it would make sense if the driver would just fill-up a struct in >> the ndo call and core would generate the string. > I do like the idea of core generating

[PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib result when requested"). When we get a prohibit ertry, we will return -EACCES directly. Before: + ip netns exec client ip -6 route get 2003::1 prohibit 2003::1 dev lo table unspec proto kernel src 2001::1 metric 4294967295

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Tue, Jul 25, 2017 at 10:49:05AM -0700, Cong Wang wrote: > On Mon, Jul 24, 2017 at 5:08 PM, Hangbin Liu wrote: > > But what we want in inet6_rtm_getroute() and rt6_dump_route() is to > > get/dump the route info. So we should get the info even it's unreachable or > >

Re: [PATCH net-next 10/10] bnxt_en: add support for port_attr_get and and get_phys_port_name

On Tue, Jul 25, 2017 at 7:45 AM, Jakub Kicinski wrote: > This is even worse. We already have two naming conventions in the > kernel, mlx5 uses "%d" for legacy reasons. nfp uses pf%dvf%d for vfs, To make it clear, in mlx5 this is used only for the offloads/switchdev mode and

Re: [PATCH net-next 2/2] bnxt_en: define sriov_lock unconditionally

On Tue, Jul 25, 2017 at 6:36 PM, Michael Chan wrote: > On Tue, Jul 25, 2017 at 8:29 AM, Arnd Bergmann wrote: >> The sriov_lock is used to serialize the sriov code with the vfr code. >> However, when SRIOV is disabled, the lock is not there at all,

Re: TC-pedit man page examples error

Hi Tyler, On Tue, Jul 25, 2017 at 08:33:40AM -0700, Tyler Bautista wrote: > To whom it may concern, > I recently attempted to use simple tc action pedit commands on the man > page and I ran into some errors. The following is some information > about my version of iproute and my machine: >

Re: After a while of system running no incoming UDP any more?

On Wed, 2017-07-26 at 10:10 +0200, Marc Haber wrote: > On Tue, Jul 25, 2017 at 02:17:52PM +0200, Paolo Abeni wrote: > > On Tue, 2017-07-25 at 13:57 +0200, Marc Haber wrote: > > > On Mon, Jul 24, 2017 at 04:19:10PM +0200, Paolo Abeni wrote: > > > > Once that a system enter the buggy status, do the

[PATCH net] sctp: fix the check for _sctp_walk_params and _sctp_walk_errors

Commit b1f5bfc27a19 ("sctp: don't dereference ptr before leaving _sctp_walk_{params, errors}()") tried to fix the issue that it may overstep the chunk end for _sctp_walk_{params, errors} with 'chunk_end > offset(length) + sizeof(length)'. But it introduced a side effect: When processing INIT, it

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: > Tue, Jul 25, 2017 at 07:13:44AM CEST, jakub.kicin...@netronome.com wrote: > >We are still in position where we can suggest uniform naming > >convention for ndo_get_phys_port_name(). switchdev.txt file > >already contained a suggestion of how

Re: After a while of system running no incoming UDP any more?

On Tue, Jul 25, 2017 at 02:17:52PM +0200, Paolo Abeni wrote: > On Tue, 2017-07-25 at 13:57 +0200, Marc Haber wrote: > > On Mon, Jul 24, 2017 at 04:19:10PM +0200, Paolo Abeni wrote: > > > Once that a system enter the buggy status, do the packets reach the > > > relevant socket's queue? > > > > > >

[PATCH net] Revert "vhost: cache used event for better performance"

This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it was reported to break vhost_net. We want to cache used event and use it to check for notification. We try to valid cached used event by checking whether or not it was ahead of new, but this is not correct all the time, it could

[PATCH] hamradio: dmascc: avoid -Wformat-overflow warning

gcc warns that the device name might overflow: drivers/net/hamradio/dmascc.c: In function 'dmascc_init': drivers/net/hamradio/dmascc.c:584:22: error: 'sprintf' may write a terminating nul past the end of the destination [-Werror=format-overflow=] sprintf(dev->name, "dmascc%i", 2 * n + i);

Re: [PATCH v2 00/10] Constify attribute_group structures

Hi Kalle, On Tuesday 25 July 2017 06:25 PM, Kalle Valo wrote: Arvind Yadav writes: attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group

Re: [PATCH v2 00/10] Constify attribute_group structures

Hi Kalle, On Tuesday 25 July 2017 06:25 PM, Kalle Valo wrote: Arvind Yadav writes: attribute_groups are not supposed to change at runtime. So mark the non-const structs as const. Arvind Yadav (10): [PATCH v2 01/10] net: cdc_ncm: constify attribute_group

[lkp-robot] [lib] e859afe1ee: kernel_BUG_at_lib/test_rhashtable.c

FYI, we noticed the following commit: commit: e859afe1ee0c5ae981c55387ccd45eba258a7842 ("lib: test_rhashtable: fix for large entry counts") https://git.kernel.org/cgit/linux/kernel/git/davem/net.git master in testcase: boot on test machine: qemu-system-x86_64 -enable-kvm -m 420M caused below

[PATCH net] dccp: fix a memleak for dccp_feat_init err process

In dccp_feat_init, when ccid_get_builtin_ccids failsto alloc memory for rx.val, it should free tx.val before returning an error. Signed-off-by: Xin Long --- net/dccp/feat.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/net/dccp/feat.c

[PATCH net] dccp: fix a memleak that dccp_ipv4 doesn't put reqsk properly

The patch "dccp: fix a memleak that dccp_ipv6 doesn't put reqsk properly" fixed reqsk refcnt leak for dccp_ipv6. The same issue exists on dccp_ipv4. This patch is to fix it for dccp_ipv4. Signed-off-by: Xin Long --- net/dccp/ipv4.c | 1 + 1 file changed, 1 insertion(+)

[PATCH net] dccp: fix a memleak that dccp_ipv6 doesn't put reqsk properly

In dccp_v6_conn_request, after reqsk gets alloced and hashed into ehash table, reqsk's refcnt is set 3. one is for req->rsk_timer, one is for hlist, and the other one is for current using. The problem is when dccp_v6_conn_request returns and finishes using reqsk, it doesn't put reqsk. This will

Re: [PATCH 0/8] net: mvpp2: add TX interrupts support

Hi Thomas, I tested patchset on A8040-DB, everything seems fine. Best regards, Marcin 2017-07-25 17:55 GMT+02:00 Thomas Petazzoni : > Hello, > > So far, the mvpp2 driver was using an hrtimer to handle TX > completion. This patch series adds support for using

<    1   2