Re: [PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile

From: mohamedalrshah Date: Wed, 2 Aug 2017 12:37:01 +0800 > +//#define NS_PROTOCOL "tcp_agilesd.c" > +//#include "../ns-linux-c.h" > +//#include "../ns-linux-util.h" > +//#include There is no way this submission will be considered seriously with all of this cruft in

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

Hi João Paulo, On Tue, 2017-08-01 at 15:58 -0700, João Paulo Rechi Vita wrote: > Hello Luca, > > On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano > wrote: > > On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: > > (...) > > > > Currently these messages

[PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile

Published: Alrshah, M.A., Othman, M., Ali, B. and Hanapi, Z.M., 2015. Agile-SD: a Linux-based TCP congestion control algorithm for supporting high-speed and short-distance networks. Journal of Network and Computer Applications, 55, pp.181-190. Agile-SD is a new loss-based and RTT-independent

[PATCH] Adding Agile-SD TCP module and modifying Kconfig and Makefile

Published: Alrshah, M.A., Othman, M., Ali, B. and Hanapi, Z.M., 2015. Agile-SD: a Linux-based TCP congestion control algorithm for supporting high-speed and short-distance networks. Journal of Network and Computer Applications, 55, pp.181-190. Agile-SD is a new loss-based and RTT-independent

[no subject]

внимания; Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных администратором, который в настоящее время работает на 10.9GB, Вы не сможете отправить или получить новую почту, пока вы повторно не проверить ваш почтовый ящик почты. Чтобы восстановить работоспособность

Re: [PATCH v2 05/11] net: stmmac: dwmac-rk: Add internal phy support

Hi David, Florian, Andrew (resent in plain text) On Fri, Jul 28, 2017 at 2:56 PM, David.Wu wrote: > > Hi Florian, > > 在 2017/7/28 0:54, Florian Fainelli 写道: >> >> - if you need knowledge about this PHY connection type prior to binding >> the PHY device and its driver

Re: Extremely important and Urgent

I am getting in touch with you regarding an extremely important and urgent matter. If you would oblige me the opportunity, I shall provide you with details upon your response. Faithfully, Ms. Singer Valve

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On 8/1/17 9:58 PM, Andrew Lunn wrote: The PHY does not participate directly in flow control/pause frames except by making sure that the SUPPORTED_Pause and SUPPORTED_AsymPause bits are set in MII_ADVERTISE to indicate towards the link partner that the Ethernet MAC controller supports

[PATCH v2 net-next 2/4] sock: ULP infrastructure

Generalize the TCP ULP infrastructure recently introduced to support kTLS. This adds a SO_ULP socket option and creates new fields in sock structure for ULP ops and ULP data. Also, the interface allows additional per ULP parameters to be set so that a ULP can be pushed and operations started in

[PATCH v2 net-next 4/4] ulp: Documention for ULP infrastructure

Add a doc in Documentation/networking Signed-off-by: Tom Herbert --- Documentation/networking/ulp.txt | 82 1 file changed, 82 insertions(+) create mode 100644 Documentation/networking/ulp.txt diff --git

[PATCH v2 net-next 0/4] ulp: Generalize ULP infrastructure

Generalize the ULP infrastructure that was recently introduced to support kTLS. This adds a SO_ULP socket option and creates new fields in sock structure for ULP ops and ULP data. Also, the interface allows additional per ULP parameters to be set so that a ULP can be pushed and operations started

[PATCH v2 net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

Fix TCP and TLS to use the newer ULP infrastructure in sockets. Signed-off-by: Tom Herbert --- Documentation/networking/tls.txt | 6 +- include/net/inet_connection_sock.h | 4 -- include/net/tcp.h | 25 --- include/net/tls.h |

[PATCH v2 net-next 1/4] inet: include net/sock.h in inet_common.h

inet_common.h has a dependency on sock.h so it should include that. Signed-off-by: Tom Herbert --- include/net/inet_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/net/inet_common.h b/include/net/inet_common.h index f39ae697347f..df0119a317aa 100644

Re: [PATCH net-next v2 00/11] net: dsa: rework EEE support

From: Vivien Didelot Date: Tue, 1 Aug 2017 16:32:30 -0400 > EEE implies configuring the port's PHY and MAC of both ends of the wire. > > The current EEE support in DSA mixes PHY and MAC configuration, which is > bad because PHYs must be configured through a

Re: [PATCH net 0/7] drivers: net: Fix 64-bit statistics seqcount init

From: Florian Fainelli Date: Tue, 1 Aug 2017 12:11:05 -0700 > This patch series fixes a bunch of drivers to have their 64-bit statistics > seqcount cookie be initialized correctly. Most of these drivers (except b44, > gtp) are probably used on 64-bit only hosts and so the

[PATCH net-next v3 1/3] netvsc: transparent VF management

This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of

[PATCH net-next v3 2/3] netvsc: add documentation

Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 63 + MAINTAINERS | 1 + 2 files changed, 64 insertions(+)

[PATCH net-next v3 3/3] netvsc: remove bonding setup script

No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git

[PATCH net-next v3 0/3] netvsc: transparent VF support

This patch set changes how SR-IOV Virtual Function devices are managed in the Hyper-V network driver. This version is rebased onto current net-next. Background In Hyper-V SR-IOV can be enabled (and disabled) by changing guest settings on host. When SR-IOV is enabled a matching PCI device is hot

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On Tue, Aug 01, 2017 at 07:56:31PM -0500, Timur Tabi wrote: > On 8/1/17 6:15 PM, Andrew Lunn wrote: > >Pause frames are something you can auto-negotiate at the PHY > >level. Should you also be clearing some bits in the phydev, so the > >peer knows pause frames are not supported? > > When pause

[PATCH net-next 4/4] ulp: Documention for ULP infrastructure

Add a doc in Documentation/networking Signed-off-by: Tom Herbert --- Documentation/networking/ulp.txt | 82 1 file changed, 82 insertions(+) create mode 100644 Documentation/networking/ulp.txt diff --git

[PATCH net-next 3/4] tcp: Adjust TCP ULP to defer to sockets ULP

Fix TCP and TLS to use the newer ULP infrastructure in sockets. Signed-off-by: Tom Herbert --- Documentation/networking/tls.txt | 6 +- include/net/inet_connection_sock.h | 4 -- include/net/tcp.h | 25 --- include/net/tls.h |

[PATCH net-next 2/4] sock: ULP infrastructure

Generalize the TCP ULP infrastructure recently introduced to support kTLS. This adds a SO_ULP socket option and creates new fields in sock structure for ULP ops and ULP data. Also, the interface allows additional per ULP parameters to be set so that a ULP can be pushed and operations started in

[PATCH net-next 1/4] inet: include net/sock.h in inet_common.h

inet_common.h has a dependency on sock.h so it should include that. Signed-off-by: Tom Herbert --- include/net/inet_common.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/net/inet_common.h b/include/net/inet_common.h index f39ae697347f..df0119a317aa 100644

[PATCH net-next 0/4] ulp: Generalize ULP infrastructure

Generalize the ULP infrastructure that was recently introduced to support kTLS. This adds a SO_ULP socket option and creates new fields in sock structure for ULP ops and ULP data. Also, the interface allows additional per ULP parameters to be set so that a ULP can be pushed and operations started

[RFC 1/1] constify tcp congestion

Split the TCP congestion ops structure into const and mutable portions. Put the list pointers, key and a copy of the flags in new tcp_congestion_entry structure. Signed-off-by: Stephen Hemminger --- include/net/tcp.h| 10 ++- net/ipv4/tcp.c | 2 -

[RFC 0/1] tcp: constify congestion_ops

This is a proposed method of making TCP congestion_ops structure const. I wonder if restricting congestion control choices is still necessary? It seems like being overly paranoid, and better enforced by having a more limited kernel config, seccomp or other mechanism. Stephen Hemminger (1):

Re: [PATCH net 6/7] netvsc: Initialize 64-bit stats seqcount

On Tue, 1 Aug 2017 12:11:12 -0700 Florian Fainelli wrote: > On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a > lockdep splat indicating this seqcount is not correctly initialized, fix > that. In commit 6c80f3fc2398 ("netvsc: report per-channel stats

Re: sysctl, argument parsing, possible bug

On Tue, 1 Aug 2017 14:27:37 -0700 Cong Wang wrote: > On Tue, Aug 1, 2017 at 1:47 PM, Massimo Sala > wrote: > > cat /proc/sys/net/ipv4/conf/eth0.100/forwarding > > 0 > > > > sysctl net.ipv4.conf.eth0.100.forwarding > > error:

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 4:12 AM, Jiri Pirko wrote: > Tue, Aug 01, 2017 at 02:37:37AM CEST, amritha.namb...@intel.com wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >>

Re: [PATCH 6/6] [net-next]net: i40e: Enable cloud filters in i40e via tc/flower classifier

On 8/1/2017 3:56 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:38 PM, Amritha Nambiar wrote: >> This patch enables tc-flower based hardware offloads. tc/flower >> filter provided by the kernel is configured as driver specific >> cloud filter. The patch implements functions and admin queue >>

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 3:44 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:37 PM, Amritha Nambiar wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >> Example: >> # tc filter

Re: [PATCH 1/6] [net-next]net: sched: act_mirred: Extend redirect action to accept a traffic class

On 8/1/2017 3:22 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:37 PM, Amritha Nambiar wrote: >> The Mirred/redirect action is extended to forward to a traffic >> class on the device. The traffic class index needs to be >> provided in addition to the device's ifindex. >> >> Example: >> # tc filter

Re: [PATCH net-next RFC 0/6] Configure cloud filters in i40e via tc/flower classifier

On 8/1/2017 3:15 AM, Jamal Hadi Salim wrote: > On 17-07-31 08:36 PM, Amritha Nambiar wrote: >> This patch series enables configuring cloud filters in i40e >> using the tc/flower classifier. The only tc-filter action >> supported is to redirect packets to a traffic class on the >> same device. The

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On 8/1/17 6:15 PM, Andrew Lunn wrote: Pause frames are something you can auto-negotiate at the PHY level. Should you also be clearing some bits in the phydev, so the peer knows pause frames are not supported? When pause frame autonegotiation is enabled in the driver, that only means that the

Re: [PATCH v3 0/2] ravb: add wake-on-lan support via magic packet

From: Niklas Söderlund Date: Tue, 1 Aug 2017 12:14:35 +0200 > WoL is enabled in the suspend callback by setting MagicPacket detection > and disabling all interrupts expect MagicPacket. In the resume path the > driver needs to reset the hardware to rearm

Re: pull request: bluetooth-next 2017-08-01

From: Johan Hedberg Date: Tue, 1 Aug 2017 12:41:56 +0300 > Here's our first batch of Bluetooth patches for the 4.14 kernel: > > - Several new USB IDs for the btusb driver > - Memory leak fix in btusb driver > - Cleanups & fixes to hci_nokia, hci_serdev and hci_bcm

Re: [PATCH net-next 00/10] net: l3mdev: Support for sockets bound to enslaved device

From: David Ahern Date: Mon, 31 Jul 2017 20:13:16 -0700 > Existing code for socket lookups already pass in 6+ arguments. Rather > than add another for the enslaved device index, the existing lookups > are converted to use a new sk_lookup struct. From there, the enslaved >

Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

On Tue, Aug 1, 2017 at 3:29 PM, David Miller wrote: > From: Kees Cook > Date: Sun, 30 Jul 2017 18:31:17 -0700 > >> In preparation for the randstruct gcc plugin performing randomization of >> structures that are entirely function pointers, use

[PATCH 1/2] atm: adummy: constify attribute_group structure

Functions working with attribute_groups provided by work with const attribute_group. These attribute_group structures do not change at runtime so mark them as const. File size before: text data bss dec hex filename 2033 1448 03481 d99 drivers/atm/adummy.o

[PATCH 2/2] atm: solos-pci: constify attribute_group structures

Functions working with attribute_groups provided by work with const attribute_group. These attribute_group structures do not change at runtime so mark them as const. File size before: text data bss dec hex filename 3574028424 832 64996fde4 drivers/atm/solos-pci.o

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On Tue, Aug 01, 2017 at 04:37:39PM -0500, Timur Tabi wrote: > The EMAC has a curious qwirk when RX flow control is enabled and the > kernel hangs. With the kernel hung, the EMAC's RX queue soon fills. > If RX flow control is enabled, the EMAC will then send a non-stop > stream of pause frames

Re: [PATCH net-next v2 0/3] netvsc: transparent SR-IOV VF support

From: Stephen Hemminger Date: Mon, 31 Jul 2017 16:45:21 -0700 > This patch set changes how SR-IOV Virtual Function devices are managed > in the Hyper-V network driver. It was part of earlier bundle, but > is now updated. I think you need to do a rebase. I just

Re: [PATCH net 2/2] gue: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP

From: Koichiro Den Date: Tue, 1 Aug 2017 01:05:39 +0900 > In the case that GRO is turned on and the original received packet is > CHECKSUM_PARTIAL, if the outer UDP header is exactly at the last > csum-unnecessary point, which for instance could occur if the packet > comes

Re: [PATCH net 1/2] vxlan: fix remcsum when GRO on and CHECKSUM_PARTIAL boundary is outer UDP

From: Koichiro Den Date: Tue, 1 Aug 2017 01:05:20 +0900 > In the case that GRO is turned on and the original received packet is > CHECKSUM_PARTIAL, if the outer UDP header is exactly at the last > csum-unnecessary point, which for instance could occur if the packet > comes

Re: [PATCH-net-next] net: add skb_frag_foreach_page and use with kmap_atomic

From: Willem de Bruijn Date: Mon, 31 Jul 2017 08:15:47 -0400 > From: Willem de Bruijn > > Skb frags may contain compound pages. Various operations map frags > temporarily using kmap_atomic, but this function works on single > pages, not

Re: [PATCH] iwlwifi: Demote messages about fw flags size to info

Hello Luca, On Mon, Jul 24, 2017 at 4:01 AM, Coelho, Luciano wrote: > On Fri, 2017-07-21 at 07:51 -0700, João Paulo Rechi Vita wrote: (...) >> Currently these messages are presented to the user during boot if there >> is no bootsplash covering the console, sometimes

Re: [PATCH net-next v3 0/4] net-next: mediatek: add support for ethernet on MT7622 SoC

From: Date: Mon, 31 Jul 2017 18:05:07 +0800 > From: Sean Wang > > Changes since v2: > - update John's mail > > Changes since v1: > - add refinement for ethernet clock management > - take out the code block for ESW, add it until ESW driver is

Re: [PATCH net-next] net: dsa: Add support for 64-bit statistics

On 08/01/2017 03:00 PM, Florian Fainelli wrote: > DSA slave network devices maintain a pair of bytes and packets counters > for each directions, but these are not 64-bit capable. Re-use > pcpu_sw_netstats which contains exactly what we need for that purpose > and update the code path to report

admin

ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [PATCH] Cipso: cipso_v4_optptr enter infinite loop

From: Yujuan Qi Date: Mon, 31 Jul 2017 11:23:01 +0800 > From: "yujuan.qi" > > in for(),if((optlen > 0) && (optptr[1] == 0)), enter infinite loop. > > Test: receive a packet which the ip length > 20 and the first byte of ip > option is 0,

Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers

From: Kees Cook Date: Sun, 30 Jul 2017 18:31:17 -0700 > In preparation for the randstruct gcc plugin performing randomization of > structures that are entirely function pointers, use designated initializers > so the compiler doesn't get angry. > > Reported-by: kbuild test

Re: [PATCH net-next 0/3] net: Infrastructure changes for [kz]proxy

From: Tom Herbert Date: Fri, 28 Jul 2017 16:22:40 -0700 > This patch set contains some general infrastructure enhancements that > will be used by kernel proxy and zero proxy. > > The changes are: > - proto_ops: Add locked versions of sendmsg and sendpage > -

Re: [PATCH v4 0/4] net: ethernet: ti: cpts: fix tx timestamping timeout

From: Grygorii Strashko Date: Fri, 28 Jul 2017 17:30:01 -0500 > With the low Ethernet connection speed cpdma notification about packet > processing can be received before CPTS TX timestamp event, which is set > when packet actually left CPSW while cpdma notification is

Re: [PATCH v6 net-next] net: systemport: Support 64bit statistics

On 07/31/2017 06:18 PM, Jianming.qiao wrote: > When using Broadcom Systemport device in 32bit Platform, ifconfig can > only report up to 4G tx,rx status, which will be wrapped to 0 when the > number of incoming or outgoing packets exceeds 4G, only taking > around 2 hours in busy network

net-next virtio_net merge...

I just merged net into net-next and one of the conflicts had to do with the truesize bug fix in 'net' conflicting with the changes in 'net-next' which encode the headroom into the contexts for mergeable buffers. I did my best to resolve this, but if you two would take a closer look and test out

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On 08/01/2017 03:02 PM, Timur Tabi wrote: > On 08/01/2017 04:55 PM, Florian Fainelli wrote: >> This is not specific to your EMAC, a lot of adapters have this problem >> actually. >> >> I wonder if it would make sense to reach for a broader solution where we >> could have a networking stack

Re: Please merge net into net-next

From: Edward Cree Date: Mon, 31 Jul 2017 18:25:16 +0100 > Could you please merge net into net-next, so I can rebase my BPF patches? > Otherwise there's likely to be merge conflicts with the BPF_SUB fix. This has now been done.

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

On 08/01/2017 03:00 PM, Timur Tabi wrote: > On 08/01/2017 04:51 PM, Florian Fainelli wrote: > >> A few adapters (bcmgenet, bcmsysport) support configuring the pause >> quanta so it would not be inconceivable to try to update >> ethtool_pauseparam to include additional fields such as: > >

[PATCH net-next] liquidio: set sriov_totalvfs correctly

From: Derek Chickles The file /sys/devices/pci000.../sriov_totalvfs is showing a wrong value. Fix it by calling pci_sriov_set_totalvfs() to set the total number of VFs available after calculations for the number of PF and VF queues are made. Signed-off-by: Derek

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On 08/01/2017 04:55 PM, Florian Fainelli wrote: This is not specific to your EMAC, a lot of adapters have this problem actually. I wonder if it would make sense to reach for a broader solution where we could have a networking stack panic/oops notifier which will actively clean up the active

[PATCH net-next] net: dsa: Add support for 64-bit statistics

DSA slave network devices maintain a pair of bytes and packets counters for each directions, but these are not 64-bit capable. Re-use pcpu_sw_netstats which contains exactly what we need for that purpose and update the code path to report 64-bit capable statistics. Signed-off-by: Florian Fainelli

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

On 08/01/2017 04:51 PM, Florian Fainelli wrote: A few adapters (bcmgenet, bcmsysport) support configuring the pause quanta so it would not be inconceivable to try to update ethtool_pauseparam to include additional fields such as: Wouldn't this require a change to the user space tool? -

Re: [PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

On 08/01/2017 02:37 PM, Timur Tabi wrote: > The EMAC has a curious qwirk when RX flow control is enabled and the > kernel hangs. With the kernel hung, the EMAC's RX queue soon fills. > If RX flow control is enabled, the EMAC will then send a non-stop > stream of pause frames until the system is

Re: sysctl, argument parsing, possible bug

On Tue, Aug 1, 2017 at 2:34 PM, Massimo Sala wrote: > Do you confirm it is a sysctl parsing bug ? > > Bosybox handles these cases, so I think also standalone sysctl have to. > > Or at least someone must update sysctl docs / MAN about this. > Maybe, sysctl seems (I

Re: [PATCH 2/2] net: qcom/emac: add software control for pause frame mode

On 08/01/2017 02:37 PM, Timur Tabi wrote: > The EMAC has the option of sending only a single pause frame when > flow control is enabled and the RX queue is full. Although sending > only one pause frame has little value, this would allow admins to > enable automatic flow control without having to

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

On Tue, Aug 01, 2017 at 02:17:58PM -0700, Cong Wang wrote: > On Mon, Jul 31, 2017 at 4:00 PM, Shaohua Li wrote: > > On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: > >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: > >> > static inline __be32

[PATCH 1/2] [for 4.13] net: qcom/emac: disable flow control autonegotiation by default

The EMAC has a curious qwirk when RX flow control is enabled and the kernel hangs. With the kernel hung, the EMAC's RX queue soon fills. If RX flow control is enabled, the EMAC will then send a non-stop stream of pause frames until the system is reset. The EMAC does not have a built-in watchdog.

[PATCH 0/2] net: qcom/emac: fixes for pause frame floods

The first patch is for 4.13. It's changes the default behavior of the EMAC driver so that it doesn't send pause frames unless the user enables them. The second patch is for 4.14, but it can be applied to 4.13 if you want. It adds the ability for the user to enable a special "single pause

[PATCH 2/2] net: qcom/emac: add software control for pause frame mode

The EMAC has the option of sending only a single pause frame when flow control is enabled and the RX queue is full. Although sending only one pause frame has little value, this would allow admins to enable automatic flow control without having to worry about the EMAC flooding nearby switches with

Re: sysctl, argument parsing, possible bug

Do you confirm it is a sysctl parsing bug ? Bosybox handles these cases, so I think also standalone sysctl have to. Or at least someone must update sysctl docs / MAN about this. Best regards, Sala On 01/08/2017, Cong Wang wrote: > On Tue, Aug 1, 2017 at 1:47 PM,

Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE

On 08/01/2017 01:32 PM, Vivien Didelot wrote: > The port's PHY and MAC are both implied in EEE. The current code does > not call the PHY operations if the related device is NULL. Change that > by returning -ENODEV if there's no PHY device attached to the interface. > > Signed-off-by: Vivien

Re: [PATCH net-next v2 06/11] net: dsa: bcm_sf2: remove unneeded supported flags

On 08/01/2017 01:32 PM, Vivien Didelot wrote: > The SF2 driver is masking the supported bitfield of its private copy of > the ports' ethtool_eee structures. It is used nowhere, thus remove it. > > Signed-off-by: Vivien Didelot Reviewed-by: Florian Fainelli

Re: sysctl, argument parsing, possible bug

On Tue, Aug 1, 2017 at 1:47 PM, Massimo Sala wrote: > cat /proc/sys/net/ipv4/conf/eth0.100/forwarding > 0 > > sysctl net.ipv4.conf.eth0.100.forwarding > error: "net.ipv4.conf.eth0.100.forwarding" is an unknown key > Use echo instead, sysctl doesn't understand eth0.100

Re: [PATCH V5 2/2] brcmfmac: don't warn user about NVRAM if fallback to the platform one succeeds

On 31-07-17 17:09, Rafał Miłecki wrote: > From: Rafał Miłecki > > Failing to load NVRAM *file* isn't critical if we manage to get platform > NVRAM in the fallback path. It means warnings like: > [ 10.801506] brcmfmac :01:00.0: Direct firmware load for >

Re: [PATCH V4 net 2/2] net: fix tcp reset packet flowlabel for ipv6

On Mon, Jul 31, 2017 at 4:00 PM, Shaohua Li wrote: > On Mon, Jul 31, 2017 at 03:35:02PM -0700, Cong Wang wrote: >> On Mon, Jul 31, 2017 at 3:19 PM, Shaohua Li wrote: >> > static inline __be32 ip6_make_flowlabel(struct net *net, struct sk_buff >> > *skb, >> >

Re: [PATCH net-next v2 11/11] net: dsa: rename switch EEE ops

On Tue, Aug 01, 2017 at 04:32:41PM -0400, Vivien Didelot wrote: > To avoid confusion with the PHY EEE settings, rename the .set_eee and > .get_eee ops to respectively .set_mac_eee and .get_mac_eee. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn

Re: [PATCH net-next v2 10/11] net: dsa: mv88e6xxx: remove EEE support

On Tue, Aug 01, 2017 at 04:32:40PM -0400, Vivien Didelot wrote: > The PHY's EEE settings are already accessed by the DSA layer through the > Marvell PHY driver and there is nothing to be done for switch's MACs. > > Remove all EEE support from the mv88e6xxx driver and simply return 0 > from the

Re: [PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set_eee

On Tue, Aug 01, 2017 at 04:32:39PM -0400, Vivien Didelot wrote: > The DSA switch operations for EEE are only meant to configure a port's > MAC EEE settings. The port's PHY EEE settings are accessed by the DSA > layer and must be made available via a proper PHY driver. > > In order to reduce this

Re: [PATCH net-next v2 08/11] net: dsa: call phy_init_eee in DSA layer

On Tue, Aug 01, 2017 at 04:32:38PM -0400, Vivien Didelot wrote: > All DSA drivers are calling phy_init_eee if eee_enabled is true. > > Move up this statement in the DSA layer to simplify the DSA drivers. > qca8k does not require to cache the ethtool_eee structures from now on. > > Signed-off-by:

Re: [PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee

On Tue, Aug 01, 2017 at 04:32:37PM -0400, Vivien Didelot wrote: > It is safer to init the EEE before the DSA layer call > phy_ethtool_set_eee, as sf2 and qca8k are doing. I can understand making all the drivers do the same thing, but the next patch deletes this change, making is pointless. My

Re: [PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE

On Tue, Aug 01, 2017 at 04:32:31PM -0400, Vivien Didelot wrote: > The port's PHY and MAC are both implied in EEE. The current code does > not call the PHY operations if the related device is NULL. Change that > by returning -ENODEV if there's no PHY device attached to the interface. > >

Re: [PATCH net 1/7] b44: Initialize 64-bit stats seqcount

On Tue, Aug 1, 2017 at 12:11 PM, Florian Fainelli wrote: > On 32-bit hosts and with CONFIG_DEBUG_LOCK_ALLOC we should be seeing a > lockdep splat indicating this seqcount is not correctly initialized, fix > that. > > Fixes: eeda8585522b ("b44: add 64 bit stats") >

Re: [PATCH net] ppp: Fix a scheduling-while-atomic bug in del_chan

On Mon, Jul 31, 2017 at 3:07 AM, wrote: > From: Gao Feng > > The PPTP set the pptp_sock_destruct as the sock's sk_destruct, it would > trigger this bug when __sk_free is invoked in atomic context, because of > the call path

Re: [PATCH net 2/3] tcp: enable xmit timer fix by having TLP use time when RTO should fire

On Tue, 2017-08-01 at 10:35 -0400, Neal Cardwell wrote: > On Tue, Aug 1, 2017 at 3:22 AM, Eric Dumazet wrote: > > On Mon, 2017-07-31 at 22:58 -0400, Neal Cardwell wrote: > >> @@ -2418,13 +2418,9 @@ bool tcp_schedule_loss_probe(struct sock *sk) > >> timeout =

[PATCH net-next v2 06/11] net: dsa: bcm_sf2: remove unneeded supported flags

The SF2 driver is masking the supported bitfield of its private copy of the ports' ethtool_eee structures. It is used nowhere, thus remove it. Signed-off-by: Vivien Didelot --- drivers/net/dsa/bcm_sf2.c | 4 1 file changed, 4 deletions(-) diff --git

[PATCH net-next v2 02/11] net: dsa: qca8k: fix EEE init

The qca8k obviously copied code from the sf2 driver as how to set EEE: if (e->eee_enabled) { p->eee_enabled = qca8k_eee_init(ds, port, phydev); if (!p->eee_enabled) ret = -EOPNOTSUPP; } But it did not use the same logic for the EEE init routine, which is

[PATCH net-next v2 04/11] net: dsa: qca8k: do not cache unneeded EEE fields

The qca8k driver is currently caching a bitfield of the supported member of a ethtool_eee private structure, which is unused. Only the eee_enabled field of the private ethtool_eee copy is updated, thus using p->advertised and p->lp_advertised is also erroneous. Remove the usage of these private

[PATCH net-next v2 11/11] net: dsa: rename switch EEE ops

To avoid confusion with the PHY EEE settings, rename the .set_eee and .get_eee ops to respectively .set_mac_eee and .get_mac_eee. Signed-off-by: Vivien Didelot --- drivers/net/dsa/bcm_sf2.c| 12 ++-- drivers/net/dsa/mv88e6xxx/chip.c | 12

[PATCH net-next v2 03/11] net: dsa: qca8k: enable EEE once

If EEE is queried enabled, qca8k_set_eee calls qca8k_eee_enable_set twice (because it is already called in qca8k_eee_init). Fix that. Signed-off-by: Vivien Didelot --- drivers/net/dsa/qca8k.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH net-next v2 10/11] net: dsa: mv88e6xxx: remove EEE support

The PHY's EEE settings are already accessed by the DSA layer through the Marvell PHY driver and there is nothing to be done for switch's MACs. Remove all EEE support from the mv88e6xxx driver and simply return 0 from the EEE ops. Signed-off-by: Vivien Didelot

[PATCH net-next v2 09/11] net: dsa: remove PHY device argument from .set_eee

The DSA switch operations for EEE are only meant to configure a port's MAC EEE settings. The port's PHY EEE settings are accessed by the DSA layer and must be made available via a proper PHY driver. In order to reduce this confusion, remove the phy_device argument from the .set_eee operation.

[PATCH net-next v2 08/11] net: dsa: call phy_init_eee in DSA layer

All DSA drivers are calling phy_init_eee if eee_enabled is true. Move up this statement in the DSA layer to simplify the DSA drivers. qca8k does not require to cache the ethtool_eee structures from now on. Signed-off-by: Vivien Didelot ---

[PATCH net-next v2 05/11] net: dsa: qca8k: empty qca8k_get_eee

phy_ethtool_get_eee is already called by the DSA layer, thus remove the duplicated call in the qca8k driver. Signed-off-by: Vivien Didelot --- drivers/net/dsa/qca8k.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git

[PATCH net-next v2 00/11] net: dsa: rework EEE support

EEE implies configuring the port's PHY and MAC of both ends of the wire. The current EEE support in DSA mixes PHY and MAC configuration, which is bad because PHYs must be configured through a proper PHY driver. The DSA switch operations for EEE are only meant for configuring the port's MAC, which

[PATCH net-next v2 07/11] net: dsa: mv88e6xxx: call phy_init_eee

It is safer to init the EEE before the DSA layer call phy_ethtool_set_eee, as sf2 and qca8k are doing. Signed-off-by: Vivien Didelot --- drivers/net/dsa/mv88e6xxx/chip.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH net-next v2 01/11] net: dsa: PHY device is mandatory for EEE

The port's PHY and MAC are both implied in EEE. The current code does not call the PHY operations if the related device is NULL. Change that by returning -ENODEV if there's no PHY device attached to the interface. Signed-off-by: Vivien Didelot ---

[PATCH net] tcp: avoid setting cwnd to invalid ssthresh after cwnd reduction states

If the sender switches the congestion control during ECN-triggered cwnd-reduction state (CA_CWR), upon exiting recovery cwnd is set to the ssthresh value calculated by the previous congestion control. If the previous congestion control is BBR that always keep ssthresh to TCP_INIFINITE_SSTHRESH,

[Patch net-next] flow_dissector: remove unused functions

They are introduced by commit f70ea018da06 ("net: Add functions to get skb->hash based on flow structures") but never gets used in tree. Signed-off-by: Cong Wang --- include/linux/skbuff.h| 16 net/core/flow_dissector.c | 45

Re: [PATCH net-next 10/11] net: dsa: mv88e6xxx: remove EEE support

Vivien Didelot writes: > Second option is: we keep it KISS and let the driver define its noop, > but as I explain, it is confusing, especially for the get operation. In fact we should be good because the DSA layer will call ds->ops->{g,s}et_mac_eee before

  1   2   3   >