Re: SKB Reference Question

2017-11-01 Thread David Miller
From: Joe Smith Date: Wed, 1 Nov 2017 10:27:49 -0700 > How strictly are references on the SKB enforced. For example, > tcp_transmit_skb() clones the SKB and adds a TCP header. Can I assume > that in case of re-transmission the header added will be there and can > be

[PATCH 2/2] net: bridge: Convert timers to use timer_setup()

2017-11-01 Thread Allen Pais
switch to using the new timer_setup() and from_timer() api's. Signed-off-by: Allen Pais --- net/bridge/br_stp_timer.c | 48 +++ 1 file changed, 19 insertions(+), 29 deletions(-) diff --git a/net/bridge/br_stp_timer.c

[PATCH 1/2] net: bridge: Convert timers to use timer_setup()

2017-11-01 Thread Allen Pais
switch to using the new timer_setup() and from_timer() api's. Signed-off-by: Allen Pais --- net/bridge/br_multicast.c | 75 +++ 1 file changed, 37 insertions(+), 38 deletions(-) diff --git a/net/bridge/br_multicast.c

Re: [PATCH net-next v2 0/3] enic: Additional ethtool support

2017-11-01 Thread David Miller
From: Parvi Kaustubhi Date: Wed, 1 Nov 2017 08:44:45 -0700 > This patch set allows the user to show or modify rx/tx ring sizes using > ethtool. > > v2: > - remove unused variable to fix build warning. > - update list of maintainers for cisco vic ethernet nic driver. Series

Re: [net-next PATCH 0/4] Updates for samples/pktgen

2017-11-01 Thread David Miller
From: Jesper Dangaard Brouer Date: Wed, 01 Nov 2017 11:41:04 +0100 > This patchset updates samples/pktgen and synchronize with changes > maintained in https://github.com/netoptimizer/network-testing/ > > Features wise Robert Hoo added support for >

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Jay Vosburgh
Jarod Wilson wrote: >On 2017-11-01 8:35 PM, Jay Vosburgh wrote: >> Jay Vosburgh wrote: >> >>> Alex Sidorenko wrote: >>> The problem has been found while trying to deploy RHEL7 on HPE Synergy platform, it is

Re: [PATCH net v4 1/2] imx7s/imx7d has the ptp interrupt newly added as well.

2017-11-01 Thread Shawn Guo
On Wed, Nov 1, 2017 at 4:16 AM, Troy Kisky wrote: > For imx7, "int0" is the interrupt for queue 0 and ENET_MII > "int1" is for queue 1 > "int2" is for queue 2 > > For imx6sx, "int0" handles all 3 queues and ENET_MII > > And of course, the "pps" interrupt is for the

RE: [PATCH net v4 2/2] net: fec: Let fec_ptp have its own interrupt routine

2017-11-01 Thread Andy Duan
From: Troy Kisky Sent: Thursday, November 02, 2017 1:36 AM >To: Andy Duan ; shawn@linaro.org; >netdev@vger.kernel.org; da...@davemloft.net >Cc: Fabio Estevam ; lzn...@gmail.com; >and...@lunn.ch >Subject: Re: [PATCH

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-01 Thread Jason Wang
On 2017年11月02日 11:45, Michael S. Tsirkin wrote: On Thu, Nov 02, 2017 at 11:43:48AM +0800, Jason Wang wrote: On 2017年11月02日 09:11, Willem de Bruijn wrote: On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: tun now use flow caches based automatic queue steering method.

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

2017-11-01 Thread Jason Wang
On 2017年11月01日 21:59, Michael S. Tsirkin wrote: On Wed, Nov 01, 2017 at 09:02:03PM +0800, Jason Wang wrote: On 2017年11月01日 00:45, Michael S. Tsirkin wrote: +static void __tun_set_steering_ebpf(struct tun_struct *tun, + struct bpf_prog *new) +{ +

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-01 Thread Michael S. Tsirkin
On Thu, Nov 02, 2017 at 11:43:48AM +0800, Jason Wang wrote: > > > On 2017年11月02日 09:11, Willem de Bruijn wrote: > > On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > > > tun now use flow caches based automatic queue steering method. This > > > may not suffice all user

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-01 Thread Jason Wang
On 2017年11月02日 09:11, Willem de Bruijn wrote: On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: tun now use flow caches based automatic queue steering method. This may not suffice all user cases. To extend it to be able to use more flow steering policy, this patch

Re: [PATCH net-next 3/9] net: hns3: Refactor the initialization of command queue

2017-11-01 Thread Yunsheng Lin
Hi, Lipeng On 2017/11/1 22:47, Lipeng wrote: > From: qumingguang > > There is no necessary to reallocate the descriptor and remap the descriptor > memory in reset process, But there is still some other action exit in both exit -> exist > reset process and

Re: [PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-01 Thread Florian Fainelli
Le 11/01/17 à 17:36, David Daney a écrit : > From: Carlos Munoz > > From the hardware user manual: "The FPA is a unit that maintains > pools of pointers to free L2/DRAM memory. To provide QoS, the pools > are referenced indirectly through 1024 auras. Both core software > and

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

2017-11-01 Thread Jason Wang
On 2017年11月02日 03:12, Alexei Starovoitov wrote: On Wed, Nov 01, 2017 at 03:59:48PM +0200, Michael S. Tsirkin wrote: On Wed, Nov 01, 2017 at 09:02:03PM +0800, Jason Wang wrote: On 2017年11月01日 00:45, Michael S. Tsirkin wrote: +static void __tun_set_steering_ebpf(struct tun_struct *tun, +

Re: [PATCH net-next] vhost_net: conditionally enable tx polling

2017-11-01 Thread Jason Wang
On 2017年11月01日 23:03, Michael S. Tsirkin wrote: On Wed, Nov 01, 2017 at 08:51:36PM +0800, Jason Wang wrote: On 2017年11月01日 00:36, Michael S. Tsirkin wrote: On Tue, Oct 31, 2017 at 06:27:20PM +0800, Jason Wang wrote: We always poll tx for socket, this is sub optimal since: - we only want

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Yang, Yi
On Thu, Nov 02, 2017 at 08:52:40AM +0800, Pravin Shelar wrote: > On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > > > > OVS master and 2.8 branch has merged NSH userspace > > patch series, this patch is to enable NSH support > > in kernel data path in order that OVS can

Re: Confirm Reciept Of This Mail

2017-11-01 Thread Meiwa Corporation co.Ltd
Season Greetings To You; Are you interested in taking up a representative position (Account Receivable Agent) for Meiwa Corporation co.Ltd, who is currently looking on contracting both Companies and Individuals who are based in Canada and USA irrespectively Please Note: * This is a part time

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Jarod Wilson
On 2017-11-01 8:35 PM, Jay Vosburgh wrote: Jay Vosburgh wrote: Alex Sidorenko wrote: The problem has been found while trying to deploy RHEL7 on HPE Synergy platform, it is seen both in customer's environment and in HPE test lab.

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 18:00 -0700, Eric Dumazet wrote: > On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > > > Yes, that looks good to me. Thanks! > > > > But we still need to clean up the skb in tcp_v4_send_reset and > > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have

Re: [RFC PATCH 01/14] packet: introduce AF_PACKET V4 userspace API

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 9:41 PM, Björn Töpel wrote: > From: Björn Töpel > > This patch adds the necessary AF_PACKET V4 structures for usage from > userspace. AF_PACKET V4 is a new interface optimized for high > performance packet processing. > >

( Compensation Reinbursement )

2017-11-01 Thread United Nations
View the enclosed file for your Compensation Reinbursement Code Payment.pdf Description: Adobe PDF document

Re: [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-01 Thread David Daney
On 11/01/2017 06:09 PM, Florian Fainelli wrote: On 11/01/2017 05:36 PM, David Daney wrote: From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill

Re: [PATCH net-next V2 2/3] tun: introduce ioctls to set and get steering policies

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > This patch introduces new ioctl for change packet steering policy for > tun. Only automatic flow steering is supported, more policies will > come. > > Signed-off-by: Jason Wang > --- >

[PATCH net-next] liquidio: bump up driver version to 1.7.0 to match newer NIC firmware

2017-11-01 Thread Felix Manlunas
Signed-off-by: Felix Manlunas Acked-by: Derek Chickles --- drivers/net/ethernet/cavium/liquidio/liquidio_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/liquidio_common.h

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > tun now use flow caches based automatic queue steering method. This > may not suffice all user cases. To extend it to be able to use more > flow steering policy, this patch abstracts flow steering logic into >

Re: [PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-01 Thread Florian Fainelli
On 11/01/2017 05:36 PM, David Daney wrote: > From: Carlos Munoz > > Add bindings for Common Ethernet Interface (BGX) block. > > Signed-off-by: Carlos Munoz > Signed-off-by: Steven J. Hill > Signed-off-by: David Daney

Re: [PATCH 1/2] bpf: add a bpf_override_function helper

2017-11-01 Thread Daniel Borkmann
On 11/01/2017 06:00 PM, Josef Bacik wrote: From: Josef Bacik Error injection is sloppy and very ad-hoc. BPF could fill this niche perfectly with it's kprobe functionality. We could make sure errors are only triggered in specific call chains that we care about with very

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 17:10 -0700, Christoph Paasch wrote: > Yes, that looks good to me. Thanks! > > But we still need to clean up the skb in tcp_v4_send_reset and > tcp_v4_send_ack, as the fields (e.g., tcp_skb_cb->seq) have been set when > coming from tcp_v4_rcv. You might be confused :

Re: [PATCH net-next v15] openvswitch: enable NSH support

2017-11-01 Thread Pravin Shelar
On Tue, Oct 31, 2017 at 9:03 PM, Yi Yang wrote: > v14->v15 > - Check size in nsh_hdr_from_nlattr > - Fixed four small issues pointed out By Jiri and Eric > > v13->v14 > - Rename skb_push_nsh to nsh_push per Dave's comment > - Rename skb_pop_nsh to nsh_pop per Dave's

[PATCH 1/7] dt-bindings: Add Cavium Octeon Common Ethernet Interface.

2017-11-01 Thread David Daney
From: Carlos Munoz Add bindings for Common Ethernet Interface (BGX) block. Signed-off-by: Carlos Munoz Signed-off-by: Steven J. Hill Signed-off-by: David Daney ---

[PATCH 2/7] MIPS: Octeon: Enable LMTDMA/LMTST operations.

2017-11-01 Thread David Daney
From: Carlos Munoz LMTDMA/LMTST operations move data between cores and I/O devices: * LMTST operations can send an address and a variable length (up to 128 bytes) of data to an I/O device. * LMTDMA operations can send an address and a variable length (up to 128) of data

[PATCH 4/7] MIPS: Octeon: Add Free Pointer Unit (FPA) support.

2017-11-01 Thread David Daney
From: Carlos Munoz >From the hardware user manual: "The FPA is a unit that maintains pools of pointers to free L2/DRAM memory. To provide QoS, the pools are referenced indirectly through 1024 auras. Both core software and hardware units allocate and free pointers."

[PATCH 3/7] MIPS: Octeon: Add a global resource manager.

2017-11-01 Thread David Daney
From: Carlos Munoz Add a global resource manager to manage tagged pointers within bootmem allocated memory. This is used by various functional blocks in the Octeon core like the FPA, Ethernet nexus, etc. Signed-off-by: Carlos Munoz Signed-off-by: Steven J.

[PATCH 5/7] MIPS: Octeon: Automatically provision CVMSEG space.

2017-11-01 Thread David Daney
Remove CONFIG_CAVIUM_OCTEON_CVMSEG_SIZE and automatically calculate the amount of CVMSEG space needed. 1st 128-bytes: Use by IOBDMA 2nd 128-bytes: Reserved by kernel for scratch/TLS emulation. 3rd 128-bytes: OCTEON-III LMTLINE New config variable CONFIG_CAVIUM_OCTEON_EXTRA_CVMSEG provisions

[PATCH 7/7] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-*

2017-11-01 Thread David Daney
Signed-off-by: David Daney --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a24f56e0451..142af33adc35 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3212,6 +3212,12 @@ W: http://www.cavium.com S:

[PATCH 0/7] Cavium OCTEON-III network driver.

2017-11-01 Thread David Daney
We are adding the Cavium OCTEON-III network driver. But since interacting with the input and output queues is done via special CPU local memory, we also need to add support to the MIPS/Octeon architecture code. Aren't SoCs nice in this way? The first five patches add the SoC support needed by

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Jay Vosburgh
Jay Vosburgh wrote: >Alex Sidorenko wrote: > >>The problem has been found while trying to deploy RHEL7 on HPE Synergy >>platform, it is seen both in customer's environment and in HPE test lab. >> >>There are several bonds configured in

Re: [PATCH v2] net: phy: leds: Add support for "link" trigger

2017-11-01 Thread Andrew Lunn
On Thu, Nov 02, 2017 at 12:49:31AM +0100, Maciej S. Szmigiero wrote: > Hi Andrew, > > On 01.11.2017 13:33, Maciej S. Szmigiero wrote: > > On 01.11.2017 13:31, Andrew Lunn wrote: > >>> Yes, I did it the same way as the existing code did for > >>> phy->phy_led_triggers > >>> for reasons of both

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Christoph Paasch
On 01/11/17 - 14:53:38, Eric Dumazet wrote: > On Wed, 2017-11-01 at 14:32 -0700, Eric Dumazet wrote: > > On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > > > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > > > line misses") IPCB/IP6CB is no

[PATCH v3 2/2] net: phy: leds: Add support for "link" trigger

2017-11-01 Thread Maciej S. Szmigiero
Currently, we create a LED trigger for any link speed known to a PHY. These triggers only fire when their exact link speed had been negotiated (they aren't cumulative, that is, they don't fire for "their or any higher" link speed). What we are missing, however, is a trigger which will fire on any

Re: [PATCH v2] net: phy: leds: Add support for "link" trigger

2017-11-01 Thread Maciej S. Szmigiero
Hi Andrew, On 01.11.2017 13:33, Maciej S. Szmigiero wrote: > On 01.11.2017 13:31, Andrew Lunn wrote: >>> Yes, I did it the same way as the existing code did for >>> phy->phy_led_triggers >>> for reasons of both consistency and also to be on the safe side because >>> maybe there is some

[PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into a separate function

2017-11-01 Thread Maciej S. Szmigiero
Currently, phy_led_trigger_change_speed() is handling a "no link" condition like it was some kind of an error (using "goto" to a code at the function end). However, having no link at PHY is an ordinary operational state, so let's handle it in an appropriately named separate function so it is more

[PATCH net-next] liquidio: synchronize VF representor names with NIC firmware

2017-11-01 Thread Felix Manlunas
From: Vijaya Mohan Guvva LiquidIO firmware supports a vswitch that needs to know the names of the VF representors in the host to maintain compatibility for direct programming using external Openflow agents. So, for each VF representor, send its name to the firmware when

Re: TCP connection closed without FIN or RST

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 22:22 +, Vitaly Davidovich wrote: > Eric, > > Yes I agree. However the thing I’m still puzzled about is the client > application is not reading/draining the recvq - ok, the client tcp > stack should start advertising a 0 window size. Does a 0 window size > count

Re: mlx5 broken affinity

2017-11-01 Thread Jes Sorensen
On 11/01/2017 06:41 PM, Saeed Mahameed wrote: > On Wed, Nov 1, 2017 at 11:20 AM, Jes Sorensen wrote: >> On 11/01/2017 01:21 PM, Sagi Grimberg wrote: >> I am all in favor of making the automatic setup better, but assuming an >> automatic setup is always right seems problematic.

[PATCH net-next 3/3] bpf: add test cases to bpf selftests to cover all meta tests

2017-11-01 Thread Daniel Borkmann
Lets also add test cases to cover all possible data_meta access tests for good/bad access cases so we keep tracking them. Signed-off-by: Daniel Borkmann Acked-by: Alexei Starovoitov Acked-by: John Fastabend ---

[PATCH net-next 2/3] bpf: also improve pattern matches for meta access

2017-11-01 Thread Daniel Borkmann
Follow-up to 0fd4759c5515 ("bpf: fix pattern matches for direct packet access") to cover also the remaining data_meta/data matches in the verifier. The matches are also refactored a bit to simplify handling of all the cases. Signed-off-by: Daniel Borkmann Acked-by: Alexei

[PATCH net-next 0/3] BPF range marking improvements for meta data

2017-11-01 Thread Daniel Borkmann
The set contains improvements for direct packet access range markings related to data_meta pointer and test cases for all such access patterns that the verifier matches on. Thanks! Daniel Borkmann (3): bpf: minor cleanups after merge bpf: also improve pattern matches for meta access bpf:

[PATCH net-next 1/3] bpf: minor cleanups after merge

2017-11-01 Thread Daniel Borkmann
Two minor cleanups after Dave's recent merge in f8ddadc4db6c ("Merge git://git.kernel.org...") of net into net-next in order to get the code in line with what was done originally in the net tree: i) use max() instead of max_t() since both ranges are u16, ii) don't split the direct access test

Re: mlx5 broken affinity

2017-11-01 Thread Saeed Mahameed
On Wed, Nov 1, 2017 at 11:20 AM, Jes Sorensen wrote: > On 11/01/2017 01:21 PM, Sagi Grimberg wrote: >>> Hi, >> >> Hi Jes, >> >>> The below patch seems to have broken PCI IRQ affinity assignments for >>> mlx5. >> >> I wouldn't call it breaking IRQ affinity assignments. It just

RE: removing bridge in vlan_filtering mode requests delete of attached ports main MAC address

2017-11-01 Thread Keller, Jacob E
> -Original Message- > From: Toshiaki Makita [mailto:makita.toshi...@lab.ntt.co.jp] > Sent: Tuesday, October 31, 2017 5:58 PM > To: Keller, Jacob E ; vyase...@redhat.com; > netdev@vger.kernel.org > Cc: Malek, Patryk > Subject: Re: removing

Re: KASAN: stack-out-of-bounds Read in xfrm_state_find (2)

2017-11-01 Thread Florian Westphal
syzbot wrote: [ cc Thomas Egerer ] > syzkaller hit the following crash on > 36ef71cae353f88fd6e095e2aaa3e5953af1685d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1

Re: TCP connection closed without FIN or RST

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 21:45 +, Vitaly Davidovich wrote: > Hi Eric, > > > First, thanks for replying. A couple of comments inline. > > On Wed, Nov 1, 2017 at 4:51 PM Eric Dumazet > wrote: > > On Wed, 2017-11-01 at 13:34 -0700, Eric Dumazet wrote: >

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 14:32 -0700, Eric Dumazet wrote: > On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > > line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. > > This

[PATCH net-next v5 3/3] act_vlan: VLAN action rewrite to use RCU lock/unlock and update

2017-11-01 Thread Manish Kurup
Using a spinlock in the VLAN action causes performance issues when the VLAN action is used on multiple cores. Rewrote the VLAN action to use RCU read locking for reads and updates instead. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko Signed-off-by:

[PATCH net-next v5 2/3] nfp flower action: Modified to use VLAN helper functions

2017-11-01 Thread Manish Kurup
Modified netronome nfp flower action to use VLAN helper functions instead of accessing the structure directly. Signed-off-by: Manish Kurup --- drivers/net/ethernet/netronome/nfp/flower/action.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git

[PATCH net-next v5 1/3] act_vlan: Change stats update to use per-core stats

2017-11-01 Thread Manish Kurup
The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v4 1/3] net sched act_vlan: Change stats update to use per-core stats

2017-11-01 Thread Manish Kurup
The VLAN action maintains one set of stats across all cores, and uses a spinlock to synchronize updates to it from the same. Changed this to use a per-CPU stats context instead. This change will result in better performance. Acked-by: Jamal Hadi Salim Acked-by: Jiri Pirko

[PATCH net-next v5 0/3] act_vlan rewrite, review comments incorporated

2017-11-01 Thread Manish Kurup
Hi everyone, Modified the netronome drivers (flower action) to use the VLAN helper functions instead of dereferencing the structure directly. This is required for the VLAN action patch. Could you please review? Here're the changes: v2: Fixed all helper functions to use RCU (rtnl_dereference) -

Re: [RFC PATCH] xfrm: fix regression introduced by xdst pcpu cache

2017-11-01 Thread Paul Moore
On Tue, Oct 31, 2017 at 7:08 PM, Florian Westphal wrote: > Paul Moore wrote: >> On Mon, Oct 30, 2017 at 10:58 AM, Stephen Smalley wrote: >> > matching before (as in this patch) or after calling xfrm_bundle_ok()? >> >> I would probably

Re: [RFC PATCH 1/5] security: Add support for SCTP security hooks

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 14:41 -0200, Marcelo Ricardo Leitner wrote: > On Tue, Oct 17, 2017 at 03:02:47PM +0100, Richard Haines wrote: > > The SCTP security hooks are explained in: > > Documentation/security/LSM-sctp.txt > > > > Signed-off-by: Richard Haines > > ---

Re: [RFC PATCH 2/5] sctp: Add ip option support

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 15:06 -0200, Marcelo Ricardo Leitner wrote: > Hello, > > On Tue, Oct 17, 2017 at 02:58:06PM +0100, Richard Haines wrote: > > Add ip option support to allow LSM security modules to utilise > > CIPSO/IPv4 > > and CALIPSO/IPv6 services. > > > > Signed-off-by: Richard Haines

RE::

2017-11-01 Thread Mrs Hsu Wealther
Are you available at your desk? I need you to please check your email box for a business letter. With Regards, Ms. Hui Weather

Re: [RFC PATCH 5/5] selinux: Add SCTP support

2017-11-01 Thread Richard Haines
On Tue, 2017-10-31 at 15:16 -0200, Marcelo Ricardo Leitner wrote: > On Tue, Oct 17, 2017 at 02:59:53PM +0100, Richard Haines wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.txt > > > > Signed-off-by: Richard Haines

Re: Bond recovery from BOND_LINK_FAIL state not working

2017-11-01 Thread Jay Vosburgh
Alex Sidorenko wrote: >The problem has been found while trying to deploy RHEL7 on HPE Synergy >platform, it is seen both in customer's environment and in HPE test lab. > >There are several bonds configured in TLB mode and miimon=100, all other >options are default.

Re: [PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Eric Dumazet
On Wed, Nov 1, 2017 at 2:10 PM, Christoph Paasch wrote: > Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache > line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. > This means that on the output path, we need to make sure that it has >

Re: [PATCH iproute2] bridge: fdb: print NDA_SRC_VNI if available

2017-11-01 Thread Stephen Hemminger
On Thu, 26 Oct 2017 10:12:55 -0700 Roopa Prabhu wrote: > From: Roopa Prabhu > > Signed-off-by: Roopa Prabhu In general, this looks ok and I will apply it. But why is there no ability to set source vni? The

Re: [iproute2 1/2] tc: Add support for the CBS qdisc

2017-11-01 Thread Stephen Hemminger
On Thu, 26 Oct 2017 10:17:48 -0700 Jeff Kirsher wrote: > From: Vinicius Costa Gomes > > The Credit Based Shaper (CBS) queueing discipline allows bandwidth > reservation with sub-milisecond precision. It is defined by the > 802.1Q-2014

Re: [PATCH] ip/ipvlan: enhance ability to add mode flags to existing modes

2017-11-01 Thread Stephen Hemminger
On Mon, 30 Oct 2017 13:57:51 -0700 Mahesh Bandewar wrote: > From: Mahesh Bandewar > > IPvlan supported bridge-only functionality prior to commits > a190d04db937 ('ipvlan: introduce 'private' attribute for all > existing modes.') and fe89aa6b250c

[PATCH net] tcp: Always cleanup skb before sending

2017-11-01 Thread Christoph Paasch
Since commit 971f10eca186 ("tcp: better TCP_SKB_CB layout to reduce cache line misses") IPCB/IP6CB is no more at the beginning of the tcp_skb_cb. This means that on the output path, we need to make sure that it has been correctly initialized to 0, as is done in tcp_transmit_skb. However, when

Re: [PATCH v2 iproute2] ip: add fastopen_no_cookie option to ip route

2017-11-01 Thread Stephen Hemminger
On Tue, 31 Oct 2017 14:54:52 -0700 Christoph Paasch wrote: > This patch adds fastopen_no_cookie option to enable/disable TCP fastopen > without a cookie on a per-route basis. > > Support in Linux was added with 71c02379c762 (tcp: Configure TFO without > cookie per socket

[PATCH] [net-next,v2] ibmvnic: Feature implementation of Vital Product Data (VPD) for the ibmvnic driver

2017-11-01 Thread Desnes Augusto Nunes do Rosario
This patch implements and enables VDP support for the ibmvnic driver. Moreover, it includes the implementation of suitable structs, signal transmission/handling and functions which allows the retrival of firmware information from the ibmvnic card. Signed-off-by: Desnes A. Nunes do Rosario

Re: [PATCH iproute2 v2 1/1] ip netns: use strtol() instead of atoi()

2017-11-01 Thread Stephen Hemminger
On Tue, 31 Oct 2017 14:24:19 -0400 Roman Mashak wrote: > Use strtol-based API to parse and validate integer input; atoi() does > not detect errors and may yield undefined behaviour if result can't be > represented. > > v2: use get_unsigned() since network namespace is really

Re: [PATCH iproute2 3/3] xfrm_{state,policy}: Allow to deleteall polices/states with marks

2017-11-01 Thread Stephen Hemminger
On Wed, 1 Nov 2017 10:52:54 +0100 Thomas Egerer wrote: > Using 'ip deleteall' with policies that have marks, fails unless you > eplicitely specify the mark values. This is very uncomfortable when > bulk-deleting policies and states. With this patch all relevant states

Re: [PATCH iproute2] Add "show" subcommand to "ip fou"

2017-11-01 Thread Stephen Hemminger
On Tue, 31 Oct 2017 13:00:47 -0700 Greg Greenway wrote: > + if (tb[FOU_ATTR_AF]) { > + family = rta_getattr_u8(tb[FOU_ATTR_AF]); > + if (family == AF_INET) > + family_str = "AF_INET"; > + else if (family ==

Re: TCP connection closed without FIN or RST

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 13:34 -0700, Eric Dumazet wrote: > On Wed, 2017-11-01 at 16:25 -0400, Vitaly Davidovich wrote: > > Hi all, > > > > I'm seeing some puzzling TCP behavior that I'm hoping someone on this > > list can shed some light on. Apologies if this isn't the right forum > > for this

Re: Any hardware limitation for bpf testing?

2017-11-01 Thread Daniel Borkmann
On 11/01/2017 12:16 PM, Orson Zhai wrote: [...] We have ran some bpf test within kselftest for 4.14.0-rc5-next-20171018 at some hardware resource limited devices. Say Hikey Board (arm64 core) with 2GB memory. The test processes was killed by OOM which made the test failed. We investigate the

Re: TCP connection closed without FIN or RST

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 16:25 -0400, Vitaly Davidovich wrote: > Hi all, > > I'm seeing some puzzling TCP behavior that I'm hoping someone on this > list can shed some light on. Apologies if this isn't the right forum > for this type of question. But here goes anyway :) > > I have client and

Re: [PATCH net-next] security: bpf: replace include of linux/bpf.h with forward declarations

2017-11-01 Thread Daniel Borkmann
On 11/01/2017 07:48 PM, Jakub Kicinski wrote: Touching linux/bpf.h makes us rebuild a surprisingly large portion of the kernel. Remove the unnecessary dependency from security.h, it only needs forward declarations. Signed-off-by: Jakub Kicinski Reviewed-by:

TCP connection closed without FIN or RST

2017-11-01 Thread Vitaly Davidovich
Hi all, I'm seeing some puzzling TCP behavior that I'm hoping someone on this list can shed some light on. Apologies if this isn't the right forum for this type of question. But here goes anyway :) I have client and server x86-64 linux machines with the 4.1.35 kernel. I set up the following

Re: Oops with HTB on net-next

2017-11-01 Thread Dave Taht
On Wed, Nov 1, 2017 at 9:04 AM, Cong Wang wrote: > On Tue, Oct 31, 2017 at 11:42 PM, Dave Taht wrote: >> I am using a fairly complex htb + three tiers of fq_codel and a couple >> tc filters (it's the sqm-scripts "simple.qos" model). I rebased on >>

Re: [PATCH V3 net-next 1/2] liquidio: switchdev support for LiquidIO NIC

2017-11-01 Thread Jakub Kicinski
On Wed, 1 Nov 2017 12:29:48 -0700, Felix Manlunas wrote: > > > +lio_vf_rep_phys_port_name(struct net_device *dev, > > > + char *buf, size_t len) > > > +{ > > > + struct lio_vf_rep_desc *vf_rep = netdev_priv(dev); > > > + struct octeon_device *oct = vf_rep->oct; > > > + int ret; >

Re: [PATCH v10 2/8] dt-bindings: net: dwmac-sun8i: update documentation about integrated PHY

2017-11-01 Thread Rob Herring
On Tue, Oct 31, 2017 at 09:19:09AM +0100, Corentin Labbe wrote: > This patch add documentation about the MDIO switch used on sun8i-h3-emac > for integrated PHY. > > Signed-off-by: Corentin Labbe > Acked-by: Florian Fainelli > Reviewed-by: Andrew

Re: SKB Reference Question

2017-11-01 Thread Eric Dumazet
On Wed, 2017-11-01 at 12:22 -0700, Joe Smith wrote: > On Wed, Nov 1, 2017 at 10:33 AM, Eric Dumazet wrote: > > On Wed, 2017-11-01 at 10:27 -0700, Joe Smith wrote: > >> How strictly are references on the SKB enforced. For example, > >> tcp_transmit_skb() clones the SKB and

Re: [v2] can: Use common error handling code in vxcan_newlink()

2017-11-01 Thread SF Markus Elfring
> Acked-by: Oliver Hartkopp Thanks for another positive feedback. > Again: Posting such a patch on linux-...@vger.kernel.org is ENOUGH! I was informed in an other way for Linux software patches. > No need to cross post such a patch additionally on > >

Re: [PATCH] net: vrf: correct FRA_L3MDEV encode type

2017-11-01 Thread David Ahern
On 11/1/17 8:58 AM, Jeff Barnhill wrote: > FRA_L3MDEV is defined as U8, but is being added as a U32 attribute. On > big endian architecture, this results in the l3mdev entry not being > added to the FIB rules. > > Fixes: 1aa6c4f6b8cd8 ("net: vrf: Add l3mdev rules on first device create") >

[PATCH net] xfrm: defer daddr pointer assignment after spi parsing

2017-11-01 Thread Florian Westphal
syzbot reports: BUG: KASAN: use-after-free in __xfrm_state_lookup+0x695/0x6b0 Read of size 4 at addr 8801d434e538 by task syzkaller647520/2991 [..] __xfrm_state_lookup+0x695/0x6b0 net/xfrm/xfrm_state.c:833 xfrm_state_lookup+0x8a/0x160 net/xfrm/xfrm_state.c:1592 xfrm_input+0x8e5/0x22f0

Re: [PATCH V3 net-next 1/2] liquidio: switchdev support for LiquidIO NIC

2017-11-01 Thread Felix Manlunas
On Wed, Nov 01, 2017 at 02:02:07PM +0100, Andrew Lunn wrote: > > +static int > > +lio_pf_switchdev_attr_get(struct net_device *dev, struct switchdev_attr > > *attr) > > +{ > > + struct lio *lio = GET_LIO(dev); > > + > > + switch (attr->id) { > > + case SWITCHDEV_ATTR_ID_PORT_PARENT_ID: > >

Re: SKB Reference Question

2017-11-01 Thread Joe Smith
On Wed, Nov 1, 2017 at 10:33 AM, Eric Dumazet wrote: > On Wed, 2017-11-01 at 10:27 -0700, Joe Smith wrote: >> How strictly are references on the SKB enforced. For example, >> tcp_transmit_skb() clones the SKB and adds a TCP header. Can I assume >> that in case of

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

2017-11-01 Thread Alexei Starovoitov
On Wed, Nov 01, 2017 at 03:59:48PM +0200, Michael S. Tsirkin wrote: > On Wed, Nov 01, 2017 at 09:02:03PM +0800, Jason Wang wrote: > > > > > > On 2017年11月01日 00:45, Michael S. Tsirkin wrote: > > > > +static void __tun_set_steering_ebpf(struct tun_struct *tun, > > > > +

Re: [PATCH v2] can: Use common error handling code in vxcan_newlink()

2017-11-01 Thread Oliver Hartkopp
On 11/01/2017 03:16 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 1 Nov 2017 14:56:15 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle

Re: WARNING in skb_warn_bad_offload

2017-11-01 Thread Dmitry Vyukov
On Wed, Nov 1, 2017 at 9:48 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 720bbe532b7c8f5613b48dea627fc58ed9ace707 > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 >

Re: [PATCH net-next] security: bpf: replace include of linux/bpf.h with forward declarations

2017-11-01 Thread Alexei Starovoitov
On Wed, Nov 01, 2017 at 11:48:00AM -0700, Jakub Kicinski wrote: > Touching linux/bpf.h makes us rebuild a surprisingly large > portion of the kernel. Remove the unnecessary dependency > from security.h, it only needs forward declarations. > > Signed-off-by: Jakub Kicinski

[PATCH 2/2] netfilter: nf_reject_ipv4: Fix use-after-free in send_reset

2017-11-01 Thread Pablo Neira Ayuso
From: Tejaswi Tanikella niph is not updated after pskb_expand_head changes the skb head. It still points to the freed data, which is then used to update tot_len and checksum. This could cause use-after-free poison crash. Update niph, if ip_route_me_harder does not fail.

[PATCH 1/2] netfilter: nft_set_hash: disable fast_ops for 2-len keys

2017-11-01 Thread Pablo Neira Ayuso
From: Anatole Denis jhash_1word of a u16 is a different value from jhash of the same u16 with length 2. Since elements are always inserted in sets using jhash over the actual klen, this would lead to incorrect lookups on fixed-size sets with a key length of 2, as they would be

[PATCH 0/2] Netfilter fixes for net

2017-11-01 Thread Pablo Neira Ayuso
Hi David, The following patchset contains two one-liner fixes for your net tree, they are: 1) Disable fast hash operations for 2-bytes length keys which is leading to incorrect lookups in nf_tables, from Anatole Denis. 2) Reload pointer ipv4 header after ip_route_me_harder() given this may

[PATCH net-next] security: bpf: replace include of linux/bpf.h with forward declarations

2017-11-01 Thread Jakub Kicinski
Touching linux/bpf.h makes us rebuild a surprisingly large portion of the kernel. Remove the unnecessary dependency from security.h, it only needs forward declarations. Signed-off-by: Jakub Kicinski Reviewed-by: Quentin Monnet ---

[PATCH net-next] net: systemport: Only inspect valid switch port & queues

2017-11-01 Thread Florian Fainelli
Hesoteric board configurations where port 0 is not available would still make SYSTEMPORT inspect the switch port 0, queue 0, which, not being enabled, would cause transmit timeouts over time. Just ignore those unconfigured rings instead. Fixes: 84ff33eeb23d ("net: systemport: Establish DSA

Re: [PATCH] net: recvmsg: Unconditionally zero struct sockaddr_storage

2017-11-01 Thread Kees Cook
On Wed, Nov 1, 2017 at 5:48 AM, Eric W. Biederman wrote: > Eric Dumazet writes: > >> On Tue, 2017-10-31 at 09:14 -0700, Kees Cook wrote: >>> Some protocols do not correctly wipe the contents of the on-stack >>> struct sockaddr_storage sent down into

  1   2   3   >