Re: [PATCH 0/7] net: core: devname allocation cleanups

From: Rasmus Villemoes Date: Mon, 13 Nov 2017 00:15:03 +0100 > It's somewhat confusing to have both dev_alloc_name and > dev_get_valid_name. I can't see why the former is less strict than the > latter, so make them (or rather dev_alloc_name_ns and > dev_get_valid_name)

Re: [PATCH net-next] net-sysfs: trigger netlink notification on ifalias change via sysfs

Tue, Nov 14, 2017 at 08:21:36AM CET, ro...@cumulusnetworks.com wrote: >From: Roopa Prabhu > >This patch adds netlink notifications on iflias changes via sysfs. >makes it consistent with the netlink path which also calls >netdev_state_change. Also makes it consistent

Re: [PATCH net 0/6] tls: Miscellaneous fixes

From: Ilya Lesokhin Date: Mon, 13 Nov 2017 10:22:43 +0200 > Here's a set of miscellaneous fix patches. > > Patch 1 makes sure aead_request is initailized properly. > Patches 2-3 Fix a memory leak we've encountered. > patch 4 moves tls_make_aad to allow sharing it in the

[PATCH v3] wcn36xx: Set default BTLE coexistence config

From: Eyal Ilsar If the value for the firmware configuration parameters BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty cycle between BT and WLAN is such that if BT (including BLE) is active WLAN gets 0 bandwidth. When tuning these parameters having a

[PATCH net-next] net-sysfs: trigger netlink notification on ifalias change via sysfs

From: Roopa Prabhu This patch adds netlink notifications on iflias changes via sysfs. makes it consistent with the netlink path which also calls netdev_state_change. Also makes it consistent with other sysfs netdev_store operations. Signed-off-by: Roopa Prabhu

Re: [PATCH net-next 0/3] bpf: improve verifier ARG_CONST_SIZE_OR_ZERO semantics

From: Yonghong Song Date: Sat, 11 Nov 2017 16:00:33 -0800 > This patch set intends to change verifier ARG_CONST_SIZE_OR_ZERO > semantics so that simpler bpf programs can be written with verifier > acceptance. Patch #1 comment provided the detailed examples and > the patch itself

Re: [PATCH v2 net-next] tcp: allow drivers to tweak TSQ logic

From: Eric Dumazet Date: Sat, 11 Nov 2017 15:54:12 -0800 > From: Eric Dumazet > > I had many reports that TSQ logic breaks wifi aggregation. > > Current logic is to allow up to 1 ms of bytes to be queued into qdisc > and drivers queues. > > But

Re: [PATCH net-next 0/3] rxrpc: Fixes

From: David Howells Date: Sat, 11 Nov 2017 17:57:52 + > > Here are some patches that fix some things in AF_RXRPC: > > (1) Prevent notifications from being passed to a kernel service for a call > that it has ended. > > (2) Fix a null pointer deference that

Re: [PATCHv3 1/1] bnx2x: fix slowpath null crash

From: Zhu Yanjun Date: Sat, 11 Nov 2017 10:42:03 -0500 > When "NETDEV WATCHDOG: em4 (bnx2x): transmit queue 2 timed out" occurs, > BNX2X_SP_RTNL_TX_TIMEOUT is set. In the function bnx2x_sp_rtnl_task, > bnx2x_nic_unload and bnx2x_nic_load are executed to shutdown and open >

Re: [PATCH net-next 0/2] cxgb4: collect LE-TCAM and SGE queue contexts

From: Rahul Lakkireddy Date: Sat, 11 Nov 2017 19:48:14 +0530 > Collect hardware dumps via ethtool --get-dump facility. > > Patch 1 collects LE-TCAM dump. > > Patch 2 collects SGE queue context dumps. Series applied, thanks.

Re: [PATCH net] vxlan: fix the issue that neigh proxy blocks all icmpv6 packets

From: Xin Long Date: Sat, 11 Nov 2017 19:58:50 +0800 > Commit f1fb08f6337c ("vxlan: fix ND proxy when skb doesn't have transport > header offset") removed icmp6_code and icmp6_type check before calling > neigh_reduce when doing neigh proxy. > > It means all icmpv6 packets

Re: [PATCH v2 2/2] chcr: Add support for Inline IPSec

From: Atul Gupta Date: Thu, 9 Nov 2017 16:59:01 +0530 > register xfrmdev_ops callbacks, Send IPsec tunneled data > to HW for inline processing. > The driver use hardware crypto accelerator to encrypt and > generate ICV for the transmitted packet in Inline mode. > >

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On 11/13/2017 09:33 PM, Björn Töpel wrote: > 2017-11-14 0:50 GMT+01:00 Alexei Starovoitov : >> On 11/13/17 9:07 PM, Björn Töpel wrote: >>> >>> 2017-10-31 13:41 GMT+01:00 Björn Töpel : From: Björn Töpel >>> [...]

Re: KASAN: use-after-free Read in rds_tcp_dev_event

On (11/13/17 19:30), Girish Moodalbail wrote: > (L538-540). However, it leaves behind some of the rds_tcp connections that > shared the same underlying RDS connection (L534 and 535). These connections > with pointer to stale network namespace are left behind in the global list. It leaves behind

Re: [PATCH] wcn36xx: Set BTLE coexistence related configuration values to defaults

Ramon Fried writes: > From: Eyal Ilsar > > If the value for the firmware configuration parameters > BTC_STATIC_LEN_LE_BT and BTC_STATIC_LEN_LE_WLAN are not set the duty > cycle between BT and WLAN is such that if BT (including BLE) is active > WLAN

Re: [PATCH v5 00/13] exit_net checks for objects initialized in net_init hook

From: Vasily Averin Date: Sun, 12 Nov 2017 22:26:44 +0300 > OpenVz kernel team have a long history of fighting against namespace-related > bugs, > some of them could be prevented by using simple checks described below. > > One of typical errors is related to live cycle of

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

Tue, Nov 14, 2017 at 06:51:42AM CET, xiyou.wangc...@gmail.com wrote: >On Mon, Nov 13, 2017 at 9:17 PM, Jiri Pirko wrote: >> Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >>>On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: From:

[PATCH net-next] openvswitch: Using kfree_rcu() to simplify the code

The callback function of call_rcu() just calls a kfree(), so we can use kfree_rcu() instead of call_rcu() + callback function. Signed-off-by: Wei Yongjun --- net/openvswitch/meter.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git

[PATCH net-next] openvswitch: Make local function ovs_nsh_key_attr_size() static

Fixes the following sparse warnings: net/openvswitch/flow_netlink.c:340:8: warning: symbol 'ovs_nsh_key_attr_size' was not declared. Should it be static? Signed-off-by: Wei Yongjun --- net/openvswitch/flow_netlink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH V2 net] net: hns3: Updates MSI/MSI-X alloc/free APIs(depricated) to new APIs

On Thu, Nov 09, 2017 at 04:38:13PM +, Salil Mehta wrote: > This patch migrates the HNS3 driver code from use of depricated PCI > MSI/MSI-X interrupt vector allocation/free APIs to new common APIs. > > Signed-off-by: Salil Mehta > Suggested-by: Christoph Hellwig

[PATCH net-next] openvswitch: Fix return value check in ovs_meter_cmd_features()

In case of error, the function ovs_meter_cmd_reply_start() returns ERR_PTR() not NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure") Signed-off-by: Wei Yongjun ---

[PATCH net-next] liquidio: Missing error code in liquidio_init_nic_module()

We accidentally return success if lio_vf_rep_modinit() fails instead of propogating the error code. Fixes: e20f469660ad ("liquidio: synchronize VF representor names with NIC firmware") Signed-off-by: Dan Carpenter diff --git

[PATCH net-next] xdp: sample: Missing curly braces in read_route()

The assert statement is supposed to be part of the else branch but the curly braces were accidentally left off. Fixes: 3e29cd0e6563 ("xdp: Sample xdp program implementing ip forward") Signed-off-by: Dan Carpenter diff --git a/samples/bpf/xdp_router_ipv4_user.c

Re: r8169 regression: UDP packets dropped intermittantly

As far as I am aware there were no follow up comments to my last post on this subject on 24 March 2017. The text of that post is included below for reference. To summarise: a short test program which reliably triggered the problem was written in the hope it would assist in the repair of this

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

On Mon, Nov 13, 2017 at 7:23 PM, 张军伟(基础平台部) wrote: > >> On 14 Nov 2017, at 10:09, Cong Wang wrote: >> >> On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang >> wrote: >>> From: Tonghao Zhang

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

On Mon, Nov 13, 2017 at 9:17 PM, Jiri Pirko wrote: > Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >>On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> Currently, user may choose to move

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

2017-11-14 0:50 GMT+01:00 Alexei Starovoitov : > On 11/13/17 9:07 PM, Björn Töpel wrote: >> >> 2017-10-31 13:41 GMT+01:00 Björn Töpel : >>> >>> From: Björn Töpel >>> >> [...] >>> >>> >>> We'll do a presentation on AF_PACKET V4 in NetDev

Re: [patch net] net: forbid netdev used by mirred tc act from being moved to another netns

Mon, Nov 13, 2017 at 08:53:57PM CET, xiyou.wangc...@gmail.com wrote: >On Mon, Nov 13, 2017 at 6:05 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> Currently, user may choose to move device that is used by mirred action >> to another network namespace. That is

Re: [net-next:master 488/665] verifier.c:undefined reference to `__multi3'

On 11/11/2017 05:33 PM, Fengguang Wu wrote: CC gcc list. According to Alexei: This is a known issue with gcc 7 on mips that is "optimizing" normal 64-bit multiply into 128-bit variant. Nothing to fix on the kernel side. I filed a bug report. This is now

Re: Per-CPU Queueing for QoS

On Mon, Nov 13, 2017 at 7:45 PM, John Fastabend wrote: > On 11/13/2017 06:18 PM, Michael Ma wrote: >> 2017-11-13 16:13 GMT-08:00 Alexander Duyck : >>> On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet >>> wrote: On

Fwd: FW: [PATCH 18/31] nds32: Library functions

>>On Wed, Nov 08, 2017 at 01:55:06PM +0800, Greentime Hu wrote: > >> +#define __range_ok(addr, size) (size <= get_fs() && addr <= (get_fs() >> +-size)) >> + >> +#define access_ok(type, addr, size) \ >> + __range_ok((unsigned long)addr, (unsigned long)size) > >> +#define

Re: Per-CPU Queueing for QoS

I have been thinking we'd try to submit sch_cake to mainline on this go-around. It's been out of tree for way too long. I look forward to understanding your patches soon in the tbf case. (I'm only responding because cake uses deficit, rather than a token bucket, scheduler, and is not reliant on

Re: Per-CPU Queueing for QoS

On 11/13/2017 06:18 PM, Michael Ma wrote: > 2017-11-13 16:13 GMT-08:00 Alexander Duyck : >> On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote: >>> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: On Mon, Nov 13, 2017 at 10:17 AM,

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

> On 14 Nov 2017, at 10:09, Cong Wang wrote: > > On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang > wrote: >> From: Tonghao Zhang >> >> This patch add a member in struct netns_core. and this is >> a counter for

[PATCH v2] net: use ARRAY_SIZE

Using the ARRAY_SIZE macro improves the readability of the code. Also, it is not always useful to use a variable to store this constant calculated at compile time. Found with Coccinelle with the following semantic patch: @r depends on (org || report)@ type T; T[] E; position p; @@ ( (sizeof(E)@p

[PATCH] uapi: fix linux/tls.h userspace compilation error

Move inclusion of a private kernel header from uapi/linux/tls.h to its only user - net/tls.h, to fix the following linux/tls.h userspace compilation error: /usr/include/linux/tls.h:41:21: fatal error: net/tcp.h: No such file or directory As to this point uapi/linux/tls.h was totaly unusuable

Re: KASAN: use-after-free Read in rds_tcp_dev_event

On 11/7/17 12:28 PM, syzbot wrote: Hello, syzkaller hit the following crash on 287683d027a3ff83feb6c7044430c79881664ecf git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached.

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

Yes, thanks for your advise. I will modify, test it and then submit v3 On Tue, Nov 14, 2017 at 10:09 AM, Cong Wang wrote: > On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang > wrote: >> From: Tonghao Zhang >> >> This

Re: [PATCH net] ipv6: set all.accept_dad to 0 by default

On Mon, 13 Nov 2017 14:21:52 + Erik Kline wrote: > Alternatively, if we really want to make all, default, and ifname > useful perhaps we need to investigate a tristate option (for currently > boolean values, at least). -1 could mean no preference, for example. I think this

Re: [PATCH net] geneve: show remote address and checksum info even after link down

Hi Eric, Thanks for the comments. On Mon, Nov 13, 2017 at 03:27:25PM -0500, Eric Garver wrote: > > Fixes: 11387fe4a98 ("geneve: fix fill_info when using collect_metadata") > > Signed-off-by: Hangbin Liu > > --- > > drivers/net/geneve.c | 28 +++- >

Re: [PATCH net] ipv6: set all.accept_dad to 0 by default

On Mon, 13 Nov 2017 14:45:36 +0100 Nicolas Dichtel wrote: > The commit a2d3f3e33853 modifies the way to disable dad on an interface. > Before the patch, setting .accept_dad to 0 was enough to disable it. > Because all.accept_dad is set to 1 by default, after the patch,

Re: Per-CPU Queueing for QoS

2017-11-13 16:13 GMT-08:00 Alexander Duyck : > On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote: >> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >>> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >>> >

Re: [PATCH net-next] net: dsa: Fix dependencies on bridge

From: Andrew Lunn Date: Sat, 11 Nov 2017 16:29:41 +0100 > DSA now uses one of the symbols exported by the bridge, > br_vlan_enabled(). This has a stub, if the bridge is not > enabled. However, if the bridge is enabled, we cannot have DSA built > in and the bridge as a module,

Re: [PATCH v2 net-next] socket: Move the socket inuse to namespace.

On Mon, Nov 13, 2017 at 4:36 AM, Tonghao Zhang wrote: > From: Tonghao Zhang > > This patch add a member in struct netns_core. and this is > a counter for socket_inuse in the _net_ namespace. The patch > will add/sub counter in the sock_alloc or

Re: Per-CPU Queueing for QoS

2017-11-13 18:05 GMT-08:00 Michael Ma : > 2017-11-13 15:08 GMT-08:00 Eric Dumazet : >> On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >>> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >>> > 2017-11-12 16:14 GMT-08:00

Re: Per-CPU Queueing for QoS

2017-11-13 15:08 GMT-08:00 Eric Dumazet : > On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >> >> On Sun, 12

Re: Per-CPU Queueing for QoS

2017-11-13 14:47 GMT-08:00 Alexander Duyck : > On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >>> On Sun, 12 Nov 2017 13:43:13 -0800 >>> Michael Ma

[PATCH] usbnet: ipheth: prevent TX queue timeouts when device not ready

iOS devices require the host to be "trusted" before servicing network packets. Establishing trust requires the user to confirm a dialog on the iOS device.Until trust is established, the iOS device will silently discard network packets from the host. Currently, the ipheth driver does not detect

RE: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip KSZ8795 DSA driver

> Subject: Microchip KSZ* DSA drivers Re: [PATCH v1 RFC 1/1] Add Microchip > KSZ8795 DSA driver > > Hi! > > Are there any news here? Is there new release planned? Is there a git > tree somewhere? I probably should get it working, soon.. so I guess I > can help with testing. > Reviewed patches

Re: [PATCH] ibmveth: Kernel crash LSO offload flag toggle

Hi Bryant, A few things: 1) The commit message could probably be trimmed, especially the stack traces. 2) What exactly are you changing and why does it fix the issue? I couldn't figure that out from the commit message. 3) Does this need a Fixes: tag? > } > > - netdev->min_mtu =

Re: [PATCH RFC,WIP 0/5] Flow offload infrastructure

On Fri, 3 Nov 2017 16:26:31 +0100, Pablo Neira Ayuso wrote: > I'm measuring here that the software flow table forwarding path is 2.5 > faster than the classic forwarding path in my testbed. > > TODO, still many things: > > * Only IPv4 at this time. > * Only IPv4 SNAT is supported. > * No netns

Re: [PATCH 12/14] nubus: Rename struct nubus_dev

On Mon, 13 Nov 2017, Geert Uytterhoeven wrote: > Hi Finn, > > On Sat, Nov 11, 2017 at 7:12 AM, Finn Thain > wrote: > > It is misleading to use "dev" to mean a functional resource. And in > > adopting the Linux Driver Model, struct nubus_board will embed a > >

Re: Per-CPU Queueing for QoS

On Mon, Nov 13, 2017 at 3:08 PM, Eric Dumazet wrote: > On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: >> On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: >> > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >>

Re: len = bpf_probe_read_str(); bpf_perf_event_output(... len) == FAIL

On 11/13/2017 04:08 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 13, 2017 at 03:56:14PM +0100, Daniel Borkmann escreveu: >> On 11/13/2017 03:30 PM, Arnaldo Carvalho de Melo wrote: >>> Hi, >>> >>> In a5e8c07059d0 ("bpf: add bpf_probe_read_str helper") you >>> state: >>> >>>"This is

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

> I wonder if there is some way to use the split format for the > intermediate files, but then for the very final link bring them all in > and make the end result be a traditional single binary. I'm not > talking the separate "dwp" package that packs multiple dwo files into > one, but to actually

Re: [RFC PATCH 00/14] Introducing AF_PACKET V4 support

On 11/13/17 9:07 PM, Björn Töpel wrote: 2017-10-31 13:41 GMT+01:00 Björn Töpel : From: Björn Töpel [...] We'll do a presentation on AF_PACKET V4 in NetDev 2.2 [1] Seoul, Korea, and our paper with complete benchmarks will be released shortly on

[PATCH] ibmveth: Kernel crash LSO offload flag toggle

The following script when run (along with some iperf traffic recreates the crash within 5-10 mins or so). while true do ethtool -k ibmveth0 | grep tcp-segmentation-offload ethtool -K ibmveth0 tso off ethtool -k ibmveth0 | grep tcp-segmentation-offload ethtool -K

Re: Per-CPU Queueing for QoS

On Mon, 2017-11-13 at 14:47 -0800, Alexander Duyck wrote: > On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: > > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : > >> On Sun, 12 Nov 2017 13:43:13 -0800 > >> Michael Ma wrote: >

Re: [RFC v2 0/6] enable creating [k,u]probe with perf_event_open

> On Nov 12, 2017, at 3:40 PM, Song Liu wrote: > > Changes v1 to v2: > Fix build issue reported by kbuild test bot by adding ifdef of > CONFIG_KPROBE_EVENTS, and CONFIG_UPROBE_EVENTS. > > v1 cover letter: > > This is to follow up the discussion over "new kprobe api"

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

On 11/14/17 4:20 AM, Daniel Borkmann wrote: On 11/13/2017 09:09 PM, Lawrence Brakmo wrote: On 11/13/17, 11:01 AM, "Vlad Dumitrescu" wrote: On Sat, Nov 11, 2017 at 2:38 PM, Alexei Starovoitov wrote: > > On 11/12/17 4:46 AM, Daniel Borkmann wrote:

Re: Per-CPU Queueing for QoS

On Mon, Nov 13, 2017 at 10:17 AM, Michael Ma wrote: > 2017-11-12 16:14 GMT-08:00 Stephen Hemminger : >> On Sun, 12 Nov 2017 13:43:13 -0800 >> Michael Ma wrote: >> >>> Any comments? We plan to implement this as a qdisc and

Re: [RFC PATCH 5/5] selinux: Add SCTP support

On Mon, Nov 13, 2017 at 5:05 PM, Richard Haines wrote: > On Mon, 2017-11-06 at 19:09 -0500, Paul Moore wrote: >> On Tue, Oct 17, 2017 at 9:59 AM, Richard Haines >> wrote: >> > The SELinux SCTP implementation is explained in: >> >

Re: [RFC PATCH 4/5] netlabel: Add SCTP support

On Mon, Nov 13, 2017 at 3:50 PM, Richard Haines wrote: > On Mon, 2017-11-06 at 18:15 -0500, Paul Moore wrote: >> On Tue, Oct 17, 2017 at 9:58 AM, Richard Haines >> wrote: >> > Add support to label SCTP associations and cater for a

Re: [PATCH] netlabel: If PF_INET6, check sk_buff ip header version

On Mon, Nov 13, 2017 at 3:54 PM, Richard Haines wrote: > When resolving a fallback label, check the sk_buff version as it > is possible (e.g. SCTP) to have family = PF_INET6 while > receiving ip_hdr(skb)->version = 4. > > Signed-off-by: Richard Haines

[PATCH][v3] uprobes/x86: emulate push insns for uprobe on x86

Uprobe is a tracing mechanism for userspace programs. Typical uprobe will incur overhead of two traps. First trap is caused by replaced trap insn, and the second trap is to execute the original displaced insn in user space. To reduce the overhead, kernel provides hooks for architectures to

Re: [RFC PATCH 5/5] selinux: Add SCTP support

On Mon, 2017-11-06 at 19:09 -0500, Paul Moore wrote: > On Tue, Oct 17, 2017 at 9:59 AM, Richard Haines > wrote: > > The SELinux SCTP implementation is explained in: > > Documentation/security/SELinux-sctp.txt > > > > Signed-off-by: Richard Haines

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

On Mon, Nov 13, 2017 at 1:41 PM, Andi Kleen wrote: > > It seems to be broken for normal programs too Ok. I wonder if there is some way to use the split format for the intermediate files, but then for the very final link bring them all in and make the end result be a

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

Can you explain what do you mean by "subsystem"? I thought that the subsystem would be the irq subsystem (which means you are the one to provide the needed input :) ) and the driver would pass in something like msi_irq_ops to pci_alloc_irq_vectors() if it supports the driver requirements that

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

On Mon, Nov 13, 2017 at 12:56:31PM -0800, Linus Torvalds wrote: > On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > > > You're right. It works for line information, but strangely not for > > inlines. I assume it can be fixed. > > So I'm not 100% sure it's strictly a

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

On Mon, 13 Nov 2017, Sagi Grimberg wrote: > > > > #1 Before the core tries to move the interrupt so it can veto > > > > the > > > > move if it cannot allocate new resources or whatever is > > > > required > > > > to operate after the move. > > > > > > What would the

RE: tipc_udp_send_msg oops in 4.4 when setting link tolerance

Hi Tommi, I am not sure, but is seems like the following patch is what you need: commit 9b3009604b8e ("tipc: add net device to skb before UDP xmit") This was applied in tipc 4.5. Is this a stooping problem for you? BR ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

Do you know if any exist? Would it make sense to have a survey to understand if anyone relies on it? From what I've seen so far, drivers that were converted simply worked with the non-managed facility and didn't have any special code for it. Perhaps Christoph can comment as he convert most of

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: > > You're right. It works for line information, but strangely not for > inlines. I assume it can be fixed. So I'm not 100% sure it's strictly a addr2line bug. We do more than just link the vmlinux file. There's that

[PATCH] netlabel: If PF_INET6, check sk_buff ip header version

When resolving a fallback label, check the sk_buff version as it is possible (e.g. SCTP) to have family = PF_INET6 while receiving ip_hdr(skb)->version = 4. Signed-off-by: Richard Haines --- net/netlabel/netlabel_unlabeled.c | 10 ++ 1 file changed, 10

Re: [RFD] Managed interrupt affinities [ Was: mlx5 broken affinity ]

On Mon, 13 Nov 2017, Sagi Grimberg wrote: > > 3) Affinity override in managed mode > > > > Doable, but there are a couple of things to think about: > > I think that it will be good to shoot for (3). Given that there are > driver requirements I'd say that driver will expose up front if it can >

Re: [RFC PATCH 4/5] netlabel: Add SCTP support

On Mon, 2017-11-06 at 18:15 -0500, Paul Moore wrote: > On Tue, Oct 17, 2017 at 9:58 AM, Richard Haines > wrote: > > Add support to label SCTP associations and cater for a situation > > where > > family = PF_INET6 with an ip_hdr(skb)->version = 4. > > > >

Re: [PATCH][v2] uprobes/x86: emulate push insns for uprobe on x86

On 11/13/17 4:59 AM, Oleg Nesterov wrote: The patch looks good to me, but I have a question because I know nothing about insn encoding, On 11/10, Yonghong Song wrote: +static int push_setup_xol_ops(struct arch_uprobe *auprobe, struct insn *insn) +{ + u8 opc1 = OPCODE1(insn),

Re: [PATCH net] geneve: show remote address and checksum info even after link down

On Mon, Nov 13, 2017 at 05:03:26PM +0800, Hangbin Liu wrote: > geneve->sock4/6 were added with geneve_open and released with geneve_stop. > So when geneve link down, we will not able to show remote address and > checksum info after commit 11387fe4a98 ("geneve: fix fill_info when using >

Re: [PATCH net-next v2] net: move decnet to staging

On Mon, 2017-11-13 at 11:32 -0800, Joe Perches wrote: > On Mon, 2017-11-13 at 09:11 -0800, Stephen Hemminger wrote: > > Support for Decnet has been orphaned for some time. > > In the interest of reducing the potential bug surface and pre-holiday > > cleaning, move the decnet protocol into staging

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

On 11/13/2017 09:09 PM, Lawrence Brakmo wrote: > On 11/13/17, 11:01 AM, "Vlad Dumitrescu" wrote: > > On Sat, Nov 11, 2017 at 2:38 PM, Alexei Starovoitov wrote: > > > > On 11/12/17 4:46 AM, Daniel Borkmann wrote: > >> > >> On 11/11/2017 05:06

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

On Mon, Nov 13, 2017 at 12:10 PM, Andi Kleen wrote: >> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, >> it saves time and disk space, but does so at the expense of making all >> the debug information unavailable to basic tools. > > You're right. It

[RFC PATCH 17/17] net: sched: lock once per bulk dequeue

Signed-off-by: John Fastabend --- 0 files changed diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c index 683f6ec..8ab7933 100644 --- a/net/sched/sch_generic.c +++ b/net/sched/sch_generic.c @@ -206,33 +206,22 @@ static struct sk_buff *dequeue_skb(struct

[RFC PATCH 16/17] net: skb_array additions for unlocked consumer

Signed-off-by: John Fastabend --- 0 files changed diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index c7addf3..d0a240e 100644 --- a/include/linux/skb_array.h +++ b/include/linux/skb_array.h @@ -142,6 +142,11 @@ static inline int

[RFC PATCH 14/17] net: skb_array: expose peek API

This adds a peek routine to skb_array.h for use with qdisc. Signed-off-by: John Fastabend --- 0 files changed diff --git a/include/linux/skb_array.h b/include/linux/skb_array.h index 8621ffd..c7addf3 100644 --- a/include/linux/skb_array.h +++

[RFC PATCH 15/17] net: sched: pfifo_fast use skb_array

This converts the pfifo_fast qdisc to use the skb_array data structure and set the lockless qdisc bit. This also removes the logic used to pick the next band to dequeue from and instead just checks a per priority array for packets from top priority to lowest. This might need to be a bit more

[RFC PATCH 13/17] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mqprio

The sch_mqprio qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this

[RFC PATCH 12/17] net: sched: add support for TCQ_F_NOLOCK subqueues to sch_mq

The sch_mq qdisc creates a sub-qdisc per tx queue which are then called independently for enqueue and dequeue operations. However statistics are aggregated and pushed up to the "master" qdisc. This patch adds support for any of the sub-qdiscs to be per cpu statistic qdiscs. To handle this case

[RFC PATCH 11/17] net: sched: helper to sum qlen

Reporting qlen when qlen is per cpu requires aggregating the per cpu counters. This adds a helper routine for this. Signed-off-by: John Fastabend --- 0 files changed diff --git a/include/net/sch_generic.h b/include/net/sch_generic.h index bad24a9..5824509 100644 ---

[RFC PATCH 10/17] net: sched: qdisc_qlen for per cpu logic

Add qdisc qlen helper routines for lockless qdiscs to use. The qdisc qlen is no longer used in the hotpath but it is reported via stats query on the qdisc so it still needs to be tracked. This adds the per cpu operations needed. Signed-off-by: John Fastabend --- 0

[RFC PATCH 07/17] net: sched: drop qdisc_reset from dev_graft_qdisc

In qdisc_graft_qdisc a "new" qdisc is attached and the 'qdisc_destroy' operation is called on the old qdisc. The destroy operation will wait a rcu grace period and call qdisc_rcu_free(). At which point gso_cpu_skb is free'd along with all stats so no need to zero stats and gso_cpu_skb from the

[RFC PATCH 09/17] net: sched: check for frozen queue before skb_bad_txq check

I can not think of any reason to pull the bad txq skb off the qdisc if the txq we plan to send this on is still frozen. So check for frozen queue first and abort before dequeuing either skb_bad_txq skb or normal qdisc dequeue() skb. Signed-off-by: John Fastabend --- 0

Re: CONFIG_DEBUG_INFO_SPLIT impacts on faddr2line

> Put another way: the CONFIG_DEBUG_INFO_SPLIT option is useless. Yes, > it saves time and disk space, but does so at the expense of making all > the debug information unavailable to basic tools. You're right. It works for line information, but strangely not for inlines. I assume it can be fixed.

[RFC PATCH 08/17] net: sched: use skb list for skb_bad_tx

Similar to how gso is handled use skb list for skb_bad_tx this is required with lockless qdiscs because we may have multiple cores attempting to push skbs into skb_bad_tx concurrently Signed-off-by: John Fastabend --- 0 files changed diff --git

Re: [PATCH net-next] bpf: expose sk_priority through struct bpf_sock_ops

On 11/13/17, 11:01 AM, "Vlad Dumitrescu" wrote: On Sat, Nov 11, 2017 at 2:38 PM, Alexei Starovoitov wrote: > > On 11/12/17 4:46 AM, Daniel Borkmann wrote: >> >> On 11/11/2017 05:06 AM, Alexei Starovoitov wrote: >>> >>> On 11/11/17

[RFC PATCH 04/17] net: sched: provide per cpu qstat helpers

The per cpu qstats support was added with per cpu bstat support which is currently used by the ingress qdisc. This patch adds a set of helpers needed to make other qdiscs that use qstats per cpu as well. Signed-off-by: John Fastabend --- 0 files changed diff --git

[RFC PATCH 05/17] net: sched: a dflt qdisc may be used with per cpu stats

Enable dflt qdisc support for per cpu stats before this patch a dflt qdisc was required to use the global statistics qstats and bstats. This adds a static flags field to qdisc_ops that is propagated into qdisc->flags in qdisc allocate call. This allows the allocation block to completely allocate

[RFC PATCH 06/17] net: sched: explicit locking in gso_cpu fallback

This work is preparing the qdisc layer to support egress lockless qdiscs. If we are running the egress qdisc lockless in the case we overrun the netdev, for whatever reason, the netdev returns a busy error code and the skb is parked on the gso_skb pointer. With many cores all hitting this case at

[RFC PATCH 03/17] net: sched: remove remaining uses for qdisc_qlen in xmit path

sch_direct_xmit() uses qdisc_qlen as a return value but all call sites of the routine only check if it is zero or not. Simplify the logic so that we don't need to return an actual queue length value. This introduces a case now where sch_direct_xmit would have returned a qlen of zero but now it

[RFC PATCH 02/17] net: sched: allow qdiscs to handle locking

This patch adds a flag for queueing disciplines to indicate the stack does not need to use the qdisc lock to protect operations. This can be used to build lockless scheduling algorithms and improving performance. The flag is checked in the tx path and the qdisc lock is only taken if it is not

[RFC PATCH 00/17] lockless qdisc

Multiple folks asked me about this series at net(dev)conf so with a 10+hour flight and a bit testing once back home I think these are ready to be submitted. Net-next is closed at the moment http://vger.kernel.org/~davem/net-next.html but, once it opens up we can get these in first thing and

  1   2   3   >