Re: A TLP implementation question

2018-02-13 Thread hiren panchasara
On 02/13/18 at 05:11P, Yuchung Cheng wrote: > On Tue, Feb 13, 2018 at 4:27 PM, hiren panchasara > wrote: > > > > Looking at current net-next to understand an aspect of TLP (tail loss > > probe) implementation. > > > > https://tools.ietf.org/html/draft-ietf-tcpm-rack-02

[PATCH net-next v2 2/2] cxgb4: speed up on-chip memory read

2018-02-13 Thread Rahul Lakkireddy
Use readq() (via t4_read_reg64()) to read 64-bits at a time. Read residual in 32-bit multiples. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Dropped AVX CPU intrinisc instructions. - Use readq() (via t4_read_reg64())

[PATCH net-next v2 1/2] cxgb4: rework on-chip memory read

2018-02-13 Thread Rahul Lakkireddy
Rework logic to read EDC and MC. Do 32-bit reads at a time. Signed-off-by: Rahul Lakkireddy Signed-off-by: Ganesh Goudar --- v2: - Dropped exporting callback to register AVX CPU intrinsic to do 256-bit reads at a time.

[PATCH net-next v2 0/2] cxgb4: speed up reading on-chip memory

2018-02-13 Thread Rahul Lakkireddy
This series of patches speed up reading on-chip memory (EDC and MC) by reading 64-bits at a time. Patch 1 reworks logic to read EDC and MC. Patch 2 adds logic to read EDC and MC 64-bits at a time. Thanks, Rahul --- v2: - Dropped AVX CPU intrinsic instructions. - Use readq() to read 64-bits at

[PATCH 0/3] Updates to segmentation-offloads.txt

2018-02-13 Thread Daniel Axtens
I've been trying to wrap my head around GSO for a while now. This is a set of small changes to the docs that would probably have been helpful when I was starting out. I realise that GSO_DODGY is still a notable omission - I'm hesitant to write too much on it just yet as I don't understand it well

[PATCH 3/3] docs: segmentation-offloads.txt: add SCTP info

2018-02-13 Thread Daniel Axtens
Most of this is extracted from 90017accff61 ("sctp: Add GSO support"), with some extra text about GSO_BY_FRAGS and the need to check for it. Cc: Marcelo Ricardo Leitner Signed-off-by: Daniel Axtens ---

[PATCH 1/3] docs: segmentation-offloads.txt: update for UFO depreciation

2018-02-13 Thread Daniel Axtens
UFO is deprecated except for tuntap and packet per 0c19f846d582, ("net: accept UFO datagrams from tuntap and packet"). Update UFO docs to reflect this. Signed-off-by: Daniel Axtens --- Documentation/networking/segmentation-offloads.txt | 4 1 file changed, 4 insertions(+)

[PATCH 2/3] docs: segmentation-offloads.txt: Fix ref to SKB_GSO_TUNNEL_REMCSUM

2018-02-13 Thread Daniel Axtens
The doc originally called it SKB_GSO_REMCSUM. Fix it. Fixes: f7a6272bf3cb ("Documentation: Add documentation for TSO and GSO features") Signed-off-by: Daniel Axtens -- The only text change is s/SKB_GSO_REMCSUM/SKB_GSO_TUNNEL_REMCSUM/, but I rewrapped the text which is why the

[PATCH net] selftests/net: fixes psock_fanout eBPF test case

2018-02-13 Thread Prashant Bhole
eBPF test fails due to verifier failure because log_buf is too small Fixed by increasing log_buf size Signed-off-by: Prashant Bhole --- tools/testing/selftests/net/psock_fanout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v7 31/37] MAINTAINERS: Add nds32

2018-02-13 Thread Greentime Hu
2018-02-14 0:02 GMT+08:00 Joe Perches : > On Tue, 2018-02-13 at 17:09 +0800, Greentime Hu wrote: >> Add a maintainer information for the nds32(Andes) architecture. > [] >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -868,6 +868,17 @@ X: drivers/iio/*/adjd* >> F:

Re: [PATCH net v3] tipc: fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Ying Xue
On 02/13/2018 07:03 PM, Kirill Tkhai wrote: > The patch is logically OK for me. The only thing I'm confused, > I had to split it in 7 patches to review, otherwise the patch > looks difficult to do. There is possible to extract: > > 1)Refactoring in __tipc_nl_compat_doit > 2)Introduce

[PATCH net v4 5/7] tipc: Introduce __tipc_nl_media_set

2018-02-13 Thread Ying Xue
Introduce __tipc_nl_media_set() which doesn't hold RTNL lock. Signed-off-by: Ying Xue --- net/tipc/bearer.c | 23 ++- net/tipc/bearer.h | 1 + 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index

[PATCH net v4 3/7] tipc: Introduce __tipc_nl_bearer_enable

2018-02-13 Thread Ying Xue
Introduce __tipc_nl_bearer_enable() which doesn't hold RTNL lock. Signed-off-by: Ying Xue --- net/tipc/bearer.c | 17 ++--- net/tipc/bearer.h | 1 + 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c index

[PATCH net v4 6/7] tipc: Introduce __tipc_nl_net_set

2018-02-13 Thread Ying Xue
Introduce __tipc_nl_net_set() which doesn't hold RTNL lock. Signed-off-by: Ying Xue --- net/tipc/net.c | 15 --- net/tipc/net.h | 1 + 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/net/tipc/net.c b/net/tipc/net.c index 719c592..1a2fde0

[PATCH net v4 7/7] tipc: Fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Ying Xue
Currently when user changes link properties, TIPC first checks if user's command message contains media name or bearer name through tipc_media_find() or tipc_bearer_find() which is protected by RTNL lock. But when tipc_nl_compat_link_set() conducts the checking with the two functions, it doesn't

[PATCH net v4 2/7] tipc: Introduce __tipc_nl_bearer_disable

2018-02-13 Thread Ying Xue
Introduce __tipc_nl_bearer_disable() which doesn't hold RTNL lock. Signed-off-by: Ying Xue --- net/tipc/bearer.c | 19 +-- net/tipc/bearer.h | 1 + 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c

[PATCH net v4 1/7] tipc: Refactor __tipc_nl_compat_doit

2018-02-13 Thread Ying Xue
As preparation for adding RTNL to make (*cmd->transcode)() and (*cmd->transcode)() constantly protected by RTNL lock, we move out of memory allocations existing between them as many as possible so that the time of holding RTNL can be minimized in __tipc_nl_compat_doit(). Signed-off-by: Ying Xue

[PATCH net v4 4/7] tipc: Introduce __tipc_nl_bearer_set

2018-02-13 Thread Ying Xue
Introduce __tipc_nl_bearer_set() which doesn't holding RTNL lock. Signed-off-by: Ying Xue --- net/tipc/bearer.c | 23 ++- net/tipc/bearer.h | 1 + 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c

[PATCH net v4 0/7] tipc: Fix missing RTNL lock protection during setting link properties

2018-02-13 Thread Ying Xue
At present it's unsafe to configure link properties through netlink as the entire setting process is not under RTNL lock protection. Now TIPC supports two different sets of netlink APIs at the same time, and they share the same set of backend functions to configure bearer, media and net

Re: [PATCH net-next] selftests: Add FIB onlink tests

2018-02-13 Thread David Ahern
On 2/13/18 1:39 PM, Ido Schimmel wrote: > On Tue, Feb 13, 2018 at 08:44:06AM -0800, David Ahern wrote: >> Add test cases verifying FIB onlink commands work as expected in >> various conditions - IPv4, IPv6, main table, and VRF. >> >> Signed-off-by: David Ahern >> --- >>

[PATCH v2 net-next] net: Move ipv4 set_lwt_redirect helper to lwtunnel

2018-02-13 Thread David Ahern
IPv4 uses set_lwt_redirect to set the lwtunnel redirect functions as needed. Move it to lwtunnel.h as lwtunnel_set_redirect and change IPv6 to also use it. Signed-off-by: David Ahern --- v2 - removed extra check on dst->lwtstate include/net/lwtunnel.h | 15 +++

Re: [PATCH net-next 00/10] PTP support for DSA and mv88e6xxx driver.

2018-02-13 Thread Richard Cochran
On Wed, Feb 14, 2018 at 01:07:41AM +0100, Andrew Lunn wrote: > Further work is requires to support bridges using Boundary Clock or > Transparent Clock mode. Small correction: Boundary Clock (BC) works just fine if the DSA ports are separate (not in a bridge device). If the DSA ports *are*

Re: [PATCH RFC 0/2] Packed ring for vhost

2018-02-13 Thread Jason Wang
On 2018年02月14日 10:47, Michael S. Tsirkin wrote: On Wed, Feb 14, 2018 at 10:37:07AM +0800, Jason Wang wrote: Hi all: This RFC implement a subset of packed ring which was described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd07.pdf . The code were tested with

[PATCH net] tuntap: try not batch packets for devmap

2018-02-13 Thread Jason Wang
Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the devmap stall caused by missed xdp flush by counting the pending xdp redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or MSG_MORE is clear. This may lead BUG() since xdp_do_flush() was called under process context

Re: [net-next 00/10][pull request] 40GbE Intel Wired LAN Driver Updates 2018-02-13

2018-02-13 Thread David Miller
From: Jeff Kirsher Date: Tue, 13 Feb 2018 11:53:22 -0800 > This series contains updates to i40e and i40evf. ... > The following are changes since commit > 8c2ceabe99e04005cadba739856eed6953a8a3af: > net/ipv4: Unexport fib_multipath_hash and fib_select_path > and

Re: [PATCH bpf-next] bpf: fix sock_map_alloc() error path

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 06:53:36PM -0800, John Fastabend wrote: > On 02/13/2018 05:19 PM, Daniel Borkmann wrote: > > Hi Eric, > > > > On 02/14/2018 12:43 AM, Eric Dumazet wrote: > >> On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote: > >>> From: Eric Dumazet > >>> > >>>

Re: [PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 07:00:21PM -0800, Yonghong Song wrote: > There is a memory leak happening in lpm_trie map_free callback > function trie_free. The trie structure itself does not get freed. > > Also, trie_free function did not do synchronize_rcu before freeing > various data structures.

[PATCH bpf v2] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-13 Thread Yonghong Song
There is a memory leak happening in lpm_trie map_free callback function trie_free. The trie structure itself does not get freed. Also, trie_free function did not do synchronize_rcu before freeing various data structures. This is incorrect as some rcu_read_lock region(s) for lookup, update, delete

Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

2018-02-13 Thread John Fastabend
On 02/09/2018 11:56 AM, Tushar Dave wrote: > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@labbpf]# ./xdp_redirect $(> $( failed to create a map: 1 Operation not permitted > > The failure is seen when executing xdp_redirect while xdp_monitor > is already runnig. >

Re: [PATCH bpf-next] bpf: fix sock_map_alloc() error path

2018-02-13 Thread John Fastabend
On 02/13/2018 05:19 PM, Daniel Borkmann wrote: > Hi Eric, > > On 02/14/2018 12:43 AM, Eric Dumazet wrote: >> On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote: >>> From: Eric Dumazet >>> >>> In case user program provides silly parameters, we want >>> a map_alloc()

[PATCH RFC 1/2] virtio: introduce packed ring defines

2018-02-13 Thread Jason Wang
Signed-off-by: Jason Wang --- include/uapi/linux/virtio_config.h | 9 + include/uapi/linux/virtio_ring.h | 17 + 2 files changed, 26 insertions(+) diff --git a/include/uapi/linux/virtio_config.h b/include/uapi/linux/virtio_config.h index

[PATCH RFC 2/2] vhost: packed ring support

2018-02-13 Thread Jason Wang
Signed-off-by: Jason Wang --- drivers/vhost/net.c | 14 +- drivers/vhost/vhost.c | 351 ++ drivers/vhost/vhost.h | 6 +- 3 files changed, 343 insertions(+), 28 deletions(-) diff --git a/drivers/vhost/net.c

Re: [PATCH RFC 0/2] Packed ring for vhost

2018-02-13 Thread Michael S. Tsirkin
On Wed, Feb 14, 2018 at 10:37:07AM +0800, Jason Wang wrote: > Hi all: > > This RFC implement a subset of packed ring which was described at > https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd07.pdf > . The code were tested with pmd implement by Jens at >

Re: [PATCH RFC 0/2] Packed ring for vhost

2018-02-13 Thread Jason Wang
On 2018年02月14日 10:37, Jason Wang wrote: Hi all: This RFC implement a subset of packed ring which was described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd07.pdf . The code were tested with pmd implement by Jens at

[PATCH RFC 0/2] Packed ring for vhost

2018-02-13 Thread Jason Wang
Hi all: This RFC implement a subset of packed ring which was described at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd07.pdf . The code were tested with pmd implement by Jens at http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change was needed for pmd

Re: [bpf-next PATCH] net: avoid including xdp.h in filter.h

2018-02-13 Thread John Fastabend
On 02/13/2018 05:57 PM, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote: >> If is sufficient with a forward declaration of struct xdp_rxq_info in >> linux/filter.h, which avoids including net/xdp.h. This was originally >> suggested by John

Re: [PATCH bpf] bpf: samples/sockmap detach sock ops program

2018-02-13 Thread John Fastabend
On 02/13/2018 05:49 PM, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 01:44:22PM +0900, Prashant Bhole wrote: >> samples/sockops program keeps the sock_ops program attached to cgroup. >> Fixed this by detaching program before exit. >> >> Signed-off-by: Prashant Bhole

Re: [PATCH bpf] bpf: samples/sockmap fix Makefile for build error

2018-02-13 Thread John Fastabend
On 02/13/2018 05:48 PM, Alexei Starovoitov wrote: > On Tue, Feb 13, 2018 at 01:42:49PM +0900, Prashant Bhole wrote: >> While building samples/sockmap, undefined reference error is thrown >> for `nla_dump_errormsg'. >> Linking tools/lib/bpf/nlattr.o as a fix >> >> Signed-off-by: Prashant Bhole

Re: [PATCH bpf-next] tools/bpf: adjust rlimit RLIMIT_MEMLOCK for test_tcpbpf_user

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 10:35:05AM -0800, Yonghong Song wrote: > The default rlimit RLIMIT_MEMLOCK is 64KB. In certain cases, > e.g. in a test machine mimicking our production system, this test may > fail due to unable to charge the required memory for map creation: ># ./test_tcpbpf_user >

Re: [bpf-next PATCH] selftests/bpf: fix Makefile for cgroup_helpers.c

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 02:19:15PM +0100, Jesper Dangaard Brouer wrote: > The current selftests Makefile construct result in cgroup_helpers.c > gets compiled together with all the TEST_GEN_PROGS. And it also result > in invoking the libbpf Makefile two times (tools/lib/bpf). > > These issues were

Re: [bpf-next PATCH] net: avoid including xdp.h in filter.h

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 02:15:36PM +0100, Jesper Dangaard Brouer wrote: > If is sufficient with a forward declaration of struct xdp_rxq_info in > linux/filter.h, which avoids including net/xdp.h. This was originally > suggested by John Fastabend during the review phase, but wasn't > included in

Re: [PATCH bpf] bpf: samples/sockmap detach sock ops program

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 01:44:22PM +0900, Prashant Bhole wrote: > samples/sockops program keeps the sock_ops program attached to cgroup. > Fixed this by detaching program before exit. > > Signed-off-by: Prashant Bhole Also applied to bpf-next considering that

Re: [PATCH bpf] bpf: samples/sockmap fix Makefile for build error

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 01:42:49PM +0900, Prashant Bhole wrote: > While building samples/sockmap, undefined reference error is thrown > for `nla_dump_errormsg'. > Linking tools/lib/bpf/nlattr.o as a fix > > Signed-off-by: Prashant Bhole Applied to bpf-next,

Re: [iproute PATCH] Remove leftovers from removed Latex documentation

2018-02-13 Thread Stephen Hemminger
On Fri, 9 Feb 2018 18:49:38 +0100 Phil Sutter wrote: > Since there is no documentation in Latex format left, there is no need > to check for commands to build it. Also there is no need to ignore any > of the temporary files which were created by them. > > Signed-off-by: Phil

Re: [PATCH bpf] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-13 Thread Yonghong Song
On 2/13/18 5:11 PM, Daniel Borkmann wrote: Hi Yonghong, On 02/12/2018 10:58 PM, Yonghong Song wrote: There is a memory leak happening in lpm_trie map_free callback function trie_free. The trie structure itself does not get freed. Also, trie_free function did not do synchronize_rcu before

Re: [net-next] samples/bpf: adjust rlimit RLIMIT_MEMLOCK for xdp_redirect

2018-02-13 Thread Alexei Starovoitov
On Fri, Feb 09, 2018 at 11:56:12AM -0800, Tushar Dave wrote: > Default rlimit RLIMIT_MEMLOCK is 64KB, causes bpf map failure. > e.g. > [root@labbpf]# ./xdp_redirect $( > $( failed to create a map: 1 Operation not permitted > > The failure is seen when executing xdp_redirect while xdp_monitor > is

Re: [vhost:vhost 22/23] drivers/firmware/qemu_fw_cfg.c:130:36: sparse: incorrect type in initializer (different base types)

2018-02-13 Thread Michael S. Tsirkin
On Wed, Feb 14, 2018 at 08:46:46AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost > head: 3d22d7c1190db3209b644b8a13a75a9802b4587f > commit: b3a8771f409b74c42deee28aee3092fc5d2c8dab [22/23] fw_cfg: write > vmcoreinfo details >

Re: [PATCH bpf-next] bpf: fix sock_map_alloc() error path

2018-02-13 Thread Daniel Borkmann
Hi Eric, On 02/14/2018 12:43 AM, Eric Dumazet wrote: > On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote: >> From: Eric Dumazet >> >> In case user program provides silly parameters, we want >> a map_alloc() handler to return an error, not a NULL pointer, >> otherwise we

Re: [PATCH bpf] bpf: fix memory leak in lpm_trie map_free callback function

2018-02-13 Thread Daniel Borkmann
Hi Yonghong, On 02/12/2018 10:58 PM, Yonghong Song wrote: > There is a memory leak happening in lpm_trie map_free callback > function trie_free. The trie structure itself does not get freed. > > Also, trie_free function did not do synchronize_rcu before freeing > various data structures. This is

Re: A TLP implementation question

2018-02-13 Thread Yuchung Cheng
On Tue, Feb 13, 2018 at 4:27 PM, hiren panchasara wrote: > > Looking at current net-next to understand an aspect of TLP (tail loss > probe) implementation. > > https://tools.ietf.org/html/draft-ietf-tcpm-rack-02 is the source of > truth now for TLP and 6.2.1. Phase 1:

Re: [PATCH v1 net-next 1/3] lan743x: Add main source file for new lan743x driver

2018-02-13 Thread Andrew Lunn
On Tue, Feb 13, 2018 at 06:26:48PM -0500, Bryan Whitehead wrote: > Add main source files for new lan743x driver > > Signed-off-by: Bryan Whitehead > --- > drivers/net/ethernet/microchip/lan743x_main.c | 2964 > + >

Re: [PATCH] headers: untangle kmemleak.h from mm.h

2018-02-13 Thread Randy Dunlap
On 02/11/2018 11:27 PM, Ingo Molnar wrote: > > * Randy Dunlap wrote: > >> From: Randy Dunlap >> >> Currently #includes for no obvious >> reason. It looks like it's only a convenience, so remove kmemleak.h >> from slab.h and add to any users of

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Mickaël Salaün
seccomp-bpf does not use cBPF but a subset of it. The reason is that it is meant to reduce the attack surface of the kernel. By limiting the number of instructions allowed by seccomp-bpf, it really reduce the possibilities for an attacker to use seccomp-bpf as an entry point to attack the kernel.

[vhost:vhost 22/23] drivers/firmware/qemu_fw_cfg.c:130:36: sparse: incorrect type in initializer (different base types)

2018-02-13 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git vhost head: 3d22d7c1190db3209b644b8a13a75a9802b4587f commit: b3a8771f409b74c42deee28aee3092fc5d2c8dab [22/23] fw_cfg: write vmcoreinfo details reproduce: # apt-get install sparse git checkout

Re: [iproute PATCH] Remove leftovers from removed Latex documentation

2018-02-13 Thread Stephen Hemminger
On Fri, 9 Feb 2018 18:49:38 +0100 Phil Sutter wrote: > Since there is no documentation in Latex format left, there is no need > to check for commands to build it. Also there is no need to ignore any > of the temporary files which were created by them. > > Signed-off-by: Phil

A TLP implementation question

2018-02-13 Thread hiren panchasara
Looking at current net-next to understand an aspect of TLP (tail loss probe) implementation. https://tools.ietf.org/html/draft-ietf-tcpm-rack-02 is the source of truth now for TLP and 6.2.1. Phase 1: Scheduling a loss probe Step 1: Check conditions for scheduling a PTO. has following as one of

[PATCH net 3/4] ibmvnic: Free RX socket buffer in case of adapter error

2018-02-13 Thread Thomas Falcon
If a RX buffer is returned to the client driver with an error, free the corresponding socket buffer before continuing. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH net 4/4] ibmvnic: Clean RX pool buffers during device close

2018-02-13 Thread Thomas Falcon
During device close or reset, there were some cases of outstanding RX socket buffers not being freed. Include a function similar to the one that already exists to clean TX socket buffers in this case. Signed-off-by: Thomas Falcon ---

[PATCH net 2/4] ibmvnic: Fix NAPI structures memory leak

2018-02-13 Thread Thomas Falcon
This memory is allocated during initialization but never freed, so do that now. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/ibm/ibmvnic.c

[PATCH net 1/4] ibmvnic: Fix login buffer memory leaks

2018-02-13 Thread Thomas Falcon
During device bringup, the driver exchanges login buffers with firmware. These buffers contain information such number of TX and RX queues alloted to the device, RX buffer size, etc. These buffers weren't being properly freed on device reset or close. We can free the buffer we send to firmware as

[PATCH net 0/4] ibmvnic: Fix memory leaks in the driver

2018-02-13 Thread Thomas Falcon
This patch set is pretty self-explanatory. It includes a number of patches that fix memory leaks found with kmemleak in the ibmvnic driver. Thomas Falcon (4): ibmvnic: Fix login buffer memory leak ibmvnic: Fix NAPI structures memory leak ibmvnic: Free RX socket buffer in case of adapter

[PATCH net-next 02/10] net: dsa: mv88e6xxx: export g2 register accessors

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff Let the mv88e6xxx_g2_* register accessor functions be accessible outside of global2.c. Signed-off-by: Brandon Streiff Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/global2.c | 8

[PATCH net-next 01/10] net: ptp: Add stub for ptp_classify_raw()

2018-02-13 Thread Andrew Lunn
When NET_PTP_CLASSIFY is disabled, a stub function is required in order that the drivers compile. Signed-off-by: Andrew Lunn Acked-by: Richard Cochran --- v2: Insert missing 'the' in commit message --- include/linux/ptp_classify.h | 4 1 file

[PATCH net-next 05/10] net: dsa: mv88e6xxx: add support for GPIO configuration

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff MV88E6352 and later switches support GPIO control through the "Scratch & Misc" global2 register. (Older switches do too, though with a slightly different register interface. Only the 6352-style is implemented here.) Add a new file,

[PATCH net-next 03/10] net: dsa: mv88e6xxx: add accessors for PTP/TAI registers

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff This patch implements support for accessing the Precision Time Protocol and Time Application Interface registers via the AVB register interface in the Global 2 register. The register interface differs slightly between different models; older models

[PATCH net-next 08/10] net: dsa: forward timestamping callbacks to switch drivers

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff Forward the rx/tx timestamp machinery from the dsa infrastructure to the switch driver. On the rx side, defer delivery of skbs until we have an rx timestamp. This mimicks the behavior of skb_defer_rx_timestamp. On the tx side, identify PTP packets,

[PATCH net-next 06/10] net: dsa: mv88e6xxx: add support for event capture

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff This patch adds support for configuring mv88e6xxx GPIO lines as PTP pins, so that they may be used for time stamping external events or for periodic output. Checkpatch and reverse Christmas tree fixes by Andrew Lunn Periodic output removed by

[PATCH net-next 00/10] PTP support for DSA and mv88e6xxx driver.

2018-02-13 Thread Andrew Lunn
This patchset adds support for using the PTP hardware in switches supported by the mv88e6xxx driver. The code was produces in collaboration with Brandon Streiff doing the initial implementation, and then Richard Cochran and Andrew Lunn making further changes and cleanups. The code is sufficient

[PATCH net-next 07/10] net: dsa: forward hardware timestamping ioctls to switch driver

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff This patch adds support to the dsa slave network device so that switch drivers can implement the SIOC[GS]HWTSTAMP ioctls and the ethtool timestamp-info interface. Signed-off-by: Brandon Streiff Signed-off-by: Andrew Lunn

[PATCH net-next 09/10] net: dsa: mv88e6xxx: add rx/tx timestamping support

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff This patch implements RX/TX timestamping support. The Marvell PTP hardware supports RX timestamping individual message types, but for simplicity we only support the EVENT receive filter since few if any clients bother with the more specific filter

[PATCH net-next 10/10] net: dsa: mv88e6xxx: add workaround for 6341 timestamping

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff 88E6341 devices default to timestamping at the PHY, but due to a hardware issue, timestamps via this component are unreliable. For this family, configure the PTP hardware to force the timestamping to occur at the MAC. Signed-off-by: Brandon Streiff

[PATCH net-next 04/10] net: dsa: mv88e6xxx: expose switch time as a PTP hardware clock

2018-02-13 Thread Andrew Lunn
From: Brandon Streiff This patch adds basic support for exposing the 32-bit timestamp counter inside the mv88e6xxx switch as a ptp_clock. Adjfine implemented by Richard Cochran. Andrew Lunn: fix return value of PTP stub function. Signed-off-by: Brandon Streiff

Re: [PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to include lan743x driver

2018-02-13 Thread Florian Fainelli
On 02/13/2018 03:26 PM, Bryan Whitehead wrote: > Update Kconfig and Makefile to include lan743x driver. This should be squashed into the first patch, otherwise the first patch introduces non buildable code, which is kind of pointless. > > Signed-off-by: Bryan Whitehead

Re: [PATCH bpf-next] bpf: fix sock_map_alloc() error path

2018-02-13 Thread Eric Dumazet
On Tue, 2018-02-13 at 15:33 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > In case user program provides silly parameters, we want > a map_alloc() handler to return an error, not a NULL pointer, > otherwise we crash later in find_and_alloc_map() > > Fixes: 174a79ff9515

[PATCH bpf-next] bpf: fix sock_map_alloc() error path

2018-02-13 Thread Eric Dumazet
From: Eric Dumazet In case user program provides silly parameters, we want a map_alloc() handler to return an error, not a NULL pointer, otherwise we crash later in find_and_alloc_map() Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support") Signed-off-by: Eric

Re: [RFC PATCH bpf-next 0/2] bpf/verifier: simplify subprog tracking

2018-02-13 Thread Jiong Wang
On 13/02/2018 05:09, John Fastabend wrote: To find these we do the following 1.a: Build the CFG of all the instructions so we can walk around the program easily. 1.b: Find the basic blocks and build the basic block CFG. After this with a few helper calls we can move

[PATCH v1 net-next 3/3] lan743x: Update MAINTAINERS to include lan743x driver maintainers

2018-02-13 Thread Bryan Whitehead
Update MAINTAINERS to include lan743x driver maintainers. Signed-off-by: Bryan Whitehead --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3bdc260..0fb76d8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@

[PATCH v1 net-next 2/3] lan743x: Update Kconfig and Makefile to include lan743x driver

2018-02-13 Thread Bryan Whitehead
Update Kconfig and Makefile to include lan743x driver. Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/Kconfig | 9 + drivers/net/ethernet/microchip/Makefile | 3 +++ 2 files changed, 12 insertions(+) diff --git

[PATCH v1 net-next 0/3] lan743x: Add new lan743x driver

2018-02-13 Thread Bryan Whitehead
Add new lan743x driver. The lan743x from Microchip Technologies Inc, is a PCIe to Gigabit Ethernet Controller. Bryan Whitehead (3): lan743x: Add main source file for new lan743x driver lan743x: Update Kconfig and Makefile to include lan743x driver lan743x: Update MAINTAINERS to include

[PATCH v1 net-next 1/3] lan743x: Add main source file for new lan743x driver

2018-02-13 Thread Bryan Whitehead
Add main source files for new lan743x driver Signed-off-by: Bryan Whitehead --- drivers/net/ethernet/microchip/lan743x_main.c | 2964 + drivers/net/ethernet/microchip/lan743x_main.h | 1331 +++ 2 files changed, 4295 insertions(+)

Re: [RFC PATCH bpf-next 0/2] bpf/verifier: simplify subprog tracking

2018-02-13 Thread Alexei Starovoitov
On Tue, Feb 13, 2018 at 06:14:53PM +, Edward Cree wrote: > > Anyway, that's my design, I hope it wasn't _too_ horrifying, and I hope to >  have some RFC patches in the next week or so. I prefer John's approach since it fits into my thinking how verifier should evolve and follows the outline

[PATCH net] ibmvnic: Wait until reset is complete to set carrier on

2018-02-13 Thread Thomas Falcon
Pushes back setting the carrier on until the end of the reset code. This resolves a bug where a watchdog timer was detecting that a TX queue had stalled before the adapter reset was complete. Signed-off-by: Thomas Falcon --- drivers/net/ethernet/ibm/ibmvnic.c | 4

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-13 Thread Nicolas Dichtel
Le 13/02/2018 à 22:02, David Ahern a écrit : > On 2/13/18 1:59 PM, Nicolas Dichtel wrote: >> Le 13/02/2018 à 21:35, David Ahern a écrit : >>> On 2/13/18 1:31 PM, Nicolas Dichtel wrote: Le 13/02/2018 à 01:06, David Ahern a écrit : > Some operators prefer IPv6 path selection to use a

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Paul Moore
On Tue, Feb 13, 2018 at 3:16 PM, Kees Cook wrote: > On Tue, Feb 13, 2018 at 9:31 AM, Sargun Dhillon wrote: >> On Tue, Feb 13, 2018 at 9:02 AM, Jessie Frazelle wrote: >>> On Tue, Feb 13, 2018 at 11:29 AM, Sargun Dhillon

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-13 Thread David Ahern
On 2/13/18 1:59 PM, Nicolas Dichtel wrote: > Le 13/02/2018 à 21:35, David Ahern a écrit : >> On 2/13/18 1:31 PM, Nicolas Dichtel wrote: >>> Le 13/02/2018 à 01:06, David Ahern a écrit : Some operators prefer IPv6 path selection to use a standard 5-tuple hash rather than just an L3 hash

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-13 Thread Nicolas Dichtel
Le 13/02/2018 à 21:35, David Ahern a écrit : > On 2/13/18 1:31 PM, Nicolas Dichtel wrote: >> Le 13/02/2018 à 01:06, David Ahern a écrit : >>> Some operators prefer IPv6 path selection to use a standard 5-tuple >>> hash rather than just an L3 hash with the flow the label. To that end >>> add

[PATCH V6 4/4] selinux: Add SCTP support

2018-02-13 Thread Richard Haines
The SELinux SCTP implementation is explained in: Documentation/security/SELinux-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/SELinux-sctp.rst | 157 ++ security/selinux/hooks.c| 280

[PATCH V6 3/4] sctp: Add LSM hooks

2018-02-13 Thread Richard Haines
Add security hooks allowing security modules to exercise access control over SCTP. Signed-off-by: Richard Haines --- include/net/sctp/structs.h | 10 include/uapi/linux/sctp.h | 1 + net/sctp/sm_make_chunk.c | 12 + net/sctp/sm_statefuns.c

RE: [PATCH] igb: Fix a test with HWTSTAMP_TX_ON

2018-02-13 Thread Brown, Aaron F
> From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Christophe JAILLET > Sent: Tuesday, February 6, 2018 11:48 AM > To: Kirsher, Jeffrey T > Cc: intel-wired-...@lists.osuosl.org; netdev@vger.kernel.org; linux- >

[PATCH V6 2/4] sctp: Add ip option support

2018-02-13 Thread Richard Haines
Add ip option support to allow LSM security modules to utilise CIPSO/IPv4 and CALIPSO/IPv6 services. Signed-off-by: Richard Haines --- include/net/sctp/sctp.h| 4 +++- include/net/sctp/structs.h | 2 ++ net/sctp/chunk.c | 12 +++-

[PATCH V6 0/4] Add SELinux SCTP protocol support

2018-02-13 Thread Richard Haines
These patches have been built on Fedora 27 with kernel-4.16.0-0.rc1 plus the following userspace patches to enable testing: 1) Updates to libsepol 2.7 to support the sctp portcon statement. The patch is available from: http://arctic.selinuxproject.org/~rhaines/selinux-sctp/

[PATCH V6 1/4] security: Add support for SCTP security hooks

2018-02-13 Thread Richard Haines
The SCTP security hooks are explained in: Documentation/security/LSM-sctp.rst Signed-off-by: Richard Haines --- Documentation/security/LSM-sctp.rst | 175 include/linux/lsm_hooks.h | 36

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Tycho Andersen
On Tue, Feb 13, 2018 at 12:16:42PM -0800, Kees Cook wrote: > If the needs Tycho outlined[1] could be addressed fully with eBPF, and > we can very narrowly scope the use of the "extra" eBPF features, I > might be more inclined to merge something like this, but I want to > take it very carefully.

[ANNOUNCE] igmpproxy 0.2.1

2018-02-13 Thread Pali Rohár
Hello, new version 0.2.1 of igmpproxy was released which fixes compilation on FreeBSD systems and also fixes broken option -n. It is just a minor version to address these problems. https://github.com/pali/igmpproxy/releases/tag/0.2.1 -- Pali Rohár pali.ro...@gmail.com signature.asc

Re: [PATCH V2 net-next] rds: do not call ->conn_alloc with GFP_KERNEL

2018-02-13 Thread David Miller
From: Sowmini Varadhan Date: Tue, 13 Feb 2018 09:05:44 -0800 > Commit ebeeb1ad9b8a ("rds: tcp: use rds_destroy_pending() to synchronize > netns/module teardown and rds connection/workq management") > adds an rcu read critical section to __rd_conn_create. The > memory

Re: [PATCH net-next] selftests: Add FIB onlink tests

2018-02-13 Thread Ido Schimmel
On Tue, Feb 13, 2018 at 08:44:06AM -0800, David Ahern wrote: > Add test cases verifying FIB onlink commands work as expected in > various conditions - IPv4, IPv6, main table, and VRF. > > Signed-off-by: David Ahern > --- > tools/testing/selftests/net/fib-onlink-tests.sh | 375

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Tom Hromatka
On 02/13/2018 01:35 PM, Kees Cook wrote: On Tue, Feb 13, 2018 at 12:33 PM, Tom Hromatka wrote: On Tue, Feb 13, 2018 at 7:42 AM, Sargun Dhillon wrote: This patchset enables seccomp filters to be written in eBPF. Although, this patchset doesn't

Re: [PATCH RFC net-next 5/7] net/ipv6: Add support for path selection using hash of 5-tuple

2018-02-13 Thread David Ahern
On 2/13/18 1:31 PM, Nicolas Dichtel wrote: > Le 13/02/2018 à 01:06, David Ahern a écrit : >> Some operators prefer IPv6 path selection to use a standard 5-tuple >> hash rather than just an L3 hash with the flow the label. To that end >> add support to IPv6 for multipath hash policy similar to

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Kees Cook
On Tue, Feb 13, 2018 at 12:33 PM, Tom Hromatka wrote: > On Tue, Feb 13, 2018 at 7:42 AM, Sargun Dhillon wrote: >> >> This patchset enables seccomp filters to be written in eBPF. Although, >> this patchset doesn't introduce much of the functionality

Re: [PATCH net-next 0/3] eBPF Seccomp filters

2018-02-13 Thread Tom Hromatka
On Tue, Feb 13, 2018 at 7:42 AM, Sargun Dhillon wrote: This patchset enables seccomp filters to be written in eBPF. Although, this patchset doesn't introduce much of the functionality enabled by eBPF, it lays the ground work for it. It also introduces the capability to dump

  1   2   3   4   >