Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

Thu, Apr 05, 2018 at 11:06:41PM CEST, d...@cumulusnetworks.com wrote: >On 4/5/18 2:10 PM, David Ahern wrote: >> >> The ASIC here is the kernel tables in a namespace. It does not make >> sense to have 2 devlink instances for a single namespace. > >I put this example controller in netdevsim per a

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

Thu, Apr 05, 2018 at 10:10:29PM CEST, d...@cumulusnetworks.com wrote: >On 4/5/18 11:27 AM, Jiri Pirko wrote: >> Wed, Mar 28, 2018 at 03:22:00AM CEST, d...@cumulusnetworks.com wrote: >>> Add devlink support to netdevsim and use it to implement a simple, >>> profile based resource controller. Only

Re: [PATCH 05/32] fs: introduce new ->get_poll_head and ->poll_mask methods

On Fri, Mar 30, 2018 at 05:07:42PM +0200, Christoph Hellwig wrote: > + get_poll_head: Returns the struct wait_queue_head that poll, select, > + epoll or aio poll should wait on in case this instance only has single > + waitqueue. Can return NULL to indicate polling is not supported, > + or a

Re: [PATCH 1/2] af_key: Use DIV_ROUND_UP() instead of open-coded equivalent

On Wed, Mar 28, 2018 at 09:35:26PM -0400, Kevin Easton wrote: > On Wed, Mar 28, 2018 at 07:59:25AM +0200, Steffen Klassert wrote: > > On Mon, Mar 26, 2018 at 07:39:16AM -0400, Kevin Easton wrote: > > > Several places use (x + 7) / 8 to convert from a number of bits to a > > > number > > > of

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Fri, Apr 06, 2018 at 01:11:56PM +1000, NeilBrown wrote: > > You don't need to handle memory allocation failures at the point where > you insert into the table - adding to a linked list requires no new > memory. You do actually. The r in rhashtable stands for resizable. We cannot completely

Re: [PATCH net-next] netns: filter uevents correctly

Christian Brauner writes: > On Thu, Apr 05, 2018 at 05:26:59PM +0300, Kirill Tkhai wrote: >> On 05.04.2018 17:07, Christian Brauner wrote: >> > On Thu, Apr 05, 2018 at 04:01:03PM +0300, Kirill Tkhai wrote: >> >> On 04.04.2018 22:48, Christian Brauner wrote: >>

Re: KASAN: use-after-free Read in worker_thread (2)

On Sat, Nov 11, 2017 at 07:56:01AM -0800, syzbot wrote: > syzkaller has found reproducer for the following crash on > d9e0e63d9a6f88440eb201e1491fcf730272c706 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw

Re: [PATCH 5/6] rhashtable: support guaranteed successful insertion.

On Thu, Mar 29 2018, Herbert Xu wrote: > On Thu, Mar 29, 2018 at 08:26:21AM +1100, NeilBrown wrote: >> >> I say "astronomically unlikely", you say "probability .. is extremely >> low". I think we are in agreement here. >> >> The point remains that if an error *can* be returned then I have to >>

Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel

On 4/3/18 9:15 PM, Md. Islam wrote: >> Have you looked at what I would consider a more interesting use case of >> packets into a node and delivered to a namespace via veth? >> >>+--+--- >>| Host | container >>|

Re: [PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

From: Jeff Barnhill <0xeff...@gmail.com> Date: Thu, 5 Apr 2018 21:29:47 + > At the end of ip6_forward(), IPSTATS_MIB_OUTFORWDATAGRAMS and > IPSTATS_MIB_OUTOCTETS are incremented immediately before the NF_HOOK call > for NFPROTO_IPV6 / NF_INET_FORWARD. As a result, these counters get >

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

From: Andrew Lunn Date: Thu, 5 Apr 2018 22:40:49 +0200 > Or could it still contain whatever state the last boot of Linux, or > maybe the bootloader, left the PHY in? Right, this is my concern as well.

Re: [PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

From: Mohammed Gamal Date: Thu, 5 Apr 2018 21:09:17 +0200 > Guests running on WS2012 hosts would not shutdown when changing network > interface setting (e.g. Number of channels, MTU ... etc). > > This patch series addresses these shutdown issues we enecountered with WS2012

Re: [PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

From: Haiyang Zhang Date: Thu, 5 Apr 2018 11:42:22 -0700 > From: Haiyang Zhang > > This patch adds the NetVSP v6 message structures, and includes this > version into NetVSC/NetVSP version negotiation process. > > Signed-off-by: Haiyang

Re: [PATCH 08/32] aio: replace kiocb_set_cancel_fn with a cancel_kiocb file operation

On Fri, Mar 30, 2018 at 05:07:45PM +0200, Christoph Hellwig wrote: > The current kiocb_set_cancel_fn implementation assumes the kiocb is > embedded into an aio_kiocb, which is fundamentally unsafe as it might > have been submitted by non-aio callers. Instead add a cancel_kiocb > file operation

Re: [PATCH net] net: mvpp2: Fix parser entry init boundary check

From: Maxime Chevallier Date: Thu, 5 Apr 2018 11:55:48 +0200 > Boundary check in mvpp2_prs_init_from_hw must be done according to the > passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet > initialized at the time of the check. > > Fixes:

Re: [PATCH net] arp: fix arp_filter on l3slave devices

From: David Ahern Date: Thu, 5 Apr 2018 08:40:48 -0600 > On 4/5/18 2:25 AM, Miguel Fadon Perlines wrote: >> arp_filter performs an ip_route_output search for arp source address and >> checks if output device is the same where the arp request was received, >> if it is not, the

Re: [PATCH net] net: dsa: Discard frames from unused ports

From: Andrew Lunn Date: Thu, 5 Apr 2018 01:56:44 +0200 > The Marvell switches under some conditions will pass a frame to the > host with the port being the CPU port. Such frames are invalid, and > should be dropped. Not dropping them can result in a crash when > incrementing the

Re: [PATCH net] netns: filter uevents correctly

From: Christian Brauner Date: Thu, 05 Apr 2018 01:27:16 + > David, is it ok to queue this or would you prefer I resend when net-next > reopens? This definitely needs more discussion, and after the discussion some further clarification in the commit log

[PATCH] make net_gso_ok return false when gso_type is zero(invalid)

Signed-off-by: Wenhua Shi --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index cf44503e..1f26cbcf 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@

Re: [RFC 0/9] bpf: Add buildid check support

On Thu, Apr 05, 2018 at 05:16:36PM +0200, Jiri Olsa wrote: > hi, > eBPF programs loaded for kprobes are allowed to read kernel > internal structures. We check the provided kernel version > to ensure that the program is loaded for the proper kernel. > > The problem is that the version check is

Re: [Cluster-devel] [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Wed, Apr 04 2018, Andreas Grünbacher wrote: > Herbert Xu schrieb am Mi. 4. Apr. 2018 um > 17:51: > >> On Wed, Apr 04, 2018 at 11:46:28AM -0400, Bob Peterson wrote: >> > >> > The patches look good. The big question is whether to add them to this >> > merge window

[no subject]

Hi Netdevhttps://goo.gl/5bDZtk

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On Thu, Apr 05, 2018 at 04:50:03PM +0100, Jiong Wang wrote: > On 03/04/2018 02:08, Alexei Starovoitov wrote: > > Combining subprog pass with do_check is going into opposite direction > > of this long term work. Divide and conquer. Combining more things into > > do_check is the opposite of this

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

2018-04-06 3:59 GMT+09:00 Jiri Olsa : > On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: >> 2018-04-06 0:16 GMT+09:00 Jiri Olsa : >> > There's no need to pass LD* arguments to link-vmlinux.sh, >> > because they are passed as variables. The only

Packet corrupts to guest system system from host kernel 4.16.x

Why, when using the 4.16 kernel on the host system, is there such a strange behavior of virtual machines? What is the problem? He rolled back to 4.9.c - the problem was gone. tcpdump on router: tcpdump: listening on vlan-00110013, link-type EN10MB (Ethernet), capture size 262144 bytes

[PATCH net] net/sched: fix NULL dereference in the error path of tcf_bpf_init()

when tcf_bpf_init_from_ops() fails (e.g. because of program having invalid number of instructions), tcf_bpf_cfg_cleanup() calls bpf_prog_put(NULL) or bpf_prog_destroy(NULL). Unless CONFIG_BPF_SYSCALL is unset, this causes the following error: BUG: unable to handle kernel NULL pointer dereference

Re: Enable and configure storm prevention in a network device

On 04/05/2018 01:20 PM, David Miller wrote: > From: Murali Karicheri > Date: Thu, 5 Apr 2018 16:14:49 -0400 > >> Is there a standard way to implement and configure storm prevention >> in a Linux network device? > > What kind of "storm", an interrupt storm? > I would

Re: [PATCH net] net: dsa: Discard frames from unused ports

On 04/04/2018 07:17 PM, Andrew Lunn wrote: > On Wed, Apr 04, 2018 at 05:49:10PM -0700, Florian Fainelli wrote: >> On 04/04/2018 04:56 PM, Andrew Lunn wrote: >>> The Marvell switches under some conditions will pass a frame to the >>> host with the port being the CPU port. Such frames are invalid,

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

On Thu, 5 Apr 2018 22:51:33 +0200, Jesper Dangaard Brouer wrote: > > What about nfp in terms of XDP > > offload capabilities, should they be included as well or is probing to load > > the program and see if it loads/JITs as we do today just fine (e.g. you'd > > otherwise end up with extra flags on

[PATCH net] net/ipv6: Increment OUTxxx counters after netfilter hook

At the end of ip6_forward(), IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented immediately before the NF_HOOK call for NFPROTO_IPV6 / NF_INET_FORWARD. As a result, these counters get incremented regardless of whether or not the netfilter hook allows the packet to continue

Re: [patch net] devlink: convert occ_get op to separate registration

Thu, Apr 05, 2018 at 10:55:58PM CEST, dsah...@gmail.com wrote: >On 4/5/18 2:13 PM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> This resolves race during initialization where the resources with >> ops are registered before driver and the structures used by occ_get >> op is

[RFC PATCH net-next v5 4/4] netvsc: refactor notifier/event handling code to use the bypass framework

Use the registration/notification framework supported by the generic bypass infrastructure. Signed-off-by: Sridhar Samudrala --- drivers/net/hyperv/Kconfig | 1 + drivers/net/hyperv/netvsc_drv.c | 219 2 files changed,

[RFC PATCH net-next v5 0/4] Enable virtio_net to act as a backup for a passthru device

The main motivation for this patch is to enable cloud service providers to provide an accelerated datapath to virtio-net enabled VMs in a transparent manner with no/minimal guest userspace changes. This also enables hypervisor controlled live migration to be supported with VMs that have direct

[RFC PATCH net-next v5 2/4] net: Introduce generic bypass module

This provides a generic interface for paravirtual drivers to listen for netdev register/unregister/link change events from pci ethernet devices with the same MAC and takeover their datapath. The notifier and event handling code is based on the existing netvsc implementation. A paravirtual driver

[RFC PATCH net-next v5 3/4] virtio_net: Extend virtio to use VF datapath when available

This patch enables virtio_net to switch over to a VF datapath when a VF netdev is present with the same MAC address. It allows live migration of a VM with a direct attached VF without the need to setup a bond/team between a VF and virtio net device in the guest. The hypervisor needs to enable

[RFC PATCH net-next v5 1/4] virtio_net: Introduce VIRTIO_NET_F_BACKUP feature bit

This feature bit can be used by hypervisor to indicate virtio_net device to act as a backup for another device with the same MAC address. VIRTIO_NET_F_BACKUP is defined as bit 62 as it is a device feature bit. Signed-off-by: Sridhar Samudrala ---

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

On 4/5/18 2:10 PM, David Ahern wrote: > > The ASIC here is the kernel tables in a namespace. It does not make > sense to have 2 devlink instances for a single namespace. I put this example controller in netdevsim per a suggestion from Ido. The netdevsim seemed like a good idea given that modules

Re: [patch net] devlink: convert occ_get op to separate registration

On 4/5/18 2:55 PM, David Ahern wrote: > @@ -154,6 +155,12 @@ void *mlxsw_core_driver_priv(struct mlxsw_core > *mlxsw_core) > } > EXPORT_SYMBOL(mlxsw_core_driver_priv); > > +bool mlxsw_core_reload_in_progress(struct mlxsw_core *mlxsw_core) > +{ > + return

Re: [patch net] devlink: convert occ_get op to separate registration

On 4/5/18 2:13 PM, Jiri Pirko wrote: > From: Jiri Pirko > > This resolves race during initialization where the resources with > ops are registered before driver and the structures used by occ_get > op is initialized. So keep occ_get callbacks registered only when > all structs

Re: [iovisor-dev] Best userspace programming API for XDP features query to kernel?

On Thu, 5 Apr 2018 12:37:19 +0200 Daniel Borkmann wrote: > On 04/04/2018 02:28 PM, Jesper Dangaard Brouer via iovisor-dev wrote: > > Hi Suricata people, > > > > When Eric Leblond (and I helped) integrated XDP in Suricata, we ran > > into the issue, that at Suricata

Re: marvell switch

> > Hi Ran > > > > The Marvell driver makes each port act like a normal Linux network > > interface. So if you want to enable a port, do > > > > ip link set lan0 up > > > > Want to add an ip address to a port > > > > ip addr add 10.42.42.42/24 dev lan0 > > > > Want to bridge two ports > > > > ip

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

On Thu, Apr 05, 2018 at 10:30:45PM +0200, Esben Haabendal wrote: > Florian Fainelli writes: > > > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: > >> From: Esben Haabendal > >> > >> Read configration settings, to allow automatic forced

[PATCH v2] net: phy: marvell: Enable interrupt function on LED2 pin

From: Esben Haabendal The LED2[2]/INTn pin on Marvell 88E1318S as well as 88E1510/12/14/18 needs to be configured to be usable as interrupt not only when WOL is enabled, but whenever we rely on interrupts from the PHY. Signed-off-by: Esben Haabendal Cc: Rasmus

Re: [PATCH 1/2] net: phy: Helper function for reading strapped configuration values

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Add a function for use in PHY driver probe functions, reading current >> autoneg, speed and duplex configuration from BMCR register. >> >>

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Read configration settings, to allow automatic forced speed/duplex setup >> by hardware strapping. > > OK but why? What problem is this

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Read configration settings, to allow automatic forced speed/duplex setup >> by hardware strapping. > > OK but why? What problem is this

Re: [PATCH 1/2] net: phy: Helper function for reading strapped configuration values

Florian Fainelli writes: > On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: >> From: Esben Haabendal >> >> Add a function for use in PHY driver probe functions, reading current >> autoneg, speed and duplex configuration from BMCR register. >> >>

Re: Enable and configure storm prevention in a network device

From: Murali Karicheri Date: Thu, 5 Apr 2018 16:14:49 -0400 > Is there a standard way to implement and configure storm prevention > in a Linux network device? What kind of "storm", an interrupt storm?

[patch net] devlink: convert occ_get op to separate registration

From: Jiri Pirko This resolves race during initialization where the resources with ops are registered before driver and the structures used by occ_get op is initialized. So keep occ_get callbacks registered only when all structs are initialized. The example flows, as it is in

Enable and configure storm prevention in a network device

Hello Netdev experts, Is there a standard way to implement and configure storm prevention in a Linux network device? Our NIC firmware has the capability to enable storm prevention which is implemented using a credit based scheme. The configuration is how many number of multicast + broadcast

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

On 4/5/18 11:27 AM, Jiri Pirko wrote: > Wed, Mar 28, 2018 at 03:22:00AM CEST, d...@cumulusnetworks.com wrote: >> Add devlink support to netdevsim and use it to implement a simple, >> profile based resource controller. Only one controller is needed >> per namespace, so the first netdevsim netdevice

Re: [PATCH iproute2] l2tp: no need to export session offsets in JSON output

On Thu, 5 Apr 2018 19:24:17 +0200 Guillaume Nault wrote: > The offset and peer_offset parameters are only printed to avoid > confusing external scripts that may parse "ip l2tp show session" > output. There's no reason to keep them in JSON. > > Signed-off-by: Guillaume

Re: [PATCH net 0/6] net: better validate user provided tunnel names

On 04/05/2018 12:21 PM, David Miller wrote: > From: Eric Dumazet > Date: Thu, 5 Apr 2018 06:39:25 -0700 > >> This series changes dev_valid_name() to not attempt reading >> a possibly too long user-provided device name, then use >> this helper in five different tunnel

Re: [PATCH net 0/6] net: better validate user provided tunnel names

From: Eric Dumazet Date: Thu, 5 Apr 2018 06:39:25 -0700 > This series changes dev_valid_name() to not attempt reading > a possibly too long user-provided device name, then use > this helper in five different tunnel providers. Series applied and queued up for -stable,

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 4/5/2018 3:10 PM, Kalle Valo wrote: Ulf Hansson writes: On 20 March 2018 at 10:55, Kalle Valo wrote: Arend van Spriel writes: If I get it right, you mean something like this: mmc3: mmc@1c12000 { ...

Re: [PATCH net-next v2 2/2] dt: bindings: add new dt entries for brcmfmac

On 5 April 2018 at 15:10, Kalle Valo wrote: > Ulf Hansson writes: > >> On 20 March 2018 at 10:55, Kalle Valo wrote: >>> Arend van Spriel writes: >>> >> If I get it right, you mean something

[PATCH 1/4] hv_netvsc: Use Windows version instead of NVSP version on GPAD teardown

When changing network interface settings, Windows guests older than WS2016 can no longer shutdown. This was addressed by commit 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older versions"), however the issue also occurs on WS2012 guests that share NVSP protocol versions with WS2016

[PATCH 0/4] hv_netvsc: Fix shutdown issues on older Windows hosts

Guests running on WS2012 hosts would not shutdown when changing network interface setting (e.g. Number of channels, MTU ... etc). This patch series addresses these shutdown issues we enecountered with WS2012 hosts. It's essentialy a rework of the series sent in

[PATCH 2/4] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl()

Split each of the functions into two for each of send/recv buffers. This will be needed in order to implement a fine-grained messaging sequence to the host so tht we accommodate the requirements of different Windows versions Fixes: 0ef58b0a05c12 ("hv_netvsc: change GPAD teardown order on older

[PATCH 3/4] hv_netvsc: Ensure correct teardown message sequence order

Prior to commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split") the call sequence in netvsc_device_remove() was as follows (as implemented in netvsc_destroy_buf()): 1- Send NVSP_MSG1_TYPE_REVOKE_RECV_BUF message 2- Teardown receive buffer GPADL 3- Send NVSP_MSG1_TYPE_REVOKE_SEND_BUF

[PATCH 4/4] hv_netvsc: Pass net_device parameter to revoke and teardown functions

The callers to netvsc_revoke_*_buf() and netvsc_teardown_*_gpadl() already have their net_device instances. Pass them as a paramaeter to the function instead of obtaining them from netvsc_device struct everytime Signed-off-by: Mohammed Gamal --- drivers/net/hyperv/netvsc.c |

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

On Fri, Apr 06, 2018 at 12:50:00AM +0900, Masahiro Yamada wrote: > 2018-04-06 0:16 GMT+09:00 Jiri Olsa : > > There's no need to pass LD* arguments to link-vmlinux.sh, > > because they are passed as variables. The only argument > > the link-vmlinux.sh supports is the 'clean'

Re: [PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

On 3/31/2018 9:05 AM, Joe Perches wrote: Remove the local ALLFFMAC extern array and use the new global instead. I stumbled upon this one couple of weeks ago. I moved the definition to flowring.c although I considered for a moment to pick up the task you took here valiantly. Miscellanea:

[PATCH net-next] hv_netvsc: Add NetVSP v6 into version negotiation

From: Haiyang Zhang This patch adds the NetVSP v6 message structures, and includes this version into NetVSC/NetVSP version negotiation process. Signed-off-by: Haiyang Zhang --- drivers/net/hyperv/hyperv_net.h | 33

Re: marvell switch

On Thu, Apr 05, 2018 at 05:26:37PM +, Ran Shalit wrote: > בתאריך יום ה׳, 5 באפר׳ 2018, 19:09, מאת Andrew Lunn ‏: > > > > Is there a wiki which explains switch configuration ? > > > > Nope. The whole idea is that they behave like normal linux > > interfaces. So there is no need

RE: [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters

Hi, "Brown, Aaron F" writes: >> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On >> Behalf Of Vinicius Costa Gomes >> Sent: Thursday, March 29, 2018 2:08 PM >> To: intel-wired-...@lists.osuosl.org >> Cc: netdev@vger.kernel.org; Sanchez-Palencia,

Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink

Wed, Mar 28, 2018 at 03:22:00AM CEST, d...@cumulusnetworks.com wrote: >Add devlink support to netdevsim and use it to implement a simple, >profile based resource controller. Only one controller is needed >per namespace, so the first netdevsim netdevice in a namespace >registers with devlink. If

Re: Kernel bug from adding bpf actions in tc

On Thu, 2018-04-05 at 11:23 -0400, Lucas Bates wrote: > Hi Davide, > > Our overnight tc test runs of net-next revealed a kernel bug on one of > the BPF tests you submitted, d959. The add action completes > successfully, but the bug occurs on the verify when tdc does a get of > the action that

[PATCH iproute2] l2tp: no need to export session offsets in JSON output

The offset and peer_offset parameters are only printed to avoid confusing external scripts that may parse "ip l2tp show session" output. There's no reason to keep them in JSON. Signed-off-by: Guillaume Nault --- ip/ipl2tp.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH iproute2] ip/l2tp: remove offset and peer-offset options

On Wed, Apr 04, 2018 at 04:43:10PM -0700, Stephen Hemminger wrote: > On Tue, 3 Apr 2018 17:39:54 +0200 > Guillaume Nault wrote: > > > Ignore options "peer-offset" and "offset" when creating sessions. Keep > > them when dumping sessions in order to avoid breaking external

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

> > Hi Andrew, > > > > We're waiting for the DPIO driver (which we depend on) to be moved > > out of staging first, it's currently under review: > > https://lkml.org/lkml/2018/3/27/1086 > > That's stalled on my side right now as the merge window is open and I > can't do any new stuff until after

Re: [PATCH net-next] pptp: remove a buggy dst release in pptp_connect()

Hi. [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 30.1120) The bot has tested the following trees: v4.15.15, v4.14.32, v4.9.92, v4.4.126, v4.15.15: Build OK! v4.14.32: Build

Re: [PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

Hi Sergey, On 04/05/2018 11:31 AM, Sergey Matyukevich wrote: Hello Gustavo, In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware

Re: [PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

Hello Gustavo, > In case memory resources for fw were succesfully allocated, release > them before jumping to fw_load_fail. > > Addresses-Coverity-ID: 1466092 ("Resource leak") > Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On 05/04/18 16:50, Jiong Wang wrote: > On 03/04/2018 02:08, Alexei Starovoitov wrote: >> Combining subprog pass with do_check is going into opposite direction >> of this long term work. Divide and conquer. Combining more things into >> do_check is the opposite of this programming principle. > >

[PATCH] ieee802154: mcr20a: Fix memory leak in mcr20a_probe

Free allocated memory for pdata before return. Addresses-Coverity-ID: 1466096 ("Resource leak") Fixes: 8c6ad9cc5157 ("ieee802154: Add NXP MCR20A IEEE 802.15.4 transceiver driver") Signed-off-by: Gustavo A. R. Silva --- drivers/net/ieee802154/mcr20a.c | 9 ++--- 1

Re: [PATCH] net: thunderx: rework mac addresses list to u64 array

On Thu, Apr 05, 2018 at 09:07:49AM -0700, Vadim Lomovtsev wrote: > > > > > + mc_list = kmalloc(sizeof(*mc_list) + > > > + sizeof(u64) * > > > netdev_mc_count(netdev), > > > + GFP_ATOMIC);

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Thu, Apr 05, 2018 at 03:35:30PM +, Ruxandra Ioana Ciocoi Radulescu wrote: > > -Original Message- > > From: Andrew Lunn [mailto:and...@lunn.ch] > > Sent: Thursday, April 5, 2018 6:24 PM > > To: Laurentiu Tudor > > Cc: Stuart Yoder ; Arnd

[PATCH] qtnfmac: pearl: pcie: fix memory leak in qtnf_fw_work_handler

In case memory resources for fw were succesfully allocated, release them before jumping to fw_load_fail. Addresses-Coverity-ID: 1466092 ("Resource leak") Fixes: c3b2f7ca4186 ("qtnfmac: implement asynchronous firmware loading") Signed-off-by: Gustavo A. R. Silva ---

Re: marvell switch

> Is there a wiki which explains switch configuration ? Nope. The whole idea is that they behave like normal linux interfaces. So there is no need to document them. You already know how to use them. > Is it possible to open socket and send/recieve on switch ports (lan0 > for example) ? Sure. It

Re: [PATCH] net: thunderx: rework mac addresses list to u64 array

Hi Christoph, Thank you for your feedback and time. On Thu, Apr 05, 2018 at 08:07:48AM -0700, Christoph Hellwig wrote: > > struct xcast_addr_list { > > - struct list_head list; > > int count; > > + u64 mc[0]; > > Please use the standard C99 syntax here: > >

Re: [PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

2018-04-06 0:16 GMT+09:00 Jiri Olsa : > There's no need to pass LD* arguments to link-vmlinux.sh, > because they are passed as variables. The only argument > the link-vmlinux.sh supports is the 'clean' argument. > > Signed-off-by: Jiri Olsa > --- Wrong. $(LD)

Re: [PATCH 2/2] net: phy: dp83640: Read strapped configuration settings

On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: > From: Esben Haabendal > > Read configration settings, to allow automatic forced speed/duplex setup > by hardware strapping. OK but why? What problem is this solving for you? In general, we do not really want to preserve

Re: [PATCH 1/2] net: phy: Helper function for reading strapped configuration values

On 04/05/2018 04:44 AM, esben.haaben...@gmail.com wrote: > From: Esben Haabendal > > Add a function for use in PHY driver probe functions, reading current > autoneg, speed and duplex configuration from BMCR register. > > Useful for PHY that supports hardware strapped

Re: marvell switch

On Thu, Apr 5, 2018 at 3:22 PM, Andrew Lunn wrote: > On Thu, Apr 05, 2018 at 05:47:24AM +0300, Ran Shalit wrote: >> Hello, >> >> I am trying to use marvell switch in linux, >> Is it that the kernel drivers from marvell switch are used just to >> enable all ports, or do they also

Re: [RFC] ethtool: Support for driver private ioctl's

On 04/05/2018 03:47 AM, Jose Abreu wrote: > Hi All, > > I would like to know your opinion regarding adding support for > driver private ioctl's in ethtool. > > Background: Synopsys Ethernet IP's have a certain number of > features which can be reconfigured at runtime. Giving you two >

Re: [PATCH v2 bpf-next 0/3] bpf/verifier: subprog/func_call simplifications

On 03/04/2018 02:08, Alexei Starovoitov wrote: Combining subprog pass with do_check is going into opposite direction of this long term work. Divide and conquer. Combining more things into do_check is the opposite of this programming principle. Agree. And for the redundant insn traversal issue

RE: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

> -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: Thursday, April 5, 2018 6:24 PM > To: Laurentiu Tudor > Cc: Stuart Yoder ; Arnd Bergmann ; > Ioana Ciornei ; gregkh >

Re: [virtio-dev] Re: [RFC PATCH 1/3] qemu: virtio-bypass should explicitly bind to a passthrough device

On 04/04/2018 10:02, Siwei Liu wrote: >> pci_bus_num is almost always a bug if not done within >> a context of a PCI host, bridge, etc. >> >> In particular this will not DTRT if run before guest assigns bus >> numbers. >> > I was seeking means to reserve a specific pci bus slot from drivers, > and

Re: [PATCH v3 2/4] bus: fsl-mc: add restool userspace support

On Thu, Apr 05, 2018 at 02:43:29PM +, Laurentiu Tudor wrote: > Hi Andrew, > > On 04/05/2018 03:48 PM, Andrew Lunn wrote: > >>> Hi Laurentiu > >>> > >>> So i can use switchdev without it? I can modprobe the switchdev > >>> driver, all the physical interfaces will appear, and i can use ip addr

Kernel bug from adding bpf actions in tc

Hi Davide, Our overnight tc test runs of net-next revealed a kernel bug on one of the BPF tests you submitted, d959. The add action completes successfully, but the bug occurs on the verify when tdc does a get of the action that was just added. Here's the text of the dump: [ 61.973632] BUG:

[RFC 0/9] bpf: Add buildid check support

hi, eBPF programs loaded for kprobes are allowed to read kernel internal structures. We check the provided kernel version to ensure that the program is loaded for the proper kernel. The problem is that the version check is not enough, because it only follows the version setup from kernel's

[PATCH 1/9] perf tools: Make read_build_id function public

And renaming it into parse_notes_buildid to be more precise and usable in following patches. Link: http://lkml.kernel.org/n/tip-v1mz76rkdxfnbfz2v05fu...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/symbol-minimal.c | 50 ++--

[PATCH 2/9] perf tools: Add fetch_kernel_buildid function

Adding fetch_kernel_buildid helper function to retrieve build id from running kernel. It will be used in following patches. Link: http://lkml.kernel.org/n/tip-at98orsncas8v2ito61u3...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/util.c | 18 ++

[PATCH 4/9] kbuild: Add filechk2 function

Adding filechk2 function that has the same semantics as filechk, but it takes the target file from the 2nd argument instead of from the '$@' as in the filechk function. This function is needed when we can't have separate target for the file, like in the following patch. Signed-off-by: Jiri Olsa

[PATCH 3/9] kbuild: Do not pass arguments to link-vmlinux.sh

There's no need to pass LD* arguments to link-vmlinux.sh, because they are passed as variables. The only argument the link-vmlinux.sh supports is the 'clean' argument. Signed-off-by: Jiri Olsa --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/9] bpf: Add CONFIG_BUILDID_H option

Adding CONFIG_BUILDID_H option that forces build to generate file with GNU build id value: include/linux/buildid.h It contains following macros: #define LINUX_BUILDID_DATA "\x6c\x41\x0f\xea\xa9\x5d ... #define LINUX_BUILDID_SIZE 20 Those macros will be used in following patches to

[PATCH 7/9] libbpf: Synchronize uapi bpf.h header

Synchronize include/uapi/linux/bpf.h with tools version. Link: http://lkml.kernel.org/n/tip-gaja0nnet6oku657642nx...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/include/uapi/linux/bpf.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h

[PATCH 6/9] bpf: Add CONFIG_BPF_BUILDID_CHECK option

Adding CONFIG_BPF_BUILDID_CHECK option that forces kernel to check on provided build id when loading eBPF program. If the build id does not match the one in kernel the program fails to load. Adding new field into struct bpf_attr. The kern_buildid points to the user memory that contains the

[PATCH 8/9] libbpf: Add support to attach buildid to program load

Adding support to retrieve buildid from elf's "buildid" section and passing it through to the load_program function to kernel bpf syscall. Fixing perf use of the bpf_load_program function and linking in the vsprintf.o into bpftool to have the scnprintf function in. Link:

  1   2   >