[PATCHv2 net-next] erspan: set bso bit based on mirrored packet's len

2018-05-18 Thread William Tu
Before the patch, the erspan BSO bit (Bad/Short/Oversized) is not handled. BSO has 4 possible values: 00 --> Good frame with no error, or unknown integrity 11 --> Payload is a Bad Frame with CRC or Alignment Error 01 --> Payload is a Short Frame 10 --> Payload is an Oversized Frame Based

[PATCH net] net: ip6_gre: fix tunnel metadata device sharing.

2018-05-18 Thread William Tu
Currently ip6gre and ip6erspan share single metadata mode device, using 'collect_md_tun'. Thus, when doing: ip link add dev ip6gre11 type ip6gretap external ip link add dev ip6erspan12 type ip6erspan external RTNETLINK answers: File exists simply fails due to the 2nd tries to create the

Re: [patch net-next 0/5] devlink: introduce port flavours and common phys_port_name generation

2018-05-18 Thread Florian Fainelli
On 05/18/2018 12:28 AM, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which is which > 2) The

Re: [patch net-next RFC 04/12] dsa: set devlink port attrs for dsa ports

2018-05-18 Thread Florian Fainelli
On 05/18/2018 06:45 AM, Andrew Lunn wrote: >> What benefit does it have to register unused ports? What is a usecase >> for them. Like Florian, I also think they should not be registered. > > Hi Jiri > > They physically exist, so we are accurately describing the hardware by > registering them.

Re: [PATCH] net: sched: don't disable bh when accessing action idr

2018-05-18 Thread Cong Wang
On Fri, May 18, 2018 at 8:45 AM, Vlad Buslov wrote: > Underlying implementation of action map has changed and doesn't require > disabling bh anymore. Replace all action idr spinlock usage with regular > calls that do not disable bh. Please explain explicitly why it is not

Re: [RFC v4 3/5] virtio_ring: add packed ring support

2018-05-18 Thread Tiwei Bie
On Sat, May 19, 2018 at 09:12:30AM +0800, Jason Wang wrote: > On 2018年05月18日 22:33, Tiwei Bie wrote: > > On Fri, May 18, 2018 at 09:17:05PM +0800, Jason Wang wrote: > > > On 2018年05月18日 19:29, Tiwei Bie wrote: > > > > On Thu, May 17, 2018 at 08:01:52PM +0800, Jason Wang wrote: > > > > > On

[PATCH bpf-next 2/5] bpf: Sync bpf.h to tools/

2018-05-18 Thread Andrey Ignatov
Sync new `BPF_CGROUP_UDP4_SENDMSG` and `BPF_CGROUP_UDP6_SENDMSG` attach types to tools/. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov --- tools/include/uapi/linux/bpf.h | 8 1 file changed, 8 insertions(+) diff --git

[PATCH bpf-next 5/5] selftests/bpf: Selftest for sys_sendmsg hooks

2018-05-18 Thread Andrey Ignatov
Add selftest for BPF_CGROUP_UDP4_SENDMSG and BPF_CGROUP_UDP6_SENDMSG attach types. Try to sendmsg(2) to specific IP:port and test that: * source IP is overridden as expected. * remote IP:port pair is overridden as expected; Both UDPv4 and UDPv6 are tested. Output: # test_sock_addr.sh

[PATCH bpf-next 3/5] libbpf: Support guessing sendmsg{4,6} progs

2018-05-18 Thread Andrey Ignatov
libbpf can guess prog type and expected attach type based on section name. Add hints for "cgroup/sendmsg4" and "cgroup/sendmsg6" section names. Signed-off-by: Andrey Ignatov Acked-by: Alexei Starovoitov --- tools/lib/bpf/libbpf.c | 2 ++ 1 file changed, 2

[PATCH bpf-next 0/5] bpf: Hooks for sys_sendmsg

2018-05-18 Thread Andrey Ignatov
This path set adds BPF hooks for sys_sendmsg similar to existing hooks for sys_bind and sys_connect. Hooks allow to override source IP (including the case when it's set via cmsg(3)) and destination IP:port for unconnected UDP (slow path). TCP and connected UDP (fast path) are not affected. This

[PATCH bpf-next 1/5] bpf: Hooks for sys_sendmsg

2018-05-18 Thread Andrey Ignatov
In addition to already existing BPF hooks for sys_bind and sys_connect, the patch provides new hooks for sys_sendmsg. It leverages existing BPF program type `BPF_PROG_TYPE_CGROUP_SOCK_ADDR` that provides access to socket itlself (properties like family, type, protocol) and user-passed `struct

[PATCH bpf-next 4/5] selftests/bpf: Prepare test_sock_addr for extension

2018-05-18 Thread Andrey Ignatov
test_sock_addr was not easy to extend since it was focused on sys_bind and sys_connect quite a bit. Reorganized it so that it'll be easier to cover new test-cases for `BPF_PROG_TYPE_CGROUP_SOCK_ADDR`: - decouple test-cases so that only one BPF prog is tested at a time; - check programmatically

Re: [RFC v4 3/5] virtio_ring: add packed ring support

2018-05-18 Thread Jason Wang
On 2018年05月18日 22:33, Tiwei Bie wrote: On Fri, May 18, 2018 at 09:17:05PM +0800, Jason Wang wrote: On 2018年05月18日 19:29, Tiwei Bie wrote: On Thu, May 17, 2018 at 08:01:52PM +0800, Jason Wang wrote: On 2018年05月16日 22:33, Tiwei Bie wrote: On Wed, May 16, 2018 at 10:05:44PM +0800, Jason Wang

Re: [PATCH net] tuntap: raise EPOLLOUT on device up

2018-05-18 Thread Jason Wang
On 2018年05月18日 22:46, Michael S. Tsirkin wrote: On Fri, May 18, 2018 at 10:11:54PM +0800, Jason Wang wrote: On 2018年05月18日 22:06, Michael S. Tsirkin wrote: On Fri, May 18, 2018 at 10:00:31PM +0800, Jason Wang wrote: On 2018年05月18日 21:26, Jason Wang wrote: On 2018年05月18日 21:13, Michael S.

Re: [PATCH 1/2] bpf: sockmap, double free in __sock_map_ctx_update_elem()

2018-05-18 Thread Gustavo A. R. Silva
Hi Dan, On 05/18/2018 09:39 AM, Dan Carpenter wrote: On Fri, May 18, 2018 at 10:27:18AM +0200, Daniel Borkmann wrote: Thanks for the two fixes, appreciate it! There were two similar ones that fix the same issues which were already applied yesterday to bpf-next:

[PATCH bpf-next 3/7] bpf: btf: Check array->index_type

2018-05-18 Thread Martin KaFai Lau
Instead of ingoring the array->index_type field. Enforce that it must be an unsigned BTF_KIND_INT. Signed-off-by: Martin KaFai Lau --- kernel/bpf/btf.c | 83 1 file changed, 59 insertions(+), 24 deletions(-) diff --git

[PATCH bpf-next 7/7] bpf: btf: Add tests for the btf uapi changes

2018-05-18 Thread Martin KaFai Lau
This patch does the followings: 1. Modify libbpf and test_btf to reflect the uapi changes in btf 2. Add test for the btf_header changes 3. Add tests for array->index_type 4. Add err_str check to the tests 5. Fix a 4 bytes hole in "struct test #1" by swapping "m" and "n" Signed-off-by: Martin

[PATCH bpf-next 1/7] bpf: Expose check_uarg_tail_zero()

2018-05-18 Thread Martin KaFai Lau
This patch exposes check_uarg_tail_zero() which will be reused by a later BTF patch. Its name is changed to bpf_check_uarg_tail_zero(). Signed-off-by: Martin KaFai Lau --- include/linux/bpf.h | 2 ++ kernel/bpf/syscall.c | 14 +++--- 2 files changed, 9 insertions(+), 7

[PATCH bpf-next 5/7] bpf: btf: Rename btf_key_id and btf_value_id in bpf_map_info

2018-05-18 Thread Martin KaFai Lau
In "struct bpf_map_info", the name "btf_id", "btf_key_id" and "btf_value_id" could cause confusion because the "id" of "btf_id" means the BPF obj id given to the BTF object while "btf_key_id" and "btf_value_id" means the BTF type id within that BTF object. To make it clear, btf_key_id and

[PATCH bpf-next 4/7] bpf: btf: Remove unused bits from uapi/linux/btf.h

2018-05-18 Thread Martin KaFai Lau
This patch does the followings: 1. Limit BTF_MAX_TYPES and BTF_MAX_NAME_OFFSET to 64k. We can raise it later. 2. Remove the BTF_TYPE_PARENT and BTF_STR_TBL_ELF_ID. They are currently encoded at the highest bit of a u32. It is because the current use case does not require supporting

[PATCH bpf-next 0/7] BTF uapi cleanup

2018-05-18 Thread Martin KaFai Lau
This patch set makes some changes to cleanup the unused bits in BTF uapi. It also makes the btf_header extensible. Please see individual patches for details. Martin KaFai Lau (7): bpf: Expose check_uarg_tail_zero() bpf: btf: Change how section is supported in btf_header bpf: btf: Check

[PATCH bpf-next 2/7] bpf: btf: Change how section is supported in btf_header

2018-05-18 Thread Martin KaFai Lau
There are currently unused section descriptions in the btf_header. Those sections are here to support future BTF use cases. For example, the func section (func_off) is to support function signature (e.g. the BPF prog function signature). Instead of spelling out all potential sections up-front

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-18 Thread David Ahern
On 5/18/18 4:08 PM, Stephen Hemminger wrote: > > What about just pushing the lookup down to the leaf functions that need it? > That should work as well. You want to re-send a formal patch?

general protection fault in smc_ioctl

2018-05-18 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1f7455c3912d tcp: tcp_rack_reo_wnd() can be static git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=171a133780 kernel config: https://syzkaller.appspot.com/x/.config?x=b632d8e2c2ab2c1 dashboard

Re: [PATCH iproute2] Allow to configure /var/run/netns directory

2018-05-18 Thread Pavel Maltsev
Thanks, Stephen, I've uploaded new patch as you suggested by putting these variables in the makefile rather than configure script. On Fri, May 18, 2018 at 2:53 PM Stephen Hemminger wrote: > > On Tue, 15 May 2018 14:49:46 -0700 > Pavel Maltsev

[PATCH iproute2] Allow to configure /var/run/netns directory

2018-05-18 Thread Pavel Maltsev
Currently NETNS_RUN_DIR is hardcoded and refers to /var/run/netns. However, some systems (e.g. Android) doesn't have /var which results in error attempts to create network namespaces on these systems. This change makes NETNS_RUN_DIR configurable at build time by allowing to pass environment

Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST

2018-05-18 Thread kbuild test robot
Hi Florian, I love your patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005 config: sparc64-allyesconfig (attached as .config)

[PATCH v2] selftests: net: reuseport_bpf_numa: don't fail if no numa support

2018-05-18 Thread Anders Roxell
The reuseport_bpf_numa test case fails there's no numa support. The test shouldn't fail if there's no support it should be skipped. Fixes: 3c2c3c16aaf6 ("reuseport, bpf: add test case for bpf_get_numa_node_id") Signed-off-by: Anders Roxell ---

Re: [PATCH bpf-next v2 7/7] tools/bpftool: add perf subcommand

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 1:51 PM, Jakub Kicinski wrote: > On Thu, 17 May 2018 22:03:10 -0700, Yonghong Song wrote: >> The new command "bpftool perf [show | list]" will traverse >> all processes under /proc, and if any fd is associated >> with a perf event, it will

Re: [PATCH iproute2] ip link: Do not call ll_name_to_index when creating a new link

2018-05-18 Thread Stephen Hemminger
On Thu, 17 May 2018 18:17:12 -0600 David Ahern wrote: > On 5/17/18 4:36 PM, Stephen Hemminger wrote: > > On Thu, 17 May 2018 16:22:37 -0600 > > dsah...@kernel.org wrote: > > > >> From: David Ahern > >> > >> Using iproute2 to create a bridge and add 4094

Re: [PATCH net-next v2 1/3] net: ethernet: ti: Allow most drivers with COMPILE_TEST

2018-05-18 Thread kbuild test robot
Hi Florian, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Florian-Fainelli/net-ethernet-ti-Allow-most-drivers-with-COMPILE_TEST/20180519-043005 config: ia64-allmodconfig (attached as .config)

Re: [PATCH iproute2] Allow to configure /var/run/netns directory

2018-05-18 Thread Stephen Hemminger
On Tue, 15 May 2018 14:49:46 -0700 Pavel Maltsev wrote: > Currently NETNS_RUN_DIR is hardcoded and refers to /var/run/netns. > However, some systems (e.g. Android) doesn't have /var > which results in error attempts to create network namespaces on these > systems. This change

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

2018-05-18 Thread Daniel Mack
Hi Robert, Thanks for this series. On Monday, April 02, 2018 04:26 PM, Robert Jarzmik wrote: From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and

[PATCH v2] isdn: eicon: fix a missing-check bug

2018-05-18 Thread Wenwen Wang
In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions

[RFC PATCH 1/6] net: ethernet: ti: cpsw: use cpdma channels in backward order for txq

2018-05-18 Thread Ivan Khoronzhuk
The cpdma channel highest priority is from hi to lo number. The driver has limited number of descriptors that are shared between number of cpdma channels. Number of queues can be tuned with ethtool, that allows to not spend descriptors on not needed cpdma channels. In AVB usually only 2 tx queues

[RFC PATCH 4/6] net: ethernet: ti: cpsw: add CBS Qdisc offload

2018-05-18 Thread Ivan Khoronzhuk
The cpsw has up to 4 FIFOs per port and upper 3 FIFOs can feed rate limited queue with shaping. In order to set and enable shaping for those 3 FIFOs queues the network device with CBS qdisc attached is needed. The CBS configuration is added for dual-emac/single port mode only, but potentially can

[RFC PATCH 0/6] net: ethernet: ti: cpsw: add MQPRIO and CBS Qdisc offload

2018-05-18 Thread Ivan Khoronzhuk
This series adds MQPRIO and CBS Qdisc offload for TI cpsw driver. It potentially can be used in audio video bridging (AVB) and time sensitive networking (TSN). Patchset was tested on AM572x EVM and BBB boards. Last patch from this series adds detailed description of configuration with examples.

[RFC PATCH 3/6] net: ethernet: ti: cpsw: add MQPRIO Qdisc offload

2018-05-18 Thread Ivan Khoronzhuk
That's possible to offload vlan to tc priority mapping with assumption sk_prio == L2 prio. Example: $ ethtool -L eth0 rx 1 tx 4 $ qdisc replace dev eth0 handle 100: parent root mqprio num_tc 3 \ map 2 2 1 0 2 2 2 2 2 2 2 2 2 2 2 2 queues 1@0 1@1 2@2 hw 1 $ tc -g class show dev eth0

Re: [patch net-next 0/5] devlink: introduce port flavours and common phys_port_name generation

2018-05-18 Thread Jakub Kicinski
On Fri, 18 May 2018 09:28:59 +0200, Jiri Pirko wrote: > From: Jiri Pirko > > This patchset resolves 2 issues we have right now: > 1) There are many netdevices / ports in the system, for port, pf, vf >represenatation but the user has no way to see which is which > 2) The

[RFC PATCH 6/6] Documentation: networking: cpsw: add MQPRIO & CBS offload examples

2018-05-18 Thread Ivan Khoronzhuk
This document describes MQPRIO and CBS Qdisc offload configuration for cpsw driver based on examples. It potentially can be used in audio video bridging (AVB) and time sensitive networking (TSN). Signed-off-by: Ivan Khoronzhuk --- Documentation/networking/cpsw.txt |

[RFC PATCH 5/6] net: ethernet: ti: cpsw: restore shaper configuration while down/up

2018-05-18 Thread Ivan Khoronzhuk
Need to restore shapers configuration after interface was down/up. This is needed as appropriate configuration is still replicated in kernel settings. This only shapers context restore, so vlan configuration should be restored by user if needed, especially for devices with one port where vlan

[RFC PATCH 2/6] net: ethernet: ti: cpdma: fit rated channels in backward order

2018-05-18 Thread Ivan Khoronzhuk
According to TRM tx rated channels should be in 7..0 order, so correct it. Signed-off-by: Ivan Khoronzhuk --- drivers/net/ethernet/ti/davinci_cpdma.c | 31 - 1 file changed, 15 insertions(+), 16 deletions(-) diff --git

Re: [bpf-next PATCH v2 0/2] SK_MSG programs: read sock fields

2018-05-18 Thread Daniel Borkmann
On 05/17/2018 11:16 PM, John Fastabend wrote: > In this series we add the ability for sk msg programs to read basic > sock information about the sock they are attached to. The second > patch adds the tests to the selftest test_verifier. > > One obseration that I had from writing this seriess is

Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 1:17 PM, Y Song wrote: > On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: >> This is simple test over rc-loopback. >> >> Signed-off-by: Sean Young > > Acked-by: Yonghong Song Just one minor thing. You

Re: [PATCH bpf-next v2 7/7] tools/bpftool: add perf subcommand

2018-05-18 Thread Jakub Kicinski
On Thu, 17 May 2018 22:03:10 -0700, Yonghong Song wrote: > The new command "bpftool perf [show | list]" will traverse > all processes under /proc, and if any fd is associated > with a perf event, it will print out related perf event > information. Documentation is also added. Thanks for the

Re: cascaded switch

2018-05-18 Thread Andrew Lunn
> So, it is used so that the 2 switch will behave as if it is one big switch. Yes. This particularly important with offloading. When your offload a bridge, you don't need to care which switch the ports or on. If traffic needs to go from one switch to the other, it will. If you modelled it as two

Re: [bpf-next V4 PATCH 7/8] xdp/trace: extend tracepoint in devmap with an err

2018-05-18 Thread Jesper Dangaard Brouer
On Fri, 18 May 2018 15:35:07 +0200 Jesper Dangaard Brouer wrote: > Extending tracepoint xdp:xdp_devmap_xmit in devmap with an err code > allow people to easier identify the reason behind the ndo_xdp_xmit > call to a given driver is failing. Signed-off-by: Jesper Dangaard

Re: [bpf-next V4 PATCH 8/8] samples/bpf: xdp_monitor use err code from tracepoint xdp:xdp_devmap_xmit

2018-05-18 Thread Jesper Dangaard Brouer
On Fri, 18 May 2018 15:35:12 +0200 Jesper Dangaard Brouer wrote: > Update xdp_monitor to use the recently added err code introduced > in tracepoint xdp:xdp_devmap_xmit, to show if the drop count is > caused by some driver general delivery problem. Other kind of drops > will

Re: [bpf-next V4 PATCH 5/8] xdp: introduce xdp_return_frame_rx_napi

2018-05-18 Thread Jesper Dangaard Brouer
On Fri, 18 May 2018 15:34:57 +0200 Jesper Dangaard Brouer wrote: > When sending an xdp_frame through xdp_do_redirect call, then error > cases can happen where the xdp_frame needs to be dropped, and > returning an -errno code isn't sufficient/possible any-longer > (e.g. for

Re: cascaded switch

2018-05-18 Thread Ran Shalit
On Fri, May 18, 2018 at 11:29 PM, Andrew Lunn wrote: >> Hi, >> >> I mean the same terminology used in marvell's switch.(I don't think >> there is more than one terminology for this, please correct me if >> wrong). >> Anyway, I can see examples how it is done, but I don't

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-18 Thread Saeed Mahameed
On Fri, 2018-05-18 at 11:21 -0600, Jason Gunthorpe wrote: > On Fri, May 18, 2018 at 01:03:51PM -0400, David Miller wrote: > > From: Saeed Mahameed > > Date: Thu, 17 May 2018 18:22:43 -0700 > > > > > Below you can find two pull requests, > > > > > > 1. mlx5 core updates to

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-18 Thread Saeed Mahameed
On Fri, 2018-05-18 at 13:03 -0400, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 17 May 2018 18:22:43 -0700 > > > Below you can find two pull requests, > > > > 1. mlx5 core updates to be shared for both netdev and RDMA, > > (patches 1..9) > > which is based on

Re: [PATCH] selftests: bpf: config: enable NET_SCH_INGRESS for xdp_meta.sh

2018-05-18 Thread Daniel Borkmann
On 05/18/2018 08:23 PM, Anders Roxell wrote: > When running bpf's selftest test_xdp_meta.sh it fails: > ./test_xdp_meta.sh > Error: Specified qdisc not found. > selftests: test_xdp_meta [FAILED] > > Need to enable CONFIG_NET_SCH_INGRESS and CONFIG_NET_CLS_ACT to get the > test to pass. > >

Re: [PATCH bpf-next 0/3] nfp: bpf: complete shift supports on NFP JIT

2018-05-18 Thread Daniel Borkmann
On 05/18/2018 09:12 PM, Jakub Kicinski wrote: > Jiong says: > > NFP eBPF JIT is missing logic indirect shifts (both left and right) and > arithmetic right shift (both indirect shift and shift by constant). > > This patch adds support for them. > > For indirect shifts, shift amount is not

Re: WARNING in __static_key_slow_dec

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 4:03 AM, DaeRyong Jeong wrote: > We report the crash: WARNING in __static_key_slow_dec > > This crash has been found in v4.8 using RaceFuzzer (a modified > version of Syzkaller), which we describe more at the end of this > report. > Even though v4.8

Re: cascaded switch

2018-05-18 Thread Andrew Lunn
> Hi, > > I mean the same terminology used in marvell's switch.(I don't think > there is more than one terminology for this, please correct me if > wrong). > Anyway, I can see examples how it is done, but I don't understand the > benefit of this constellation, and why device tree needs to be >

Re: [PATCH bpf-next v6 5/6] ipv6: sr: Add seg6local action End.BPF

2018-05-18 Thread Daniel Borkmann
On 05/17/2018 04:28 PM, Mathieu Xhonneux wrote: > This patch adds the End.BPF action to the LWT seg6local infrastructure. > This action works like any other seg6local End action, meaning that an IPv6 > header with SRH is needed, whose DA has to be equal to the SID of the > action. It will also

Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: > This is simple test over rc-loopback. > > Signed-off-by: Sean Young Acked-by: Yonghong Song > --- > tools/bpf/bpftool/prog.c | 1 + > tools/include/uapi/linux/bpf.h

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: > Add support for BPF_PROG_LIRC_MODE2. This type of BPF program can call > rc_keydown() to reported decoded IR scancodes, or rc_repeat() to report > that the last key should be repeated. > > The bpf program can be attached to using

Re: cascaded switch

2018-05-18 Thread Ran Shalit
On Fri, May 18, 2018 at 10:13 PM, Andrew Lunn wrote: > On Fri, May 18, 2018 at 09:35:38PM +0300, Ran Shalit wrote: >> Hello, >> >> I am trying to understand the concept of cascaded switch. >> I haven't find much information on this topic. >> >> Can anyone please explain the

Re: [PATCH v4 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: > This makes is it possible for bpf prog detach to return -ENOENT. > > Signed-off-by: Sean Young Acked-by: Yonghong Song

Re: [PATCH bpf v2 5/6] tools: bpftool: resolve calls without using imm field

2018-05-18 Thread Jakub Kicinski
On Fri, 18 May 2018 18:20:38 +0530, Sandipan Das wrote: > Currently, we resolve the callee's address for a JITed function > call by using the imm field of the call instruction as an offset > from __bpf_call_base. If bpf_jit_kallsyms is enabled, we further > use this address to get the callee's

pull request: bluetooth-next 2018-05-18

2018-05-18 Thread Johan Hedberg
Hi Dave, Here's the first bluetooth-next pull request for the 4.18 kernel: - Refactoring of the btbcm driver - New USB IDs for QCA_ROME and LiteOn controllers - Buffer overflow fix if the controller sends invalid advertising data length - Various cleanups & fixes for Qualcomm controllers

Re: [PATCH] isdn: eicon: fix a missing-check bug

2018-05-18 Thread Wenwen Wang
Thanks for your suggestion, David! I will revise the patch and resubmit it. Wenwen On Fri, May 11, 2018 at 2:50 PM, David Miller wrote: > From: Wenwen Wang > Date: Sat, 5 May 2018 14:32:46 -0500 > >> To avoid such issues, this patch adds a check after

Re: cascaded switch

2018-05-18 Thread Andrew Lunn
On Fri, May 18, 2018 at 09:35:38PM +0300, Ran Shalit wrote: > Hello, > > I am trying to understand the concept of cascaded switch. > I haven't find much information on this topic. > > Can anyone please explain the general concept, when is it used, and > why does the device tree need to know

[PATCH bpf-next 3/3] nfp: bpf: support arithmetic indirect right shift (BPF_ARSH | BPF_X)

2018-05-18 Thread Jakub Kicinski
From: Jiong Wang Code logic is similar with arithmetic right shift by constant, and NFP get indirect shift amount through source A operand of PREV_ALU. It is possible to fall back to logic right shift if the MSB is known to be zero from range info, however there is no

[PATCH bpf-next 1/3] nfp: bpf: support logic indirect shifts (BPF_[L|R]SH | BPF_X)

2018-05-18 Thread Jakub Kicinski
From: Jiong Wang For indirect shifts, shift amount is not specified as constant, NFP needs to get the shift amount through the low 5 bits of source A operand in PREV_ALU, therefore extra instructions are needed compared with shifts by constants. Because NFP is 32-bit,

Re: [PATCH v2 1/1] sh_eth: add RGMII support

2018-05-18 Thread Andrew Lunn
On Fri, May 18, 2018 at 09:30:18PM +0300, Sergei Shtylyov wrote: > The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII > PHY interface mode as a new value for the RMII_MII register. > > Based on the original (and large) patch by Vladimir Barinov. > > Signed-off-by:

[PATCH bpf-next 2/3] nfp: bpf: support arithmetic right shift by constant (BPF_ARSH | BPF_K)

2018-05-18 Thread Jakub Kicinski
From: Jiong Wang Code logic is similar with logic right shift except we also need to set PREV_ALU result properly, the MSB of which is the bit that will be replicated to fill in all the vacant positions. Signed-off-by: Jiong Wang Reviewed-by:

[PATCH bpf-next 0/3] nfp: bpf: complete shift supports on NFP JIT

2018-05-18 Thread Jakub Kicinski
Jiong says: NFP eBPF JIT is missing logic indirect shifts (both left and right) and arithmetic right shift (both indirect shift and shift by constant). This patch adds support for them. For indirect shifts, shift amount is not specified as constant, NFP needs to get the shift amount through the

[PATCH RFC net-next 1/1] tcp: close socket without reset on incoming data

2018-05-18 Thread Debabrata Banerjee
When TCP_CLOSE_NORST is set before a close(), offload sinking of unwanted data to the kernel with low resource usage, with a timeout of TCP_LINGER2. The socket will transition to FIN_WAIT1 and then FIN_WAIT2 where it will ack data until either the timeout is hit, or a RST or FIN is received.

[PATCH RFC net-next 0/1] tcp: close socket without reset on incoming data

2018-05-18 Thread Debabrata Banerjee
There is a basic problem with TCP sockets, where sending and closing of data is unreliable. One good example of this is a web server that wants to send an error back on a HTTP POST and close the socket, however assuming the POST was of any significant size what really happens is that the browser

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn >> wrote: >>> On Fri, May

[net-next] Revert "ixgbe: release lock for the duration of ixgbe_suspend_close()"

2018-05-18 Thread Jeff Kirsher
This reverts commit 6710f970d9979d8f03f6e292bb729b2ee1526d0e. Gotta love when developers have offline discussions, thinking everyone is reading their responses/dialog. The change had the potential for a number of race conditions on shutdown, which is why we are reverting the change.

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: >>> From: Eric Dumazet

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: >> From: Eric Dumazet >> Date: Fri, 18 May 2018 08:30:43 -0700 >> >>> We probably need to revert Willem

cascaded switch

2018-05-18 Thread Ran Shalit
Hello, I am trying to understand the concept of cascaded switch. I haven't find much information on this topic. Can anyone please explain the general concept, when is it used, and why does the device tree need to know about cascaded switch ? Thank you, ranran

[PATCH v2 3/3] sh_eth: add R8A77980 support

2018-05-18 Thread Sergei Shtylyov
Finally, add support for the DT probing of the R-Car V3H (AKA R8A77980) -- it's the only R-Car gen3 SoC having the GEther controller -- others have only EtherAVB... Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov

[PATCH v2 2/3] sh_eth: add EDMR.NBST support

2018-05-18 Thread Sergei Shtylyov
The R-Car V3H (AKA R8A77980) GEther controller adds the DMA burst mode bit (NBST) in EDMR and the manual tells to always set it before doing any DMA. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by:

[PATCH v2 1/1] sh_eth: add RGMII support

2018-05-18 Thread Sergei Shtylyov
The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII PHY interface mode as a new value for the RMII_MII register. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov Signed-off-by: Sergei

[PATCH v2 0/3] Add Renesas R8A77980 GEther support

2018-05-18 Thread Sergei Shtylyov
Hello! Here's a set of 3 patches against DaveM's 'net-next.git' repo. They (gradually) add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new register bits/values introduced with this chip, and ending with adding a new 'struct sh_eth_cpu_data' instance connected to the new

[PATCH] selftests: bpf: config: enable NET_SCH_INGRESS for xdp_meta.sh

2018-05-18 Thread Anders Roxell
When running bpf's selftest test_xdp_meta.sh it fails: ./test_xdp_meta.sh Error: Specified qdisc not found. selftests: test_xdp_meta [FAILED] Need to enable CONFIG_NET_SCH_INGRESS and CONFIG_NET_CLS_ACT to get the test to pass. Fixes: 22c8852624fc ("bpf: improve selftests and add tests for meta

Re: [PATCH v2 net-next] net: stmmac: Populate missing callbacks in HWIF initialization

2018-05-18 Thread David Miller
From: Jose Abreu Date: Fri, 18 May 2018 16:54:38 +0100 > Some HW specific setups, like sun8i, do not populate all the necessary > callbacks, which is what HWIF helpers were expecting. > > Fix this by always trying to get the generic helpers and populate them > if they

Re: [PATCH net-next] cxgb4: collect SGE PF/VF queue map

2018-05-18 Thread David Miller
From: Rahul Lakkireddy Date: Fri, 18 May 2018 19:12:53 +0530 > For T6, collect info on queue mapping to corresponding PF/VF in SGE. > > Signed-off-by: Rahul Lakkireddy > Signed-off-by: Ganesh Goudar Applied.

Re: [PATCH net] cxgb4: fix offset in collecting TX rate limit info

2018-05-18 Thread David Miller
From: Rahul Lakkireddy Date: Fri, 18 May 2018 19:13:37 +0530 > Correct the indirect register offsets in collecting TX rate limit info > in UP CIM logs. > > Also, T5 doesn't support these indirect register offsets, so remove > them from collection logic. > > Fixes:

Re: [PATCH net] net: sched: red: avoid hashing NULL child

2018-05-18 Thread David Miller
From: Paolo Abeni Date: Fri, 18 May 2018 14:51:44 +0200 > Hangbin reported an Oops triggered by the syzkaller qdisc rules: ... > When a red qdisc is updated with a 0 limit, the child qdisc is left > unmodified, no additional scheduler is created in red_change(), > the 'child'

Re: [PATCH 1/4] arcnet: com20020: Add com20020 io mapped version

2018-05-18 Thread David Miller
From: Andrea Greco Date: Fri, 18 May 2018 14:18:41 +0200 > In com20020.c found this: > /* FIXME: do this some other way! */ > if (!dev->dev_addr[0]) > dev->dev_addr[0] = arcnet_inb(ioaddr, 8); > > NODE-ID, must be univoque, for all arcnet network. > My previews

Re: [PATCH] net: mvpp2: typo and cosmetic fixes

2018-05-18 Thread David Miller
From: Antoine Tenart Date: Fri, 18 May 2018 14:34:51 +0200 > This patch on the Marvell PPv2 driver is only cosmetic. Two typos are > removed as well as other cosmetic fixes, such as extra new lines or tabs > vs spaces. > > Suggested-by: Stefan Chulski

Re: [PATCH net] sock_diag: fix use-after-free read in __sk_free

2018-05-18 Thread David Miller
From: Eric Dumazet Date: Fri, 18 May 2018 04:47:55 -0700 > We must not call sock_diag_has_destroy_listeners(sk) on a socket > that has no reference on net structure. ... > Fixes: b922622ec6ef ("sock_diag: don't broadcast kernel sockets") > Signed-off-by: Eric Dumazet

Re: [PATCH] hippi: fix spelling mistake: "Framming" -> "Framing"

2018-05-18 Thread David Miller
From: Colin King Date: Fri, 18 May 2018 11:09:22 +0100 > From: Colin Ian King > > Trivial fix to spelling mistake in printk message text > > Signed-off-by: Colin Ian King Applied.

Re: [PATCH v2] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-05-18 Thread David Miller
From: Geert Uytterhoeven Date: Fri, 18 May 2018 12:52:51 +0200 > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy > CONFIG_ARCH_SHMOBILE, hence use the former. > > Renesas

Re: [PATCH] net/atheros: fix spelling mistake: "Ddescription" -> "Description"

2018-05-18 Thread David Miller
From: Colin King Date: Fri, 18 May 2018 10:22:06 +0100 > From: Colin Ian King > > Trivial fix to spelling mistakes in name field text > > Signed-off-by: Colin Ian King > --- >

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Pavel Tatashin
On 05/18/2018 01:28 PM, Sergei Shtylyov wrote: > On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > >> * parallelized this function, so drop lock for the >>> >>> Parallelizing? Else the sentence doesn't parse for me. :-) > >My comment hardly makes sense when you removed all the

Re: [RFC PATCH net-next] tcp: tcp_rack_reo_wnd() can be static

2018-05-18 Thread David Miller
From: kbuild test robot Date: Fri, 18 May 2018 13:14:23 +0800 > Fixes: 20b654dfe1be ("tcp: support DUPACK threshold in RACK") > Signed-off-by: kbuild test robot Looks good, applied, thanks!

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

2018-05-18 Thread Sergei Shtylyov
On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > * parallelized this function, so drop lock for the >> >> Parallelizing? Else the sentence doesn't parse for me. :-) My comment hardly makes sense when you removed all the context... > Hi Sergei, > > In a separate series I

Re: [PATCH bpf-next 0/5] fix test_sockmap

2018-05-18 Thread Daniel Borkmann
On 05/18/2018 06:54 PM, Shuah Khan wrote: > On 05/18/2018 01:17 AM, Prashant Bhole wrote: >> This series fixes bugs in test_sockmap code. They weren't caught >> previously because failure in RX/TX thread was not notified to the >> main thread. >> >> Also fixed data verification logic and slightly

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-18 Thread Jason Gunthorpe
On Fri, May 18, 2018 at 01:03:51PM -0400, David Miller wrote: > From: Saeed Mahameed > Date: Thu, 17 May 2018 18:22:43 -0700 > > > Below you can find two pull requests, > > > > 1. mlx5 core updates to be shared for both netdev and RDMA, (patches 1..9) > > which is based on

Re: [PATCH net-next 0/9] net/smc: cleanups 2018-05-18

2018-05-18 Thread David Miller
From: Ursula Braun Date: Fri, 18 May 2018 09:34:09 +0200 > here are SMC patches for net-next providing restructuring and cleanup > in different areas. Series applied, thanks Ursula.

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 18 May 2018 08:30:43 -0700 > >> We probably need to revert Willem patch >> (7ce875e5ecb8562fd44040f69bda96c999e38bbc) > > Is it really valid to reach ip_recv_err

Re: [pull request][for-next 00/15] Mellanox, mlx5 core and netdev updates 2018-05-17

2018-05-18 Thread David Miller
From: Saeed Mahameed Date: Thu, 17 May 2018 18:22:43 -0700 > Below you can find two pull requests, > > 1. mlx5 core updates to be shared for both netdev and RDMA, (patches 1..9) > which is based on the last mlx5-next pull request > > The following changes since commit

  1   2   3   >