ATENCIÓN

2018-06-05 Thread Sistemas administrador
ATENCIÓN; Su buzón ha superado el límite de almacenamiento, que es de 5 GB definidos por el administrador, quien actualmente está ejecutando en 10.9GB, no puede ser capaz de enviar o recibir correo nuevo hasta que vuelva a validar su buzón de correo electrónico. Para revalidar su buzón de

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 8:51 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch/851711/ Let me try to

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread Or Gerlitz
On Wed, Jun 6, 2018 at 12:27 AM, Jakub Kicinski wrote: > On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote: >> From: Jakub Kicinski >> Date: Tue, 5 Jun 2018 11:57:47 -0700 >> >> > Do we still care about correctness and not breaking backward >> > compatibility? >> >> Jakub let me know

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread Or Gerlitz
On Tue, Jun 5, 2018 at 9:59 PM, Jakub Kicinski wrote: > On Tue, 5 Jun 2018 11:57:47 -0700, Jakub Kicinski wrote: >> On Tue, 5 Jun 2018 11:04:03 +0300, Paul Blakey wrote: >> > When using a vxlan device as the ingress dev, we count it as a >> > "no offload dev", so when such a rule comes and err

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 16:52:22 -0700 "Samudrala, Sridhar" wrote: > On 6/5/2018 2:52 PM, Stephen Hemminger wrote: > > On Tue, 5 Jun 2018 22:38:43 +0300 > > "Michael S. Tsirkin" wrote: > > > >>> See: > >>> https://patchwork.ozlabs.org/patch/851711/ > >> Let me try to summarize that: > >> >

Re: [PATCH bpf-next v7 3/6] bpf: Add IPv6 Segment Routing helpers

2018-06-05 Thread Mathieu Xhonneux
2018-05-30 13:00 GMT+02:00 Daniel Borkmann : >> Instead of doing this inside the helper you can reject the program already >> in the lwt_*_func_proto() by returning NULL when !CONFIG_IPV6_SEG6_BPF. That >> way programs get rejected at verification time instead of runtime, so the >> user can probe

[PATCH net-next] enic: fix UDP rss bits

2018-06-05 Thread Govindarajulu Varadarajan
In commit 48398b6e7065 ("enic: set UDP rss flag") driver needed to set a single bit to enable UDP rss. This is changed to two bit. One for UDP IPv4 and other bit for UDP IPv6. The hardware which supports this is not released yet. When released, driver should set 2 bit to enable UDP rss for both

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
> And I just have to look a little bit in the future as selected approach > expected to be extended on future SoC (and other parts of existing SoCs - > ICSS-G SW switch) > where we going to have more features, like TSN, EST and packet Policing and > Classification. You should probably took a

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/5/2018 2:52 PM, Stephen Hemminger wrote: On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: See: https://patchwork.ozlabs.org/patch/851711/ Let me try to summarize that: You wanted to speed up the delayed link up. You had an idea to additionally take

Re: umh build...

2018-06-05 Thread David Miller
From: Alexei Starovoitov Date: Tue, 5 Jun 2018 15:29:34 -0700 > On Tue, Jun 05, 2018 at 05:03:59PM -0400, David Miller wrote: >> >> Alexei, I tried to build bpfilter on sparc64 and it shows that >> CONFIG_OUTPUT_FORMAT is an x86 specific Kconfig value. >> >> And, even if I added it, it's not

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
On Tue, Jun 05, 2018 at 06:23:45PM -0500, Grygorii Strashko wrote: > > > On 06/02/2018 07:26 PM, Andrew Lunn wrote: > >> *After this patch set*: goal keep things working the same as max as > >> possible and get rid of TI custom tool. > > > > We are happy to keep things the same, if they fit

wir bieten 2% Kredite

2018-06-05 Thread Ronald Bernstein
Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehen zu TOP

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
> So, my understanding for (1) "blocked FDB entry support" is reasonable > extension for bridge/switchdev ("green"). You might have to justify it, but yes. > > Does the network stack need for forward specific multicast MAC > > addresses between bridge ports independent of the state? If there is

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 07:26 PM, Andrew Lunn wrote: >> *After this patch set*: goal keep things working the same as max as >> possible and get rid of TI custom tool. > > We are happy to keep things the same, if they fit with the switchdev > model. Anything in your customer TI tool/model which does not

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 22:38:43 +0300 "Michael S. Tsirkin" wrote: > > > > See: > >https://patchwork.ozlabs.org/patch/851711/ > > Let me try to summarize that: > > You wanted to speed up the delayed link up. You had an idea to > additionally take link up when userspace renames

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 09:08 AM, Andrew Lunn wrote: > On Fri, Jun 01, 2018 at 04:29:08PM -0500, Grygorii Strashko wrote: >> Hi Ilias, > > >> Second, Thanks a lot for your great work. I'm still testing it with different >> use cases and trying to consolidate my reply for all questions. >> >> All,

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
Hi Andrew, Thanks a lot for you comments. On 06/02/2018 07:49 PM, Andrew Lunn wrote: > Hi Grygorii > >> Don't know howto: >> 1) add FDB entry with "blocked" flag - ALE can discard all packets with >> SRC/DST >> address = blocked MAC >> 2) add multicast MAC address with Supervisory Packet flag

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-06-05 Thread Julian Anastasov
Hello, On Tue, 5 Jun 2018, Martin KaFai Lau wrote: > On Sat, May 05, 2018 at 03:58:25PM +0300, Julian Anastasov wrote: > > So, except the RTF_LOCAL check in __ip6_rt_update_pmtu > > we should have no other issues. > Hi Julian, > > Do you have a chance to work on the IPv6 side?

Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum action

2018-06-05 Thread David Ahern
On 6/5/18 1:44 PM, Keara Leibovitz wrote: > Add json output support for checksum action. > ... > > Signed-off-by: Keara Leibovitz > --- > tc/m_csum.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/tc/m_csum.c b/tc/m_csum.c > index

Re: umh build...

2018-06-05 Thread Alexei Starovoitov
On Tue, Jun 05, 2018 at 05:03:59PM -0400, David Miller wrote: > > Alexei, I tried to build bpfilter on sparc64 and it shows that > CONFIG_OUTPUT_FORMAT is an x86 specific Kconfig value. > > And, even if I added it, it's not clear what it should even be set to. > > Right now, for example, my

Re: [PATCH bpf-next v4 2/2] samples/bpf: Add xdp_sample_pkts example

2018-06-05 Thread Jakub Kicinski
On Tue, 05 Jun 2018 16:50:00 +0200, Toke Høiland-Jørgensen wrote: > Add an example program showing how to sample packets from XDP using the > perf event buffer. The example userspace program just prints the ethernet > header for every packet sampled. > > Signed-off-by: Toke Høiland-Jørgensen >

Re: [PATCH bpf-next v4 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-05 Thread Jakub Kicinski
On Tue, 05 Jun 2018 16:50:00 +0200, Toke Høiland-Jørgensen wrote: > Add two new helper functions to trace_helpers that supports polling > multiple perf file descriptors for events. These are used to the XDP > perf_event_output example, which needs to work with one perf fd per CPU. > >

[PATCH net] net: ipv6: ip6_output: alloc skb with tailroom

2018-06-05 Thread Alexander Aring
This patch adds care about tailroom length for allocate a skb from ipv6 level stack. In case of 6lowpan we had the problem the skb runs into a skb_over_panic() in some special length cases. The root was there was no tailroom allocated for the IEEE 802.15.4 checksum, although we had the necessary

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
> PHC only one, but hw timestamping blocks are per port. Yes, same as the Marvell. Per port, there are two receive time stamps and one transmit time stamp. Andrew

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/05/2018 04:28 PM, Andrew Lunn wrote: I hope you are right - question is always in number of available options and which one to select - and, most important, explain it to the end user :( The end customer being ptp4linux? At least for Marvell switches, it is happy about everything

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-05 Thread Florian Fainelli
On 06/05/2018 02:03 PM, Grygorii Strashko wrote: > > > On 06/02/2018 05:34 AM, Ilias Apalodimas wrote: >> Hi Florian, >> >> Thanks for taking time to look into this >> >> On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >>> >>> >>> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote:

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
> Right, thanky for the info, but still (sry, to be annoying) why default vlan > is added by bridge > when vlan_filtering == 0? I have no idea! I just made sure the Marvell driver works with this. You might want to do a git blame and find out who added it, and it might say why. Andrew

Re: [PATCH RFC net-next] net: ipvs: Adjust gso_size for IPPROTO_TCP

2018-06-05 Thread Martin KaFai Lau
On Sat, May 05, 2018 at 03:58:25PM +0300, Julian Anastasov wrote: > So, except the RTF_LOCAL check in __ip6_rt_update_pmtu > we should have no other issues. Hi Julian, Do you have a chance to work on the IPv6 side? Thanks, Martin

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 07:37 PM, Andrew Lunn wrote: >> 1) boot, ping no vlan >> >> # ip link add name br0 type bridge >> # echo 0 > /sys/class/net/br0/bridge/default_pvid >> # ip link set dev eth2 master br0 >> # ip link set dev eth0 master br0 >> # ip link set dev eth1 master br0 >> # ifconfig br0

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Andrew Lunn
> I hope you are right - question is always in number of available options > and which one to select - and, most important, explain it to the end user :( The end customer being ptp4linux? At least for Marvell switches, it is happy about everything except that the switch is a bit slow, so we need

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread Jakub Kicinski
On Tue, 05 Jun 2018 15:06:40 -0400 (EDT), David Miller wrote: > From: Jakub Kicinski > Date: Tue, 5 Jun 2018 11:57:47 -0700 > > > Do we still care about correctness and not breaking backward > > compatibility? > > Jakub let me know if you want me to revert this change. Yes, I think this

Re: [PATCH bpf-next v5 00/10] BTF: BPF Type Format

2018-06-05 Thread Martin KaFai Lau
On Thu, Apr 19, 2018 at 04:40:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 18, 2018 at 03:55:56PM -0700, Martin KaFai Lau escreveu: > > This patch introduces BPF Type Format (BTF). > > > > BTF (BPF Type Format) is the meta data format which describes > > the data types of BPF

Re: [PATCH 0/4] RFC CPSW switchdev mode

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 07:08 PM, Andrew Lunn wrote: > On Sat, Jun 02, 2018 at 06:28:22PM -0500, Grygorii Strashko wrote: > > Hi Grygorii > > I'm just picking out one thing here... there is lots more good stuff here. > >> Additional headache is PTP: we have on PHC, but both external interfaces >>

Re: [PATCH iproute2-next v2 1/1] tc: add json support in csum action

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 16:44:19 -0400 Keara Leibovitz wrote: > diff --git a/tc/m_csum.c b/tc/m_csum.c > index 8391071d73f2..0bdbcf361a28 100644 > --- a/tc/m_csum.c > +++ b/tc/m_csum.c > @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE *f, struct rtattr > *arg) > char *uflag_5 =

Re: [PATCH 4/4] cpsw: add switchdev support

2018-06-05 Thread Grygorii Strashko
On 06/02/2018 05:34 AM, Ilias Apalodimas wrote: > Hi Florian, > > Thanks for taking time to look into this > > On Fri, Jun 01, 2018 at 02:48:48PM -0700, Florian Fainelli wrote: >> >> >> On 05/24/2018 09:56 PM, Ilias Apalodimas wrote: >>> On Thu, May 24, 2018 at 06:39:04PM +0200, Andrew Lunn

umh build...

2018-06-05 Thread David Miller
Alexei, I tried to build bpfilter on sparc64 and it shows that CONFIG_OUTPUT_FORMAT is an x86 specific Kconfig value. And, even if I added it, it's not clear what it should even be set to. Right now, for example, my userland builds default to 32-bit sparc even though I'm building a 64-bit

[PATCH iproute2-next v2 1/1] tc: add json support in csum action

2018-06-05 Thread Keara Leibovitz
Add json output support for checksum action. Example output: ~$ $TC actions add action csum udp continue index 7 ~$ $TC actions add action csum icmp iph igmp pipe index 200 cookie 112233 ~$ $TC -j actions ls action csum [{ "total acts":2 }, { "actions": [{ "order":0,

Re: [PATCH iproute2-next 1/1] tc: add json support in csum action

2018-06-05 Thread David Ahern
On 6/5/18 12:30 PM, Keara Leibovitz wrote: please add some words here. e.g., add example output > Signed-off-by: Keara Leibovitz > --- > tc/m_csum.c | 16 ++-- > 1 file changed, 10 insertions(+), 6 deletions(-) > > diff --git a/tc/m_csum.c b/tc/m_csum.c > index

[PATCH iproute2-next 1/1] tc: add json support in csum action

2018-06-05 Thread Keara Leibovitz
Signed-off-by: Keara Leibovitz --- tc/m_csum.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/tc/m_csum.c b/tc/m_csum.c index 8391071d73f2..67481667d9d2 100644 --- a/tc/m_csum.c +++ b/tc/m_csum.c @@ -162,6 +162,7 @@ print_csum(struct action_util *au, FILE

Re: [PATCH net-next v2 0/2] net: phy: improve PHY suspend/resume

2018-06-05 Thread Heiner Kallweit
On 02.06.2018 22:27, Heiner Kallweit wrote: > On 01.06.2018 02:10, Andrew Lunn wrote: >>> Configuring the different WoL options isn't handled by writing to >>> the PHY registers but by writing to chip / MAC registers. >>> Therefore phy_suspend() isn't able to figure out whether WoL is >>> enabled

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Michael S. Tsirkin
On Tue, Jun 05, 2018 at 11:53:05AM -0700, Stephen Hemminger wrote: > > > * Now, netvsc and net_failover use the same delayed work type > > > mechanism for setup. Previously, net_failover code was triggering off > > > name change but a similar policy was rejected for netvsc. > > >

Re: pull-request: bpf-next 2018-06-05

2018-06-05 Thread David Miller
From: Daniel Borkmann Date: Tue, 5 Jun 2018 18:39:16 +0200 > The following pull-request contains BPF updates for your *net-next* tree. > > The main changes are: ... > Please consider pulling these changes from: > > git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git I've pulled

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-05 Thread Ronak Doshi
On Tue, 5 Jun 2018, Paolo Abeni wrote: > Hi, > > I'm sorry for the long delay in my answer, I've been travelling. > > On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote: > > On Thu, 31 May 2018, Neil Horman wrote: > > > What packet types will rcd.csum be set for? > > > Neil > > > > I

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread David Miller
From: Jakub Kicinski Date: Tue, 5 Jun 2018 11:57:47 -0700 > Do we still care about correctness and not breaking backward > compatibility? Jakub let me know if you want me to revert this change.

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread Jakub Kicinski
On Tue, 5 Jun 2018 11:57:47 -0700, Jakub Kicinski wrote: > On Tue, 5 Jun 2018 11:04:03 +0300, Paul Blakey wrote: > > When using a vxlan device as the ingress dev, we count it as a > > "no offload dev", so when such a rule comes and err stop is true, > > we fail early and don't try the egdev route

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread Jakub Kicinski
On Tue, 5 Jun 2018 11:04:03 +0300, Paul Blakey wrote: > When using a vxlan device as the ingress dev, we count it as a > "no offload dev", so when such a rule comes and err stop is true, > we fail early and don't try the egdev route which can offload it > through the egress device. > > Fix that

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 21:35:26 +0300 "Michael S. Tsirkin" wrote: > Thanks, I think this is nice patch but I wonder whether it can be split > up somewhat. Not all of it is uncontroversial. I started that way, but then I was fixing code that was later deleted. The big change was eliminating the

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Michael S. Tsirkin
Thanks, I think this is nice patch but I wonder whether it can be split up somewhat. Not all of it is uncontroversial. On Mon, Jun 04, 2018 at 08:42:31PM -0700, Stephen Hemminger wrote: > * The matching of secondary device to primary device policy > is up to the network device. Both

Re: [Patch net v2] netdev-FAQ: clarify DaveM's position for stable backports

2018-06-05 Thread David Miller
From: Cong Wang Date: Tue, 5 Jun 2018 09:48:13 -0700 > Per discussion with David at netconf 2018, let's clarify > DaveM's position of handling stable backports in netdev-FAQ. > > This is important for people relying on upstream -stable > releases. > > Cc: sta...@vger.kernel.org > Cc: Greg

Re: [PATCH iproute2] configure: require libmnl

2018-06-05 Thread Simon Horman
On Thu, May 31, 2018 at 03:32:09PM -0400, Stephen Hemminger wrote: > Several users of BPF and other features are trying to build without > libmnl, then complaining that features don't work. The time has > come to require libmnl to build iproute2. > > Signed-off-by: Stephen Hemminger

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread David Miller
From: Stephen Hemminger Date: Tue, 5 Jun 2018 10:45:10 -0700 > I said it wasn't tested. Not surprising. Don't have a version of KVM > that supports standby (and not going to build KVM from scratch for > this). It would definitely help me if you put "RFC" in the subject line for patches which

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 10:22:13 -0700 "Samudrala, Sridhar" wrote: > On 6/4/2018 8:42 PM, Stephen Hemminger wrote: > > The net failover should be a simple library, not a virtual > > object with function callbacks (see callback hell). > > The code is simpler is smaller both for the netvsc and virtio

Re: Qualcomm rmnet driver and qmi_wwan

2018-06-05 Thread Subash Abhinov Kasiviswanathan
On 2018-06-05 08:54, Dan Williams wrote: On Tue, 2018-06-05 at 11:38 +0200, Daniele Palmas wrote: Hi, 2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan : > On 2018-02-21 04:38, Daniele Palmas wrote: > > > > Hello, > > > > in rmnet kernel documentation I read: > > > > "This driver can

Re: [PATCH net] failover: eliminate callback hell

2018-06-05 Thread Samudrala, Sridhar
On 6/4/2018 8:42 PM, Stephen Hemminger wrote: The net failover should be a simple library, not a virtual object with function callbacks (see callback hell). The code is simpler is smaller both for the netvsc and virtio use case. I quickly tried this patch and it breaks virtio-net in standby

Re: [PATCH iproute2 v2 1/2] ip: display netns name instead of nsid

2018-06-05 Thread Stephen Hemminger
On Tue, 5 Jun 2018 15:08:30 +0200 Nicolas Dichtel wrote: > > +char *get_name_from_nsid(int nsid) > +{ > + struct nsid_cache *c; > + > + netns_nsid_socket_init(); > + netns_map_init(); > + > + c = netns_map_get_by_nsid(nsid); > + if (c) > + return c->name; > + >

[Patch net v2] netdev-FAQ: clarify DaveM's position for stable backports

2018-06-05 Thread Cong Wang
Per discussion with David at netconf 2018, let's clarify DaveM's position of handling stable backports in netdev-FAQ. This is important for people relying on upstream -stable releases. Cc: sta...@vger.kernel.org Cc: Greg Kroah-Hartman Signed-off-by: Cong Wang ---

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:25:19 -0700 > It seems that rtnl_group_changelink() can call do_setlink > while a prior call to validate_linkmsg(dev = NULL, ...) could > not validate IFLA_ADDRESS / IFLA_BROADCAST > > Make sure do_setlink() calls validate_linkmsg() instead > of

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:42:54 -0700 > On 06/05/2018 09:41 AM, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 5 Jun 2018 09:25:19 -0700 >> >>> It seems that rtnl_group_changelink() can call do_setlink >>> while a prior call to validate_linkmsg(dev = NULL, ...)

Re: [Patch net-next] netdev-FAQ: clarify DaveM's position for stable backports

2018-06-05 Thread Cong Wang
On Tue, Jun 5, 2018 at 6:43 AM, David Miller wrote: > From: Cong Wang > Date: Mon, 4 Jun 2018 11:07:19 -0700 > >> +Q: Are all networking bug fixes backported to all stable releases? >> + >> +A: Due to capacity, Dave could only take care of the backports for the last >> + 3 stable releases. >

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread Eric Dumazet
On 06/05/2018 09:41 AM, David Miller wrote: > From: Eric Dumazet > Date: Tue, 5 Jun 2018 09:25:19 -0700 > >> It seems that rtnl_group_changelink() can call do_setlink >> while a prior call to validate_linkmsg(dev = NULL, ...) could >> not validate IFLA_ADDRESS / IFLA_BROADCAST >> >> Make

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:25:19 -0700 > It seems that rtnl_group_changelink() can call do_setlink > while a prior call to validate_linkmsg(dev = NULL, ...) could > not validate IFLA_ADDRESS / IFLA_BROADCAST > > Make sure do_setlink() calls validate_linkmsg() instead > of

pull-request: bpf-next 2018-06-05

2018-06-05 Thread Daniel Borkmann
Hi David, The following pull-request contains BPF updates for your *net-next* tree. The main changes are: 1) Add a new BPF hook for sendmsg similar to existing hooks for bind and connect: "This allows to override source IP (including the case when it's set via cmsg(3)) and destination

Re: [PATCH net] l2tp: fix refcount leakage on PPPoL2TP sockets

2018-06-05 Thread Guillaume Nault
On Tue, Jun 05, 2018 at 09:41:24AM -0400, David Miller wrote: > From: Guillaume Nault > Date: Mon, 4 Jun 2018 18:52:19 +0200 > > > Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session > > object destroy") tried to fix a race condition where a PPPoL2TP socket > > would disappear

Re: [net-next PATCH v3 0/5] Symmetric queue selection using XPS for Rx queues

2018-06-05 Thread David Miller
From: Amritha Nambiar Date: Tue, 05 Jun 2018 01:37:45 -0700 > This patch series implements support for Tx queue selection based on > Rx queue(s) map. This is done by configuring Rx queue(s) map per Tx-queue > using sysfs attribute. If the user configuration for Rx queues does > not apply, then

Re: [PATCH v2 net-next 0/3] devlink: Add extack messages for reload and port split/unsplit

2018-06-05 Thread David Miller
From: dsah...@kernel.org Date: Tue, 5 Jun 2018 08:14:08 -0700 > From: David Ahern > > Patch 1 adds extack arg to reload, port_split and port_unsplit devlink > operations. > > Patch 2 adds extack messages for reload operation in netdevsim. > > Patch 3 adds extack messages to port

Re: [PATCH net v2 2/2] ipmr: fix error path when ipmr_new_table fails

2018-06-05 Thread David Miller
From: Sabrina Dubroca Date: Tue, 5 Jun 2018 15:02:00 +0200 > commit 0bbbf0e7d0e7 ("ipmr, ip6mr: Unite creation of new mr_table") > refactored ipmr_new_table, so that it now returns NULL when > mr_table_alloc fails. Unfortunately, all callers of ipmr_new_table > expect an ERR_PTR. > > This can

Re: [PATCH v2 net-next] net: metrics: add proper netlink validation

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 06:06:19 -0700 > Before using nla_get_u32(), better make sure the attribute > is of the proper size. > > Code recently was changed, but bug has been there from beginning > of git. ... > Fixes: a919525ad832 ("net: Move fib_convert_metrics to metrics

Re: [PATCH net v2 1/2] ip6mr: only set ip6mr_table from setsockopt when ip6mr_new_table succeeds

2018-06-05 Thread David Miller
From: Sabrina Dubroca Date: Tue, 5 Jun 2018 15:01:59 +0200 > Currently, raw6_sk(sk)->ip6mr_table is set unconditionally during > ip6_mroute_setsockopt(MRT6_TABLE). A subsequent attempt at the same > setsockopt will fail with -ENOENT, since we haven't actually created > that table. > > A

[PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread Eric Dumazet
It seems that rtnl_group_changelink() can call do_setlink while a prior call to validate_linkmsg(dev = NULL, ...) could not validate IFLA_ADDRESS / IFLA_BROADCAST Make sure do_setlink() calls validate_linkmsg() instead of letting its callers having this responsibility. With help from Dmitry

Re: suspicius csum initialization in vmxnet3_rx_csum

2018-06-05 Thread Paolo Abeni
Hi, I'm sorry for the long delay in my answer, I've been travelling. On Fri, 2018-06-01 at 11:10 -0700, Ronak Doshi wrote: > On Thu, 31 May 2018, Neil Horman wrote: > > What packet types will rcd.csum be set for? > > Neil > > I looked thorugh the emulation code and found that rcd.csum is not

Re: [RFC PATCH] kcm: hold rx mux lock when updating the receive queue.

2018-06-05 Thread Paolo Abeni
Hi, On Tue, 2018-06-05 at 08:35 -0700, Tom Herbert wrote: > On Tue, Jun 5, 2018 at 7:53 AM, David Miller wrote: > > From: Paolo Abeni > > Date: Tue, 5 Jun 2018 12:32:33 +0200 > > > >> @@ -1157,7 +1158,9 @@ static int kcm_recvmsg(struct socket *sock, struct > >> msghdr *msg, > >>

Re: [PATCH v2 net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-05 Thread Jiri Pirko
Tue, Jun 05, 2018 at 05:14:11PM CEST, dsah...@kernel.org wrote: >From: David Ahern > >Return messages in extack for port split/unsplit errors. e.g., >$ devlink port split swp1s1 count 4 >Error: mlxsw_spectrum: Port cannot be split further. >devlink answers: Invalid argument > >$

[PATCH v2 net-next 1/3] devlink: Add extack to reload and port_{un,}split operations

2018-06-05 Thread dsahern
From: David Ahern Add extack argument to reload, port_split and port_unsplit operations. Signed-off-by: David Ahern Acked-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 9 ++--- drivers/net/ethernet/netronome/nfp/nfp_devlink.c | 5 +++--

[PATCH v2 net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures

2018-06-05 Thread dsahern
From: David Ahern Return messages in extack for port split/unsplit errors. e.g., $ devlink port split swp1s1 count 4 Error: mlxsw_spectrum: Port cannot be split further. devlink answers: Invalid argument $ devlink port unsplit swp4 Error: mlxsw_spectrum: Port was not split.

[PATCH v2 net-next 0/3] devlink: Add extack messages for reload and port split/unsplit

2018-06-05 Thread dsahern
From: David Ahern Patch 1 adds extack arg to reload, port_split and port_unsplit devlink operations. Patch 2 adds extack messages for reload operation in netdevsim. Patch 3 adds extack messages to port split/unsplit in mlxsw driver. v2 - make the extack messages align with existing dev_err

[PATCH v2 net-next 2/3] netdevsim: Add extack error message for devlink reload

2018-06-05 Thread dsahern
From: David Ahern devlink reset command can fail if a FIB resource limit is set to a value lower than the current occupancy. Return a proper message indicating the reason for the failure. $ devlink resource sh netdevsim/netdevsim0 netdevsim/netdevsim0: name IPv4 size unlimited unit entry

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread Jiri Pirko
Tue, Jun 05, 2018 at 04:58:44PM CEST, dsah...@gmail.com wrote: >On 6/5/18 1:18 AM, Jiri Pirko wrote: >> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Miller
From: David Ahern Date: Tue, 5 Jun 2018 07:58:44 -0700 > On 6/5/18 1:18 AM, Jiri Pirko wrote: >> Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote:

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Ahern
On 6/5/18 1:18 AM, Jiri Pirko wrote: > Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >> On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: >>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: if (!mlxsw_sp_port->split) {

Re: Qualcomm rmnet driver and qmi_wwan

2018-06-05 Thread Dan Williams
On Tue, 2018-06-05 at 11:38 +0200, Daniele Palmas wrote: > Hi, > > 2018-02-21 20:47 GMT+01:00 Subash Abhinov Kasiviswanathan > : > > On 2018-02-21 04:38, Daniele Palmas wrote: > > > > > > Hello, > > > > > > in rmnet kernel documentation I read: > > > > > > "This driver can be used to register

Re: [RFC PATCH] kcm: hold rx mux lock when updating the receive queue.

2018-06-05 Thread David Miller
From: Paolo Abeni Date: Tue, 5 Jun 2018 12:32:33 +0200 > @@ -1157,7 +1158,9 @@ static int kcm_recvmsg(struct socket *sock, struct > msghdr *msg, > /* Finished with message */ > msg->msg_flags |= MSG_EOR; >

[PATCH bpf-next v4 2/2] samples/bpf: Add xdp_sample_pkts example

2018-06-05 Thread Toke Høiland-Jørgensen
Add an example program showing how to sample packets from XDP using the perf event buffer. The example userspace program just prints the ethernet header for every packet sampled. Signed-off-by: Toke Høiland-Jørgensen --- samples/bpf/Makefile |4 +

[PATCH bpf-next v4 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-05 Thread Toke Høiland-Jørgensen
Add two new helper functions to trace_helpers that supports polling multiple perf file descriptors for events. These are used to the XDP perf_event_output example, which needs to work with one perf fd per CPU. Signed-off-by: Toke Høiland-Jørgensen --- tools/testing/selftests/bpf/trace_helpers.c

Re: [PATCH] net-tcp: remove useless tw_timeout field

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 05:59:27 -0700 > On 06/05/2018 03:07 AM, Maciej Żenczykowski wrote: >> From: Maciej Żenczykowski >> >> Tested: 'git grep tw_timeout' comes up empty and it builds :-) >> >> Signed-off-by: Maciej Żenczykowski >> Cc: Eric Dumazet > > This field became

Re: [PATCH bpf-next v3 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-05 Thread Toke Høiland-Jørgensen
Daniel Borkmann writes: > Hi Toke, > > On 06/05/2018 01:14 PM, Toke Høiland-Jørgensen wrote: >> Signed-off-by: Toke Høiland-Jørgensen > > Please no empty commit message. Not sure why from the previous patch > you removed it here. Ah, right, sorry; think I got patch versions mixed up :/ Will

Re: [PATCH net] net: sched: cls: Fix offloading when ingress dev is vxlan

2018-06-05 Thread David Miller
From: Paul Blakey Date: Tue, 5 Jun 2018 11:04:03 +0300 > When using a vxlan device as the ingress dev, we count it as a > "no offload dev", so when such a rule comes and err stop is true, > we fail early and don't try the egdev route which can offload it > through the egress device. > > Fix

Re: [PATCH net-next 3/3] mlxsw: Add extack messages for port_{un,}split failures?

2018-06-05 Thread David Miller
From: Jiri Pirko Date: Tue, 5 Jun 2018 10:18:36 +0200 > Tue, Jun 05, 2018 at 10:05:28AM CEST, ido...@idosch.org wrote: >>On Tue, Jun 05, 2018 at 09:52:30AM +0200, Jiri Pirko wrote: >>> Tue, Jun 05, 2018 at 12:15:03AM CEST, dsah...@kernel.org wrote: >>> > if (!mlxsw_sp_port->split) { >>> >

Re: [PATCH net] sctp: not allow transport timeout value less than HZ/5 for hb_timer

2018-06-05 Thread David Miller
From: Xin Long Date: Tue, 5 Jun 2018 12:16:58 +0800 > syzbot reported a rcu_sched self-detected stall on CPU which is caused > by too small value set on rto_min with SCTP_RTOINFO sockopt. With this > value, hb_timer will get stuck there, as in its timer handler it starts > this timer again with

Re: [PATCH net-next] net/mlx5e: fix error return code in mlx5e_alloc_rq()

2018-06-05 Thread David Miller
From: Wei Yongjun Date: Tue, 5 Jun 2018 02:42:56 + > Fix to return error code -ENOMEM from the kvzalloc_node() error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue memory > scheme") > Signed-off-by:

Re: [PATCH net-next] net/mlx5e: Make function mlx5e_change_rep_mtu() static

2018-06-05 Thread David Miller
From: Wei Yongjun Date: Tue, 5 Jun 2018 02:42:45 + > Fixes the following sparse warning: > > drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:903:5: warning: > symbol 'mlx5e_change_rep_mtu' was not declared. Should it be static? > > Signed-off-by: Wei Yongjun Applied.

Re: [PATCH net-next v2] net: qualcomm: rmnet: Fix use after free while sending command ack

2018-06-05 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Mon, 4 Jun 2018 19:43:38 -0600 > When sending an ack to a command packet, the skb is still referenced > after it is sent to the real device. Since the real device could > free the skb, the device pointer would be invalid. > Also, remove an unnecessary

Re: [PATCH net-next v2] net: ipv6: Generate random IID for addresses on RAWIP devices

2018-06-05 Thread David Miller
From: Subash Abhinov Kasiviswanathan Date: Mon, 4 Jun 2018 19:26:07 -0600 > RAWIP devices such as rmnet do not have a hardware address and > instead require the kernel to generate a random IID for the > IPv6 addresses. > > Signed-off-by: Sean Tranchetti > Signed-off-by: Subash Abhinov

bpf-next is CLOSED

2018-06-05 Thread Daniel Borkmann
Please only submit bug fixes at this time due to merge window, thank you.

Re: [PATCH bpf-next v3 1/2] trace_helpers.c: Add helpers to poll multiple perf FDs for events

2018-06-05 Thread Daniel Borkmann
Hi Toke, On 06/05/2018 01:14 PM, Toke Høiland-Jørgensen wrote: > Signed-off-by: Toke Høiland-Jørgensen Please no empty commit message. Not sure why from the previous patch you removed it here. > --- > tools/testing/selftests/bpf/trace_helpers.c | 47 > ++- >

Re: AF_XDP. Was: [net-next 00/12][pull request] Intel Wired LAN Driver Updates 2018-06-04

2018-06-05 Thread Daniel Borkmann
On 06/05/2018 10:44 AM, Björn Töpel wrote: > Den tis 5 juni 2018 kl 03:46 skrev Alexander Duyck > : >> On Mon, Jun 4, 2018 at 4:32 PM, Alexei Starovoitov >> wrote: >>> On Mon, Jun 04, 2018 at 03:02:31PM -0700, Alexander Duyck wrote: On Mon, Jun 4, 2018 at 2:27 PM, David Miller wrote: >

Re: [PATCH net-next] tcp: refactor tcp_ecn_check_ce to remove sk type cast

2018-06-05 Thread David Miller
From: Yousuk Seung Date: Mon, 4 Jun 2018 15:29:51 -0700 > Refactor tcp_ecn_check_ce and __tcp_ecn_check_ce to accept struct sock* > instead of tcp_sock* to clean up type casts. This is a pure refactor > patch. > > Signed-off-by: Yousuk Seung > Signed-off-by: Neal Cardwell > Signed-off-by:

Re: [PATCH net] net/ipv6: prevent use after free in ip6_route_mpath_notify

2018-06-05 Thread David Miller
From: dsah...@kernel.org Date: Mon, 4 Jun 2018 13:41:42 -0700 > From: David Ahern > > syzbot reported a use-after-free: ... > The problem is that rt_last can point to a deleted route if the insert > fails. > > One reproducer is to insert a route and then add a multipath route that > has a

Re: [PATCH net-next] net: phy: broadcom: Enable 125 MHz clock on LED4 pin for BCM54612E by default.

2018-06-05 Thread David Miller
From: Kun Yi Date: Mon, 4 Jun 2018 13:17:04 -0700 > BCM54612E have 4 multi-functional LED pins that can be configured > through register setting; the LED4 pin can be configured to a 125MHz > reference clock output by setting the spare register. Since the dedicated > CLK125 reference clock pin

Re: [Patch net-next] netdev-FAQ: clarify DaveM's position for stable backports

2018-06-05 Thread David Miller
From: Cong Wang Date: Mon, 4 Jun 2018 11:07:19 -0700 > +Q: Are all networking bug fixes backported to all stable releases? > + > +A: Due to capacity, Dave could only take care of the backports for the last > + 3 stable releases. As Greg stated, I only do 2 not 3.

Re: [PATCH net] l2tp: fix refcount leakage on PPPoL2TP sockets

2018-06-05 Thread David Miller
From: Guillaume Nault Date: Mon, 4 Jun 2018 18:52:19 +0200 > Commit d02ba2a6110c ("l2tp: fix race in pppol2tp_release with session > object destroy") tried to fix a race condition where a PPPoL2TP socket > would disappear while the L2TP session was still using it. However, it > missed the root

  1   2   >