[PATCH nf-next] netfilter: ipset: deduplicate prefixlen maps

The prefixlen maps used here are identical, and have been since introduction. It seems to make sense to use a single large map, that the preprocessor will fill appropriately. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipset/pfxlen.c

Re: those bpf binutils testsuite failures..

David Miller writes: > I wonder if whatever tool you used to get rid of trailing whitespace > did so in the testsuite foo.d files too? That definitely is > undesirable :-) Most likely I was being too clever by half. I'll make sure I omit the .d files from scanning.

Re: [PATCH v4 binutils] Add BPF support to binutils...

David Miller <da...@davemloft.net> writes: > From: Aaron Conole <acon...@bytheb.org> > Date: Mon, 01 May 2017 13:22:00 -0400 > >> x86-64: >> Running /home/aconole/git/binutils-gdb/gas/testsuite/gas/bpf/bpf.exp ... >> FAIL: jump >> FAIL: call >

Re: [PATCH v4 binutils] Add BPF support to binutils...

David Miller writes: > This is mainly a synchronization point, I still need to look > more deeply into Alexei's -g issue. > > New in this version from v3: > - Remove tailcall from opcode table > - Rearrange relocations so that numbers match with LLVM ones > - Emit relocs

Re: [PATCH v2 binutils] Add BPF support to binutils...

David Miller <da...@davemloft.net> writes: > From: Aaron Conole <acon...@bytheb.org> > Date: Fri, 28 Apr 2017 11:57:36 -0400 > >> I'll get an arm board up and running to do some testing there. As a >> teaser: > > Great. > > I started w

Re: [PATCH v2 binutils] Add BPF support to binutils...

Hi David, David Miller writes: > Here is what I have after today's work. I think I sorted out the > endianness issues. > > gas can be controlled explicitly using "-EB" and "-EL" options. The > default is whatever endianness the host has. The elf names for the > two

[PATCH nf-next] ip_vs_sync: change comparison on sync_refresh_period

The sync_refresh_period variable is unsigned, so it can never be < 0. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipvs/ip_vs_sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_syn

[PATCH nf-next] nf_conntrack: remove double assignment

The protonet pointer will unconditionally be rewritten, so just do the needed assignment first. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/nf_conntrack_proto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/netfilter/nf_conntrack_proto.c

[PATCH nf-next] nf_tables: remove double return statement

Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/nf_tables_api.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 2d822d2..1452fb7 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/net

[PATCH nf-next] ipset: remove unused function __ip_set_get_netlink

There are no in-tree callers. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/ipset/ip_set_core.c | 8 1 file changed, 8 deletions(-) diff --git a/net/netfilter/ipset/ip_set_core.c b/net/netfilter/ipset/ip_set_core.c index c296f9b..68ba531 100644 --- a/net/net

[PATCH nf-next] ipvs: remove unused function ip_vs_set_state_timeout

There are no in-tree callers of this function and it isn't exported. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/ip_vs.h | 2 -- net/netfilter/ipvs/ip_vs_proto.c | 22 -- 2 files changed, 24 deletions(-) diff --git a/include/net/ip_

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Alexei, and Daniel, Alexei Starovoitov <alexei.starovoi...@gmail.com> writes: > On Wed, Apr 05, 2017 at 10:59:49PM -0400, Aaron Conole wrote: >> Hi Daniel, >> >> Daniel Borkmann <dan...@iogearbox.net> writes: >> >> > On 04/04/2017 08:33

Re: [RFC net-next] bpf: taint loading !is_gpl programs

Hi Daniel, Daniel Borkmann <dan...@iogearbox.net> writes: > On 04/04/2017 08:33 PM, Aaron Conole wrote: >> The eBPF framework is used for more than just socket level filtering. It >> can also provide tracing, and even change the way packets coming into the >> sys

[RFC net-next] bpf: taint loading !is_gpl programs

. An exemption is made for socket-level filters, since they do not really impact networking for the whole kernel. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- kernel/bpf/syscall.c | 5 + 1 file changed, 5 insertions(+) diff --git a/kernel/bpf/syscall.c b/kernel/bpf/syscall.c

Re: [PATCH] Ipvlan should return an error when an address is already in use.

David Miller <da...@davemloft.net> writes: > From: Aaron Conole <acon...@redhat.com> > Date: Tue, 03 Jan 2017 10:50:00 -0500 > >>> @@ -489,7 +490,12 @@ static int __inet_insert_ifa(struct in_ifaddr *ifa, >>> struct nlmsghdr *nlh, >>

Re: [PATCH] Ipvlan should return an error when an address is already in use.

Hi Krister, Krister Johansen writes: > The ipvlan code already knows how to detect when a duplicate address is > about to be assigned to an ipvlan device. However, that failure is not > propogated outward and leads to a silent failure. This teaches the ip > address

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

Aaron Conole <acon...@redhat.com> writes: >> From: Aaron Conole <acon...@bytheb.org> >> >> The virtio committee recently ratified a change, VIRTIO-152, which >> defines the mtu field to be 'max' MTU, not simply desired MTU. >> >> This commit brings

[PATCH v2 net-next] virtio-net: Update the mtu code to match virtio spec

by virtio_cread16 will never exceed the initial value of max_mtu. Signed-off-by: Aaron Conole <acon...@redhat.com> Acked-by: "Michael S. Tsirkin" <m...@redhat.com> Acked-by: Jarod Wilson <ja...@redhat.com> --- Nothing code-wise has changed, but I've included the ACKs and fixed up

Re: [PATCH] virtio-net: Update the mtu code to match virtio spec

> From: Aaron Conole <acon...@bytheb.org> > > The virtio committee recently ratified a change, VIRTIO-152, which > defines the mtu field to be 'max' MTU, not simply desired MTU. > > This commit brings the virtio-net device in compliance with VIRTIO-152. > > Additio

[PATCH] virtio-net: Update the mtu code to match virtio spec

From: Aaron Conole <acon...@bytheb.org> The virtio committee recently ratified a change, VIRTIO-152, which defines the mtu field to be 'max' MTU, not simply desired MTU. This commit brings the virtio-net device in compliance with VIRTIO-152. Additionally, drop the max_mtu branch - it

Re: [PATCH net-next v2 6/9] net: use core MTU range checking in virt drivers

"Michael S. Tsirkin" writes: > On Thu, Oct 20, 2016 at 10:37:20PM -0400, Jarod Wilson wrote: >> On Thu, Oct 20, 2016 at 11:23:54PM +0300, Michael S. Tsirkin wrote: >> > On Thu, Oct 20, 2016 at 01:55:21PM -0400, Jarod Wilson wrote: >> ... >> > > diff --git

Re: [PATCH net-next 5/6] net: use core MTU range checking in virt drivers

Jarod Wilson writes: > hyperv_net: > - set min/max_mtu > > virtio_net: > - set min/max_mtu > - remove virtnet_change_mtu > > vmxnet3: > - set min/max_mtu > > CC: netdev@vger.kernel.org > CC: virtualizat...@lists.linux-foundation.org > CC: "K. Y. Srinivasan"

Re: slab corruption with current -git

Michal Kubecek writes: > On Mon, Oct 10, 2016 at 04:24:01AM -0400, David Miller wrote: >> From: David Miller >> Date: Sun, 09 Oct 2016 23:57:45 -0400 (EDT) >> >> This means that the netns is possibly getting freed up before we >> unregister the netfilter

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

by: Linus Torvalds <torva...@linux-foundation.org> > > to the patch, though. > > David, if you want me to just commit that thing directly, I can > obviously do so, but I do think somebody should look at > > (a) that I actually got the priority list ordering right on the

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Linus Torvalds writes: > On Sun, Oct 9, 2016 at 7:49 PM, Linus Torvalds > wrote: >> >> There is one *correct* way to remove an entry from a singly linked >> list, and it looks like this: >> >> struct entry **pp, *p; >> >> pp

Re: slab corruption with current -git (was Re: [git pull] vfs pile 1 (splice))

Florian Westphal writes: > Linus Torvalds wrote: >> On Sun, Oct 9, 2016 at 12:11 PM, Linus Torvalds >> wrote: >> > >> > Anyway, I don't think I can bisect it, but I'll try to narrow it down >> > a *bit* at least. >>

Re: 4.9-rc0: nf_hooks_ingress missing, breaking compilation

Pavel Machek writes: > Hi! Hi Pavel, > In kernel based on edadd0e, I get plenty of errors such as: In this case, I screwed up - sincere apologies. Enabling CONFIG_NETFILTER_INGRESS will work around this error for the time being, while the fix makes it way through the various

Re: [PATCH 2/3] netfilter: hide reference to nf_hooks_ingress

Arnd Bergmann writes: > A recent cleanup added an unconditional reference to the nf_hooks_ingress > pointer, > but that fails when CONFIG_NETFILTER_INGRESS is disabled and that member is > not present in net_device: > > net/netfilter/core.c: In function 'nf_set_hooks_head': >

Re: pull-request: wireless-drivers-next 2016-09-29

David Miller writes: > From: Kalle Valo > Date: Thu, 29 Sep 2016 19:57:28 +0300 > ... >> Or actually I had one problem. While doing a test merge I noticed that >> net-next fails to compile for me, but I don't think this is anything >> wireless related:

[PATCH nf-next v4 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next v4 1/2] netfilter: Fix potential null pointer dereference

and attempt to dereference. This fix ensures that no null pointer dereference could occur when such a condition happens. Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single linked list") Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 2 +- 1

Re: [PATCH nf-next v3 1/2] netfilter: Fix potential null pointer dereference

Eric Dumazet <eric.duma...@gmail.com> writes: > On Wed, 2016-09-28 at 10:56 -0400, Aaron Conole wrote: >> Eric Dumazet <eric.duma...@gmail.com> writes: >> >> > On Wed, 2016-09-28 at 09:12 -0400, Aaron Conole wrote: >> >> It's possibl

[PATCH nf-next v4 2/2] nf_set_hooks_head: accommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Fixes: e3b37f11e6e4 ("netfilter: replace list_head with single linked list") Signed-off-by: Aaron Conole <acon.

Re: [PATCH nf-next v3 1/2] netfilter: Fix potential null pointer dereference

Eric Dumazet <eric.duma...@gmail.com> writes: > On Wed, 2016-09-28 at 09:12 -0400, Aaron Conole wrote: >> It's possible for nf_hook_entry_head to return NULL. If two >> nf_unregister_net_hook calls happen simultaneously with a single hook >> entry in the list, both w

Re: [PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

Liping Zhang <zlpnob...@gmail.com> writes: > 2016-09-28 11:08 GMT+08:00 Liping Zhang <zlpnob...@gmail.com>: >> Hi Feng, >> >> 2016-09-28 9:23 GMT+08:00 Feng Gao <gfree.w...@gmail.com>: >>> Hi Aaraon, >>> >>> On Tue, Sep 27, 2

[PATCH nf-next v3 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next v3 2/2] nf_set_hooks_head: accommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 15 +++ 1 file changed, 11 inse

[PATCH nf-next v3 1/2] netfilter: Fix potential null pointer dereference

and attempt to dereference. This fix ensures that no null pointer dereference could occur when such a condition happens. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/core.c b/net/netfilter/

[PATCH nf-next v2 2/2] nf_set_hooks_head: acommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 15 +++ 1 file changed, 11 inse

[PATCH nf-next v2 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next v2 1/2] netfilter: Fix potential null pointer dereference

It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole <acon...@bytheb.org> --

Re: [PATCH nf-next 2/2] nf_set_hooks_head: acommodate different kconfig

Florian Westphal <f...@strlen.de> writes: > Aaron Conole <acon...@bytheb.org> wrote: >> When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle >> the request for registration properly by dropping the hook. This >> releases the entry during the set. &

[PATCH nf-next 0/2] fixes for recent nf_compact hooks

Two possible error conditions were caught during an extended testing session, and by a build robot. These patches fix the two issues (a missing handler when config is changed, and a potential NULL dereference). Aaron Conole (2): netfilter: Fix potential null pointer dereference

[PATCH nf-next 2/2] nf_set_hooks_head: acommodate different kconfig

When CONFIG_NETFILTER_INGRESS is unset (or no), we need to handle the request for registration properly by dropping the hook. This releases the entry during the set. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 4 1 file changed, 4 insertions(+) diff

[PATCH nf-next 1/2] netfilter: Fix potential null pointer dereference

It's possible for nf_hook_entry_head to return NULL if two nf_unregister_net_hook calls happen simultaneously with a single hook entry in the list. This fix ensures that no null pointer dereference could occur when such a race happens. Signed-off-by: Aaron Conole <acon...@bytheb.org> --

Re: [PATCH] netfilter: replace list_head with single linked list

Aaron Conole <acon...@bytheb.org> writes: > The netfilter hook list never uses the prev pointer, and so can be trimmed to > be a simple singly-linked list. > > In addition to having a more light weight structure for hook traversal, > struct net becomes 5568 bytes (down

[PATCH] netfilter: replace list_head with single linked list

-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Florian Westphal <f...@strlen.de> --- include/linux/netdevice.h | 2 +- include/linux/netfilter.h | 61 + include/linux/netfilter_ingress.h | 16 +++-- include/net/netfilter/nf_queue.h | 3 +-

[PATCH nf-next v3 5/7] nf_register_net_hook: Only allow sane values

This commit adds an upfront check for sane values to be passed when registering a netfilter hook. This will be used in a future patch for a simplified hook list traversal. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/netfilter/core.c | 5 + 1 file changed, 5 insertions(+)

[PATCH nf-next v3 1/7] netfilter: bridge: add and use br_nf_hook_thresh

u read-side critical section to make a future cleanup simpler. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/netfilter/br_netfilter.h | 6 net/bridge/br_netfilter_hooks.c | 60 ++

[PATCH nf-next v3 2/7] netfilter: call nf_hook_state_init with rcu_read_lock held

ed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/linux/netfilter.h | 8 +++- include/linux/netfilter_ingress.h | 1 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/include/linux/netfilter.h b/include

[PATCH nf-next v3 3/7] netfilter: call nf_hook_ingress with rcu_read_lock

This commit ensures that the rcu read-side lock is held while the ingress hook is called. This ensures that a call to nf_hook_slow (and ultimately nf_ingress) will be read protected. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/core/dev.c | 7 ++- 1 file changed, 6 inse

[PATCH nf-next v3 4/7] nf_hook_slow: Remove explicit rcu_read_lock

All of the callers of nf_hook_slow already hold the rcu_read_lock, so this cleanup removes the recursive call. This is just a cleanup, as the locking code gracefully handles this situation. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/bridge/netfilter/ebt_redirect.c

[PATCH nf-next v3 6/7] nf_queue_handler: whitespace cleanup

A future patch will modify the hook drop and outfn functions. This will cause the line lengths to take up too much space. This is simply a readability change. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/netfilter/nf_queue.h | 8 1 file changed, 4 insertions

[PATCH nf-next v3 0/7] Compact netfilter hooks list

. Previous series can be found at: http://www.spinics.net/lists/netdev/msg386080.html Aaron Conole (5): netfilter: call nf_hook_ingress with rcu_read_lock nf_hook_slow: Remove explicit rcu_read_lock nf_register_net_hook: Only allow sane values nf_queue_handler: whitespace cleanup netfilter

Re: [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

Pablo Neira Ayuso <pa...@netfilter.org> writes: > On Tue, Jul 12, 2016 at 11:32:19AM -0400, Aaron Conole wrote: >> +/* recursively invokes nf_hook_slow (again), skipping already-called >> + * hooks (< NF_BR_PRI_BRNF). >> + * >> + * Called with rcu read lock hel

[PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh

strlen.de> Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/netfilter/br_netfilter.h | 6 net/bridge/br_netfilter_hooks.c | 57 ++-- net/bridge/br_netfilter_ipv6.c | 12 3 files changed, 59 insertions(+), 16 deleti

[PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

From: Florian Westphal <f...@strlen.de> This makes things simpler because we can store the head of the list in the nf_state structure without worrying about concurrent add/delete of hook elements from the list. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Aaron

[PATCH nf-next v2 0/3] Compact netfilter hooks list

and lockdep debugging enabled. Aaron Conole (2): netfilter: bridge: add and use br_nf_hook_thresh netfilter: replace list_head with single linked list Florian Westphal (1): netfilter: call nf_hook_state_init with rcu_read_lock held include/linux/netdevice.h | 2

[PATCH v2 3/3] netfilter: replace list_head with single linked list

-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Florian Westphal <f...@strlen.de> --- v2: * Adjusted the hook list head function, and retested with rcu and lockdep debugging enabled. include/linux/netdevice.h | 2 +- include/linux/netfilter.h | 18 +++

Re: [PATCH nf-next 3/3] netfilter: replace list_head with single linked list

Thanks for this; I will send a v2 in the next two days. -Aaron Florian Westphal <f...@strlen.de> writes: > Aaron Conole <acon...@bytheb.org> wrote: >> --- a/net/netfilter/core.c >> +++ b/net/netfilter/core > [..] >> +#define nf_entry_dereference(e) \

[PATCH nf-next 3/3] netfilter: replace list_head with single linked list

-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Florian Westphal <f...@strlen.de> --- include/linux/netdevice.h | 2 +- include/linux/netfilter.h | 18 +++--- include/linux/netfilter_ingress.h | 14 +++-- include/net/netfilter/nf_queue.h | 9 ++- inclu

[PATCH nf-next 1/3] netfilter: bridge: add and use br_nf_hook_thresh

strlen.de> Signed-off-by: Aaron Conole <acon...@bytheb.org> --- include/net/netfilter/br_netfilter.h | 6 net/bridge/br_netfilter_hooks.c | 57 ++-- net/bridge/br_netfilter_ipv6.c | 12 3 files changed, 59 insertions(+), 16 deleti

[PATCH nf-next 0/3] Compact netfilter hooks list

by Florian Westphal. Aaron Conole (1): netfilter: replace list_head with single linked list Florian Westphal (2): netfilter: bridge: add and use br_nf_hook_thresh netfilter: call nf_hook_state_init with rcu_read_lock held include/linux/netdevice.h | 2 +- include/linux

[PATCH nf-next 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

From: Florian Westphal <f...@strlen.de> This makes things simpler because we can store the head of the list in the nf_state structure without worrying about concurrent add/delete of hook elements from the list. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Aaron

Re: [RFC nf-next 1/3] netfilter: bridge: add and use br_nf_hook_thresh

Aaron Conole <acon...@bytheb.org> writes: > From: Florian Westphal <f...@strlen.de> > > This replaces the last uses of NF_HOOK_THRESH(). > Followup patch will remove it and rename nf_hook_thresh. > > The reason is that inet (non-bridge) netfilter no longer invokes th

[RFC nf-next 3/3] netfilter: replace list_head with single linked list

-off-by: Aaron Conole <acon...@bytheb.org> Signed-off-by: Florian Westphal <f...@strlen.de> --- NOTE: The unregister list code is ugly right now - I will be fixing it to a cleaner version in the next round of submission. include/linux/netdevice.h | 2 +- include/linux

[RFC nf-next 0/3] Compact netfilter hooks list

by Florian Westphal. Aaron Conole (1): netfilter: replace list_head with single linked list Florian Westphal (2): netfilter: bridge: add and use br_nf_hook_thresh netfilter: call nf_hook_state_init with rcu_read_lock held include/linux/netdevice.h | 2 +- include/linux

[RFC nf-next 1/3] netfilter: bridge: add and use br_nf_hook_thresh

strlen.de> Signed-off-by: Aaron Conole <acon...@redhat.com> --- include/net/netfilter/br_netfilter.h | 6 net/bridge/br_netfilter_hooks.c | 57 ++-- net/bridge/br_netfilter_ipv6.c | 12 3 files changed, 59 insertions(+), 16 deleti

[RFC nf-next 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held

From: Florian Westphal <f...@strlen.de> This makes things simpler because we can store the head of the list in the nf_state structure without worrying about concurrent add/delete of hook elements from the list. Signed-off-by: Florian Westphal <f...@strlen.de> Signed-off-by: Aaron

[PATCH -next] virtio_net: Update the feature bit to comply with spec

-by: Aaron Conole <acon...@redhat.com> Suggested-by: "Michael S. Tsirkin" <m...@redhat.com> --- include/uapi/linux/virtio_net.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/virtio_net.h b/include/uapi/linux/virtio_net.h index 1ab4ea6..0da0e3

[PATCH v3] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole <acon...@redhat.com> --- v2->v3: * Added a check for the MTU, and a bit clear for it being out of range. drivers/net/virtio_net.c| 10 ++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/drivers/net/virti

[PATCH v2 -next] virtio-net: Add initial MTU advice feature

-off-by: Aaron Conole <acon...@redhat.com> --- v1->v2: * Fixed omitted hunk from virtio_net.h * Squashed to a single commit * Fixed commit message. drivers/net/virtio_net.c| 7 +++ include/uapi/linux/virtio_net.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/dr

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

kbuild test robot <l...@intel.com> writes: > Hi, > > [auto build test ERROR on next-20160602] > > url: > https://github.com/0day-ci/linux/commits/Aaron-Conole/virtio-net-Advised-MTU-feature/20160603-000714 > config: i386-allmodconfig (attached as .config) > c

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Jun 02, 2016 at 11:43:31AM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper er

Re: [PATCH -next 1/2] virtio: Start feature MTU support

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Thu, Jun 02, 2016 at 11:43:30AM -0400, Aaron Conole wrote: >> This commit adds the feature bit and associated mtu device entry for the >> virtio network device. Future commits will make use of these bits to >

Re: [PATCH -next 2/2] virtio_net: Read the advised MTU

Hi Rick, In the future, please don't cut the list. Rick Jones <rick.jon...@hpe.com> writes: > On 06/02/2016 08:43 AM, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >>

[PATCH -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@redhat.com> --- include/uapi/linux/virtio_net.h | 2 ++ 1 file changed, 2 insertions(+)

[PATCH -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

[PATCH -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@redhat.com> --- drivers/net/virtio_net.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index e0638e5..ef5ee01 100644 --- a/drive

[PATCH v3 -next] net/core/dev: Warn on a too-short GRO frame

From: Aaron Conole <acon...@bytheb.org> When signaling that a GRO frame is ready to be processed, the network stack correctly checks length and aborts processing when a frame is less than 14 bytes. However, such a condition is really indicative of a broken driver, and should be loudly si

[PATCH v2 -next] net/core/dev: Warn on a too-short GRO frame

From: Aaron Conole <acon...@bytheb.org> When signaling that a GRO frame is ready to be processed, the network stack correctly checks length and aborts processing when a frame is less than 14 bytes. However, such a condition is really indicative of a broken driver, and should be loudly si

[RFC v3 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning v3: * Removed the warning when changing MTU (which simplified the code) Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net

[RFC v3 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning v3: * removed the mtu change warning d

[RFC v3 -net 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2,v3: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file c

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

>> >> The second patch adds a user of the bit, and a warning when the guest changes >> the MTU from the hypervisor advised MTU. Future patches may add more thorough >> error handling. >> >> v2: >> * Whitespace and code style cleanups from Sergei Shtylyov and Pa

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: > Hello. > > On 3/16/2016 12:04 AM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No prop

Re: [RFC v2 -next 1/2] virtio: Start feature MTU support

Stephen Hemminger <step...@networkplumber.org> writes: > On Tue, 15 Mar 2016 17:04:12 -0400 > Aaron Conole <acon...@redhat.com> wrote: > >> --- a/include/uapi/linux/virtio_net.h >> +++ b/include/uapi/linux/virtio_net.h >> @@ -55,6 +55,7 @@ >>

Re: [RFC v2 -next 0/2] virtio-net: Advised MTU feature

Rick Jones <rick.jon...@hpe.com> writes: > On 03/15/2016 02:04 PM, Aaron Conole wrote: >> The following series adds the ability for a hypervisor to set an MTU on the >> guest during feature negotiation phase. This is useful for VM orchestration >> when, for inst

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

"Michael S. Tsirkin" <m...@redhat.com> writes: > On Tue, Mar 15, 2016 at 05:04:13PM -0400, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper er

[RFC v2 -next 1/2] virtio: Start feature MTU support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * No change include/uapi/linux/virtio_net.h | 3 +++ 1 file chan

[RFC v2 -next 0/2] virtio-net: Advised MTU feature

: * Whitespace and code style cleanups from Sergei Shtylyov and Paolo Abeni * Additional test before printing a warning Aaron Conole (2): virtio: Start feature MTU support virtio_net: Read the advised MTU drivers/net/virtio_net.c| 12 include/uapi/linux/virtio_net.h | 3 +++ 2

[RFC v2 -next 2/2] virtio_net: Read the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- v2: * Whitespace cleanup in the last hunk * Code style change around the pr_warn * Additional test for mtu change before printing warning drivers/net/virtio_net.c | 12 +

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> writes: > Hello. Hi Sergei, > On 03/10/2016 05:28 PM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >&g

Re: [RFC -next 2/2] virtio_net: Read and use the advised MTU

Paolo Abeni <pab...@redhat.com> writes: > On Thu, 2016-03-10 at 09:28 -0500, Aaron Conole wrote: >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided

[RFC -next 1/2] virtio: Start the advised MTU feature support

This commit adds the feature bit and associated mtu device entry for the virtio network device. Future commits will make use of these bits to support negotiated MTU. Signed-off-by: Aaron Conole <acon...@redhat.com> --- include/uapi/linux/virtio_net.h | 3 +++ 1 file changed, 3 inse

[RFC -next 2/2] virtio_net: Read and use the advised MTU

changes the device MTU after previously being given advice. Signed-off-by: Aaron Conole <acon...@redhat.com> --- drivers/net/virtio_net.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 767ab11..7

[RFC -next 0/2] virtio-net: Advised MTU feature

as described in the proposed VFIO spec addition found at https://lists.oasis-open.org/archives/virtio-dev/201603/msg1.html The second patch adds a user of the bit, and a warning when the guest changes the MTU from the hypervisor advised MTU. Future patches may add more thorough error handling. Aaron

Re: [PATCH next] net/core/dev: Warn on an impossibly short offload frame

Joe Perches <j...@perches.com> writes: > On Sat, 2016-01-02 at 19:25 -0500, Aaron Conole wrote: >> When signaling that a GRO frame is ready to be processed, the network stack >> correctly checks length and aborts processing when a frame is less than 14 >> bytes. However,

[PATCH next] net/core/dev: Warn on an impossibly short offload frame

is today. Convert the condition to use WARN_ON() to ensure that the stack loudly complains about such broken drivers. Signed-off-by: Aaron Conole <acon...@bytheb.org> --- net/core/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev.c b/net/core/dev.c

Re: use-after-free in sctp_do_sm

gt;>>> On 12/03/2015 03:03 PM, Joe Perches wrote: >>>>>>>> On Thu, 2015-12-03 at 14:32 -0500, Jason Baron wrote: >>>>>>>>> On 12/03/2015 01:52 PM, Aaron Conole wrote: >>>>>>>>>> I think that as a minimum, the following

  1   2   >