Re: [PATCH v2 net] bonding: fix 802.3ad state sent to partner when unbinding slave

like Open VSwitch and libreswitch, and >vendor implementations like Arista EOS, seem to disable collecting + >distributing to when doing similar port disabling/detaching/removing change. >With this patch kernel implementation would behave the same way and ensure >partner doesn't consider

Re: [PATCH net] bonding: fix 802.3ad state sent to partner when unbinding slave

(figure 5-15) to exit C_D state and go to ATTACHED state (disabling Coll/Dist). But, either way, as this is a hint to get the link partner to stop using the port, this looks reasonable to me. Acked-by: Jay Vosburgh -J >Signed-off-by: Toni Peltonen >--- > drivers/net/bonding

Re: [PATCH] bonding: fix length of actor system

rams.ad_actor_system), >- >params.ad_actor_system)) >+ ETH_ALEN, >params.ad_actor_system)) > goto nla_put_failure; > } > if (!bond_3ad_get_active_agg_info(bond, )) { > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

Chas Williams <3ch...@gmail.com> wrote: >On 10/25/2018 05:59 PM, Jay Vosburgh wrote: >> Chas Williams <3ch...@gmail.com> wrote: >> >>> netif_is_lag_port should be used to identify link aggregation ports. >>> For this to work, we need to r

Re: [PATCH net-next] net/ipv6: Block IPv6 addrconf on team ports

AVE) >+ if (netif_is_lag_port(dev) || dev->flags & IFF_SLAVE) Note that netvsc_vf_join() also uses IFF_SLAVE in order skip IPv6 addrconf for netvsc devices; I don't believe its usage will pass netif_is_lag_port(). It looks like the above will work, but your commit message mentions eql as the reason for retaining the IFF_SLAVE test, and eql isn't the only user of IFF_SLAVE in this manner. -J > break; > > if (idev && idev->cnf.disable_ipv6) >-- >2.14.4 > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net 02/15] bonding: use netpoll_poll_dev() helper

is for bonding, not team; otherwise LGTM. Acked-by: Jay Vosburgh -J >Signed-off-by: Eric Dumazet >Cc: Jay Vosburgh >Cc: Veaceslav Falico >Cc: Andy Gospodarek >--- > drivers/net/bonding/bond_main.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-)

Re: [PATCH next] bonding: pass link-local packets to bonding master also.

struct sk_buff *nskb = skb_clone(skb, GFP_ATOMIC); >+ >+ if (nskb) { >+ nskb->dev = bond->dev; >+ netif_rx(nskb); >+ } > return RX_HANDLER_PASS; >+ } > if (bond_should_deliver_exact_match(skb, slave, bond)) > return RX_HANDLER_EXACT; > >-- >2.18.0.203.gfac676dfb9-goog --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [BUG] bonded interfaces drop bpdu (stp) frames

Mahesh Bandewar (महेश बंडेवार) wrote: >On Thu, Jul 12, 2018 at 11:03 AM, Jay Vosburgh > wrote: >> Michal Soltys wrote: >> >>>On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >>>> Mahesh Bandewar (महेश बंडेवार) wrote: >>>> >>>>> On We

Re: [BUG] bonded interfaces drop bpdu (stp) frames

Michal Soltys wrote: >On 07/12/2018 04:51 PM, Jay Vosburgh wrote: >> Mahesh Bandewar (महेश बंडेवार) wrote: >> >>> On Wed, Jul 11, 2018 at 3:23 PM, Michal Soltys wrote: >>>> >>>> Hi, >>>> >>>> As weird as that sounds,

Re: [BUG] bonded interfaces drop bpdu (stp) frames

02:18 2017 -0700 bonding: deliver link-local packets with skb->dev set to link that packets arrived on Michal, are you able to revert this patch and test? -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net-next v2 4/4] bonding: allow carrier and link status to determine link state

ptions.c >b/drivers/net/bonding/bond_options.c >index 8a945c9341d6..dba6cef05134 100644 >--- a/drivers/net/bonding/bond_options.c >+++ b/drivers/net/bonding/bond_options.c >@@ -164,9 +164,10 @@ static const struct bond_opt_value >bond_primary_reselect_tbl[] = { > }; > >

Re: [PATCH net-next 4/4] bonding: allow carrier and link status to determine link state

_primary_reselect_tbl[] = { > }; > > static const struct bond_opt_value bond_use_carrier_tbl[] = { >- { "off", 0, 0}, >- { "on", 1, BOND_VALFLAG_DEFAULT}, >- { NULL, -1, 0} >+ { "off", 0, 0}, >+ { "on", 1, BOND_VALFLAG_DEFAULT}, >+ { "both", 2, 0}, >+ { NULL, -1, 0} > }; > > static const struct bond_opt_value bond_all_slaves_active_tbl[] = { >-- >2.17.0 > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net-next 3/4] bonding: allow use of tx hashing in balance-alb

Debabrata Banerjee wrote: >The rx load balancing provided by balance-alb is not mutually >exclusive with using hashing for tx selection, and should provide a decent >speed increase because this eliminates spinlocks and cache contention. > >Signed-off-by: Debabrata Banerjee

Re: [PATCH net-next 2/4] bonding: use common mac addr checks

Banerjee, Debabrata <dbane...@akamai.com> wrote: >> From: Jay Vosburgh [mailto:jay.vosbu...@canonical.com] >> Debabrata Banerjee <dbane...@akamai.com> wrote: > >> >- if >> (!ether_addr

Re: [PATCH net-next 2/4] bonding: use common mac addr checks

Debabrata Banerjee wrote: >Replace homegrown mac addr checks with faster defs from etherdevice.h > >Signed-off-by: Debabrata Banerjee >--- > drivers/net/bonding/bond_alb.c | 28 +--- > 1 file changed, 9 insertions(+), 19

[PATCH v2 net-next] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

uot; VIRTIO_NET_F_STATUS cases, and then the existing call to netif_carrier_on for the "without" case will cause an operstate transition. Cc: "Michael S. Tsirkin" <m...@redhat.com> Cc: Jason Wang <jasow...@redhat.com> Cc: Ben Hutchings <b...@decaden

Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

Michael S. Tsirkin <m...@redhat.com> wrote: >On Thu, Mar 22, 2018 at 12:02:10PM +0000, Jay Vosburgh wrote: >> Michael S. Tsirkin <m...@redhat.com> wrote: >> >> >On Thu, Mar 22, 2018 at 09:05:52AM +, Jay Vosburgh wrote: >> >> Th

Re: [PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

Michael S. Tsirkin <m...@redhat.com> wrote: >On Thu, Mar 22, 2018 at 09:05:52AM +0000, Jay Vosburgh wrote: >> The operstate update logic will leave an interface in the >> default UNKNOWN operstate if the interface carrier state never changes >> from the d

[PATCH net] virtio-net: Fix operstate for virtio when no VIRTIO_NET_F_STATUS

Fixes: 167c25e4c550 ("virtio-net: init link state correctly") Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- I considered resolving this by changing linkwatch_init_dev to unconditionally call rfc2863_policy, as that would always set operstate for all int

[PATCH net] bonding: fix slave stuck in BOND_LINK_FAIL state

ally link up. The remedy for this is to initialize new_link_state on each entry to bond_miimon_inspect, as is already done with new_link. Reported-by: Alex Sidorenko <alexandre.sidore...@hpe.com> Reviewed-by: Jarod Wilson <ja...@redhat.com> Signed-off-by: Jay Vosburgh <jay.vo

Re: Bond recovery from BOND_LINK_FAIL state not working

Jarod Wilson <ja...@redhat.com> wrote: >On 2017-11-02 9:11 PM, Jay Vosburgh wrote: [...] >> diff --git a/drivers/net/bonding/bond_main.c >> b/drivers/net/bonding/bond_main.c >> index 18b58e1376f1..6f89f9981a6c 100644 >> --- a/drivers/net/bonding/bond_ma

Re: Bond recovery from BOND_LINK_FAIL state not working

>bond_alb_handle_active_change >Oct 31 09:09:25 SYDC1LNX kernel: bond0: bond_set_carrier: turning carrier on >Oct 31 09:09:25 SYDC1LNX kernel: bond0: first active interface up! > >Oct 31 09:09:26 SYDC1LNX kernel: bond0: bond_mii_monitor: ens3f0 current link >state: 2 >

Re: Bond recovery from BOND_LINK_FAIL state not working

Alex Sidorenko <alexandre.sidore...@hpe.com> wrote: >On 11/02/2017 12:51 AM, Jay Vosburgh wrote: >> Jarod Wilson <ja...@redhat.com> wrote: >> >>> On 2017-11-01 8:35 PM, Jay Vosburgh wrote: >>>> Jay Vosburgh <jay.vosbu...@canonical.com> wrote:

Re: Bond recovery from BOND_LINK_FAIL state not working

Jarod Wilson <ja...@redhat.com> wrote: >On 2017-11-01 8:35 PM, Jay Vosburgh wrote: >> Jay Vosburgh <jay.vosbu...@canonical.com> wrote: >> >>> Alex Sidorenko <alexandre.sidore...@hpe.com> wrote: >>> >>>> The problem has been

Re: Bond recovery from BOND_LINK_FAIL state not working

Jay Vosburgh <jay.vosbu...@canonical.com> wrote: >Alex Sidorenko <alexandre.sidore...@hpe.com> wrote: > >>The problem has been found while trying to deploy RHEL7 on HPE Synergy >>platform, it is seen both in customer's environment and in HPE test lab. >>

Re: Bond recovery from BOND_LINK_FAIL state not working

sure where this is, but presuming that this is in the BOND_LINK_FAIL case of the switch, it looks like both BOND_LINK_FAIL and BOND_LINK_BACK will have the issue that if the link recovers or fails, respectively, within the delay window (for down/updelay > 0) it won't set a slave->new_link. Looks like this got lost somewhere along the line, as originally the transition back to UP (or DOWN) happened immediately, and that has been lost somewhere. I'll have to dig out when that broke, but I'll see about a test patch this afternoon. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: Regression: Bug 196547 - Since 4.12 - bonding module not working with wireless drivers

hat absolutely should just work. I don't think bonding cares (or should care) about (a) - (c) for this use. Your point (b) suggests that there are use cases other than the above; I'm unfamiliar with any use other than wifi + ethernet, can you elaborate? -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

pointer null"); >return ERROR_CODE >} In general, yes, but in this case, the condition should be impossible to hit, so BUG_ON seems appropriate. If bond_slave_get_rtnl/rcu() returns NULL for an actual bonding slave, other code paths (bond_fill_slave_info, bond_handle_frame) will likely crash before getting to this one. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

as there doesn't appear to be any way to get into bond_option_active_slave_set for a slave prior to bond_enslave registering the rx_handler for that slave, as these operations are mutexed by RTNL. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

if (new_active == old_active) { > /* do nothing */ >-- >2.7.4 > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] Convert multiple netdev_info messages to netdev_dbg

bond->params.arp_interval = 0; >> /* set miimon to default value */ >> bond->params.miimon = BOND_DEFAULT_MIIMON; >> -netdev_info(bond->dev, "Setting MII monitoring interval to >> %d\n", >> +netdev_dbg(bond->dev, "Setting MII monitoring interval to %d\n", >> bond->params.miimon); > >etc... > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: bond link state mismatch, rtnl_trylock() vs rtnl_lock()

/drivers/net/bonding/bond_main.c >@@ -2614,8 +2614,7 @@ static void bond_loadbalance_arp_mon(struct >work_struct *work) >rcu_read_unlock(); > >if (do_failover || slave_state_changed) { >- if (!rtnl_trylock()) >- goto re_arm; >+ rtnl_lock(); > >if (slave_state_changed) { >bond_slave_state_change(bond); > > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net] bonding: avoid defaulting hard_header_len to ETH_HLEN on slave removal

rt P <n...@physik.uzh.ch> >Fixes: 54ef31371407 ("[PATCH] bonding: Handle large hard_header_len") >Fixes: fc791b633515 ("IB/ipoib: move back IB LL address into the hard header") >Signed-off-by: Marcelo Ricardo Leitner <marcelo.leit...@gmail.com> >Signed-off-by

Re: [PATCH net-next v2] bonding: deliver link-local packets with skb->dev set to link that packets arrived on

skb->dev is changed to bonding-master. This >patch changes this behavior for link-local packets by not changing >the skb->dev to the bonding-master and maintaining it as it is, >i.e. the link on which the packet arrived. Minor nit: "looses" should be "lose

Re: [PATCH net-next] bonding: do not pass link-local packets to master-interface

Mahesh Bandewar (महेश बंडेवार) wrote: >On Fri, Apr 14, 2017 at 12:30 PM, Jay Vosburgh ><jay.vosbu...@canonical.com> wrote: >> >> >> Chonggang Li <chonggan...@google.com> wrote: >> >> >Previously link-local packets excluding LACP (which are ha

Re: [PATCH net-next] bonding: do not pass link-local packets to master-interface

not _EXACT, the packet will go through the ptype_base packet handlers, so is the comment strictly correct? -J > if (bond_should_deliver_exact_match(skb, slave, bond)) > return RX_HANDLER_EXACT; > >-- >2.12.2.762.g0e3151a226-goog > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: bond procfs hw addr prints

ddr in its format string. Perhaps that format would be a better choice than %pM for this case? -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH next 0/5] bonding: winter cleanup

he unimplemented "port-moved" state >from the LACP state machine. This state is defined but never set so >removing from the state machine logic makes code little cleaner. > >(d) Reduce scope of some global variables to local. For all patches in the series: Sign

Re: [Patch net] bonding: use ETH_MAX_MTU as max mtu

bond_dev->max_mtu = ETH_MAX_MTU; > bond_dev->netdev_ops = _netdev_ops; > bond_dev->ethtool_ops = _ethtool_ops; Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net-next] net: Remove usage of net_device last_rx member

switch three drivers (sky2, atp and >smc91c92_cs) which actually read and write it to use their own private >copy in netdev_priv. > >Compile-tested with allyesconfig and allmodconfig on x86 and arm. Reviewed-by: Jay Vosburgh <jay.vosbu...@canonical.com>

Re: [PATCH] net: bonding: use new api ethtool_{get|set}_link_ksettings

s = bond_ethtool_get_settings, > .get_link = ethtool_op_get_link, >+ .get_link_ksettings = bond_ethtool_get_link_ksettings, > }; > > static const struct net_device_ops bond_netdev_ops = { >-- >1.7.4.4 --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] bonding: Prevent deletion of a bond, or the last slave from a bond, with active usage.

gt;+ pr_info("%s is being deleted...\n", ifname); >+ unregister_netdevice(bond_dev); >+ } else { >+ pr_err("unable to delete non-existent %s\n", ifname); >+ res = -ENODEV; >+ } >+ rtnl_unlock(); > } else > goto err_no_cmd; > >@@ -139,7 +170,7 @@ static ssize_t bonding_store_bonds(struct class *cls, > return res; > > err_no_cmd: >- pr_err("no command found in bonding_masters - use +ifname or >-ifname\n"); >+ pr_err("no command found in bonding_masters - use +ifname or -ifname or >?-ifname\n"); > return -EPERM; > } > >-- >1.8.3.1 > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] bonding: Allow tun-interfaces as slaves

ac || >+ BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP)) { > /* Set slave to master's mac address. The application already >* set the master's mac address to that of the first slave >*/ >-- >2.1.4 > --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] bonding: Allow tun-interfaces as slaves

Ding Tianhong <dingtianh...@huawei.com> wrote: >On 2016/8/10 7:51, Jay Vosburgh wrote: >> Jörn Engel <jo...@purestorage.com> wrote: >> >>> On Tue, Aug 09, 2016 at 12:06:36PM -0700, David Miller wrote: >>>>> On Tue, Aug 09, 2016 at 09:28:

Re: [PATCH] bonding: Allow tun-interfaces as slaves

nclude/net/bonding.h index 6360c259da6d..ec3442b3aa83 100644 --- a/include/net/bonding.h +++ b/include/net/bonding.h @@ -420,6 +420,7 @@ static inline bool bond_slave_can_tx(struct slave *slave) #define BOND_FOM_NONE 0 #define BOND_FOM_ACTIVE1 #define BOND_FOM_FOLLOW2 +#define BOND_FOM_KEEPMAC 3 #define BOND_ARP_TARGETS_ANY 0 #define BOND_ARP_TARGETS_ALL 1 -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH] bonding: Allow tun-interfaces as slaves

silently loses packets. My tentative suggestion is that we extened fail_over_mac to cover additional modes, as a sort of "I really know what I'm doing" flag, and allow the enslavement to succeed when it is set. This would require setting an additional bonding option for this situation, b

Re: [PATCH net V2] net/bonding: Enforce active-backup policy for IPoIB bonds

ying to copy 20 bytes (IPoIB) device address >to a sockaddr struct that has only 16 bytes of storage. > >Signed-off-by: Mark Bloch <ma...@mellanox.com> >Signed-off-by: Or Gerlitz <ogerl...@mellanox.com> >Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Sign

Re: [PATCH net] net/bonding: Enforce active-backup policy for IPoIB bonds

elds back to the ARPHRD_ETHER related values, then we could have an invalid dereference on the header_ops pointer if something unloads the IB module. -J >> +goto err_undo_flags; >> +} >> + >> +if (!slave_ops->ndo_set_mac_address || >> +

Re: [PATCH] bonding:Fix perfomance drop if one bonding device in configuration is repeatedly restarted

, > arp->mac_dst); Regardless of the description above, this test is insuring that the code doesn't use the broadcast MAC address for the client. Changing it seems like a bad thing to do, as it would cause traffic for the client to be sent to the ethernet broadcast addres

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu <veli-matti.li...@opinsys.fi> wrote: >2016-07-06 0:20 GMT+03:00 Jay Vosburgh <jay.vosbu...@canonical.com>: >> Veli-Matti Lintu <veli-matti.li...@opinsys.fi> wrote: >> >>>2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu <veli-matti.li...@opi

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

Veli-Matti Lintu <veli-matti.li...@opinsys.fi> wrote: >2016-06-30 14:15 GMT+03:00 Veli-Matti Lintu <veli-matti.li...@opinsys.fi>: >> 2016-06-29 18:59 GMT+03:00 Jay Vosburgh <jay.vosbu...@canonical.com>: >>> Veli-Matti Lintu <veli-matti.li...@opinsys.fi>

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

is not available in this mode. > >Is there a way to enable ARP monitor somehow? No, there isn't. ARP monitor is not available in 802.3ad mode. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net] bonding: fix 802.3ad aggregator reselection

links than >the new aggregator. This shouldn't happen. If the active aggregator is just as good as some other aggregator choice, it should stay with the current active. I suspect that both of these are edge cases arising from the aggregators now including link down ports,

[PATCH net] bonding: fix 802.3ad aggregator reselection

insure the correct aggregator is active. Reported-by: Veli-Matti Lintu <veli-matti.li...@opinsys.fi> Fixes: 7bb11dc9f59d ("bonding: unify all places where actor-oper key needs to be updated.") Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- drivers/net/bonding

Re: 802.3ad bonding aggregator reselection

if (active->num_of_ports < bond->params.min_links) { + if (__agg_active_ports(active) < bond->params.min_links) { if (netif_carrier_ok(bond->dev)) { netif_carrier_off(bond->dev); goto out; -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: 802.3ad bonding aggregator reselection

t;sm_vars &= ~AD_PORT_SELECTED; } netdev_dbg(slave->bond->dev, "Port %d changed link status to %s\n", port->actor_port_number, I'll test this locally and will submit a formal patch with an update to bonding.txt tomorrow (if it works). -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: 802.3ad bonding aggregator reselection

esting on a Cisco switch, but I have an HP 2530 now; I'll test it later today or tomorrow and see if it behaves properly, and whether your proposed patch is needed. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

zhuyj <zyjzyj2...@gmail.com> wrote: >On 02/25/2016 09:33 PM, Jay Vosburgh wrote: >> zhuyj <zyjzyj2...@gmail.com> wrote: >> [...] >>> I delved into the source code and Emil's tests. I think that the problem >>> that this patch expects to fix occurs

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

inding a link state change. The performance impact here should be minimal. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH v2 net] bonding: don't use stale speed and duplex information

.@intel.com> >> Cc: Veaceslav Falico <vfal...@gmail.com> >> Cc: dingtianhong <dingtianh...@huawei.com> >> Fixes: 876254ae2758 ("bonding: don't call update_speed_duplex() under >> spinlocks") >> Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com&

Re: Bonding MAC failover behavior with VLAN interfaces

, either, so propagation to VLANs was not a consideration. In your "real" SR-IOV sitation, is there something that necessitates the use of fail_over_mac=active (I don't recall that SR-IOV itself prohibits a VF from changing its MAC address), or is this being done for other reasons? -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

[PATCH v2 net] bonding: don't use stale speed and duplex information

es: 876254ae2758 ("bonding: don't call update_speed_duplex() under spinlocks") Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- v2: Correct Veaceslav's email address Note: The "Fixes" commit is the commit that makes this operation safe again, not the commit

[PATCH net] bonding: don't use stale speed and duplex information

es: 876254ae2758 ("bonding: don't call update_speed_duplex() under spinlocks") Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- Note: The "Fixes" commit is the commit that makes this operation safe again, not the commit that originally introduced the race. I d

Re: [PATCH net v2] bonding: Fix ARP monitor validation

t;> >> Fixes: aeea64ac717a ("bonding: don't trust arp requests unless active slave >> really works") >> Cc: Veaceslav Falico <vfal...@gmail.com> >> Cc: Andy Gospodarek <go...@cumulusnetworks.com> >> Signed-off-by: Jay Vosburgh <jay.vosbu...@cano

Re: bonding reports interface up with 0 Mbps

Jay Vosburgh <jay.vosbu...@canonical.com> wrote: [...] > Thinking about the trace again... Emil: what happens in the >trace before this? Is there ever a call to the ixgbe_get_settings? >Does a NETDEV_UP or NETDEV_CHANGE event ever hit the bond_netdev_event >function?

Re: bonding reports interface up with 0 Mbps

. Once it settles down with carrier up then the speed and duplex should be valid. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: bonding reports interface up with 0 Mbps

ion? Could you describe your test that reproduces this? I'd like to see if I can set it up locally. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH net v2] bonding: Fix ARP monitor validation

ve receives the ARP reply. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: bonding reports interface up with 0 Mbps

BOND_LINK_UP, BOND_SLAVE_NOTIFY_NOW); slave->last_link_up = jiffies; This will make bonding recheck the link state and update the speed and duplex after it acquires RTNL to commit a link change. This probably still h

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: >On 02/03/2016 08:05 PM, Jay Vosburgh wrote: >> Nikolay Aleksandrov <ra...@blackwall.org> wrote: >> >>> From: Nikolay Aleksandrov <niko...@cumulusnetworks.com> >>> >>> Curren

Re: [PATCH net-next] bonding: 3ad: apply ad_actor settings changes immediately

yet (applied to bond device when first slave shows up, and to >slaves at 3ad bind time). After this patch changes are applied immediately >and the new values can be used/seen after the bond's upped so it's not >necessary anymore to release all and enslave again to see the changes. > >C

[PATCH net v2] bonding: Fix ARP monitor validation

s unless active slave really works") Cc: Veaceslav Falico <vfal...@gmail.com> Cc: Andy Gospodarek <go...@cumulusnetworks.com> Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- v2: more detail in log and comment; no code change. drivers/net/bonding/bond_main.c |

Re: bonding (IEEE 802.3ad) not working with qemu/virtio

oes? Creating a magic whitelist of devices deep inside the 802.3ad implementation seems less desirable. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

[PATCH net] bonding: Fix ARP monitor validation

ly for validation on any slave if there is a current ARP slave and it has recently sent an ARP probe. Fixes: aeea64ac717a ("bonding: don't trust arp requests unless active slave really works") Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> --- drivers/net/bonding/bond_main.

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

zhuyj <zyjzyj2...@gmail.com> wrote: >On 01/26/2016 08:43 AM, Jay Vosburgh wrote: >> <zyjzyj2...@gmail.com> wrote: >> >>> From: Zhu Yanjun <zyjzyj2...@gmail.com> >>> >>> Bonding will utilize notifier callbacks to detect slave >>&

Re: [PATCH 1/1] bonding: Use notifiers for slave link state detection

nding. > >Because of link flap from the slave interface, if the notifier >is NETDEV_UP while the actual link state is down, it is not >necessary to continue. > >Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> I haven't signed off on this patch. I've ju

Re: [RFC PATCH net] net/core: don't increment rx_dropped on inactive slaves

C: "David S. Miller" <da...@davemloft.net> >CC: Eric Dumazet <eduma...@google.com> >CC: Jiri Pirko <j...@mellanox.com> >CC: Daniel Borkmann <dan...@iogearbox.net> >CC: Tom Herbert <t...@herbertland.com> >CC: Jay Vosburgh <j.vosbu...@gmail.

Re: [PATCH] net: take care of bonding in build_skb_flow_key (v3)

rina Dubroca <s...@queasysnail.net>'s suggestions from yesterday. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com

Re: [PATCH 1/1] bonding: restrict up state in 802.3ad mode

} >+ } Also, as a functional note on this patch, the above looks like it will spam the log repeatedly every miimon interval for as long as the "carrier up but no speed/duplex" situation persists. -J > switch (slave->link)

Re: [PATCH 1/1] bonding: delay up state without speed and duplex in 802.3ad mode

check_dev_link(struct bonding *bond, > if (!reporting && !netif_running(slave_dev)) > return 0; > >+ /* Check the speed and duplex of the slave device in 802.3ad mode. */ >+ if ((BOND_MODE(bond) == BOND_MODE_8023AD) && >+ !__check_speed_dupl

[PATCH net] bonding: fix panic on non-ARPHRD_ETHER enslave failure

tem will panic when the work function is called. This panic is resolved by calling dev_close on the bond itself prior to calling ether_setup. Cc: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Signed-off-by: Jay Vosburgh <jay.vosbu...@canonical.com> Fixes: 7d5cd2ce5292 (&quo

Re: Regression in bonding driver - devices without set_mac

= BOND_FOM_ACTIVE || - BOND_MODE(bond) != BOND_MODE_ACTIVEBACKUP) { + if (bond->params.fail_over_mac != BOND_FOM_ACTIVE) { /* restore original ("permanent") mac address */ ether_addr_copy(addr.sa_data, slave->perm_hwaddr); addr.sa_

Re: Regression in bonding driver - devices without set_mac

and this fails (because there is no ndo_set_mac). >Is there anything I can do to try and sort this regression out, with you? As I said, I do not believe this is a regression. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line &quo

Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU

IPv6 addrconf on IFF_SLAVE devices was disabled for bonding slaves in commit c2edacf80e15 because it caused issues with snooping switches. This is also referenced in https://bugzilla.redhat.com/show_bug.cgi?id=236750 Won't re-enabling autoconf on IFF_SLAVE devices cause that issu

Re: [PATCH v4] net/bonding: send arp in interval if no active slave

I also wonder if the fail_over_mac option would affect this behavior, as it would cause the slaves to keep their MAC address for the duration, so the switch would not see the MAC move from port to port. Another thought would be to have the curr_arp_slave cycle through the slaves in r

Re: [PATCH] net/bonding: send arp in interval if no active slave

Uwe Koziolek <uwe.kozio...@redknee.com> wrote: >On Tue, Sep 01, 2015 at 05:41 PM +0200, Andy Gospodarek wrote: >> On Mon, Aug 17, 2015 at 10:51:27PM +0200, Uwe Koziolek wrote: >>> On Mon, Aug 17, 2015 at 09:14PM +0200, Jay Vosburgh wrote: >>>> Uwe Kozio

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

and destroy logic. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] net/bonding: send arp in interval if no active slave

no chance to solve the problem. The num_grat_arp is only used, if a different slave is going active. But in our case, the bonding slaves are not going into the state active for a longer time. [jarod: manufacturing of changelog] CC: Jay Vosburgh j.vosbu...@gmail.com CC: Veaceslav Falico vfal

3.14 stable request for net: gso: use feature flag argument in all protocol gso handlers

-by: Florian Westphal f...@strlen.de Signed-off-by: David S. Miller da...@davemloft.net [jay.vosburgh: backported to 3.14. ] Signed-off-by: Jay Vosburgh jay.vosbu...@canonical.com --- net/ipv4/af_inet.c | 2 +- net/ipv4/gre_offload.c | 2 +- net/ipv4/udp.c | 2 +- net/ipv6/ip6_offload.c

Re: [PATCH net] bonding: fix bond dev flags after convert to arphrd_ether

(bond_dev, slave_dev); else { ether_setup(bond_dev); + bond_dev-flags |= IFF_MASTER; bond_dev-priv_flags = ~IFF_TX_SKB_SHARING; } -- 1.9.3 --- -Jay

Stable request for gso feature flag and error handling fixes

. Strictly speaking, with the first place applied the panic is avoided (as the NULL return does not occur), but including the second patch may still be prudent. Thanks, -J --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line

Re: Stable request for gso feature flag and error handling fixes

David Miller da...@davemloft.net wrote: From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue, 07 Jul 2015 17:38:50 -0700 Please consider commit When you ask me to consider commits for -stable you have to tell me what -stable releases you want me to submit them for. Currently I am only

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

GMAIL ranamazh...@gmail.com wrote: Hi Jay, On Friday 03 July 2015 02:12 AM, Jay Vosburgh wrote: [ added netdev to cc ] Mazhar Rana ranamazh...@gmail.com wrote: When primary_reselect is set to failure, primary interface should not become active until current active slave is up

Re: [PATCH v2] bonding: primary_reselect with failure is not working properly

(bond, slave, iter) { if (slave-link == BOND_LINK_UP) --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: Issue with LACP mode in linux bonding driver

Ajith Adapa adapa.aj...@gmail.com wrote: On 26 June 2015 at 07:45, Jay Vosburgh jay.vosbu...@canonical.com wrote: echo 'module bonding =p' /sys/kernel/debug/dynamic_debug/control Hi, thanks for the reply. I tried this out a bit here, and could reproduce the problem on 3.13

Re: Issue with LACP mode in linux bonding driver

aggregator. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Experimental new bonding driver mode=batman

in the kernel source code. It is also not feasible to add pointers in the kernel source code to out-of-tree patches; sorry. -J --- -Jay Vosburgh, jay.vosbu...@canonical.com -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord

Re: [PATCH] bonding: simplify code and get rid of warning

are you getting? -J --- -Jay Vosburgh, IBM Linux Technology Center, [EMAIL PROTECTED] Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- Patch against current 2.6.25 version. --- a/drivers/net/bonding/bond_alb.c 2008-02-18 20:58:53.0 -0800 +++ b/drivers/net/bonding

Re: [Bugme-new] [Bug 9937] New: Bug in bonding driver - Kernel oops whenever driver is loaded with max_bonds parameter

Andrew Morton [EMAIL PROTECTED] wrote: Problem Description: Kernel oops whenever bonding driver with max_bonds=2 (or 2) is loaded ... I believe this is fixed by the following (from linux-2.6): From: Jay Vosburgh [EMAIL PROTECTED] Date: Tue, 29 Jan 2008 18:07:45 -0800 Subject

Re: Null pointer dereference when bringing up bonding device on kernel-2.6.24-2.fc9.i686

Siim Põder [EMAIL PROTECTED] wrote: Jay Vosburgh wrote: Benny Amorsen [EMAIL PROTECTED] wrote: https://bugzilla.redhat.com/show_bug.cgi?id=430391 I know what this is, I'll fix it. do you know when this happend, so we would know which kernel is ok to use (not to start trying blindly

  1   2   3   4   >