RE: [PATCH net-next 2/2] net: stmmac: Add support for DWMAC5 and implement Safety Features

Looking great! -Original Message- From: Jose Abreu [mailto:joab...@synopsys.com] Sent: Thursday, February 1, 2018 2:42 PM To: netdev@vger.kernel.org Cc: Jose Abreu <joab...@synopsys.com>; David S. Miller <da...@davemloft.net>; Joao Pinto <jpi...@synopsys.com>;

Re: [PATCH net-next] net: stmmac: fix broken dma_interrupt handling for multi-queues

Hi Niklas, Às 10:56 PM de 12/7/2017, Niklas Cassel escreveu: > There is nothing that says that number of TX queues == number of RX > queues. E.g. the ARTPEC-6 SoC has 2 TX queues and 1 RX queue. > Yes you are totally right. Our Hardware was configured with 4RX queues and 4TX queues and that

stmmac: issue while performing iperf data flood

Hello to all, I am executing some tests in stmmac regarding its multiple tx queue capability. My setup is routing through queue 0 generic traffic and through queue 2 higher priority traffic. It works fine, but when I execute a data flood using iperf in the TX side, the interface goes down,

Re: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

Hi Peppe, Às 8:09 AM de 7/7/2017, Giuseppe CAVALLARO escreveu: > Hi Joao > > On 7/5/2017 12:34 PM, Joao Pinto wrote: >> Hi Peppe, >> >> Às 8:10 AM de 6/9/2017, Giuseppe CAVALLARO escreveu: >>> Hi Joao >>> >>> On 6/8/2017 8:02 PM, Joao Pinto

Re: [PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

Hi Peppe, Às 8:10 AM de 6/9/2017, Giuseppe CAVALLARO escreveu: > Hi Joao > > On 6/8/2017 8:02 PM, Joao Pinto wrote: >> This patch fixes the description of the DT AVB parameters and gives >> an accurate example. It was also included the base values that were >> u

[PATCH 2/2 net-next] net: stmmac: Improve documentation on AVB parameters

This patch fixes the description of the DT AVB parameters and gives an accurate example. It was also included the base values that were used to get the example' CBS paremeter values. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- Documentation/devicetree/bindings/net/stmmac.tx

[PATCH 1/2 net-next] net: stmmac: fix RX routing function name

This patch fixes the RX packet routing function name in dwmac4_core. It also calls the correct dwmac4_core callback for the routing configuration purpose. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 6 +++--- drivers/net/et

Re: mlx5 endpoint driver problem

Hi again Saeed, Às 6:44 PM de 5/9/2017, Saeed Mahameed escreveu: > On Tue, May 9, 2017 at 8:38 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> Hi Saeed, >> >> Às 6:35 PM de 5/9/2017, Saeed Mahameed escreveu: >>> On Tue, May 9, 2017 at 7:25 PM, Joao P

Re: mlx5 endpoint driver problem

Hi Saeed, Às 6:35 PM de 5/9/2017, Saeed Mahameed escreveu: > On Tue, May 9, 2017 at 7:25 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> Hello, >> >> I am making tests with a Mellanox MLX5 Endpoint, and I am getting kernel >> hangs >> when trying to

mlx5 endpoint driver problem

Hello, I am making tests with a Mellanox MLX5 Endpoint, and I am getting kernel hangs when trying to enable the hca: mlx5_core :01:00.0: enabling device ( -> 0002) mlx5_core :01:00.0: Warning: couldn't set 64-bit PCI DMA mask mlx5_core :01:00.0: Warning: couldn't set 64-bit

Re: [PATCH v1 4/4] stmmac: pci: split out common_default_data() helper

lter_bins = HASH_TABLE_SIZE; > - > - /* Set default value for unicast filter entries */ > - plat->unicast_filter_entries = 1; > - > - /* Set the maxmtu to a default of JUMBO_LEN */ > - plat->maxmtu = JUMBO_LEN; > - > - /* Set default number of RX and TX queues to use */ > - plat->tx_queues_to_use = 1; > - plat->rx_queues_to_use = 1; > - > - /* Disable Priority config by default */ > - plat->tx_queues_cfg[0].use_prio = false; > - plat->rx_queues_cfg[0].use_prio = false; > - > - /* Disable RX queues routing by default */ > - plat->rx_queues_cfg[0].pkt_route = 0x0; > - > return 0; > } > > Makes sense! Acked-by: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v1 3/4] stmmac: pci: RX queue routing configuration

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > The commit abe80fdc6ee6 > > ("net: stmmac: RX queue routing configuration") > > missed Intel Quark configuration. Append it here. > > Fixes: abe80fdc6ee6 ("net: stmmac: RX queue routing confi

Re: [PATCH v1 2/4] stmmac: pci: TX and RX queue priority configuration

Às 3:14 PM de 5/8/2017, Andy Shevchenko escreveu: > The commit a8f5102af2a7 > > ("net: stmmac: TX and RX queue priority configuration") > > missed Intel Quark configuration. Append it here. > > Fixes: a8f5102af2a7 ("net: stmmac: TX and RX queue prior

Re: [PATCH v1 1/4] stmmac: pci: set default number of rx and tx queues

t default number of rx and tx queues in > stmmac_pci") > Cc: Joao Pinto <joao.pi...@synopsys.com> > Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 4 > 1 file changed, 4 insertions(+)

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

Às 12:56 PM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 2:40 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 1:42 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

Às 12:34 PM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 1:42 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 12:54 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

Às 11:12 AM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 12:54 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> Hi Andy and Jan, >> >> Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: >>> On Mon, May 8, 2017 at 9:56 AM, Jan Kiszka <jan.

Re: [PATCH v3 net-next 01/11] net: stmmac: prepare dma op mode config for multiple queues

Hi Andy and Jan, Às 10:36 AM de 5/8/2017, Andy Shevchenko escreveu: > On Mon, May 8, 2017 at 9:56 AM, Jan Kiszka <jan.kis...@siemens.com> wrote: >> On 2017-03-15 12:04, Joao Pinto wrote: >>> This patch prepares DMA Operation Mode configuration for multiple queues

Re: [PATCH net-next v3] bindings: net: stmmac: add missing note about LPI interrupt

= <0xe080 0x8000>; > interrupt-parent = <>; > - interrupts = <24 23>; > - interrupt-names = "macirq", "eth_wake_irq"; > + interrupts = <24 23 22>; > + interrupt-names = "macirq", "eth_wake_irq", "eth_lpi"; > mac-address = []; /* Filled in by U-Boot */ > max-frame-size = <3800>; > phy-mode = "gmii"; > Acked-By: Joao Pinto <jpi...@synopsys.com> Regards!

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Hi Florian, Às 6:43 PM de 4/12/2017, Florian Fainelli escreveu: > On 04/12/2017 07:58 AM, Andrew Lunn wrote: >> On Wed, Apr 12, 2017 at 01:07:02PM +0100, Joao Pinto wrote: >>> Hi Andrew, >>> >>> Às 12:56 PM de 4/12/2017, Andrew Lunn escreveu: >>>>

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Às 4:28 PM de 4/12/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Wed, 12 Apr 2017 16:13:33 +0100 > >> Às 3:51 PM de 4/12/2017, David Miller escreveu: >>> You cannot develop performance based features and only test their >>&g

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Hello, Às 3:51 PM de 4/12/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Wed, 12 Apr 2017 14:55:03 +0100 > >> Understand your point, but for now our development and testing setup will be >> based on the IP Prototyping Kit,

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Às 2:52 PM de 4/12/2017, Andrew Lunn escreveu: My setup is FPGA based, so it will have lower performance values. Iperf results with "Drop Transmit Status" set: ~650Mbps. "Drop Transmit Status" unset: ~450Mbps. >>> >>> What percentage of your customers use FPGAs? When i look

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Às 2:10 PM de 4/12/2017, Andrew Lunn escreveu: +- snps,drop-tx-status: this enables drop tx status >>> >>> Hi Joao >>> >>> Was the conclusion from testing that this cannot be turned on by >>> default? >> >> This feature is great for applications that need good performance, but has a >>

Re: [PATCH v2 net-next] net: stmmac: add drop transmit status feature

Hi Andrew, Às 12:56 PM de 4/12/2017, Andrew Lunn escreveu: > On Wed, Apr 12, 2017 at 10:26:20AM +0100, Joao Pinto wrote: >> When the Drop Transmit Status bit is set, the Tx packet status >> received from the MAC is dropped in the MTL. When this bit is reset, >> the Tx packet

[PATCH v2 net-next] net: stmmac: add drop transmit status feature

When the Drop Transmit Status bit is set, the Tx packet status received from the MAC is dropped in the MTL. When this bit is reset, the Tx packet status received from the MAC is forwarded to the application. This feature will cause a performance improvement. Signed-off-by: Joao Pinto <

Re: [PATCH] net: stmmac: add drop transmit status feature

Hi Andrew, Às 4:04 PM de 4/11/2017, Andrew Lunn escreveu: > On Tue, Apr 11, 2017 at 03:44:10PM +0100, Joao Pinto wrote: >> When the Drop Transmit Status bit is set, the Tx packet status >> received from the MAC is dropped in the MTL. When this bit is reset, >> the Tx packet

[PATCH] net: stmmac: add drop transmit status feature

When the Drop Transmit Status bit is set, the Tx packet status received from the MAC is dropped in the MTL. When this bit is reset, the Tx packet status received from the MAC is forwarded to the application. This feature will cause a performance improvement. Signed-off-by: Joao Pinto <

Re: [PATCH net-next] net: stmmac: set total length of the packet to be transmitted in TDES3

Hi Niklas, Às 7:33 PM de 4/10/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > Field FL/TPL in register TDES3 is not correctly set on GMAC4. > TX appears to be functional on GMAC 4.10a even if this field is not set, > however, to avoid relying on undefined

Suggestion: Merge of sxgbe to stmmac

Dear Byungho, Girish and David, Today I was requested to analyse the Synopsys XGMAC IP support in the Linux kernel and I found AMD' xgbe and Samsung's sxgbe drivers. Samsung' driver has the same architecture as stmmac, so I am sending this e-mail to suggest the merge of sxgbe to stmmac.

[PATCH] net: stmmac: use netif_set_real_num_{rx,tx}_queues

In the submission of the lastest multiple buffer patch set, this fix was lost. I am sending this patch to put it right again. The fix was originally proposed by Arnd Bergmann. Signed-off-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/

[PATCH 3/4 v3 net-next] net: stmmac: adding multiple buffers for TX

This patch adds the structure stmmac_tx_queue which contains tx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v1->v3: - just to keep up with patch-set version drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 38 +- dr

[PATCH 4/4 v3 net-next] net: stmmac: adding multiple napi mechanism

This patch adds the napi variable to the stmmac_rx_queue structure and forces that operations like netif_queue_stopped, netif_wake_queue, netif_stop_queue, netdev_reset_queue and netdev_sent_queue be made by queue. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v2->v3: - jus

[PATCH 0/4 v3 net-next] net: stmmac: adding multiple buffers

This patch adds multiple buffers to stmmac in a more fragmented way, in order to make problem debug easier. I would kindly request to people to test this patch in their HWs in order to check if everything's functional. Thank you. Joao Pinto (4): net: stmmac: break some functions into RX and TX

[PATCH 1/4 v3 net-next] net: stmmac: break some functions into RX and TX scopes

This patch breaks several functions into RX and TX scopes, which will be useful when adding multiple buffers mechanism. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v2->v3: - just to keep up with patch-set version changes v1->v2: - RX and TX inconsistency - stmmac_fre

[PATCH 2/4 v3 net-next] net: stmmac: adding multiple buffers for rx

This patch adds the structure stmmac_rx_queue which contains rx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v2->v3: - fixed infinite loop in err_init_rx_buffers error handling changes v1->v2: - %d replaced by %u w

Re: [PATCH 0/4 v2 net-next] net: stmmac: adding multiple buffers

Às 5:59 PM de 4/5/2017, Corentin Labbe escreveu: > On Wed, Apr 05, 2017 at 05:43:00PM +0100, Joao Pinto wrote: >> This patch adds multiple buffers to stmmac in a more fragmented >> way, in order to make problem debug easier. >> >> I would kindly request to people to t

Re: [PATCH 2/4 v2 net-next] net: stmmac: adding multiple buffers for RX (fwd)

o_kx0=SF-IM8g8b7VBN_AjT6JxdRBYkTu-2huMLcFlVh_4YKw=q4A5_6A5zp5DRgmx5IJbDiIpc2W3GK3tSNhqpyIaHX8= > > git remote update linux-review > git checkout b403b5806dca0f85904ddc6cf2241286da86ed9b > vim +1190 drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > > b6ad2502 Joao

[PATCH 2/4 v2 net-next] net: stmmac: adding multiple buffers for RX

This patch adds the structure stmmac_rx_queue which contains rx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v1->v2: - %d replaced by %u when printing unsigned - err_init_rx_buffers treatment fixed drivers/net/etherne

[PATCH 1/4 v2 net-next] net: stmmac: break some functions into RX and TX scopes

This patch breaks several functions into RX and TX scopes, which will be useful when adding multiple buffers mechanism. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v1->v2: - RX and TX inconsistency - stmmac_free_rx_buffers renamed to stmmac_free_rx_buffer - stmmac_free_t

[PATCH 4/4 v2 net-next] net: stmmac: adding multiple napi mechanism

This patch adds the napi variable to the stmmac_rx_queue structure and forces that operations like netif_queue_stopped, netif_wake_queue, netif_stop_queue, netdev_reset_queue and netdev_sent_queue be made by queue. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes

[PATCH 3/4 v2 net-next] net: stmmac: adding multiple buffers for TX

This patch adds the structure stmmac_tx_queue which contains tx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v1->v2: - just to keep up with patch-set version drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 38 +- dr

[PATCH 0/4 v2 net-next] net: stmmac: adding multiple buffers

This patch adds multiple buffers to stmmac in a more fragmented way, in order to make problem debug easier. I would kindly request to people to test this patch in their HWs in order to check if everything's functional. Thank you. Joao Pinto (4): net: stmmac: break some functions into RX and TX

Re: [PATCH 1/4] net: stmmac: break some functions into RX and TX scopes

Hi Thierry, Às 7:57 PM de 4/4/2017, Thierry Reding escreveu: > On Tue, Apr 04, 2017 at 06:54:24PM +0100, Joao Pinto wrote: >> This patch breaks several functions into RX and TX scopes, which >> will be useful when adding multiple buffers mechanism. >> >> Sig

[PATCH 0/4 net-next] net: stmmac: adding multiple buffers

This patch adds multiple buffers to stmmac in a more fragmented way, in order to make problem debug easier. I would kindly request to people to test this patch in their HWs in order to check if everything's functional. Thank you. Joao Pinto (4): net: stmmac: break some functions into RX and TX

[PATCH 3/4] net: stmmac: adding multiple buffers for TX

This patch adds the structure stmmac_tx_queue which contains tx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 38 +- drivers/net/ethernet/stmicro/stmmac/ring_mode.c | 46 +- d

[PATCH 2/4] net: stmmac: adding multiple buffers for rx

This patch adds the structure stmmac_rx_queue which contains rx queues specific data (previously in stmmac_priv). Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/chain_mode.c | 7 +- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 26 +- d

[PATCH 1/4] net: stmmac: break some functions into RX and TX scopes

This patch breaks several functions into RX and TX scopes, which will be useful when adding multiple buffers mechanism. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 350 +- 1 file changed, 268 insertions(

[PATCH 4/4] net: stmmac: adding multiple napi mechanism

This patch adds the napi variable to the stmmac_rx_queue structure and forces that operations like netif_queue_stopped, netif_wake_queue, netif_stop_queue, netdev_reset_queue and netdev_sent_queue be made by queue. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/s

[PATCH net-next] net: stmmac: rx queue to dma channel mapping fix

In hardware configurations where multiple queues are active, the rx queue needs to be mapped into a dma channel, even if a single rx queue is used. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Hello Peppe, Às 2:07 PM de 4/3/2017, Giuseppe CAVALLARO escreveu: > Hello Joao > > On 3/30/2017 6:42 PM, Joao Pinto wrote: >> Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: >>> On 03/30/2017 04:34 PM, Thierry Reding wrote: >>>> On Thu, Mar 30, 2017 at 09

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:57 PM de 3/31/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Fri, 31 Mar 2017 11:43:38 +0100 > >> @David: Could you please create a branch in your git tree for us to work on >> it >> until the multiple buffers get stable f

[PATCH] net: stmmac: fix cbs configuration

sel <niklas.cas...@axis.com> Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- Documentation/devicetree/bindings/net/stmmac.txt | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetr

Re: stmmac CBS configuration for TX AVB queue

Às 10:59 AM de 3/31/2017, Niklas Cassel escreveu: > Hello Joao > > > I was looking at > > commit 19d9187317979cf0c25f67017d2676149abc46b2 > Author: Joao Pinto <joao.pi...@synopsys.com> > Date: Fri Mar 10 18:24:59 2017 + > > net: stmmac: configurat

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 11:14 AM de 3/31/2017, Joao Pinto escreveu: > Às 6:48 PM de 3/30/2017, David Miller escreveu: >> From: Thierry Reding <tred...@nvidia.com> >> Date: Thu, 30 Mar 2017 16:34:36 +0200 >> >>> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 6:48 PM de 3/30/2017, David Miller escreveu: > From: Thierry Reding > Date: Thu, 30 Mar 2017 16:34:36 +0200 > >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann

Re: [PATCH] [net-next] stmmac: use netif_set_real_num_{rx,tx}_queues

Às 5:35 PM de 3/30/2017, Niklas Cassel escreveu: > On 03/30/2017 04:34 PM, Thierry Reding wrote: >> On Thu, Mar 30, 2017 at 09:45:36AM +0200, Corentin Labbe wrote: >>> On Tue, Mar 28, 2017 at 06:01:05PM -0700, David Miller wrote: From: Arnd Bergmann Date: Tue, 28 Mar 2017

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 6:28 PM de 3/27/2017, David Miller escreveu: > From: Corentin Labbe <clabbe.montj...@gmail.com> > Date: Mon, 27 Mar 2017 19:00:58 +0200 > >> On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: >>> Hi David, >>> >>> Às 7:26 AM de 3/25/20

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 6:00 PM de 3/27/2017, Corentin Labbe escreveu: > On Mon, Mar 27, 2017 at 04:26:48PM +0100, Joao Pinto wrote: >> Hi David, >> >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >>> On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: >>>>

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Hi David, Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > On Fri, Mar 24, 2017 at 05:16:45PM +0000, Joao Pinto wrote: >> For cores that have more than 1 TX queue configured, the kernel would crash, >> since only one TX queue is permitted by default. >> >> Sig

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Hin Thierry, Às 2:34 PM de 3/27/2017, Joao Pinto escreveu: > Às 2:28 PM de 3/27/2017, Niklas Cassel escreveu: >> >> >> On 03/27/2017 11:12 AM, Joao Pinto wrote: >>> Às 10:09 AM de 3/27/2017, Corentin Labbe escreveu: >>>> On Mon, Mar 27, 2017 at 10:04:5

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 2:28 PM de 3/27/2017, Niklas Cassel escreveu: > > > On 03/27/2017 11:12 AM, Joao Pinto wrote: >> Às 10:09 AM de 3/27/2017, Corentin Labbe escreveu: >>> On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: >>>> Às 7:26 AM de 3/25/2017, Corentin Labbe

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Às 10:28 AM de 3/27/2017, Alexandre Torgue escreveu: > Hi Joao > > On 03/24/2017 06:09 PM, Joao Pinto wrote: >> >> Hello David, >> >> Às 5:05 PM de 3/24/2017, David Miller escreveu: >>> From: Andrew Lunn <and...@lunn.ch> >>> Dat

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 10:09 AM de 3/27/2017, Corentin Labbe escreveu: > On Mon, Mar 27, 2017 at 10:04:57AM +0100, Joao Pinto wrote: >> Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: >>> On Fri, Mar 24, 2017 at 05:16:45PM +, Joao Pinto wrote: >>>> For cores that have more than 1 T

Re: [PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

Às 7:26 AM de 3/25/2017, Corentin Labbe escreveu: > On Fri, Mar 24, 2017 at 05:16:45PM +0000, Joao Pinto wrote: >> For cores that have more than 1 TX queue configured, the kernel would crash, >> since only one TX queue is permitted by default. >> >> Signed-off-by: Joao

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Às 5:17 PM de 3/24/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Fri, 24 Mar 2017 15:02:27 + > >> Yes, I agree, it is better to revert and leave the tree functional for all. >> >> @David Miller: >> The multiple-buffer

[PATCH net-next 0/2] net: stmmac: multiple queue fixes

This patch set contains two fixes for problems I detected when ran the driver in single queue mode. Please test in your setups to check if you get better results. Joao Pinto (2): net: stmmac: fix netdev release net: stmmac: fix number of tx queues in stmmac_poll drivers/net/ethernet

[PATCH net-next 2/2] net: stmmac: fix number of tx queues in stmmac_poll

For cores that have more than 1 TX queue configured, the kernel would crash, since only one TX queue is permitted by default. Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next 1/2] net: stmmac: fix netdev release

This patch fixes the kernel crash problem that happens when the driver exits. The dma resouces must be freed after netdev resouces get freed and in driver removed, multiple napi's should be deleted before removing netdev resouces or it will hang. Signed-off-by: Joao Pinto <jpi...@synopsys.

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Hello David, Às 5:05 PM de 3/24/2017, David Miller escreveu: > From: Andrew Lunn > Date: Fri, 24 Mar 2017 12:17:36 +0100 > >>> Yes it would be fantastic to have a set of boards, but I rarely see this in >>> any >>> maintainer :). >> >> Being a Marvell SoC and switch

Fwd: Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Sorry, sending again with David Miller in TO: instead of CC. Às 2:09 PM de 3/24/2017, Corentin Labbe escreveu: > On Thu, Mar 23, 2017 at 07:10:59PM +0100, Thierry Reding wrote: >> On Thu, Mar 23, 2017 at 05:27:08PM +0000, Joao Pinto wrote: >>> Hi Thierry, >>> >

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Às 2:09 PM de 3/24/2017, Corentin Labbe escreveu: > On Thu, Mar 23, 2017 at 07:10:59PM +0100, Thierry Reding wrote: >> On Thu, Mar 23, 2017 at 05:27:08PM +0000, Joao Pinto wrote: >>> Hi Thierry, >>> >> >> Yes, I can submit a patch for that. >> >>

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Às 11:17 AM de 3/24/2017, Andrew Lunn escreveu: >> Yes it would be fantastic to have a set of boards, but I rarely see this in >> any >> maintainer :). > > Being a Marvell SoC and switch maintainer, i have around a dozen > boards. Some i got some simply by asking the manufacture, others i >

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Hi Andrew, Às 7:42 AM de 3/24/2017, Andrew Lunn escreveu: > On Thu, Mar 23, 2017 at 05:27:08PM +0000, Joao Pinto wrote: > >> Yes, you are correct. It should be priv->plat->tx_queues_to_use instead of >> "u32 >> tx_count = priv->dma_cap.number_tx_queues;&q

Re: [v2,net-next,1/3] net: stmmac: enable multiple buffers

Hi Thierry, Às 5:17 PM de 3/23/2017, Thierry Reding escreveu: > On Fri, Mar 17, 2017 at 04:11:05PM +0000, Joao Pinto wrote: >> This patch creates 2 new structures (stmmac_tx_queue and stmmac_rx_queue) >> in include/linux/stmmac.h, enabling that each RX and TX queue has its >>

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Às 10:56 AM de 3/23/2017, Joao Pinto escreveu: > Às 10:51 AM de 3/23/2017, Giuseppe CAVALLARO escreveu: >> On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote: >>> Hello >>> >>> On 3/23/2017 11:20 AM, Corentin Labbe wrote: >>>>> I have a 4.21 Q

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Às 10:51 AM de 3/23/2017, Giuseppe CAVALLARO escreveu: > On 3/23/2017 11:48 AM, Giuseppe CAVALLARO wrote: >> Hello >> >> On 3/23/2017 11:20 AM, Corentin Labbe wrote: I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >Could you please share the iperf cmds you are using

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hi Peppe, Às 10:48 AM de 3/23/2017, Giuseppe CAVALLARO escreveu: > Hello > > On 3/23/2017 11:20 AM, Corentin Labbe wrote: >>> I have a 4.21 QoS Core with 4 RX + 4 TX and detected no regression. >>> >Could you please share the iperf cmds you are using in order for me to >>> reproduce >>> >in my

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Às 10:20 AM de 3/23/2017, Corentin Labbe escreveu: > On Thu, Mar 23, 2017 at 10:12:18AM +0000, Joao Pinto wrote: >> >> Hi Corentin, >> >> Às 10:08 AM de 3/23/2017, Corentin Labbe escreveu: >>> Hello >>> >>> Using next-20170323 produce

Re: stmmac: Performance regression after commit aff3d9eff843 "net: stmmac: enable multiple buffers"

Hi Corentin, Às 10:08 AM de 3/23/2017, Corentin Labbe escreveu: > Hello > > Using next-20170323 produce a huge performance regression on my sunxi boards. > On dwmac-sun8i, iperf goes from 94mbs/s to 37 when sending. > > On cubieboard2(dwmac-sunxi), iperf made the kernel flood with >

[PATCH v3 net-next] net: stmmac: fix dma operation mode config for older versions

ntj...@gmail.com> Reviewed-by: Thierry Reding <thierry.red...@gmail.com> Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- changes v2->v3: - Commit ID and title should be under a 'Fixes' tag changes v1->v2: - commit id did not have 12 digits drivers/net/ethernet/stmicro/st

Re: [PATCH v2 net-next] net: fix dma operation mode config for older versions

Às 6:56 PM de 3/21/2017, Florian Fainelli escreveu: > On 03/21/2017 11:02 AM, Joao Pinto wrote: >> This patch fixes a bug introduced in: >> commit 6deee2221e11 ("net: stmmac: prepare dma op mode config for multiple >> queues") > > So even though this is again

Re: [PATCH net-next] net: fix dma operation mode config for older versions

Às 5:53 PM de 3/21/2017, Sergei Shtylyov escreveu: > On 03/21/2017 08:36 PM, Joao Pinto wrote: > >> This patch fixes a bug introduced in commit: >> 6deee22 (net: stmmac: prepare dma op mode config for multiple queues) > >Need 12 hex digits and the

[PATCH v2 net-next] net: fix dma operation mode config for older versions

00. Reported-by: Corentin Labbe <clabbe.montj...@gmail.com> Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/dri

[PATCH net-next] net: fix dma operation mode config for older versions

tin Labbe <clabbe.montj...@gmail.com> Signed-off-by: Joao Pinto <jpi...@synopsys.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 4:50 PM de 3/21/2017, Joao Pinto escreveu: > Às 4:42 PM de 3/21/2017, Thierry Reding escreveu: >> On Tue, Mar 21, 2017 at 03:23:00PM +0000, Joao Pinto wrote: >>> Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: >>>> From: Thierry Reding <tred...@nvidia.com>

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 4:42 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 03:23:00PM +0000, Joao Pinto wrote: >> Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: >>> From: Thierry Reding <tred...@nvidia.com> >>> >>> Prior to the recent mult

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: > From: Thierry Reding > > Prior to the recent multi-queue changes the driver would configure the > queues to use the AVB mode, but the mode then got switched to DCB. The > hardware still works fine in DCB mode, but my testing

Re: [PATCH 2/3] net: stmmac: Restore DT backwards-compatibility

* snps,mtl-rx-config or snps,mtl-tx-config properties, we fall back > + * to one RX and TX queues each. > + */ > + plat->rx_queues_to_use = 1; > + plat->tx_queues_to_use = 1; > + > rx_node = of_parse_phandle(pdev->dev.of_node, "snps,mtl-rx-config", 0); > if (!rx_node) > return; > Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH 1/3] net: stmmac: Always enable MAC RX queues

needs the enable operation. >>> But came to my attention a setup that has 1 RX queue and 2 TX queues, which enables multiple queues mechanism inside the core (even with 1 RX) and so RX needs to be enabled. Because of that I agree with this patch. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hi Peppe, Às 2:39 PM de 3/21/2017, Giuseppe CAVALLARO escreveu: > Hello Corentin > > yes, bisect process is really good approach to me. Pls give us more details. > Recently the multi DMA channel logic has been added so it could be that > something is needed to allow your platform to manage the

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

Às 2:33 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 02:25:15PM +0000, Joao Pinto wrote: >> Às 2:23 PM de 3/21/2017, Corentin Labbe escreveu: >>> On Tue, Mar 21, 2017 at 02:10:47PM +, Joao Pinto wrote: >>>> ++Adding Corentin >>>

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

Às 2:23 PM de 3/21/2017, Corentin Labbe escreveu: > On Tue, Mar 21, 2017 at 02:10:47PM +0000, Joao Pinto wrote: >> ++Adding Corentin >> >> Às 2:08 PM de 3/21/2017, Thierry Reding escreveu: >>> On Tue, Mar 21, 2017 at 01:58:36PM +, Joao Pinto wrote: >>>>

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

Às 2:08 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 01:58:36PM +0000, Joao Pinto wrote: >> Às 12:24 PM de 3/21/2017, Thierry Reding escreveu: >>> On Tue, Mar 21, 2017 at 12:02:03PM +, Joao Pinto wrote: >>>> Às 11:58 AM de 3/21/2017, Thierry

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

++Adding Corentin Às 2:08 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 01:58:36PM +0000, Joao Pinto wrote: >> Às 12:24 PM de 3/21/2017, Thierry Reding escreveu: >>> On Tue, Mar 21, 2017 at 12:02:03PM +, Joao Pinto wrote: >>>> Às 11:58 A

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

Às 12:24 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 12:02:03PM +0000, Joao Pinto wrote: >> Às 11:58 AM de 3/21/2017, Thierry Reding escreveu: >>> On Fri, Mar 10, 2017 at 06:24:52PM +, Joao Pinto wrote: >>>> This patch adds the R

Re: [v5,net-next,2/9] net: stmmac: configure mtl rx and tx algorithms

Às 11:58 AM de 3/21/2017, Thierry Reding escreveu: > On Fri, Mar 10, 2017 at 06:24:52PM +0000, Joao Pinto wrote: >> This patch adds the RX and TX scheduling algorithms programming. >> It introduces the multiple queues configuration function >> (stmmac_mtl_configur

Re: [v5,net-next,1/9] net: stmmac: multiple queues dt configuration

Hi Thierry, Às 11:32 AM de 3/21/2017, Thierry Reding escreveu: > On Fri, Mar 10, 2017 at 06:24:51PM +0000, Joao Pinto wrote: >> This patch adds the multiple queues configuration in the Device Tree. >> It was also created a set of structures to keep the RX and TX queues &g

Re: linux-next-20170320 breaks stmmac on meson (Amlogic S905GXBB)

Hi Heiner and Corentin, Às 9:58 PM de 3/20/2017, Heiner Kallweit escreveu: > As reported by Corentin Labbe before: > stmmac in the latest next kernel is broken also on meson8b. > > The following commit seems to create the trouble: > 6deee2221e11 "net: stmmac: prepare dma op mode config for

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:44 PM de 3/20/2017, Niklas Cassel escreveu: > On 03/20/2017 06:42 PM, Joao Pinto wrote: >> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >>> From: Niklas Cassel <niklas.cas...@axis.com> >>> >>> It is usually possible to do >>> ethtool -s a

  1   2   3   4   >