Re: [net-next 12/12] igc: Clean up code

On Wed, 2018-11-07 at 14:48 -0800, Jeff Kirsher wrote: > From: Sasha Neftin > > Address few community comments. > Remove unused code, will be added per demand. > Remove blank lines and unneeded includes. > > Signed-off-by: Sasha Neftin > Tested-by: Aaron Brown > Signed-off-by: Jeff Kirsher >

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

On Tue, 2018-10-30 at 09:21 +0800, tanhuazhong wrote: > > On 2018/10/30 1:44, Joe Perches wrote: > > On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: > > > When hns3_nic_init_vector_data() fails to map ring to vector, > > > it should cancel the netif_napi_ad

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

On Mon, 2018-10-29 at 21:54 +0800, Huazhong Tan wrote: > When hns3_nic_init_vector_data() fails to map ring to vector, > it should cancel the netif_napi_add() that has been successfully > done and then exits. [] > diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c >

Re: [PATCH v2] rtlwifi: remove set but not used variable 'radiob_array_table' and 'radiob_arraylen'

On Tue, 2018-10-23 at 16:28 +0800, zhong jiang wrote: > radiob_array_table' and 'radiob_arraylen' are not used after setting its > value. > It is safe to remove the unused variable. Meanwhile, radio B radio should be > removed as well. because it will no longer be referenced. The patch subject

Re: [PATCH v7 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver

On Sat, 2018-10-06 at 11:36 +0530, sunil.kovv...@gmail.com wrote: > Added maintainers entry for Marvell OcteonTX2 SOC's RVU > admin function driver. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -8844,6 +8844,15 @@ S: Supported > F: drivers/mmc/host/sdhci-xenon* > F:

Re: any reason for "!!netif_carrier_ok" and "!!netif_dormant" in net-sysfs.c?

On Mon, 2018-08-27 at 12:16 -0400, rpj...@crashcourse.ca wrote: > Quoting David Miller : > > > From: "Robert P. J. Day" > > Date: Mon, 27 Aug 2018 04:55:29 -0400 (EDT) > > > > > another pedantic oddity -- is there a reason for these two double > > > negations in net/core/net-sysfs.c? > > > >

Re: [net 01/11] ixgb: use dma_zalloc_coherent instead of allocator/memset

On Fri, 2018-08-24 at 11:47 -0700, Jeff Kirsher wrote: > From: YueHaibing > > Use dma_zalloc_coherent instead of dma_alloc_coherent > followed by memset 0. Unrelated trivia: above this, perhaps the size = sizeof(struct ixgb_buffer) * txdr->count; txdr->buffer_info =

[PATCH] checkpatch: warn on unnecessary int declarations

On Sun, 2018-08-05 at 08:52 -0700, Linus Torvalds wrote: > "long unsigned int" isn't _technically_ wrong. But we normally > call that type "unsigned long". So add a checkpatch test for it. Signed-off-by: Joe Perches --- scripts/checkpatch.pl | 20 ++

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

On Wed, 2018-07-25 at 15:12 +0200, Arnd Bergmann wrote: > tools/perf/tests/.gitignore: > LLVM byte-codes, uncompressed > On Wed, Jul 25, 2018 at 2:55 AM, Andrew Morton > wrote: > > On Tue, 24 Jul 2018 17:13:20 -0700 Joe Perches wrote: > >

Re: [PATCH v2 net] nfp: cast sizeof() to int when comparing with error code

On Tue, 2018-06-26 at 09:16 +0800, Chengguang Xu wrote: > sizeof() will return unsigned value so in the error check > negative error code will be always larger than sizeof(). [] > diff --git a/drivers/net/ethernet/netronome/nfp/nfpcore/nfp_nffw.c >

Re: [PATCH 3/4] net/ncsi: Use netdev_dbg for debug messages

On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > This moves all of the netdev_printk(KERN_DEBUG, ...) messages over to > netdev_dbg. There is no change in behaviour. Not quite, but I think the patch is fine anyway. netdev_printk(KERN_DEBUG ... is always emitted as long as the console

Re: [PATCH 1/4] net/ncsi: Silence debug messages

On Mon, 2018-06-18 at 16:49 +0930, Joel Stanley wrote: > In normal operation we see this series of messages as the host drives > the network device: > > ftgmac100 1e66.ethernet eth0: NCSI: LSC AEN - channel 0 state down > ftgmac100 1e66.ethernet eth0: NCSI: suspending channel 0 [...] >

[PATCH] drivers/net: Fix various unnecessary characters after logging newlines

Remove and coalesce formats when there is an unnecessary character after a logging newline. These extra characters cause logging defects. Miscellanea: o Coalesce formats Signed-off-by: Joe Perches --- drivers/net/ethernet/cavium/liquidio/lio_main.c | 2 +- drivers/net/ethernet

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

this line. > > > > Hm, looks like this would have to be changed in a lot of places (~782 > > according to `git grep 'default n$'|wc -l` in my slightly outdated linux- > > next). Do you want to fix it everywhere? > > No, but we can at least not add the new ones... &

Re: [PATCH] rtlwifi: remove duplicate code

On Thu, 2018-05-24 at 13:54 -0500, Gustavo A. R. Silva wrote: > Remove and refactor some code in order to avoid having identical code > for different branches. True and nice tool and patch submittal thanks. > Notice that the logic has been there since 2014. But perhaps the original logic is a

Re: [PATCH 8/8] batman-adv: enable B.A.T.M.A.N. V compilation by default

On Thu, 2018-05-24 at 14:03 +0200, Simon Wunderlich wrote: > From: Marek Lindner > > Signed-off-by: Marek Lindner > Acked-by: Antonio Quartulli > Signed-off-by: Sven Eckelmann > Signed-off-by: Simon

Re: [PATCH bpf-next] bpf: btf: Avoid variable length array

On Wed, 2018-05-23 at 10:46 -0700, Martin KaFai Lau wrote: > Sparse warning: > kernel/bpf/btf.c:1985:34: warning: Variable length array is used. Perhaps use ARRAY_SIZE directly instead of indirectly via a #define > diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c [] > @@ -1970,6 +1970,8 @@

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On Fri, 2018-05-18 at 09:52 +0200, Alexandre Belloni wrote: > On 17/05/2018 18:13:25-0700, Joe Perches wrote: > > On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > > > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > > > On Thu, 2018-05-17 at 21:23

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On Thu, 2018-05-17 at 21:39 +0200, Alexandre Belloni wrote: > On 17/05/2018 12:28:59-0700, Joe Perches wrote: > > On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > > > ocelot_qsys.h is missing the SPDX identfier, fix that. > > > > > > Signed-off-b

Re: [PATCH net-next ] net: mscc: Add SPDX identifier

On Thu, 2018-05-17 at 21:23 +0200, Alexandre Belloni wrote: > ocelot_qsys.h is missing the SPDX identfier, fix that. > > Signed-off-by: Alexandre Belloni Only the copyright holders should ideally be modifying these and also removing other license content. For

Re: [resend PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

On Tue, 2018-03-27 at 11:52 -0700, Joe Perches wrote: > When enabled, the current debug logging does not have a KERN_. > Add KERN_DEBUG to the logging macros. > > Miscellanea: > > o Remove #define redundancy and neaten the macros a bit ping? > Signed-off-by: Joe Perc

[PATCH 00/18] Convert default pr_fmt from empty to KBUILD_MODNAME

ries is applied. The above script output diff is currently: 1198 files changed, 70 insertions(+), 2241 deletions(-) Joe Perches (18): kernel: Use pr_fmt lib: Use pr_fmt printk: Convert pr_fmt from blank define to KBUILD_MODNAME x86: Remove pr_fmt duplicate logging prefixes x86/mtrr: Rename

[PATCH 02/18] lib: Use pr_fmt

neatening o Use %s, __func__ instead of embedding function names as strings o Add missing newline terminations Signed-off-by: Joe Perches <j...@perches.com> --- lib/cpu_rmap.c | 15 +--- lib/crc32test.c | 2 ++ lib/earlycpio.c | 5 ++-- lib/find_bit_bench

[PATCH 06/18] net: Remove pr_fmt duplicate logging prefixes

Using KBUILD_MODNAME as the default pr_fmt prefix caused some duplication on logging prefixes in net/. Remove the duplicate prefixes. Signed-off-by: Joe Perches <j...@perches.com> --- net/ipv4/ipconfig.c| 59 -- net/ipv4/

[PATCH 09/18] ptp: Remove pr_fmt duplicate logging prefixes

Converting pr_fmt from a simple define to use KBUILD_MODNAME added some duplicate logging prefixes to existing uses. Remove them. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/ptp/ptp_clock.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drive

[PATCH] net: ipv4: remove define INET_CSK_DEBUG and unnecessary EXPORT_SYMBOL

INET_CSK_DEBUG is always set and only is used for 2 pr_debug calls. EXPORT_SYMBOL(inet_csk_timer_bug_msg) is only used by these 2 pr_debug calls and is also unnecessary as the exported string can be used directly by these calls. Signed-off-by: Joe Perches <j...@perches.com> --- inclu

Re: [net-next][PATCH] inet: Use switch case instead of multiple condition checks

On Thu, 2018-05-10 at 13:37 +0800, Li RongQing wrote: > inet_csk_reset_xmit_timer uses multiple equality condition checks, > so it is better to use switch case instead of them [] > diff --git a/include/net/inet_connection_sock.h > b/include/net/inet_connection_sock.h [] > @@ -239,22 +239,31 @@

Re: [net-next 2/6] fm10k: reduce duplicate fm10k_stat macro code

On Mon, 2018-05-07 at 07:45 -0700, Jeff Kirsher wrote: > Share some of the code for setting up fm10k_stat macros by implementing > an FM10K_STAT_FIELDS macro which we can use when setting up the type > specific macros. [] > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c >

Re: [PATCH 00/12] Ethernet: Add and use ether__addr globals

On Thu, 2018-04-05 at 15:27 +0200, Felix Fietkau wrote: > On 2018-03-31 09:05, Joe Perches wrote: > > There are many local static and non-static arrays that are used for > > Ethernet broadcast address output or comparison. > > > > Centralize the array into a sing

Re: [PATCH 04/12] bridge: netfilter: Use the new global ether__addr arrays

On Sat, 2018-03-31 at 20:28 +0200, Pablo Neira Ayuso wrote: > Hi Joe, Hi Pablo. > On Sat, Mar 31, 2018 at 12:05:19AM -0700, Joe Perches wrote: > > Remove the local consts and use the new globals. > > This one is already upstream: > > https://git.kernel.org/pub/scm/l

[PATCH V2] treewide/net: Rename eth_stp_addr to ether_stp_addr

eth_stp_addr is not in the same form as the other global ether__addr addresses like ether_broadcast_addr. Convert it treewide. Miscellanea: o Add comment to the ether_stp_addr define to show it's for spanning-tree Signed-off-by: Joe Perches <j...@perches.com> --- V2: Remove gg from i

Re: [PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

On Sat, 2018-03-31 at 19:36 +0200, Andrew Lunn wrote: > On Sat, Mar 31, 2018 at 12:05:17AM -0700, Joe Perches wrote: > > --- a/net/bridge/br_device.c > > +++ b/net/bridge/br_device.c > > @@ -1,4 +1,4 @@ > > -/* > > +gg/* > > Hi Joe > &g

Re: [PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

On Sat, 2018-03-31 at 14:01 +, Pkshih wrote: > On Sat, 2018-03-31 at 00:05 -0700, Joe Perches wrote: > > Use the new ether_broadcast_addr global instead to save some object code. [] > > diff --git a/drivers/net/wireless/realtek/rtlwifi/core.c [] > > @@ -1649,7

[PATCH 01/12] ethernet: Add generic ether__addr addresses

and move static const eth_reservd_addr_base from etherdevice.h to this new ether_addrs.c file so it is no longer oddly declared as static const in a .h file Signed-off-by: Joe Perches <j...@perches.com> --- include/linux/etherdevice.h | 12 net/ethernet/Makefile | 2 +

[PATCH 02/12] treewide/net: Rename eth_stp_addr to ether_stp_addr

eth_stp_addr is not in the same form as the other global ether__addr addresses like ether_broadcast_addr. Convert it treewide. Miscellanea: o Add comment to the ether_stp_addr define to show it's for spanning-tree Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/dsa/l

[PATCH 00/12] Ethernet: Add and use ether__addr globals

There are many local static and non-static arrays that are used for Ethernet broadcast address output or comparison. Centralize the array into a single separate file and remove the local arrays. Joe Perches (12): ethernet: Add generic ether__addr addresses treewide/net: Rename eth_stp_addr

[PATCH 03/12] net: mac80211: Use global ether_broadcast_addr

Remove statics and use the new global ether_broadcast_addr instead to save some overall object code size. Signed-off-by: Joe Perches <j...@perches.com> --- net/mac80211/iface.c| 5 + net/mac80211/key.c | 6 ++ net/mac80211/mesh_hwmp.c| 19 ++

[PATCH 04/12] bridge: netfilter: Use the new global ether__addr arrays

Remove the local consts and use the new globals. Signed-off-by: Joe Perches <j...@perches.com> --- net/bridge/netfilter/ebt_stp.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index 3140eb

[PATCH 05/12] net: atm: Use ether_broadcast_addr

Use the new global instead of a local static to reduce object code size a tiny bit. Signed-off-by: Joe Perches <j...@perches.com> --- net/atm/lec.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index 01d5d20a6eb1..ec47b4

[PATCH 07/12] brcmfmac: Convert ALLFFMAC to ether_broadcast_addr

Remove the local ALLFFMAC extern array and use the new global instead. Miscellanea: o Convert char *mac to const char *mac as it can't be modified Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/common.c | 2 -- drivers/net/wireless/br

[PATCH 06/12] wireless: Convert simple uses of a static const Ethernet broadcast address

Use the new ether_broadcast_addr global instead to save some object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/admtek/adm8211.c | 3 +-- drivers/net/wireless/ath/carl9170/mac.c | 4 +--- drivers/net/wireless/broadcom/b43/main.c

[PATCH 08/12] iwlegacy: Remove EXPORT_SYMBOL(il_bcast_addr) and use ether_broadcast_addr

Remove the local array and use the new global instead to save some small amount of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/intel/iwlegacy/3945-mac.c | 2 +- drivers/net/wireless/intel/iwlegacy/4965-mac.c | 2 +- drivers/net/wireless/intel/iw

[PATCH 10/12] mvpp2: Use ether_broadcast_addr instead of a local array

Save a small bit of object code by using the new global instead. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/marvell/mvpp2.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/m

[PATCH 12/12] ethernet: Use ether_zero_addr instead of local statics

This saves a small amount of object code. Miscellanea: o __b44_cam_write now use const u8 *data instead of unsigned char * to avoid compiler warnings as it doesn't modify data Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/broadcom/b44.c | 5 ++--- drive

[PATCH 09/12] iwlwifi: Remove local iwl_bcast_addr and use ether_broadcast_addr

Use the new global to save a little bit of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/intel/iwlwifi/dvm/dev.h | 1 - drivers/net/wireless/intel/iwlwifi/dvm/scan.c | 2 +- drivers/net/wireless/intel/iwlwifi/dvm/sta.c | 4 +--- 3 files chan

[PATCH 11/12] qlogic: Convert local bcast_addr to global ether_broadcast_addr

Use the new global instead of local statics to save a bit of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c | 5 + drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c | 6 ++ drivers/net/ethernet/qlogic/

[PATCH] ethernet: hisilicon: hns: hns_dsaf_mac: Use generic eth_broadcast_addr

Rather than use an on-stack array to copy a broadcast address, use the generic eth_broadcast_addr function to save a trivial amount of object code. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_mac.c | 6 ++ 1 file changed, 2 insertions

Re: [PATCH] ISDN: eicon: message: remove redundant check

On Fri, 2018-03-30 at 10:46 -0500, Gustavo A. R. Silva wrote: > Check on plci->internal_command is unnecessary. Probably all of these are unnecessary too: $ for length in {7..2} ; do \ grep-2.5.4 -rP --include=*.[ch] -n "^\t{$length,$length}break;\n\t{$(($length-1)),$(($length-1))}break;" *

Re: [PATCH] sfp: allow cotsworks modules

On Wed, 2018-03-28 at 17:51 +0100, Russell King - ARM Linux wrote: > On Wed, Mar 28, 2018 at 09:19:01AM -0700, Joe Perches wrote: > > On Wed, 2018-03-28 at 11:41 +0100, Russell King - ARM Linux wrote: > > > On Wed, Mar 28, 2018 at 03:33:57AM -0700, Joe Perches wrote: > >

Re: [PATCH] sfp: allow cotsworks modules

On Wed, 2018-03-28 at 11:41 +0100, Russell King - ARM Linux wrote: > On Wed, Mar 28, 2018 at 03:33:57AM -0700, Joe Perches wrote: > > On Wed, 2018-03-28 at 11:18 +0100, Russell King wrote: > > > Cotsworks modules fail the checksums - it appears that Cotsworks > > > repro

Re: [PATCH] sfp: allow cotsworks modules

On Wed, 2018-03-28 at 11:18 +0100, Russell King wrote: > Cotsworks modules fail the checksums - it appears that Cotsworks > reprograms the EEPROM at the end of production with the final product > information (serial, date code, and exact part number for module > options) and fails to update the

[resend PATCH] rxrpc: Neaten logging macros and add KERN_DEBUG logging level

When enabled, the current debug logging does not have a KERN_. Add KERN_DEBUG to the logging macros. Miscellanea: o Remove #define redundancy and neaten the macros a bit Signed-off-by: Joe Perches <j...@perches.com> --- Resend of patch: https://lkml.org/lkml/2017/11/30/573 No change in

[PATCH] ipv6: addrconf: Use normal debugging style

a dump_stack() Signed-off-by: Joe Perches <j...@perches.com> --- Remerged resend of http://patchwork.ozlabs.org/patch/826028/ back in October 2017 net/ipv6/addrconf.c | 28 1 file changed, 8 insertions(+), 20 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addr

Re: [PATCH 2/4] wireless: Use octal not symbolic permissions

On Sat, 2018-03-24 at 12:09 +0200, Kalle Valo wrote: > Joe Perches <j...@perches.com> writes: > > Prefer the direct use of octal for permissions. [] > I don't know what tree are you planning to send these to, but I would > prefer to take this to wireless-drivers-next to m

[PATCH 1/4] ethernet: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/8390/

[PATCH 4/4] drivers/net: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/bonding/bond_procfs.c | 2 +- d

[PATCH 2/4] wireless: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath5k/

[PATCH 3/4] net: Use octal not symbolic permissions

Prefer the direct use of octal for permissions. Done with checkpatch -f --types=SYMBOLIC_PERMS --fix-inplace and some typing. Miscellanea: o Whitespace neatening around these conversions. Signed-off-by: Joe Perches <j...@perches.com> --- net/8021q/vlanproc.c

[PATCH 0/4] net: drivers/net: Use octal permissions

Using octal and not symbolic permissions is preferred by many as more readable. https://lkml.org/lkml/2016/8/2/1945 Rather than getting these piecemeal, just do them all. Done with checkpatch and some typing. Joe Perches (4): ethernet: Use octal not symbolic permissions wireless: Use octal

[trivial PATCH V2] treewide: Align function definition open/close braces

Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Signed-off-by: Joe Perches <j...@perches.

[PATCH] bridge: netfilter: ebt_stp: Use generic functions for comparisons

5d0 net/bridge/netfilter/ebt_stp.o.old Signed-off-by: Joe Perches <j...@perches.com> --- net/bridge/netfilter/ebt_stp.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index 3140eb912d7e..47ba98

[PATCH] ath: Remove unnecessary ath_bcast_mac and use eth_broadcast_addr

Remove the static array and use the generic routine to set the Ethernet broadcast address. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/wireless/ath/ath.h| 2 -- drivers/net/wireless/ath/ath5k/attach.c | 2 +- drivers/net/wireless/ath/ath9k/htc_drv_

[RFC PATCH] etherdevice.h: net/core: Add ether_addrs.c and global ether__addr

it extern to avoid possible multiple static definitions o Add compilation to the Makefile Signed-off-by: Joe Perches <j...@perches.com> --- Not sure this is the best place for this. Better ideas welcomed. include/linux/etherdevice.h | 12 net/core/Makefile | 3 ++- ne

Re: [net-next] intel: add SPDX identifiers to all the Intel drivers

On Tue, 2018-03-20 at 18:09 -0700, Jeff Kirsher wrote: > On Tue, 2018-03-20 at 16:46 -0700, Philippe Ombredanne wrote: > > When the kernel maintainers decide to switch to V3.0 of the SPDX list, > > the doc will be updated and then Joe's script could be applied at once > > to update the past. > >

Re: [net-next] intel: add SPDX identifiers to all the Intel drivers

On Tue, 2018-03-20 at 20:48 +, Allan, Bruce W wrote: > > -Original Message- > > From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] > > On Behalf Of Jeff Kirsher > > Sent: Tuesday, March 20, 2018 10:52 AM > > To: Joe Perches <j...@

Re: rfc: treewide replace local ethernet broadcast char arrays with a global ?

On Tue, 2018-03-20 at 13:07 -0700, Florian Fainelli wrote: > On 03/20/2018 01:00 PM, Joe Perches wrote: > > Treewide there are ~60 declarations of a ethernet broadcast > > address as a 6 byte array that are later used as either an > > output for vsprintf extension %pM

rfc: treewide replace local ethernet broadcast char arrays with a global ?

Treewide there are ~60 declarations of a ethernet broadcast address as a 6 byte array that are later used as either an output for vsprintf extension %pM or as a source array to copy or compare. Perhaps it'd be useful to declare a global static const u8[] in net somewhere instead to save the

Re: [net-next] intel: add SPDX identifiers to all the Intel drivers

On Tue, 2018-03-20 at 10:13 -0700, Jeff Kirsher wrote: > Add the SPDX identifiers to all the Intel wired LAN driver files, as > outlined in Documentation/process/license-rules.rst. So far the Documentation does not show using the -only variant. For a discussion, please see:

[PATCH] netfilter: ipset: Use is_zero_ether_addr instead of static and memcmp

64 276796c1f ip_set_hash_mac.o.allyesconfig.old 104431040 0 114832cdb ip_set_hash_mac.o.defconfig.new 105071040 0 115472d1b ip_set_hash_mac.o.defconfig.old Signed-off-by: Joe Perches <j...@perches.com> --- net/netfilter/ipset/ip_set_hash_mac

Re: rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures)

On Thu, 2018-03-15 at 10:08 -0700, Matthew Wilcox wrote: > On Thu, Mar 15, 2018 at 09:56:46AM -0700, Joe Perches wrote: > > I have a patchset that creates a vsprintf extension for > > print_vma_addr and removes all the uses similar to the > > print_symbol() removal. > &g

rfc: remove print_vma_addr ? (was Re: [PATCH 00/16] remove eight obsolete architectures)

On Thu, 2018-03-15 at 10:48 +0100, Geert Uytterhoeven wrote: > Hi David, > > On Thu, Mar 15, 2018 at 10:42 AM, David Howells wrote: > > Do we have anything left that still implements NOMMU? > > Sure: arm, c6x, m68k, microblaze, and sh. I have a patchset that creates a

Re: [PATCH net 2/2] qed: Fix non TCP packets should be dropped on iWARP ll2 connection

On Wed, 2018-03-14 at 14:49 +0200, Michal Kalderon wrote: > FW workaround. The iWARP LL2 connection did not expect TCP packets > to arrive on it's connection. The fix drops any non-tcp packets [] > diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c >

Re: [PATCH net-next v2 2/4] net: qualcomm: rmnet: Update copyright year to 2018

On Tue, 2018-03-13 at 18:15 -0600, Subash Abhinov Kasiviswanathan wrote: > > Did any work actually occur on all these files in 2018? > > $ git log --name-only --since=01-01-2018 > > drivers/net/ethernet/qualcomm/rmnet/ | \ > > grep "^drivers" | sort | uniq > >

Re: [PATCH net-next v2 2/4] net: qualcomm: rmnet: Update copyright year to 2018

On Tue, 2018-03-13 at 16:50 -0600, Subash Abhinov Kasiviswanathan wrote: > Signed-off-by: Subash Abhinov Kasiviswanathan > --- > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.c | 2 +- > drivers/net/ethernet/qualcomm/rmnet/rmnet_config.h | 2 +- >

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Tue, 2018-03-13 at 15:59 +0100, Pablo Neira Ayuso wrote: > On Mon, Mar 12, 2018 at 04:58:38PM -0700, Joe Perches wrote: > > On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > > > In preparation to enabling -Wvla, remove VLA and replace it > > > wit

Re: [PATCH] netfilter: cttimeout: remove VLA usage

On Mon, 2018-03-12 at 18:14 -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with dynamic memory allocation. > > From a security viewpoint, the use of Variable Length Arrays can be > a vector for stack overflow attacks. Also, in general, as the

[PATCH] net: drivers/net: Remove unnecessary skb_copy_expand OOM messages

skb_copy_expand without __GFP_NOWARN already does a dump_stack on OOM so these messages are redundant. Signed-off-by: Joe Perches <j...@perches.com> --- drivers/net/ethernet/qualcomm/qca_spi.c | 1 - drivers/net/usb/lg-vl600.c | 6 +- drivers/net/wimax/i2400m/usb-rx.c

Re: [PATCH v2] net: netfilter: Replace printk() with appropriate pr_*() macro

On Mon, 2018-03-12 at 01:11 +0530, Arushi Singhal wrote: > Using pr_() is more concise than > printk(KERN_). > Replace printks having a log level with the appropriate > pr_*() macros. > > Signed-off-by: Arushi Singhal > --- > changes in v2 > *in v1 printk() were

Re: [PATCH 1/2] net/usb/ax88179_178a: Use common code in ax88179_chk_eee()

On Sat, 2018-03-10 at 19:24 +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 10 Mar 2018 18:22:43 +0100 > > Adjust a jump target so that a bit of common code can be better reused > at the end of this function. Please stop mindlessly sending

Re: [PATCH] drivers: net: wireless: ath: ath9k: dfs: remove VLA usage

On Fri, 2018-03-09 at 15:23 +0200, Andreas Christoforou wrote: > The kernel would like to have all stack VLA usage removed. > This is the correct patch. [] > diff --git a/drivers/net/wireless/ath/ath9k/dfs.c > b/drivers/net/wireless/ath/ath9k/dfs.c [] > @@ -101,7 +101,7 @@ static bool

Re: [PATCH] i40evf: remove redundant array comparisons to 0 checks

On Sun, 2018-02-18 at 16:58 +0200, Andy Shevchenko wrote: > On Fri, Feb 16, 2018 at 6:53 PM, Colin Ian King > wrote: > > On 16/02/18 16:51, Andy Shevchenko wrote: > > > On Thu, Feb 15, 2018 at 9:42 PM, Colin King > > > wrote: > > > > +

Re: KASAN: use-after-free Read in rds_tcp_tune

On Wed, 2018-02-14 at 18:16 +0100, Dmitry Vyukov wrote: > On Wed, Feb 14, 2018 at 6:02 PM, Joe Perches <j...@perches.com> wrote: > > On Wed, 2018-02-14 at 16:55 +0100, Dmitry Vyukov wrote: > > > On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan > > > &l

Re: KASAN: use-after-free Read in rds_tcp_tune

On Wed, 2018-02-14 at 16:55 +0100, Dmitry Vyukov wrote: > On Wed, Feb 14, 2018 at 4:35 PM, Sowmini Varadhan > wrote: > > btw, checkpatch.pl complains about the syzbot*@syzkaller.appspotmail.com > > addresses as "Unrecognized email address", we should fix that > >

Re: [PATCH v7 31/37] MAINTAINERS: Add nds32

On Tue, 2018-02-13 at 17:09 +0800, Greentime Hu wrote: > Add a maintainer information for the nds32(Andes) architecture. [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@ -868,6 +868,17 @@ X: drivers/iio/*/adjd* > F: drivers/staging/iio/*/ad* > F:

Re: [PATCH] rtlwifi: rtl8192cu: remove pointless memcpy

On Fri, 2018-02-09 at 14:24 +0100, Arnd Bergmann wrote: > gcc-8 points out that source and destination of the memcpy() are > always the same pointer, so the effect of memcpy() is undefined > here (its arguments must not overlap): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c: In

Re: [net-next 2/7] fm10k: cleanup unnecessary parenthesis in fm10k_iov.c

On Wed, 2018-01-24 at 14:45 -0800, Jeff Kirsher wrote: > This fixes a few warnings found by checkpatch.pl --strict [] > diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_iov.c > b/drivers/net/ethernet/intel/fm10k/fm10k_iov.c [] > @@ -353,7 +353,7 @@ int fm10k_iov_resume(struct pci_dev *pdev) >

Re: [PATCH v2] smc: return booleans instead of integers

On Mon, 2018-01-22 at 12:58 +0100, Ursula Braun wrote: > > On 01/19/2018 09:54 PM, Gustavo A. R. Silva wrote: > > Return statements in functions returning bool should use > > true/false instead of 1/0. > > > > This issue was detected with the help of Coccinelle. > > > > Signed-off-by: Gustavo

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Wed, 2018-01-17 at 17:46 -0800, Eric Biggers wrote: > On Wed, Jan 17, 2018 at 05:18:17PM -0800, Joe Perches wrote: > > On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > > > get_maintainer.pl, which is often not accurate > > > > Examples please. >

Re: dangers of bots on the mailing lists was Re: divide error in ___bpf_prog_run

On Wed, 2018-01-17 at 20:09 -0500, Theodore Ts'o wrote: > get_maintainer.pl, which is often not accurate Examples please.

Re: [PATCH net-next v2 08/10] net: aquantia: Fix register definitions to linux style

On Mon, 2018-01-15 at 16:41 +0300, Igor Russkikh wrote: > Original driver code had internal registers and masks declarations > in low case and without any prefix. > Here we make all these uppercase and add already used HW_ATL prefix > to recognize these. [] > diff --git

[PATCH] MAINTAINERS: Mark some staging directories as "Obsolete"

e matching subsystem files should not be modified. This might help avoid receiving patches that will be dropped. Signed-off-by: Joe Perches <j...@perches.com> --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3d53de49e736..9ed

Re: [PATCH net-next v2 1/6] net: Fix netdev_WARN_ONCE macro

On Sun, 2018-01-07 at 12:08 +0200, Gal Pressman wrote: > netdev_WARN_ONCE is broken (whoops..), this fix will remove the > unnecessary "condition" parameter, add the missing comma and change > "arg" to "args". > > Fixes: 375ef2b1f0d0 ("net: Introduce netdev_*_once functions") > Signed-off-by: Gal

Re: [PATCH] MAINTAINERS: Update my email address.

On Tue, 2018-01-02 at 20:14 -0800, Pravin B Shelar wrote: > Signed-off-by: Pravin Shelar > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 753799d..1704ed4 100644 > --- a/MAINTAINERS > +++

Re: [PATCH net-next 2/2] tuntap: XDP transmission

On Mon, 2018-01-01 at 11:48 +0800, kbuild test robot wrote: > Hi Jason, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on net-next/master] > > url: > https://github.com/0day-ci/linux/commits/Jason-Wang/XDP-transmission-for-tuntap/20180101-105946 > config:

Re: [ovs-dev] Pravin Shelar

On Wed, 2017-12-27 at 10:25 -0800, Ben Pfaff wrote: > On Wed, Dec 27, 2017 at 04:22:55PM +0100, Julia Lawall wrote: > > The email address pshe...@nicira.com listed for Pravin Shelar in > > MAINTAINERS (OPENVSWITCH section) seems to bounce. > > Pravin has used a newer address recently, so I sent

Re: [-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

On Tue, 2017-12-19 at 19:44 +0100, Borislav Petkov wrote: > On Tue, Dec 19, 2017 at 10:15:09AM -0800, Joe Perches wrote: > > Convert DEVICE_ATTR uses to DEVICE_ATTR_WO where possible. > > > > Done with perl script: > > > > $ git grep -w --name-only DEVICE_ATTR

[-next PATCH 0/4] sysfs and DEVICE_ATTR_

Joe Perches (4): sysfs.h: Use octal permissions treewide: Use DEVICE_ATTR_RW treewide: Use DEVICE_ATTR_RO treewide: Use DEVICE_ATTR_WO arch/arm/mach-pxa/sharpsl_pm.c | 4 +- arch/s390/kernel/smp.c | 2 +- arch/s390/kernel/topology.c

[-next PATCH 4/4] treewide: Use DEVICE_ATTR_WO

(\1)/g; print;}' Signed-off-by: Joe Perches <j...@perches.com> --- arch/s390/kernel/smp.c | 2 +- arch/x86/kernel/cpu/microcode/core.c | 2 +- drivers/input/touchscreen/elants_i2c.c | 2 +- drivers/net/ethernet/ibm/ibmvnic.c | 2 +- drivers/net/wimax/i2400m/sysfs.c | 3

Re: [PATCH v2 2/3] vsprintf: print if symbol not found

On Tue, 2017-12-19 at 14:28 +1100, Tobin C. Harding wrote: > Depends on: commit 40eee173a35e ("kallsyms: don't leak address when > symbol not found") > > Currently vsprintf for specifiers %p[SsB] relies on the behaviour of > kallsyms (sprint_symbol()) and prints the actual address if a symbol is

Re: [PATCH v2 0/5] Support for generalized use of make C={1,2} via a wrapper program

On Mon, 2017-12-18 at 10:46 -0700, Jason Gunthorpe wrote: > On Sun, Dec 17, 2017 at 10:00:17PM -0800, Joe Perches wrote: > > > > Today when we run checkers we get so many warnings it is too hard to > > > make any sense of it. > > > > Here is a list of

  1   2   3   4   5   6   7   8   9   >