Re: [PATCH iproute2] stats output

On Fri, Nov 30, 2018 at 10:12 AM Stephen Hemminger wrote: > > On Fri, 30 Nov 2018 14:33:49 +0100 > Alexis Vachette wrote: > > > When using: > > > > - ip -s link > > > > I think it should be better to print errors stats without adding -s > > option twice. > > > > This option print stats for each

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

On Thu, Nov 29, 2018 at 7:55 AM Sabrina Dubroca wrote: > > 2018-11-29, 07:27:17 -0800, Roopa Prabhu wrote: > > On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca > > wrote: > > > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > > > nit: This patch would have be

Re: [PATCH net-next v2 1/3] vxlan: support changelink for a few more attributes

On Thu, Nov 29, 2018 at 5:56 AM Sabrina Dubroca wrote: > > 2018-11-28, 14:27:57 -0800, Roopa Prabhu wrote: > > From: Roopa Prabhu > > > > We started very conservative when supporting changelink > > especially because not all attribute changes could be > > te

Re: [PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

On Thu, Nov 29, 2018 at 6:19 AM Sabrina Dubroca wrote: > > 2018-11-28, 14:27:59 -0800, Roopa Prabhu wrote: > > +/* Set/clear flags based on attribute */ > > +static void vxlan_nl2flag(struct vxlan_config *conf, struct nlattr *tb[], > > + int attr

[PATCH net-next v2 0/3] vxlan: a few minor cleanups

From: Roopa Prabhu Roopa Prabhu (3): vxlan: support changelink for a few more attributes vxlan: extack support for some changelink cases vxlan: move flag sets to use a helper func drivers/net/vxlan.c | 199 +++- 1 file changed, 102

[PATCH net-next v2 3/3] vxlan: move flag sets to use a helper func

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 95 - 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 4cb6b50..47671fd 100644 --- a/drivers/net/vxlan.c

[PATCH net-next v2 2/3] vxlan: extack support for some changelink cases

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 76 + 1 file changed, 59 insertions(+), 17 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 73caa65..4cb6b50 100644 --- a/drivers/net/vxlan.c

[PATCH net-next v2 1/3] vxlan: support changelink for a few more attributes

From: Roopa Prabhu We started very conservative when supporting changelink especially because not all attribute changes could be tested. This patch opens up a few more attributes for changelink. The reason for choosing this set of attributes is based on code references for these attributes. I

Re: [PATCH net-next 3/3] vxlan: move flag sets to use a helper func vxlan_nl2conf

On Wed, Nov 28, 2018 at 2:10 PM Roopa Prabhu wrote: > > From: Roopa Prabhu > > Signed-off-by: Roopa Prabhu > --- just noticed a typo in the title, spinning v2. > drivers/net/vxlan.c | 95 > - > 1 file chang

[PATCH net-next 1/3] vxlan: support changelink for a few more attributes

From: Roopa Prabhu We started very conservative when supporting changelink especially because not all attribute changes could be tested. This patch opens up a few more attributes for changelink. The reason for choosing this set of attributes is based on code references for these attributes. I

[PATCH net-next 3/3] vxlan: move flag sets to use a helper func vxlan_nl2conf

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 95 - 1 file changed, 43 insertions(+), 52 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 4cb6b50..47671fd 100644 --- a/drivers/net/vxlan.c

[PATCH net-next 2/3] vxlan: extack support for some changelink cases

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 76 + 1 file changed, 59 insertions(+), 17 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 73caa65..4cb6b50 100644 --- a/drivers/net/vxlan.c

[PATCH net-next 0/3] vxlan: a few minor cleanups

From: Roopa Prabhu Roopa Prabhu (3): vxlan: support changelink for a few more attributes vxlan: extack support for some changelink cases vxlan: move flag sets to use a helper func vxlan_nl2conf drivers/net/vxlan.c | 199 +++- 1 file changed

[PATCH iproute2] bridge: make -c match -compressvlans first instead of -color

From: Roopa Prabhu commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library") broke previous use of -c to represent compressvlans. This restores previous use of -c to represent compressvlans. Understand the original motivation to use -c to represent color consistently

Re: [PATCH v5 5/6] vxlan: handle underlay VRF changes

On Mon, Nov 26, 2018 at 5:04 PM Alexis Bauvin wrote: > > When underlay VRF changes, either because the lower device itself changed, > or its VRF changed, this patch releases the current socket of the VXLAN > device and recreates another one in the right VRF. This allows for > on-the-fly change of

Re: [RFC v4 3/5] vxlan: add support for underlay in non-default VRF

On Mon, Nov 26, 2018 at 9:54 AM David Ahern wrote: > > On 11/26/18 9:32 AM, Alexis Bauvin wrote: > > Thanks for the review. I’ll send a v5 if you have no other comment on > > this version! > > A few comments on the test script; see attached which has the changes. > > Mainly the cleanup does not

Re: [RFC v3 3/3] vxlan: handle underlay VRF changes

On Tue, Nov 20, 2018 at 7:04 AM David Ahern wrote: > > On 11/20/18 7:23 AM, Alexis Bauvin wrote: > > When underlay VRF changes, either because the lower device itself changed, > > or its VRF changed, this patch releases the current socket of the VXLAN > > device and recreates another one in the

Re: [RFC v3 2/3] vxlan: add support for underlay in non-default VRF

On Tue, Nov 20, 2018 at 6:23 AM Alexis Bauvin wrote: > > Creating a VXLAN device with is underlay in the non-default VRF makes > egress route lookup fail or incorrect since it will resolve in the > default VRF, and ingress fail because the socket listens in the default > VRF. > > This patch binds

Re: Should the bridge learn from frames with link local destination MAC address?

On Fri, Nov 9, 2018 at 8:00 AM Stephen Hemminger wrote: > > On Fri, 9 Nov 2018 04:24:43 +0100 > Andrew Lunn wrote: > > > Hi Roopa, Nikolay > > > > br_handle_frame() looks out for frames with a destination MAC > > addresses with is Ethernet link local, those which fit > > 01-80-C2-00-00-XX. It

[PATCH iproute2] bridge: fdb: remove redundant dev string in show output

From: Roopa Prabhu After commit 4abb8c723a64 ("bridge: fdb: Fix for missing keywords in non-JSON output"), I am seeing a double print for dev in bridge fdb show. eg: "44:38:39:00:6a:82 dev dev bridge vlan 1 master bridge permanent" this patch removes the redundant print.

Re: [PATCH net] bridge: do not add port to router list when receives query with source 0.0.0.0

nd to other > nodes. > > b) The arrival port for IGMP Queries (sent by multicast routers) > where the source address is not 0.0.0.0. > > We should not add the port to router list when receives query with source > 0.0.0.0. > > Reported-by: Ying Xu > Signed-off-by: Hangbin Liu > --- Acked-by: Roopa Prabhu

[PATCH net] Revert "neighbour: force neigh_invalidate when NUD_FAILED update is from admin"

From: Roopa Prabhu This reverts commit 8e326289e3069dfc9fa9c209924668dd031ab8ef. This patch results in unnecessary netlink notification when one tries to delete a neigh entry already in NUD_FAILED state. Found this with a buggy app that tries to delete a NUD_FAILED entry repeatedly. While

[PATCH iproute2 net-next] ipneigh: support for NTF_EXT_LEARNED flag on neigh entries

From: Roopa Prabhu Adds new option extern_learn to set NTF_EXT_LEARNED flag on neigh entries. Signed-off-by: Roopa Prabhu --- ip/ipneigh.c| 7 ++- man/man8/ip-neighbour.8 | 9 - 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c

[PATCH net-next v2] vxlan: support NTF_USE refresh of fdb entries

From: Roopa Prabhu This makes use of NTF_USE in vxlan driver consistent with bridge driver. Signed-off-by: Roopa Prabhu --- v2: fix patch prefix drivers/net/vxlan.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index

Re: [PATCH cumulus-4.18.y] vxlan: support NTF_USE refresh of fdb entries

On Thu, Oct 11, 2018 at 12:33 PM Roopa Prabhu wrote: > > From: Roopa Prabhu > > This makes use of NTF_USE in vxlan driver consistent > with bridge driver. > > Signed-off-by: Roopa Prabhu > --- pls ignore. wrong patch prefix :)

[PATCH cumulus-4.18.y] vxlan: support NTF_USE refresh of fdb entries

From: Roopa Prabhu This makes use of NTF_USE in vxlan driver consistent with bridge driver. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index fb0cdbb..018406c

Re: [PATCH net-next 0/9] net: Kernel side filtering for route dumps

On Thu, Oct 11, 2018 at 9:16 AM David Ahern wrote: > > On 10/11/18 10:07 AM, Jamal Hadi Salim wrote: > > On 2018-10-11 11:46 a.m., Sowmini Varadhan wrote: > >> On (10/11/18 08:26), Stephen Hemminger wrote: > >>> You can do the something like this already with BPF socket filters. > >>> But writing

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

On Wed, Sep 26, 2018 at 10:23 AM Roopa Prabhu wrote: > > On Tue, Sep 25, 2018 at 2:34 AM, Patrick Ruddy > wrote: > > On Wed, 2018-09-19 at 21:47 -0700, David Ahern wrote: > >> On 9/18/18 6:12 AM, Patrick Ruddy wrote: > >> > > >> > I've hit a s

[PATCH iproute2 net-next] ipneigh: update man page and help for router

From: Roopa Prabhu While at it also add missing text for proxy in the man page. Signed-off-by: Roopa Prabhu --- ip/ipneigh.c| 1 + man/man8/ip-neighbour.8 | 11 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index 5747152

Re: [PATCH iproute2 net-next] ipneigh: support setting of NTF_ROUTER on neigh entries

On Fri, Sep 28, 2018 at 9:57 AM David Ahern wrote: > > On 9/25/18 3:15 PM, Roopa Prabhu wrote: > > From: Roopa Prabhu > > > > Signed-off-by: Roopa Prabhu > > --- > > ip/ipneigh.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > ap

Re: [PATCH] MAINTAINERS: change bridge maintainers

ed-off-by: Stephen Hemminger > --- Acked-by: Roopa Prabhu Thanks

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

On Tue, Sep 25, 2018 at 2:34 AM, Patrick Ruddy wrote: > On Wed, 2018-09-19 at 21:47 -0700, David Ahern wrote: >> On 9/18/18 6:12 AM, Patrick Ruddy wrote: >> > >> > I've hit a small snag with adding the new groups. The number of defined >> > groups currently sits at 31 so I can only add one before

[PATCH net-next] bridge: br_arp_nd_proxy: set icmp6_router if neigh has NTF_ROUTER

From: Roopa Prabhu Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports") Signed-off-by: Roopa Prabhu --- net/bridge/br_arp_nd_proxy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_arp_nd_proxy.c b/net/bridge/br_arp_nd_pro

[PATCH iproute2 net-next] ipneigh: support setting of NTF_ROUTER on neigh entries

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- ip/ipneigh.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ip/ipneigh.c b/ip/ipneigh.c index a0af705..5747152 100644 --- a/ip/ipneigh.c +++ b/ip/ipneigh.c @@ -139,6 +139,8 @@ static int ipneigh_modify(int cmd, int flags, int argc

[PATCH net-next 2/2] neighbour: send netlink notification if NTF_ROUTER changes

From: Roopa Prabhu send netlink notification if neigh_update results in NTF_ROUTER change and if NEIGH_UPDATE_F_ISROUTER is on. Also move the NTF_ROUTER change function into a helper. Signed-off-by: Roopa Prabhu --- include/net/neighbour.h | 15 +++ net/core/neighbour.c| 7

[PATCH net-next 1/2] neighbour: allow admin to set NTF_ROUTER

From: Roopa Prabhu This patch allows admin setting of NTF_ROUTER flag on a neighbour entry. This enables external control plane (like bgp evpn) to manage neigh entries with NTF_ROUTER flag. Signed-off-by: Roopa Prabhu --- net/core/neighbour.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[PATCH net-next 0/2] few NTF_ROUTER related updates

From: Roopa Prabhu This series allows setting of NTF_ROUTER by an external entity (eg BGP E-VPN control plane). Also fixes missing netlink notification on neigh NTF_ROUTER flag changes. Roopa Prabhu (2): neighbour: allow admin to set NTF_ROUTER neighbour: send netlink notification

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

On Thu, Sep 6, 2018 at 8:40 PM, Roopa Prabhu wrote: > On Thu, Sep 6, 2018 at 2:10 AM, Patrick Ruddy > wrote: >> Some userspace applications need to know about IGMP joins from the >> kernel for 2 reasons: >> 1. To allow the programming of multicast MAC filters i

[PATCH net] net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags

From: Roopa Prabhu This fix addresses https://bugzilla.kernel.org/show_bug.cgi?id=201071 Commit 5025f7f7d506 wrongly relied on __dev_change_flags to notify users of dev flag changes in the case when dev->rtnl_link_state = RTNL_LINK_INITIALIZED. Fix it by indicating flag changes explici

Re: Fw: [Bug 201071] New: Creating a vxlan in state 'up' does not give proper RTM_NEWLINK message

On Tue, Sep 11, 2018 at 3:10 PM, Roopa Prabhu wrote: > On Mon, Sep 10, 2018 at 11:55 AM, Stephen Hemminger > wrote: >> >> >> Begin forwarded message: >> >> Date: Mon, 10 Sep 2018 04:04:37 + >> From: bugzilla-dae...@bugzilla.kernel.org >> To: st

Re: Fw: [Bug 201071] New: Creating a vxlan in state 'up' does not give proper RTM_NEWLINK message

On Mon, Sep 10, 2018 at 11:55 AM, Stephen Hemminger wrote: > > > Begin forwarded message: > > Date: Mon, 10 Sep 2018 04:04:37 + > From: bugzilla-dae...@bugzilla.kernel.org > To: step...@networkplumber.org > Subject: [Bug 201071] New: Creating a vxlan in state 'up' does not give > proper

Re: [PATCH net-next v3 1/2] netlink: ipv4 igmp join notifications

On Thu, Sep 6, 2018 at 2:10 AM, Patrick Ruddy wrote: > Some userspace applications need to know about IGMP joins from the > kernel for 2 reasons: > 1. To allow the programming of multicast MAC filters in hardware > 2. To form a multicast FORUS list for non link-local multicast >groups to be

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

On Sun, Sep 2, 2018 at 4:18 AM, Patrick Ruddy wrote: > Hi Roopa > > inline > > thx > > -pr > > On Fri, 2018-08-31 at 09:29 -0700, Roopa Prabhu wrote: >> On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy >> wrote: >> > Some userspace applicatio

Re: [PATCH net-next v2 1/2] netlink: ipv4 igmp join notifications

On Fri, Aug 31, 2018 at 4:20 AM, Patrick Ruddy wrote: > Some userspace applications need to know about IGMP joins from the kernel > for 2 reasons > 1. To allow the programming of multicast MAC filters in hardware > 2. To form a multicast FORUS list for non link-local multicast >groups to be

Re: [PATCH v2 iproute2-next 2/5] bridge: colorize output and use JSON print library

On Sat, Jul 14, 2018 at 6:41 PM, Roopa Prabhu wrote: > On Tue, Feb 20, 2018 at 11:24 AM, Stephen Hemminger > wrote: >> From: Stephen Hemminger >> >> Use new functions from json_print to simplify code. >> Provide standard flag for colorizing output. >> &

Re: [PATCH net 0/4] vxlan: fix default fdb entry user-space notify ordering/race

On Fri, Jul 20, 2018 at 1:21 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > Problem: > In vxlan_newlink, a default fdb entry is added before register_netdev. > The default fdb creation function notifies user-space of the > fdb entry on the vxlan device which user-space does

[PATCH net 2/4] vxlan: add new fdb alloc and create helpers

From: Roopa Prabhu - Add new vxlan_fdb_alloc helper - rename existing vxlan_fdb_create into vxlan_fdb_update: because it really creates or updates an existing fdb entry - move new fdb creation into a separate vxlan_fdb_create Main motivation for this change is to introduce

[PATCH net 4/4] vxlan: fix default fdb entry netlink notify ordering during netdev create

From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function also notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

[PATCH net 1/4] rtnetlink: add rtnl_link_state check in rtnl_configure_link

From: Roopa Prabhu rtnl_configure_link sets dev->rtnl_link_state to RTNL_LINK_INITIALIZED and unconditionally calls __dev_notify_flags to notify user-space of dev flags. current call sequence for rtnl_configure_link rtnetlink_newlink rtnl_link_ops->newlink rtnl_configur

[PATCH net 3/4] vxlan: make netlink notify in vxlan_fdb_destroy optional

From: Roopa Prabhu Add a new option do_notify to vxlan_fdb_destroy to make sending netlink notify optional. Used by a later patch. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b

[PATCH net 0/4] vxlan: fix default fdb entry user-space notify ordering/race

From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

Re: [PATCH net-next,v2] net: rename ndo_setup_tc to ndo_setup_offload

On Wed, Jul 18, 2018 at 5:11 PM, Pablo Neira Ayuso wrote: > One of the recurring complaints is that we do not have, as a driver > writer, a central location from which we would be fed offloading rules > into a NIC. This was brought up again during Netconf'18 in Boston. > > This patch just renames

[PATCH iproute2 net-next] ipneigh: exclude NTF_EXT_LEARNED from default filter

From: Roopa Prabhu NUD_NOARP entries are filtered out by default by iproute2. We dont want NUD_NOARP with NTF_EXT_LEARNED flag filtered out. This patch extends the default filter check for ip neigh show to include the NTF_EXT_LEARNED flag. Signed-off-by: Roopa Prabhu --- ip/ipneigh.c | 1 + 1

Re: [PATCH v2 iproute2-next 2/5] bridge: colorize output and use JSON print library

On Tue, Feb 20, 2018 at 11:24 AM, Stephen Hemminger wrote: > From: Stephen Hemminger > > Use new functions from json_print to simplify code. > Provide standard flag for colorizing output. > > The shortened -c flag is ambiguous it could mean color or > compressvlan; it is now changed to mean

Re: [PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race

On Sat, Jul 7, 2018 at 4:23 AM, David Miller wrote: > From: Roopa Prabhu > Date: Wed, 4 Jul 2018 16:46:28 -0700 > >> From: Roopa Prabhu >> >> Problem: >> In vxlan_newlink, a default fdb entry is added before register_netdev. >> The default fd

[PATCH net-next 2/4] vxlan: add new fdb alloc and create helpers

From: Roopa Prabhu - Add new vxlan_fdb_alloc helper - rename existing vxlan_fdb_create into vxlan_fdb_update: because it really creates or updates an existing fdb entry - move new fdb creation into a separate vxlan_fdb_create Main motivation for this change is to introduce

[PATCH net-next 4/4] vxlan: fix default fdb entry netlink notify ordering during netdev create

From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function also notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

[PATCH net-next 3/4] vxlan: make netlink notify in vxlan_fdb_destroy optional

From: Roopa Prabhu Add a new option do_notify to vxlan_fdb_destroy to make sending netlink notify optional. Used by a later patch. Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/vxlan.c b

[PATCH net-next 1/4] rtnetlink: add rtnl_link_state check in rtnl_configure_link

From: Roopa Prabhu rtnl_configure_link sets dev->rtnl_link_state to RTNL_LINK_INITIALIZED and unconditionally calls __dev_notify_flags to notify user-space of dev flags. current call sequence for rtnl_configure_link rtnetlink_newlink rtnl_link_ops->newlink rtnl_configur

[PATCH net-next 0/4] vxlan: fix default fdb entry user-space notify ordering/race

From: Roopa Prabhu Problem: In vxlan_newlink, a default fdb entry is added before register_netdev. The default fdb creation function notifies user-space of the fdb entry on the vxlan device which user-space does not know about yet. (RTM_NEWNEIGH goes before RTM_NEWLINK for the same ifindex

[PATCH net] net: fib_rules: bring back rule_exists to match rule during add

From: Roopa Prabhu After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule"), rule_exists got replaced by rule_find for existing rule lookup in both the add and del paths. While this is good for the delete path, it solves a few problems bu

Re: [PATCH net] net: fib_rules: add protocol check in rule_find

On Thu, Jun 28, 2018 at 9:59 PM, Roopa Prabhu wrote: > On Wed, Jun 27, 2018 at 6:27 PM, Roopa Prabhu > wrote: >> From: Roopa Prabhu >> >> After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule >> delrule msgs into fib_nl2rule&qu

Re: [PATCH net] net: fib_rules: add protocol check in rule_find

On Wed, Jun 27, 2018 at 6:27 PM, Roopa Prabhu wrote: > From: Roopa Prabhu > > After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule > delrule msgs into fib_nl2rule"), rule_find is strict about checking > for an existing rule. rule_find must check

[PATCH net] net: fib_rules: add protocol check in rule_find

From: Roopa Prabhu After commit f9d4b0c1e969 ("fib_rules: move common handling of newrule delrule msgs into fib_nl2rule"), rule_find is strict about checking for an existing rule. rule_find must check against all user given attributes, else it may match against a subset of attributes

Re: [PATCH v2] fib_rules: match rules based on suppress_* properties too

On Tue, Jun 26, 2018 at 6:34 PM, David Miller wrote: > From: "Jason A. Donenfeld" > Date: Tue, 26 Jun 2018 01:39:32 +0200 > >> Two rules with different values of suppress_prefix or suppress_ifgroup >> are not the same. This fixes an -EEXIST when running: >> >>$ ip -4 rule add table main

Re: [PATCH v2] fib_rules: match rules based on suppress_* properties too

On Mon, Jun 25, 2018 at 4:39 PM, Jason A. Donenfeld wrote: > Two rules with different values of suppress_prefix or suppress_ifgroup > are not the same. This fixes an -EEXIST when running: > >$ ip -4 rule add table main suppress_prefixlength 0 > > Signed-off-by: Jason A. Donenfeld > Fixes:

[PATCH net-next] neighbour: force neigh_invalidate when NUD_FAILED update is from admin

From: Roopa Prabhu In systems where neigh gc thresh holds are set to high values, admin deleted neigh entries (eg ip neigh flush or ip neigh del) can linger around in NUD_FAILED state for a long time until periodic gc kicks in. This patch forces neigh_invalidate when NUD_FAILED neigh_update

Re: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength

On Mon, Jun 25, 2018 at 8:23 AM, Roopa Prabhu wrote: > On Sat, Jun 23, 2018 at 8:46 AM, Jason A. Donenfeld wrote: >> Hey Roopa, >> >> On a kernel with a minimal networking config, >> CONFIG_IP_MULTIPLE_TABLES appears to be bro

Re: [net regression] "fib_rules: move common handling of newrule delrule msgs into fib_nl2rule" breaks suppress_prefixlength

On Sat, Jun 23, 2018 at 8:46 AM, Jason A. Donenfeld wrote: > Hey Roopa, > > On a kernel with a minimal networking config, > CONFIG_IP_MULTIPLE_TABLES appears to be broken for certain rules after > f9d4b0c1e9695e3de7af3768205bacc27312320c. > > Try, for example, running: > > $ ip -4 rule add table

Re: [PATCH] fib_rules: match rules based on suppress_* properties too

On Sat, Jun 23, 2018 at 8:59 AM, Jason A. Donenfeld wrote: > Two rules with different values of suppress_prefix or suppress_ifgroup > are not the same. This fixes an -EEXIST when running: > >$ ip -4 rule add table main suppress_prefixlength 0 > > Signed-off-by: Jason A. Donenfeld > Fixes:

[PATCH net] neighbour: skip NTF_EXT_LEARNED entries during forced gc

From: Roopa Prabhu Commit 9ce33e46531d ("neighbour: support for NTF_EXT_LEARNED flag") added support for NTF_EXT_LEARNED for neighbour entries. NTF_EXT_LEARNED entries are neigh entries managed by control plane (eg: Ethernet VPN implementation in FRR routing suite). Periodic gc alread

[PATCH iproute2 net-next] iproute: ip route get support for sport, dport and ipproto match

From: Roopa Prabhu Signed-off-by: Roopa Prabhu --- ip/iproute.c | 26 +- man/man8/ip-route.8.in | 20 +++- 2 files changed, 44 insertions(+), 2 deletions(-) diff --git a/ip/iproute.c b/ip/iproute.c index 56dd9f2..ef04d27 100644 --- a/ip

Re: [PATCH net] net: ipv4: add missing RTA_TABLE to rtm_ipv4_policy

On Wed, May 23, 2018 at 12:04 PM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 22 May 2018 13:44:51 -0700 > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Signed-off-by: Roopa P

[PATCH net-next v5 3/3] selftests: net: initial fib rule tests

From: Roopa Prabhu <ro...@cumulusnetworks.com> This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by:

[PATCH net-next v5 0/3] fib rule selftest

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's c

[PATCH net-next v5 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- include/net/ip.h

[PATCH net-next v5 2/3] ipv6: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib6 rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/ipv6/

[PATCH net] net: ipv4: add missing RTA_TABLE to rtm_ipv4_policy

From: Roopa Prabhu <ro...@cumulusnetworks.com> Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/ipv4/fib_frontend.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 4d622112..e66172a 100644 --- a/net/ipv4/fi

Re: [lkp-robot] [selftests] 3f45449746: kernel_selftests.net.fib_rule_tests.sh.fail

ps://github.com/0day-ci/linux/commits/Roopa-Prabhu/ipv4-support-sport-dport-and-ip_proto-in-RTM_GETROUTE/20180518-051740 > > > in testcase: kernel_selftests > with following parameters: > > group: kselftests-02 > > test-description: The kernel contains a set of

Re: [PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

On Tue, May 22, 2018 at 8:04 AM, Eric Dumazet <eric.duma...@gmail.com> wrote: > > > On 05/22/2018 07:51 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> > > ... > >> diff --git a/net/ipv4/fib_frontend.c b/net

[PATCH net-next v4 3/3] selftests: net: initial fib rule tests

From: Roopa Prabhu <ro...@cumulusnetworks.com> This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by:

[PATCH net-next v4 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- include/net/ip.h

[PATCH net-next v4 2/3] ipv6: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib6 rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/ipv6/

[PATCH net-next v4 0/3] fib rule selftest

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's c

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

On Wed, May 16, 2018 at 7:36 PM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Wed, 16 May 2018 13:30:28 -0700 > >> yes, but we hold rcu read lock before calling the reply function for >> fib result. I did c

Re: [PATCH v2 net] net/ipv4: Initialize proto and ports in flow struct

ff4862653b ("net: fib_rules: support for match on ip_proto, sport > and dport") > Signed-off-by: David Ahern <dsah...@gmail.com> > --- LGTM, Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com>

Re: [PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

On Wed, May 16, 2018 at 11:37 AM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 15 May 2018 20:55:06 -0700 > >> +static int inet_rtm_getroute_reply(struct sk_buff *in_skb, struct nlmsghdr >> *nlh, >>

[PATCH net-next v3 0/3] fib rule selftest

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's c

[PATCH net-next v3 1/3] ipv4: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Before this patch getroute used same skb to pass through the route lookup and for the netlink ge

[PATCH net-next v3 2/3] ipv6: support sport, dport and ip_proto in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib6 rules sport, dport and ipproto match support. Only supports tcp, udp and icmp for ipproto. Used by fib rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/ipv6/

[PATCH net-next v3 3/3] selftests: net: initial fib rule tests

From: Roopa Prabhu <ro...@cumulusnetworks.com> This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by:

Re: [PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

On Sun, May 6, 2018 at 6:46 PM, David Ahern <d...@cumulusnetworks.com> wrote: > On 5/6/18 6:59 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This is a followup to fib rules sport, dport match support. >> Having them suppor

[PATCH net-next v2 2/3] ipv6: support sport and dport in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib6 rules sport and dport match support. Having them supported in getroute makes it easier to test fib6 rule lookups. Used by fib6 rule self tests. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/

[PATCH net-next v2 3/3] selftests: net: initial fib rule tests

From: Roopa Prabhu <ro...@cumulusnetworks.com> This adds a first set of tests for fib rule match/action for ipv4 and ipv6. Initial tests only cover action lookup table. can be extended to cover other actions in the future. Uses ip route get to validate the rule lookup. Signed-off-by:

[PATCH net-next v2 1/3] ipv4: support sport and dport in RTM_GETROUTE

From: Roopa Prabhu <ro...@cumulusnetworks.com> This is a followup to fib rules sport, dport match support. Having them supported in getroute makes it easier to test fib rule lookups. Used by fib rule self tests. Before this patch getroute used same skb to pass through the route

[PATCH net-next v2 0/3] fib rule selftest

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series adds a new test to test fib rules. ip route get is used to test fib rule matches. This series also extends ip route get to match on sport and dport to test recent support of sport and dport fib rule match. v2 - address ido's c

Re: [PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

On Wed, Apr 25, 2018 at 10:20 AM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 24 Apr 2018 13:49:34 -0700 > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch extends NT

[PATCH net-next] neighbour: support for NTF_EXT_LEARNED flag

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch extends NTF_EXT_LEARNED support to the neighbour system. Example use-case: An Ethernet VPN implementation (eg in FRR routing suite) can use this flag to add dynamic reachable external neigh entires learned via control plane. T

Re: [net-next regression] kselftest failure in fib_nl_newrule()

On Tue, Apr 24, 2018 at 2:46 AM, Anders Roxell wrote: > Hi, > > fib-onlink-tests.sh (from kselftest) found a regression between > next-20180424 [1] (worked with tag next-20180423 [2]) > > here is tree commits that look suspicious specially this patch (sha: >

Re: [PATCH net v2] net: ethtool: Add missing kernel doc for FEC parameters

ror correction > modes") > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> Thanks Florian.

  1   2   3   4   5   6   7   >