Re: [PATCH AUTOSEL 4.19 15/68] batman-adv: Expand merged fragment buffer for full packet

Hello! On 11/29/2018 08:55 AM, Sasha Levin wrote: > From: Sven Eckelmann > > [ Upstream commit d7d8bbb40a5b1f682ee6589e212934f4c6b8ad60 ] > > The complete size ("total_size") of the fragmented packet is stored in the > fragment header and in the size of the fragment chain. When the fragments

Re: [PATCH net-next] cxgb4: number of VFs supported is not always 16

Hello! On 27.11.2018 9:25, Ganesh Goudar wrote: Total number of VFs supported by PF is used determine the last ^ to byte of VF's mac address. Number of VFs supported is not always 16, use the variable nvfs to get the number of VFs supported

Re: [RFC PATCH] net: don't keep lonely packets forever in the gro hash

On 11/20/2018 01:17 PM, Paolo Abeni wrote: > Eric noted that with UDP GRO and napi timeout, we could keep a single NAPI, else you're simply inconsistent. > UDP packet inside the GRO hash forever, if the related NAPI instance > calls napi_gro_complete() at an higher frequency than the napi

Re: [net 01/13] net/mlx5: IPSec, Fix the SA context hash key

Hello! On 20.11.2018 2:41, Saeed Mahameed wrote: From: Raed Salem The commit "net/mlx5: Refactor accel IPSec code" introduced a You also need to cite the commit ID. bug where asynchronous short time change in hash key value by create/release SA context might happen during an

Re: [PATCH net] cxgb4: fix thermal zone build error

Hello! On 15.11.2018 12:23, Ganesh Goudar wrote: with CONFIG_THERMAL=m and cxgb4 as built-in build fails, and 'commit e70a57fa59bb ("cxgb4: fix thermal configuration dependencies")' tires to fix it but when cxgb4i is made built-in build fails again, Tries? :-) use IS_REACHABLE instead

Re: [PATCH] iucv: Remove SKB list assumptions.

Hello! On 11.11.2018 3:55, David Miller wrote: Eliminate the assumption that SKBs and SKB list heads can be cast to eachother in SKB list handling code. Each other? My spellchecker trips here. This change also appears to fix a bug since the list->next pointer is sampled outside of

Re: [PATCH net-next] net: dsa: mv88e6xxx: Work around mv886e6161 SERDES missing MII_PHYSID2

Hello! On 11.11.2018 2:50, Andrew Lunn wrote: We already have a workaround for a couple of switches whose internal PHYs only have the Marvel OUI, but no model number. We detect such PHYs and give them the 6390 ID as the model number. However the mv88e6161 has two SERDES interfaces in the same

Re: [PATCH net-next 05/10] ipv6: factor out protocol delivery helper

On 11/8/2018 1:13 PM, Paolo Abeni wrote: So that we can re-use it at the UDP level in the next patch rfc v3 -> v1: - add the helper declaration into the ipv6 header Signed-off-by: Paolo Abeni --- include/net/ipv6.h | 2 ++ net/ipv6/ip6_input.c | 28

Re: [PATCH net-next 05/10] ipv6: factor out protocol delivery helper

On 11/7/2018 2:38 PM, Paolo Abeni wrote: So that we can re-use it at the UDP level in the next patch rfc v3 -> v1: - add the helper declaration into the ipv6 header Signed-off-by: Paolo Abeni --- include/net/ipv6.h | 2 ++ net/ipv6/ip6_input.c | 28 2

Re: [Patch V4 net 01/11] net: hns3: add error handler for hns3_nic_init_vector_data()

On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_nic_init_vector_data() fails to map ring to vector, it should cancel the netif_napi_add() that has been successfully done and then exits. Fixes: 76ad4f0ee747 ("net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC") Signed-off-by:

Re: [Patch V4 net 02/11] net: hns3: add error handler for hns3_get_ring_config/hns3_queue_to_ring

Hello! On 10/29/2018 4:54 PM, Huazhong Tan wrote: When hns3_get_ring_config()/hns3_queue_to_ring() failed during resetting, the allocated memory has not been freed before hns3_get_ring_config() and hns3_queue_to_ring() return. So this patch fixes the buffer not freeing problem during

Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

On 10/29/2018 03:06 PM, John Hurley wrote: >>> Add a helper function to determine if the type of a netdev is geneve based >>> on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels >> >> Offload? >> > > offload encap/decap to a hardware device such as a smartNIC. > Sorry,

Re: [Patch V3 net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()

Hello! On 28.10.2018 6:34, Huazhong Tan wrote: It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be reset in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING Operation. flag in the

Re: [Patch net 09/11] net: hns3: bugfix for handling mailbox while the command queue reinitialized

On 27.10.2018 5:41, Huazhong Tan wrote: In a multi-core machine, the mailbox service and reset service will be executed at the same time. The reset server will re-initialize the commond queue, before that, the mailbox handler can only get some Command? invalid messages. The

Re: [Patch net 05/11] net: hns3: remove unnecessary queue reset in the hns3_uninit_all_ring()

Hello! On 27.10.2018 5:41, Huazhong Tan wrote: It is not necessary to reset the queue in the hns3_uninit_all_ring(), since the queue is stopped in the down operation, and will be resetted s/resetted/reset/. in the up operaton. And the judgment of the HCLGE_STATE_RST_HANDLING flag in the

Re: [RFC net-next v2 2/8] net: add netif_is_geneve()

Hello! On 25.10.2018 15:26, John Hurley wrote: Add a helper function to determine if the type of a netdev is geneve based on its rtnl_link_ops. This allows drivers that may wish to ofload tunnels Offload? to check the underlying type of the device. A recent patch added a similar helper

Re: [PATCH] net: ethernet:fec: Consistently use SPEED_ prefix

On 20.10.2018 23:48, Andrew Lunn wrote: All other calls to phy_set_max_speed() use the SPEED_ prefix. Make the FEC driver follow this common pattern. This makes no different to Difference. generated code since SPEED_1000 is 1000, and SPEED_100 is 100. Reported-by: Corentin Labbe

Re: [PATCH net-next] net: phy: phy_support_sym_pause: Clear Asym Pause

Hello! On 20.10.2018 23:41, Andrew Lunn wrote: When indicating the MAC supports Symmetric Pause, clear the Asymmetric Pause bit, which could of been already set is the PHY supports it. Could've been, s/is/if/. Reported-by: Labbe Corentin Fixes: c306ad36184f ("net: ethernet: Add helper

Re: [PATCH net-next] net: ena: Fix Kconfig dependencies X86

Hello! On 17.10.2018 11:16, neta...@amazon.com wrote: From: Netanel Belgazal The Kconfig limitation of X86 is to too wide. The ENA driver only requires a little endian dependency. Change the dependency to be on little endian CPU. Signed-off-by: Netanel Belgazal ---

Re: [PATCH v2] rxrpc: use correct kvec num while send response packet in rxrpc_reject_packets

On 10/09/2018 05:15 PM, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > net/rxrpc/output.c: In function 'rxrpc_reject_packets': > net/rxrpc/output.c:527:11: warning: > variable 'ioc' set but not used [-Wunused-but-set-variable] > > 'ioc' is the correct kvec num while

Re: [PATCH net-next 02/11] net: sched: cls_u32: make sure that divisor is a power of 2

Hello! On 07.10.2018 19:38, Jamal Hadi Salim wrote: From: Al Viro Tested by modifying iproute2 to to allow One "to" is enough, no? :-) sending a divisor > 255 Tested-by: Jamal Hadi Salim Signed-off-by: Al Viro Signed-off-by: Jamal Hadi Salim [...] MBR, Sergei

Re: [net-next 07/13] ixgbe: Fix crash with VFs and flow director on interface flap

Hello! On 10/3/2018 11:25 PM, Jeff Kirsher wrote: From: Radoslaw Tyl This patch fix crash when we have restore flow director filters after reset Fixes. Restored? adapter. In ixgbe_fdir_filter_restore() filter->action is outside of the rx_ring array, as it has a VF identifier in the

Re: [net-next 02/13] ixgbe: Fix ixgbe TX hangs with XDP_TX beyond queue limit

Hello! On 10/3/2018 11:25 PM, Jeff Kirsher wrote: From: Radoslaw Tyl We have Tx hang when number Tx and XDP queues are more than 64. ^ of In XDP always is MTQC == 0x0 (64TxQs). We need more space for Tx queues. Signed-off-by: Radoslaw Tyl Tested-by: Andrew

Re: [PATCH 5/6] xfrm: Fix NULL pointer dereference when skb_dst_force clears the dst_entry.

On 10/01/2018 11:58 AM, Steffen Klassert wrote: > Since commit 222d7dbd258d ("net: prevent dst uses after free") > skb_dst_force() might clear the dst_entry attached to the skb. > The xfrm code don't expect this to happen, so we crash with Doesn't. > a NULL pointer dereference in this case.

Re: [PATCH v2 net-next 7/8] net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES

Hello! On 9/30/2018 12:04 AM, Andrew Lunn wrote: The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to support link_modes. Remove its use from xgde by replacing it with its definition. Probably, the current behavior is wrong. It probably should be ANDing not assigning.

Re: [net-next 1/8] ice: use [sr]q.count when checking if queue is initialized

Hello! On 9/27/2018 7:21 PM, Jeff Kirsher wrote: From: Jacob Keller When shutting down the controlqs, we check if they are initialized before we shut them down and destroy the lock. This is important, as it prevents attempts to access the lock of an already shutdown queue. Unfortunately, we

Re: [PATCH net] net: phy: sfp: Fix unregistering of HWMON SFP device

Hello! On 9/25/2018 1:38 AM, Andrew Lunn wrote: A HWMON device is only registered is the SFP module supports the s/is/if/? diagnostic page and is complient to SFF8472. Don't unconditionally Compliant? unregister the hwmon device when the SFP module is remove, otherwise we access

Re: [PATCH net-next] ravb: Disable Pause Advertisement

t and > remove the Pause and Asym Pause modes, so restoring the old behavior. > > Reported-by: Simon Horman > Fixes: 41124fa64d4b ("net: ethernet: Add helper to remove a supported link > mode") > Signed-off-by: Andrew Lunn [...] Reviewed-by: Sergei Shtylyov MBR, Sergei

Re: [PATH RFC net-next 6/8] net: ethernet xgbe expand PHY_GBIT_FEAUTRES

On 9/15/2018 12:38 AM, Andrew Lunn wrote: The macro PHY_GBIT_FEAUTRES needs to change into a bitmap in order to support link_modes. Remove its use from xgde by replacing it with its definition. Probably, the current behavior is wrong. It probably should be ANDing not assigning. Signed-off-by:

Re: [PATCH] net: caif: remove redundant null check on frontpkt

Hello! On 09/14/2018 08:19 PM, Colin King wrote: > From: Colin Ian King > > It is impossible for frontpkt to be null at the point of the null > check because it has been assigned from rearpkt and there is no > way realpkt can be null at the point of the assignment because rearpkt? > of

Re: [PATCH v2 net-next 05/12] net: ethernet: genet: Fix speed selection

Hello! On 9/11/2018 12:52 AM, Andrew Lunn wrote: The phy supported speed is being used to determine if the MAC should be configured to 100 or 1G. The masking logic is broken. Instead, look Look at? 1G supported speeds to enable 1G MAC support. Signed-off-by: Andrew Lunn [...] MBR,

Re: [PATCH net-next 13/15] net: Add and use skb_list_del_init().

Hello! On 9/8/2018 11:11 PM, David Miller wrote: It documents what is happening, and eliminates the spurious list pointer poisoning. In the long term, in order to get proper list head debugging, we might want to use the list poinson value as the indicator that Poison? an SKB is a

Re: [PATCH 2/3] IB/ipoib: Stop using dev_id to expose port numbers

Hello! On 8/29/2018 12:01 AM, Arseny Maslennikov wrote: Some InfiniBand network devices have multiple ports on the same PCI function. Prior to this the kernel erroneously used the `dev_id' sysfs field of those network interfaces to convey the port number to userspace. `dev_id' is currently

Re: [net 07/13] ice: Use order_base_2 to calculate higher power of 2

On 08/24/2018 06:39 PM, Keller, Jacob E wrote: >>> From: Jacob Keller >>> >>> Currently, we use a combination of ilog2 and is_power_of_2() to >>> calculate the next power of 2 for the qcount. This appears to be causing >>> a warning on some combinations of GCC and the Linux kernel: >>> >>>

Re: [net 07/13] ice: Use order_base_2 to calculate higher power of 2

Hello! On 8/23/2018 10:14 PM, Jeff Kirsher wrote: From: Jacob Keller Currently, we use a combination of ilog2 and is_power_of_2() to calculate the next power of 2 for the qcount. This appears to be causing a warning on some combinations of GCC and the Linux kernel: MODPOST 1 modules

Re: [PATCH bpf] tools: bpftool: return from do_event_pipe() on bad arguments

Hello! On 08/23/2018 07:46 PM, Quentin Monnet wrote: > When command line parsing fails in the while loop in do_event_pipe() > because the number of arguments is incorrect or because the keyword is > unknown, an error message is displayed, but bpfool bp-who? ;-) > remains stucked in

Re: [PATCH net-next 9/9] bindings: net: stmmac: Add the bindings documentation for XGMAC2.

Hello! On 08/01/2018 03:10 PM, Jose Abreu wrote: > Adds the documentation for XGMAC2 DT bindings. > > Signed-off-by: Jose Abreu > Cc: David S. Miller > Cc: Joao Pinto > Cc: Giuseppe Cavallaro > Cc: Alexandre Torgue > --- > Documentation/devicetree/bindings/net/stmmac.txt | 3 ++- > 1 file

Re: [PATCH 1/4] docs: bpf: Rename README.rst to index.rst

Hello! On 7/25/2018 5:29 AM, Tobin C. Harding wrote: Recently bpf/ docs were converted to us RST format. 'README.rst' was s/us/use/? created but in order to fit in with the Sphinx build system this file should be named 'index.rst'. Rename file, fixes to integrate into Sphinx build

Re: [PATCH v3 bpf 1/3] bpf: btf: Sync uapi btf.h to tools

On 7/24/2018 6:40 PM, Martin KaFai Lau wrote: This patch sync the uapi btf.h to tools/ Fixes: 36fc3c8c282c bpf: btf: Clean up BTF_INT_BITS() in uapi btf.h Should be: Fixes: 36fc3c8c282c ("bpf: btf: Clean up BTF_INT_BITS() in uapi btf.h") Signed-off-by: Martin KaFai Lau Acked-by:

Re: [PATCH] netfilter: avoid stalls in nf_ct_alloc_hashtable

Hello! On 7/24/2018 10:19 AM, Li RongQing wrote: when system forks a process with CLONE_NEWNET flag under the high memory pressure, it will trigger memory reclaim and stall for a long time because nf_ct_alloc_hashtable need to allocate high-order memory at that time. The calltrace as below:

Re: [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 7/9/2018 2:24 AM, Sergei Shtylyov wrote:     So you applied the whole series to net.git... that was somewhat     unexpected, at least by me. Care to share your reasoning? It's fixes a sleep in atomic which is a serious bug.    Do you realize that only patches 0, 1, 8, and 9 were real

Re: [PATCH v2 00/14] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

Hello! On 7/8/2018 2:58 AM, David Miller wrote: So you applied the whole series to net.git... that was somewhat unexpected, at least by me. Care to share your reasoning? It's fixes a sleep in atomic which is a serious bug. Do you realize that only patches 0, 1, 8, and 9 were

Re: [PATCH] net: core: improve the tx_hash calculating

Hello! On 5/31/2018 1:14 PM, Tonghao Zhang wrote: Use the % instead of while, and it may simple code and improve the calculating. The real_num_tx_queues has been checked when allocating and setting it. Signed-off-by: Tonghao Zhang --- net/core/dev.c | 8 +++- 1 file changed, 3

Re: [PATCH net-next] net: remove bypassed check in sch_direct_xmit()

Hello! On 5/29/2018 12:36 AM, Song Liu wrote: Check sch_direct_xmit() at the end of sch_direct_xmit() will be bypassed. "Checking netif_xmit_frozen_or_stopped()", perhaps? Else it doesn't make much sense... This is because "ret" from sch_direct_xmit() will be either NETDEV_TX_OK or

Re: [PATCH 3/6] ravb: remove custom .set_link_ksettings from ethtool ops

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .set_link_ksettings > callback with a shared phy_ethtool_set_link_ksettings(), this fixes > sleep in atomic context bug, which is encountered every time when link > settings are changed by ethtool.

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

On 05/26/2018 09:46 PM, Sergei Shtylyov wrote: >> The change fixes a sleep in atomic context issue, which can be >> always triggered by running 'ethtool -r' command, because >> phy_start_aneg() protects phydev fields by a mutex. > >Again, I'm unable to reproduce thi

Re: [PATCH 4/6] sh_eth: remove custom .nway_reset from ethtool ops

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. Again, I'm unable to reproduce this BUG()... > Another note is

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. BTW, I was unable to trigger the BUG() with 'ethtool -r eth0'

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 05/25/2018 09:25 AM, Vladimir Zapolskiy wrote: For ages trivial changes to RAVB and SuperH ethernet links by means of standard 'ethtool' trigger a 'sleeping function called from invalid context' bug, to visualize it on r8a7795 ULCB: % ethtool -r eth0 BUG:

Re: [PATCH 2/6] ravb: remove custom .get_link_ksettings from ethtool ops

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change replaces a custom implementation of .get_link_ksettings > callback with a shared phy_ethtool_get_link_ksettings(), note that > >lock wrapping is not needed, because the lock does not > serialize access to phydev fields. No BUG()

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

Hello. A formal patch review this time... On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. OK so far... >

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

Hello. A formal patch review this time... On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. OK so far... >

Re: [PATCH] rtnetlink: Add more well known protocol values

Hello! On 5/25/2018 9:20 PM, Donald Sharp wrote: FRRouting installs routes into the kernel associated with the originating protocol. Add these values to the well known values in rtnetlink.h. Signed-off-by: Donald Sharp --- include/uapi/linux/rtnetlink.h | 5

Re: [PATCH 1/2] batman-adv: Remove "default n" in Kconfig

. And it's "a", not "an" in this case. :-) Reported-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Signed-off-by: Sven Eckelmann <s...@narfation.org> [...] MBR, Sergei

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On 05/25/2018 02:15 PM, Sven Eckelmann wrote: >>> [...] > --- a/net/batman-adv/Kconfig > +++ b/net/batman-adv/Kconfig > @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS > bool "batman-adv debugfs entries" > depends on BATMAN_ADV > depends on DEBUG_FS > - default y

Re: [PATCH] ath6kl: mark expected switch fall-throughs

Hello! On 5/25/2018 2:13 AM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- drivers/net/wireless/ath/ath6kl/cfg80211.c | 6 +++--- 1 file

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

On 5/25/2018 1:50 PM, Sven Eckelmann wrote: [...] --- a/net/batman-adv/Kconfig +++ b/net/batman-adv/Kconfig @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS bool "batman-adv debugfs entries" depends on BATMAN_ADV depends on DEBUG_FS - default y + default n N is the default

Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by default

Hello! On 5/24/2018 3:02 PM, Simon Wunderlich wrote: From: Sven Eckelmann All tools which were known to the batman-adv development team are supporting the batman-adv netlink interface since a while. Also debugfs is not supported for batman-adv interfaces in any

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 05/24/2018 07:40 PM, Sergei Shtylyov wrote: >> For ages trivial changes to RAVB and SuperH ethernet links by means of >> standard 'ethtool' trigger a 'sleeping function called from invalid >> context' bug, to visualize it on r8a7795 ULCB: >> >> % ethtool -r et

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

On 05/24/2018 07:44 PM, Andrew Lunn wrote: > The change fixes a sleep in atomic context issue, which can be > always triggered by running 'ethtool -r' command, because > phy_start_aneg() protects phydev fields by a mutex. >> >> You don't say that *not* grabbing the spinlock is

Re: [PATCH 0/6] ravb/sh_eth: fix sleep in atomic by reusing shared ethtool handlers

On 05/24/2018 02:11 PM, Vladimir Zapolskiy wrote: > For ages trivial changes to RAVB and SuperH ethernet links by means of > standard 'ethtool' trigger a 'sleeping function called from invalid > context' bug, to visualize it on r8a7795 ULCB: > > % ethtool -r eth0 > BUG: sleeping function

Re: [PATCH 1/6] ravb: remove custom .nway_reset from ethtool ops

Hello! On 05/24/2018 05:11 PM, Vladimir Zapolskiy wrote: >>> The change fixes a sleep in atomic context issue, which can be >>> always triggered by running 'ethtool -r' command, because >>> phy_start_aneg() protects phydev fields by a mutex. You don't say that *not* grabbing the spinlock is

Re: [PATCH 30/31] timerfd: convert to ->poll_mask

Hello! On 05/22/2018 02:31 PM, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig > --- > fs/timerfd.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/fs/timerfd.c b/fs/timerfd.c > index cdad49da3ff7..d84a2bee4f82 100644

[PATCH 3/3] sh_eth: fix typo in comment to BCULR write

Simon has noticed a typo in the comment accompaining the BCULR write -- fix it and move the comment before the write (following the style of the other comments), while at it... Reported-by: Simon Horman <ho...@verge.net.au> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentemb

[PATCH 2/3] sh_eth: fix comment grammar in 'struct sh_eth_cpu_data'

All the verbs in the comments to the 'struct sh_eth_cpu_data' declaration should be in a 3rd person singular, to match the nouns. Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.h | 22 +++--- 1 file chang

[PATCH 1/3] sh_eth: fix typo in EESR.TRO bit name

The correct name of the EESR bit 8 is TRO (transmit retry over), not RTO. Note that EESIPR bit 8, TROIP remained correct... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.c | 10 +- drivers/net/ethernet/renesas/sh

[PATCH 0/3] sh_eth: fix typos/grammar

Hello! Here's a set of 3 patches against DaveM's 'net-next.git' repo plus the R8A77980 support patches posted earlier. They fix the comments typos/grammar and another typo in the EESR bit... [1/1] sh_eth: fix typo in EESR.TRO bit name [2/3] sh_eth: fix comment grammar in 'struct sh_eth_cpu_data'

[PATCH v2 3/3] sh_eth: add R8A77980 support

com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> --- Changes in version 2: - added Simon's tag. Documentation/devicetree/bindings/net/sh_eth.txt |1 drivers/net/ethernet/renesas/sh_eth.c

[PATCH v2 2/3] sh_eth: add EDMR.NBST support

ed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> --- Changes in version 2: - added Simon's tag. drivers/net/ethernet/renesas/sh_eth.c |4 drivers/net/ethernet/renesas/sh_eth.h |2 ++ 2 files changed, 6 in

[PATCH v2 1/1] sh_eth: add RGMII support

The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII PHY interface mode as a new value for the RMII_MII register. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> Signed-off-by:

[PATCH v2 0/3] Add Renesas R8A77980 GEther support

Hello! Here's a set of 3 patches against DaveM's 'net-next.git' repo. They (gradually) add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new register bits/values introduced with this chip, and ending with adding a new 'struct sh_eth_cpu_data' instance connected to the new

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

On 05/18/2018 02:37 PM, Pavel Tatashin wrote: > * parallelized this function, so drop lock for the >> >> Parallelizing? Else the sentence doesn't parse for me. :-) My comment hardly makes sense when you removed all the context... > Hi Sergei, > > In a separate series I

Re: [PATCH 0/3] Add R8A77980 GEther support

On 05/17/2018 09:53 PM, David Miller wrote: >> Here's a set of 3 patches against DaveM's 'net-next.git' repo. They >> (gradually) >> add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new >> register bits/values introduced with this chip, and ending with adding a new >>

Re: [PATCH v2] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

e...@glider.be> > Acked-by: Arnd Bergmann <a...@arndb.de> > Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > Reviewed-by: Simon Horman <horms+rene...@verge.net.au> [...] MBR, Sergei

Re: [net-next 3/6] ixgbe: release lock for the duration of ixgbe_suspend_close()

Hello! On 5/17/2018 7:37 PM, Jeff Kirsher wrote: From: Pavel Tatashin Currently, during device_shutdown() ixgbe holds rtnl_lock for the duration of lengthy ixgbe_close_suspend(). On machines with multiple ixgbe cards this lock prevents scaling if device_shutdown()

Re: [PATCH net-next] net: NET_VENDOR_MICROSEMI should default ot N

On 05/17/2018 06:43 PM, David Ahern wrote: > Other ethernet drivers default to N. There is no reason for Microsemi > to default to y. I believe Linus has set the bar at a feature that cures > cancer can be enabled by default. [1] > > [1] https://lkml.org/lkml/2010/3/2/366 > > Signed-off-by:

Re: [PATCH 1/3] sh_eth: add RGMII support

On 5/16/2018 11:37 PM, Andrew Lunn wrote: What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID, PHY_INTERFACE_MODE_RGMII_TXID, Oops, totally forgot about those... :-/ Everybody does. I keep intending to write a email template for this, and

Re: [PATCH 1/3] sh_eth: add RGMII support

> Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> >> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> >> >> --- >> drivers/net/ethernet/renesas/sh_eth.c |3 +++ >> 1 file change

Re: [PATCH net-next v2 2/2] drivers: net: Remove device_node checks with of_mdiobus_register()

ret = mdiobus_register(mdp->mii_bus); > - } > + if (pd->phy_irq > 0) > + mdp->mii_bus->irq[pd->phy] = pd->phy_irq; > > + ret = of_mdiobus_register(mdp->mii_bus, dev->of_node); > if (ret) > goto out_free_b

[PATCH 3/3] sh_eth: add R8A77980 support

com> Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- Documentation/devicetree/bindings/net/sh_eth.txt |1 drivers/net/ethernet/renesas/sh_eth.c| 44 +++ 2 files changed, 45 insertions(+) Index: net-next/Documentation/devicet

[PATCH 2/3] sh_eth: add EDMR.NBST support

ed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.c |4 drivers/net/ethernet/renesas/sh_eth.h |2 ++ 2 files changed, 6 insertions(+) Index: net-next/drivers/net/ethernet/rene

[PATCH 1/3] sh_eth: add RGMII support

The R-Car V3H (AKA R8A77980) GEther controller adds support for the RGMII PHY interface mode as a new value for the RMII_MII register. Based on the original (and large) patch by Vladimir Barinov. Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> Signed-off-by:

[PATCH 0/3] Add R8A77980 GEther support

Hello! Here's a set of 3 patches against DaveM's 'net-next.git' repo. They (gradually) add R8A77980 GEther support to the 'sh_eth' driver, starting with couple new register bits/values introduced with this chip, and ending with adding a new 'struct sh_eth_cpu_data' instance connected to the new

Re: [RFC v4 5/5] virtio_ring: enable packed ring

On 05/16/2018 01:21 PM, Tiwei Bie wrote: >>> Signed-off-by: Tiwei Bie >>> --- >>> drivers/virtio/virtio_ring.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c >>> index de3839f3621a..b158692263b0

Re: [RFC v4 5/5] virtio_ring: enable packed ring

On 5/16/2018 11:37 AM, Tiwei Bie wrote: Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c index de3839f3621a..b158692263b0 100644 ---

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

On 5/13/2018 10:58 AM, Simon Horman wrote: Add documentation for r8a77990 compatible string to renesas ravb device tree bindings documentation. Signed-off-by: Yoshihiro Shimoda I'm assuming this isn't targetted at one of my trees. Just FYI. Hi Dave, I

Re: [PATCH net-next] net: stmmac: Add Jose Abreu as co-maintainer

Hello! On 5/14/2018 12:29 PM, Jose Abreu wrote: I'm offering to be a co-maintainer for stmmac driver. As per discussion with Alexandre, I will arranje to get STM32 boards to Arrange. :-) test patches in GMAC version 3.x and 4.1. I also have HW to test GMAC version 5. Looking forward

Re: [PATCH v2] ipvlan: flush arp table when mac address changed

Hello. On 5/14/2018 12:22 PM, liuq...@huawei.com wrote: From: Keefe Liu When master device's mac has been changed, the commit <32c10bbfe914> "ipvlan: always use the current L2 addr of the master" makes the IPVlan devices's mac changed commit 32c10bbfe914 ("ipvlan:

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

On 5/14/2018 11:22 AM, Marco Felsch wrote: From: Markus Niebel handle errata #2 for KSZ9031: force 1000Base-T master Attention: enabling the workaround will cause no link to other GIGE master. Signed-off-by: Markus Niebel

Re: [PATCH] net: phy: micrel: workaround for errata #2 for KSZ9031

Hello! On 5/14/2018 11:22 AM, Marco Felsch wrote: From: Markus Niebel handle errata #2 for KSZ9031: force 1000Base-T master Attention: enabling the workaround will cause no link to other GIGE master. Signed-off-by: Markus Niebel

Re: [PATCH] [PATCH net v2] ipv6: remove min MTU check for ipsec tunnels

Hello! On 5/10/2018 8:19 PM, Ashwanth Goli wrote: With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU" When you cite a comnmit, you must specify at least 12-digit SHA1 and enclose the summary in (""), not just "". ipsec tunnels that report a MTU less than IPV6_MIN_MTU are

Re: [PATCH] [PATCH net v2] ipv6: remove min MTU check for ipsec tunnels

On 5/11/2018 12:02 PM, Sergei Shtylyov wrote: With 749439bfac "fix udpv6 sendmsg crash caused by too small MTU"    When you cite a comnmit, you must specify at least 12-digit SHA1 and enclose the summary in (""), not just "". ipsec tunnels that repor

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

On 5/11/2018 6:18 AM, Yoshihiro Shimoda wrote: Add documentation for r8a77990 compatible string to renesas ravb device tree bindings documentation. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> [...] Acked-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.

Re: [PATCH net-next] net/core: delete the no need variable description in devlink_resource_register() comment

Hello! On 5/10/2018 6:28 AM, Sun Lianwen wrote: The variable "top_hierarchy" and "reload_required" is not existence in Don't exist, you mean? devlink_resource_register() Signed-off-by: Sun Lianwen [...] MBR, Sergei

[PATCH 2/2] sh_eth: WARN_ON() access to unimplemented TSU register

atter pair of accessors, it makes sense to check for the unimplemented TSU registers as well... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/ethernet/renesas/sh_eth.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Index: net-

[PATCH 1/2] sh_eth: use TSU register accessors for TSU_POST

There's no particularly good reason TSU_POST registers get accessed circumventing sh_eth_tsu_{read|write}() -- start using those, removing (badly named) sh_eth_tsu_get_post_reg_offset(), while at it... Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- drivers/net/et

[PATCH 0/2] sh_eth: complain on access to unimplemented TSU registers

Hello! Here's a set of 2 patches against DaveM's 'net-next.git' repo. The 1st patch routes TSU_POST register accesses thru sh_eth_tsu_{read|write}() and the 2nd added WARN_ON() unimplemented register to those functions. I'm going to deal with TSU_ADR{H|L} registers in a later series... [1/2]

Re: [PATCH V9 net-next 03/14] net: Add Software fallback infrastructure for socket dependent offloads

Hello! On 4/29/2018 11:06 AM, Boris Pismenny wrote: From: Ilya Lesokhin With socket dependent offloads we rely on the netdev to transform the transmitted packets before sending them to the wire. When a packet from an offloaded socket is rerouted to a different device we

Re: [PATCH v5 net-next 3/3] lan78xx: Modify error messages

Hello! On 04/27/2018 09:47 PM, Raghuram Chary J wrote: > Modify the error messages when phy registration fails. > > Signed-off-by: Raghuram Chary J > --- > drivers/net/usb/lan78xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

[PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

Document the R-Car V3H (R8A77980) SoC support in the R-Car CAN-FD bindings. Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> --- The patch is against the 'linux-can-next.git' repo plus the R8A77970 bindings patch posted yesterday. Although I wouldn't object if they'r

  1   2   3   4   5   6   7   8   9   10   >