Re: [iproute PATCH] man: ip-route.8: Fix ENCAP references in synopsis

2018-11-30 Thread Simon Horman
Hi Phil, On Wed, Nov 28, 2018 at 12:12:32PM +0100, Phil Sutter wrote: > The different encapsulation types are described in ENCAP_* > non-terminals, but ENCAP definition lists them without the ENCAP_ > prefix. Fix this for consistency. > > Signed-off-by: Phil Sutter > --- >

Re: [PATCH][resend] can: rcar_can: convert to SPDX identifiers

2018-11-30 Thread Simon Horman
On Wed, Nov 28, 2018 at 06:12:16AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto > Acked-by: Ramesh Shanmugasundaram Reviewed-by: Simon Horman

Re: [PATCHv2 net] ipvs: call ip_vs_dst_notifier earlier than ipv6_dev_notf

2018-11-19 Thread Simon Horman
On Sat, Nov 17, 2018 at 07:14:57PM +0100, Pablo Neira Ayuso wrote: > On Sat, Nov 17, 2018 at 09:19:52PM +0900, Xin Long wrote: > > On Sat, Nov 17, 2018 at 8:15 PM Pablo Neira Ayuso > > wrote: > > > > > > On Fri, Nov 16, 2018 at 06:37:19AM -0800, Simon Horman wr

Re: [PATCH v2 net] mpls: allow routes on ip6gre devices

2018-10-03 Thread Simon Horman
1c1d 1e1f 2021 2223 .!"# > 0x0080: 2425 2627 2829 2a2b 2c2d 2e2f 3031 3233 $%&'()*+,-./0123 > 0x0090: 3435 3637 4567 > ``` > > Signed-off-by: Saif Hasan This appears to be consistent with work I did to enable MPLS over SIT, IPI

[PATCH iproute2-next] tc: f_flower: add geneve option match support to flower

2018-09-28 Thread Simon Horman
:80:1122334421314151/:ff: \ ip_proto udp \ action mirred egress redirect dev eth1 Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- man/man8/tc-flower.8 | 13 ++- tc/f_flower.c| 282

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-25 Thread Simon Horman
On Fri, Sep 21, 2018 at 03:01:44PM +0200, Andrew Lunn wrote: > > Thanks Andrew, > > > > it seems that removing Aysm Pause does the trick. > > Great. > > I will submit the patch today. > > I see two possible followups: > > 1) Figure out why auto-neg does not complete when Pause is >

Re: [PATCH net-next] ravb: Disable Pause Advertisement

2018-09-25 Thread Simon Horman
e the Pause and Asym Pause modes, so restoring the old behavior. > > Reported-by: Simon Horman > Fixes: 41124fa64d4b ("net: ethernet: Add helper to remove a supported link > mode") > Signed-off-by: Andrew Lunn Tested-by: Simon Horman Reviewed-by: Simon Horman

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-21 Thread Simon Horman
Subject: [PATCH] ravb: Disable Pause Advertisement > > The previous commit to ravb had the side effect of making the PHY > advertise Pause. This previously did not happen, and it appears the > MAC does not support Pause. By default, phydev->supported has Pause > enabled, but phyd

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-18 Thread Simon Horman
On Mon, Sep 17, 2018 at 05:38:11PM +0200, Andrew Lunn wrote: > On Mon, Sep 17, 2018 at 05:13:07PM +0200, Simon Horman wrote: > > On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote: > > > Some MAC hardware cannot support a subset of link modes. e.g. often >

Re: [PATCH v3 net-next 07/12] net: ethernet: Add helper to remove a supported link mode

2018-09-17 Thread Simon Horman
On Wed, Sep 12, 2018 at 01:53:14AM +0200, Andrew Lunn wrote: > Some MAC hardware cannot support a subset of link modes. e.g. often > 1Gbps Full duplex is supported, but Half duplex is not. Add a helper > to remove such a link mode. > > Signed-off-by: Andrew Lunn > Reviewed-by: Florian Fainelli

[PATCH net-next 5/6] nfp: flower: add geneve option push action offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce new push geneve option action. This allows offloading filters configured to entunnel geneve with options. Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower

[PATCH net-next 2/6] nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl

2018-08-07 Thread Simon Horman
From: John Hurley The addition of FLOW_DISSECTOR_KEY_ENC_IP to TC flower means that the ToS and TTL of the tunnel header can now be matched on. Extend the NFP tunnel match function to include these new fields. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman

[PATCH net-next 4/6] net/sched: allow flower to match tunnel options

2018-08-07 Thread Simon Horman
. And be done in a way that drivers that facilitate offload of the Flower classifier can reject or accept such flows based on hardware datapath capabilities. This approach was discussed and agreed on at Netconf 2018 in Seoul. Signed-off-by: Simon Horman Signed-off-by: Pieter Jansen van Vuuren

[PATCH net-next 6/6] nfp: flower: add geneve option match offload

2018-08-07 Thread Simon Horman
From: Pieter Jansen van Vuuren Introduce a new layer for matching on geneve options. This allows offloading filters configured to match geneve with options. Signed-off-by: Pieter Jansen van Vuuren Signed-off-by: Simon Horman --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 6

[PATCH net-next 3/6] flow_dissector: allow dissection of tunnel options from metadata

2018-08-07 Thread Simon Horman
classifier makes that call. So there should be no impact on other users of the flow dissector. This is in preparation for allowing the flower classifier to match on Geneve options. Signed-off-by: Simon Horman Signed-off-by: Pieter Jansen van Vuuren Reviewed-by: Jakub Kicinski --- include/net

[PATCH net-next 1/6] nfp: flower: set ip tunnel ttl from encap action

2018-08-07 Thread Simon Horman
From: John Hurley The TTL for encapsulating headers in IPv4 UDP tunnels is taken from a route lookup. Modify this to first check if a user has specified a TTL to be used in the TC action. Signed-off-by: John Hurley Reviewed-by: Jakub Kicinski Signed-off-by: Simon Horman --- drivers/net

[PATCH net-next 0/6] nfp: flower: tunnel TTL & TOS, and Geneve options set & match support

2018-08-07 Thread Simon Horman
nel ttl from encap action nfp: flower: allow matching on ipv4 UDP tunnel tos and ttl Pieter Jansen van Vuuren (3): net/sched: allow flower to match tunnel options nfp: flower: add geneve option push action offload nfp: flower: add geneve option match offload Simon Horman (1): flow_diss

Re: [PATCH net-next] net: sched: refactor flower walk to iterate over idr

2018-07-13 Thread Simon Horman
On Tue, Jul 10, 2018 at 08:02:10PM +0300, Vlad Buslov wrote: > > On Tue 10 Jul 2018 at 13:55, Simon Horman wrote: > > On Mon, Jul 09, 2018 at 01:29:11PM +0300, Vlad Buslov wrote: > >> Extend struct tcf_walker with additional 'cookie' field. It is intended to > >&

Re: [PATCH net-next] net: sched: refactor flower walk to iterate over idr

2018-07-10 Thread Simon Horman
g flower classifier from > quadratic to linearithmic. (assuming idr lookup has logarithmic complexity) > > Reviewed-by: Jiri Pirko > Signed-off-by: Vlad Buslov Reported-by: Simon Horman Thanks, I'm very pleased to see this change. I would appreciate it if we could have a little time to test

Re: [PATCH iproute2] man: Fix typos on tc-cbs

2018-07-05 Thread Simon Horman
Some changelog text should go here. On Wed, Jun 27, 2018 at 10:50:51AM -0700, Jesus Sanchez-Palencia wrote: > Signed-off-by: Jesus Sanchez-Palencia Otherwise, this seems fine to me. Reviewed-by: Simon Horman > --- > man/man8/tc-cbs.8 | 4 ++-- > 1 file changed, 2 insertions(+),

Re: [PATCH net 0/5] net sched actions: code style cleanup and fixes

2018-06-20 Thread Simon Horman
et sched actions: fix coding style in pedit headers > net sched actions: fix sparse warning > net sched actions: use sizeof operator for buffer length > net sched actions: fix misleading text strings in pedit action All patches: Reviewed-by: Simon Horman

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

2018-06-11 Thread Simon Horman
On Mon, Jun 11, 2018 at 10:57:42AM -0700, Eric Biggers wrote: > Hi Simon, > > On Mon, Jun 11, 2018 at 11:40:23AM +0200, Simon Horman wrote: > > On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > My recen

Re: [PATCH net] KEYS: DNS: fix parsing multiple options

2018-06-11 Thread Simon Horman
On Fri, Jun 08, 2018 at 09:20:37AM -0700, Eric Biggers wrote: > From: Eric Biggers > > My recent fix for dns_resolver_preparse() printing very long strings was > incomplete, as shown by syzbot which still managed to hit the > WARN_ONCE() in set_precision() by adding a crafted "dns_resolver" key:

Re: [PATCH net v2] net/sched: act_simple: fix parsing of TCA_DEF_DATA

2018-06-08 Thread Simon Horman
message, thanks Hangbin Liu > > Fixes: fa1b1cff3d06 ("net_cls_act: Make act_simple use of netlink policy.") > Signed-off-by: Davide Caratti Reviewed-by: Simon Horman

Re: [PATCH iproute2] configure: require libmnl

2018-06-05 Thread Simon Horman
nger Reviewed-by: Simon Horman

Re: [PATCH net-next V2 2/2] cls_flower: Fix comparing of old filter mask with new filter

2018-06-04 Thread Simon Horman
y") > Reported-by: Vlad Buslov > Reviewed-by: Roi Dayan > Reviewed-by: Jiri Pirko > Signed-off-by: Paul Blakey Reviewed-by: Simon Horman

Re: [PATCH net-next V2 1/2] cls_flower: Fix missing free of rhashtable

2018-06-04 Thread Simon Horman
by: Jiri Pirko > Signed-off-by: Paul Blakey Reviewed-by: Simon Horman

Re: [PATCH 3/3] sh_eth: add R8A77980 support

2018-05-17 Thread Simon Horman
tch by Vladimir Barinov. > > Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 2/3] sh_eth: add EDMR.NBST support

2018-05-17 Thread Simon Horman
> > Signed-off-by: Vladimir Barinov <vladimir.bari...@cogentembedded.com> > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au> > > --- > drivers/net/ethernet/renesas/sh_eth.c |4

Re: [PATCH] dt-bindings: net: ravb: Add support for r8a77990 SoC

2018-05-13 Thread Simon Horman
tation. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda...@renesas.com> > > I'm assuming this isn't targetted at one of my trees. Just FYI. Hi Dave, I think this is appropriate for net-next but if not I can take it. Reviewed-by: Simon Horman <horms+rene..

Re: [PATCH] dt-bindings: can: rcar_can: Fix R8A7796 SoC name

2018-05-04 Thread Simon Horman
On Thu, May 03, 2018 at 03:02:33PM +0200, Geert Uytterhoeven wrote: > R8A7796 is R-Car M3-W. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77980 bindings

2018-04-30 Thread Simon Horman
' repo plus the R8A77970 bindings > patch posted yesterday. Although I wouldn't object if they're both merged to > the 'linux-can.git' repo instead. :-) > > Documentation/devicetree/bindings/net/can/rcar_canfd.txt |1 + > 1 file changed, 1 insertion(+) Reviewed-by: Simon Horman &

Re: [PATCH] DT: net: can: rcar_canfd: document R8A77970 bindings

2018-04-30 Thread Simon Horman
On Thu, Apr 26, 2018 at 10:41:14PM +0300, Sergei Shtylyov wrote: > Document the R-Car V3M (R8A77970) SoC support in the R-Car CAN-FD bindings. > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [Patch nf] ipvs: initialize tbl->entries in ip_vs_lblc_init_svc()

2018-04-26 Thread Simon Horman
e(), > > as reported by syzbot. > > > > Reported-by: <syzbot+3e9695f147fb529aa...@syzkaller.appspotmail.com> > > Cc: Simon Horman <ho...@verge.net.au> > > Cc: Julian Anastasov <j...@ssi.bg> > > Cc: Pablo Neira Ayuso <pa...@netfilter.org

Re: [Patch nf] ipvs: initialize tbl->entries after allocation

2018-04-26 Thread Simon Horman
re() > > as reported by syzbot. > > > > Reported-by: <syzbot+3dfdea57819073a04...@syzkaller.appspotmail.com> > > Cc: Simon Horman <ho...@verge.net.au> > > Cc: Julian Anastasov <j...@ssi.bg> > > Cc: Pablo Neira Ayuso <pa...@netfilter.org> > > Signed

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940

Re: [PATCH/RFC 7/8] ARM: shmobile: Remove the ARCH_SHMOBILE Kconfig symbol

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 03:28:33PM +0200, Geert Uytterhoeven wrote: > All drivers for Renesas ARM SoCs have gained proper ARCH_RENESAS > platform dependencies. Hence finish the conversion from ARCH_SHMOBILE > to ARCH_RENESAS for Renesas 32-bit ARM SoCs, as started by commit > 9b5ba0df4ea4f940

Re: [PATCH 6/8] ASoC: sh: Update menu title and platform dependency

2018-04-23 Thread Simon Horman
in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 4/8] sh_eth: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
sas SuperH SH-Mobile SoCs are still covered by the CONFIG_CPU_SH4 > check. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 5/8] staging: emxx_udc: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
ce use the > former. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 3/8] [media] v4l: rcar_fdp1: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
y > than the legacy ARCH_SHMOBILE, hence use the former. > > This will allow to drop ARCH_SHMOBILE on ARM and ARM64 in the near > future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-23 Thread Simon Horman
remaining #ifdefs. > > This will allow to drop ARCH_SHMOBILE on ARM in the near future. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH 1/8] arm: shmobile: Change platform dependency to ARCH_RENESAS

2018-04-23 Thread Simon Horman
On Fri, Apr 20, 2018 at 05:53:18PM +0300, Sergei Shtylyov wrote: > On 04/20/2018 04:28 PM, Geert Uytterhoeven wrote: > > > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > > is ARCH_RENESAS a more appropriate platform dependency than the legacy > >"ARCH_RENESAS is",

[PATCH 5/5] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

2018-04-19 Thread Simon Horman
incent Bernat <vinc...@bernat.im> Acked-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_dh.c| 3 ++- net/netfilter/ipvs/ip_vs_lblc.c | 3 ++- net/netfilter/ipvs/ip_vs_lblcr.c | 3 ++- net/netfilter/ipvs/ip_vs_

[PATCH 4/5] netfilter: ipvs: Add configurations of Maglev hashing

2018-04-19 Thread Simon Horman
rcorp.com> Signed-off-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/Kconfig | 37 + net/netfilter/ipvs/Makefile | 1 + 2 files changed, 38 insertions(+) diff --git a/net/netfilter/ipvs/Kcon

[PATCH 3/5] netfilter: ipvs: Add Maglev hashing scheduler

2018-04-19 Thread Simon Horman
ud.pdf Signed-off-by: Inju Song <inju.s...@navercorp.com> Signed-off-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_mh.c | 540 ++ 1 file changed, 540 insertions(+) create m

[PATCH 1/5] netfilter: ipvs: Fix space before '[' error.

2018-04-19 Thread Simon Horman
From: Arvind Yadav <arvind.yadav...@gmail.com> Fix checkpatch.pl error: ERROR: space prohibited before open square bracket '['. Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> Signed-off-by: Simon Horman <ho...@verge.net.au> --- net/netfilter/ipvs/ip_vs_proto_tcp.

[GIT PULL 0/5] IPVS Updates for v4.18

2018-04-19 Thread Simon Horman
Hi Pablo, please consider these IPVS enhancements for v4.18. * Whitepace cleanup * Add Maglev hashing algorithm as a IPVS scheduler Inju Song says "Implements the Google's Maglev hashing algorithm as a IPVS scheduler. Basically it provides consistent hashing but offers some special

[PATCH 2/5] netfilter: ipvs: Keep latest weight of destination

2018-04-19 Thread Simon Horman
u Song <inju.s...@navercorp.com> Signed-off-by: Julian Anastasov <j...@ssi.bg> Signed-off-by: Simon Horman <ho...@verge.net.au> --- include/net/ip_vs.h| 1 + net/netfilter/ipvs/ip_vs_ctl.c | 4 2 files changed, 5 insertions(+) diff --git a/include/net/ip_vs.h b/i

[PATCH/RFC net-next 3/5] ravb: do not write 1 to reserved bits

2018-04-17 Thread Simon Horman
From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> This patch corrects writing 1 to reserved bits. The write value should be 0. Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/ne

[PATCH/RFC net-next 5/5] ravb: remove tx buffer addr 4byte alilgnment restriction for R-Car Gen3

2018-04-17 Thread Simon Horman
From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> This patch sets from two descriptor to one descriptor because R-Car Gen3 does not have the 4 bytes alignment restriction of the transmission buffer. Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-o

[PATCH/RFC net-next 2/5] ravb: correct ptp does failure after suspend and resume

2018-04-17 Thread Simon Horman
lock driver") Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/ravb_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/

[PATCH/RFC net-next 4/5] ravb: remove undocumented processing

2018-04-17 Thread Simon Horman
From: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Signed-off-by: Simon Horman <horms+rene...@verge.net.au> --- drivers/net/ethernet/renesas/ravb.h | 5 - drivers/net/ethernet/renesa

[PATCH/RFC net-next 0/5] ravb: updates

2018-04-17 Thread Simon Horman
Hi Sergei, this series is composed of otherwise unrelated RAVB patches from the R-Car BSP v3.6.2 which at a first pass seem worth considering for upstream. I would value your feedback on these patches so they can either proceed into net-next or remain local to the BSP. Thanks! Kazuya Mizuguchi

[PATCH/RFC net-next 1/5] ravb: fix inconsistent lock state at enabling tx timestamp

2018-04-17 Thread Simon Horman
117925] [] start_kernel+0x38c/0x3a0 [ 59.124261] [] __primary_switched+0x5c/0x64 Fixes: f51bdc236b6c ("ravb: Add dma queue interrupt support") Signed-off-by: Masaru Nagai <masaru.nagai...@renesas.com> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi...@renesas.com> Si

Re: [bpf-next PATCH 1/4] bpf: sockmap, free memory on sock close with cork data

2018-04-12 Thread Simon Horman
On Sun, Apr 01, 2018 at 08:00:54AM -0700, John Fastabend wrote: > If a socket with pending cork data is closed we do not return the > memory to the socket until the garbage collector free's the psock > structure. The garbage collector though can run after the sock has > completed its close

Re: [PATCH net-next v2] ipvs: fix multiplicative hashing in sh/dh/lblc/lblcr algorithms

2018-04-09 Thread Simon Horman
On Sun, Apr 01, 2018 at 02:11:51PM +0300, Julian Anastasov wrote: > > Hello, > > On Sun, 1 Apr 2018, Vincent Bernat wrote: > > > The sh/dh/lblc/lblcr algorithms are using Knuth's multiplicative > > hashing incorrectly. Replace its use by the hash_32() macro, which > > correctly implements

Re: [iproute PATCH] man: ip-route.8: ssthresh parameter is NUMBER

2018-03-28 Thread Simon Horman
On Thu, Mar 22, 2018 at 03:00:38PM +0100, Phil Sutter wrote: > Synopsis section was inconsistent with regards to help text and later > description of ssthresh parameter. > > Signed-off-by: Phil Sutter <p...@nwl.cc> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

[PATCH net-next 1/2] nfp: flower: refactor shared ip header in match offload

2018-03-26 Thread Simon Horman
com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 19 +++ drivers/net/ethernet/netronome/nfp/flower/match.c | 61 +++ 2 files changed, 38 insertions(+), 42 deletions(-) diff --git a/drivers/net/ethernet/net

[PATCH net-next 0/2] nfp: flower: add ip fragmentation offloading support

2018-03-26 Thread Simon Horman
Pieter Jansen van Vuuren says: This set allows offloading IP fragmentation classification. It Implements ip fragmentation match offloading for both IPv4 and IPv6 and offloads frag, nofrag, first and nofirstfrag classification. Pieter Jansen van Vuuren (2): nfp: flower: refactor shared ip

[PATCH net-next 2/2] nfp: flower: implement ip fragmentation match offload

2018-03-26 Thread Simon Horman
gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h| 3 +++ drivers/net/ethernet/netronome/nfp/flower/match.c | 12 drivers/net/ethernet/netron

Re: [PATCH/RFC 3/3] net/sched: add tunnel option support to act_tunnel_key

2018-03-22 Thread Simon Horman
On Fri, Mar 09, 2018 at 12:53:17PM +0100, Jiri Benc wrote: > On Tue, 6 Mar 2018 18:08:05 +0100, Simon Horman wrote: > > +static int > > +tunnel_key_copy_geneve_opt(const struct nlattr *nla, int dst_len, void > > *dst, > > + str

Re: [PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-22 Thread Simon Horman
On Fri, Mar 09, 2018 at 12:22:48PM +0100, Jiri Benc wrote: > On Tue, 6 Mar 2018 18:08:04 +0100, Simon Horman wrote: > > - if (!tb[TCA_TUNNEL_KEY_PARMS]) > > + if (!tb[TCA_TUNNEL_KEY_PARMS]) { > > + NL_SET_ERR_MSG(extack, "Missing tunnel key parameter&

[PATCH iproute2/net-next] tc: f_flower: Add support for matching first frag packets

2018-03-09 Thread Simon Horman
gt; Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- man/man8/tc-flower.8 | 8 ++-- tc/f_flower.c| 1 + 2 files changed, 7 insertions(+), 2 deletions(-) This patch depends on u

Re: [PATCH/RFC net-next 0/3] introduce Geneve options support in TC tunnel key

2018-03-06 Thread Simon Horman
On Tue, Mar 06, 2018 at 07:11:12PM +0200, Or Gerlitz wrote: > On Tue, Mar 6, 2018 at 7:08 PM, Simon Horman <simon.hor...@netronome.com> > wrote: > > Hi all, > > > > This set adds Geneve options support to the TC tunnel key action. > > Options TLVs are exposed

[PATCH net-next] net/sched: cls_flower: Add support to handle first frag as match field

2018-03-06 Thread Simon Horman
Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- include/uapi/linux/pkt_cls.h | 1 + net/sched/cls_flower.c | 6 ++ 2 files changed, 7 insertions(+) diff --git a/include/uapi/linux/pkt_cl

[PATCH/RFC 2/3] net/sched: act_tunnel_key: add extended ack support

2018-03-06 Thread Simon Horman
Add extended ack support for the tunnel key action by using NL_SET_ERR_MSG during validation of user input. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Reviewed-by: Jakub Kicinski

[PATCH/RFC 3/3] net/sched: add tunnel option support to act_tunnel_key

2018-03-06 Thread Simon Horman
dev geneve0 Signed-off-by: Simon Horman <simon.hor...@netronome.com> Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuu...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- include/uapi/linux/tc_act/tc_tunnel_key.h | 26 net/sche

[PATCH/RFC net-next 0/3] introduce Geneve options support in TC tunnel key

2018-03-06 Thread Simon Horman
Hi all, This set adds Geneve options support to the TC tunnel key action. Options TLVs are exposed to userspace using a list of netlink attributes with each option described using attributes for class, type and data. The series also enhances the tunnel key action to use extended ack. Simon

[PATCH/RFC 1/3] net/sched: act_tunnel_key: disambiguate metadata dst error cases

2018-03-06 Thread Simon Horman
information to users when parsing their input. Signed-off-by: Simon Horman <simon.hor...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> --- net/sched/act_tunnel_key.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/sched/act_tunnel_key.c

Re: [PATCH] ipvs: use true and false for boolean values

2018-03-06 Thread Simon Horman
On Mon, Mar 05, 2018 at 03:35:57PM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Signed-off

Re: [PATCH v2 00/10] R-Car M3-N: Enable EtherAVB device node

2018-03-01 Thread Simon Horman
On Tue, Feb 27, 2018 at 11:22:44AM +0100, Jacopo Mondi wrote: > Hi Simon, Geert, >in this second iteration I have dropped iommu dependencies for EtherAVB > and have changed "phy-mode" for all mainlines Gen-3 boards, this time > including > ULCB, Draak, Eagle and V3MSK. > > The series add

Re: [PATCH 0/8] R-Car M3-N: Enable EtherAVB device node

2018-02-27 Thread Simon Horman
On Tue, Feb 27, 2018 at 09:28:38AM +0100, jacopo mondi wrote: > Hi Geert, > > On Mon, Feb 26, 2018 at 07:28:47PM +0100, Geert Uytterhoeven wrote: > > Hi Jacopo, > > > > On Mon, Feb 26, 2018 at 6:57 PM, Jacopo Mondi > > wrote: > > > as discussed with you Sergei and

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-27 Thread Simon Horman
On Mon, Feb 26, 2018 at 03:10:51PM -0500, David Miller wrote: > From: Simon Horman <ho...@verge.net.au> > Date: Mon, 26 Feb 2018 11:58:24 +0100 > > > On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote: > >> From: Sergei Shtylyov <sergei.shtyl...@cogen

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-26 Thread Simon Horman
On Sat, Feb 24, 2018 at 09:53:17PM -0500, David Miller wrote: > From: Sergei Shtylyov > Date: Sat, 24 Feb 2018 21:01:15 +0300 > > > On 02/01/2018 11:13 PM, Sergei Shtylyov wrote: > > > >> Renesas R-Car V3H (R8A77980) SoC has the R-Car gen3 compatible EtherAVB

Re: [oss-drivers] [PATCH net 5/5] nfp: populate MODULE_VERSION

2018-02-08 Thread Simon Horman
output, put it into MODULE_VERSION > as well. > > Reported-by: Jan Gutter <jan.gut...@netronome.com> > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> > Reviewed-by: Dirk van der Merwe <dirk.vanderme...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [oss-drivers] [PATCH net 4/5] nfp: limit the number of TSO segments

2018-02-08 Thread Simon Horman
; > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH 2/3] arm64: dts: renesas: r8a77970: Remove non-existing STBE region

2018-02-07 Thread Simon Horman
On Tue, Feb 06, 2018 at 02:05:53PM +0100, Geert Uytterhoeven wrote: > R-Car V3M does not have the Stream Buffer for EtherAVB-IF (STBE). > > Note that the RAVB driver does not use this region. > > Fixes: bea2ab136eaacec2 ("arm64: dts: renesas: r8a77970: add EtherAVB > support") > Signed-off-by:

Re: [PATCH 3/3] arm64: dts: renesas: r8a77995: Remove non-existing STBE region

2018-02-07 Thread Simon Horman
On Tue, Feb 06, 2018 at 02:05:54PM +0100, Geert Uytterhoeven wrote: > R-Car D3 does not have the Stream Buffer for EtherAVB-IF (STBE). > > Note that the RAVB driver does not use this region. > > Fixes: f9ba0c4cfe6169b7 ("arm64: dts: renesas: r8a77995: Add EthernetAVB > device node") >

Re: [PATCH 1/3] dt-bindings: net: renesas-ravb: Make stream buffer optional

2018-02-06 Thread Simon Horman
5ec87483d1e24a ("ravb: document R8A77970 bindings") > Fixes: f231c4178a655b09 ("dt-bindings: net: renesas-ravb: Add support for > R8A77995 RAVB") > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH] DT: net: renesas,ravb: document R8A77980 bindings

2018-02-02 Thread Simon Horman
he SoC specific bindings. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtyl...@cogentembedded.com> > > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Simon Horman <horms+rene...@verge.net.au>

Re: [PATCH bpf-next] netdevsim: fix overflow on the error path

2018-02-01 Thread Simon Horman
ort fake map offload") > Reported-by: Dan Carpenter <dan.carpen...@oracle.com> > Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Reviewed-by: Simon Horman <simon.hor...@netronome.com>

Re: [PATCH] nfp: add basic multicast filtering

2018-01-04 Thread Simon Horman
On Thu, Jan 04, 2018 at 04:10:19PM +0100, Simon Horman wrote: > From: Jakub Kicinski <jakub.kicin...@netronome.com> > > We currently always pass all multicast traffic through. > Only set L2MC when actually needed. Since the driver > was not making use of the capabilit

[PATCH] nfp: add basic multicast filtering

2018-01-04 Thread Simon Horman
users if capability is not present (like we do for promisc flag). The lack of L2MC capability is assumed to mean all multicast traffic goes through. Signed-off-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethe

[PATCH net-next 1/4] nfp: flower: remove unused tun_mask variable

2017-12-19 Thread Simon Horman
.@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/match.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/flower/match.c b/drivers/net/ethernet/netronome/

[PATCH net-next 2/4] nfp: flower: read extra feature support from fw

2017-12-19 Thread Simon Horman
l does not exist, set the bitmap to 0. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/main.c | 10 +- driver

[PATCH net-next 3/4] nfp: flower: compile Geneve match fields

2017-12-19 Thread Simon Horman
Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/flower/cmsg.h | 32 - drivers/net/ethernet/netronome/

[PATCH net-next 4/4] nfp: flower: compile Geneve encap actions

2017-12-19 Thread Simon Horman
ptions is not supported yet. Only attempt to offload if the fw supports Geneve. Signed-off-by: John Hurley <john.hur...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/

[PATCH net-next 0/4] nfp: flower: add Geneve tunnel support

2017-12-19 Thread Simon Horman
John Hurley says: This patchset adds support for offloading the encap and decap of Geneve tunnels to the NFP. In both cases, specifying well known port 6081 is a requirement for rule offload. Geneve firmware support has been recently added, so the patchset includes the reading of a fw symbol

Re: [PATCH net-next 0/2] nfp: fix rtsym and XDP register handling in debug dump

2017-12-15 Thread Simon Horman
On Thu, Dec 14, 2017 at 10:50:24AM +0100, Simon Horman wrote: > Hi, > > this series resolves two problems in the recently added debug dump facility. > > * Correctly handle reading absolute rtysms > * Correctly handle special-case PB register reads > > These fixes a

[PATCH net-next 2/2] nfp: fix XPB register reads in debug dump

2017-12-14 Thread Simon Horman
PB and direct ME CSRs") Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c | 15

[PATCH net-next 1/2] nfp: fix absolute rtsym handling in debug dump

2017-12-14 Thread Simon Horman
4a 0x is reported. The values may be read using ethtool debug level 2. # ethtool -W 2 # ethtool -w data dump.dat Fixes: e1e798e3fd93 ("nfp: dump rtsyms") Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.

[PATCH net-next 0/2] nfp: fix rtsym and XDP register handling in debug dump

2017-12-14 Thread Simon Horman
Hi, this series resolves two problems in the recently added debug dump facility. * Correctly handle reading absolute rtysms * Correctly handle special-case PB register reads These fixes are for code only present in net-next. Carl Heymann (2): nfp: fix absolute rtsym handling in debug dump

Re: [PATCH v4 0/4] Teach phylib hard-resetting devices

2017-12-10 Thread Simon Horman
On Mon, Dec 04, 2017 at 11:34:48AM +0100, Geert Uytterhoeven wrote: > Hi David, Andrew, Florian, Simon, Magnus, > > This patch series adds optional PHY reset support to phylib. > > The first two patches are destined for David's net-next tree. They add > core PHY reset code, and update a

[PATCH net-next 02/10] nfp: load debug dump spec

2017-12-04 Thread Simon Horman
.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git

[PATCH net-next 10/10] nfp: dump indirect ME CSRs

2017-12-04 Thread Simon Horman
write the context to a specific derived address, read it back, and then read the register value. - For each address, read and dump all 8 contexts in this manner. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Si

[PATCH net-next 03/10] nfp: dump prolog

2017-12-04 Thread Simon Horman
<jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 88 +- 1 file changed, 86 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_debugdump.c

[PATCH net-next 09/10] nfp: dump CPP, XPB and direct ME CSRs

2017-12-04 Thread Simon Horman
ed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 102 + 1 file changed, 102 insertions(+) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_de

[PATCH net-next 08/10] nfp: dump firmware name

2017-12-04 Thread Simon Horman
From: Carl Heymann <carl.heym...@netronome.com> Dump FW name as TLV, based on dump specification. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com&g

[PATCH net-next 07/10] nfp: dump single hwinfo field by key

2017-12-04 Thread Simon Horman
error. Signed-off-by: Carl Heymann <carl.heym...@netronome.com> Reviewed-by: Jakub Kicinski <jakub.kicin...@netronome.com> Signed-off-by: Simon Horman <simon.hor...@netronome.com> --- .../net/ethernet/netronome/nfp/nfp_net_debugdump.c | 57 ++ 1 file changed, 57 i

  1   2   3   4   5   6   7   8   9   10   >