there. The arrays are
kept up-to-date during normal runtime. The crash handler fn is triggered by the
recently introduced PPC crash shutdown reg/unreg functions.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h | 34 +-
drivers/net/ehea/ehea_main.c | 281
RFC #1:
http://lkml.org/lkml/2007/12/12/241
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.24-rc5/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.24-rc5/drivers/net/ehea/ehea.h2007-12-11 04:48:43.0
+0100
registrations.
Please comment.
Shutdown hook patches:
http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048058.html
http://ozlabs.org/pipermail/linuxppc-dev/2007-December/048059.html
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.24-rc5/drivers/net/ehea/ehea.h
Prevent driver from brawly logging packet checksum errors.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 11 +--
drivers/net/ehea/ehea_qmr.h |4 ++--
3 files changed, 8 insertions(+), 9 deletions(-)
diff
Using own tx_packets counter instead of firmware counters.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |9 +++--
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers
-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 28
2 files changed, 29 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index f78e5bf..5935899 100644
--- a/drivers
Fix: Workqueue ehea_driver_wq was not destroyed
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index
Use shorter method to determine whether adapter has configured ports
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea
Fixed wrongly casted pointers
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index 36ca322..9756211
Fix: Workqueue ehea_driver_wq was not destroyed
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |1 +
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index
Use shorter method to determine whether adapter has configured ports
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea
Fixed wrongly casted pointers
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 25 ++---
1 files changed, 10 insertions(+), 15 deletions(-)
diff --git a/drivers/net/ehea/ehea_main.c b/drivers/net/ehea/ehea_main.c
index 36ca322..9756211
Michael Neuling wrote:
From ehea_start_xmit in ehea_main.c we have:
if (unlikely(atomic_read(pr-swqe_avail) = 1)) {
spin_lock_irqsave(pr-netif_queue, flags);
if (unlikely(atomic_read(pr-swqe_avail) = 1)) {
pr-p_stats.queue_stopped++;
and down functions to the port resources setup functions. Additionally the
missing update of the last_rx member of the netdev structure was added.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 37
performs
a rebuild of the mapping table and a re-registration of the global memory
region.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h | 23 +--
drivers/net/ehea/ehea_main.c | 144 +++
drivers/net/ehea/ehea_phyp.h |3
This patch fixes a possible kernel panic due to not checking the vlan group
when processing received VLAN packets and a malfunction in VLAN/hypervisor
registration.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.22-rc4/drivers/net/ehea/ehea.h
patched_kernel
This patch fixes several whitespace issues.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.22-rc3/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.22-rc3/drivers/net/ehea/ehea.h2007-05-30 12:13:36.0
+0200
operation.
We currently consider this as experimental until further review and tests
have been passed.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.22-rc3/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.22-rc3/drivers/net/ehea/ehea.h
Must access the respective queue's dummy netdev instead of the port's netdev.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff --git a/drivers/net/ehea/ehea.h b/drivers/net/ehea/ehea.h
index 602872d..e85a933 100644
--- a/drivers/net/ehea/ehea.h
+++ b/drivers/net/ehea/ehea.h
@@ -39,7 +39,7
this in the mainline driver?
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp -X dontdiff linux-2.6.22pre/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.22pre/drivers/net/ehea/ehea.h 2007-05-07 15:55:43.0
+0200
+++ patched_kernel/drivers/net/ehea/ehea.h
Create symbolic link from each logical port to ehea driver
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
diff -Nurp -X dontdiff linux-2.6.21/drivers/net/ehea/ehea.h
patched_kernel/drivers/net/ehea/ehea.h
--- linux-2.6.21
Certain resources may only be allocated when first logical port is available,
and must be removed when last logical port has been removed.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
This patch applies on top of the netdev upstream branch for 2.6.22
diff -Nurp -X dontdiff linux-2.6.21
This patch fixes the wrong query and logging of the per interface jumbo frames
enabled/disabled status.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c | 30 +++---
2 files changed, 24 insertions
NEQ-Tasklet wasn't killed when module is removed.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |1 +
1 files changed, 1 insertion(+)
diff -Nurp -X dontdiff linux-2.6.20-rc6/drivers/net/ehea/ehea_main.c
patched_kernel/drivers/net/ehea/ehea_main.c
Not only check the pointer against 0 but also the dereferenced value
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea.h |2 +-
drivers/net/ehea/ehea_main.c |6 --
2 files changed, 5 insertions(+), 3 deletions(-)
diff -Nurp -X dontdiff linux-2.6.20-rc5
Fix to use exactly one queue for incoming packets in all
firmware configurations
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c
Logical partitions are not allowed to (try to) set the autonegotiation status.
This patch removes the respective function call from the port setup function.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
Count OFDT nodes to determine the number of available ports
instead of using the possibly outdated value from the hypervisor
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 15 ++-
1 files changed, 14 insertions(+), 1 deletion(-)
diff -Nurp -X
Disabled dump of hcall regs on some permission issues and
fixed appropriate misleading logmessages
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c | 16 +++-
drivers/net/ehea/ehea_phyp.c | 10 --
2 files changed, 15 insertions(+), 11
Fixed possible nullpointer access in event queue processing
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
drivers/net/ehea/ehea_main.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff -Nurp -X dontdiff linux-2.6.20-rc5/drivers/net/ehea/ehea_main.c
patched_kernel
Removed define H_CB_ALIGNMENT which is already defined in
include/asm-powerpc/hvcall.h
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea.h
git.netdev-2.6/drivers/net/ehea/ehea.h
--- git.netdev-2.6.base/drivers/net/ehea/ehea.h 2006-11-03 14
Fix: Must check for nullpointer before dereferencing it - not afterwards.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
---
diff -Nurp git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c
git.netdev-2.6/drivers/net/ehea/ehea_qmr.c
--- git.netdev-2.6.base/drivers/net/ehea/ehea_qmr.c 2006-11-03
This patch fixes 64k page support by using PAGE_MASK and appropriate pagesize
defines in several places.
Signed-off-by: Thomas Klein [EMAIL PROTECTED]
drivers/net/ehea/ehea_ethtool.c |2 +-
drivers/net/ehea/ehea_main.c| 26 +-
drivers/net/ehea/ehea_phyp.c
Hi Francois,
thanks for your review and your comments. See below our answers.
Regards
Thomas
Francois Romieu wrote:
+cb2 = kzalloc(H_CB_ALIGNMENT, GFP_KERNEL);
+if (!cb2) {
+ehea_error(no mem for cb2);
+goto kzalloc_failed;
It's better when the label
Stephen Hemminger wrote:
On Fri, 18 Aug 2006 17:41:26 +0200
Thomas Klein [EMAIL PROTECTED] wrote:
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes
Alexey Dobriyan wrote:
On Fri, Aug 18, 2006 at 01:30:21PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_phyp.c
+++ kernel/drivers/net/ehea/ehea_phyp.c
+ hret = ehea_h_register_rpage(hcp_adapter_handle, pagesize, queue_type,
+
Alexey Dobriyan wrote:
On Fri, Aug 18, 2006 at 01:33:22PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c
+++ kernel/drivers/net/ehea/ehea_ethtool.c
+{
+strncpy(info-driver, DRV_NAME, sizeof(info-driver) - 1);
+strncpy(info-version,
Michael Neuling wrote:
+static inline void ehea_update_sqa(struct ehea_qp *qp, u16 nr_wqes)
+{
+struct h_epa epa = qp-epas.kernel;
+epa_store_acc(epa, QPTEMM_OFFSET(qpx_sqa),
+ EHEA_BMASK_SET(QPX_SQA_VALUE, nr_wqes));
+}
+
+static inline void
Alexey Dobriyan wrote:
On Fri, Aug 18, 2006 at 01:37:44PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4/drivers/net/Kconfig
+++ patched_kernel/drivers/net/Kconfig
@@ -2277,6 +2277,12 @@ config CHELSIO_T1
To compile this driver as a module, choose M here: the module
Alexey Dobriyan wrote:
On Fri, Aug 18, 2006 at 01:29:01PM +0200, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_main.c
+++ kernel/drivers/net/ehea/ehea_main.c
+static inline int ehea_refill_rq3_def(struct ehea_port_res *pr, int
nr_of_wqes)
This one looks too big
Arjan van de Ven wrote:
+ queue-queue_length = nr_of_pages * pagesize;
+ queue-queue_pages = vmalloc(nr_of_pages * sizeof(void *));
wow... is this really so large that it warrants a vmalloc()???
Agreed: Replaced with kmalloc()
Regards
Thomas
-
To unsubscribe from this list:
Hi Alexey,
first of all thanks a lot for the extensive review.
Alexey Dobriyan wrote:
+ u64 hret = H_HARDWARE;
Useless assignment here and everywhere.
Initializing returncodes to errorstate is a cheap way to prevent
accidentally returning (uninitalized) success returncodes which
Anton Blanchard wrote:
Hi,
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_ethtool.c 1969-12-31
+static void netdev_get_pauseparam(struct net_device *dev,
+ struct ethtool_pauseparam *pauseparam)
+{
+ printk(get pauseparam\n);
+}
There
Anton Blanchard wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea.h 1969-12-31
+extern void exit(int);
Should be able to remove that prototype :)
Anton
Indeed :-) It's gone.
Thomas
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a
Michael Neuling wrote:
+static inline u32 map_swqe_size(u8 swqe_enc_size)
+{
+ return 128 swqe_enc_size;
+}^
+ |
+static inline u32|map_rwqe_size(u8 rwqe_enc_size)
+{|
+ return 128 rwqe_enc_size;
+ *
+ * (C) Copyright IBM Corp. 2006
+ *
+ * Authors:
+ * Christoph Raisch [EMAIL PROTECTED]
+ * Jan-Bernd Themann [EMAIL PROTECTED]
+ * Heiko-Joerg Schick [EMAIL PROTECTED]
+ * Thomas Klein [EMAIL PROTECTED]
+ *
+ *
+ * This program is free software; you can redistribute
Sam Ravnborg wrote:
On Wed, Aug 09, 2006 at 10:40:20AM +0200, Jan-Bernd Themann wrote:
Signed-off-by: Jan-Bernd Themann [EMAIL PROTECTED]
drivers/net/ehea/Makefile |7 +++
1 file changed, 7 insertions(+)
--- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31
Arnd Bergmann wrote:
On Wednesday 09 August 2006 10:38, Jan-Bernd Themann wrote:
--- linux-2.6.18-rc4-orig/drivers/net/ehea/ehea_hcall.h 1969-12-31
16:00:00.0 -0800
+++ kernel/drivers/net/ehea/ehea_hcall.h2006-08-08 23:59:38.111462960
-0700
@@ -0,0 +1,52 @@
+
+/**
+ * This
48 matches
Mail list logo
