RE: [PATCH net-next 1/1] bnx2x: Collect the device debug information during Tx timeout.

> Tx-timeout mostly happens due to some issue in the device. In such cases, > debug dump would be helpful for identifying the cause of the issue. > This patch adds support to spill debug data during the Tx timeout. Here > bnx2x_panic_dump() API is used instead of bnx2x_panic(), since we still >

[PATCH iproute2-next] tc: Correct json output for actions

action": { Relocate the open/close of the JSON object to declare the object only for the case that needs it. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- tc/m_action.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tc/m_action.c b/tc/m_action.c index 2f85d35..899

Re: [PATCH net-next 3/4] qed: Adapter flash update support.

On Mon, Mar 26, 2018 at 03:13:47AM -0700, Sudarsana Reddy Kalluru wrote: > This patch adds the required driver support for updating the flash or > non volatile memory of the adapter. At highlevel, flash upgrade comprises > of reading the flash images from the input file, validating the images and

Re: [PATCH net-next 1/4] qed: Populate nvm image attribute shadow.

On Mon, Mar 26, 2018 at 03:13:45AM -0700, Sudarsana Reddy Kalluru wrote: > This patch add support for populating the flash image attributes. s/add/adds/ [...] > -int qed_mcp_bist_nvm_test_get_image_att(struct qed_hwfn *p_hwfn, > - struct qed_ptt *p_ptt, > -

RE: [PATCH RESEND net-next] net: Do synchronize_rcu() in ip6mr_sk_done() only if this is needed

> >>> After unshare test kworker hangs for ages: > >>> > >>> $ while :; do unshare -n true; done & > >>> > >>> $ perf report > >>> -   88,82% 0,00%  kworker/u16:0  [kernel.vmlinux]  [k] > >>> cleanup_net > >>>  cleanup_net > >>>    - ops_exit_list.isra.9 > >>>  

RE: [PATCH V2 net] qed: Free RoCE ILT Memory on rmmod qedr

> - /* Free Task CXT */ > + /* Free Task CXT ( Intentionally RoCE as task-id is shared between > + * RoCE and iWARP > + */ Broken parenthesis In comment...

[PATCH v2 net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mr

[PATCH v2 net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/m

[PATCH v2 net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

] RFC -> v1: - Corrected support for CONFIG_IP{,V6}_MROUTE_MULTIPLE_TABLES - Addressed a couple of kbuild test robot issues Yuval Mintz (11): ipmr,ipmr6: Define a uniform vif_device ip6mr: Make mroute_sk rcu-based ip6mr: Align hash implementation to ipmr mroute*: Make mr_table a com

[PATCH v2 net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

] mr_mfc has to be the first field inside every multicast routing abstraction utilizing it. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c | 21 +- include/linux/mroute.h| 45 +--- include/linux/mro

[PATCH v2 net-next 04/11] mroute*: Make mr_table a common struct

suffix. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute.h | 21 include/linux/mroute6.h | 1 - include/linux/mroute_base.h | 46 +++ include/net/netns/ipv6.h| 2 +- net

[PATCH v2 net-next 03/11] ip6mr: Align hash implementation to ipmr

Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz <yuv...

[PATCH v2 net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

ed by ipmr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute.h | 9 - include/linux/mroute6.h | 3 --- include/linux/mroute_base.h | 9 + net/ipv6/ip6mr.c| 3 -

[PATCH v2 net-next 09/11] ipmr, ip6mr: Unite vif seq functions

Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute

[PATCH v2 net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

for common flows, in this case - the hash parameters and a comparison key representing a (*,*) route. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 52 +-- net/ipv4/ipmr.c | 71 ++

[PATCH v2 net-next 02/11] ip6mr: Make mroute_sk rcu-based

In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c

[PATCH v2 net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

of the vif_device fields in a new common source file. This requires modifying the ipv{4,6] Kconfig and ipv4 makefile as we're introducing a new common config option - CONFIG_IP_MROUTE_COMMON. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnet

[PATCH v2 net-next 11/11] ipmr, ip6mr: Unite dumproute flows

between the two. Notice this requires creating an mr_table iterator for each, as the for-each preprocessor macro can't be used by the common logic. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> Acked-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> --- include/linux/mroute_

Re: [PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

On Wed, Feb 28, 2018 at 12:38:20AM +0200, Nikolay Aleksandrov wrote: > On 27/02/18 20:58, Yuval Mintz wrote: > > mfc_cache and mfc6_cache are almost identical - the main difference is > > in the origin/group addresses and comparison-key. Make a common > > structu

RE: [PATCH net-next] team: Use extack to report enslavement failures

> >> > If so, for how long? They should certainly be removed eventually. How > >> > do we ensure we don't forget? > >> > > >> > Seems to me it would be better to remove them right now. > >> > >> I can do that unless someone objects. > > > >I don't object, but FWIW keep in mind extack errors don't

[PATCH net-next 04/11] mroute*: Make mr_table a common struct

suffix. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 21 include/linux/mroute6.h | 1 - include/linux/mroute_base.h | 46 +++ include/net/netns/ipv6.h| 2 +- net/ipv4/ipmr.c | 2 - net/ipv6/ip6mr.c

[PATCH net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

] mr_mfc has to be the first field inside every multicast routing abstraction utilizing it. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c | 21 +- include/linux/mroute.h| 45 +--- include/linux/mro

[PATCH net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

ed by ipmr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 9 - include/linux/mroute6.h | 3 --- include/linux/mroute_base.h | 9 + net/ipv6/ip6mr.c| 3 --- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git

[PATCH net-next 11/11] ipmr, ip6mr: Unite dumproute flows

between the two. Notice this requires creating an mr_table iterator for each, as the for-each preprocessor macro can't be used by the common logic. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 29 net/ipv4/ipmr.c

[PATCH net-next 03/11] ip6mr: Align hash implementation to ipmr

Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz <yuv...

[PATCH net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 69 net/ipv4/

[PATCH net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

for common flows, in this case - the hash parameters and a comparison key representing a (*,*) route. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 52 +-- net/ipv4/ipmr.c | 71 ++

[PATCH net-next 02/11] ip6mr: Make mroute_sk rcu-based

In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c| 45 +++-- 3 files c

[PATCH net-next 09/11] ipmr, ip6mr: Unite vif seq functions

Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 33 ++ net/ipv4/ipmr.c

[PATCH net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

of the vif_device fields in a new common source file. This requires modifying the ipv{4,6] Kconfig and ipv4 makefile as we're introducing a new common config option - CONFIG_IP_MROUTE_COMMON. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 13 +--- include

[PATCH net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 17 + net/ipv4/ipmr.c

[PATCH net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

bot issues Yuval Mintz (11): ipmr,ipmr6: Define a uniform vif_device ip6mr: Make mroute_sk rcu-based ip6mr: Align hash implementation to ipmr mroute*: Make mr_table a common struct ipmr, ip6mr: Unite creation of new mr_table ipmr, ip6mr: Make mfc_cache a common structure ipmr, ip6mr: Un

[RFC net-next 03/11] ip6mr: Align hash implementation to ipmr

Since commit 8fb472c09b9d ("ipmr: improve hash scalability") ipmr has been using rhashtable as a basis for its mfc routes, but ip6mr is currently still using the old private MFC hash implementation. Align ip6mr to the current ipmr implementation. Signed-off-by: Yuval Mintz <yuv...

[RFC net-next 09/11] ipmr, ip6mr: Unite vif seq functions

Same as previously done with the mfc seq, the logic for the vif seq is refactored to be shared between ipmr and ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 33 ++ net/ipv4/ipmr.c

[RFC net-next 06/11] ipmr, ip6mr: Make mfc_cache a common structure

] mr_mfc has to be the first field inside every multicast routing abstraction utilizing it. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- drivers/net/ethernet/mellanox/mlxsw/spectrum_mr.c | 21 +- include/linux/mroute.h| 45 +--- include/linux/mro

[RFC net-next 00/11] ipmr, ip6mr: Align multicast routing for IPv4 & IPv6

offloading as well, as almost all structures related to the offloading would be shared between the two protocols. Yuval Mintz (11): ipmr,ipmr6: Define a uniform vif_device ip6mr: Make mroute_sk rcu-based ip6mr: Align hash implementation to ipmr mroute*: Make mr_table a common struct ipmr

[RFC net-next 11/11] ipmr, ip6mr: Unite dumproute flows

between the two. Notice this requires creating an mr_table iterator for each, as the for-each preprocessor macro can't be used by the common logic. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 29 + net/ipv4/ipmr.c

[RFC net-next 04/11] mroute*: Make mr_table a common struct

suffix. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 21 --- include/linux/mroute6.h | 1 - include/linux/mroute_base.h | 46 +++ include/net/netns/ipv6.h| 2 +- net/ipv4/ipmr.c | 2 - net/ipv6/ip6mr.c

[RFC net-next 05/11] ipmr, ip6mr: Unite creation of new mr_table

Now that both ipmr and ip6mr are using the same mr_table structure, we can have a common function to allocate & initialize a new instance. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 17 + net/ipv4/ipmr.c

[RFC net-next 10/11] ip6mr: Remove MFC_NOTIFY and refactor flags

ed by ipmr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 9 - include/linux/mroute6.h | 3 --- include/linux/mroute_base.h | 9 + net/ipv6/ip6mr.c| 3 --- 4 files changed, 9 insertions(+), 15 deletions(-) diff --git

[RFC net-next 08/11] ipmr, ip6mr: Unite mfc seq logic

With the exception of the final dump, ipmr and ip6mr have the exact same seq logic for traversing a given mr_table. Refactor that code and make it common. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 69 net/ipv4/

[RFC net-next 01/11] ipmr,ipmr6: Define a uniform vif_device

of the vif_device fields in a new common source file. This requires modifying the ipv{4,6] Kconfig and ipv4 makefile as we're introducing a new common config option - CONFIG_IP_MROUTE_COMMON. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute.h | 13 +--- include

[RFC net-next 02/11] ip6mr: Make mroute_sk rcu-based

In ipmr the mr_table socket is handled under RCU. Introduce the same for ip6mr. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute6.h | 6 +++--- net/ipv6/ip6_output.c | 2 +- net/ipv6/ip6mr.c| 43 ++- 3 files chang

[RFC net-next 07/11] ipmr, ip6mr: Unite logic for searching in MFC cache

for common flows, in this case - the hash parameters and a comparison key representing a (*,*) route. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/linux/mroute_base.h | 52 +-- net/ipv4/ipmr.c | 71 ++

RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

> > > Hm. You you need this just because you didn't add the backlog > > > pointer to destroy? AFAIK on destroy we are free to reset stats as > > > well, thus simplifying your driver... Let me know if I > > > misunderstand. > > > > This is meant exactly for the scenario where qdisc didn't get >

RE: [patch net-next 5/5] mlxsw: spectrum: qdiscs: Support stats for PRIO qdisc

se of a qdisc that stops being offloaded but is not destroyed, backlog > > value needs to be updated about the un-offloading. > > For that reason an unoffload function is being added to the ops struct. > > > > Signed-off-by: Nogah Frankel <nog...@mellanox.com> >

RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

> > > > +struct tc_prio_qopt_offload_params { > > > > + int bands; > > > > + u8 priomap[TC_PRIO_MAX + 1]; > > > > + /* In case that a prio qdisc is offloaded and now is changed to > > > > a > > > > +* non-offloadedable config, it needs to update the backlog > > > >

RE: [patch net-next 3/5] net: sch: prio: Add offload ability to PRIO qdisc

> > +struct tc_prio_qopt_offload_params { > > + int bands; > > + u8 priomap[TC_PRIO_MAX + 1]; > > + /* In case that a prio qdisc is offloaded and now is changed to a > > +* non-offloadedable config, it needs to update the backlog value > > +* to negate the HW backlog value. > > +

RE: [patch net-next v2 00/10] Add support for resource abstraction

> >>> Many of the ASIC's internal resources are limited and are shared > between > >>> several hardware procedures. For example, unified hash-based memory > can > >>> be used for many lookup purposes, like FDB and LPM. In many cases the > user > >>> can provide a partitioning scheme for such a

RE: [patch net-next v2 00/10] Add support for resource abstraction

> Many of the ASIC's internal resources are limited and are shared > between > several hardware procedures. For example, unified hash-based memory > can > be used for many lookup purposes, like FDB and LPM. In many cases the > user > can provide a partitioning scheme for such a

RE: [patch net-next v2 00/10] Add support for resource abstraction

> >> Many of the ASIC's internal resources are limited and are shared between > >> several hardware procedures. For example, unified hash-based memory > can > >> be used for many lookup purposes, like FDB and LPM. In many cases the > user > >> can provide a partitioning scheme for such a resource

RE: [PATCH iproute] qdisc: Print offload indication

> >Use the newly added TCA_HW_OFFLOAD indication from kernel > >to print a consistent 'offloaded' message to user when listing qdiscs. > > > >Signed-off-by: Yuval Mintz <yuv...@mellanox.com> > > Reviewed-by: Jiri Pirko <j...@mellanox.com> Just now saw th

[PATCH iproute] qdisc: Print offload indication

Use the newly added TCA_HW_OFFLOAD indication from kernel to print a consistent 'offloaded' message to user when listing qdiscs. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/uapi/linux/rtnetlink.h | 1 + tc/tc_qdisc.c | 4 2 files changed, 5 inse

[PATCH net 1/3] net: sched: Add TCA_HW_OFFLOAD

-off-by: Yuval Mintz <yuv...@mellanox.com> --- Do Notice this is going to create [easy-to-solve-]conflicts with net-next, Due to 6b3ba9146fe6 ("net: sched: allow qdiscs to handle locking"). That's also why the numbering here are apparently inconsistent [skipping 0x100]. -

[PATCH net 3/3] pkt_sched: Remove TC_RED_OFFLOADED from uapi

qdisc") Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- include/uapi/linux/pkt_sched.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/linux/pkt_sched.h b/include/uapi/linux/pkt_sched.h index af3cc2f..37b5096 100644 --- a/include/uapi/linux/pkt_sched.h +++ b/in

[PATCH net 2/3] net: sched: Move to new offload indication in RED

Let RED utilize the new internal flag, TCQ_F_OFFLOADED, to mark a given qdisc as offloaded instead of using a dedicated indication. Also, change internal logic into looking at said flag when possible. Fixes: 602f3baf2218 ("net_sch: red: Add offload ability to RED qdisc") Signed-off

[PATCH net 0/3] net: sched: Make qdisc offload uapi uniform

DED as its no longer needed. Dave, A bit unorthodox as it's not a fix per-se, but it's the last chance for killing the unneeded uapi and replacing it with something better before getting stuck with it forever. Cheers, Yuval Yuval Mintz (3): net: sched: Add TCA_HW_OFFLOAD net: sched: Move to n

RE: [PATCH net-next 1/4] net: Introduce NETIF_F_GRO_HW

> Introduce NETIF_F_GRO_HW feature flag for NICs that support hardware > GRO. With this flag, we can now independently turn on or off hardware > GRO when GRO is on. Hardware GRO guarantees that packets can be > re-segmented by TSO/GSO to reconstruct the original packet stream. > > Cc: Ariel

RE: [PATCH net-next 4/4] qede: Use NETIF_F_GRO_HW.

> Advertise NETIF_F_GRO_HW and turn on or off hardware GRO based on > NETIF_F_GRO_FW flag. > > Cc: Ariel Elior > Cc: everest-linux...@cavium.com > Signed-off-by: Michael Chan > --- > drivers/net/ethernet/qlogic/qede/qede_filter.c | 9 ++---

[PATCH net 2/2] MAINTAINERS: Remove Yotam from mlxfw

Provide a mailing list for maintenance of the module instead. Signed-off-by: Yuval Mintz <yuv...@mellanox.com> --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index beac4ee..e2dc868 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH net 0/2] MAINTAINERS: Update Yotam Gigi details

mply removing his corporate E-mail, replacing it with his private one. b. For mlxfw we're providing a mailing list as a replacement for his contact details. Dave, Please consider applying this to 'net'. Thanks, Yuval Yotam Gigi (1): MAINTAINERS: Update Yotam's E-mail Yuval Mint

[PATCH net 1/2] MAINTAINERS: Update Yotam's E-mail

From: Yotam Gigi <yotam...@gmail.com> For the time being I will be available in my private mail. Update both the MAINTAINERS file and the individual modules MODULE_AUTHOR directive with the new address. Signed-off-by: Yotam Gigi <yotam...@gmail.com> Signed-off-by: Yuva

RE: [PATCH net-next v3 06/10] bnxt: Add devlink support for config get/set

> +static int bnxt_nvm_read(struct bnxt *bp, int nvm_param, int idx, > + void *buf, int size) > +{ > + struct hwrm_nvm_get_variable_input req = {0}; > + dma_addr_t dest_data_dma_addr; > + void *dest_data_addr = NULL; > + int bytesize; > + int rc; > + > +

RE: [PATCH net-next v3 01/10] devlink: Add permanent config parameter get/set operations

> On Tue, Oct 24, 2017 at 5:22 PM, Yuval Mintz <yuv...@mellanox.com> > wrote: > >> Add support for permanent config parameter get/set commands. Used > >> for persistent device configuration parameters. > >> > > ... > >>

RE: [PATCH net-next v3 03/10] devlink: Adding num VFs per PF permanent config param

> Adding DEVLINK_PERM_CONFIG_NUM_VF_PER_PF permanent config > parameter. Value is permanent, so becomes the new default > value for this device. > > The value sets the number of VFs per PF in SR-IOV mode. Assuming it's meant to directly control the PCIe capability value I think you should

RE: [PATCH net-next v3 02/10] devlink: Adding SR-IOV enablement perm config param

> Adding DEVLINK_PERM_CONFIG_SRIOV_ENABLED permanent config > parameter. Value is permanent, so becomes the new default > value for this device. > > 0 = Disable SR-IOV > 1 = Enable SR-IOV Does this imposes a requirement on the PCIe specifics, E.g., that the device should no longer expose

RE: [PATCH net-next v3 01/10] devlink: Add permanent config parameter get/set operations

> Add support for permanent config parameter get/set commands. Used > for persistent device configuration parameters. > ... > + int (*perm_config_get)(struct devlink *devlink, > +enum devlink_perm_config_param param, u8 > type, > +void

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

> >> >> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: > >> >> > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com > wrote: > >> >> >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: > >> >> >>> Thu, Oct 19, 2017 at 10:32:21PM CEST,

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

> >> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: > >> > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: > >> >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: > >> >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com

RE: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

> On Thu, Oct 19, 2017 at 4:21 PM, Yuval Mintz <yuv...@mellanox.com> > wrote: > >> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config > parameter > >> get/set operations > >> > >> Add support for permanent config parameter get/s

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

> On Fri, Oct 20, 2017 at 10:10 AM, Jiri Pirko wrote: > > Fri, Oct 20, 2017 at 04:03:55PM CEST, steven.l...@broadcom.com wrote: > >>On Thu, Oct 19, 2017 at 5:39 PM, Jiri Pirko wrote: > >>> Thu, Oct 19, 2017 at 10:32:21PM CEST, yuv...@mellanox.com wrote: >

RE: [PATCH net-next v2 5/6] devlink: Adding num MSI-X vectors per VF NVRAM config param

> Adding DEVLINK_PERM_CONFIG_MSIX_VECTORS_PER_VF permanent > config > parameter. Defines number of MSI-X vectors allocated per VF. > Value is permanent (stored in NVRAM), so becomes the new default > value for this device. Sounds like you're having this enforce the same configuration for all

RE: [PATCH net-next v2 1/6] devlink: Add permanent config parameter get/set operations

> Subject: [PATCH net-next v2 1/6] devlink: Add permanent config parameter > get/set operations > > Add support for permanent config parameter get/set commands. Used > for parameters held in NVRAM, persistent device configuration. Given some of the attributes aren't Boolean, what about an API

RE: [PATCH 4/7] devlink: Adding perm config of link settings

> On Thu, Oct 19, 2017 at 2:07 AM, Yuval Mintz <yuv...@mellanox.com> > wrote: > >> +enum devlink_autoneg_protocol { > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, > >> + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, > &g

RE: [PATCH 2/7] devlink: Adding NPAR permanent config parameters

> >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_RESERVATION_VALID: 1 to use > >> BW_RESERVATION setting, 0 to ignore. > >> > > ... > >> DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT > >> setting, 0 to ignore. > > > > While it probably ties to different fields in your NVM layout why would the >

RE: [PATCH 2/7] devlink: Adding NPAR permanent config parameters

> DEVLINK_ATTR_PERM_CFG_NPAR_BW_RESERVATION_VALID: 1 to use > BW_RESERVATION setting, 0 to ignore. > ... > DEVLINK_ATTR_PERM_CFG_NPAR_BW_LIMIT_VALID: 1 to use BW_LIMIT > setting, 0 to ignore. While it probably ties to different fields in your NVM layout why would the user require specific

RE: [PATCH 3/7] devlink: Adding high level dev perm config params

> DEVLINK_ATTR_PERM_CFG_MULTIFUNC_MODE: Configure multi-function > mode; use devlink_multifunc_mode. ... > +enum devlink_multifunc_mode { > + DEVLINK_MULTIFUNC_MODE_ALLOWED, /* Ext switch > activates MF */ > + DEVLINK_MULTIFUNC_MODE_FORCE_SINGFUNC, > +

RE: [PATCH 5/7] devlink: Adding pre-boot permanent config parameters

> DEVLINK_ATTR_PERM_CFG_MBA_LINK_SPEED: Configured link speed > while executing MBA host software (PXI/iSCSI); use enum > devlink_mba_link_speed. #4 introduces: > DEVLINK_ATTR_PERM_CFG_PRE_OS_LINK_SPEED_D0: Configure default > pre-OS link speed in full power (D0) state; use enum >

RE: [PATCH 4/7] devlink: Adding perm config of link settings

> +enum devlink_autoneg_protocol { > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_BAM, > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY_CONSORTIUM, > + DEVLINK_AUTONEG_PROTOCOL_IEEE8023BY, > + DEVLINK_AUTONEG_PROTOCOL_BAM, /* Broadcom > Autoneg Mode */ > +

RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

> Hi, Yuval > > On 2017/10/15 13:14, Yuval Mintz wrote: > >> Hi, Yuval > >> > >> On 2017/10/13 4:21, Yuval Mintz wrote: > >>>> This patchset adds a new hardware offload type in mqprio before > adding > >>>> mqprio hardware o

RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

> > >> This patchset adds a new hardware offload type in mqprio before > adding > > >> mqprio hardware offload support in hns3 driver. Apparently Dave has already acceptedAmirtha's changes to mqprio: https://marc.info/?l=linux-netdev=150803219824053=2 so I guess you need to revise your

RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

> Hi, Yuval > > On 2017/10/13 4:21, Yuval Mintz wrote: > >> This patchset adds a new hardware offload type in mqprio before adding > >> mqprio hardware offload support in hns3 driver. > > > > I think one of the biggest issues in tying this to DCB

RE: [PATCH net-next 0/2] Add mqprio hardware offload support in hns3 driver

> This patchset adds a new hardware offload type in mqprio before adding > mqprio hardware offload support in hns3 driver. I think one of the biggest issues in tying this to DCB configuration is the non-immediate [and possibly non persistent] configuration. Scenario #1: User is configuring

RE: [PATCH net-next 1/2] mqprio: Add a new hardware offload type in mqprio

> When a driver supports both dcb and hardware offloaded mqprio, and > user is running mqprio and dcb tool concurrently, the configuration > set by each tool may be conflicted with each other because the dcb (for second 'each') s/each/the > and mqprio may be using the same hardwere offload

RE: [net-next 11/15] i40evf: Enable VF to request an alternate queue allocation

> + case VIRTCHNL_OP_REQUEST_QUEUES: { > + struct virtchnl_vf_res_request *vfres = > + (struct virtchnl_vf_res_request *)msg; > + if (vfres->num_queue_pairs == adapter->num_req_queues) > { > + adapter->flags |= >

RE: [patch net-next 1/7] skbuff: Add the offload_mr_fwd_mark field

> hello Jiri and Yotam, > > On Thu, 2017-09-28 at 19:34 +0200, Jiri Pirko wrote: > > From: Yotam Gigi > > > > diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h > > index 19e64bf..ada8214 100644 > > --- a/include/linux/skbuff.h > > +++ b/include/linux/skbuff.h > >

RE: [PATCH v2 net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

> Hi, Yuval > > On 2017/9/26 14:43, Yuval Mintz wrote: > >> When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc > >> is used to tell hclge_dcb module to do the setup. > > > > While this might be a step in the right direction, this causes an

RE: [PATCH v2 net-next 10/10] net: hns3: Add mqprio support when interacting with network stack

> When using tc qdisc to configure DCB parameter, dcb_ops->setup_tc > is used to tell hclge_dcb module to do the setup. While this might be a step in the right direction, this causes an inconsistency in user experience - Some [well, most] vendors didn't allow the mqprio priority mapping to affect

[PATCH] net: Remove ndo_dfwd_start_xmit

Looks like commit f663dd9aaf9e ("net: core: explicitly select a txq before doing l2 forwarding") has removed the need for this dedicated xmit function [it even explicitly states so in its commit log message] but it hasn't removed the definition of the ndo. Signed-off-by: Yuval Mintz

[PATCH net] bnx2x: Don't log mc removal needlessly

, if a positive value would be returned driver would errneously log it as an error. Fixes: c7b7b483ccc9 ("bnx2x: Don't flush multicast MACs") Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- Dave, Please consider applying this to 'net'. Thanks, Yuval --- drivers/net/etherne

[PATCH net-next] qede: Fix compilation without QED_RDMA

e8e167 ("qed*: Set rdma generic functions prefix") Signed-off-by: Chad Dupuis <chad.dup...@cavium.com> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- include/linux/qed/qede_rdma.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/qed

[PATCH v4 net-next 7/7] qed: SPQ async callback registration

m> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/net/ethernet/qlogic/qed/qed_iscsi.c | 24 - drivers/net/ethernet/qlogic/qed/qed_roce.c | 16 ++--- drivers/net/ethernet/qlogic/qed/qed_roce.h | 6 drivers/net/ethernet/qlogic/qed/qed_sp.h| 17

[PATCH v4 net-next 6/7] qed: Wait for resources before FUNC_CLOSE

From: Michal Kalderon <michal.kalde...@cavium.com> Driver needs to wait for all resources to return from FW before it can send the FUNC_CLOSE ramrod. Signed-off-by: Michal Kalderon <michal.kalde...@cavium.com> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/n

[PATCH v4 net-next 3/7] qed: Disable RoCE dpm when DCBx change occurs

If DCBx update occurs while QPs are open, stop sending edpms until all QPs are closed. Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 8 +++ drivers/net/ethernet/qlogic/qed/qed_roce.c | 36 ++ drive

[PATCH v4 net-next 2/7] qed: RoCE EDPM to honor PFC

Configure device according to DCBx results so that EDPMs made by RoCE would honor flow-control. Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/net/ethernet/qlogic/qed/qed_dcbx.c | 16 drivers/net/ethernet/qlogic/qed/qed_reg_addr.h | 6 ++ 2

[PATCH v4 net-next 4/7] qed*: qede_roce.[ch] -> qede_rdma.[ch]

s and adding includes to make sure it contains all type definitions it requires. Signed-off-by: Michal Kalderon <michal.kalde...@cavium.com> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/i

[PATCH v4 net-next 5/7] qed*: Set rdma generic functions prefix

From: Michal Kalderon <michal.kalde...@cavium.com> Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon <michal.kalde...@cavium.com> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/

[PATCH v4 net-next 1/7] qed: Chain support for external PBL

iWARP would require the chains to allocate/free their PBL memory independently, so add the infrastructure to provide it externally. Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/infiniband/hw/qedr/main.c | 2 +- drivers/infiniband/hw/qedr/verbs.c

[PATCH v4 net-next 0/7] qed*: RDMA and infrastructure for iWARP

ons prefix qed: Wait for resources before FUNC_CLOSE qed: SPQ async callback registration Yuval Mintz (4): qed: Chain support for external PBL qed: RoCE EDPM to honor PFC qed: Disable RoCE dpm when DCBx change occurs drivers/infiniband/hw/qedr/main.c | 10 +- driv

[PATCH v3 net-next 5/7] qed*: Set rdma generic functions prefix

From: Michal Kalderon <michal.kalde...@cavium.com> Rename the functions common to both iWARP and RoCE to have a prefix of _rdma_ instead of _roce_. Signed-off-by: Michal Kalderon <michal.kalde...@cavium.com> Signed-off-by: Yuval Mintz <yuval.mi...@cavium.com> --- drivers/

  1   2   3   4   5   6   7   8   9   >