Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-27 Thread Hagen Paul Pfeifer
* David Miller | 2006-10-26 17:02:21 [-0700]: Your email client turned the tabs into spaces in the patch making it useless. Sorry my mistake! I am en route and I paste the patch into my editor, who eat all tabs. One more time: sorry! Check if user has CAP_NET_ADMIN capability to change

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-27 Thread Stephen Hemminger
On Fri, 27 Oct 2006 12:43:11 +0200 Hagen Paul Pfeifer [EMAIL PROTECTED] wrote: * David Miller | 2006-10-26 17:02:21 [-0700]: Your email client turned the tabs into spaces in the patch making it useless. Sorry my mistake! I am en route and I paste the patch into my editor, who eat all

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-27 Thread Hagen Paul Pfeifer
* Stephen Hemminger | 2006-10-27 07:41:02 [-0700]: Please no, it makes the socket option useless. Technical no, in the sense of usability for everybody yes. You are right Stephen, as a programmer I understand you complete! But on the other side: We know for sure that this IS a problem if we

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-27 Thread Stephen Hemminger
Hagen Paul Pfeifer wrote: * Stephen Hemminger | 2006-10-27 07:41:02 [-0700]: Please no, it makes the socket option useless. Technical no, in the sense of usability for everybody yes. You are right Stephen, as a programmer I understand you complete! But on the other side: We know for

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-27 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 27 Oct 2006 07:41:02 -0700 Please no, it makes the socket option useless. If you want to tag some bad apples thats okay, but would need some more infrastructure. The behavior of the TCP stack is a system wide decision. If anything it

[PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread Hagen Paul Pfeifer
Check if user has CAP_NET_ADMIN capability to change congestion control algorithm. Under normal circumstances a application programmer doesn't have enough information to choose the right algorithm (expect he is the pchar/pathchar maintainer). At 99.9% only the local host administrator has the

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread Ian McDonald
On 10/27/06, Hagen Paul Pfeifer [EMAIL PROTECTED] wrote: Check if user has CAP_NET_ADMIN capability to change congestion control algorithm. Under normal circumstances a application programmer doesn't have enough information to choose the right algorithm (expect he is the pchar/pathchar

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread David Miller
This is driving me crazy... Your email client turned the tabs into spaces in the patch making it useless. I want to ask why it is so hard for people to submit patches that are not corrupted? :-/ I type in this kind of email response at least 2 or 3 times every single day that I review

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread David Miller
From: Ian McDonald [EMAIL PROTECTED] Date: Fri, 27 Oct 2006 12:59:30 +1300 I don't agree with this at all. I would love Firefox, BitTorrent etc to implement usage of TCP-LP for example so they use unused bandwidth only. With this change applications can't do this. If we are going to

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread Ian McDonald
On 10/27/06, David Miller [EMAIL PROTECTED] wrote: From: Ian McDonald [EMAIL PROTECTED] Date: Fri, 27 Oct 2006 12:59:30 +1300 I don't agree with this at all. I would love Firefox, BitTorrent etc to implement usage of TCP-LP for example so they use unused bandwidth only. With this change

Re: [PATCH] Check if user has CAP_NET_ADMIN to change congestion control algorithm

2006-10-26 Thread Stephen Hemminger
On Fri, 27 Oct 2006 01:52:56 +0200 Hagen Paul Pfeifer [EMAIL PROTECTED] wrote: Check if user has CAP_NET_ADMIN capability to change congestion control algorithm. Under normal circumstances a application programmer doesn't have enough information to choose the right algorithm (expect he is