Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Oliver Neukum
On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > > usbnet drives no devices of its own. It makes more sense to > > select it whenever a driver for actual hardware that needs > > it is chosen rather than offer it as an option of its own. > > > >

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Bjørn Mork
Oliver Neukum writes: > On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > >> This looks incomplete. > > Yes, it is against the earlier patch set which introduces the CDC > parser in cdc-acm and cdc-wdm. In hindsight I should have reversed > the order of patches. Ah, right,

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Oliver Neukum
On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote: > Oliver Neukum writes: > > On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote: > > > >> This looks incomplete. > > > > Yes, it is against the earlier patch set which introduces the CDC > > parser in cdc-acm and cdc-wdm. In

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-20 Thread Bjørn Mork
Oliver Neukum writes: > On Tue, 2015-10-20 at 10:43 +0200, Bjørn Mork wrote: > >> So we might need to move cdc_parse_cdc_header() out of usbnet.c after >> all. Keeping it there creates an unnecessary "select" mess. But I don't >> know where to put it... Either a common CDC

[PATCH] usbnet: removed USB_USBNET as a config option

2015-10-19 Thread Oliver Neukum
usbnet drives no devices of its own. It makes more sense to select it whenever a driver for actual hardware that needs it is chosen rather than offer it as an option of its own. Signed-off-by: Oliver Neukum --- drivers/net/usb/Kconfig | 75

Re: [PATCH] usbnet: removed USB_USBNET as a config option

2015-10-19 Thread Bjørn Mork
Oliver Neukum writes: > usbnet drives no devices of its own. It makes more sense to > select it whenever a driver for actual hardware that needs > it is chosen rather than offer it as an option of its own. > > Signed-off-by: Oliver Neukum > --- >