Re: [PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-10 Thread Jeff Garzik
Jan-Bernd Themann wrote: This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have

[PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-05 Thread Jan-Bernd Themann
This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have seen a lower CPU load and

Re: [PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-05 Thread Evgeniy Polyakov
Hi Jan-Bernd. [ Dropped spambot/i.e. unrelated mail lists ] On Thu, Jul 05, 2007 at 09:26:30AM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received

Re: [PATCH 2/2] eHEA: Receive SKB Aggregation, generic LRO helper functions

2007-07-05 Thread Evgeniy Polyakov
On Thu, Jul 05, 2007 at 04:24:46PM +0200, Jan-Bernd Themann ([EMAIL PROTECTED]) wrote: I've couple of comments on the driver, but mainly the fact of decreased CPU usage itself - what was the magnitude of the win with this driver, it looks like because of per-packet receive code path

[PATCH 2/2] eHEA: Receive SKB Aggregation

2007-07-04 Thread Jan-Bernd Themann
This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after an interrupt arrived and forwards these as chains of SKBs for the same TCP connection with modified header field. We have seen a lower CPU load and

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-06-04 Thread Christoph Raisch
Stephen Hemminger wrote on 31.05.2007 18:37:03: +static int try_get_ip_tcp_hdr(struct ehea_cqe *cqe, struct sk_buff *skb, + struct iphdr **iph, struct tcphdr **tcph) +{ + int ip_len; + + /* non tcp/udp packets */ + if (!cqe-header_length) + return

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-06-04 Thread Christoph Raisch
Christoph Hellwig wrote on 31.05.2007 15:41:18: I'm still very unhappy with having all this in various drivers. There's a lot of code that can be turned into generic library functions, and even more code that could be made generic with some amount of refactoring. Yes, we'd also prefer to

[PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Thomas Klein
After there were no technical concerns about this patch I'm resending it with all whitespace issues fixed which were mentioned by Stephen Rothwell. This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Christoph Hellwig
I'm still very unhappy with having all this in various drivers. There's a lot of code that can be turned into generic library functions, and even more code that could be made generic with some amount of refactoring. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Stephen Hemminger
+static int try_get_ip_tcp_hdr(struct ehea_cqe *cqe, struct sk_buff *skb, + struct iphdr **iph, struct tcphdr **tcph) +{ + int ip_len; + + /* non tcp/udp packets */ + if (!cqe-header_length) + return -1; + + /* non tcp packet */