Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-09 Thread David Miller
From: Toshiaki Makita Date: Thu, 4 Aug 2016 11:11:19 +0900 > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > *

Re: [Bridge] [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-07 Thread Toshiaki Makita
On 16/08/06 (土) 7:26, Stephen Hemminger wrote: On Thu, 04 Aug 2016 11:27:25 -0700 Roopa Prabhu wrote: On 8/4/16, 1:15 AM, Toshiaki Makita wrote: On 2016/08/04 16:24, Roopa Prabhu wrote: On 8/3/16, 7:11 PM, Toshiaki Makita wrote: Adding fdb entries pointing to the

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-06 Thread Stephen Hemminger
On Thu, 04 Aug 2016 11:27:25 -0700 Roopa Prabhu wrote: > On 8/4/16, 1:15 AM, Toshiaki Makita wrote: > > On 2016/08/04 16:24, Roopa Prabhu wrote: > >> On 8/3/16, 7:11 PM, Toshiaki Makita wrote: > >>> Adding fdb entries pointing to the bridge device uses

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-04 Thread Roopa Prabhu
On 8/4/16, 1:15 AM, Toshiaki Makita wrote: > On 2016/08/04 16:24, Roopa Prabhu wrote: >> On 8/3/16, 7:11 PM, Toshiaki Makita wrote: >>> Adding fdb entries pointing to the bridge device uses fdb_insert(), >>> which lacks various checks and does not respect added_by_user flag. >>> >>> As a result,

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-04 Thread Toshiaki Makita
On 2016/08/04 17:15, Toshiaki Makita wrote: > On 2016/08/04 16:24, Roopa Prabhu wrote: >> On 8/3/16, 7:11 PM, Toshiaki Makita wrote: >>> Adding fdb entries pointing to the bridge device uses fdb_insert(), >>> which lacks various checks and does not respect added_by_user flag. >>> >>> As a result,

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-04 Thread Toshiaki Makita
On 2016/08/04 16:24, Roopa Prabhu wrote: > On 8/3/16, 7:11 PM, Toshiaki Makita wrote: >> Adding fdb entries pointing to the bridge device uses fdb_insert(), >> which lacks various checks and does not respect added_by_user flag. >> >> As a result, some inconsistent behavior can happen: >> * Adding

Re: [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-04 Thread Roopa Prabhu
On 8/3/16, 7:11 PM, Toshiaki Makita wrote: > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > * Adding temporary entries succeeds but results in

[PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

2016-08-03 Thread Toshiaki Makita
Adding fdb entries pointing to the bridge device uses fdb_insert(), which lacks various checks and does not respect added_by_user flag. As a result, some inconsistent behavior can happen: * Adding temporary entries succeeds but results in permanent entries. * Same goes for "dynamic" and "use". *