Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-10-02 Thread Roland Dreier
On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu wrote: > + err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid, > + cb->nlh->nlmsg_seq, RTM_NEWRULE, > + NLM_F_MULTI, ops); > +

Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-10-02 Thread roopa
On 10/2/15, 10:18 AM, Roland Dreier wrote: > On Tue, Sep 22, 2015 at 9:40 PM, Roopa Prabhu > wrote: >> + err = fib_nl_fill_rule(skb, rule, NETLINK_CB(cb->skb).portid, >> + cb->nlh->nlmsg_seq, RTM_NEWRULE, >> +

Re: [PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-09-24 Thread David Miller
From: Roopa Prabhu Date: Tue, 22 Sep 2015 21:40:22 -0700 > From: Wilson Kok > > dump_rules returns skb length and not error. > But when family == AF_UNSPEC, the caller of dump_rules > assumes that it returns an error. Hence, when family ==

[PATCH net] fib_rules: fix fib rule dumps across multiple skbs

2015-09-22 Thread Roopa Prabhu
From: Wilson Kok dump_rules returns skb length and not error. But when family == AF_UNSPEC, the caller of dump_rules assumes that it returns an error. Hence, when family == AF_UNSPEC, we continue trying to dump on -EMSGSIZE errors resulting in incorrect dump idx carried