[PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread Roland Dreier
netif_rx_complete() takes a netdev parameter and does dev_put() on that netdev, so netif_rx_reschedule() needs to also take a netdev parameter and do dev_hold() on it to avoid reference counts from getting becoming negative because of unbalanced dev_put()s. This should fix the problem reported by

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 10:58:37 -0700 netif_rx_complete() takes a netdev parameter and does dev_put() on that netdev, so netif_rx_reschedule() needs to also take a netdev parameter and do dev_hold() on it to avoid reference counts from getting becoming

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread Roland Dreier
Further complicating things is that you need to setup a ppc32 cross-build environment to even build test a conversion, and I'm not comfortable doing the surgery until I can test build the thing. OK, I actually have a system with a ppc 440 SoC that uses this driver, so I'll try to get things

Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule()

2007-09-18 Thread David Miller
From: Roland Dreier [EMAIL PROTECTED] Date: Tue, 18 Sep 2007 15:46:36 -0700 OK, I actually have a system with a ppc 440 SoC that uses this driver, so I'll try to get things to the stage where I can boot net-2.6.24 on it and see if I can get the driver working... Thanks a lot Roland. - To