Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2016-01-06 Thread Edward Cree
On 18/12/15 19:41, Tom Herbert wrote: > Drivers indicate that can do NETIF_F_IP[V6]_CSUM for encapsulation by > setting enc_features. This is checked in validate_xmit_skb so that if > drive can't handle encapsulated checksum skb_checksum_help is called > there. In that case, why is udp_set_csum

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-25 Thread David Miller
From: Tom Herbert Date: Thu, 17 Dec 2015 10:06:13 -0800 > On Thu, Dec 17, 2015 at 7:27 AM, Edward Cree wrote: >> When the inner packet checksum is offloaded, the outer UDP checksum is easy >> to calculate as it doesn't depend on the payload (because

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-18 Thread Edward Cree
On 17/12/15 18:06, Tom Herbert wrote: > I'm not sure that we need bits in VXLAN or any other encapsulation. It > should be sufficient in udp_set_csum that if we already have > CHECKSUM_PARTIAL that can always be used to do local checksum offload. My understandingis that otherwise

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-18 Thread Tom Herbert
On Fri, Dec 18, 2015 at 2:41 AM, Edward Cree wrote: > On 17/12/15 18:06, Tom Herbert wrote: >> I'm not sure that we need bits in VXLAN or any other encapsulation. It >> should be sufficient in udp_set_csum that if we already have >> CHECKSUM_PARTIAL that can always be used

[PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-17 Thread Edward Cree
When the inner packet checksum is offloaded, the outer UDP checksum is easy to calculate as it doesn't depend on the payload (because the inner checksum cancels out everything from the inner packet except the pseudo header). Thus, transmit checksums for VXLAN (and in principle other

Re: [PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-17 Thread Tom Herbert
On Thu, Dec 17, 2015 at 7:27 AM, Edward Cree wrote: > When the inner packet checksum is offloaded, the outer UDP checksum is easy > to calculate as it doesn't depend on the payload (because the inner checksum > cancels out everything from the inner packet except the pseudo

[RFC PATCH net-next 0/2] Local checksum offload for VXLAN

2015-12-14 Thread Edward Cree
When the inner packet checksum is offloaded, the outer UDP checksum is easy to calculate as it doesn't depend on the payload (because the inner checksum cancels out everything from the inner packet except the pseudo header). Thus, transmit checksums for VXLAN (and in principle other