Re: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hi Marcin, On Wed, Aug 23, 2017 at 11:05:33PM +0200, Marcin Wojtas wrote: > 2017-08-23 18:04 GMT+02:00 Antoine Tenart : > > On Wed, Aug 23, 2017 at 03:24:55PM +, Stefan Chulski wrote: > >> > When the cable is connected (there is signal) and the serdes is in

Re: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hi Antoine, 2017-08-23 18:04 GMT+02:00 Antoine Tenart : > On Wed, Aug 23, 2017 at 03:24:55PM +, Stefan Chulski wrote: >> > When the cable is connected (there is signal) and the serdes is in sync >> > and AN >> > succeeded. >> > >> > > With SFF/SFP ports,

Re: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

On Wed, Aug 23, 2017 at 03:24:55PM +, Stefan Chulski wrote: > > When the cable is connected (there is signal) and the serdes is in sync and > > AN > > succeeded. > > > > > With SFF/SFP ports, you generally need a gpio line the fibre module > > > can use to indicate if it has link. Fixed-phy

RE: [EXT] Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

> When the cable is connected (there is signal) and the serdes is in sync and AN > succeeded. > > > With SFF/SFP ports, you generally need a gpio line the fibre module > > can use to indicate if it has link. Fixed-phy has such support, and > > your link_change function will get called when the

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hi Andrew, Russell, On Wed, Jul 26, 2017 at 06:26:48PM +0200, Andrew Lunn wrote: > On Mon, Jul 24, 2017 at 03:48:40PM +0200, Antoine Tenart wrote: > > This patch adds the GoP link interrupt support for when a port isn't > > connected to a PHY. Because of this the phylib callback is never called >

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

On Wed, Jul 26, 2017 at 06:26:48PM +0200, Andrew Lunn wrote: > And this is another bit of code you probably need to change in a while > with phylink lands. The way the MAC driver handles link up/down and configuration events changes significantly when a MAC driver switches to phylink, since a

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

On Mon, Jul 24, 2017 at 03:48:40PM +0200, Antoine Tenart wrote: > This patch adds the GoP link interrupt support for when a port isn't > connected to a PHY. Because of this the phylib callback is never called > and the link status management isn't done. This patch use the GoP link > interrupt in

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hi Thomas, On Tue, Jul 25, 2017 at 03:17:48PM +0200, Thomas Petazzoni wrote: > On Mon, 24 Jul 2017 15:48:40 +0200, Antoine Tenart wrote: > > + > > + port->link_irq = of_irq_get_byname(port_node, "link"); > > + if (port->link_irq == -EPROBE_DEFER) { > > + err

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hello, On Mon, 24 Jul 2017 15:48:40 +0200, Antoine Tenart wrote: > + > + port->link_irq = of_irq_get_byname(port_node, "link"); > + if (port->link_irq == -EPROBE_DEFER) { > + err = -EPROBE_DEFER; > + goto err_free_irq; > +

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

Hi Marcin, On Tue, Jul 25, 2017 at 12:58:20AM +0200, Marcin Wojtas wrote: > > This patch requires also: > > diff --git a/drivers/net/ethernet/marvell/mvpp2.c > b/drivers/net/ethernet/marvell/mvpp2.c > index 4694d4f..369819f 100644 > --- a/drivers/net/ethernet/marvell/mvpp2.c > +++

[PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

This patch adds the GoP link interrupt support for when a port isn't connected to a PHY. Because of this the phylib callback is never called and the link status management isn't done. This patch use the GoP link interrupt in such cases to still have a minimal link management. Without this patch