Re: [PATCH net-next v3 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-21 Thread Saeed Mahameed
On Sat, Nov 19, 2016 at 2:45 AM, Daniel Borkmann wrote: > There are multiple issues in mlx5e_xdp_set(): > > 1) The batched bpf_prog_add() is currently not checked for errors. When >doing so, it should be done at an earlier point in time to makes sure >that we cannot

[PATCH net-next v3 2/4] bpf, mlx5: fix various refcount issues in mlx5e_xdp_set

2016-11-18 Thread Daniel Borkmann
There are multiple issues in mlx5e_xdp_set(): 1) The batched bpf_prog_add() is currently not checked for errors. When doing so, it should be done at an earlier point in time to makes sure that we cannot fail anymore at the time we want to set the program for each channel. The batched