Re: [Patch net v2] net: check dev->addr_len for dev_set_mac_address()

2017-07-29 Thread David Miller
From: Cong Wang Date: Wed, 26 Jul 2017 15:22:06 -0700 > Historically, dev_ifsioc() uses struct sockaddr as mac > address definition, this is why dev_set_mac_address() > accepts a struct sockaddr pointer as input but now we > have various types of mac addresse whose

[Patch net v2] net: check dev->addr_len for dev_set_mac_address()

2017-07-26 Thread Cong Wang
Historically, dev_ifsioc() uses struct sockaddr as mac address definition, this is why dev_set_mac_address() accepts a struct sockaddr pointer as input but now we have various types of mac addresse whose lengths are up to MAX_ADDR_LEN, longer than struct sockaddr, and saved in dev->addr_len. It