Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-08-05 Thread subashab
I need to do some additional testing next week (taking PTO the next 2 days), but this should fix your problem. Can you confirm? This is better than a sysctl to handle the known use cases, but it does not handle a combination of the 2 known use cases (e.g., throw your use case into a VRF). diff

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-08-03 Thread David Ahern
On 8/3/16 5:02 PM, subas...@codeaurora.org wrote: >> I can't explain the iptables output but from a FIB lookup perspective >> it is using table 8 per the FIB rules, the xfrm is hit and packets >> shift to 192.168.77.1 and go out what you have as eth0. >> >> Take a look at: >> perf record -e

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-08-03 Thread subashab
I can't explain the iptables output but from a FIB lookup perspective it is using table 8 per the FIB rules, the xfrm is hit and packets shift to 192.168.77.1 and go out what you have as eth0. Take a look at: perf record -e fib:* -a -g perf script And then run tcpdump on both eth0 and eth1.

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-08-02 Thread David Ahern
On 7/29/16 12:21 PM, subas...@codeaurora.org wrote: Please don't try to workaround a bug with a sysctl. If we have a bug here, we should fix it. Choosing between bug A and bug B with a sysctl is not what we are doing ;) Sure, this was just a quick hack. Can you give an example of your use

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-07-29 Thread subashab
Please don't try to workaround a bug with a sysctl. If we have a bug here, we should fix it. Choosing between bug A and bug B with a sysctl is not what we are doing ;) Sure, this was just a quick hack. Can you give an example of your use case -- e.g., commands for others (me) to reproduce?

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-07-27 Thread Steffen Klassert
On Mon, Jul 25, 2016 at 06:34:32PM -0600, Subash Abhinov Kasiviswanathan wrote: > We are seeing incorrect routing when tunneling packets over an > interface and sending it over another interface. This scenario > worked on 3.18 (and earlier) and failed on 4.4 kernel. The rules > / routes / policies

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-07-25 Thread David Ahern
On 7/25/16 6:34 PM, Subash Abhinov Kasiviswanathan wrote: We are seeing incorrect routing when tunneling packets over an interface and sending it over another interface. This scenario worked on 3.18 (and earlier) and failed on 4.4 kernel. The rules / routes / policies were the same across

[RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

2016-07-25 Thread Subash Abhinov Kasiviswanathan
We are seeing incorrect routing when tunneling packets over an interface and sending it over another interface. This scenario worked on 3.18 (and earlier) and failed on 4.4 kernel. The rules / routes / policies were the same across kernels. Commit 42a7b32b73d6 ("xfrm: Add oif to dst lookups")