[net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-27 Thread Sathya Perla
The ndo_set_rx_mode() and ndo_add/del_vxlan_port() calls may be called with BHs disabled. The driver currently issues the required cmds to the FW in these contexts and polls on completions from the FW, while BHs remain disabled. This can cause either packet loss or packet reception to be delayed

Re: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-27 Thread David Miller
From: Sathya Perla Date: Wed, 27 Jul 2016 13:33:19 +0530 >> -Original Message- >> From: Sathya Perla [mailto:sathya.pe...@broadcom.com] >> > > >> > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter >> > *adapter) >> > > >u32 cap_flags

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-27 Thread Sathya Perla
> -Original Message- > From: Sathya Perla [mailto:sathya.pe...@broadcom.com] > > > > > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter > > *adapter) > > > > u32 cap_flags = be_if_cap_flags(adapter); > > > > int status; > > > > > > > > + /* alloc

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-26 Thread Sathya Perla
> -Original Message- > From: Sathya Perla [mailto:sathya.pe...@broadcom.com] > > > -Original Message- > > From: David Miller [mailto:da...@davemloft.net] > > > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter > *adapter) > > > u32 cap_flags =

RE: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-26 Thread Sathya Perla
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > > > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter *adapter) > > u32 cap_flags = be_if_cap_flags(adapter); > > int status; > > > > + /* alloc required memory for other filtering fields */ >

Re: [net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-25 Thread David Miller
From: Sathya Perla Date: Fri, 22 Jul 2016 06:55:46 -0400 > @@ -4477,6 +4551,22 @@ static int be_if_create(struct be_adapter *adapter) > u32 cap_flags = be_if_cap_flags(adapter); > int status; > > + /* alloc required memory for other filtering fields

[net-next PATCH 4/4] be2net: replace polling with sleeping in the FW completion path

2016-07-22 Thread Sathya Perla
The ndo_set_rx_mode() and ndo_add/del_vxlan_port() calls may be called with BHs disabled. The driver currently issues the required cmds to the FW in these contexts and polls on completions from the FW, while BHs remain disabled. This can cause either packet loss or packet reception to be delayed