Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-07-08 Thread Roopa Prabhu
On Mon, Jun 27, 2016 at 6:11 AM, Jiri Pirko wrote: > Mon, Jun 27, 2016 at 03:02:31PM CEST, ro...@cumulusnetworks.com wrote: [snip] >> >>The point of the stats api is to bring all stats together. >>ethtool stats are very valuable. so there is no point leaving them out. >>they

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-27 Thread Jiri Pirko
Mon, Jun 27, 2016 at 03:02:31PM CEST, ro...@cumulusnetworks.com wrote: >[resending ...my previous reply sent some non-text content] > >On Sun, Jun 26, 2016 at 11:51 PM, Jiri Pirko wrote: >> >> Mon, Jun 27, 2016 at 04:53:53AM CEST, ro...@cumulusnetworks.com wrote: >> >On Sun, Jun

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-27 Thread Roopa Prabhu
[resending ...my previous reply sent some non-text content] On Sun, Jun 26, 2016 at 11:51 PM, Jiri Pirko wrote: > > Mon, Jun 27, 2016 at 04:53:53AM CEST, ro...@cumulusnetworks.com wrote: > >On Sun, Jun 26, 2016 at 11:15 AM, Jiri Pirko wrote: > >> Sun, Jun 26,

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-27 Thread Jiri Pirko
Mon, Jun 27, 2016 at 04:53:53AM CEST, ro...@cumulusnetworks.com wrote: >On Sun, Jun 26, 2016 at 11:15 AM, Jiri Pirko wrote: >> Sun, Jun 26, 2016 at 08:06:40PM CEST, ro...@cumulusnetworks.com wrote: >>>On 6/26/16, 2:33 AM, Jiri Pirko wrote: Sat, Jun 25, 2016 at 05:50:59PM

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-26 Thread Roopa Prabhu
On Sun, Jun 26, 2016 at 11:15 AM, Jiri Pirko wrote: > Sun, Jun 26, 2016 at 08:06:40PM CEST, ro...@cumulusnetworks.com wrote: >>On 6/26/16, 2:33 AM, Jiri Pirko wrote: >>> Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: On Thu, Jun 23, 2016 at 8:40 AM,

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-26 Thread Jiri Pirko
Sun, Jun 26, 2016 at 08:06:40PM CEST, ro...@cumulusnetworks.com wrote: >On 6/26/16, 2:33 AM, Jiri Pirko wrote: >> Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >>> On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: Thu, Jun 23, 2016 at 05:11:26PM

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-26 Thread Roopa Prabhu
On 6/26/16, 2:33 AM, Jiri Pirko wrote: > Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >> On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: >>> Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: we can't separate CPU and

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-26 Thread Jiri Pirko
Sat, Jun 25, 2016 at 05:50:59PM CEST, ro...@cumulusnetworks.com wrote: >On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: >> Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: >>> we can't separate CPU and HW stats there. In some cases (or ASICs) HW

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-25 Thread Roopa Prabhu
On Thu, Jun 23, 2016 at 8:40 AM, Jiri Pirko wrote: > Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: >> we can't separate CPU and HW stats there. In some cases (or ASICs) HW >> counters do >> not include CPU generated packetsyou will

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Jiri Pirko
Thu, Jun 23, 2016 at 05:11:26PM CEST, anurad...@cumulusnetworks.com wrote: > we can't separate CPU and HW stats there. In some cases (or ASICs) HW > counters do > not include CPU generated packetsyou will have to add CPU > generated pkt counters to the > hw counters for

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Anuradha Karuppiah
we can't separate CPU and HW stats there. In some cases (or ASICs) HW counters do not include CPU generated packetsyou will have to add CPU generated pkt counters to the hw counters for such virtual device stats. >>> Can you please provide and example how that could

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Jiri Pirko
Thu, Jun 23, 2016 at 01:27:35PM CEST, ro...@cumulusnetworks.com wrote: >On 6/22/16, 10:40 PM, Jiri Pirko wrote: >> Wed, Jun 22, 2016 at 09:32:25PM CEST, ro...@cumulusnetworks.com wrote: >>> On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: From: Jiri Pirko

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-23 Thread Roopa Prabhu
On 6/22/16, 10:40 PM, Jiri Pirko wrote: > Wed, Jun 22, 2016 at 09:32:25PM CEST, ro...@cumulusnetworks.com wrote: >> On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: >>> From: Jiri Pirko >>> >>> The problem we try to handle is about offloaded forwarded

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-22 Thread Jiri Pirko
Wed, Jun 22, 2016 at 09:32:25PM CEST, ro...@cumulusnetworks.com wrote: >On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: >> From: Jiri Pirko >> >> The problem we try to handle is about offloaded forwarded packets >> which are not seen by kernel. Let me try

Re: [patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-22 Thread Roopa Prabhu
On Tue, Jun 21, 2016 at 8:15 AM, Jiri Pirko wrote: > From: Jiri Pirko > > The problem we try to handle is about offloaded forwarded packets > which are not seen by kernel. Let me try to draw it: > > port1 port2 (HW stats are counted

[patch net-next v5 0/4] return offloaded stats as default and expose original sw stats

2016-06-21 Thread Jiri Pirko
From: Jiri Pirko The problem we try to handle is about offloaded forwarded packets which are not seen by kernel. Let me try to draw it: port1 port2 (HW stats are counted here) \ / \/