Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-18 Thread Eric Dumazet
On Fri, 2016-11-18 at 16:38 -0800, Jarno Rajahalme wrote: > This fixes the problem for me, so for whatever it’s worth: > > Tested-by: Jarno Rajahalme > Thanks for testing !

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-18 Thread Jarno Rajahalme
> On Nov 14, 2016, at 3:09 PM, Eric Dumazet wrote: > > On Mon, 2016-11-14 at 14:46 -0800, Eric Dumazet wrote: >> On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: >> >>> synchronize_rcu_expidited is not enough if you have multiple network >>> devices in play.

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-17 Thread Jarno Rajahalme
> On Nov 14, 2016, at 3:09 PM, Eric Dumazet wrote: > > On Mon, 2016-11-14 at 14:46 -0800, Eric Dumazet wrote: >> On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: >> >>> synchronize_rcu_expidited is not enough if you have multiple network >>> devices in play.

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 14:46 -0800, Eric Dumazet wrote: > On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: > > > synchronize_rcu_expidited is not enough if you have multiple network > > devices in play. > > > > Looking at the code it comes down to this commit, and it appears there > >

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric Dumazet
On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: > synchronize_rcu_expidited is not enough if you have multiple network > devices in play. > > Looking at the code it comes down to this commit, and it appears there > is a promise add rcu grace period combining by Eric Dumazet. > >

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Eric W. Biederman
"Paul E. McKenney" writes: > On Mon, Nov 14, 2016 at 09:44:35AM -0800, Cong Wang wrote: >> On Mon, Nov 14, 2016 at 8:24 AM, Paul E. McKenney >> wrote: >> > On Sun, Nov 13, 2016 at 10:47:01PM -0800, Cong Wang wrote: >> >> On Fri, Nov 11,

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Paul E. McKenney
On Mon, Nov 14, 2016 at 09:44:35AM -0800, Cong Wang wrote: > On Mon, Nov 14, 2016 at 8:24 AM, Paul E. McKenney > wrote: > > On Sun, Nov 13, 2016 at 10:47:01PM -0800, Cong Wang wrote: > >> On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang > >>

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Cong Wang
On Mon, Nov 14, 2016 at 8:24 AM, Paul E. McKenney wrote: > On Sun, Nov 13, 2016 at 10:47:01PM -0800, Cong Wang wrote: >> On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang wrote: >> > On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney >> >

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Hannes Frederic Sowa
Hi Cong, On Sat, Nov 12, 2016, at 01:55, Cong Wang wrote: > On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney > wrote: > > > > Ah! This net_mutex is different than RTNL. Should synchronize_net() be > > modified to check for net_mutex being held in addition to the

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-14 Thread Paul E. McKenney
On Sun, Nov 13, 2016 at 10:47:01PM -0800, Cong Wang wrote: > On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang wrote: > > On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney > > wrote: > >> > >> Ah! This net_mutex is different than RTNL. Should

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-13 Thread Cong Wang
On Fri, Nov 11, 2016 at 4:55 PM, Cong Wang wrote: > On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney > wrote: >> >> Ah! This net_mutex is different than RTNL. Should synchronize_net() be >> modified to check for net_mutex being held in

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-11 Thread Cong Wang
On Fri, Nov 11, 2016 at 4:23 PM, Paul E. McKenney wrote: > > Ah! This net_mutex is different than RTNL. Should synchronize_net() be > modified to check for net_mutex being held in addition to the current > checks for RTNL being held? > Good point! Like commit

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-11 Thread Paul E. McKenney
On Fri, Nov 11, 2016 at 01:11:01PM +, Rolf Neugebauer wrote: > On Thu, Nov 10, 2016 at 9:24 PM, Paul E. McKenney > wrote: > > On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: > >> (Cc'ing Paul) > >> > >> On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer >

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-11 Thread Rolf Neugebauer
On Thu, Nov 10, 2016 at 9:24 PM, Paul E. McKenney wrote: > On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: >> (Cc'ing Paul) >> >> On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer >> wrote: >> > Hi >> > >> > We noticed some long

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-10 Thread Paul E. McKenney
On Thu, Nov 10, 2016 at 09:37:47AM -0800, Cong Wang wrote: > (Cc'ing Paul) > > On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer > wrote: > > Hi > > > > We noticed some long delays starting docker containers on some newer > > kernels (starting with 4.5.x and still

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-10 Thread Cong Wang
(Cc'ing Paul) On Wed, Nov 9, 2016 at 7:42 AM, Rolf Neugebauer wrote: > Hi > > We noticed some long delays starting docker containers on some newer > kernels (starting with 4.5.x and still present in 4.9-rc4, 4.4.x is > fine). We narrowed this down to the creation of a