Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-10-03 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 03, 2016 at 10:27:44PM +0200, Geert Uytterhoeven escreveu: > On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: > > On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: > >>> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device > >>> *vrf_dev, >

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-04 Thread Geert Uytterhoeven
Hi David, On Thu, Aug 4, 2016 at 7:01 AM, David Ahern wrote: > Does making the code the same between those 2 functions matter? Yes, it does make the warning go away. > diff --git a/drivers/net/vrf.c b/drivers/net/vrf.c > index 1ce7420322ee..3951a2c98431 100644 > ---

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-03 Thread Geert Uytterhoeven
On Wed, Aug 3, 2016 at 10:36 PM, David Ahern wrote: > On 8/3/16 2:27 PM, Geert Uytterhoeven wrote: >> On Wed, Aug 3, 2016 at 10:11 PM, David Ahern >> wrote: >>> On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: > +static void

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-03 Thread David Ahern
On 8/3/16 2:27 PM, Geert Uytterhoeven wrote: > On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: >> On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device *vrf_dev, > +

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-03 Thread Geert Uytterhoeven
On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: > On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: >>> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device >>> *vrf_dev, >>> > + int ifindex) >>> > +{ >>> > + const

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-03 Thread David Ahern
On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: >> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device >> *vrf_dev, >> > + int ifindex) >> > +{ >> > + const struct ipv6hdr *iph = ipv6_hdr(skb); >> > + struct flowi6 fl6 = { >> > +

Re: net: vrf: Handle ipv6 multicast and link-local addresses

2016-08-03 Thread Geert Uytterhoeven
9ff601 > Parent: ba46ee4c0ed122fa14aa2f5d6994c166a01ae2c0 > Refname:refs/heads/master > Author: David Ahern <d...@cumulusnetworks.com> > AuthorDate: Mon Jun 13 13:44:19 2016 -0700 > Committer: David S. Miller <da...@davemloft.net> > CommitDate: Wed Jun 15 12:34:34 2016 -0700 > > net:

Re: [PATCH net-next 0/3] net: vrf: Handle ipv6 multicast and link-local addresses

2016-06-15 Thread David Miller
From: David Ahern Date: Mon, 13 Jun 2016 13:44:16 -0700 > IPv6 multicast and link-local addresses require special handling by the > VRF driver. Rather than using the VRF device index and full FIB lookups, > packets to/from these addresses should use direct FIB lookups

[PATCH net-next 0/3] net: vrf: Handle ipv6 multicast and link-local addresses

2016-06-13 Thread David Ahern
ssh -6 root@fe80::18f8:83ff:fe4b:7a2e%eth1 David Ahern (3): net: l3mdev: Remove const from flowi6 arg to get_rt6_dst net: ipv6: Do not add multicast route for l3 master devices net: vrf: Handle ipv6 multicast and link-local addresses drivers/net/vrf.c | 100

[PATCH net-next 3/3] net: vrf: Handle ipv6 multicast and link-local addresses

2016-06-13 Thread David Ahern
IPv6 multicast and link-local addresses require special handling by the VRF driver: 1. Rather than using the VRF device index and full FIB lookups, packets to/from these addresses should use direct FIB lookups based on the VRF device table. 2. fail sends/receives on a VRF device to/from a

[PATCH net-next 10/13] net: vrf: Handle ipv6 multicast and link-local addresses

2016-05-04 Thread David Ahern
IPv6 multicast and link-local addresses require special handling by the VRF driver. Rather than using the VRF device index and a full FIB lookups packets to/from these addresses should use direct FIB lookups. Multicast routes do not make sense for L3 master devices. So, do not add mcast routes