[git patch] since the definition of dst_discard_in and dst_discard_out are the same,,they should merged into one

2007-05-31 Thread Rankle_
From 30d6996860f7e5589d1bce10404bbcfd6592c9de Mon Sep 17 00:00:00 2001 From: Denis Cheng [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:21:58 +0800 Subject: [PATCH] since the definition of dst_discard_in and dst_discard_out are the same, they should merged into one Signed-off-by: Denis Cheng

Re: [PATCH 2/2] bridge: round off STP perodic timers

2007-05-31 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Wed, 30 May 2007 12:14:22 -0700 Peroidic STP timers don't have to be exact. The hold timer runs at 1HZ, and the hello timer normally runs at 2HZ; save power by aligning it them to next second. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]

Re: [PATCH 0/4] mac80211 fixes for 2.6.22

2007-05-31 Thread David Miller
From: John W. Linville [EMAIL PROTECTED] Date: Wed, 30 May 2007 14:25:38 -0400 Some bug fixes that should be applied to 2.6.22: mac80211: fail back to use associate from reassociate mac80211: fix memory leak when defrag fragments mac80211: always set carrier status on open

Re: [git patch] since the definition of dst_discard_in and dst_discard_out are the same,,they should merged into one

2007-05-31 Thread David Miller
From: Rankle_ [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:26:54 +0800 From 30d6996860f7e5589d1bce10404bbcfd6592c9de Mon Sep 17 00:00:00 2001 From: Denis Cheng [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:21:58 +0800 Subject: [PATCH] since the definition of dst_discard_in and dst_discard_out

Re: [PATCH 1/9] [TCP]: Move Reno SACKed_out counter functions earlier

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:54 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] This is of course trivial and fine, applied. - To unsubscribe from this list: send the line unsubscribe netdev

Re: [PATCH 2/9] [TCP] FRTO: remove unnecessary fackets/sacked_out recounting

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:55 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] F-RTO does not touch SACKED_ACKED bits at all, so there is no need to recount them in tcp_enter_frto_loss. After removal of the else branch, nested ifs can be

Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:56 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] It is easily calculable when needed and user are not that many after all. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] This looks good, but are you

Re: [PATCH 4/9] [TCP]: Access to highest_sack obsoletes forward_cnt_hint

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:57 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, added a reference about the purpose of the loop. Signed-off-by: Ilpo Järvinen [EMAIL PROTECTED] Nice observation, patch applied. - To

Re: [PATCH 5/9] [TCP]: Move code from tcp_ecn.h to tcp*.c and tcp.h remove it

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:58 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] No other users exist for tcp_ecn.h. Very few things remain in tcp.h, for most TCP ECN functions callers reside within a single .c file and can be placed

Re: [PATCH 6/9] [TCP]: Reorganize lost marking code

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:59 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] The indentation started to get scary, so I reorganized code so that some trivial ifs are in tcp_update_scoreboard and the main loops remain in

Re: [PATCH 7/9] [TCP]: Correct fastpath entrypoint below high_seq

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:36:00 +0300 From: =?ISO-8859-1?q?Ilpo_J=E4rvinen?= [EMAIL PROTECTED] In addition, implemented find_below using minus one. Some reorganization was necessary to make code efficient again. Signed-off-by: Ilpo Järvinen [EMAIL

Re: [git patch] since the definition of dst_discard_in and dst_discard_out are the same,,they should merged into one

2007-05-31 Thread rae l
On 5/31/07, David Miller [EMAIL PROTECTED] wrote: Your email client has changed all of the tab characters into spaces, corrupting the patch. Please configure your email client to not perform any text formatting. Please test this, by emailing the patch to yourself and trying to apply it,

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-31 Thread Andi Kleen
Venki Pallipadi [EMAIL PROTECTED] writes: If this does not work: Another option is to use 'deferrable timer' here which will be called at same as before time when CPU is busy and on idle CPU it will be delayed until CPU comes out of idle due to any other events. That would sound like a good

[PATCH 1/2] ehea: Whitespace cleanup

2007-05-31 Thread Thomas Klein
This patch fixes several whitespace issues. Signed-off-by: Thomas Klein [EMAIL PROTECTED] --- diff -Nurp -X dontdiff linux-2.6.22-rc3/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.22-rc3/drivers/net/ehea/ehea.h2007-05-30 12:13:36.0 +0200 +++

[PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Thomas Klein
After there were no technical concerns about this patch I'm resending it with all whitespace issues fixed which were mentioned by Stephen Rothwell. This patch enables the receive side processing to aggregate TCP packets within the HEA device driver. It analyses the packets already received after

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-31 Thread KOVACS Krisztian
Hi, On Thursday 31 May 2007 02:21, Julian Anastasov wrote: I've posted a few patches making omitting this check possible selectively back in March. Do those changes look acceptable? http://marc.info/?l=linux-netdevm=117310979823297w=3 Also, i'm not sure if

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Christoph Hellwig
I'm still very unhappy with having all this in various drivers. There's a lot of code that can be turned into generic library functions, and even more code that could be made generic with some amount of refactoring. - To unsubscribe from this list: send the line unsubscribe netdev in the body of

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Kok, Auke
Herbert Xu wrote: On Wed, May 30, 2007 at 09:51:14PM -0700, Kok, Auke wrote: this has been an age-old confusion that I never grasped either, so I perfectly understand why you added the explicit e1000_disable_irq call in the other patch (and think thats a great idea). But really, there should

Re: [PATCH] [XFRM]: Add module alias for transformation type. (Re: [PATCH 2/2] [IPV6] MIP6: Loadable module support for MIPv6.)

2007-05-31 Thread Ingo Oeser
Dear Nakamura-san, [EMAIL PROTECTED] schrieb: This is the third one of MIPv6 module patch. It can be applied after two patches which are already sent to the list. Could you review it? They look good. Thanks for taking the time to clean this up! Acked-by: Ingo Oeser [EMAIL PROTECTED] Best

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Doug Chapman
On Thu, 2007-05-31 at 11:08 +1000, Herbert Xu wrote: On Wed, May 30, 2007 at 05:22:30PM -0400, Doug Chapman wrote: but once again broken just yesterday by the following commit. I have backed just this commit out and verified I no longer panic. Hmm, the only way I can see this happening

Re: [E1000-devel] REGRESSION: panic on e1000 driver

2007-05-31 Thread Kok, Auke
Doug Chapman wrote: On Thu, 2007-05-31 at 11:08 +1000, Herbert Xu wrote: On Wed, May 30, 2007 at 05:22:30PM -0400, Doug Chapman wrote: but once again broken just yesterday by the following commit. I have backed just this commit out and verified I no longer panic. Hmm, the only way I can see

Re: [PATCH 3/9] [TCP]: Tighten tcp_sock's belt, drop left_out

2007-05-31 Thread Ilpo Järvinen
Thanks for you comments... On Thu, 31 May 2007, David Miller wrote: From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Sat, 26 May 2007 11:35:56 +0300 It is easily calculable when needed and user are not that many after all. This looks good, but are you absolutely sure we never used a stale

Re: [PATCH 2/2] ehea: Receive SKB Aggregation

2007-05-31 Thread Stephen Hemminger
+static int try_get_ip_tcp_hdr(struct ehea_cqe *cqe, struct sk_buff *skb, + struct iphdr **iph, struct tcphdr **tcph) +{ + int ip_len; + + /* non tcp/udp packets */ + if (!cqe-header_length) + return -1; + + /* non tcp packet */

[PATCH]: sky2: Fix VLAN unregistration

2007-05-31 Thread Stephen Hemminger
On Sun, 27 May 2007 20:44:04 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: Fix sky2 disabling VLAN completely when the first vid is unregistered. For some reason the VLAN code insists on the driver providing a vlan_rx_kill_vid function even if only NETIF_F_HW_VLAN_RX and not

Re: [PATCH]: sky2: Fix VLAN unregistration

2007-05-31 Thread Patrick McHardy
Stephen Hemminger wrote: On Sun, 27 May 2007 20:44:04 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: Fix sky2 disabling VLAN completely when the first vid is unregistered. For some reason the VLAN code insists on the driver providing a vlan_rx_kill_vid function even if only

Re: [PATCH]: sky2: Fix VLAN unregistration

2007-05-31 Thread Stephen Hemminger
On Thu, 31 May 2007 19:37:07 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Sun, 27 May 2007 20:44:04 +0200 Patrick McHardy [EMAIL PROTECTED] wrote: Fix sky2 disabling VLAN completely when the first vid is unregistered. For some reason the VLAN code

[PATCH 2.6.23] mac80211: Add support for SIOCGIWRATE ioctl

2007-05-31 Thread John W. Linville
From: Larry Finger [EMAIL PROTECTED] At present, transmission rate information for mac80211 is available only if verbose debugging is turned on, and then only in the logs. This patch implements the SIOCGIWRATE ioctl, which adds the current transmission rate to the output of iwconfig.

Re: Suspicious fackets_out handling

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Mon, 23 Apr 2007 14:28:21 +0300 (EEST) There are IMHO two problems in it. First of all, nothing ensures that the skb TCP is fragmenting is actually below the forwardmost sack block (and thus is included to the fackets_out)... Good catch, I agree

[PATCH] net/hp100: fix section mismatch warning

2007-05-31 Thread Sam Ravnborg
Fix following section mismatch warning in hp100: WARNING: drivers/net/hp100.o(.init.text+0x26a): Section mismatch: reference to .exit.text: (after 'init_module') The warning says that we use a function marked __exit from a function marked __init. This is not good on architectures where we

Re: [patch 5/7] CAN: Add virtual CAN netdevice driver

2007-05-31 Thread Oliver Hartkopp
Patrick McHardy wrote: Urs Thuermann wrote: +/* tx socket reference pointer: Loopback required if not NULL */ +loop = *(struct sock **)skb-cb != NULL; Qdiscs might change skb-cb. Maybe use skb-sk? Hi Patrick, due to current projects Urs and me had only a short time

[TG3]: Fix link problem on Dell's onboard 5906.

2007-05-31 Thread Michael Chan
[TG3]: Fix link problem on Dell's onboard 5906. The bug is caused by code that always set (TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's onboard devices. With these 2 flags set, the link status is polled by tg3_timer() and will only work when the PHY is set up to interrupt

Re: Please pull 'libertas' branch of wireless-2.6

2007-05-31 Thread Dan Williams
On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote: On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote: John W. Linville wrote: Lots of stuff here...probably best for 2.6.23... Is this best for Linux users... or just easy for developers? Won't putting off all these fixes until

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Herbert Xu
On Thu, May 31, 2007 at 07:54:31AM -0700, Kok, Auke wrote: so how about calling netif_poll_disable() before we register the net_device? Yes that should work. Let's move the other two netif_ calls while we're at it. well no, if we make the watchdog (this is something I've already

Re: [TG3]: Fix link problem on Dell's onboard 5906.

2007-05-31 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Thu, 31 May 2007 15:03:39 -0700 [TG3]: Fix link problem on Dell's onboard 5906. The bug is caused by code that always set (TG3_FLAG_USE_MI_INTERRUPT | TG3_FLAG_USE_LINKCHG_REG) on all Dell's onboard devices. With these 2 flags set, the link status

Re: [E1000-devel] REGRESSION: panic on e1000 driver

2007-05-31 Thread Herbert Xu
On Thu, May 31, 2007 at 08:23:24AM -0700, Kok, Auke wrote: e1000: :01:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f8 e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection e1000: :01:02.1: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f9 e1000: eth1: e1000_probe:

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Herbert Xu
On Thu, May 31, 2007 at 11:16:09AM -0400, Doug Chapman wrote: # dmesg | grep e1000 e1000: :01:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f8 e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection e1000: :01:02.1: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f9

Re: [E1000-devel] REGRESSION: panic on e1000 driver

2007-05-31 Thread Kok, Auke
Herbert Xu wrote: On Thu, May 31, 2007 at 08:23:24AM -0700, Kok, Auke wrote: e1000: :01:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f8 e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection e1000: :01:02.1: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f9 e1000:

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Kok, Auke
Herbert Xu wrote: On Thu, May 31, 2007 at 07:54:31AM -0700, Kok, Auke wrote: so how about calling netif_poll_disable() before we register the net_device? Yes that should work. Let's move the other two netif_ calls while we're at it. well no, if we make the watchdog (this is something I've

Re: [Oops] unix_dgram_connect locking problem?

2007-05-31 Thread David Miller
From: Frederik Deweerdt [EMAIL PROTECTED] Date: Fri, 11 May 2007 17:00:14 +0200 I'm seeing an Oops[1] with a 2.6.19.2 kernel: Frederik, I finally was able to spend some quality time on this issue today. Sorry for taking so long. I came up with a series of two patches, the first one makes the

Re: Please pull 'libertas' branch of wireless-2.6

2007-05-31 Thread John W. Linville
On Thu, May 31, 2007 at 05:13:17PM -0400, Dan Williams wrote: On Wed, 2007-05-30 at 11:28 -0400, Dan Williams wrote: On Wed, 2007-05-30 at 10:07 -0400, Jeff Garzik wrote: John W. Linville wrote: Lots of stuff here...probably best for 2.6.23... Is this best for Linux users... or

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Doug Chapman
On Fri, 2007-06-01 at 08:10 +1000, Herbert Xu wrote: On Thu, May 31, 2007 at 11:16:09AM -0400, Doug Chapman wrote: # dmesg | grep e1000 e1000: :01:02.0: e1000_probe: (PCI-X:66MHz:64-bit) 00:15:60:04:d7:f8 e1000: eth0: e1000_probe: Intel(R) PRO/1000 Network Connection e1000:

Re: [PATCH] use default 32768-61000 outgoing port range in all cases

2007-05-31 Thread David Miller
From: Mark Glines [EMAIL PROTECTED] Date: Tue, 15 May 2007 15:50:54 -0700 I noticed I had chopped off a whole comment, when I meant to only remove part of it. So I've fixed that. This is a reissued use-high-ports-for-local-stuff.diff, with a comment fix. Does anyone have a problem with

Re: [IPV4] LVS: Allow to send ICMP unreachable responses when real-servers are removed

2007-05-31 Thread Julian Anastasov
Hello, On Thu, 31 May 2007, KOVACS Krisztian wrote: So what about this one? May be we can try with better coding style. Also, this version adds undefined behavior for using FLOWI_FLAG_ANYSRC with multicast oldflp-fl4_dst Loosen source address check on IPv4 output From:

Re: [PATCH] improved locking performance in rt_run_flush()

2007-05-31 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 20 May 2007 15:11:48 +1000 David Miller [EMAIL PROTECTED] wrote: From: Dave Johnson [EMAIL PROTECTED] The below patch changes rt_run_flush() to only take each spinlock protecting the rt_hash_table once instead of taking a spinlock for

Re: REGRESSION: panic on e1000 driver

2007-05-31 Thread Herbert Xu
On Thu, May 31, 2007 at 06:38:28PM -0400, Doug Chapman wrote: I get a backtrace as it probes each e1000 device and I also still get the unexpected interrupt message. WARNING: at drivers/net/e1000/e1000_main.c:1331 e1000_sw_init() Thanks for testing! Although I still don't know what

bond_3ad.c: why does bond_3ad_set_carrier() check if the mac partnet mac is set.

2007-05-31 Thread Laurent Chavey
if a host configured with 802.3ad bond mode is connected to a switch that does not support 802.3ad, then an aggregator is selected as the active aggregator (first link that has carrier in the slave list). This is perfectly fine, since it lets at least one of the link become active. (this was the

[PATCH] Fix bug of update IPv4 PMTU when received ICMP Fragmentation Needed message

2007-05-31 Thread Wei Yongjun
When received ICMP Fragmentation Needed message, PATH MTU is always set to the 576 even if MTU in ICMP message is lager then 576. This is because of error condition in function ip_rt_frag_needed(), now if packet size of that ICMP message is less then new MTU, packet size will be used ,but RFC

Re: [PATCH] net: fix comparisons of unsigned 0

2007-05-31 Thread David Miller
From: Bill Nottingham [EMAIL PROTECTED] Date: Wed, 30 May 2007 03:56:13 -0400 Recent gcc versions emit warnings when unsigned variables are compared 0 or = 0. Signed-off-by: Bill Nottingham [EMAIL PROTECTED] Patch applied, thanks. - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules)

2007-05-31 Thread David Miller
From: Ilpo_Järvinen [EMAIL PROTECTED] Date: Wed, 30 May 2007 12:10:06 +0300 (EEST) Based on feedback from Stephen, I changed the commit msg bit clearer, the patch remains the same. [PATCH] [TCP]: Fix GSO ignorance of pkts_acked arg (cong.cntrl modules) The code used to ignore GSO

Re: Fix ipOutNoRoutes counter error for TCP and UDP

2007-05-31 Thread David Miller
From: Wei Dong [EMAIL PROTECTED] Date: Thu, 31 May 2007 09:16:50 +0800 Hi Mr. David I have modified my patch according to you advice. I think - EHOSTUNREACH is only for input path. In output path, we can just simply check-ENETUNREACH (^_^), the patch is shown in the end of this mail. I

Re: [NET] gso: Fix GSO feature mask in sk_setup_caps

2007-05-31 Thread Herbert Xu
On Thu, May 31, 2007 at 10:16:22PM -0700, David Miller wrote: I don't think it's worth bothering -stable with this one, agreed? Not unless we're planning on making UFO use sk_setup_caps :) Agreed! Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL

[NET] gso: Fix GSO feature mask in sk_setup_caps

2007-05-31 Thread Herbert Xu
Hi Dave: [NET] gso: Fix GSO feature mask in sk_setup_caps This isn't a bug just yet as only TCP uses sk_setup_caps for GSO. However, if and when UDP or something else starts using it this is likely to cause a problem if we forget to add software emulation for it at the same time. The problem is

Re: [NET] gso: Fix GSO feature mask in sk_setup_caps

2007-05-31 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 1 Jun 2007 15:13:49 +1000 [NET] gso: Fix GSO feature mask in sk_setup_caps This isn't a bug just yet as only TCP uses sk_setup_caps for GSO. However, if and when UDP or something else starts using it this is likely to cause a problem if we

RE: [PATCH 2/5] phylib: enable RGMII-ID on the Marvell m88e1111 PHY

2007-05-31 Thread Li Yang-r58472
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Kim Phillips Sent: Saturday, May 12, 2007 7:25 AM To: Jeff Garzik; netdev@vger.kernel.org Subject: [PATCH 2/5] phylib: enable RGMII-ID on the Marvell m88e PHY Support for configuring RGMII-ID

Re: Fix ipOutNoRoutes counter error for TCP and UDP

2007-05-31 Thread weidong
Mr David Sorry to trouble many times, I will attention to this next time. I have made this patch again, and I tried, it can be patched to the recently kernel of linux-2.6.21.3. following is the patch, and I also attach this patch to the attachment. Signed-off-by: Wei Dong [EMAIL