[PATCH RFC 1/2] cdc_ncm: add the currently processed NDP frame to global driver data

2015-06-02 Thread Enrico Mioso
This is useful to split up the cdc_ncm_ndp function later on. The resulting code will be anyway stateful. Signed-Off-By: Enrico Mioso mrkiko...@gmail.com --- include/linux/usb/cdc_ncm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/usb/cdc_ncm.h b/include/linux/usb/cdc_ncm.h

[PATCH RFC 0/2] cdc_ncm refactoring

2015-06-02 Thread Enrico Mioso
I changed my mind, and decided to try in following this new way. This series splits the cdc_ncm_ndp function in two parts: - one that finds NDP blocks already present in the SKB being sent out - one that pushes new ones, starting from where the _find function left. After this splitting it seems

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Scott Feldman
On Mon, Jun 1, 2015 at 10:24 PM, David Miller da...@davemloft.net wrote: From: Toshiaki Makita makita.toshi...@lab.ntt.co.jp Date: Tue, 02 Jun 2015 13:51:06 +0900 On 2015/06/02 3:39, sfel...@gmail.com wrote: From: Scott Feldman sfel...@gmail.com Remove support for legacy ndo ops

Re: [PATCH 7/7] mac80211: Switch to new AEAD interface

2015-06-02 Thread Jouni Malinen
On Mon, Jun 01, 2015 at 05:36:58PM +0200, Stephan Mueller wrote: Am Montag, 1. Juni 2015, 16:35:26 schrieb Johannes Berg: IOW, I think something like this would make sense: That looks definitely cleaner :-) Indeed.. That AAD length-in-the-buffer design came from the over ten year old code

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Junling Zheng
On 2015/6/2 14:52, Willy Tarreau wrote: On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: On 2015/6/2 14:27, Greg KH wrote: On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: From: Junling Zheng zhengjunl...@huawei.com Date: Tue, 2 Jun 2015 12:05:32 +0800 So, the

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Guenter Roeck
Vivien, On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit implements the port_vlan_add and port_vlan_del functions in the dsa_switch_driver structure for Marvell 88E6xxx compatible switches. This allows to access a switch VLAN Table Unit, and thus define VLANs from standard userspace

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch adds the glue between DSA and switchdev to add and delete SWITCHDEV_OBJ_PORT_VLAN objects. This will allow the DSA switch drivers implementing the port_vlan_add and port_vlan_del functions to access the switch VLAN database through

Re: [PATCH net-next v2 01/14] sfc: Add code to export port_num in netdev-dev_port

2015-06-02 Thread Shradha Shah
On 01/06/15 20:01, David Miller wrote: From: Shradha Shah ss...@solarflare.com Date: Mon, 1 Jun 2015 14:00:12 +0100 In the case where we have multiple functions (PFs and VFs), this sysfs entry is useful to identify the physical port corresponding to the function we are interested in.

linux-next: manual merge of the scsi tree with the net-next tree

2015-06-02 Thread Stephen Rothwell
Hi James, Today's linux-next merge of the scsi tree got a conflict in drivers/target/target_core_user.c between commit 5538d294dd66 (treewide: Add missing vmalloc.h inclusion) from the net-next tree and commit 7ad09a15e76b (target: Minimize SCSI header #include directives) from the scsi tree. I

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Scott Feldman
On Mon, Jun 1, 2015 at 11:50 PM, Guenter Roeck li...@roeck-us.net wrote: [cut] I brought this up before. No idea if my e-mail got lost or what happened. We use a fid per port, and a fid per bridge group. With VLANs, this is completely ignored, ahd there is only a single fid per vlan for the

[BUG] be2net breaks when dma_alloc_coherent memory is not zeroed out

2015-06-02 Thread Joerg Roedel
Hi, yesterday I bisected an issue with one of my be2net adapters and AMD IOMMU enabled. In 4.1-rc it suddenly broke and didn't initialize anymore. It turned out that the be2net driver breaks when the memory returned from dma_alloc_coherent is not zeroed out. I introduced that change to the AMD

[PATCH net-next] net/mlx4_core: Fix build failure introduced by the EQ pool changes

2015-06-02 Thread Or Gerlitz
When CONFIG_RFS_ACCEL or SMP aren't set, we fail to build, fix it. Also, avoid build warning as of unused function on that setup. Fixes: c66fa19c405a ('net/mlx4: Add EQ pool') Reported-by: Michael Ellerman m...@ellerman.id.au Signed-off-by: Matan Barak mat...@mellanox.com Signed-off-by: Or

Re: [PATCH 1/2] Bluetooth: Add reset_resume function

2015-06-02 Thread Oliver Neukum
On Mon, 2015-06-01 at 18:14 -0700, Laura Abbott wrote: Bluetooth devices off of some buses such as USB may lose power across suspend/resume. When this happens, drivers may need to have the setup function called again and behave differently than a cold power on. Yes, but what is the point? We

[PATCH RFC 2/2] cdc_ncm: split the cdc_ncm_ndp funciton

2015-06-02 Thread Enrico Mioso
Split this function in two new ones: - cdc_ncm_ndp16_find: finds an NDP block in the chain mathcing a supplied signature; a pointer to it is returned in case of success; - cdc_ncm_ndp16_push: create and add to skb a new NDP block; cdc_ncm_ndp16_push refers to the last NDP visited by

[PATCH] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Denis Kirjanov
Perform the address length check first, before calling the the proto specific bind() function Signed-off-by: Denis Kirjanov k...@linux-powerpc.org --- net/ipv4/af_inet.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index

Re: [RFC] [PATCH] net: socket: Fix the wrong returns for recvmsg and sendmsg

2015-06-02 Thread Willy Tarreau
On Tue, Jun 02, 2015 at 02:43:54PM +0800, Junling Zheng wrote: On 2015/6/2 14:27, Greg KH wrote: On Mon, Jun 01, 2015 at 10:23:57PM -0700, David Miller wrote: From: Junling Zheng zhengjunl...@huawei.com Date: Tue, 2 Jun 2015 12:05:32 +0800 So, the problem commit is 281c9c36 (net:

Re: [PATCH net] net/mlx4: need to call close fw if alloc icm is called twice

2015-06-02 Thread Or Gerlitz
On Mon, Jun 1, 2015 at 5:41 PM, cls...@linux.vnet.ibm.com wrote: --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -2837,6 +2837,7 @@ slave_start: existing_vfs,

Re: [PATCH net] net/mlx4: double free of dev_vfs

2015-06-02 Thread Or Gerlitz
On Mon, Jun 1, 2015 at 5:41 PM, cls...@linux.vnet.ibm.com wrote: --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -2685,6 +2685,7 @@ disable_sriov: free_mem: dev-persist-num_vfs = 0; kfree(dev-dev_vfs); + dev-dev_vfs

[PATCH 00/10] net: thunderx: fix problems reported by static check tools

2015-06-02 Thread Aleksey Makarov
These are fixes for the problems that were reported by static check tools. Aleksey Makarov (9): net: thunderx: fix constants net: thunderx: introduce a function for mailbox access net: thunderx: rework mac address handling net: thunderx: delete unused variables net: thunderx: add static

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an interface for each tunnel endpoint

Re: [PATCH net-next 5/5] rocker: remove support for legacy VLAN ndo ops

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 9:58 AM, roopa ro...@cumulusnetworks.com wrote: On 6/2/15, 7:30 AM, Scott Feldman wrote: On Tue, Jun 2, 2015 at 4:43 AM, Jamal Hadi Salim j...@mojatatu.com wrote: On 06/02/15 03:10, Scott Feldman wrote: Actually, we're now consistent with bridge man page which says

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: You failed to thread the patch series again -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 04/10] net: thunderx: rework mac address handling

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:385:40: sparse: cast to restricted __le64 Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/nic.h | 4

[PATCH 07/10] net: thunderx: fix nicvf_set_rxfh()

2015-06-02 Thread Aleksey Makarov
This fixes a copypaste bug that was discovered by a static analysis tool: The patch 4863dea3fab0: net: Adding support for Cavium ThunderX network controller from May 26, 2015, leads to the following static checker warning: drivers/net/ethernet/cavium/thunder/nicvf_ethtool.c:517

[PATCH 03/10] net: thunderx: introduce a function for mailbox access

2015-06-02 Thread Aleksey Makarov
This fixes sparse message: drivers/net/ethernet/cavium/thunder/nicvf_main.c:153:25: sparse: cast to restricted __le64 Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/nicvf_main.c | 27

Re: [Intel-wired-lan] [PATCH 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Rustad, Mark D
On Jun 2, 2015, at 10:48 AM, Alexander Duyck alexander.h.du...@redhat.com wrote: I'm pretty sure these could cause some serious errors if you direct assign the device into a VM since you then end up with multiple devices sharing a bus. Also it would likely have side-effects on a LOM

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
roopa ro...@cumulusnetworks.com writes: On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting up an

[PATCH 05/10] net: thunderx: delete unused variables

2015-06-02 Thread Aleksey Makarov
They were left from development stage Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/10] net: thunderx: check if memory allocation was successful

2015-06-02 Thread Aleksey Makarov
This fixes a coccinelle warning: coccinelle warnings: (new ones prefixed by ) drivers/net/ethernet/cavium/thunder/nicvf_queues.c:360:1-11: alloc with no test, possible model on line 367 vim +360 drivers/net/ethernet/cavium/thunder/nicvf_queues.c 354 err =

[PATCH 10/10] net: thunderx: use GFP_KERNEL in thread context

2015-06-02 Thread Aleksey Makarov
GFP_KERNEL should be used in the thread context Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cavium/thunder/nicvf_queues.c

[PATCH 08/10] net: thunderx: remove unneeded type conversions

2015-06-02 Thread Aleksey Makarov
No need to cast void* to u8*: pointer arithmetics works same way for both. Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com --- drivers/net/ethernet/cavium/thunder/nicvf_queues.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 06/10] net: thunderx: add static

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/nicvf_main.c:1141:26: sparse: symbol 'nicvf_get_stats64' was not declared. Should it be static? Also remove unused declarations Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Aleksey Makarov

Re: [ovs-dev] [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Flavio Leitner
It seems patch 01 didn't make it to ovs dev mailing list, but it is available on netdev mailing list. fbl -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 02/10] net: thunderx: fix constants

2015-06-02 Thread Aleksey Makarov
This fixes sparse messages like this: drivers/net/ethernet/cavium/thunder/thunder_bgx.c:897:24: sparse: constant 0x3000 is so big it is long Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Aleksey Makarov aleksey.maka...@caviumnetworks.com ---

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack of labels, in the same format as for RTA_NEWST. It uses the encap data

[PATCH] drivers/net/ethernet/dec/tulip/uli526x.c: fix misleading indentation in uli526x_timer

2015-06-02 Thread David Malcolm
This code in drivers/net/ethernet/dec/tulip/uli526x.c function uli526x_timer: 1086 } else 1087 if ((tmp_cr12 0x3) db-link_failed) { [...snip...] 1109 } 1110 else if(!(tmp_cr12 0x3) db-link_failed) {

[PATCH net-next V10 1/4] openvswitch: 802.1ad uapi changes.

2015-06-02 Thread Thomas F Herbert
openvswitch: Add support for 8021.AD Change the description of the VLAN tpid field. Signed-off-by: Thomas F Herbert thomasfherb...@gmail.com --- include/uapi/linux/openvswitch.h | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git

[PATCH 01/10] net: thunderx: Cleanup duplicate NODE_ID macros, add nic_get_node_id()

2015-06-02 Thread Aleksey Makarov
From: Robert Richter rrich...@cavium.com There are duplicate NODE_ID macro definitions. Move all of them to nic.h for usage in nic and bgx driver and introduce nic_get_node_id() helper function. This patch also fixes 64bit mask which should have been ULL by reworking the node calculation.

Re: [net-next RFC 00/14] Convert OVS tunnel vports to use regular net_devices

2015-06-02 Thread Eric W. Biederman
Thomas Graf tg...@suug.ch writes: This is the first series in a greater effort to bring the scalability and programmability advantages of OVS to the rest of the network stack and to get rid of as much OVS specific code as possible. This first series focuses on getting rid of OVS tunnel

How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
As far as I can tell, enabling IP_RECVERR causes the presence of a queued error to cause recvmsg, etc to return an error (once). It's worse, though: a new error can be queued asynchronously at any time, this setting sk_err to a nonzero value. How do I sensibly distinguish recvmsg failures to to

Re: [PATCH 00/10] net: thunderx: fix problems reported by static check tools

2015-06-02 Thread David Miller
From: Aleksey Makarov aleksey.maka...@caviumnetworks.com Date: Tue, 2 Jun 2015 11:00:17 -0700 These are fixes for the problems that were reported by static check tools. Series applied, thanks. -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[PATCH net-next V10 0/4] openvswitch: Add support for 802.1AD

2015-06-02 Thread Thomas F Herbert
Add support for 802.1AD to the openvswitch kernel module. V10: Implement reviewer comments: Consolidate vlan parsing functions. Splits netlink parsing and flow conversion into a separate patch. Uses double encap attribute encapsulation for 802.1ad. Netlink attributes now look like this:

[PATCH net-next V10 2/4] General check for vlan ethernet types

2015-06-02 Thread Thomas F Herbert
This patch adds a function to check for vlan ethernet types. There is a use case in openvswitch and it should be useful elsewhere. Signed-off-by: Thomas F Herbert thomasfherb...@gmail.com --- include/linux/if_vlan.h | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH net-next V10 4/4] 8021AD: Flow key parsing and netlink attributes.

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad to netlink parsing and flow conversation. Uses double nested encap attributes to represent double tagged vlan. Signed-off-by: Thomas F Herbert thomasfherb...@gmail.com --- net/openvswitch/flow_netlink.c | 186 ++--- 1 file changed, 157

[PATCH net-next V10 3/4] 802.1AD: Flow handling, actions and vlan parsing

2015-06-02 Thread Thomas F Herbert
Add support for 802.1ad including the ability to push and pop double tagged vlans. Signed-off-by: Thomas F Herbert thomasfherb...@gmail.com --- net/openvswitch/flow.c | 82 ++ net/openvswitch/flow.h | 3 ++ 2 files changed, 73 insertions(+), 12

Re: [RFC net-next 1/3] net: infra for per-nexthop encap data

2015-06-02 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: Having to add a new interface to apply encap onto a packet is a mechanism that works well today, allowing the setup of the encap to be done separately from the routes out of them, meaning that routing protocols and other user-space apps don't need

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread roopa
On 6/2/15, 11:30 AM, Eric W. Biederman wrote: roopa ro...@cumulusnetworks.com writes: On 6/1/15, 9:46 AM, Robert Shearman wrote: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread roopa
On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its per-nexthop encapsulation data as a stack

Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock structure to ready for 2038

2015-06-02 Thread Thomas Gleixner
On Mon, 1 Jun 2015, Baolin Wang wrote: This patch series changes the 32-bit time types (timespec/itimerspec) to the 64-bit types (timespec64/itimerspec64), since 32-bit time types will break in the year 2038. That's only true for 32bit systems. All in all the patch series looks rather

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Robert Shearman
On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward them out. The traditional approach of setting

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP packets and impose an MPLS encap and forward

Re: ray_cs: Change 1 to true for bool type variable.

2015-06-02 Thread Kalle Valo
The variable translate is bool type. So assigning true instead of 1. Signed-off-by: Shailendra Verma shailendra.capric...@gmail.com Thanks, applied to wireless-drivers-next.git. Kalle Valo -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

[PATCH v5 1/2] Renesas Ethernet AVB driver proper

2015-06-02 Thread Sergei Shtylyov
Ethernet AVB includes an Gigabit Ethernet controller (E-MAC) that is basically compatible with SuperH Gigabit Ethernet E-MAC. Ethernet AVB has a dedicated direct memory access controller (AVB-DMAC) that is a new design compared to the SuperH E-DMAC. The AVB-DMAC is compliant with 3 standards

[PATCH v5 2/2] Renesas Ethernet AVB PTP clock driver

2015-06-02 Thread Sergei Shtylyov
Ethernet AVB device includes the gPTP timer, so we can implement a PTP clock driver. We're doing that in a separate file, with the main Ethernet driver calling the PTP driver's [de]initialization and interrupt handler functions. Unfortunately, the clock seems tightly coupled with the AVB-DMAC,

[PATCH net-next 3/3] net/mlx4_core: fix typo in mlx4_set_vf_mac

2015-06-02 Thread clsoto
From: Carol Soto cls...@linux.vnet.ibm.com fix typo in mlx4_set_vf_mac Acked-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com --- drivers/net/ethernet/mellanox/mlx4/cmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH net-next 2/3] net/mlx4_core: need to call close fw if alloc icm is called twice

2015-06-02 Thread clsoto
From: Carol Soto cls...@linux.vnet.ibm.com If mlx4_enable_sriov is called by adapter without this feature MLX4_DEV_CAP_FLAG2_SYS_EQS then during this path the function alloc icm is called twice without freeing the structures from the first time. Acked-by: Or Gerlitz ogerl...@mellanox.com

[PATCH net-next 1/3] net/mlx4_core: double free of dev_vfs

2015-06-02 Thread clsoto
From: Carol L Soto cls...@linux.vnet.ibm.com If user loads mlx4_core with num_vfs greater than supported then variable dev-dev_vfs is freed 2 times after unloading the driver. Acked-by: Or Gerlitz ogerl...@mellanox.com Signed-off-by: Carol L Soto cls...@linux.vnet.ibm.com ---

Re: [PATCH net-next v3 00/15] sfc: ndo_get_phys_port_id, vadaptor stats and PF unload when Vf's assigned to guest

2015-06-02 Thread David Miller
From: Shradha Shah ss...@solarflare.com Date: Tue, 2 Jun 2015 11:36:00 +0100 This is the third and last instalment of SRIOV for EF10 patches. This patch set includes implementation of ndo_get_phys_port_id and changes to the MAC statistics code in order to support vadaptor statistics. It

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Robert Shearman
On 02/06/15 19:57, roopa wrote: On 6/2/15, 9:33 AM, Robert Shearman wrote: On 02/06/15 17:15, roopa wrote: On 6/1/15, 9:46 AM, Robert Shearman wrote: Allow creating an mpls device for the purposes of encapsulating IP packets with: ip link add type ipmpls This device defines its

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: As far as I can tell, enabling IP_RECVERR causes the presence of a queued error to cause recvmsg, etc to return an error (once). It's worse, though: a new error can be queued asynchronously at any time, this setting sk_err to a nonzero

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: My proposal would be to make the error conversion lazy: Keeping duplicate data is not a good idea in general: So we shouldn't use sk-sk_err if

Re: [RFC 2/9] net: dsa: add basic support for VLAN operations

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:42 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch adds the glue between DSA and switchdev to add and delete SWITCHDEV_OBJ_PORT_VLAN objects. This will allow the DSA switch drivers implementing the

Re: [PATCH v2 net-next] vlan: Add GRO support for non hardware accelerated vlan

2015-06-02 Thread Simon Horman
On Mon, Jun 01, 2015 at 02:56:25PM -0700, David Miller wrote: From: Eric Dumazet eric.duma...@gmail.com Date: Mon, 01 Jun 2015 07:12:37 -0700 Can we ensure offload_base contains a sensible order of expected types ? This seemed easy enough to kill, so I pushed the following into

Re: [RFC 0/3] DSA and Marvell 88E6352 802.1q support

2015-06-02 Thread Vivien Didelot
Hi Scott, On Jun 2, 2015, at 2:18 AM, Scott Feldman sfel...@gmail.com wrote: On Mon, Jun 1, 2015 at 5:18 PM, Vivien Didelot vivien.dide...@savoirfairelinux.com wrote: On May 29, 2015, at 1:02 AM, Scott Feldman sfel...@gmail.com wrote: On Thu, May 28, 2015 at 2:37 PM, Vivien Didelot

[PATCH V2 2/2] pci: Add VPD quirk for Intel Ethernet devices

2015-06-02 Thread Mark D Rustad
This quirk sets the PCI_DEV_FLAGS_VPD_REF_F0 flag on all Intel Ethernet device functions other than function 0. Signed-off-by: Mark Rustad mark.d.rus...@intel.com --- drivers/pci/quirks.c |9 + 1 file changed, 9 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 5:33 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Wed, Jun 3, 2015, at 02:03, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: My proposal would be to make the error conversion lazy:

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:50 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 23:42, Hannes Frederic Sowa wrote: On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Vivien Didelot
Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy in the monitor control register, since this feature is not needed.

Re: [PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu ro...@cumulusnetworks.com writes: From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

2015-06-02 Thread Guenter Roeck
On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com --- drivers/net/dsa/mv88e6xxx.c | 14

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Thomas Graf tg...@suug.ch writes: On 06/02/15 at 01:26pm, Eric W. Biederman wrote: What we really want here is xfrm-lite. By lite I mean the tunnel selection criteria is simple enough that it fits into the normal routing table instead of having to do weird flow based magic that is rarely

Re: [RFC 8/9] net: dsa: mv88e6352: set port 802.1Q mode to Secure

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:31 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit changes the 802.1Q mode of each port from Disabled to Secure. This enables the VLAN support, by checking the VTU entries on ingress. Signed-off-by:

[PATCH V2 0/2] pci: Provide a flag to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Many multi-function devices provide shared registers in extended config space for accessing VPD. The behavior of these registers means that the state must be tracked and access locked correctly for accesses not to hang or worse. One way to meet these needs is to always perform the accesses through

[PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Mark D Rustad
Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on function 0 or there will be an infinite

[PATCH net iproute2 v4] mpls: always set type RTN_UNICAST and scope RT_SCOPE_UNIVERSE for route add/deletes

2015-06-02 Thread Roopa Prabhu
From: Roopa Prabhu ro...@cumulusnetworks.com This patch fixes incorrect -EINVAL errors due to invalid scope and type during mpls route deletes. $ip -f mpls route add 100 as 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route show 100 as to 200 via inet 10.1.1.2 dev swp1 $ip -f mpls route del 100

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:24 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit disables SA learning and refreshing for the CPU port. Hi Vivien, This patch also seems to be unrelated to the rest of the series. Can you add an

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: As far as I can tell, enabling IP_RECVERR causes the presence of a queued error to cause recvmsg, etc to return an error (once). It's worse, though: a

Re: [net-next v2] ipv4: inet_bind: check the addr_len first

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 17:13, Denis Kirjanov wrote: On 6/2/15, Hannes Frederic Sowa han...@stressinduktion.org wrote: Hello, On Tue, Jun 2, 2015, at 14:21, Denis Kirjanov wrote: Perform the address length check first, before calling the proto specific bind() function Can you give

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: As far as I can tell, enabling IP_RECVERR causes the presence of a queued error to cause

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Robert Shearman
On 02/06/15 22:10, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: In order to be able to function as a Label Edge Router in an MPLS network, it is necessary to be able to take IP

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Eric W. Biederman
Thomas Graf tg...@suug.ch writes: On 06/02/15 at 01:26pm, Eric W. Biederman wrote: What we really want here is xfrm-lite. By lite I mean the tunnel selection criteria is simple enough that it fits into the normal routing table instead of having to do weird flow based magic that is rarely

Re: [RFC net-next 3/3] mpls: new ipmpls device for encapsulating IP packets as mpls

2015-06-02 Thread Thomas Graf
On 06/02/15 at 01:26pm, Eric W. Biederman wrote: What we really want here is xfrm-lite. By lite I mean the tunnel selection criteria is simple enough that it fits into the normal routing table instead of having to do weird flow based magic that is rarely needed. I believe what we want are

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Thomas Graf
On 06/02/15 at 02:28pm, Robert Shearman wrote: Nesting attributes inside the RTA_ENCAP blob should be supported by the patch series today. Something like this: Sure. I'm not seeing such a construct for the MPLS case yet. I'm happy to rebase my patches on top of your nexthop implementation. It

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread roopa
On 6/2/15, 2:13 PM, Eric W. Biederman wrote: So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in iproute. I assumed that meant it was not being touched and it was taking a default value of

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Eric W. Biederman
roopa ro...@cumulusnetworks.com writes: On 6/2/15, 2:13 PM, Eric W. Biederman wrote: So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in iproute. I assumed that meant it was not being

Re: [PATCH net v3 2/2] mpls: fix mpls route deletes to not check for route scope

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu ro...@cumulusnetworks.com writes: From: Roopa Prabhu ro...@cumulusnetworks.com Ignore scope for route del messages So I just stopped and looked at what is happening. When you originally reported this you said (or at least I understood) that rtm_scope was not being set in

Re: [PATCH net iproute2 v3 1/2] mpls: always set type as RTN_UNICAST for route add/deletes

2015-06-02 Thread Eric W. Biederman
Roopa Prabhu ro...@cumulusnetworks.com writes: From: Roopa Prabhu ro...@cumulusnetworks.com Kernel expects type RTN_UNICAST for mpls route/dels There almost a bug in this patch. You test req.r.rtm_family just before the default case of AF_UNSPEC is set to AF_INET. Which should not affect

[PATCH iproute2 -next] tc: {f,m}_bpf: allow to retrieve uds path from env

2015-06-02 Thread Daniel Borkmann
Allow to retrieve uds path from the environment, facilitates also dealing with export a bit. Signed-off-by: Daniel Borkmann dan...@iogearbox.net --- tc/f_bpf.c | 6 -- tc/m_bpf.c | 6 -- tc/tc_bpf.h | 2 ++ 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/tc/f_bpf.c

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Andy Lutomirski
On Tue, Jun 2, 2015 at 2:42 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: As far as

Re: How do I avoid recvmsg races with IP_RECVERR?

2015-06-02 Thread Hannes Frederic Sowa
On Tue, Jun 2, 2015, at 23:42, Hannes Frederic Sowa wrote: On Tue, Jun 2, 2015, at 23:33, Andy Lutomirski wrote: On Tue, Jun 2, 2015 at 2:17 PM, Hannes Frederic Sowa han...@stressinduktion.org wrote: On Tue, Jun 2, 2015, at 21:40, Andy Lutomirski wrote: [...] I do this already,

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread nolan
On 06/02/2015 12:44 AM, Scott Feldman wrote: That brings up an interesting point about having multiple bridges with the same vlan configured. I struggled with that problem with rocker also and I don't have an answer other than don't do that. Or, better put, if you have multiple bridge on the

[PATCH net-next] bpf: introduce bpf_clone_redirect() helper

2015-06-02 Thread Alexei Starovoitov
Allow eBPF programs attached to classifier/actions to call bpf_clone_redirect(skb, ifindex, flags) helper which will mirror or redirect the packet by dynamic ifindex selection from within the program to a target device either at ingress or at egress. Can be used for various scenarios, for example,

Re: [RFC net-next 0/3] IP imposition of per-nh MPLS encap

2015-06-02 Thread Eric W. Biederman
Robert Shearman rshea...@brocade.com writes: On 02/06/15 22:10, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: On 02/06/15 19:11, Eric W. Biederman wrote: Robert Shearman rshea...@brocade.com writes: In order to be able to function as a Label Edge Router in an MPLS

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Guenter Roeck
On 06/02/2015 07:31 PM, Chris Healy wrote: Guenter, That's a very valid concern. I have a configuration with a 6352 controlled by a low end ARM core with a 100mbps connection on the CPU port. This switch needs to support passing multicast streams that are more than 100mbps on GigE links.

Re: [RFC 3/9] net: dsa: mv88e6xxx: add support for VTU ops

2015-06-02 Thread Vivien Didelot
Guenter, On Jun 2, 2015, at 2:50 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: +/* Bringing an interface up adds it to the VLAN 0. Ignore this. */ +if (!vid) +return 0; + Me puzzled ;-). I brought this and the fid question up

Re: [RFC 6/9] net: dsa: mv88e6352: allow egress of unknown multicast

2015-06-02 Thread Vivien Didelot
Hi Guenter, On Jun 2, 2015, at 10:20 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This patch disables egress of unknown unicast destination addresses. Hi Vivien, seems to me this patch is unrelated to the rest of the series. Not sure if we

Re: [RFC 7/9] net: dsa: mv88e6352: lock CPU port from learning addresses

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:06:15PM -0400, Vivien Didelot wrote: Hi Guenter, On Jun 2, 2015, at 10:24 AM, Guenter Roeck li...@roeck-us.net wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: This commit disables SA learning and refreshing for the CPU port. Hi Vivien, This patch

Re: [RFC 5/9] net: dsa: mv88e6352: disable mirroring

2015-06-02 Thread Guenter Roeck
On Tue, Jun 02, 2015 at 09:12:30PM -0400, Vivien Didelot wrote: Hi Guenter, Andrew, On Jun 2, 2015, at 10:53 AM, Andrew Lunn and...@lunn.ch wrote: On Tue, Jun 02, 2015 at 07:16:10AM -0700, Guenter Roeck wrote: On 06/01/2015 06:27 PM, Vivien Didelot wrote: Disable the mirroring policy in

Re: [Intel-wired-lan] [PATCH V2 1/2] pci: Add dev_flags bit to access VPD through function 0

2015-06-02 Thread Alexander Duyck
On 06/02/2015 05:10 PM, Mark D Rustad wrote: Add a dev_flags bit, PCI_DEV_FLAGS_VPD_REF_F0, to access VPD through function 0 to provide VPD access on other functions. This solves concurrent access problems on many devices without changing the attributes exposed in sysfs. Never set this bit on

[PATCH net-next] net: change fib behavior based on interface link status

2015-06-02 Thread Andy Gospodarek
This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in

  1   2   >