Re: [Codel] [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Rick Jones
On 03/17/2016 10:00 AM, Dave Taht wrote: netperf's udp_rr is not how much traffic conventionally behaves. It doesn't do tcp slow start or congestion control in particular... Nor would one expect it to need to, unless one were using "burst mode" to have more than one transaction inflight at

我在这里等你

2016-03-19 Thread 我在这里等你
你的老朋友邀你来Q群:343257759

Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

2016-03-19 Thread Sergei Shtylyov
On 3/17/2016 12:41 PM, Alexey Brodkin wrote: Following commit broke DW GMAC functionality on AXS10x boards: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763 Note that scripts/checkpatch.pl now enforces certain format for

Re: [BUG] bcmgenet tx path

2016-03-19 Thread Florian Fainelli
Hi Eric, On 16/03/16 07:18, Eric Dumazet wrote: > Hi Florian > > I was looking at drivers/net/ethernet/broadcom/genet/bcmgenet.c > and found TX completion (__bcmgenet_tx_reclaim()) was freeing skb before > frags were actually dma unmapped. > > > Are you sure this is OK ? bnx2 and bnx2x

Re: [PATCH net] esp: Fix crash observed during device unregistration and decryption

2016-03-19 Thread Steffen Klassert
On Wed, Mar 16, 2016 at 06:25:26PM -0600, Subash Abhinov Kasiviswanathan wrote: > A crash is observed when a decrypted packet is processed in receive path. > get_rps_cpus() tries to dereference the skb->dev fields but it appears > that the device is freed from the poison pattern. > > []

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-19 Thread Linus Torvalds
On Tue, Mar 15, 2016 at 5:58 PM, Stephen Rothwell wrote: > > I fixed it up (see below) and can carry the fix as necessary (no action > is required). Side note: can you change this wording for your manual merge script? Last merge window (or was it the one before it?) we had

Re: [PATCHv2] vsock: Fix blocking ops call in prepare_to_wait

2016-03-19 Thread David Miller
From: Laura Abbott Date: Mon, 14 Mar 2016 13:07:06 -0700 > On 03/14/2016 12:24 PM, David Miller wrote: >> From: Claudio Imbrenda >> Date: Fri, 11 Mar 2016 13:39:23 +0100 >> >>> I think I found a problem with the patch submitted by Laura Abbott

8:25 arriving 9:07, if I catch it....

2016-03-19 Thread Dave Taht
Dave Täht Let's go make home routers and wifi faster! With better software! https://www.gofundme.com/savewifi

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Joe Perches
On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > Fix order of mac80211_rx_flags description to match the enum. > > Signed-off-by: Luis de Bethencourt > --- > Hi, > > I want ahead and fixed the order of the descriptions. checkpatch.pl was giving > a warning

[iproute PATCH 3/8] man: tc-csum.8: Add an example

2016-03-19 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/tc-csum.8 | 15 +++ 1 file changed, 15 insertions(+) diff --git a/man/man8/tc-csum.8 b/man/man8/tc-csum.8 index 9d00aae346af0..3a64c82f09ba8 100644 --- a/man/man8/tc-csum.8 +++ b/man/man8/tc-csum.8 @@ -49,6 +49,21 @@ UDPLite

Re: [v6, 3/5] dt: move guts devicetree doc out of powerpc directory

2016-03-19 Thread Leo Li
On Thu, Mar 17, 2016 at 12:57 PM, Rob Herring wrote: > On Thu, Mar 17, 2016 at 12:11 PM, Arnd Bergmann wrote: >> On Thursday 17 March 2016 12:06:40 Rob Herring wrote: >>> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt >>> >

Re: [PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Venkatesh Srinivas
On Thu, Mar 17, 2016 at 7:44 AM, Paolo Abeni wrote: > > This gives small but noticeable rx performance improvement (2-3%) > and will allow exploiting future napi improvement. > > Signed-off-by: Paolo Abeni > --- Worked in my tests, though the performance

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Joe Stringer
On 17 March 2016 at 02:56, Arnd Bergmann wrote: > On Wednesday 16 March 2016 14:25:36 Pablo Neira Ayuso wrote: >> Not related with this patch, just a side note/recommendation. >> >> I understand this code just got into tree, and that this needs a bit >> work/iterations but this

Re: [PATCH] iwlwifi: dvm: convert create_singlethread_workqueue() to alloc_workqueue()

2016-03-19 Thread Tejun Heo
Hello, On Thu, Mar 17, 2016 at 01:43:22PM +0100, Johannes Berg wrote: > On Thu, 2016-03-17 at 20:37 +0800, Eva Rachel Retuya wrote: > > Use alloc_workqueue() to allocate the workqueue instead of > > create_singlethread_workqueue() since the latter is deprecated and is > > scheduled for removal. >

Re: [RFC v2 -next 2/2] virtio_net: Read the advised MTU

2016-03-19 Thread Aaron Conole
Sergei Shtylyov writes: > Hello. > > On 3/16/2016 12:04 AM, Aaron Conole wrote: > >> This patch checks the feature bit for the VIRTIO_NET_F_MTU feature. If it >> exists, read the advised MTU and use it. >> >> No proper error handling is provided for the case

Re: [PATCH net-next 2/6] bridge: simplify the forward_delay_store by calling store_bridge_parm

2016-03-19 Thread Nikolay Aleksandrov
On 03/16/2016 02:34 PM, Xin Long wrote: > There are some repetitive codes in forward_delay_store, we can remove > them by calling store_bridge_parm. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 27 ++- > 1 file changed, 10

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Dave Taht
On Thu, Mar 17, 2016 at 1:55 AM, Michal Kazior wrote: > I suspect the BK/BE latency difference has to do with the fact that > there's bulk traffic going on BE queues (this isn't reflected > explicitly in the plots). The `bursts` flent test includes short > bursts of

Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts

2016-03-19 Thread Vineet Gupta
On Thursday 17 March 2016 05:29 PM, Sergei Shtylyov wrote: > Hello. > > On 3/17/2016 2:41 PM, Vineet Gupta wrote: > > Following commit broke DW GMAC functionality on AXS10x boards: >

Re: [PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-19 Thread Mason
On 18/03/2016 21:11, Uwe Kleine-König wrote: > Hello, > > On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote: > >> On 18/03/2016 20:12, Uwe Kleine-König wrote: >> >>> On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: >>> What would you think of making

[PATCH v5 3/4] net: ethernet: stmmac: add support of Synopsys 3.50a MAC IP

2016-03-19 Thread Alexandre TORGUE
Adds support of Synopsys 3.50a MAC IP in stmmac driver. Acked-by: Giuseppe Cavallaro Tested-by: Maxime Coquelin Signed-off-by: Alexandre TORGUE diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
On 18/03/16 16:49, Johannes Berg wrote: > On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: >> Fix order of mac80211_rx_flags description to match the enum. >> >> Signed-off-by: Luis de Bethencourt >> --- >> Hi, >> >> I want ahead and fixed the order of the

Re: [PATCH (net-next.git) 0/2] STMMAC: MDIO settings

2016-03-19 Thread David Miller
Don't _ever_ send the same two sets of patches targetting net and net-next at the same time. Especially right now, as 'net' is basically frozen, and 'net-next' is closed for new features and is only for last minute bug fixes before I send a merge window pull request to Linus. I'm tossing both

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
On Wed, Mar 16, 2016 at 04:59:23PM +0100, Yegor Yefremov wrote: > This patch breaks my am335x based board, where one of the CPSW slaves > is connected to IP175D switch chip via RMII interface. Since this > patch packet reception is not working. Hi Yegor Which phy is causing the problem? A PHY

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-19 Thread Stephen Rothwell
Hi Linus, On Wed, 16 Mar 2016 10:18:33 -0700 Linus Torvalds wrote: > > On Tue, Mar 15, 2016 at 5:58 PM, Stephen Rothwell > wrote: > > > > I fixed it up (see below) and can carry the fix as necessary (no action > > is required). > > Side

[RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread Tejun Heo
Hello, Years ago, workqueue got reimplemented to use common worker pools across different workqueues and a new set of more expressive workqueue creation APIs, alloc_*workqueue() were introduced. The old create_*workqueue() became simple wrappers around alloc_*workqueue() with the most

Re: [PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-19 Thread Chen-Yu Tsai
Hi, On Fri, Mar 18, 2016 at 11:37 PM, Alexandre TORGUE wrote: > Signed-off-by: Alexandre TORGUE > > diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt > b/Documentation/devicetree/bindings/net/stm32-dwmac.txt > new file

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Dave Taht
it is helpful to name the test files coherently in the flent tests, in addition to using a directory structure and timestamp. It makes doing comparison plots in data->add-other-open-data-files simpler. "-t patched-mac-300mbps", for example. Also netperf from svn (maybe 2.7, don't remember) will

[iproute PATCH 7/8] tc/m_vlan.c: mention CONTROL option in help text

2016-03-19 Thread Phil Sutter
Signed-off-by: Phil Sutter --- tc/m_vlan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tc/m_vlan.c b/tc/m_vlan.c index 32db5ed5b107b..2512b4f967108 100644 --- a/tc/m_vlan.c +++ b/tc/m_vlan.c @@ -22,9 +22,10 @@ static void explain(void) {

[PATCH net 3/3] tunnels: Remove encapsulation offloads on decap.

2016-03-19 Thread Jesse Gross
If a packet is either locally encapsulated or processed through GRO it is marked with the offloads that it requires. However, when it is decapsulated these tunnel offload indications are not removed. This means that if we receive an encapsulated TCP packet, aggregate it with GRO, decapsulate, and

Re: [PATCH v2] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread David Miller
From: Arnd Bergmann Date: Fri, 18 Mar 2016 14:33:45 +0100 > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > >

Re: [RFD] workqueue: WQ_MEM_RECLAIM usage in network drivers

2016-03-19 Thread Tejun Heo
Hello, Jeff. On Thu, Mar 17, 2016 at 09:32:16PM -0400, Jeff Layton wrote: > > * Are network devices expected to be able to serve as a part of > > storage stack which is depended upon for memory reclamation? > > I think they should be. Cached NFS pages can consume a lot of memory, > and

Re: [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static

2016-03-19 Thread David Miller
From: kbuild test robot Date: Sat, 19 Mar 2016 00:54:50 +0800 > Signed-off-by: Fengguang Wu Looks good, applied, thanks.

Re: [PATCH net-next v3 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-19 Thread Sowmini Varadhan
On (03/16/16 12:26), Hannes Frederic Sowa wrote: > > My hope was actually that by using the ->data pointer in netns you > don't need to provide the two functions, just simply use something > like the following for both cases. Ok, it would probably be less hacky to do it as you suggest. > Do I

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Joe Perches
On Fri, 2016-03-18 at 17:40 +, Luis de Bethencourt wrote: > On 18/03/16 17:29, Joe Perches wrote: > > On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: > > > Fix order of mac80211_rx_flags description to match the enum. [] > > > I want ahead and fixed the order of the descriptions.

[PATCH net-next] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Paolo Abeni
This gives small but noticeable rx performance improvement (2-3%) and will allow exploiting future napi improvement. Signed-off-by: Paolo Abeni --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c

[PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
Fix order of mac80211_rx_flags description to match the enum. Signed-off-by: Luis de Bethencourt --- Hi, I want ahead and fixed the order of the descriptions. checkpatch.pl was giving a warning to my previous patch and I had a hunch it was because the wrong order breaks

Re: [PATCH] net: phy: at803x: Add support to control PHY LEDs

2016-03-19 Thread Florian Fainelli
On 17/03/16 07:50, Andrew Lunn wrote: > On Thu, Mar 17, 2016 at 02:59:07PM +0100, Vishal Thanki wrote: >> The LEDs can be turned on and off by a sysfs interface >> now. Write 0 to "led_enable" file to turn off the LEDs >> and write 1 to turn on. The support is experimental >> and can be enabled by

Re: [PATCH] qeth: Default to allow promiscuous mode

2016-03-19 Thread Evgeny Cherkashin
Hello Alexander, -Alexander Graf wrote: - send it explicitly if that makes it move obvious, sure. > >> 3. The patch should probably go via the -networking maillist. > >Ah, get_maintainers.pl didn't list it. You may want to send a patch >for >the MAINTAINERS file here :).

[PATCH] rtlwifi: fix gcc-6 indentation warning

2016-03-19 Thread Arnd Bergmann
The rtl8821ae_dm_txpower_tracking_callback_thermalmeter function contains a call to RT_TRACE() that is indented in a misleading way, as pointed out by a gcc-6 warning: drivers/net/wireless/realtek/rtlwifi/rtl8821ae/dm.c: In function 'rtl8821ae_dm_txpower_tracking_callback_thermalmeter':

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-19 Thread Doug Ledford
On 3/16/2016 1:18 PM, Linus Torvalds wrote: > On Tue, Mar 15, 2016 at 5:58 PM, Stephen Rothwell > wrote: >> >> I fixed it up (see below) and can carry the fix as necessary (no action >> is required). > > Side note: can you change this wording for your manual merge script?

Re: [PATCH net v2] ppp: ensure file->private_data can't be overridden

2016-03-19 Thread David Miller
From: Guillaume Nault Date: Mon, 14 Mar 2016 21:17:16 +0100 > Locking ppp_mutex must be done before dereferencing file->private_data, > otherwise it could be modified before ppp_unattached_ioctl() takes the > lock. This could lead ppp_unattached_ioctl() to override

Re: Regression: netlink fail (triggered by iw) removes extra wlan (phy) interface

2016-03-19 Thread Cong Wang
On Thu, Feb 25, 2016 at 5:22 AM, Rafał Miłecki wrote: > Hi, > > After updating kernel in OpenWrt from 4.1.6 to 4.1.10 I noticed that > if "iw" command fails (which happens very rarely) my wlan0-1 interface > disappears. To trigger this problem easily I'm using this trivial >

Re: [PATCH net-next] bnx2x: don't wait for Tx completion on recovery

2016-03-19 Thread David Miller
From: Yuval Mintz Date: Sun, 13 Mar 2016 21:21:48 +0200 > When driver has hit a parity event, HW can no longer write to host memory. > As a result, Tx completions cannot be written to the host SB memory, and > waiting for Tx completions eventually timeout. > As driver is

[PATCH] xfrm: don't segment UFO packets

2016-03-19 Thread Jiri Bohac
xfrm_output() will segment GSO packets, including UDP (UFO) packets. this is wrong per RFC4303, section 3.3.4. Fragmentation: If necessary, fragmentation is performed after ESP processing within an IPsec implementation. Thus, transport mode ESP is applied only to whole IP datagrams

[PATCH net-next v4 1/2] RDS: TCP: Add sysctl tunables for sndbuf/rcvbuf on rds-tcp socket

2016-03-19 Thread Sowmini Varadhan
Add per-net sysctl tunables to set the size of sndbuf and rcvbuf on the kernel tcp socket. The tunables are added at /proc/sys/net/rds/tcp/rds_tcp_sndbuf and /proc/sys/net/rds/tcp/rds_tcp_rcvbuf. These values must be set before accept() or connect(), and there may be an arbitrary number of

Re: [ovs-dev] [PATCH] openvswitch: call only into reachable nf-nat code

2016-03-19 Thread Joe Stringer
On 17 March 2016 at 01:47, Arnd Bergmann wrote: > The openvswitch code has gained support for calling into the > nf-nat-ipv4/ipv6 modules, however those can be loadable modules > in a configuration in which openvswitch is built-in, leading > to link errors: > > net/built-in.o: In

[PATCH v2 ethtool 1/2] Add IPv6 support to NFC

2016-03-19 Thread Edward Cree
Signed-off-by: Edward Cree --- ethtool.c | 21 + rxclass.c | 267 ++ 2 files changed, 274 insertions(+), 14 deletions(-) diff --git a/ethtool.c b/ethtool.c index 0cd0d4f..b476dcc 100644 --- a/ethtool.c +++

Re: [PATCH] mac80211: add doc for RX_FLAG_DUP_VALIDATED flag

2016-03-19 Thread Luis de Bethencourt
On 18/03/16 16:09, Luis de Bethencourt wrote: > Add documentation for the flag for duplication check. > > Fixes the following warning when running make htmldocs: > warning: Enum value 'RX_FLAG_DUP_VALIDATED' not described in enum > 'mac80211_rx_flags' > > Signed-off-by: Luis de Bethencourt

AP firmware for TI wl1251 wifi chip (wl1251-fw-ap.bin)

2016-03-19 Thread Pali Rohár
Hi! In linux-firmware repository [1] is missing AP firmware for TI wl1251 chip. There is only STA firmware wl1251-fw.bin which supports managed and ad-hoc modes. For other TI wilink chips there are -ap.bin firmware files (wl1271-fw-ap.bin and wl128x-fw-ap.bin) which support AP mode. But for

Re: [net] openvswitch: Allow deferred action fifo to expand during run time

2016-03-19 Thread David Miller
From: Andy Zhou Date: Thu, 17 Mar 2016 21:32:13 -0700 > Current openvswitch implementation allows up to 10 recirculation actions > for each packet. This limit was sufficient for most use cases in the > past, but with more new features, such as supporting connection > tracking, and

Re: [PATCH 2/5] net: macb: Fix coding style warnings

2016-03-19 Thread Nicolas Ferre
Le 14/03/2016 21:53, Michal Simek a écrit : > On 13.3.2016 20:10, Moritz Fischer wrote: >> This commit takes care of the coding style warnings >> that are mostly due to a different comment style and >> lines over 80 chars, as well as a dangling else. >> >> Signed-off-by: Moritz Fischer

[PATCH] mac80211: remove description of dropped member

2016-03-19 Thread Luis de Bethencourt
Commit 976bd9efdae6 ("mac80211: move beacon_loss_count into ifmgd") removed the member from the sta_info struct but the description stayed lingering. Remove it. Signed-off-by: Luis de Bethencourt --- Hi, A second patch fixing a warning in make htmldocs. Thanks :) Luis

[net-next v2] virtio_net: replace netdev_alloc_skb_ip_align() with napi_alloc_skb()

2016-03-19 Thread Paolo Abeni
This gives small but noticeable rx performance improvement (2-3%) and will allow exploiting future napi improvement. Signed-off-by: Paolo Abeni -- v2: replace also netdev_alloc_skb_ip_align() invocation in add_recvbuf_small(), suggested by Venkatesh Srinivas ---

Re: [PATCH] rtlwifi: btcoexist: Convert BTC_PRINTK to btc__dbg

2016-03-19 Thread Joe Perches
On Thu, 2016-03-17 at 21:54 -0500, Larry Finger wrote: > On 03/17/2016 07:00 PM, Joe Perches wrote: > > Use a more common logging style. [ 300K+ quote without comment ] > Joe, Hi Larry. > The patch looks good, but it has conflict in  >

Re: [v6, 2/5] soc: fsl: add GUTS driver for QorIQ platforms

2016-03-19 Thread Scott Wood
On 03/09/2016 04:18 AM, Yangbo Lu wrote: > +#ifdef CONFIG_FSL_GUTS > +u32 fsl_guts_get_svr(void); > +int fsl_guts_init(void); > +#endif Don't ifdef prototypes (when not providing a stub alternative). -Scott

[PATCH v5 2/4] Documentation: Bindings: Add STM32 DWMAC glue

2016-03-19 Thread Alexandre TORGUE
Signed-off-by: Alexandre TORGUE diff --git a/Documentation/devicetree/bindings/net/stm32-dwmac.txt b/Documentation/devicetree/bindings/net/stm32-dwmac.txt new file mode 100644 index 000..ada2aa4 --- /dev/null +++

Re: [net-next 1/2] bonding: remove duplicate set of flag IFF_MULTICAST

2016-03-19 Thread 张胜举
> On 03/16/2016 10:59 AM, Zhang Shengju wrote: > > Remove unnecessary set of flag IFF_MULTICAST, since ether_setup > > already does this. > > > > Signed-off-by: Zhang Shengju > > --- > > drivers/net/bonding/bond_main.c | 2 +- > > 1 file changed, 1

Re: [PATCH 1/5] net: macb: Fix coding style error message

2016-03-19 Thread Nicolas Ferre
Le 13/03/2016 20:10, Moritz Fischer a écrit : > checkpatch.pl gave the following error: > > ERROR: space required before the open parenthesis '(' > + for(; p < end; p++, offset += 4) > > Signed-off-by: Moritz Fischer Acked-by: Nicolas Ferre

Re: [PATCH] mac80211: fix order of flag descriptions

2016-03-19 Thread Luis de Bethencourt
On 18/03/16 17:46, Joe Perches wrote: > On Fri, 2016-03-18 at 17:40 +, Luis de Bethencourt wrote: >> On 18/03/16 17:29, Joe Perches wrote: >>> On Fri, 2016-03-18 at 16:35 +, Luis de Bethencourt wrote: Fix order of mac80211_rx_flags description to match the enum. > [] I want ahead

[PATCH net-next v2 2/4] vxlan: move fdb code to common location in vxlan_xmit

2016-03-19 Thread Jiri Benc
Handle VXLAN_F_COLLECT_METADATA before VXLAN_F_PROXY. The latter does not make sense with the former, as it needs populated fdb which does not happen in metadata mode. After this cleanup, the fdb code in vxlan_xmit is moved to a common location and can be later skipped for VXLAN-GPE which does

Re: [PATCH net-next 1/6] bridge: add rtnl_lock in fdb_flush in br_sysfs_br.c

2016-03-19 Thread Nikolay Aleksandrov
On 03/16/2016 02:34 PM, Xin Long wrote: > In fdb_delete, it will send rtnl msg, so before that, we should > hold rtnl_lock in the function that call it in sysfs. > > Signed-off-by: Xin Long > --- > net/bridge/br_sysfs_br.c | 5 + > 1 file changed, 5 insertions(+) >

Re: [PATCH net-next v4 0/2] RDS: TCP: tunable socket buffer parameters

2016-03-19 Thread David Miller
From: Sowmini Varadhan Date: Wed, 16 Mar 2016 11:38:11 -0700 > Patch 1 uses sysctl to create tunable socket buffer size parameters. > > Patch 2 removes an unuused constant. > > v2: use sysctl > v3: review comments from Santosh Shilimkar, Eric Dumazet > v4: review

[PATCH v1 2/2] netlink: add support for NIC driver ioctls

2016-03-19 Thread David Decotigny
From: David Decotigny This patch removes the requirement that ethtool be tied to the support of a specific L3 protocol (ethtool uses an AF_INET socket today). Signed-off-by: David Decotigny --- net/netlink/af_netlink.c | 10 +- 1 file changed, 9

[iproute PATCH 1/8] doc/tc-filters.tex: Drop overly subjective paragraphs

2016-03-19 Thread Phil Sutter
Cc: Alexei Starovoitov Signed-off-by: Phil Sutter --- doc/tc-filters.tex | 23 --- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/doc/tc-filters.tex b/doc/tc-filters.tex index 59127d6672ed7..54cc0c9920ce2 100644 ---

Re: [PATCH] net: phy: fix PHY_RUNNING in phy_state_machine

2016-03-19 Thread Andrew Lunn
> After changing cpsw_emac0 entry to: > > _emac0 { > phy-mode = "rmii"; > dual_emac_res_vlan = <1>; > fixed-link { > speed = <100>; > full-duplex; > }; > }; > > I've got packets running in both directions. Great. > Now I have

ksoftirqd and network processing

2016-03-19 Thread Anna Fischer
Hi there, I'd like to understand more in detail how ksoftirqd works in combination with Linux kernel networking. I'm doing IPSec processing on my Linux machine (kernel 4.4). On one interface I receive encrypted packets which are decrypted and then routed out plaintext (TCP) via another

[PATCH] sctp: do not leak chunks that are sent to unconfirmed paths

2016-03-19 Thread Marcelo Ricardo Leitner
Currently, if a chunk is scheduled to be sent through a transport that is currently unconfirmed, it will be leaked as it is dequeued from outq and is not re-queued nor freed. As I'm not aware of any situation that may lead to this situation, I'm fixing this by freeing the chunk and also logging a

Re: [PATCH v3] can: rcar_canfd: Add Renesas R-Car CAN FD driver

2016-03-19 Thread Rob Herring
On Tue, Mar 15, 2016 at 09:48:14AM +, Ramesh Shanmugasundaram wrote: > This patch adds support for the CAN FD controller found in Renesas R-Car > SoCs. The controller operates in CAN FD only mode by default. > > CAN FD mode supports both Classical CAN & CAN FD frame formats. The > controller

[PATCH] net: sched: Add description for cpu_bstats argument

2016-03-19 Thread Luis de Bethencourt
Commit 22e0f8b9322c ("net: sched: make bstats per cpu and estimator RCU safe") added the argument cpu_bstats to functions gen_new_estimator and gen_replace_estimator and now the descriptions of these are missing for the documentation. Adding them. Signed-off-by: Luis de Bethencourt

[PATCH] gen_stats.c: Add description for cpu argument

2016-03-19 Thread Luis de Bethencourt
Function gnet_stats_copy_basic is missing the description of the cpu argument in the documentation. Adding it. Signed-off-by: Luis de Bethencourt --- Hi, Noticed this issue when running make htmldocs. I got the following warning: .//net/core/gen_stats.c:155: warning: No

Re: linux-next: manual merge of the rdma tree with the net-next tree

2016-03-19 Thread Stephen Rothwell
Hi Andrew, On Wed, 16 Mar 2016 22:15:03 +0100 Andrew Lunn wrote: > > > How about "This is now fixed as far as linux-next is concerned, but any > > non trivial conflicts should be mentioned to your upstream maintainer > > when your tree is submitted for merging. You may want also

[BUG] bcmgenet tx path

2016-03-19 Thread Eric Dumazet
Hi Florian I was looking at drivers/net/ethernet/broadcom/genet/bcmgenet.c and found TX completion (__bcmgenet_tx_reclaim()) was freeing skb before frags were actually dma unmapped. Are you sure this is OK ? bnx2 and bnx2x actually do the reverse (unmap all frags before freeing skb) A second

Re: [RFC PATCH 6/9] ethtool: Add support for toggling any of the GSO offloads

2016-03-19 Thread Jesse Gross
On Fri, Mar 18, 2016 at 6:42 PM, Ben Hutchings wrote: > On Fri, 2016-03-18 at 17:30 -0700, Alexander Duyck wrote: >> On Fri, Mar 18, 2016 at 5:18 PM, Ben Hutchings wrote: >> > On Fri, 2016-03-18 at 16:25 -0700, Alexander Duyck wrote: >> > >

Re: [RFCv2 0/3] mac80211: implement fq codel

2016-03-19 Thread Bob Copeland
On Wed, Mar 16, 2016 at 11:36:31AM -0700, Dave Taht wrote: > That is the sanest 802.11e queue behavior I have ever seen! (at both > 6 and 300mbit! in the ath10k patched mac test) Out of curiosity, why does BE have larger latency than BK in that chart? I'd have expected the opposite. -- Bob

[PATCH] sctp: keep fragmentation point aligned to word size

2016-03-19 Thread Marcelo Ricardo Leitner
If the user supply a different fragmentation point or if there is a network header that cause it to not be aligned, force it to be aligned. Fragmentation point at a value that is not aligned is not optimal. It causes extra padding to be used and has just no pros. Signed-off-by: Marcelo Ricardo

[PATCH] net: phy: at803x: don't depend on GPIOLIB

2016-03-19 Thread Sebastian Frias
Commit 687908c2b649 ("net: phy: at803x: simplify using devm_gpiod_get_optional and its 4th argument") introduced a dependency on GPIOLIB that was not there before. This commit removes such dependency by checking the return code and comparing it against ENOSYS which is returned when GPIOLIB is not

[PATCH v2] iwlwifi: dvm: use alloc_ordered_workqueue()

2016-03-19 Thread Eva Rachel Retuya
Use alloc_ordered_workqueue() to allocate the workqueue instead of create_singlethread_workqueue() since the latter is deprecated and is scheduled for removal. There are work items doing related operations that shouldn't be swapped when queued in a certain order hence preserve the strict

[iproute PATCH 2/4] tc: pedit: Fix for big-endian systems

2016-03-19 Thread Phil Sutter
This was tricky to get right: - The 'stride' value used for 8 and 16 bit values must behave inverse to the value's intra word offset to work correctly with big-endian data act_pedit is editing. - The 'm' array's values are in host byte order, so they have to be converted as well (and the

RE: [PATCH 2/2] lan78xx: add ndo_get_stats64

2016-03-19 Thread Woojung.Huh
> > + storage->rx_length_errors = (stats.rx_undersize_frame_errors + > > +stats.rx_oversize_frame_errors); > > Parens not needed. > > > + storage->rx_errors = (stats.rx_fcs_errors + > > + stats.rx_alignment_errors + > > +

[PATCH net 2/3] tunnels: Don't apply GRO to multiple layers of encapsulation.

2016-03-19 Thread Jesse Gross
When drivers express support for TSO of encapsulated packets, they only mean that they can do it for one layer of encapsulation. Supporting additional levels would mean updating, at a minimum, more IP length fields and they are unaware of this. No encapsulation device expresses support for

[PATCH net] esp: Fix crash observed during device unregistration and decryption

2016-03-19 Thread Subash Abhinov Kasiviswanathan
A crash is observed when a decrypted packet is processed in receive path. get_rps_cpus() tries to dereference the skb->dev fields but it appears that the device is freed from the poison pattern. [] get_rps_cpu+0x94/0x2f0 [] netif_rx_internal+0x140/0x1cc [] netif_rx+0x74/0x94 []

Re: [PATCH (net-next.git) 0/2] STMMAC: MDIO settings

2016-03-19 Thread David Miller
From: Giuseppe CAVALLARO Date: Thu, 17 Mar 2016 14:10:17 +0100 > On 3/16/2016 11:09 PM, David Miller wrote: >> >> Don't _ever_ send the same two sets of patches targetting net and >> net-next at the same time. > > cover-letter reports the difference between the two

[PATCH ethtool] ethtool.c: fix memory leaks

2016-03-19 Thread Ivan Vecera
Memory allocated at several places is not appropriately freed. Signed-off-by: Ivan Vecera --- ethtool.c | 60 +--- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git a/ethtool.c b/ethtool.c index

[PATCH] sctp: do not update a_rwnd if we are not issuing a sack

2016-03-19 Thread Marcelo Ricardo Leitner
The SACK can be lost pretty much elsewhere, but if its allocation fail, we know we are not sending it, so it is better to revert a_rwnd to its previous value as this may give it a chance to issue a window update later. Signed-off-by: Marcelo Ricardo Leitner ---

[iproute PATCH 4/8] man: tc-mirred.8: Reword man page a bit, add generic mirror example

2016-03-19 Thread Phil Sutter
Signed-off-by: Phil Sutter --- man/man8/tc-mirred.8 | 26 +++--- 1 file changed, 19 insertions(+), 7 deletions(-) diff --git a/man/man8/tc-mirred.8 b/man/man8/tc-mirred.8 index 52d98bc416563..bba96e0e5d8c0 100644 --- a/man/man8/tc-mirred.8 +++

Re: [PATCH] ipv6: Fix the pmtu path for connected UDP socket

2016-03-19 Thread Cong Wang
On Wed, Mar 16, 2016 at 8:34 PM, Eric Dumazet wrote: > On Wed, 2016-03-16 at 22:38 -0400, David Miller wrote: >> From: Eric Dumazet >> Date: Wed, 16 Mar 2016 17:22:07 -0700 >> >> > One of the issue is that IPV6_MTU getsockopt() will not check the

[PATCH v5 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig

2016-03-19 Thread Alexandre TORGUE
Enable basic Ethernet support (IPV4) for stm32 defconfig. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index ec52505..8b8abe0 100644 --- a/arch/arm/configs/stm32_defconfig +++

[net-next RFC 2/4] bindtosubnet: TCP/IPv4 implementation

2016-03-19 Thread Gilberto Bertin
Signed-off-by: Gilberto Bertin --- net/ipv4/inet_connection_sock.c | 20 +++- net/ipv4/inet_hashtables.c | 9 + 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/net/ipv4/inet_connection_sock.c

[iproute PATCH] Use ARRAY_SIZE macro everywhere

2016-03-19 Thread Phil Sutter
This patch was generated by the following semantic patch (a trimmed down version of what is shipped with Linux sources): @@ type T; T[] E; @@ ( - (sizeof(E)/sizeof(*E)) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(E[...])) + ARRAY_SIZE(E) | - (sizeof(E)/sizeof(T)) + ARRAY_SIZE(E) ) The only manual

[PATCH iproute2 1/2] vxlan: Follow kernel defaults for outer UDP checksum.

2016-03-19 Thread Jesse Gross
On recent kernels, UDP checksum computation has become more efficient and the default behavior was changed, however, the ip command overrides this by always specifying a particular behavior. If the user does not specify that UDP checksums should either be computed or not then we don't need to

Re: [PATCH net-next] ethtool: Set cmd field in ETHTOOL_GLINKSETTINGS response to wrong nwords

2016-03-19 Thread Ben Hutchings
On Wed, 2016-03-16 at 19:26 -0400, David Miller wrote: > From: Ben Hutchings > Date: Mon, 14 Mar 2016 01:05:38 + > > > When the ETHTOOL_GLINKSETTINGS implementation finds that userland is > > using the wrong number of words of link mode bitmaps (or is trying to > > find

Re: [PATCH net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br

2016-03-19 Thread Nikolay Aleksandrov
On 03/16/2016 02:34 PM, Xin Long wrote: > Now when we change the attributes of bridge or br_port by netlink, > a relevant netlink notification will be sent, but if we change them > by ioctl or sysfs, no notification will be sent. > > We should ensure that whenever those attributes change

Re: [v6, 3/5] dt: move guts devicetree doc out of powerpc directory

2016-03-19 Thread Rob Herring
On Thu, Mar 17, 2016 at 12:11 PM, Arnd Bergmann wrote: > On Thursday 17 March 2016 12:06:40 Rob Herring wrote: >> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/guts.txt >> > b/Documentation/devicetree/bindings/soc/fsl/guts.txt >> > similarity index 91% >> > rename

Re: [PATCH net-next 0/2] ovs: refresh a flow via netlink

2016-03-19 Thread Jesse Gross
On Wed, Mar 16, 2016 at 8:07 AM, Samuel Gauthier wrote: > This patchset adds a netlink api to refresh an existing flow in > openvswitch. > > When a packet is sent in the openvswitch kernel datapath and no > flow is found, the packet is sent to the ovs-vswitchd daemon, >

Re: [PATCH net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if

2016-03-19 Thread Nikolay Aleksandrov
On 03/16/2016 03:45 PM, Xin Long wrote: > On Wed, Mar 16, 2016 at 10:23 PM, Nikolay Aleksandrov > wrote: >> On 03/16/2016 02:34 PM, Xin Long wrote: >>> Now when we change the attributes of bridge or br_port by netlink, >>> a relevant netlink notification will be sent,

Re: [PATCH][net-next] ipv6: rework the lock in addrconf_permanent_addr

2016-03-19 Thread David Miller
From: roy.qing...@gmail.com Date: Thu, 17 Mar 2016 11:39:15 +0800 > From: Li RongQing > > 1. nothing of idev is changed, so read lock is enough > 2. ifp is changed, so used ifp->lock or cmpxchg to protect it > > Signed-off-by: Li RongQing Sorry

[PATCH net] bonding: fix bond_get_stats()

2016-03-19 Thread Eric Dumazet
From: Eric Dumazet bond_get_stats() can be called from rtnetlink (with RTNL held) or from /proc/net/dev seq handler (with RCU held) The logic added in commit 5f0c5f73e5ef ("bonding: make global bonding stats more reliable") kind of assumed only one cpu could run there. If

[PATCH v1 0/2] basic ioctl support for netlink sockets

2016-03-19 Thread David Decotigny
From: David Decotigny This removes the requirement that ethtool be tied to the support of a specific L3 protocol, also updates a comment. # Patch Set Summary: David Decotigny (2): ethtool: minor doc update netlink: add

Re: [PATCHv2 (net-next.git) 0/2] STMMAC: MDIO settings

2016-03-19 Thread Andreas Färber
Am 16.03.2016 um 13:56 schrieb Giuseppe Cavallaro: > V2: fix runtime problem due to NULL pointer. > > Giuseppe Cavallaro (2): > Revert "stmmac: Fix 'eth0: No PHY found' regression" > stmmac: fix MDIO settings Tested-by: Andreas Färber Thanks, Andreas -- SUSE Linux GmbH,

ip-token: unable to remove a token & multi-token handling & concurrent use w/ EUI64/privacy

2016-03-19 Thread Robin H. Johnson
Hi, Playing around with IPv6 tokens, I ran into a problem: Once you have a token set on an interface, it's impossible to remove it! # ip token set :: dev eth0 RTNETLINK answers: Invalid argument This is a side-effect of rejecting ipv6_addr_any in inet6_set_iftoken. While this gets fixed, I

  1   2   3   4   >