Re: [PATCH 3.2 085/115] veth: don???t modify ip_summed; doing so treats packets with bad checksums as good.

On Sat, Apr 30, 2016 at 03:43:51PM -0700, Ben Greear wrote: > On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: > > Consider: > > > > - App A sends out corrupt packets 50% of the time and discards inbound > > data. (...) > How can you make a generic app C know how to do this? The path could be,

Re: sfc: Please add rss_cpus=hyperthreads support

On Tue, May 5, 2015 at 6:48 AM, Robert Stonehouse wrote: > On 02/05/15 01:03, Andy Lutomirski wrote: >> >> Can you please port the rss_cpus=hyperthreads feature from the >> OpenOnload driver to the upstream driver? The fact that sticking: >> >> options sfc

Re: [PATCH net-next 10/12] net/mlx5e: Create aRFS flow tables

On Fri, Apr 29, 2016 at 01:36:40AM +0300, Saeed Mahameed wrote: > From: Maor Gottlieb > > Create the following four flow tables for aRFS usage: > 1. IPv4 TCP - filtering 4-tuple of IPv4 TCP packets. > 2. IPv6 TCP - filtering 4-tuple of IPv6 TCP packets. > 3. IPv4 UDP -

[PATCH] macb: fix mdiobus_scan() error check

Now mdiobus_scan() returns ERR_PTR(-ENODEV) instead of NULL if the PHY device ID was read as all ones. As this was not an error before, this value should be filtered out now in this driver. Fixes: b74766a0a0fe ("phylib: don't return NULL from get_phy_device()") Signed-off-by: Sergei Shtylyov

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On 04/30/2016 03:01 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:52 PM, Ben Greear wrote: Good point, so if you had: eth0 <-> raw <-> user space-bridge <-> raw <-> vethA <-> veth B <-> userspace-stub <->eth1 and user-space hub enabled this elide flag,

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Sat, Apr 30, 2016 at 1:59 PM, Ben Greear wrote: > > On 04/30/2016 12:54 PM, Tom Herbert wrote: >> >> We've put considerable effort into cleaning up the checksum interface >> to make it as unambiguous as possible, please be very careful to >> follow it. Broken checksum

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Sat, Apr 30, 2016 at 5:52 PM, Ben Greear wrote: >> >> Good point, so if you had: >> >> eth0 <-> raw <-> user space-bridge <-> raw <-> vethA <-> veth B <-> >> userspace-stub <->eth1 >> >> and user-space hub enabled this elide flag, things would work, right? >> Then, it

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On 04/30/2016 02:36 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 5:29 PM, Ben Greear wrote: On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: On 04/30/2016 12:54 PM, Tom

Re: New DSA design for cross-chip operations

On Fri, Apr 29, 2016 at 05:33:44PM -0400, Vivien Didelot wrote: > Hi, > > Here's a proposal for a new design of DSA. It is meant to discuss the > actual state and future implementation of the D (for distributed) in > DSA, which consists of supporting several interconnected switch chips, > exposed

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Sat, Apr 30, 2016 at 5:29 PM, Ben Greear wrote: > > > On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: >> >> On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear >> wrote: >>> >>> >>> >>> On 04/30/2016 12:54 PM, Tom Herbert wrote: We've

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On 04/30/2016 02:13 PM, Vijay Pandurangan wrote: On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: On 04/30/2016 12:54 PM, Tom Herbert wrote: We've put considerable effort into cleaning up the checksum interface to make it as unambiguous as possible, please be

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Sat, Apr 30, 2016 at 4:59 PM, Ben Greear wrote: > > > On 04/30/2016 12:54 PM, Tom Herbert wrote: >> >> We've put considerable effort into cleaning up the checksum interface >> to make it as unambiguous as possible, please be very careful to >> follow it. Broken

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On 04/30/2016 12:54 PM, Tom Herbert wrote: We've put considerable effort into cleaning up the checksum interface to make it as unambiguous as possible, please be very careful to follow it. Broken checksum processing is really hard to detect and debug. CHECKSUM_UNNECESSARY means that some

[PATCH] pxa168_eth: fix mdiobus_scan() error check

Since mdiobus_scan() returns either an error code or NULL on error, the driver should check for both, not only for NULL, otherwise a crash is imminent... Reported-by: Arnd Bergmann Signed-off-by: Sergei Shtylyov --- The patch is against

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

[oops – resending this because I was using gmail in HTML mode before by accident] There was a discussion on a separate thread about this. I agree with Sabrina fully. I believe veth should provide an abstraction layer that correctly emulates a physical network in all ways. Consider an environment

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

We've put considerable effort into cleaning up the checksum interface to make it as unambiguous as possible, please be very careful to follow it. Broken checksum processing is really hard to detect and debug. CHECKSUM_UNNECESSARY means that some number of _specific_ checksums (indicated by

Re: __napi_alloc_skb failures locking up the box

On Sat, 2016-04-30 at 22:24 +0300, Aaro Koskinen wrote: > Hi, > > I have old NAS box (Thecus N2100) with 512 MB RAM, where rsync from NFS -> > disk reliably results in temporary out-of-memory conditions. > > When this happens the dmesg gets flooded with below logs. If the serial > console

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On 04/30/2016 11:33 AM, Ben Hutchings wrote: On Thu, 2016-04-28 at 12:29 +0200, Sabrina Dubroca wrote: Hello, http://dmz2.candelatech.com/?p=linux-4.4.dev.y/.git;a=commitdiff;h=8153e983c0e5eba1aafe1fc296248ed2a553f1ac;hp=454b07405d694dad52e7f41af5816eed0190da8a Actually, no, this is not

__napi_alloc_skb failures locking up the box

Hi, I have old NAS box (Thecus N2100) with 512 MB RAM, where rsync from NFS -> disk reliably results in temporary out-of-memory conditions. When this happens the dmesg gets flooded with below logs. If the serial console logging is enabled, this will lock up the box completely and the backup is

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Thu, 2016-04-28 at 06:45 -0700, Ben Greear wrote: > > On 04/28/2016 03:29 AM, Sabrina Dubroca wrote: [...] > > Your use case is invalid, it just happened to work because of a > > bug.  If you want the stack to fill checksums so that you want capture > > and reinject packets, you have to

Re: [PATCH 3.2 085/115] veth: don’t modify ip_summed; doing so treats packets with bad checksums as good.

On Thu, 2016-04-28 at 12:29 +0200, Sabrina Dubroca wrote: > Hello, > > 2016-04-27, 17:14:44 -0700, Ben Greear wrote: > > > > On 04/27/2016 05:00 PM, Hannes Frederic Sowa wrote: > > > > > > Hi Ben, > > > > > > On Wed, Apr 27, 2016, at 20:07, Ben Hutchings wrote: > > > > > > > > On Wed,

[PATCH net-next] net: relax expensive skb_unclone() in iptunnel_handle_offloads()

From: Eric Dumazet Locally generated TCP GSO packets having to go through a GRE/SIT/IPIP tunnel have to go through an expensive skb_unclone() Reallocating skb->head is a lot of work. Test should really check if a 'real clone' of the packet was done. TCP does not care if

[PATCH 1/4] batman-adv: fix DAT candidate selection (must use vid)

Now that DAT is VLAN aware, it must use the VID when computing the DHT address of the candidate nodes where an entry is going to be stored/retrieved. Fixes: be1db4f6615b ("batman-adv: make the Distributed ARP Table vlan aware") Signed-off-by: Antonio Quartulli

[PATCH 4/4] batman-adv: Fix reference counting of hardif_neigh_node object for neigh_node

From: Sven Eckelmann The batadv_neigh_node was specific to a batadv_hardif_neigh_node and held an implicit reference to it. But this reference was never stored in form of a pointer in the batadv_neigh_node itself. Instead batadv_neigh_node_release depends on a consistent

[PATCH 2/4] batman-adv: B.A.T.M.A.N V - make sure iface is reactivated upon NETDEV_UP event

At the moment there is no explicit reactivation of an hard-interface upon NETDEV_UP event. In case of B.A.T.M.A.N. IV the interface is reactivated as soon as the next OGM is scheduled for sending, but this mechanism does not work with B.A.T.M.A.N. V. The latter does not rely on the same scheduling

pull request [net]: batman-adv 20160430

Hello David, this is another pull request intended for net. I know that I sent another batch a few days ago, but after having gone through my queue I thought that merging these last 4 patches would still be worth it (there won't be any other pull request for linux-4.6 :)). The description of

[PATCH 3/4] batman-adv: Fix reference counting of vlan object for tt_local_entry

From: Sven Eckelmann The batadv_tt_local_entry was specific to a batadv_softif_vlan and held an implicit reference to it. But this reference was never stored in form of a pointer in the tt_local_entry itself. Instead batadv_tt_local_remove, batadv_tt_local_table_free and

Unauthorized attempt

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

On 4/30/16, 3:21 AM, Jamal Hadi Salim wrote: > On 16-04-30 02:41 AM, Roopa Prabhu wrote: >> From: Roopa Prabhu >> >> This patch modifies ifstat to use the new RTM_GETSTATS api >> to query stats from the kernel. In the process this also >> moves ifstat to use 64 bit

Re: [PATCHv3] netem: Segment GSO packets on enqueue

On Fri, Apr 29, 2016 at 11:19:05AM -0700, Stephen Hemminger wrote: > On Fri, 29 Apr 2016 13:35:48 -0400 > Neil Horman wrote: > > > This was recently reported to me, and reproduced on the latest net kernel, > > when > > attempting to run netperf from a host that had a

Re: [iproute2 1/1] man: tc-ife.8: man page for ife action

On Sat, Apr 30, 2016 at 06:58:04AM -0400, Jamal Hadi Salim wrote: > From: Lucas Bates > > Signed-off-by: Lucas Bates > Signed-off-by: Jamal Hadi Salim Acked-by: Phil Sutter Nit-picking on two things below, but merely

[iproute2 1/1] man: tc-ife.8: man page for ife action

From: Lucas Bates Signed-off-by: Lucas Bates Signed-off-by: Jamal Hadi Salim --- man/man8/tc-ife.8 | 118 ++ 1 file changed, 118 insertions(+) create mode 100644 man/man8/tc-ife.8

[PATCH net] vlan: Propagate MAC address changes properly

The MAC address of the physical interface is only copied to the VLAN when it is first created, resulting in an inconsistency after MAC address changes of only newly created VLANs having an up-to-date MAC. Continuing to inherit the MAC address unless explicitly changed for the VLAN allows IPv6

Re: [PATCH net] Propagate MAC address changes to VLANs

On 03/03/2016 09:12 PM, David Miller wrote: > From: Mike Manning > Date: Mon, 29 Feb 2016 11:32:51 + > >> >> -/* vlan address was equal to the old address and is different from >> +/* vlan address was equal to the old address so now also inherit >> * the

Re: [PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

On 16-04-30 02:41 AM, Roopa Prabhu wrote: From: Roopa Prabhu This patch modifies ifstat to use the new RTM_GETSTATS api to query stats from the kernel. In the process this also moves ifstat to use 64 bit stats. Breaks old kernels? May need to keep backward compat

Re: [PATCH v2 net-next 0/7] net: make TCP preemptible

Hello, On Fri, 29 Apr 2016, Eric Dumazet wrote: > I had corruptions issues and a dying HDD one month ago. > > I have a brand new HDD, but maybe the SSD I use for my git trees is > dying as well :( > > But I've seen this strange patterns in the past, it might be the old > text editor I

[PATCH net-next v3 3/4] bridge: vlan: learn to count

Add support for per-VLAN Tx/Rx statistics. Every global vlan context gets allocated a per-cpu stats which is then set in each per-port vlan context for quick access. The br_allowed_ingress() common function is used to account for Rx packets and the br_handle_vlan() common function is used to

[PATCH net-next v3 1/4] net: rtnetlink: allow rtnl_fill_statsinfo to save private state counter

The new prividx argument allows the current dumping device to save a private state counter which would enable it to continue dumping from where it left off. And the idxattr is used to save the current idx user so multiple prividx using attributes can be requested at the same time as suggested by

[PATCH net-next v3 4/4] bridge: netlink: export per-vlan stats

Add a new LINK_XSTATS_TYPE_BRIDGE attribute and implement the RTM_GETSTATS callbacks for IFLA_STATS_LINK_XSTATS (fill_linkxstats and get_linkxstats_size) in order to export the per-vlan stats. The paddings were added because soon these fields will be needed for per-port per-vlan stats (or

[PATCH net-next v3 0/4] bridge: per-vlan stats

Hi, This set adds support for bridge per-vlan statistics. In order to be able to dump statistics for many vlans we need a way to continue dumping after reaching maximum size, thus patches 01 and 02 extend the new stats API with a per-device extended link stats attribute and callback which can save

[PATCH net-next v3 2/4] net: rtnetlink: add linkxstats callbacks and attribute

Add callbacks to calculate the size and fill link extended statistics which can be split into multiple messages and are dumped via the new rtnl stats API (RTM_GETSTATS) with the IFLA_STATS_LINK_XSTATS attribute. Also add that attribute to the idx mask check since it is expected to be able to save

[PATCH iproute2 net-next] ifstat: move to new RTM_GETSTATS api

From: Roopa Prabhu This patch modifies ifstat to use the new RTM_GETSTATS api to query stats from the kernel. In the process this also moves ifstat to use 64 bit stats. Signed-off-by: Roopa Prabhu --- include/libnetlink.h | 3 +++