Re: Hitting WARN_ON_ONCE on skb_try_coalesce

On Wed, 2016-08-03 at 20:36 -0300, Marcelo Ricardo Leitner wrote: > Hi, > > I have two namespaces linked with a veth and netem in one of them adding 20ms > latency, and doing netperf from one to another. I'm on commit > 7cf210dc267861360cf6968b69bf512475aca985, net updated today, and I'm hitting

Re: [PATCH] wl3501_cs: Add spinlock to wl3501_reset

On Tuesday 02 August 2016 03:11 PM, Pavel Andrianov wrote: > Likely wl3501_reset should acquire spinlock as wl3501_{open, close}. > One of calls of wl3501_reset has been already protected. > The others were unprotected and might lead to a race condition. > The patch adds spinlock into the

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

On 8/3/16 5:02 PM, subas...@codeaurora.org wrote: >> I can't explain the iptables output but from a FIB lookup perspective >> it is using table 8 per the FIB rules, the xfrm is hit and packets >> shift to 192.168.77.1 and go out what you have as eth0. >> >> Take a look at: >> perf record -e

[PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

Adding fdb entries pointing to the bridge device uses fdb_insert(), which lacks various checks and does not respect added_by_user flag. As a result, some inconsistent behavior can happen: * Adding temporary entries succeeds but results in permanent entries. * Same goes for "dynamic" and "use". *

[PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

code does not match comment head = tcp_write_queue_head(sk); skb_mstamp_get(); age = skb_mstamp_us_delta(, >skb_mstamp); /* If next ACK is likely to come too late (half srtt), do not defer */ if (age < (tp->srtt_us >> 4)) goto send_now;

Re: [PATCH] tcp-tso: fix faulty logic in tcp_tso_should_defer

On Thu, Aug 4, 2016 at 12:01 PM, Liang Ge wrote: > > code does not match comment > > head = tcp_write_queue_head(sk); > skb_mstamp_get(); > age = skb_mstamp_us_delta(, >skb_mstamp); > /* If next ACK is likely to come too late (half srtt), do

Re: [RFC PATCH v2 1/4] Documentation: DT: net: Add Xilinx gmiitorgmii converter device tree binding documentation

On 27/07/2016 01:05, Andrew Lunn wrote: > Hi Appana > > Here is roughly what i was thinking: > > struct priv { >phy_device *master; >phy_device *slave; >struct phy_driver *slave_drv; > }; > > phy_status_clone(phy_device *master, phy_device *slave) > { >

Re: [PATCH v1] net: phy: micrel: Add specific suspend

On 03/08/2016 17:21, Wenyou Yang wrote: > Disable all interrupts when suspend, they will be enabled > when resume. Otherwise, the suspend/resume process will be > blocked occasionally. This seems like something fairly generic actually, we could imagine having the core library do something like

Re: [PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes

Hi Daniel, [auto build test WARNING on net/master] url: https://github.com/0day-ci/linux/commits/Daniel-Borkmann/Few-BPF-helper-related-checksum-fixes/20160804-085300 reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/skbuff.h:940: warning: No description

[PATCH net 3/3] bpf: fix checksum for vlan push/pop helper

When having skbs on ingress with CHECKSUM_COMPLETE, tc BPF programs don't push rcsum of mac header back in and after BPF run back pull out again as opposed to some other subsystems (ovs, for example). For cases like q-in-q, meaning when a vlan tag for offloading is already present and we're about

[PATCH net 2/3] bpf: fix checksum fixups on bpf_skb_store_bytes

bpf_skb_store_bytes() invocations above L2 header need BPF_F_RECOMPUTE_CSUM flag for updates, so that CHECKSUM_COMPLETE will be fixed up along the way. Only other exception besides L2 header where BPF_F_RECOMPUTE_CSUM is not passed to bpf_skb_store_bytes() are packet changes affecting pseudo

[PATCH net 0/3] Few BPF helper related checksum fixes

The set contains three fixes with regards to CHECKSUM_COMPLETE and BPF helper functions. For details please see individual patches. Thanks! Daniel Borkmann (3): bpf: also call skb_postpush_rcsum on xmit occasions bpf: fix checksum fixups on bpf_skb_store_bytes bpf: fix checksum for vlan

[PATCH net 1/3] bpf: also call skb_postpush_rcsum on xmit occasions

Follow-up to commit f8ffad69c9f8 ("bpf: add skb_postpush_rcsum and fix dev_forward_skb occasions") to fix an issue for dev_queue_xmit() redirect locations which need CHECKSUM_COMPLETE fixups on ingress. For the same reasons as described in f8ffad69c9f8 already, we of course also need this here,

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Inline On 08/03/2016 05:58 PM, Feng Gao wrote: inline comment. There are two comments that I am not clear. Best Regards Feng On Thu, Aug 4, 2016 at 4:43 AM, Philip Prindeville wrote: Inline… On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com

[PATCH v1] net: phy: micrel: Add specific suspend

Disable all interrupts when suspend, they will be enabled when resume. Otherwise, the suspend/resume process will be blocked occasionally. Signed-off-by: Wenyou Yang Acked-by: Nicolas Ferre --- drivers/net/phy/micrel.c | 19 ++-

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

inline comment. There are two comments that I am not clear. Best Regards Feng On Thu, Aug 4, 2016 at 4:43 AM, Philip Prindeville wrote: > Inline… > >> On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: >> >> From: Gao Feng >>

Re: [PATCH net-next 06/18] liquidio support for new device cn23xx

Hi Raghu, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Raghu-Vatsavayi/liquidio-support-for-new-device-cn23xx/20160804-063711 config: arm64-allmodconfig (attached as .config) compiler: aarch64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Hi Tom, inline comments On Thu, Aug 4, 2016 at 12:15 AM, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 7:52 AM, wrote: >> From: Gao Feng >> >> The PPTP is encapsulated by GRE header with that GRE_VERSION bits >> must contain one. But

[PATCH 1/1] ixgbevf: remove unused variable

From: Zhu Yanjun The variable autoneg_wait_to_complete is not used. So it is removed. Signed-off-by: Zhu Yanjun --- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++-- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-

Re: PROBLEM: network data corruption (bisected to e5a4b0bb803b)

Christian Lamparter wrote: > > One thing I noticed in your previous post is that you "might" not have > draft-802.11n enabled. Do you see any "disabling HT/VHT due to WEP/TKIP use." > in your dmesg logs? If so, check if you can force your AP to use WPA2 > with CCMP/AES only. > Yes, I've had

Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

On Wed, Aug 03, 2016 at 06:51:15PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote: > > Since it is exported as unsigned value, userspace has no way detecting > > whether it is negative or just very large. Therefore do this in kernel > > space

Hitting WARN_ON_ONCE on skb_try_coalesce

Hi, I have two namespaces linked with a veth and netem in one of them adding 20ms latency, and doing netperf from one to another. I'm on commit 7cf210dc267861360cf6968b69bf512475aca985, net updated today, and I'm hitting this: [ 1043.024555] WARNING: CPU: 3 PID: 19902 at

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On 08/04/2016 12:36 AM, Alexei Starovoitov wrote: On Wed, Aug 03, 2016 at 12:06:55PM -0700, Tom Herbert wrote: [...] This is not at all obvious to XDP programmer. The type of ctx structure is xdp_md and the definition of that structure in uapi/linux/bpf.h says that the fields in the that

Re: [PATCH net-next 15/18] liquidio support for new device cn23xx

Hi Raghu, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Raghu-Vatsavayi/liquidio-support-for-new-device-cn23xx/20160804-063711 config: sparc64-allmodconfig (attached as .config) compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609

Re: [RFC PATCH] xfrm: Add option to reset oif in xfrm lookup

I can't explain the iptables output but from a FIB lookup perspective it is using table 8 per the FIB rules, the xfrm is hit and packets shift to 192.168.77.1 and go out what you have as eth0. Take a look at: perf record -e fib:* -a -g perf script And then run tcpdump on both eth0 and eth1.

Re: [PATCH] ipv4: panic in leaf_walk_rcu due to stale node pointer

On Wed, Aug 3, 2016 at 12:01 PM, David Miller wrote: > From: David Forster > Date: Wed, 3 Aug 2016 15:13:01 +0100 > >> Panic occurs when issuing "cat /proc/net/route" whilst >> populating FIB with > 1M routes. >> >> Use of cached node pointer in

Re: [PATCH net-next 15/18] liquidio support for new device cn23xx

Hi Raghu, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Raghu-Vatsavayi/liquidio-support-for-new-device-cn23xx/20160804-063711 config: tile-allmodconfig (attached as .config) compiler: tilegx-linux-gcc (GCC) 4.6.2 reproduce: wget

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Wed, Aug 03, 2016 at 12:06:55PM -0700, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 11:29 AM, Brenden Blanco wrote: > > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: > >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > >>

[PATCH net-next 18/18] liquidio support for new device cn23xx

This patch adds support for pause frame and priv flag for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

On Wed, Aug 3, 2016 at 9:04 AM, Rick Jones wrote: > > Should anything then happen with: > > /* No rx interrupts will be generated if both are zero */ > if ((ec->rx_coalesce_usecs == 0) && > (ec->rx_max_coalesced_frames == 0)) >

Re: [PATCH net-next 00/18] liquidio support for new device cn23xx

From: Raghu Vatsavayi Date: Wed, 3 Aug 2016 11:55:31 -0700 > Please consider following patches for support of new device > CN23XX in liquidio family of adapters. Patches may have to > be applied in following order as some of the patches depend > on earlier patches.

Re: [PATCH v2 2/3] sctp_diag: export timer value only if it is active

On Wed, Aug 03, 2016 at 11:23:12PM +0200, Phil Sutter wrote: > Since it is exported as unsigned value, userspace has no way detecting > whether it is negative or just very large. Therefore do this in kernel > space where it is a simple comparison. > > Signed-off-by: Phil Sutter >

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Arnd Bergmann wrote: As I said, this is inherently driver specific. If setting the 64-bit mask fails, the driver itself needs to fall back to the 32-bit mask so it can allocate buffers from ZONE_DMA instead of ZONE_NORMAL. I just posted a v7 of my patch, but I forgot to fix the dma_set_mask

[PATCH v2 2/3] sctp_diag: export timer value only if it is active

Since it is exported as unsigned value, userspace has no way detecting whether it is negative or just very large. Therefore do this in kernel space where it is a simple comparison. Signed-off-by: Phil Sutter --- Changes since v1: - Introduce local variable to shorten long lines. -

[PATCH v2 0/3] sctp_diag: A bunch of fixes for upcoming 'ss' support

The following series contains a number of fixes necessary to make my yet unpublished 'ss' support patch functional. Changes since v1: - Fixed patch 2/3 - Rebased whole series onto current net-next/master Phil Sutter (3): sctp: Export struct sctp_info to userspace sctp_diag: export timer

[PATCH v2 3/3] sctp_diag: Respect ss adding TCPF_CLOSE to idiag_states

Since 'ss' always adds TCPF_CLOSE to idiag_states flags, sctp_diag can't rely upon TCPF_LISTEN flag solely being present when listening sockets are requested. Signed-off-by: Phil Sutter --- net/sctp/sctp_diag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH v2 1/3] sctp: Export struct sctp_info to userspace

This is required to correctly interpret INET_DIAG_INFO messages exported by sctp_diag module. Signed-off-by: Phil Sutter --- include/linux/sctp.h | 64 --- include/uapi/linux/sctp.h | 64

Re: net: vrf: Handle ipv6 multicast and link-local addresses

On Wed, Aug 3, 2016 at 10:36 PM, David Ahern wrote: > On 8/3/16 2:27 PM, Geert Uytterhoeven wrote: >> On Wed, Aug 3, 2016 at 10:11 PM, David Ahern >> wrote: >>> On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: > +static void

Re: [PATCH net-next 00/18] liquidio support for new device cn23xx

On 08/03/2016 11:55 AM, Raghu Vatsavayi wrote: Dave, Please consider following patches for support of new device CN23XX in liquidio family of adapters. Patches may have to be applied in following order as some of the patches depend on earlier patches. Thanks Raghu Vatsavayi. Raghu Vatsavayi

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Inline… > On Aug 3, 2016, at 8:52 AM, f...@48lvckh6395k16k5.yundunddos.com wrote: > > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for

Re: net: vrf: Handle ipv6 multicast and link-local addresses

On 8/3/16 2:27 PM, Geert Uytterhoeven wrote: > On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: >> On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device *vrf_dev, > +

[PATCH net-next 13/18] liquidio support for new device cn23xx

This patch adds support for Instruction Queue(IQ) index manipulation routines thru bar1 of cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 05/18] liquidio support for new device cn23xx

This patch adds support for cn23xx specific queue definitions and features. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next 10/18] liquidio support for new device cn23xx

This patch adds firmware download support for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 04/18] liquidio support for new device cn23xx

This patch adds support for new device cn23xx related register definitions and structures. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 08/18] liquidio support for new device cn23xx

This patch adds support for queue manipulation routines for cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 07/18] liquidio support for new device cn23xx

This patch adds support for device initialization functions for cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next 00/18] liquidio support for new device cn23xx

Dave, Please consider following patches for support of new device CN23XX in liquidio family of adapters. Patches may have to be applied in following order as some of the patches depend on earlier patches. Thanks Raghu Vatsavayi. Raghu Vatsavayi (18):

[PATCH net-next 15/18] liquidio support for new device cn23xx

This patch adds support for LED identification and ethtool based statistics for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 03/18] liquidio support for new device cn23xx

This patch adds support for adding common lio_enable_irq function for iq and oq. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by:

[PATCH net-next 12/18] liquidio support for new device cn23xx

This patch adds support for RX control commands on cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 16/18] liquidio support for new device cn23xx

This patch adds support for watchdog based health monitoring of octeon cores. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

Re: net: vrf: Handle ipv6 multicast and link-local addresses

On Wed, Aug 3, 2016 at 10:11 PM, David Ahern wrote: > On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: >>> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device >>> *vrf_dev, >>> > + int ifindex) >>> > +{ >>> > + const

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

On Wed, Aug 03, 2016 at 04:46:52PM -0300, Marcelo Ricardo Leitner wrote: > On Wed, Aug 03, 2016 at 09:28:13PM +0200, Phil Sutter wrote: > > Hi, > > > > On Sat, Jul 30, 2016 at 09:25:42PM +0800, Xin Long wrote: > > [...] > > > Now for the transport's info, we only choose primary_path to dump. > >

[PATCH] [v7] net: emac: emac gigabit ethernet controller driver

Add supports for ethernet controller HW on Qualcomm Technologies, Inc. SoC. This driver supports the following features: 1) Checksum offload. 2) Interrupt coalescing support. 3) SGMII phy. 4) phylib interface for external phy Based on original work by Niranjana Vishwanathapura

Re: net: vrf: Handle ipv6 multicast and link-local addresses

On 8/3/16 1:57 PM, Geert Uytterhoeven wrote: >> +static void vrf_ip6_input_dst(struct sk_buff *skb, struct net_device >> *vrf_dev, >> > + int ifindex) >> > +{ >> > + const struct ipv6hdr *iph = ipv6_hdr(skb); >> > + struct flowi6 fl6 = { >> > +

Re: [PATCH] [v6] net: emac: emac gigabit ethernet controller driver

Timur Tabi wrote: Is there a good way to test my code? ping and iperf appear to send no more than 3 packets at a time, which comes nowhere close to filling the queue (which holds 512 normally). netif_queue_stopped() never returns true, no matter what I do. Never mind, I fixed this problem.

Re: net: vrf: Handle ipv6 multicast and link-local addresses

On Wed, Jul 27, 2016 at 11:52 PM, Linux Kernel Mailing List wrote: > Web: > https://git.kernel.org/torvalds/c/9ff74384600aeecba34ebdacbbde0627489ff601 > Commit: 9ff74384600aeecba34ebdacbbde0627489ff601 > Parent:

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

On Wed, Aug 03, 2016 at 09:28:13PM +0200, Phil Sutter wrote: > Hi, > > On Sat, Jul 30, 2016 at 09:25:42PM +0800, Xin Long wrote: > [...] > > Now for the transport's info, we only choose primary_path to dump. > > It means we should fix this by getting the left time to expire from > > primary

[PATCH] net: dsa: b53: Add missing ULL suffix for 64-bit constant

On 32-bit (e.g. with m68k-linux-gnu-gcc-4.1): drivers/net/dsa/b53/b53_common.c: In function ‘b53_arl_read’: drivers/net/dsa/b53/b53_common.c:1072: warning: integer constant is too large for ‘long’ type Fixes: 1da6df85c6fbed8f ("net: dsa: b53: Implement ARL add/del/dump operations")

[PATCH net-next 11/18] liquidio support for new device cn23xx

This patch adds support for work queue for link status and control commands. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next 09/18] liquidio support for new device cn23xx

This patch adds support for msix interrupt for cn23xx device. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 01/18] liquidio support for new device cn23xx

This patch consolidates common functionality of different devices from other files into lio_core.c/octeon_console.c. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 14/18] liquidio support for new device cn23xx

This patch adds support for data path related changes based on octeon3 instruction header(ih3) and related changes for cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas

[PATCH net-next 02/18] liquidio support for new device cn23xx

This patch contains changes for firmware version management changes. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

[PATCH net-next 17/18] liquidio support for new device cn23xx

This patch adds NAPI related support for cn23xx. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu Vatsavayi

[PATCH net-next 06/18] liquidio support for new device cn23xx

This patch adds hooks for cn23xx device init and sriov queue config. Signed-off-by: Derek Chickles Signed-off-by: Satanand Burla Signed-off-by: Felix Manlunas Signed-off-by: Raghu

Re: [PATCH 2/3] sctp_diag: export timer value only if it is active

Hi, On Sat, Jul 30, 2016 at 09:25:42PM +0800, Xin Long wrote: [...] > Now for the transport's info, we only choose primary_path to dump. > It means we should fix this by getting the left time to expire from > primary transport t->T3_rtx_timer. like: > > r->idiag_expires =

[RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

Otherwise freezer cgroup state might never become "FROZEN". Here is a deadlock scheme for 2 processes in one freezer cgroup, which is freezing: CPU 0 CPU 1 do_last inode_lock(dir->d_inode) vfs_create nfs_create

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Wed, Aug 3, 2016 at 11:29 AM, Brenden Blanco wrote: > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov >> wrote: >> > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert

[patch] i40e: remove a stray unlock

We shifted the locking around a bit but forgot to delete this unlock so now it can unlock twice. Fixes: cd3be169a5ff ('i40e: Move the mutex lock in i40e_client_unregister') Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/intel/i40e/i40e_client.c

Re: [PATCH] net: xgene: fix maybe-uninitialized variable

From: Arnd Bergmann Date: Tue, 2 Aug 2016 12:23:29 +0200 > Building with -Wmaybe-uninitialized shows a potential use of > an uninitialized variable: > > drivers/net/ethernet/apm/xgene/xgene_enet_hw.c: In function > 'xgene_enet_phy_connect': >

Re: [PATCH net 0/3] qlcnic: bug fixes

From: Manish Chopra Date: Wed, 3 Aug 2016 04:02:01 -0400 > This series fixes a data structure corruption bug in > VF's async mailbox commands handling and an issue realted > to napi poll budget in the driver. > > Please consider applying this series to "net" Series

Re: [PATCH] ipv4: panic in leaf_walk_rcu due to stale node pointer

From: David Forster Date: Wed, 3 Aug 2016 15:13:01 +0100 > Panic occurs when issuing "cat /proc/net/route" whilst > populating FIB with > 1M routes. > > Use of cached node pointer in fib_route_get_idx is unsafe. ... > Signed-off-by: Dave Forster

Re: [PATCH net 0/2] tg3: Disallow 0 rx coalesce time and correctly report RSS queues in tg3_get_rxnfc

From: skallam Date: Wed, 3 Aug 2016 09:43:58 +0530 > First patch: > Diasllow rx coalescing time to be 0 > > Second patch: > Report the correct number of RSS queues through tg3_get_rxnfc Series applied, thanks.

Re: [PATCH net] bpf: fix method of PTR_TO_PACKET reg id generation

From: Jakub Kicinski Date: Tue, 2 Aug 2016 16:12:14 +0100 > Using per-register incrementing ID can lead to > find_good_pkt_pointers() confusing registers which > have completely different values. Consider example: ... > We need to get a UNKNOWN_VALUE with imm to

Re: [PATCH net] openvswitch: Remove incorrect WARN_ONCE().

From: Jarno Rajahalme Date: Mon, 1 Aug 2016 19:36:07 -0700 > ovs_ct_find_existing() issues a warning if an existing conntrack entry > classified as IP_CT_NEW is found, with the premise that this should > not happen. However, a newly confirmed, non-expected conntrack entry >

Re: [PATCH 1/1] virtio-vsock: Fix unbound rx buffer

From: ggar...@abra.uab.cat Date: Mon, 01 Aug 2016 19:18:21 +0200 > From: Gerard Garcia > > Reset connection and close rx socket when the sender is ignoring our > announced available buffer. > > Signed-off-by: Gerard Garcia > --- >

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: > On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > wrote: > > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: > >> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

From: Brenden Blanco Date: Wed, 3 Aug 2016 11:29:52 -0700 > On Wed, Aug 03, 2016 at 10:29:58AM -0700, Tom Herbert wrote: >> On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov >> wrote: >> > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

From: Tom Herbert Date: Wed, 3 Aug 2016 10:29:58 -0700 > On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov > wrote: >> On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: >>> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

> On Aug 3, 2016, at 1:36 PM, Jeff Layton wrote: > > On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: >> Otherwise freezer cgroup state might never become "FROZEN". >> >> Here is a deadlock scheme for 2 processes in one freezer cgroup, >> which is >>

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco wrote: > Add a sample that rewrites and forwards packets out on the same > interface. Observed single core forwarding performance of ~10Mpps. > > Since the mlx4 driver under test recycles every single packet page, the > perf

order-0 vs order-N driver allocation. Was: [PATCH v10 07/12] net/mlx4_en: add page recycle to prepare rx ring for tx support

On Mon, Jul 25, 2016 at 09:35:20AM +0200, Eric Dumazet wrote: > On Tue, 2016-07-19 at 12:16 -0700, Brenden Blanco wrote: > > The mlx4 driver by default allocates order-3 pages for the ring to > > consume in multiple fragments. When the device has an xdp program, this > > behavior will prevent tx

Re: [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: > Otherwise freezer cgroup state might never become "FROZEN". > > Here is a deadlock scheme for 2 processes in one freezer cgroup, > which is > freezing: > > CPU 0   CPU 1 >    

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Wed, Aug 3, 2016 at 10:11 AM, Alexei Starovoitov wrote: > On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: >> On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco >> wrote: >> > Add a sample that rewrites and forwards packets out on

Re: [PATCH v10 12/12] bpf: add sample for xdp forwarding and rewrite

On Wed, Aug 03, 2016 at 10:01:54AM -0700, Tom Herbert wrote: > On Tue, Jul 19, 2016 at 12:16 PM, Brenden Blanco wrote: > > Add a sample that rewrites and forwards packets out on the same > > interface. Observed single core forwarding performance of ~10Mpps. > > > > Since the

Re: [PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

On Wed, Aug 3, 2016 at 7:52 AM, wrote: > From: Gao Feng > > The PPTP is encapsulated by GRE header with that GRE_VERSION bits > must contain one. But current GRE RPS needs the GRE_VERSION must be > zero. So RPS does not work for PPTP traffic. > > In my test

Re: PROBLEM: TPROXY and DNAT broken (bisected to 079096f103fa)

I think that it is worth doing, as the original kernel change broke my user space program and could do the same to others as well. On another setup, even with the DIVERT rule in place, I'm still seeing the RST after the ACK. I'm not sure how it is behaving differently than the other setup so I

Re: [PATCH net 1/2] tg3: Fix for diasllow rx coalescing time to be 0

On 08/02/2016 09:13 PM, skallam wrote: From: Satish Baddipadige When the rx coalescing time is 0, interrupts are not generated from the controller and rx path hangs. To avoid this rx hang, updating the driver to not allow rx coalescing time to be 0.

RE: [PATCH 0071/1285] Replace numeric parameter like 0444 with macro

From: Baole Ni > Sent: 02 August 2016 11:39 > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the > corresponding macro, > and that

Re: [Patch net-next] net_sched: remove the leftover cleanup_a()

On Wed, Aug 3, 2016 at 4:36 AM, Jamal Hadi Salim wrote: > Cong, > > Improvement on the basic test as it no longer oopses, but: > here's a test that will oops: Make sure you test this together with the other patch I sent (sorry I didn't number them), the other patch also fixed

Re: Kernel NFS boot failure

Hi Vladimir, On 08/03/2016 03:06 PM, Vladimir Murzin wrote: > On 03/08/16 12:41, Grygorii Strashko wrote: >> We observe Kernel boot failure while running NFS boot stress test (1000 >> iterations): >> - Linux version 4.7.0 I'd like to pay your attention that this issue also reproducible with

[PATCH] ipv4: panic in leaf_walk_rcu due to stale node pointer

Panic occurs when issuing "cat /proc/net/route" whilst populating FIB with > 1M routes. Use of cached node pointer in fib_route_get_idx is unsafe. BUG: unable to handle kernel paging request at c90001630024 IP: [] leaf_walk_rcu+0x10/0xe0 PGD 11b08d067 PUD 11b08e067 PMD dac4b067 PTE 0

[PATCH v3 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

From: Gao Feng The PPTP is encapsulated by GRE header with that GRE_VERSION bits must contain one. But current GRE RPS needs the GRE_VERSION must be zero. So RPS does not work for PPTP traffic. In my test environment, there are four MIPS cores, and all traffic are passed

Re: [PATCH 1/1] rps: Inspect PPTP encapsulated by GRE to get flow hash

Hi Philip & Tom, I have sent the v3 patch now. Philip, I just move the definition of pptp_gre_header into new file include/net/pptp.h without refactoring the pptp codes now. I think the refactor should be done in another patch. Tom, Now I have consolidate the PPTP codes with GRE codes together.

[PULL] vhost: new features for 4.8

I already have more bugfixes on top queued, but not regression fixes so it does not seem worth it to delay this anymore. The following changes since commit 523d939ef98fd712632d93a5a2b588e477a7565e: Linux 4.7 (2016-07-24 12:23:50 -0700) are available in the git repository at:

[PATCH 1/2] ravb: use SET_RUNTIME_PM_OPS macro

Use macro to define the runtime PM operations. Signed-off-by: Niklas Söderlund --- drivers/net/ethernet/renesas/ravb_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/renesas/ravb_main.c

[PATCH 0/2] ravb: add sleep PM suspend/resume support

Hi, This series adds sleep PM suspend/resume support to the ravb driver. It is based on v4.7 and tested on Salvator-X. I used NFS root filesystem and was able to suspend/resume and keep the system working. I also tested suspend/resume with a initramfs when the interface was down (ifconfig

[PATCH 2/2] ravb: add sleep PM suspend/resume support

The interface would not function after the system had been woken up after have been suspended (echo mem > /sys/power/state) cycle. The reason for this is that all device registers have been reset to its default values. This patch adds sleep suspend and resume functions that detached the interface

  1   2   >