Re: [PATCH net 1/4] pegasus: Use heap buffers for all register access

2017-02-07 Thread Petko Manolov
On 17-02-07 10:32:16, Steve Calfee wrote: > On Mon, Feb 6, 2017 at 4:51 AM, Petko Manolov wrote: > > On 17-02-06 09:28:22, Greg KH wrote: > >> On Mon, Feb 06, 2017 at 10:14:44AM +0200, Petko Manolov wrote: > >> > On 17-02-05 01:30:39, Greg KH wrote: > >> > > On Sat, Feb 04,

RE: [PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-07 Thread maowenan
> -Original Message- > From: Florian Fainelli [mailto:f.faine...@gmail.com] > Sent: Wednesday, February 08, 2017 3:38 PM > To: netdev@vger.kernel.org > Cc: da...@davemloft.net; and...@lunn.ch; rmk+ker...@armlinux.org.uk; > maowenan; Florian Fainelli > Subject: [PATCH net v2 1/3] net:

Re: [PATCH v3 1/2] mac80211: fils_aead: Use crypto api CMAC shash rather than bare cipher

2017-02-07 Thread Johannes Berg
On Wed, 2017-02-08 at 07:45 +, Ard Biesheuvel wrote: > On 8 February 2017 at 07:00, Johannes Berg > wrote: > > This looks strange to me: > > > > > +static int aes_s2v(struct crypto_shash *tfm, > > >  size_t num_elem, const u8 *addr[], size_t len[],

Re: [PATCH v3 1/2] mac80211: fils_aead: Use crypto api CMAC shash rather than bare cipher

2017-02-07 Thread Ard Biesheuvel
On 8 February 2017 at 07:00, Johannes Berg wrote: > This looks strange to me: > >> +static int aes_s2v(struct crypto_shash *tfm, >> size_t num_elem, const u8 *addr[], size_t len[], >> u8 *v) >> { >> - u8 d[AES_BLOCK_SIZE], tmp[AES_BLOCK_SIZE]; >> +

[PATCH net v2 3/3] net: phy: Fix PHY driver bind and unbind events

2017-02-07 Thread Florian Fainelli
The PHY library does not deal very well with bind and unbind events. The first thing we would see is that we were not properly canceling the PHY state machine workqueue, so we would be crashing while dereferencing phydev->drv since there is no driver attached anymore. Once we fix that, there are

[PATCH 1/3 net-next] enic: add devcmds for vxlan offload

2017-02-07 Thread Govindarajulu Varadarajan
This patch adds devcmds needed for vxlan offload. Implement 3 new devcmd overlay_offload_ctrl: enable/disable offload overlay_offload_cfg: update offload udp port number get_supported_feature_ver: get hw supported offload version. Each version has different bitmap for

[PATCH net v2 0/3] net: phy: Unbind/bind fixes

2017-02-07 Thread Florian Fainelli
Hi all, This patch series addresses the inability to safely unbind and bind PHY drivers by making the appropriate checks throught PHYLIB where we may be directly responding to user-space queries, as well as from within the kernel state machine. The second patch makes the unbind -> bind working

[PATCH net v2 1/3] net: phy: Fix PHY module checks

2017-02-07 Thread Florian Fainelli
The Generic PHY drivers gets assigned after we checked that the current PHY driver is NULL, so we need to check a few things before we can safely derference d->driver. Update phy_attach_direct() and phy_detach() accordingly to be resilient to these cases. Even though the Generic PHY driver

[PATCH net v2 2/3] net: phy: Check phydev->drv

2017-02-07 Thread Florian Fainelli
In preparation for supporting driver bind/unbind properly, sprinkle checks on phydev->drv where we may call into PHYLIB from user-space or other parts of the kernel. Suggested-by: Russell King Signed-off-by: Florian Fainelli ---

[PATCH 2/3 net-next] enic: add udp_tunnel ndo for vxlan offload

2017-02-07 Thread Govindarajulu Varadarajan
Defines enic_udp_tunnel_add/del for configuring vxlan tunnel offload. enic supports offload of only one ipv4/udp port. There are two modes that fw supports for vxlan offload. mode 0: fcoe bit is set for encapsulated packet. fcoe_fc_crc_ok is set if checksum of csum is ok. This bit is or of

[PATCH 3/3 net-next] enic: add vxlan offload on tx path

2017-02-07 Thread Govindarajulu Varadarajan
Define ndo_features_check. Hw supports offload only for ipv4 inner and ipv4 outer pkt. Code refactor for setting inner tcp pseudo csum. Signed-off-by: Govindarajulu Varadarajan --- drivers/net/ethernet/cisco/enic/enic_main.c | 126 +--- 1 file

Re: arch: arm: bpf: Converting cBPF to eBPF for arm 32 bit

2017-02-07 Thread Shubham Bansal
Anybody willing to take swing at my following comments ? On Wed, Feb 1, 2017 at 6:31 PM, Shubham Bansal wrote: > Hi Kees & Daniel, > > On Tue, Jan 31, 2017 at 09:44:56AM -0800, Kees Cook wrote: >> >> > 1.) Currently, as eBPF uses 64 bit registers, I am mapping 64 bit

[PATCH net-next v4 1/2] qed: Add infrastructure for PTP support.

2017-02-07 Thread Sudarsana Kalluru
From: Sudarsana Reddy Kalluru The patch adds the required qed interfaces for configuring/reading the PTP clock on the adapter. Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Yuval Mintz ---

[PATCH net-next v4 2/2] qede: Add driver support for PTP.

2017-02-07 Thread Sudarsana Kalluru
From: Sudarsana Reddy Kalluru This patch adds the driver support for, - Registering the ptp clock functionality with the OS. - Timestamping the Rx/Tx PTP packets. - Ethtool callbacks related to PTP. Signed-off-by: Sudarsana Reddy Kalluru

[PATCH] net: fix description of skb_find_text() according to removed functionality

2017-02-07 Thread Igor Pylypiv
I am not planning to to add a new user of this functions. Use of skb_find_text() was a part of my Linux study and its description informed me that I can use textsearch_next() which I cannot. Just want to fix this. On Tue, Feb 7, 2017 at 7:02 PM, David Miller wrote: > > How

[PATCH net] net: dsa: Do not destroy invalid network devices

2017-02-07 Thread Florian Fainelli
dsa_slave_create() can fail, and dsa_user_port_unapply() will properly check for the network device not being NULL before attempting to destroy it. We were not setting the slave network device as NULL if dsa_slave_create() failed, so we would later on be calling dsa_slave_destroy() on a now free'd

RE: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Weiny, Ira
> > On Tue, 2017-02-07 at 16:54 -0800, Vishwanathapura, Niranjana wrote: > > On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: > > > On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > > > > This is Ethernet - not IP - encapsulation over a non-InfiniBand > device/protocol. > >

Re: [PATCH v3 1/2] mac80211: fils_aead: Use crypto api CMAC shash rather than bare cipher

2017-02-07 Thread Johannes Berg
This looks strange to me: > +static int aes_s2v(struct crypto_shash *tfm, >      size_t num_elem, const u8 *addr[], size_t len[], > u8 *v) >  { > - u8 d[AES_BLOCK_SIZE], tmp[AES_BLOCK_SIZE]; > + u8 d[AES_BLOCK_SIZE], tmp[AES_BLOCK_SIZE] = {}; > + SHASH_DESC_ON_STACK(desc,

[PATCH net-next v4 0/2] qed*: Add support for PTP

2017-02-07 Thread Sudarsana Kalluru
From: Sudarsana Reddy Kalluru Hi David, The patch series adds required changes for qed/qede drivers for supporting the IEEE Precision Time Protocol (PTP). Please consider applying this series to "net-next". Thanks, Sudarsana Changes from previous versions:

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 02:19:01PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 07, 2017 at 12:23:01PM -0800, Vishwanathapura, Niranjana wrote: > > Add rdma netdev interface to ib device structure allowing rdma netdev > > devices to be allocated by ib clients. > > Define HFI VNIC interface between

Re: [PATCH net 0/2] net: phy: Unbind/bind fixes

2017-02-07 Thread Florian Fainelli
On 02/05/2017 02:25 PM, Florian Fainelli wrote: > Hi all, > > This patch series addresses the inability to safely unbind and bind > PHY drivers by making the appropriate checks throught PHYLIB where we > may be directly responding to user-space queries, as well as from within > the kernel state

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Denny Page
> On Feb 07, 2017, at 06:01, Miroslav Lichvar wrote: > > 1) new rx_filter for NTP > > Some NICs can't timestamp all received packets and are currently > unusable for NTP with HW timestamping. The new filter would allow > NTP support in new NICs and adding support to

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Denny Page
On Feb 07, 2017, at 21:27, Richard Cochran wrote: > > On Tue, Feb 07, 2017 at 05:52:52PM -0800, Denny Page wrote: >> Most, but not all. The TI DP83630 doesn’t support timestamping for all >> packets, but it does support either PTP or NTP: > > That is the one and only

Re: [PATCH net-next 7/7] openvswitch: Pack struct sw_flow_key.

2017-02-07 Thread Jarno Rajahalme
> On Feb 6, 2017, at 11:15 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> struct sw_flow_key has two 16-bit holes. Move the most matched >> conntrack match fields there. In some typical cases this reduces the >> size of the key

Re: [PATCH net-next 6/7] openvswitch: Add force commit.

2017-02-07 Thread Jarno Rajahalme
> On Feb 7, 2017, at 2:15 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> Stateful network admission policy may allow connections to one >> direction and reject connections initiated in the other direction. >> After policy change

Re: [PATCH net-next 4/7] openvswitch: Inherit master's labels.

2017-02-07 Thread Jarno Rajahalme
> On Feb 6, 2017, at 1:53 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> We avoid calling into nf_conntrack_in() for expected connections, as >> that would remove the expectation that we want to stick around until >> we are ready

Re: [PATCH net-next 3/7] openvswitch: Do not trigger events for unconfirmed connection.

2017-02-07 Thread Jarno Rajahalme
Thanks for the review! Comments below, Jarno > On Feb 6, 2017, at 1:46 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> Avoid triggering change events for setting conntrack mark or labels >> before the conntrack entry has been

Re: [PATCH net-next 5/7] openvswitch: Add original direction conntrack tuple to sw_flow_key.

2017-02-07 Thread Jarno Rajahalme
> On Feb 6, 2017, at 11:15 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> Add the fields of the conntrack original direction 5-tuple to struct >> sw_flow_key. The new fields are initially zeroed, and are populated >> whenever a

Re: [PATCH net-next 1/7] openvswitch: Use inverted tuple in ovs_ct_find_existing() if NATted.

2017-02-07 Thread Jarno Rajahalme
> On Feb 6, 2017, at 9:07 AM, Pravin Shelar wrote: > > On Thu, Feb 2, 2017 at 5:10 PM, Jarno Rajahalme wrote: >> When looking for an existing conntrack entry, the packet 5-tuple >> must be inverted if NAT has already been applied, as the current >> packet

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 09:00:05PM +, Hefty, Sean wrote: > > I didn't read patches yet, and prefer to ask it in advance. Does this > > new ULP work with all > > drivers/infiniband/hw/* devices as it is expected from ULP? > > Like the way ipoib or srp work with all hw devices? What is the real

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Richard Cochran
On Tue, Feb 07, 2017 at 05:52:52PM -0800, Denny Page wrote: > Most, but not all. The TI DP83630 doesn’t support timestamping for all > packets, but it does support either PTP or NTP: That is the one and only device that explicitly supports NTP. This is a nice idea, of course, but it just did not

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Leon Romanovsky
On Tue, Feb 07, 2017 at 01:43:03PM -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 01:00:05PM -0800, Hefty, Sean wrote: > > > I didn't read patches yet, and prefer to ask it in advance. Does this > > > new ULP work with all > > > drivers/infiniband/hw/* devices as it is expected

Re: [PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Nicholas A. Bellinger
Hi Florian, On Tue, 2017-02-07 at 15:03 -0800, Florian Fainelli wrote: > From: Russell King > > drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration > of function 'try_module_get' [-Werror=implicit-function-declaration] > > Add

RE: [RFC v3 09/11] IB/hfi1: HFI_VNIC RDMA netdev support

2017-02-07 Thread Parav Pandit
Hi, > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > Sent: Tuesday, February 7, 2017 2:23 PM > To: dledf...@redhat.com > Cc: linux-r...@vger.kernel.org; netdev@vger.kernel.org; >

Re: [PATCH v2 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread kbuild test robot
Hi Stefan, [auto build test WARNING on net-next/master] [also build test WARNING on v4.10-rc7] [cannot apply to next-20170207] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Stefan-Br-ns

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Denny Page
[Resend without rich text] On Feb 07, 2017, at 12:17, sdncurious wrote: > If the NTP has access to the physical layer, then the timestamps are >associated with the beginning of the symbol after the start of frame. >Otherwise, implementations should attempt to

Re: [PATCH] net: fix description of skb_find_text() according to removed functionality

2017-02-07 Thread David Miller
How about you make edits to this interface when you add an in-tree user as we mentioned in our responses to your previous patch? Thank you.

Re: [PATCH v2 1/5] bpf: Add missing header to the library

2017-02-07 Thread Wangnan (F)
Please add me into the cc list of all of the 5 patches. Thank you. On 2017/2/7 4:40, Mickaël Salaün wrote: Include stddef.h to define size_t. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel

Re: [PATCH v3 1/5] bpf: Add missing header to the library

2017-02-07 Thread Wangnan (F)
On 2017/2/8 4:56, Mickaël Salaün wrote: Include stddef.h to define size_t. Signed-off-by: Mickaël Salaün Cc: Alexei Starovoitov Cc: Arnaldo Carvalho de Melo Cc: Daniel Borkmann Cc: Wang Nan ---

[PATCH] net: fix description of skb_find_text() according to removed functionality

2017-02-07 Thread Igor Pylypiv
Textsearch state parameter was moved to local scope of the function. This eliminates usage of textsearch_next() to find subsequent occurrences. Fixes: 59a2440fd3cf ("net: Remove state argument from skb_find_text()") Signed-off-by: Igor Pylypiv --- net/core/skbuff.c | 5

Re: [PATCH v3 2/5] bpf: Simplify bpf_load_program() error handling in the library

2017-02-07 Thread Wangnan (F)
On 2017/2/8 4:56, Mickaël Salaün wrote: Do not call a second time bpf(2) when a program load failed. BPF_PROG_LOAD should success most of the time. Setting log_level to 0 by default and require log buffer when failure can make it faster in normal case. Thank you. Signed-off-by: Mickaël

Re: [PATCH net-next 6/7] openvswitch: Add force commit.

2017-02-07 Thread Joe Stringer
On 7 February 2017 at 17:03, Jarno Rajahalme wrote: > > On Feb 7, 2017, at 2:15 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: > > Stateful network admission policy may allow connections to one > direction and reject

[PATCH v3 0/2] Fixes for sierra_net driver

2017-02-07 Thread Stefan Brüns
When trying to initiate a dual-stack (ipv4v6) connection, a MC7710, FW version SWI9200X_03.05.24.00ap answers with an unsupported LSI. Add support for this LSI. Also the link_type should be ignored when going idle, otherwise the modem is stuck in a bad link state. Tested on MC7710, T-Mobile DE,

[PATCH v3 1/2] sierra_net: Add support for IPv6 and Dual-Stack Link Sense Indications

2017-02-07 Thread Stefan Brüns
If a context is configured as dualstack ("IPv4v6"), the modem indicates the context activation with a slightly different indication message. The dual-stack indication omits the link_type (IPv4/v6) and adds additional address fields. IPv6 LSIs are identical to IPv4 LSIs, but have a different link

[PATCH v3 2/2] sierra_net: Skip validating irrelevant fields for IDLE LSIs

2017-02-07 Thread Stefan Brüns
When the context is deactivated, the link_type is set to 0xff, which triggers a warning message, and results in a wrong link status, as the LSI is ignored. Signed-off-by: Stefan Brüns --- drivers/net/usb/sierra_net.c | 14 +++--- 1 file changed, 7

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Denny Page
[Resend without rich text] > On Feb 07, 2017, at 09:45, Keller, Jacob E wrote: > > The main problem here is that most hardware that *can't* timestamp all > packets is pretty limited to timestamping only PTP frames. Most, but not all. The TI DP83630 doesn’t support

linux-next: manual merge of the kspp tree with the net-next tree

2017-02-07 Thread Stephen Rothwell
Hi Kees, Today's linux-next merge of the kspp tree got a conflict in: arch/Kconfig between commit: 1a8b6d76dc5b ("net:add one common config ARCH_WANT_RELAX_ORDER to support relax ordering") from the net-next tree and commits: ad21fc4faa2a ("arch: Move CONFIG_DEBUG_RODATA and

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Vishwanathapura, Niranjana
On Wed, Feb 08, 2017 at 12:43:40AM +, Parav Pandit wrote: @@ -2096,6 +2114,15 @@ struct ib_device { struct ib_rwq_ind_table_init_attr *init_attr, struct ib_udata *udata);

Re: [PATCH net-next 7/7] openvswitch: Pack struct sw_flow_key.

2017-02-07 Thread Jarno Rajahalme
> On Feb 6, 2017, at 11:15 PM, Joe Stringer wrote: > > On 2 February 2017 at 17:10, Jarno Rajahalme wrote: >> struct sw_flow_key has two 16-bit holes. Move the most matched >> conntrack match fields there. In some typical cases this reduces the >> size of the key

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Bart Van Assche
On Tue, 2017-02-07 at 16:54 -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: > > On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: > > > This is Ethernet - not IP - encapsulation over a non-InfiniBand > > > device/protocol. > > > >

[PATCHv2 net-next 0/2] mv88e6xxx Watchdog support

2017-02-07 Thread Andrew Lunn
The Marvell switches have an in built watchdog over some of the internal state machine. The watchdog can be configured to raise an interrupt on error. The problem the watchdog found is then logged to the kernel log. The older switches can automagically perform a software reset when the watchdog

[PATCH] net: dsa: mv88e6xxx: Move forward declaration to where it is needed

2017-02-07 Thread Andrew Lunn
Move it out from the middle for the #defines to just before it is needed. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/mv88e6xxx.h

Re: [PATCH 3/3] rhashtable: Add nested tables

2017-02-07 Thread Herbert Xu
On Tue, Feb 07, 2017 at 07:02:16PM +0100, Florian Westphal wrote: > > I can't really say anything here because *I* don't expect > it to succeed. Think about incoming TCP connections, you can't rate-limit that without defeating yourself. > Even with this proposed patch things will eventually fail

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 03:19:25PM -0700, Jason Gunthorpe wrote: On Tue, Feb 07, 2017 at 02:06:30PM -0800, Vishwanathapura, Niranjana wrote: >>IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34), >>+ IB_DEVICE_RDMA_NETDEV_HFI_VNIC = (1ULL << 35), > >What is this

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

2017-02-07 Thread Vishwanathapura, Niranjana
On Tue, Feb 07, 2017 at 09:58:50PM +, Bart Van Assche wrote: On Tue, 2017-02-07 at 21:44 +, Hefty, Sean wrote: This is Ethernet - not IP - encapsulation over a non-InfiniBand device/protocol. That's more than clear from the cover letter. In my opinion the cover letter should explain

RE: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Parav Pandit
Hi > -Original Message- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Vishwanathapura, Niranjana > Sent: Tuesday, February 7, 2017 2:23 PM > To: dledf...@redhat.com > Cc: linux-r...@vger.kernel.org; netdev@vger.kernel.org; >

[PATCHv2 net-next 2/2] net: dsa: mv88e6xxx: Add mv88e6390 watchdog interrupt support

2017-02-07 Thread Andrew Lunn
Implement the ops needed to support the watchdog for the MV88E6390 family. Signed-off-by: Andrew Lunn --- v2 Completely new. drivers/net/dsa/mv88e6xxx/chip.c | 7 + drivers/net/dsa/mv88e6xxx/global2.c | 48 +++

[PATCHv2 net-next 1/2] net: dsa: mv88e6xxx: Add watchdog interrupt handler

2017-02-07 Thread Andrew Lunn
The switch contains a watchdog looking for issues with the internal gubbins of the switch. Hook the interrupt the watchdog triggers and log the value of the control register indicating why the watchdog fired. The watchdog can only be cleared with a switch reset, which will destroy the current

[PATCH net-next] bpf, lpm: fix overflows in trie_alloc checks

2017-02-07 Thread Daniel Borkmann
Cap the maximum (total) value size and bail out if larger than KMALLOC_MAX_SIZE as otherwise it doesn't make any sense to proceed further, since we're guaranteed to fail to allocate elements anyway in lpm_trie_node_alloc(); likleyhood of failure is still high for large values, though, similarly as

Re: [PATCH net-next v3 04/11] bpf: Use bpf_load_program() from the library

2017-02-07 Thread Alexei Starovoitov
On 2/7/17 1:44 PM, Mickaël Salaün wrote: - union bpf_attr attr; + union bpf_attr attr = {}; - bzero(, sizeof(attr)); I think somebody mentioned that there are compilers out there that don't do it correctly, hence it was done with explicit bzero. Arnaldo, Wang, do you

[PATCH net-next] bridge: vlan tunnel id info range fill size calc cleanups

2017-02-07 Thread Roopa Prabhu
From: Roopa Prabhu This fixes a bug and cleans up tunnelid range size calculation code by using consistent variable names and checks in size calculation and fill functions. tested for a few cases of vlan-vni range mappings: (output from patched iproute2): $bridge vlan

Re: [iproute PATCH 1/2] testsuite: skip link show test on big endian systems

2017-02-07 Thread Phil Sutter
On Tue, Feb 07, 2017 at 03:12:49PM -0800, Stephen Hemminger wrote: > On Wed, 8 Feb 2017 00:04:21 +0100 > Phil Sutter wrote: > > > Netlink protocol is in host byte order, so the provided binary netlink > > message buffer being in little endian format will cause the test to fail > >

Re: gro_cells: move to net/core/gro_cells.c

2017-02-07 Thread Eric Dumazet
On Tue, 2017-02-07 at 15:37 -0800, Eric Dumazet wrote: > From: Eric Dumazet > > We have many gro cells users, so lets move the code to avoid > duplication. > > This creates a CONFIG_GRO_CELLS option. > > Signed-off-by: Eric Dumazet This is targeting

gro_cells: move to net/core/gro_cells.c

2017-02-07 Thread Eric Dumazet
From: Eric Dumazet We have many gro cells users, so lets move the code to avoid duplication. This creates a CONFIG_GRO_CELLS option. Signed-off-by: Eric Dumazet --- drivers/net/Kconfig |3 + include/net/gro_cells.h | 86

Re: [PATCH v2] xen-netfront: Improve error handling during initialization

2017-02-07 Thread Boris Ostrovsky
On 02/07/2017 09:55 AM, Ross Lagerwall wrote: > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is set to the >

Re: [iproute PATCH 1/2] testsuite: skip link show test on big endian systems

2017-02-07 Thread Stephen Hemminger
On Wed, 8 Feb 2017 00:04:21 +0100 Phil Sutter wrote: > Netlink protocol is in host byte order, so the provided binary netlink > message buffer being in little endian format will cause the test to fail > on big endian systems. > > Signed-off-by: Phil Sutter Maybe

[PATCH net-next v2 02/12] net: cgroups: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King net/core/netprio_cgroup.c:303:16: error: expected declaration specifiers or '...' before string constant MODULE_LICENSE("GPL v2"); ^~~~ Add linux/module.h to fix this. Signed-off-by: Russell King

[PATCH net-next v2 00/12] net: dsa: remove unnecessary phy.h include

2017-02-07 Thread Florian Fainelli
Hi all, Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the declaration of a couple of structures

[PATCH net-next v2 04/12] net: lan78xx: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/usb/lan78xx.c:394:33: sparse: expected ; at end of declaration drivers/net/usb/lan78xx.c:394:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/usb/lan78xx.c:394:33: sparse: got interface

[PATCH net-next v2 03/12] net: macb: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/ethernet/cadence/macb.h:862:33: sparse: expected ; at end of declaration drivers/net/ethernet/cadence/macb.h:862:33: sparse: Expected } at end of struct-union-enum-specifier drivers/net/ethernet/cadence/macb.h:862:33: sparse: got

[PATCH net-next v2 01/12] net: sunrpc: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King Removing linux/phy.h from net/dsa.h reveals a build error in the sunrpc code: net/sunrpc/xprtrdma/svc_rdma_backchannel.c: In function 'xprt_rdma_bc_put': net/sunrpc/xprtrdma/svc_rdma_backchannel.c:277:2: error: implicit declaration of function

[PATCH] net: mellanox: switchx2: use new api ethtool_{get|set}_link_ksettings

2017-02-07 Thread Philippe Reynes
The ethtool api {get|set}_settings is deprecated. We move this driver to new api {get|set}_link_ksettings. As I don't have the hardware, I'd be very pleased if someone may test this patch. Signed-off-by: Philippe Reynes --- drivers/net/ethernet/mellanox/mlxsw/switchx2.c |

[PATCH net-next v2 05/12] net: bgmac: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/ethernet/broadcom/bgmac.c:1015:17: error: dereferencing pointer to incomplete type 'struct mii_bus' drivers/net/ethernet/broadcom/bgmac.c:1185:2: error: implicit declaration of function 'phy_start'

[PATCH net-next v2 09/12] MIPS: Octeon: Remove unnecessary MODULE_*()

2017-02-07 Thread Florian Fainelli
From: Russell King octeon-platform.c can not be built as a module for two reasons: (a) the Makefile doesn't allow it: obj-y := cpu.o setup.o octeon-platform.o octeon-irq.o csrc-octeon.o (b) the multiple *_initcall() statements, each of which are translated

[PATCH net-next v2 11/12] net: ath5k: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King Fix these errors reported by the 0-day builder by replacing the linux/export.h include with linux/module.h. In file included from include/linux/platform_device.h:14:0, from drivers/net/wireless/ath/ath5k/ahb.c:20:

[PATCH net-next v2 08/12] iscsi: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/target/iscsi/iscsi_target_login.c:1135:7: error: implicit declaration of function 'try_module_get' [-Werror=implicit-function-declaration] Add linux/module.h to iscsi_target_login.c. Signed-off-by: Russell King

[PATCH net-next v2 10/12] net: liquidio: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: error: expected declaration specifiers or '...' before string constant drivers/net/ethernet/cavium/liquidio/lio_vf_main.c:30: warning: data definition has no type or storage class

[PATCH net-next v2 07/12] net: mvneta: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/ethernet/marvell/mvneta.c:2694:26: error: storage size of 'status' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:26: error: storage size of 'changed' isn't known drivers/net/ethernet/marvell/mvneta.c:2695:9: error: variable

[PATCH net-next v2 06/12] net: fman: fix build errors when linux/phy*.h is removed from net/dsa.h

2017-02-07 Thread Florian Fainelli
From: Russell King drivers/net/ethernet/freescale/fman/fman_memac.c:519:21: error: dereferencing pointer to incomplete type 'struct fixed_phy_status' Add linux/phy_fixed.h to fman_memac.c Signed-off-by: Russell King ---

[PATCH net-next v2 12/12] net: dsa: remove unnecessary phy*.h includes

2017-02-07 Thread Florian Fainelli
From: Russell King Including phy.h and phy_fixed.h into net/dsa.h causes phy*.h to be an unnecessary dependency for quite a large amount of the kernel. There's very little which actually requires definitions from phy.h in net/dsa.h - the include itself only wants the

[iproute PATCH 2/2] testsuite: Search kernel config in modules dir also

2017-02-07 Thread Phil Sutter
At least in Fedora there is no /proc/config.gz but instead /lib/modules/`uname -r`/config, so use that as a fallback. Signed-off-by: Phil Sutter --- testsuite/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/testsuite/Makefile b/testsuite/Makefile index

[iproute PATCH 1/2] testsuite: skip link show test on big endian systems

2017-02-07 Thread Phil Sutter
Netlink protocol is in host byte order, so the provided binary netlink message buffer being in little endian format will cause the test to fail on big endian systems. Signed-off-by: Phil Sutter --- .gitignore| 1 + testsuite/Makefile

[iproute PATCH 0/2] Two minor testsuite fixes

2017-02-07 Thread Phil Sutter
While playing around with testsuite, I noticed two minor nits which this series attempts to fix. Phil Sutter (2): testsuite: skip link show test on big endian systems testsuite: Search kernel config in modules dir also .gitignore| 1 + testsuite/Makefile

Re: [net-next PATCH 0/4] Documenting eBPF - extended Berkeley Packet Filter

2017-02-07 Thread Daniel Borkmann
On 02/07/2017 10:19 PM, Jesper Dangaard Brouer wrote: On Tue, 07 Feb 2017 17:43:38 +0100 Daniel Borkmann wrote: Hi Jesper, On 02/07/2017 03:30 PM, Jesper Dangaard Brouer wrote: Question: What kernel tree should this go into??? If going through Jonathan Corbet, will it

Re: Extending socket timestamping API for NTP

2017-02-07 Thread Willem de Bruijn
>> 2) new SO_TIMESTAMPING option to receive from the error queue only >>user data as was passed to sendmsg() instead of Ethernet frames >> >>Parsing Ethernet and IP headers (especially IPv6 options) is not >>fun and SOF_TIMESTAMPING_OPT_ID is not always practical, e.g. in >>

Re: netvsc merge conflicts...

2017-02-07 Thread David Miller
From: Stephen Hemminger Date: Tue, 7 Feb 2017 14:17:40 -0800 > On Tue, 07 Feb 2017 16:41:41 -0500 (EST) > David Miller wrote: > >> Stephen, I just did a merge of net into net-next and had to >> resolve a merge conflict in the netvsc driver. >>

Re: [PATCH net-next 6/7] openvswitch: Add force commit.

2017-02-07 Thread Joe Stringer
On 2 February 2017 at 17:10, Jarno Rajahalme wrote: > Stateful network admission policy may allow connections to one > direction and reject connections initiated in the other direction. > After policy change it is possible that for a new connection an > overlapping conntrack entry

Re: [PATCH iproute2] ip route: Make name of protocol 0 consistent

2017-02-07 Thread Stephen Hemminger
On Tue, 7 Feb 2017 14:51:45 -0700 David Ahern wrote: > On 2/7/17 2:40 PM, Stephen Hemminger wrote: > >> Reading the file changes the string in rtnl_rtprot_tab for > >> RTPROT_UNSPEC. Both string values -- "none" and "unspec" come from > >> iproute2, so my point is that

[PATCH v2 net-next 7/9] sunvnet: remove extra rcu_read_unlocks

2017-02-07 Thread Shannon Nelson
The RCU read lock is grabbed first thing in sunvnet_start_xmit_common() so it always needs to be released. This removes the conditional release in the dropped packet error path and removes a couple of superfluous calls in the middle of the code. Reported-by: Bijan Mottahedeh

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

2017-02-07 Thread Jason Gunthorpe
On Tue, Feb 07, 2017 at 02:06:30PM -0800, Vishwanathapura, Niranjana wrote: > >>IB_DEVICE_RAW_SCATTER_FCS = (1ULL << 34), > >>+ IB_DEVICE_RDMA_NETDEV_HFI_VNIC = (1ULL << 35), > > > >What is this called HFI_VNIC anyhow? Shouldn't this be OPA_VNIC? There > >is nothing

[PATCH v2 net-next 2/9] sunvnet: remove unused variable in maybe_tx_wakeup

2017-02-07 Thread Shannon Nelson
From: Sowmini Varadhan The vio_dring_state *dr variable is unused in maybe_tx_wakeup(). As the comments indicate, we call maybe_tx_wakeup() whenever we get a STOPPED LDC message on the port. If the queue is stopped, we want to wake it up so that we will send another

[PATCH v2 net-next 6/9] sunvnet: straighten up message event handling logic

2017-02-07 Thread Shannon Nelson
The use of gotos for handling the incoming events made this code harder to read and support than it should be. This patch straightens out and clears up the logic. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet_common.c | 94

[PATCH v2 net-next 1/9] sunvnet: make sunvnet common code dynamically loadable

2017-02-07 Thread Shannon Nelson
When the sunvnet_common code was split out for use by both sunvnet and the newer ldmvsw, it was made into a static kernel library, which limits the usefulness of sunvnet and ldmvsw as loadables, since most of the real work is being done in the shared code. Also, this is simply dead code in

[PATCH v2 net-next 9/9] ldmvsw: disable tso and gso for bridge operations

2017-02-07 Thread Shannon Nelson
The ldmvsw driver is specifically for supporting the ldom virtual networking by running in the primary ldom and using the LDC to connect the remaining ldoms to the outside world via a bridge. With TSO and GSO supported while connected the bridge, things tend to misbehave as seen in our case by

[PATCH v2 net-next 5/9] sunvnet: add memory barrier before check for tx enable

2017-02-07 Thread Shannon Nelson
In order to allow the underlying LDC and outstanding memory operations to potentially catch up with the driver's Tx requests, add a memory barrier before checking again for available tx descriptors. Signed-off-by: Shannon Nelson ---

[PATCH v2 net-next 4/9] sunvnet: add driver stats for ethtool support

2017-02-07 Thread Shannon Nelson
Since we're collecting some stats in the driver code, let's support use of the ethtool driver stats facility in both sunvnet and ldmvsw. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 63 +

[PATCH v2 net-next 0/9] sunvnet driver updates

2017-02-07 Thread Shannon Nelson
The sunvnet ldom virtual network driver was due for some updates and a bugfix or two. These patches address a few items left over from last year's make-over. v2: - changed memory barrier fix to use smp_wmb - put NETIF_F_SG back into the advertised ldmvsw hw_features Shannon Nelson (8):

Re: netvsc merge conflicts...

2017-02-07 Thread Stephen Hemminger
On Tue, 07 Feb 2017 16:41:41 -0500 (EST) David Miller wrote: > Stephen, I just did a merge of net into net-next and had to > resolve a merge conflict in the netvsc driver. > > The problem was that in 'net' the hyperv bug fix that added > the calls to

[PATCH v2 net-next 8/9] ldmvsw: update and simplify version string

2017-02-07 Thread Shannon Nelson
New version and simplify the print code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/ldmvsw.c | 14 -- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c

[PATCH v2 net-next 3/9] sunvnet: update version and version printing

2017-02-07 Thread Shannon Nelson
There have been several changes since the first version of this code, so we bump the version number. While we're at it, we can simplify the version printing a bit and drop a couple lines of code. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/sun/sunvnet.c |

  1   2   3   4   >