qmi_wwan: Null pointer dereference when removing driver

Unsure at which point was added, but issue not present in stock debian 4.11 kernel. Running on a Thinkpad X220 with coreboot. I'm building from upstream. When I attempt to remove the qmi_wwan module (which also happens pre-suspend) the rmmod process gets killed, and the following shows in

[PATCH V2 net] Revert "vhost: cache used event for better performance"

This reverts commit 809ecb9bca6a9424ccd392d67e368160f8b76c92. Since it was reported to break vhost_net. We want to cache used event and use it to check for notification. The assumption was that guest won't move the event idx back, but this could happen in fact when 16 bit index wraps around after

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

Hi Kurt, On 07/26/2017 03:04 PM, Kurt Van Dijck wrote: > Hi, > > I know my response is late ... > >> Hi Oliver >> On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: >>> Hi Franklin, >>> >>> On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: >>> +#ifdef CONFIG_OF +void

RE: [PATCH V2 net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission

> -Original Message- > From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com] > Sent: Wednesday, July 26, 2017 6:03 PM > To: maowenan; netdev@vger.kernel.org; da...@davemloft.net; > ncardw...@google.com; ych...@google.com; nandi...@google.com; > weiyongjun (A); Chenweilong;

RE: [PATCH net-next] TLP: Don't reschedule PTO when there's one outstanding TLP retransmission.

> -Original Message- > From: Yuchung Cheng [mailto:ych...@google.com] > Sent: Thursday, July 27, 2017 12:45 AM > To: maowenan > Cc: Neal Cardwell; Netdev; David Miller; weiyongjun (A); Chenweilong; Nandita > Dukkipati; Wangkefeng (Kevin) > Subject: Re: [PATCH net-next] TLP: Don't

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

On 2017/7/27 2:26, Casey Leedom wrote: > By the way Ding, two issues: > > 1. Did we ever get any acknowledgement from either Intel or AMD > on this patch? I know that we can't ensure that, but it sure would > be nice since the PCI Quirks that we're putting in affect their >

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

On 2017/7/27 3:05, Casey Leedom wrote: > | From: Alexander Duyck > | Sent: Wednesday, July 26, 2017 11:44 AM > | > | On Jul 26, 2017 11:26 AM, "Casey Leedom" wrote: > | | > | | I think that the patch will need to be extended to modify > | |

Re: [PATCH v3 net-next] net: systemport: Support 64bit statistics

On 07/26/2017 05:40 PM, Jianming.qiao wrote: > When using Broadcom Systemport device in 32bit Platform, ifconfig can > only report up to 4G tx,rx status, which will be wrapped to 0 when the > number of incoming or outgoing packets exceeds 4G, only taking > around 2 hours in busy network

[PATCH v3 net-next] net: systemport: Support 64bit statistics

When using Broadcom Systemport device in 32bit Platform, ifconfig can only report up to 4G tx,rx status, which will be wrapped to 0 when the number of incoming or outgoing packets exceeds 4G, only taking around 2 hours in busy network environment (such as streaming). Therefore, it makes hard for

Re: [PATCH] bpf: testing: fix devmap tests

On 07/27/2017 02:32 AM, John Fastabend wrote: Apparently through one of my revisions of the initial patches series I lost the devmap test. We can add more testing later but for now lets fix the simple one we have. Fixes: 546ac1ffb70d "bpf: add devmap, a map for storing net device references"

RE: [Intel-wired-lan] [PATCH] igb: support BCM54616 PHY

> From: Intel-wired-lan [mailto:intel-wired-lan-boun...@osuosl.org] On Behalf > Of John W. Linville > Sent: Friday, July 21, 2017 11:12 AM > To: netdev@vger.kernel.org > Cc: intel-wired-...@lists.osuosl.org; John W. Linville > > Subject: [Intel-wired-lan] [PATCH] igb:

Re: [PATCH] bpf: testing: fix devmap tests

On 07/26/2017 05:32 PM, John Fastabend wrote: > Apparently through one of my revisions of the initial patches > series I lost the devmap test. We can add more testing later but > for now lets fix the simple one we have. > > Fixes: 546ac1ffb70d "bpf: add devmap, a map for storing net device

[PATCH] bpf: testing: fix devmap tests

Apparently through one of my revisions of the initial patches series I lost the devmap test. We can add more testing later but for now lets fix the simple one we have. Fixes: 546ac1ffb70d "bpf: add devmap, a map for storing net device references" Reported-by: Jakub Kicinski

Re: [PATCH net-next v2 07/10] net: dsa: lan9303: Added basic offloading of unicast traffic

Hi Egil, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Egil-Hjelmeland/net-dsa-lan9303-unicast-offload-fdb-mdb-STP/20170727-074246 config: x86_64-randconfig-x000-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901

Re: [PATCH net] bpf: don't zero out the info struct in bpf_obj_get_info_by_fd()

From: Jakub Kicinski Date: Tue, 25 Jul 2017 15:16:12 -0700 > The buffer passed to bpf_obj_get_info_by_fd() should be initialized > to zeros. Kernel will enforce that to guarantee we can safely extend > info structures in the future. > > Making the

Re: [PATCH] netpoll: Fix device name check in netpoll_setup()

From: Matthias Kaehlcke Date: Tue, 25 Jul 2017 11:36:25 -0700 > Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer > when checking if the device name is set: > > if (np->dev_name) { > ... > > However the field is a character array, therefore the

Re: [net-next 00/14][pull request] 40GbE Intel Wired LAN Driver Updates 2017-07-25

From: Jeff Kirsher Date: Wed, 26 Jul 2017 03:31:09 -0700 > This series contains updates to i40e and i40evf only. > > Gustavo Silva fixes a variable assignment, where the incorrect variable > was being used to store the error parameter. > > Carolyn provides a fix

[PATCH net-next v2 00/10] netvsc fixes and new features

This series has updates for Hyper-V network driver. The first four patches are just minor fixes. The next group of patches aims to reduce the driver memory footprint by reducing the size of the per-device receive and send buffers, and the per-channel receive completion queue. The biggest change

[PATCH net-next v2 09/10] netvsc: add documentation

Add some background documentation on netvsc device options and limitations. Signed-off-by: Stephen Hemminger --- Documentation/networking/netvsc.txt | 50 + MAINTAINERS | 1 + 2 files changed, 51 insertions(+)

[PATCH net-next v2 10/10] netvsc: remove bonding setup script

No longer needed, now all managed by transparent VF logic. Signed-off-by: Stephen Hemminger --- tools/hv/bondvf.sh | 255 - 1 file changed, 255 deletions(-) delete mode 100755 tools/hv/bondvf.sh diff --git

[PATCH net-next v2 02/10] netvsc: fix warnings reported by lockdep

This includes a bunch of fixups for issues reported by lockdep. * ethtool routines can assume RTNL * send is done with RCU lock (and BH disable) * avoid refetching internal device struct (netvsc) instead pass it as a parameter. Signed-off-by: Stephen Hemminger

[PATCH net-next v2 04/10] netvsc: remove unnecessary indirection of page_buffer

The internal API was passing struct hv_page_buffer ** when only simple struct hv_page_buffer * was necessary for passing an array. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/hyperv_net.h | 2 +- drivers/net/hyperv/netvsc.c | 21 ++---

[PATCH net-next v2 07/10] netvsc: allow smaller send/recv buffer size

The default value of send and receive buffer area for host DMA is much larger than it needs to be. Experimentation shows that 4M receive and 1M send is sufficient. Make the size a module parameter so that it can be adjusted as needed for testing or special needs. Signed-off-by: Stephen Hemminger

[PATCH net-next v2 06/10] netvsc: signal host if receive ring is emptied

Latency improvement related to NAPI conversion. If all packets are processed from receive ring then need to signal host. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH net-next v2 05/10] netvsc: optimize receive completions

Optimize how receive completion ring are managed. * Allocate only as many slots as needed for all buffers from host * Allocate before setting up sub channel for better error detection * Don't need to keep copy of initial receive section message * Precompute the watermark for when

[PATCH net-next v2 08/10] netvsc: transparent VF management

This patch implements transparent fail over from synthetic NIC to SR-IOV virtual function NIC in Hyper-V environment. It is a better alternative to using bonding as is done now. Instead, the receive and transmit fail over is done internally inside the driver. Using bonding driver has lots of

[PATCH net-next v2 03/10] netvsc: don't print pointer value in error message

Using %p to print pointer to packet meta-data doesn't give any good info, and exposes kernel memory offsets. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH net-next v2 01/10] netvsc: fix return value for set_channels

The error and normal case got swapped. Signed-off-by: Stephen Hemminger --- drivers/net/hyperv/netvsc_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c index

Re: [net-next v4 0/5][pull request] 10GbE Intel Wired LAN Driver Updates 2017-07-25

From: Jeff Kirsher Date: Tue, 25 Jul 2017 16:41:33 -0700 > This series contains updates to ixgbe only. > > Tony provides all of the changes in the series, starting with adding a > check to ensure that adding a MAC filter was successful, before setting the > MACVLAN.

Re: [PATCH] net: inet: diag: expose sockets cgroup classid

On Wed, Jul 26, 2017 at 03:01:32PM -0700, Cong Wang wrote: >On Wed, Jul 26, 2017 at 10:22 AM, Levin, Alexander (Sasha Levin) > wrote: >> + if (ext & (1 << (INET_DIAG_CLASS_ID - 1))) { >> + u32 classid = 0; >> + >> +#ifdef CONFIG_SOCK_CGROUP_DATA >>

Re: [PATCH RFC 02/13] net: phy: split out PHY speed and duplex string generation

On 07/25/2017 07:02 AM, Russell King wrote: > Other code would like to make use of this, so make the speed and duplex > string generation visible, and place it in a separate file. > > Signed-off-by: Russell King Reviewed-by: Florian Fainelli --

Re: [PATCH RFC 01/13] net: phy: allow settings table to support more than 32 link modes

On 07/25/2017 07:02 AM, Russell King wrote: > Allow the phy settings table to support more than 32 link modes by > switching to the ethtool link mode bit number representation, rather > than storing the mask. This will allow phylink and other ethtool > code to share the settings table to look up

Re: [PATCH RFC 07/13] net: phy: add I2C mdio bus

On 07/25/2017 07:03 AM, Russell King wrote: > Add an I2C MDIO bus bridge library, to allow phylib to access PHYs which > are connected to an I2C bus instead of the more conventional MDIO bus. > Such PHYs can be found in SFP adapters and SFF modules. > > Since PHYs appear at I2C bus address

Re: [PATCH V2 net-next 20/21] net-next/hinic: Add ethtool and stats

On Wed, Jul 19, 2017 at 03:36:28PM +0300, Aviad Krawczyk wrote: > Hi Joe, > > I tried to be consistent with the comments before, that requested > that we will use dev_err exclude some special cases for use netif. > > We will replace the dev_err(>dev,.. to netdev_err in the > next fix.

Re: [PATCH RFC 12/13] phylink: add in-band autonegotiation support for 10GBase-KR mode.

On Tue, Jul 25, 2017 at 03:03:34PM +0100, Russell King wrote: > Add in-band autonegotation support for 10GBase-KR mode. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn Andrew

[Patch net v2] team: use a larger struct for mac address

IPv6 tunnels use sizeof(struct in6_addr) as dev->addr_len, but in many places especially bonding, we use struct sockaddr to copy and set mac addr, this could lead to stack out-of-bounds access. Fix it by using a larger address storage like bonding. Reported-by: Andrey Konovalov

[Patch net v2] net: check dev->addr_len for dev_set_mac_address()

Historically, dev_ifsioc() uses struct sockaddr as mac address definition, this is why dev_set_mac_address() accepts a struct sockaddr pointer as input but now we have various types of mac addresse whose lengths are up to MAX_ADDR_LEN, longer than struct sockaddr, and saved in dev->addr_len. It

Re: [PATCH RFC 07/13] net: phy: add I2C mdio bus

On Tue, Jul 25, 2017 at 03:03:08PM +0100, Russell King wrote: > Add an I2C MDIO bus bridge library, to allow phylib to access PHYs which > are connected to an I2C bus instead of the more conventional MDIO bus. > Such PHYs can be found in SFP adapters and SFF modules. > > Since PHYs appear at I2C

Re: [PATCH RFC 03/13] net: phy: move phy_lookup_setting() and guts of phy_supported_speeds() to phy-core

On Tue, Jul 25, 2017 at 03:02:47PM +0100, Russell King wrote: > phy_lookup_setting() provides useful functionality in ethtool code > outside phylib. Move it to phy-core and allow it to be re-used (eg, > in phylink) rather than duplicated elsewhere. Note that this supports > the larger linkmode

[PATCH v3 1/3] ptp: introduce ptp auxiliary worker

Many PTP drivers required to perform some asynchronous or periodic work, like periodically handling PHC counter overflow or handle delayed timestamp for RX/TX network packets. In most of the cases, such work is implemented using workqueues. Unfortunately, Kernel workqueues might introduce

[PATCH v3 0/3] net: ethernet: ti: cpts: fix tx timestamping timeout

Hi With the low Ethernet connection speed cpdma notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast

[PATCH v3 3/3] net: ethernet: ti: cpts: fix tx timestamping timeout

With the low speed Ethernet connection CPDMA notification about packet processing can be received before CPTS TX timestamp event, which is set when packet actually left CPSW while cpdma notification is sent when packet pushed in CPSW fifo. As result, when connection is slow and CPU is fast enough

[PATCH v4 2/3] net: ethernet: ti: cpts: convert to use ptp auxiliary worker

There could be significant delay in CPTS work schedule under high system load and on -RT which could cause CPTS misbehavior due to internal counter overflow. Usage of own kthread_worker allows to avoid such kind of issues and makes it possible to tune priority of CPTS kthread_worker thread on -RT.

Re: [PATCH] net: inet: diag: expose sockets cgroup classid

On Wed, Jul 26, 2017 at 10:22 AM, Levin, Alexander (Sasha Levin) wrote: > + if (ext & (1 << (INET_DIAG_CLASS_ID - 1))) { > + u32 classid = 0; > + > +#ifdef CONFIG_SOCK_CGROUP_DATA > + classid = sock_cgroup_classid(>sk_cgrp_data); >

Re: [PATCH RFC 04/13] net: phy: add 1000Base-X to phy settings table

On Tue, Jul 25, 2017 at 03:02:52PM +0100, Russell King wrote: > Add the missing 1000Base-X entry to the phy settings table. This was > not included because the original code could not cope with more than > 32 bits of link mode mask. > > Signed-off-by: Russell King

Re: [PATCH RFC 02/13] net: phy: split out PHY speed and duplex string generation

On Tue, Jul 25, 2017 at 03:02:42PM +0100, Russell King wrote: > Other code would like to make use of this, so make the speed and duplex > string generation visible, and place it in a separate file. > > Signed-off-by: Russell King Reviewed-by: Andrew Lunn

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

> Good. Just one question about process. Could I have posted my work > as a RFC? To get one round of initial feedback before chopping into > small patch requests. As well as indicating where I am heading. Or is > that just waste of human bandwidth? Depends. Post 100 RFC patches, i won't look at

Re: [PATCH] netpoll: Fix device name check in netpoll_setup()

On Wed, Jul 26, 2017 at 11:44 AM, Doug Anderson wrote: > Hi, > > On Tue, Jul 25, 2017 at 11:36 AM, Matthias Kaehlcke wrote: >> Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer >> when checking if the device name is set: >> >> if

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

Den 26. juli 2017 22:07, skrev David Miller: From: Andrew Lunn Date: Wed, 26 Jul 2017 19:52:24 +0200 So I really want to group the patches into only a few series in order to not spend months on the process. I strongly agree with Vivien here. Good patches get accepted in

Re: [PATCH net-next v2] bpf: install libbpf headers on 'make install'

From: Jakub Kicinski Date: Tue, 25 Jul 2017 11:17:11 -0700 > Add a new target to install the bpf.h header to $(prefix)/include/bpf/ > directory. This is necessary to build standalone applications using > libbpf, without the need to clone the kernel sources and

Re: [Patch net] bonding: commit link status change after propose

From: Cong Wang Date: Tue, 25 Jul 2017 09:44:25 -0700 > Commit de77ecd4ef02 ("bonding: improve link-status update in mii-monitoring") > moves link status commitment into bond_mii_monitor(), but it still relies > on the return value of bond_miimon_inspect() as the hint.

Re: [PATCH 0/8] net: mvpp2: add TX interrupts support

From: Thomas Petazzoni Date: Tue, 25 Jul 2017 17:55:01 +0200 > Hello, > > So far, the mvpp2 driver was using an hrtimer to handle TX > completion. This patch series adds support for using TX interrupts > (for each CPU) on PPv2.2, the variant of the IP used

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Wed, 26 Jul 2017 12:23:17 +0300, Or Gerlitz wrote: > On Wed, Jul 26, 2017 at 11:13 AM, Jakub Kicinski wrote: > > On Wed, 26 Jul 2017 07:48:40 +0200, Jiri Pirko wrote: > > >> I think it would make sense if the driver would just fill-up a struct in > >> the ndo call and core

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

From: Andrew Lunn Date: Wed, 26 Jul 2017 19:52:24 +0200 >> > So I really want to group the patches into only a few series in order >> > to not spend months on the process. > > I strongly agree with Vivien here. Good patches get accepted in about > 3 days. You should expect

Re: [PATCH 1/4] can: dev: Add support for limiting configured bitrate

Hi, I know my response is late ... > Hi Oliver > On 07/20/2017 02:43 AM, Oliver Hartkopp wrote: > > Hi Franklin, > > > > On 07/20/2017 01:36 AM, Franklin S Cooper Jr wrote: > > > >> +#ifdef CONFIG_OF > >> +void of_transceiver_is_fixed(struct net_device *dev) > >> +{ > > > > (..) > > > >> +}

Re: [PATCH net] net: phy: Run state machine to completion

On 07/26/2017 12:34 PM, Florian Fainelli wrote: > On 07/26/2017 12:24 PM, Florian Fainelli wrote: >> Marc reported that he was not getting the PHY library adjust_link() >> callback function to run when calling phy_stop() + phy_disconnect() >> which does not indeed happen because we don't make sure

Re: [PATCH net-next 10/18] net: mvpp2: use the GoP interrupt for link status changes

On Wed, Jul 26, 2017 at 06:26:48PM +0200, Andrew Lunn wrote: > And this is another bit of code you probably need to change in a while > with phylink lands. The way the MAC driver handles link up/down and configuration events changes significantly when a MAC driver switches to phylink, since a

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 12:00 PM, David Ahern wrote: > On 7/26/17 12:55 PM, Roopa Prabhu wrote: >> On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: >>> On 7/26/17 12:27 PM, Roopa Prabhu wrote: agreed...so looks like the check in v3 should be

Re: [PATCH net] net: phy: Run state machine to completion

On 07/26/2017 12:24 PM, Florian Fainelli wrote: > Marc reported that he was not getting the PHY library adjust_link() > callback function to run when calling phy_stop() + phy_disconnect() > which does not indeed happen because we don't make sure we flush the > PHYLIB delayed work and let it run to

Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

On Tue, 2017-07-25 at 18:56 +0200, crow wrote: > Hi, > Today I did test on ArchLinuxArm the Kernel v4.13-rc2. On downloading > the linux git source the network will eventually get stalled. Here are > the information > > Over SSH (network works). > > [root@alarm ~]# uname -a > Linux alarm

Re: ARM GLX Khadas VIM Pro - Ethernet detected as only 10Mbps and stalled after some traffic

On Sun, 2017-06-11 at 08:31 +0200, crow wrote: > Hi Andrew, > > On Sat, Jun 10, 2017 at 5:27 PM, Andrew Lunn wrote: > > > Also what Martin Blumenstingl wrote is following which is also crucial > > > for fixing the issue: > > > Amlogic has given their ethernet PHY driver some

[PATCH net] net: phy: Run state machine to completion

Marc reported that he was not getting the PHY library adjust_link() callback function to run when calling phy_stop() + phy_disconnect() which does not indeed happen because we don't make sure we flush the PHYLIB delayed work and let it run to completion. We also need to have a synchronous call to

Re: [PATCH net-next] net: phy: Remove stale comments referencing timer

On Wed, Jul 26, 2017 at 12:05:38PM -0700, Florian Fainelli wrote: > Since commit a390d1f379cf ("phylib: convert state_queue work to > delayed_work"), the PHYLIB state machine was converted to use delayed > workqueues, yet some functions were still referencing the PHY library > timer in their

[PATCH v3 net-next 2/2] liquidio: cleanup: removed cryptic and misleading macro

From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_console.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff

[PATCH v3 net-next 1/2] liquidio: standardization: use min_t instead of custom macro

From: Rick Farrington Signed-off-by: Rick Farrington Signed-off-by: Derek Chickles Signed-off-by: Felix Manlunas --- drivers/net/ethernet/cavium/liquidio/octeon_console.c | 3

[PATCH v3 net-next 0/2] liquidio: standardization and cleanup

From: Rick Farrington This patchset corrects some non-standard macro usage. 1. Replaced custom MIN macro with use of standard 'min_t'. 2. Removed cryptic and misleading macro 'CAST_ULL'. change log: V1 -> V2: 1. Add driver cleanup of macro 'CAST_ULL'. V2 -> V3:

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

| From: Alexander Duyck | Sent: Wednesday, July 26, 2017 11:44 AM | | On Jul 26, 2017 11:26 AM, "Casey Leedom" wrote: | | | |     I think that the patch will need to be extended to modify | |     drivers/pci.c/iov.c:sriov_enable() to explicitly

[PATCH net-next] net: phy: Remove stale comments referencing timer

Since commit a390d1f379cf ("phylib: convert state_queue work to delayed_work"), the PHYLIB state machine was converted to use delayed workqueues, yet some functions were still referencing the PHY library timer in their comments, fix that and remove the now unused linux/timer.h include.

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 2:38 PM, Neal Cardwell wrote: > Yeah, it looks like I can reproduce this issue with (1) bad sacks > causing repeated TLPs, and (2) TLPs timers being pushed out to later > times due to incoming data. Scripts are attached. I'm testing a fix of only

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On 7/26/17 12:55 PM, Roopa Prabhu wrote: > On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: >> On 7/26/17 12:27 PM, Roopa Prabhu wrote: >>> agreed...so looks like the check in v3 should be >>> >>> >>> + if ( rt == net->ipv6.ip6_null_entry || >>> +

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 11:49 AM, David Ahern wrote: > On 7/26/17 12:27 PM, Roopa Prabhu wrote: >> agreed...so looks like the check in v3 should be >> >> >> + if ( rt == net->ipv6.ip6_null_entry || >> +(rt->dst.error && >> + #ifdef CONFIG_IPV6_MULTIPLE_TABLES

Re: [PATCH] netpoll: Fix device name check in netpoll_setup()

Hi, On Tue, Jul 25, 2017 at 11:36 AM, Matthias Kaehlcke wrote: > Apparently netpoll_setup() assumes that netpoll.dev_name is a pointer > when checking if the device name is set: > > if (np->dev_name) { > ... > > However the field is a character array, therefore the condition

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On 7/26/17 12:27 PM, Roopa Prabhu wrote: > agreed...so looks like the check in v3 should be > > > + if ( rt == net->ipv6.ip6_null_entry || > +(rt->dst.error && > + #ifdef CONFIG_IPV6_MULTIPLE_TABLES > + rt != net->ipv6.ip6_prohibit_entry && > + rt !=

Re: [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

On 7/26/17 11:09 AM, David Ahern wrote: > I don't understand why you are focused on the built-in null and prohibit > route entries. I see. You are using fib rules for the prohibit entry; I am using an explicit route entry. If I run 'ip ro get fibmatch' for the latter I want to see that route

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 1:06 PM, Neal Cardwell wrote: > On Wed, Jul 26, 2017 at 12:43 PM, Neal Cardwell wrote: >> (2) It looks like there is a bug in the sender code where it seems to >> be repeatedly using a TLP timer firing 211ms after every ACK is

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

On 07/26/2017 12:05 PM, Oliver Hartkopp wrote: > On 07/26/2017 06:41 PM, Andrew Lunn wrote: >> On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: > >>> + >>> +Optional: >>> + max-arbitration-speed: a positive non 0 value that determines the max >>> +speed that CAN

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On Wed, Jul 26, 2017 at 10:18 AM, David Ahern wrote: > On 7/25/17 1:32 AM, Hangbin Liu wrote: >> On Mon, Jul 24, 2017 at 09:28:07PM -0600, David Ahern wrote: >>> On 7/24/17 6:08 PM, Hangbin Liu wrote: That's why I think we should remove both rt->dst.error and

Re: [PATCH v7 2/3] PCI: Enable PCIe Relaxed Ordering if supported

By the way Ding, two issues: 1. Did we ever get any acknowledgement from either Intel or AMD on this patch? I know that we can't ensure that, but it sure would be nice since the PCI Quirks that we're putting in affect their products. 2. I just realized that there's still a small

Re: [PATCH 0/4] Configuring traffic classes via new hardware offload mechanism in tc/mqprio

On 7/21/2017 2:42 AM, Richard Cochran wrote: On Mon, May 22, 2017 at 12:31:12PM -0700, Jeff Kirsher wrote: On Fri, 2017-05-19 at 17:58 -0700, Amritha Nambiar wrote: The following series introduces a new harware offload mode in tc/mqprio where the TCs, the queue configurations and bandwidth

[PATCH net-next 3/3] nfp: only use direct firmware requests

request_firmware() will fallback to user space helper and may cause long delays when driver is loaded if udev doesn't correctly handle FW requests. Since we never really made use of the user space helper functionality switch to the simpler request_firmware_direct() call. The side effect of this

[PATCH net-next 1/3] nfp: remove the probe deferral when FW not present

We use a hack to defer probe when firmware was not pre-loaded or found on disk. This helps in case users forgot to include firmware in initramfs, the driver will most likely get another shot at probing after real root is mounted. This is not for what EPROBE_DEFER is supposed to be used, and when

[PATCH net-next 2/3] nfp: look for firmware image by device serial number and PCI name

We generally look up firmware by card type, but that doesn't allow users who have more than one card of the same type in their system to select firmware per adapter. Unfortunately user space firmware helper seems fraught with difficulties and to be on its way out. In particular support for

[PATCH net-next 0/3] nfp: extend firmware request logic

Hi! We have been pondering for some time how to support loading different application firmwares onto NFP. We want to support both users selecting one of the firmware images provided by Netronome (which are optimized for different use cases each) as well as firmware images created by users

Re: [PATCH RFC 00/13] phylink and sfp support

On Wed, Jul 26, 2017 at 06:44:11PM +0200, Andrew Lunn wrote: > Do you have a git branch we can look at to see these changes. It helps > understand the API when you can see both sides of it. git://git.armlinux.org.uk/~rmk/linux-arm.git phy or head to the cgit at:

Re: [RFC] switchdev: clarify ndo_get_phys_port_name() formats

On Tue, Jul 25, 2017 at 07:34:47PM -0700, Jakub Kicinski wrote: > On Tue, 25 Jul 2017 21:48:15 -0400, Andy Gospodarek wrote: > > On Tue, Jul 25, 2017 at 03:26:47PM -0700, Jakub Kicinski wrote: > > > On Tue, 25 Jul 2017 11:22:41 -0400, Andy Gospodarek wrote: > > > > On Mon, Jul 24, 2017 at

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

> > So I really want to group the patches into only a few series in order > > to not spend months on the process. I strongly agree with Vivien here. Good patches get accepted in about 3 days. You should expect feedback within a day or two. That allows you to have fast cycle times for getting

Re: [PATCH net-next v2 08/10] net: dsa: lan9303: Added ALR/fdb/mdb handling

Hi Egil > +/* This function will wait a while until mask & reg == value */ > +/* Otherwise, return timeout */ > +static int lan9303_csr_reg_wait(struct lan9303 *chip, int regno, > + int mask, char value) > +{ > + int i; > + > + for (i = 0; i < 0x1000; i++) { >

Re: [PATCH net-next v2 07/10] net: dsa: lan9303: Added basic offloading of unicast traffic

Hi Egil > +/* forward special tagged packets from port 0 to port 1 *or* port 2 */ > +static int lan9303_setup_tagging(struct lan9303 *chip) > +{ > + int ret; Blank line please. > + /* enable defining the destination port via special VLAN tagging > + * for port 0 > + */ > +

Re: [PATCH] net: phy: Log only PHY state transitions

On 07/25/2017 12:33 PM, David Miller wrote: > From: Marc Gonzalez > Date: Tue, 25 Jul 2017 11:31:46 +0200 > >> In the current code, old and new PHY states are always logged. >> From now on, log only PHY state transitions. >> >> Signed-off-by: Marc Gonzalez

[PATCH] net: inet: diag: expose sockets cgroup classid

This is useful for directly looking up a task based on class id rather than having to scan through all open file descriptors. Signed-off-by: Sasha Levin --- include/uapi/linux/inet_diag.h | 1 + net/ipv4/inet_diag.c | 10 ++ 2 files changed, 11

Re: [PATCH net] ipv6: no need to return rt->dst.error if it is not null entry.

On 7/25/17 1:32 AM, Hangbin Liu wrote: > On Mon, Jul 24, 2017 at 09:28:07PM -0600, David Ahern wrote: >> On 7/24/17 6:08 PM, Hangbin Liu wrote: >>> That's why I think we should remove both rt->dst.error and ip6_null_entry >>> check in inet6_rtm_getroute(). And even further, remove the

Re: [PATCH net-next v2 06/10] net: dsa: lan9303: added sysfs node swe_bcst_throt

On Tue, Jul 25, 2017 at 06:15:49PM +0200, Egil Hjelmeland wrote: > Allowing per-port access to Switch Engine Broadcast Throttling Register Hi Egil In general, we are against using sysfs. If there is a generic mechanism, that applies for all sorts of network interfaces, it should be used instead

Re: [PATCH net-next v2 04/10] net: dsa: lan9303: Added adjust_link() method

On Tue, Jul 25, 2017 at 06:15:47PM +0200, Egil Hjelmeland wrote: > This makes the driver react to device tree "fixed-link" declaration > on CPU port. > > - turn off autonegotiation > - force speed 10 or 100 mb/s > - force duplex mode > > Signed-off-by: Egil Hjelmeland

Re: [PATCHv3 net] ipv6: no need to return rt->dst.error if it is prohibit entry

On 7/26/17 3:20 AM, Hangbin Liu wrote: > After commit 18c3a61c4264 ("net: ipv6: RTM_GETROUTE: return matched fib > result when requested"). When we get a prohibit ertry, we will return > -EACCES directly. > > Before: Do you mean "Before commit 18c3a61c4264?" > + ip netns exec client ip -6 route

Re: TCP fast retransmit issues

On Wed, Jul 26, 2017 at 12:43 PM, Neal Cardwell wrote: > (1) Because the connection negotiated SACK, the Linux TCP sender does > not get to its tcp_add_reno_sack() code to count dupacks and enter > fast recovery on the 3rd dupack. The sender keeps waiting for specific >

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

On 07/26/2017 06:41 PM, Andrew Lunn wrote: On Mon, Jul 24, 2017 at 06:05:19PM -0500, Franklin S Cooper Jr wrote: + +Optional: + max-arbitration-speed: a positive non 0 value that determines the max + speed that CAN can run in non CAN-FD mode or during the +

[RFC] net: make net.core.{r,w}mem_{default,max} namespaced

The following sysctl are global and can't be read or set from a netns: net.core.rmem_default net.core.rmem_max net.core.wmem_default net.core.wmem_max Make the following sysctl parameters available from within a network namespace, allowing to set unique values per network namespace. My concern

Re: [PATCH net-next v2 02/10] net: dsa: lan9303: Do not disable/enable switch fabric port 0 at startup

On Tue, Jul 25, 2017 at 06:15:45PM +0200, Egil Hjelmeland wrote: > For some mysterious reason enable switch fabric port 0 TX fails to > work, when the TX has previous been disabled. Resolved by not > disable/enable switch fabric port 0 at startup. Port 1 and 2 are > still disabled in early init. >

Re: [PATCH net-next v2 01/10] net: dsa: lan9303: Fixed MDIO interface

On Tue, Jul 25, 2017 at 06:15:44PM +0200, Egil Hjelmeland wrote: > Fixes after testing on actual HW: > > - lan9303_mdio_write()/_read() must multiply register number > by 4 to get offset > > - Indirect access (PMI) to phy register only work in I2C mode. In > MDIO mode phy registers must be

Re: TC-pedit man page examples error

Hello Phil, Thank you for taking my message. I have gotten a solution working so feel free to ignore the rest of this email. By vanilla iproute2 do you mean the latest package through the yum or apt repository? All I can tell you is that in the example I gave the iproute2 package was the latest

  1   2   >