[PATCH 9/9] skge: version 1.4

2006-03-21 Thread Stephen Hemminger
Update version number Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -44,7 +44,7 @@ #include skge.h #define DRV_NAME skge -#define DRV_VERSION1.3 +#define DRV_VERSION1.4 #define

[PATCH 2/9] skge: use auto masking of irqs

2006-03-21 Thread Stephen Hemminger
Improve performance of skge driver by not touching irq mask register as much. Since the interrupt source auto-masks, the driver can just leave it disabled until the end of the soft irq. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers

[PATCH 7/9] skge: formmating and whitespace cleanup

2006-03-21 Thread Stephen Hemminger
Reformat some code to make it easier to read. And whitespace fixes. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2177,15 +2177,17 @@ static int skge_up(struct net_device *de memset(skge-mem, 0, skge

[PATCH 3/9] skge: check the allocation of ring buffer

2006-03-21 Thread Stephen Hemminger
The SysKonnect Genesis and Yukon chip sets have restrictions on the possible control block area. The memory needs to not cross 4 Gig boundary, and it needs to be 8 byte aligned. This patch checks and fails to bring the device up if region is unacceptable. Signed-off-by: Stephen Hemminger [EMAIL

[PATCH 6/9] skge: use mmiowb

2006-03-21 Thread Stephen Hemminger
Add mmio barriers at the appropriate places, don't have a platform that needs them, but this is where the documentation of the patch says to add them. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2394,9 +2394,11

[PATCH 5/9] skge: use kcalloc

2006-03-21 Thread Stephen Hemminger
Use kcalloc when allocating ring data structure. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -733,13 +733,12 @@ static int skge_ring_alloc(struct skge_r struct skge_element *e; int i; - ring

Re: Results WAS(Re: [PATCH] TC: bug fixes to the sample clause

2006-03-21 Thread Stephen Hemminger
Back to the original question... What should the iproute2 utilities contain? Does it have to have the utsname hack to work? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [iproute2] IPoIB link layer address bug

2006-03-21 Thread Stephen Hemminger
On Thu, 16 Mar 2006 17:24:41 -0500 (EST) James Lentini [EMAIL PROTECTED] wrote: The ip(8) command has a bug when dealing with IPoIB link layer addresses. Specifically it does not correctly handle the addition of new entries in the neighbor/arp table. For example, this command will fail:

Re: Writing a rate based transport protocol

2006-03-21 Thread Stephen Hemminger
On Tue, 21 Mar 2006 20:26:55 -0700 Mark Butler [EMAIL PROTECTED] wrote: On Mon, 13 Mar 2006 18:20:26 -0600, Saurabh Jain wrote: Hi All, I am trying to write a new rate based transport protocol in linux kernel (either as a module or directly within the kernel). Basically it

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-03-22 Thread Stephen Hemminger
On Tue, 21 Mar 2006 22:31:14 -0800 Chris Wright [EMAIL PROTECTED] wrote: The network device frontend driver allows the kernel to access network devices exported exported by a virtual machine containing a physical network device driver. Signed-off-by: Ian Pratt [EMAIL PROTECTED]

Re: [SKY2]: Fix RX stats

2006-03-22 Thread Stephen Hemminger
On Wed, 22 Mar 2006 18:14:36 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: yes, skge has the same typo as well. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] sky2: more ethtool stats

2006-03-22 Thread Stephen Hemminger
Expose all the available hardware statistics via ethtool. And cleanup some of the statistics definitions. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-22 09:33:41.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006-03-22 09:58

[PATCH 2/3] sky2: Fix RX stats

2006-03-23 Thread Stephen Hemminger
Unicast packets are shown as multicast, real multicast packets are missing. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:29:11.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006

[PATCH 1/3] sky2: typo in last stats patch

2006-03-23 Thread Stephen Hemminger
Typo in last stats patch. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:39:31.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006-03-23 08:44:04.0 -0800 @@ -2484,7 +2484,7 @@ { single_collisions, GM_TXF_SNG_COL

[PATCH 0/3] sky2 small fixes

2006-03-23 Thread Stephen Hemminger
One build fix, a statistics fix, and optimization -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] sky2: dont need to use dev_kfree_skb_any

2006-03-23 Thread Stephen Hemminger
Transmit buffers are always freed with interrupts enabled (softirq), so we can just call dev_kfree_skb. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-03-23 08:44:04.0 -0800 +++ sky2-2.6.17/drivers/net/sky2.c 2006-03-23 08:45

[PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread Stephen Hemminger
bridge with 2.6.16. Appended is a patch to fix them. Signed-off-by: Peter Chubb [EMAIL PROTECTED] Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.orig/net/bridge/br_stp_bpdu.c 2006-03-23 09:30:09.0 -0800 +++ linux-2.6/net/bridge/br_stp_bpdu.c 2006-03-23 09:30

[PATCH 1/7] skge: align receive buffers

2006-03-23 Thread Stephen Hemminger
The skge driver aligns the header on the initial receive buffers, but but doesn't on followon receive buffer allocations. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2155,7 +2155,7 @@ static int skge_up(struct

[PATCH 0/7] skge: update 1.5

2006-03-23 Thread Stephen Hemminger
Mostly small fixes, the most important one is making sure not to free transmit buffers to early during scatter-gather -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH 7/7] skge: version 1.5

2006-03-23 Thread Stephen Hemminger
Update version to allow tracking of complaints. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -44,7 +44,7 @@ #include skge.h #define DRV_NAME skge -#define DRV_VERSION1.4 +#define

[PATCH 5/7] skge: dont free skb until multi-part transmit complete

2006-03-23 Thread Stephen Hemminger
of the last done descriptor, second cleans up until that point. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2404,35 +2404,39 @@ static int skge_xmit_frame(struct sk_buf return NETDEV_TX_OK; } -static inline

[PATCH 2/7] skge: dont use dev_alloc_skb for rx buffs

2006-03-23 Thread Stephen Hemminger
. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -829,7 +829,7 @@ static int skge_rx_fill(struct skge_port do { struct sk_buff *skb; - skb = dev_alloc_skb(skge-rx_buf_size

[PATCH 3/7] skge: rx_reuse called twice

2006-03-23 Thread Stephen Hemminger
In the error case we call skge_rx_reuse twice. This is harmless but unnecessary. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -781,7 +781,7 @@ static void skge_rx_setup(struct skge_po * Note: DMA address

[PATCH 4/7] skge: multicast statistics fix

2006-03-23 Thread Stephen Hemminger
Fix count of multicast packets. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -357,7 +357,7 @@ static struct net_device_stats *skge_get skge-net_stats.rx_bytes = data[1]; skge-net_stats.tx_packets

[ANNOUNCE] iproute2 2.6.16-060323

2006-03-23 Thread Stephen Hemminger
in tc sample Add sample divisor Alpt Add more rt_proto values Dale Sedivec Warn when using handle instead of classid with tc class Jean Tourrilhes Fix endless loop in netlink error handling Stephen Hemminger Change default lnstat count to 1 Update to 2.6.16 headers Add fake

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-03-23 Thread Stephen Hemminger
David S. Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 23 Mar 2006 09:32:33 -0800 I see lots of kernel unaligned access to 0xa001009dbb6f, ip=0xa00100811591 kernel unaligned access to 0xa001009dbb6b, ip=0xa001008115c1 kernel

Re: [PATCH] set default max TCP buffers from memory pool size

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 11:47:29 -0500 John Heffner [EMAIL PROTECTED] wrote: This patch sets the maximum TCP buffer sizes (available to automatic buffer tuning, not to setsockopt) based on the TCP memory pool size. The maximum sndbuf and rcvbuf each will be up to 4 MB, but no more than 1/128 of

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 17:14:49 + michael [EMAIL PROTECTED] wrote: transfer of data hangs with sky2 very often on a :02:00.0 Ethernet controller: Marvell Technology Group Ltd. 88E8036 Fast Ethernet Controller (rev 10) found on toshiba laptops, when using 2.6.16, which proves a

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 18:18:57 + michael [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 09:38:44AM -0800, Stephen Hemminger wrote: On Fri, 24 Mar 2006 17:14:49 + michael [EMAIL PROTECTED] wrote: transfer of data hangs with sky2 very often on a :02:00.0 Ethernet

Re: [RFC] new qla3xxx NIC Driver v2.02.00b01

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 10:58:44 -0800 Ron Mercer [EMAIL PROTECTED] wrote: * Use existing MII code and interface Do you mean support for the get/set IOCTLS SIOCGMIIREG/SIOCSMIIREG? If you can look at using mii.c and include/linux/mii.h. Not all drivers can, and the interface is poorly

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 18:48:37 + fs [EMAIL PROTECTED] wrote: On Fri, Mar 24, 2006 at 10:40:00AM -0800, Stephen Hemminger wrote: Maybe the hang I notice is different because it stays with this patch and appears primarily after using multiple connections. An easy way to reproduce

Re: sky2: hangs on 2.6.16

2006-03-24 Thread Stephen Hemminger
On Fri, 24 Mar 2006 22:13:54 + Michael Menegakis [EMAIL PROTECTED] wrote: were they any helpfull? The first thing to look for is are packets showing up (and being transmitted) by doing ethtool -S eth0 Since in this driver stats come out of the PHY, it is possible for the PHY to be

[Fwd: [Bug 6295] New: unregister_netdevice loops indefinitely when bringing down an interface if static ARP entries are present]

2006-03-28 Thread Stephen Hemminger
---BeginMessage--- http://bugzilla.kernel.org/show_bug.cgi?id=6295 Summary: unregister_netdevice loops indefinitely when bringing down an interface if static ARP entries are present Kernel Version: 2.6.16 Status: NEW Severity: normal

Re: RX processing order for packet sockets and bridge

2006-03-31 Thread Stephen Hemminger
jamal wrote: On Wed, 2006-29-03 at 13:16 -0800, [EMAIL PROTECTED] wrote: On Wed, 2006-29-03 at 11:14 -0800, Jouni Malinen wrote: [..] A digression: One of the problems of the bridge in my opinion is having STP, a control protocol, inside the kernel. I do hope someone with time will rip it

Re: [PATCH 1.1/9] NetXen 1G/10G driver

2006-04-03 Thread Stephen Hemminger
On +#undef NetXen_LOOPBACK +#undef SINGLE_DMA_BUF +#define NetXen_NIC_HW_CSUM +#define NetXen_NIC_NAPI +// #undef NetXen_NIC_NAPI + +#define NetXen_NETIF_F_TSO Ugh. MixedCase define's and ifdef configuration message. Remember, either keep the code or remove it. +// for cmd line

Re: [PATCH 0/9] NetXen 1G/10G driver

2006-04-03 Thread Stephen Hemminger
diff -Naru linux-2.6.16_orig/drivers/net/netxen/Makefile linux-2.6.16/drivers/net/netxen/Makefile --- linux-2.6.16_orig/drivers/net/netxen/Makefile 1969-12-31 16:00:00.0 -0800 +++ linux-2.6.16/drivers/net/netxen/Makefile 2006-03-24 14:25:53.0 -0800 @@ -0,0 +1,40 @@

Fw: [Bug 6322] New: Kernel Panic (i think nf_br component)

2006-04-03 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 3 Apr 2006 04:26:21 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 6322] New: Kernel Panic (i think nf_br component) http://bugzilla.kernel.org/show_bug.cgi?id=6322 Summary: Kernel Panic (i think nf_br component) Kernel

Fw: [Bug 6295] New: unregister_netdevice loops indefinitely when bringing down an interface if static ARP entries are present

2006-04-03 Thread Stephen Hemminger
Begin forwarded message: Date: Mon, 27 Mar 2006 23:12:50 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 6295] New: unregister_netdevice loops indefinitely when bringing down an interface if static ARP entries are present http://bugzilla.kernel.org/show_bug.cgi?id=6295

Re: [PATCH 2/9] NetXen 1G/10G driver

2006-04-03 Thread Stephen Hemminger
O +static int +netxen_nic_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol) +{ +// can't implement as WOL register is not known !! +return 0; If it can not be implemented, it should return something 0, say -EINVAL. ethtool does the right thing if you

Re: [2.6 patch] drivers/char/random.c: unexport secure_ipv6_port_ephemeral

2006-04-05 Thread Stephen Hemminger
On Wed, 5 Apr 2006 18:36:10 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: This patch removes the unused EXPORT_SYMBOL(secure_ipv6_port_ephemeral). Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- linux-2.6.17-rc1-mm1-full/drivers/char/random.c.old 2006-04-05 17:00:04.0 +0200

[PATCH] sky2: bad memory reference on dual port cards

2006-04-05 Thread Stephen Hemminger
Sky2 driver will oops referencing bad memory if used on a dual port card. The problem is accessing past end of MIB counter space. Applies for both 2.6.17 and 2.6.16 (with fuzz) Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- test-2.6.orig/drivers/net/sky2.c +++ test-2.6/drivers/net

Re: Notifier for netdev feature changes?

2006-04-06 Thread Stephen Hemminger
On Thu, 06 Apr 2006 09:57:20 -0700 Ben Greear [EMAIL PROTECTED] wrote: Is there currently a way to be notified of an arbitrary interface having it's netdev feature flags modified? If not, perhaps we could add one? I think this would be useful for allowing 802.1Q VLANs, bridges, and other

Re: [patch] ipv4: initialize arp_tbl rw lock

2006-04-07 Thread Stephen Hemminger
On Fri, 7 Apr 2006 10:15:33 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: From: Heiko Carstens [EMAIL PROTECTED] The qeth driver makes use of the arp_tbl rw lock. CONFIG_DEBUG_SPINLOCK detects that this lock is not initialized as it is supposed to be. Signed-off-by: Heiko Carstens [EMAIL

Re: [PATCH] Unaligned accesses in the ethernet bridge

2006-04-07 Thread Stephen Hemminger
On Thu, 6 Apr 2006 22:37:08 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: On Thu, Mar 23, 2006 at 01:06:02PM +1100, Peter Chubb wrote: I see lots of kernel unaligned access to 0xa001009dbb6f, ip=0xa00100811591 kernel unaligned access to 0xa001009dbb6b,

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Stephen Hemminger
On Mon, 10 Apr 2006 19:28:39 +0200 Ingo Oeser [EMAIL PROTECTED] wrote: Hi Vlad, Vlad Drukker wrote: diff --git a/net/core/dev.c b/net/core/dev.c index 434220d..a351687 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1614,6 +1614,8 @@ static __inline__ int handle_bridge(stru   

Re: [PATCH] fix multicast frame handling

2006-04-10 Thread Stephen Hemminger
On Mon, 10 Apr 2006 22:57:45 +0300 Vlad Drukker [EMAIL PROTECTED] wrote: On Mon, 2006-04-10 at 11:06 -0700, Stephen Hemminger wrote: On Mon, 10 Apr 2006 19:28:39 +0200 Ingo Oeser [EMAIL PROTECTED] wrote: Hi Vlad, Vlad Drukker wrote: diff --git a/net/core/dev.c b/net/core

[PATCH] bridge: receive link-local on disabled ports.

2006-04-10 Thread Stephen Hemminger
This change allows link local packets (like 802.3ad and Spanning Tree Protocol) to be processed even when the bridge is not using the port. It fixes the chicken-egg problem for bridging a bonded device, and may also fix problems with spanning tree failover. Signed-off-by: Stephen Hemminger [EMAIL

[RFT] dlink pci cards using wrong driver

2006-04-11 Thread Stephen Hemminger
This patch fixes the problem of some Dlink cards picking the wrong driver. It looks like these cards use Yukon 1 chipset, not Yukon 2. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/skge.c 2006-03-24 09:56:05.0 -0800 +++ sky2-2.6.17/drivers/net

[PATCH 2/3] eth: indentation and whitespace

2006-04-11 Thread Stephen Hemminger
Run the ethernet common code through indent, and fix other whitespace issues. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 10:07:37.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:18:37.0 -0700 @@ -66,55 +66,46

[PATCH 0/3] eth.c cleanups for 2.6.18

2006-04-11 Thread Stephen Hemminger
Minor optimizations and cleanups to the common ethernet header routines. -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] eth: dont use __constant_htons

2006-04-11 Thread Stephen Hemminger
Don't need to use __constant_htons here. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 10:18:37.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:21:40.0 -0700 @@ -208,7 +208,7 @@ eth = (struct ethhdr

[PATCH 1/3] eth: use constant size address

2006-04-11 Thread Stephen Hemminger
Change the ethernet support routines to use constant address size. This generates smaller faster code. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net-2.6.orig/net/ethernet/eth.c 2006-04-11 09:43:40.0 -0700 +++ net-2.6/net/ethernet/eth.c 2006-04-11 10:07:37.0

Re: created new q_disc, inserted module, tc tells me unknown qdisc

2006-04-11 Thread Stephen Hemminger
On Mon, 10 Apr 2006 21:41:39 -0400 (EDT) George P Nychis [EMAIL PROTECTED] wrote: Hi, I am trying to install a proprietary qdisc made for research, it is not publically released yet, however its been used several times so i know it works. The files included are: q_xcp.c: static

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Tue, 11 Apr 2006 20:30:46 +0100 Daniel Drake [EMAIL PROTECTED] wrote: Hi, Since sometime after 2.6.16, some websites have been very slow to load. Examples include: http://zd1211.ath.cx http://developer.osdl.org/shemminger/blog/ http://www.reactivated.net/weblog On a good

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Tue, 11 Apr 2006 23:20:42 +0100 Daniel Drake [EMAIL PROTECTED] wrote: John Heffner wrote: This is almost certainly due to a buggy firewall that doesn't understand TCP window scaling. I've usually seen this in the past with OpenBSD firewalls. Do you have one of these in your path?

Re: 2.6.17 regression: Very slow net transfer from some hosts

2006-04-11 Thread Stephen Hemminger
On Wed, 12 Apr 2006 01:06:09 +0100 Daniel Drake [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: This is very familiar, and I just found the article I was thinking of: http://lwn.net/Articles/92727/ I was also hit by that bug, on the same collection of websites, but that particular

[PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
completes. The problem is that the driver doesn't register a notify handler unless ATM is started, and it doesn't do the proper cleanup in the event handler. Please apply for 2.6.17 and 2.6.16 stable. Bug-reference: http://bugzilla.kernel.org/show_bug.cgi?id=6295 Signed-off-by: Stephen Hemminger [EMAIL

[PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
://bugzilla.kernel.org/show_bug.cgi?id=6295 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.16.2.orig/net/atm/clip.c 2006-04-12 10:10:43.0 -0700 +++ linux-2.6.16.2/net/atm/clip.c 2006-04-12 11:22:47.0 -0700 @@ -613,12 +613,19 @@ static int clip_device_event

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
On Thu, 13 Apr 2006 06:00:15 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Hi Stephen: On Wed, Apr 12, 2006 at 12:45:33PM -0700, Stephen Hemminger wrote: /* ignore non-CLIP devices */ - if (((struct net_device *) dev)-type != ARPHRD_ATM || - ((struct net_device *) dev

Re: [RFD][PATCH] typhoon and core sample for folding away VLAN stuff

2006-04-12 Thread Stephen Hemminger
On Wed, 12 Apr 2006 13:10:06 -0700 Ben Greear [EMAIL PROTECTED] wrote: What is the reasoning for this change? Is the compiler able to optomize the right-hand-side to a constant with your change in place? - if (veth-h_vlan_proto != __constant_htons(ETH_P_8021Q)) { + if

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-04-12 Thread Stephen Hemminger
You need this patch, which Jeff hasn't applied yet. - Subject: sky2: crash when bringing up second port Sky2 driver will oops referencing bad memory if used on a dual port card. The problem is accessing past end of MIB counter space. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED

Re: [PATCH] atm: clip causes unregister hang

2006-04-12 Thread Stephen Hemminger
of the patch also adds locking around the reference to the atm arp daemon to avoid races with events and daemon state changes. (Note: barrier() was never really safe) Bug-reference: http://bugzilla.kernel.org/show_bug.cgi?id=6295 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c

[PATCH] atm: clip timer race

2006-04-12 Thread Stephen Hemminger
By inspection, the clip idle timer code is racy on SMP. Here is a safe version of timer management. Untested, I don't have ATM hardware. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-12 14:24:10.0 -0700 +++ clip/net/atm/clip.c 2006-04-12 14:40

Re: [PATCH] atm: clip timer race

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 22:45:34 +1000 Herbert Xu [EMAIL PROTECTED] wrote: On Wed, Apr 12, 2006 at 03:42:14PM -0700, Stephen Hemminger wrote: By inspection, the clip idle timer code is racy on SMP. Here is a safe version of timer management. Untested, I don't have ATM hardware. Good catch

Re: [PATCH 12/18] ipw2200: version string rework

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 17:20:34 +0800 Zhu Yi [EMAIL PROTECTED] wrote: Added version string fields so the version string indicates what is configured (ie, you'll see 1.1.1kpmd if you are using a GIT snapshot (Kernel.. previously -git), promiscuous (p), monitor (m), debug (d) build. No, this is

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-13 Thread Stephen Hemminger
Please get rid of the debug config option. Make the debug code, default off and be low enough impact that everyone can ship with it. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] bcm43xx: iw_priv_args names should be 16 characters

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 15:02:27 +0200 Erik Mouw [EMAIL PROTECTED] wrote: The room for the names in bcm43xx_priv_wx_args[] are IFNAMSIZ long and IFNAMSIZ is defined as 16, so the names in bcm43xx_priv_wx_args should be 15 characters (16 including the trailing \0). This patch fixes that for the

Re: via_rhine modules error on 2.6.16 with mii-tool

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 22:47:31 +0200 Roger Luethi [EMAIL PROTECTED] wrote: On Thu, 13 Apr 2006 11:40:18 -0700, Stephen Hemminger wrote: The right thing to do is get rid of the locking in via_rhine:netdev_ioctl and push the locking down into mdio_read, mdio_write. As I said before, a dozen

[PATCH 4/4] clip: add module info

2006-04-13 Thread Stephen Hemminger
Add module information Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:20:38.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:23:41.0 -0700 @@ -1017,5 +1017,6 @@ module_init(atm_clip_init); module_exit(atm_clip_exit

[PATCH 2/4] clip: get rid of PROC_FS ifdef

2006-04-13 Thread Stephen Hemminger
Don't need the ifdef here since create_proc_entry() is stubbed to always return NULL. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:18:21.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:20:26.0 -0700 @@ -976,6 +976,7 @@ static

[PATCH 1/4] clip: run through Lindent

2006-04-13 Thread Stephen Hemminger
Run CLIP driver through Lindent script to fix formatting. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 09:44:22.0 -0700 +++ clip/net/atm/clip.c 2006-04-13 15:18:21.0 -0700 @@ -2,7 +2,6 @@ /* Written 1995-2000 by Werner

[PATCH 3/4] clip: notifier related cleanups

2006-04-13 Thread Stephen Hemminger
Cleanup some code around notifier. Don't need (void) casts to ignore return values, and use C90 style initializer. Just ignore unused device events. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- clip.orig/net/atm/clip.c2006-04-13 15:20:26.0 -0700 +++ clip/net/atm/clip.c

Re: [patch 1/3] softmac: return -EAGAIN from getscan while scanning

2006-04-13 Thread Stephen Hemminger
On Thu, 13 Apr 2006 15:45:22 -0700 Jouni Malinen [EMAIL PROTECTED] wrote: On Thu, Apr 13, 2006 at 03:28:53PM -0700, Pete Zaitcev wrote: On Thu, 13 Apr 2006 09:00:51 -0700, Jouni Malinen [EMAIL PROTECTED] wrote: That could be blocking an ioctl call for couple of seconds and would be

[PATCH 1/3] eth: use constant size address (revised)

2006-04-13 Thread Stephen Hemminger
Change the ethernet support routines to use constant address size. This generates smaller faster code. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/net/ethernet/eth.c 2006-03-07 13:28:54.0 -0800 +++ sky2-2.6.17/net/ethernet/eth.c 2006-04-12 13:10

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-14 Thread Stephen Hemminger
On Fri, 14 Apr 2006 13:18:31 +0800 Zhu Yi [EMAIL PROTECTED] wrote: On Thu, 2006-04-13 at 10:30 -0700, Stephen Hemminger wrote: Please get rid of the debug config option. Make the debug code, default off and be low enough impact that everyone can ship with it. This patch is exactly doing

Re: [PATCH] stir4200 switch to the kthread API

2006-04-14 Thread Stephen Hemminger
Has this been tested? - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Kernel error

2006-04-17 Thread Stephen Hemminger
On Sun, 16 Apr 2006 01:43:08 -0500 Saurabh Jain [EMAIL PROTECTED] wrote: Hi Guys, I am getting the following kernel error while doing some experiments. Any idea where things are going wrong. To me it looks like there is an error while copying data from user space to kernel space. The

Re: [PATCH] ipw2100: wraps the debug module param within #ifdefs

2006-04-17 Thread Stephen Hemminger
On Mon, 17 Apr 2006 10:17:43 +0800 Zhu Yi [EMAIL PROTECTED] wrote: On Fri, 2006-04-14 at 09:33 -0700, Stephen Hemminger wrote: I meant get rid of CONFIG_IPW2200_DEBUG completely. Having the debug code isn't bad, and there is no reason not to have it always there. There are lots

Re: want to randomly drop packets based on percent

2006-04-17 Thread Stephen Hemminger
On Mon, 17 Apr 2006 03:38:33 -0400 George Nychis [EMAIL PROTECTED] wrote: Hey, I'm using the 2.4.32 kernel with madwifi and iproute2 version 2-2.6.16-060323.tar.gz I wanted to insert artificial packet loss based on a percent so i found: network emulab qdisc could do it, so i compiled

Re: want to randomly drop packets based on percent

2006-04-17 Thread Stephen Hemminger
On Mon, 17 Apr 2006 18:30:51 -0400 George Nychis [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: On Mon, 17 Apr 2006 03:38:33 -0400 George Nychis [EMAIL PROTECTED] wrote: Hey, I'm using the 2.4.32 kernel with madwifi and iproute2 version 2-2.6.16-060323.tar.gz I wanted

Re: want to randomly drop packets based on percent

2006-04-17 Thread Stephen Hemminger
O I wanted to insert artificial packet loss based on a percent so i found: network emulab qdisc could do it, so i compiled support into the kernel and tried: tc qdisc change dev eth0 root netem loss .1% ^^ You need to do add not change. Add will set the queue

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-04-17 Thread Stephen Hemminger
I don't know what you are doing different, but my 2 port SysKonnect card is working fine. Running SMP AMD64 and 2.6.17 latest. Showing full speed on both ports. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] ip_route_input panic fix

2006-04-17 Thread Stephen Hemminger
-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.16.6.orig/net/ipv4/route.c +++ linux-2.6.16.6/net/ipv4/route.c @@ -2750,7 +2750,10 @@ int inet_rtm_getroute(struct sk_buff *in /* Reserve room for dummy headers, this skb can pass through good chunk of routing engine

Re: [PATCH] sky2: flow control off

2007-02-05 Thread Stephen Hemminger
, no errors occurred in a 48 hour test run. There probably are other races and hangs that are related. I don't consider all the hangs eliminated yet. -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED

[PATCH 0/7] sky2 v1.12 patches

2007-02-06 Thread Stephen Hemminger
New driver version for 2.6.21 inclusion: * WOL * TSO support for 88E8055 * more PCI id's * experimental support for Yukon Extreme Patches are against current netdev-2.6#upstream -- Stephen Hemminger [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body

[PATCH 2/7] sky2: use dev_err for error reports

2007-02-06 Thread Stephen Hemminger
Use the standard dev_xxx functions instead of printk directly for error reports. Fix a bug where the initialization would return 0 if allocation of network device failed. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 75

[PATCH 7/7] sky2: version 1.12

2007-02-06 Thread Stephen Hemminger
Updated version for WOL and new id's Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- sky2-dev.orig/drivers/net/sky2.c2007-02-06 10:44:29.0 -0800 +++ sky2-dev/drivers/net/sky2.c 2007-02-06 10:44

[PATCH 5/7] sky2: Yukon Extreme support

2007-02-06 Thread Stephen Hemminger
This is basic support for the new Yukon Extreme chip, extracted from the new vendor driver 10.0.4.3. Since this is untested hardware, it has a big fat warning for now. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 49

[PATCH 3/7] sky2: TSO support for EC_U

2007-02-06 Thread Stephen Hemminger
The Yukon EC_U chipset apparently supports TSO but only for non-Jumbo frame sizes because it lacks a Ram buffer. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) --- sky2-dev.orig/drivers/net/sky2.c

[PATCH 4/7] sky2: safer transmit timeout

2007-02-06 Thread Stephen Hemminger
Rather than trying to be smart about possible transmit timeout causes. Just clear all pending frames and reset the PHY. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions

[PATCH 1/7] sky2: add Wake On Lan support

2007-02-06 Thread Stephen Hemminger
Adds basic magic packet wake on lan support to the sky2 driver. Note: initial WOL value is based on BIOS settings. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c | 208 ++--- drivers/net/sky2.h | 28 ++- 2 files

[PATCH 6/7] sky2: add new chip ids

2007-02-06 Thread Stephen Hemminger
More new chip id's from vendor driver version 10.0.4.3 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c |4 1 file changed, 4 insertions(+) --- sky2-dev.orig/drivers/net/sky2.c2007-02-06 10:44:26.0 -0800 +++ sky2-dev/drivers/net/sky2.c 2007-02-06

Re: [PATCH 5/7] sky2: Yukon Extreme support

2007-02-06 Thread Stephen Hemminger
static bool is_yukon_extreme(struct sky2_hw *hw) { return hw-chip_id == CHIP_ID_YUKON_XL || hw-chip_id == CHIP_ID_YUKON_EC_U || hw-chip_id == CHIP_ID_YUKON_EX; These chips aren't extreme, it might be easier to turn the test around and test for the chips

Re: [PATCH] sky2: flow control off

2007-02-06 Thread Stephen Hemminger
On Tue, 06 Feb 2007 19:18:07 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: Turn flow control off for sky2. When flow control is on, the transmitter may get randomly stuck. Perhaps there is hardware problem, but until Marvell provides errata information for workaround

Re: [IPROUTE2] tc build failure and netfilter headers.

2007-02-06 Thread Stephen Hemminger
On Wed, 07 Feb 2007 16:33:53 +0900 (JST) YOSHIFUJI Hideaki / 吉藤英明 [EMAIL PROTECTED] wrote: Stephen, I think we should include include/linux/netfilter/{x_tables.h,xt_tcpudp.h} in iproute2 distribution to avoid compilation failure of tc. Regards, --yoshfuji Okay, but but we are

Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

2007-02-07 Thread Stephen Hemminger
On Wed, 7 Feb 2007 12:52:16 -0800 Andrew Morton [EMAIL PROTECTED] wrote: Begin forwarded message: Date: Wed, 7 Feb 2007 12:41:07 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

[PATCH] sk98lin: planned removal

2007-02-07 Thread Stephen Hemminger
Document planned removal of sk98lin driver. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- Documentation/feature-removal-schedule.txt |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/Documentation/feature-removal-schedule.txt b/Documentation/feature-removal

Re: Network: convert network devices to use struct device instead of class_device

2007-02-08 Thread Stephen Hemminger
On Thu, 08 Feb 2007 07:43:18 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=43cb76d91ee85f579a69d42bc8efc08bac560278 Commit:

Re: [Bugme-new] [Bug 7962] New: oops in port_carrier_check

2007-02-09 Thread Stephen Hemminger
On Fri, 9 Feb 2007 08:42:11 +0100 Jarek Poplawski [EMAIL PROTECTED] wrote: On 07-02-2007 23:09, Stephen Hemminger wrote: On Wed, 7 Feb 2007 12:52:16 -0800 Andrew Morton [EMAIL PROTECTED] wrote: ... Feb 7 21:20:18 plop kernel: BUG: unable to handle kernel paging request at virtual

[patch 2/3] tcp: use read mostly for CUBIC parameters

2007-02-12 Thread Stephen Hemminger
These module parameters should be in the read mostly area to avoid cache pollution. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- net/ipv4/tcp_cubic.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) --- tcp.orig/net/ipv4/tcp_cubic.c 2007-02-12 07:28

<    9   10   11   12   13   14   15   16   17   18   >