Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
On Thu, 1 Feb 2007 19:55:32 +0100 Thomas Glanzmann [EMAIL PROTECTED] wrote: Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. However if I remove the driver module and load it again it works and even the

Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
On Thu, 1 Feb 2007 19:55:32 +0100 Thomas Glanzmann [EMAIL PROTECTED] wrote: Hello, I have a sky2 network card in my intel mac mini. It stops working when I do havy network load like watching a divx over http/sshfs. Is this heavy Tx load (ie your watching movie from mac mini). or Rx load (you

Re: sky2 hangs

2007-02-01 Thread Stephen Hemminger
, as there is a MySQL server on the other end, receiving about 100 queries per second - unloading the sky2 module totally freezes the computer for me If you do: ethtool -r eth0 it cause a PHY reset (renegotiation) and clears the problem. -- Stephen Hemminger [EMAIL PROTECTED

[PATCH 1/4] skge: handle zero address at open

2007-02-02 Thread Stephen Hemminger
Some motherboards are broken and have no address set. Failing at probe time prevents the device from ever being used (like to download a fixed BIOS). Instead warn on probe and check again when device is brought up. That way the address can be set. Signed-off-by: Stephen Hemminger [EMAIL

[PATCH 0/4] skge: update

2007-02-02 Thread Stephen Hemminger
Several enhancements: WOL now works, use dev_printk macros and allow handling broken hardware better. -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] skge: version 1.10

2007-02-02 Thread Stephen Hemminger
Mark this as 1.10 because WOL now works Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge.orig/drivers/net/skge.c +++ skge/drivers/net/skge.c @@ -42,7 +42,7 @@ #include skge.h #define DRV_NAME skge -#define DRV_VERSION1.9 +#define DRV_VERSION

[PATCH 3/4] skge: WOL support

2007-02-02 Thread Stephen Hemminger
Add WOL support for Yukon chipsets in skge device. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/skge.c | 158 + drivers/net/skge.h |2 2 files changed, 125 insertions(+), 35 deletions(-) --- skge.orig/drivers/net

[PATCH 2/4] skge: use dev_printk

2007-02-02 Thread Stephen Hemminger
Use dev_printk related macros for PCI related errors and warnings Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge.orig/drivers/net/skge.c +++ skge/drivers/net/skge.c @@ -2395,7 +2395,7 @@ static int skge_up(struct net_device *de BUG_ON(skge-dma 7); if ((u64)skge

[RFT] sky2 auto negotiation PHY errata

2007-02-02 Thread Stephen Hemminger
This patch does the Marvell errata before auto negotiation (from drivers/phy/marvell.c). The Yukon II chips have an internal version of the same PHY, so perhaps this errata is necessary for them as well. For test only, but it may fix some of the hangs. It seems to fix the PHY lockups I saw

[PATCH] sky2: flow control off

2007-02-02 Thread Stephen Hemminger
Turn flow control off for sky2. When flow control is on, the transmitter may get randomly stuck. Perhaps there is hardware problem, but until Marvell provides errata information for workaround, it should default to off. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/sky2.c

Re: [TCP]: Fix truesize underflow

2006-04-19 Thread Stephen Hemminger
On Tue, 18 Apr 2006 22:32:04 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Hi Dave: You're absolutely right about there being a problem with the TSO packet trimming code. The cause of this lies in the tcp_fragment() function. When we allocate a fragment for a completely non-linear packet the

Re: I/OAT: Call for discussion

2006-04-19 Thread Stephen Hemminger
On Wed, 19 Apr 2006 09:39:37 -0700 Grover, Andrew [EMAIL PROTECTED] wrote: Over the past few months, we (the Intel networking group) have been working hard, often off-list, to get the I/OAT patches we've posted here merged into the mainline kernel branch, as well as Red Hat and SuSE. We've

Re: Netpoll checksum issue

2006-04-19 Thread Stephen Hemminger
The changes to how hardware receive checksums are handled broke the netpoll checksum code (for CHECKSUM_HW). Since this is not at all performance critical, try this patch. It changes to always to normal software checksum. --- linux-2.6.orig/net/core/netpoll.c 2006-03-22 09:30:56.0

Re: TOE info page

2006-04-19 Thread Stephen Hemminger
On Wed, 19 Apr 2006 19:22:14 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: I created a TOE (TCP Offload Engine) info page for Linux, on the linux-net wiki: http://linux-net.osdl.org/index.php/TOE As soon as I can find a wiki admin, it will get added to the main page. I don't

[PATCH] bridge: allow full size vlan tagged packets to be bridged

2006-04-20 Thread Stephen Hemminger
The Ethernet bridge code silently drops packets when forwarding a packet that is too large for the destination interface (as per 802.1d). But it should allow for VLAN tagged frames. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- bridge.orig/net/bridge/br_forward.c 2006-04-10 16:17

Re: Congestion Avoidance Monitoring Tools

2006-04-21 Thread Stephen Hemminger
On Thu, 20 Apr 2006 22:26:14 -0700 Piet Delaney [EMAIL PROTECTED] wrote: I'm upgrading our 2.6.12 kernel to 2.6.13, which includes significant congestion avoidance code additions and changes. I was wondering if there are any tools folks can recommend for testing the kernel to make sure the

Hotplug race on name change

2006-04-21 Thread Stephen Hemminger
This: Without that patch, there is a race when registering network interfaces and renaming it with udev rules, because initially the address in sysfs doesn't contain useful data. See http://marc.theaimsgroup.com/?t=11446033892r=1w=2 Breaking the recommended way of assigning

Fw: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src 0x1) triggered

2006-04-21 Thread Stephen Hemminger
Looks like PIO at unaligned addresses doesn't work on alpha... Begin forwarded message: Date: Fri, 21 Apr 2006 02:35:45 -0700 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [Bug 6421] New: kernel 2.6.10-2.6.16 on alpha: arch/alpha/kernel/io.c, iowrite16_rep() BUG_ON((unsigned long)src

[PATCH 1/2] class device: add attribute_group creation

2006-04-21 Thread Stephen Hemminger
are a property of the class_device object. This is done because there are different types of network devices (wireless for example). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/base/class.c 2006-04-21 12:19:26.0 -0700 +++ sky2-2.6.17/drivers/base

[PATCH 2/2] netdev: create attribute_groups with class_device_add

2006-04-21 Thread Stephen Hemminger
Atomically create attributes when class device is added. This avoids the race between registering class_device (which generates hotplug event), and the creation of attribute groups. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/net/core/dev.c 2006-04-21 12:20

[RFC] netdev sysfs failure handling

2006-04-21 Thread Stephen Hemminger
In case of sysfs failure, don't let device be brought up. It can be cleared by unregister_netdevice so module can be unloaded normally. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/net/core/dev.c 2006-04-21 12:21:45.0 -0700 +++ sky2-2.6.17/net/core/dev.c

Re: [PATCH 9/10] d80211: rename master interface

2006-04-21 Thread Stephen Hemminger
On Fri, 21 Apr 2006 22:53:29 +0200 (CEST) Jiri Benc [EMAIL PROTECTED] wrote: Rename master interface to wmasterX to better reflect its purpose. Signed-off-by: Jiri Benc [EMAIL PROTECTED] --- net/d80211/ieee80211.c |2 +- net/d80211/ieee80211_i.h |2 +- 2 files changed, 2

Re: [patch 2/5] s2io driver updates

2006-04-24 Thread Stephen Hemminger
On Sat, 22 Apr 2006 11:28:02 +0200 Francois Romieu [EMAIL PROTECTED] wrote: Ananda Raju [EMAIL PROTECTED] : [...] Signed-off-by: Ananda Raju [EMAIL PROTECTED] --- diff -upNr perf_fixes/drivers/net/s2io.c dmesg_param_fixes/drivers/net/s2io.c --- perf_fixes/drivers/net/s2io.c

Re: [PATCH 02/11] ixgb: Fix the use of dprintk rather than printk

2006-04-24 Thread Stephen Hemminger
On Sat, 22 Apr 2006 11:03:01 +0200 Francois Romieu [EMAIL PROTECTED] wrote: Jeff Kirsher [EMAIL PROTECTED] : [...] diff --git a/drivers/net/ixgb/ixgb.h b/drivers/net/ixgb/ixgb.h index c83271b..a696c33 100644 --- a/drivers/net/ixgb/ixgb.h +++ b/drivers/net/ixgb/ixgb.h [...] @@ -192,6

Re: Congestion Avoidance Monitoring Tools

2006-04-24 Thread Stephen Hemminger
On Mon, 24 Apr 2006 00:52:35 +0200 Hagen Paul Pfeifer [EMAIL PROTECTED] wrote: * Stephen Hemminger | 2006-04-21 08:19:17 [-0700]: 2.6.13 still had lots of problems, things didn't really get working right till 2.6.15 or later. Especially with TSO. --verbose? I have a tool using kprobe's

Re: [patch 2/5] s2io driver updates

2006-04-24 Thread Stephen Hemminger
On Mon, 24 Apr 2006 10:39:52 -0700 Ananda Raju [EMAIL PROTECTED] wrote: Hi, Currently the only way we can differentiate between copper CX4 transponder adapters from optical transponder adapters is by reading the product name string in vpd. That makes sense. Though often the VPD can be

[PATCH] netdev: hotplug napi race cleanup

2006-04-24 Thread Stephen Hemminger
-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.orig/net/core/dev.c 2006-04-24 10:31:15.0 -0700 +++ linux-2.6/net/core/dev.c2006-04-24 10:31:16.0 -0700 @@ -203,10 +203,12 @@ #ifdef CONFIG_SYSFS extern int netdev_sysfs_init(void); -extern int netdev_register_sysfs

Re: is it a backwards compatability catch-22?

2006-04-24 Thread Stephen Hemminger
to depend on usermode to define the name. Just choose some other convention eth_0 or something like that. -- Stephen Hemminger [EMAIL PROTECTED] OSDL http://developer.osdl.org/~shemminger - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH]: suspicious unlikely usage in tcp_transmit_skb()

2006-04-25 Thread Stephen Hemminger
On Mon, 24 Apr 2006 16:25:39 -0700 Hua Zhong [EMAIL PROTECTED] wrote: Hi, I am developing a profiling tool to check if likely/unlikely usages are wise. I find that the following one is always a miss: # Hit# miss Function:[EMAIL PROTECTED] ! 0 50505

[PATCH 2/5] sky2: add fake idle irq timer

2006-04-25 Thread Stephen Hemminger
Add an fake NAPI schedule once a second. This is an attempt to work around for broken configurations with edge-triggered interrupts. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:48:47.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c

[PATCH 3/5] sky2: use ALIGN() macro

2006-04-25 Thread Stephen Hemminger
The ALIGN() macro in kernel.h does the same math that the sky2 driver was using for padding. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:47:03.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c 2006-04-25 10:47:28.0 -0700

[PATCH 5/5] sky2: version 1.2

2006-04-25 Thread Stephen Hemminger
Update to version 1.2 Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:54:57.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c 2006-04-25 10:55:51.0 -0700 @@ -51,7 +51,7 @@ #include sky2.h #define DRV_NAME

[PATCH 0/5] sky2: version 1.2

2006-04-25 Thread Stephen Hemminger
Update to sky2 driver. Mostly fixes to try and handle users stuck with edge-triggered interrupts. Also, some minor cleanups. Patches apply onto 1.1 version in 2.6.17-rc2 -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

[PATCH 1/5] sky2: reschedule if irq still pending

2006-04-25 Thread Stephen Hemminger
. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:48:44.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c 2006-04-25 10:48:47.0 -0700 @@ -2093,6 +2093,7 @@ int work_done = 0; u32 status = sky2_read32(hw

Re: [PATCH 2/5] sky2: add fake idle irq timer

2006-04-25 Thread Stephen Hemminger
On Tue, 25 Apr 2006 23:23:29 +0200 Francois Romieu [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] : [...] --- sky2-2.6.17.orig/drivers/net/sky2.c 2006-04-25 10:48:47.0 -0700 +++ sky2-2.6.17/drivers/net/sky2.c 2006-04-25 10:53:32.0 -0700 @@ -2086,6

Re: [PATCH]: suspicious unlikely usage in tcp_transmit_skb()

2006-04-25 Thread Stephen Hemminger
On Tue, 25 Apr 2006 14:46:49 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 25 Apr 2006 10:01:49 -0700 # Hit# miss Function:[EMAIL PROTECTED] ! 0 50505 tcp_transmit_skb():net/ipv4/[EMAIL PROTECTED

Re: [PATCH 2/5] sky2: add fake idle irq timer

2006-04-25 Thread Stephen Hemminger
On Wed, 26 Apr 2006 00:39:00 +0200 Francois Romieu [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] : [...] Any objection against moving mod_timer() from sky2_poll() to sky2_idle() so as to keep poll() path unmodified ? If traffic is moving, then I want the timer

Re: sky2 driver problems in 2.6.17-rc2-git6 (was: Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1)

2006-04-26 Thread Stephen Hemminger
On Tue, 25 Apr 2006 17:06:25 -0700 Guenther Thomsen [EMAIL PROTECTED] wrote: On Monday 17 April 2006 11:18, Stephen Hemminger wrote: I don't know what you are doing different, but my 2 port SysKonnect card is working fine. Running SMP AMD64 and 2.6.17 latest. Showing full speed on both

[RFC] bridge: partial rtnetlink hooks

2006-04-26 Thread Stephen Hemminger
); + br_netlink_exit(); + #ifdef CONFIG_BRIDGE_NETFILTER br_netfilter_fini(); #endif --- /dev/null +++ bridge-2.6/net/bridge/br_netlink.c @@ -0,0 +1,135 @@ +/* + * Bridge netlink control interface + * + * Authors: + * Stephen Hemminger [EMAIL PROTECTED

Re: tune back idle cwnd closing?

2006-04-26 Thread Stephen Hemminger
On Wed, 26 Apr 2006 15:16:18 -0700 Rick Jones [EMAIL PROTECTED] wrote: When you're bursty application is not sending, other flows can take up the pipe space you are not using, and you must reprobe to figure that out. If the restarted connection does normal slow-start, one of two things

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-04-28 Thread Stephen Hemminger
On Fri, 28 Apr 2006 10:02:10 -0700 Caitlin Bestler [EMAIL PROTECTED] wrote: Evgeniy Polyakov wrote: On Fri, Apr 28, 2006 at 08:59:19AM -0700, Caitlin Bestler ([EMAIL PROTECTED]) wrote: Btw, how is it supposed to work without header split capabale hardware? Hardware that can classify

[PATCH] netem: fix loss

2006-04-28 Thread Stephen Hemminger
The following one line fix is needed to make loss function of netem work right when doing loss on the local host. Otherwise, higher layers just recover. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.orig/net/sched/sch_netem.c +++ linux-2.6/net/sched/sch_netem.c @@ -167,7

Re: [LARTC] how to change classful netem loss probability?

2006-04-28 Thread Stephen Hemminger
Loss was broken, patch sent. The following works now: # tc qdisc add dev eth1 root handle 1:0 netem loss 20% # tc qdisc add dev eth1 parent 1:1 handle 10: tbf \ rate 256kbit buffer 1600 limit 3000 # ping -f -c 1000 shell 1000 packets transmitted, 781 received, 21% packet loss, time 3214ms

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-04-28 Thread Stephen Hemminger
On Fri, 28 Apr 2006 21:29:32 +0400 Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Fri, Apr 28, 2006 at 10:18:33AM -0700, Stephen Hemminger ([EMAIL PROTECTED]) wrote: Please just use existing AIO interface. We don't need another interface. The number of interfaces increases the exposed bug

Re: [PATCH 1/3] Rough VJ Channel Implementation - vj_core.patch

2006-04-28 Thread Stephen Hemminger
On Fri, 28 Apr 2006 12:16:36 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Fri, 28 Apr 2006 21:55:39 +0400 On Fri, Apr 28, 2006 at 10:41:18AM -0700, Stephen Hemminger ([EMAIL PROTECTED]) wrote: Second, introducing kevents, seems

Re: [PATCH 001/100] TCP congestion module: add TCP-LP supporting for 2.6.16

2006-05-02 Thread Stephen Hemminger
On Mon, 1 May 2006 18:05:52 +0800 Wong Edison [EMAIL PROTECTED] wrote: TCP Low Priority is a distributed algorithm whose goal is to utilize only the excess network bandwidth as compared to the ``fair share`` of bandwidth as targeted by TCP. Available from:

Re: [PATCH 001/100] TCP congestion module: add TCP-LP supporting for 2.6.16

2006-05-02 Thread Stephen Hemminger
+/** + * struct lp + * @flag: TCP-LP state flag + * @sowd: smoothed OWD 3 + * @owd_min: min OWD + * @owd_max: max OWD + * @owd_max_rsv: resrved max owd + * @RHZ: estimated remote HZ + * @remote_ref_time: remote reference time + * @local_ref_time: local reference time + * @last_drop:

Re: VJ Channel API - driver level (PATCH)

2006-05-03 Thread Stephen Hemminger
On Wed, 3 May 2006 11:12:15 -0700 Caitlin Bestler [EMAIL PROTECTED] wrote: Evgeniy Polyakov wrote: On Wed, May 03, 2006 at 08:56:23AM -0700, Caitlin Bestler ([EMAIL PROTECTED]) wrote: I'd expect high end NIC ASICs to implement rx steering based upon some sort of hash (for load

sky2 1.3-rc1

2006-05-03 Thread Stephen Hemminger
Here is a new version that addresses some of the outstanding bugs. * There was a race in receive processing that would cause hang * Some more support for Yukon Ultra found in dual-core Centrino laptops (I want one of these). It does not fix the problems with dual port cards corrupting receive

Re: netlink+ARP+CLIP == broken,

2006-05-03 Thread Stephen Hemminger
On Wed, 03 May 2006 22:32:39 +0100 Simon Kelley [EMAIL PROTECTED] wrote: Both net/ipv4/arp.c and net/arm/clip.c create neighbour tables with family == AF_INET. For most purposes this is fine, since the two modules each hold a pointer to their table and pass it into the neigh_* functions. A

[PATCH] bridge: keep track of received multicast packets

2006-05-04 Thread Stephen Hemminger
It makes sense to add this simple statistic to keep track of received multicast packets. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- bridge.orig/net/bridge/br_input.c 2006-04-21 14:28:55.0 -0700 +++ bridge/net/bridge/br_input.c2006-05-04 16:07:24.0 -0700

Re: [Netem] where i can find this netem patch?

2006-05-05 Thread Stephen Hemminger
On Fri, 05 May 2006 11:08:23 -0400 George Nychis [EMAIL PROTECTED] wrote: Hi, I need help finding this patch that Stephen made. He sent me a patch, but i do not think its related to the patch that solved this problem. I will include the patch he did forward to me at the bottom.

Re: sky2 1.3-rc1

2006-05-05 Thread Stephen Hemminger
On Fri, 5 May 2006 19:35:09 +0200 Thomas Glanzmann [EMAIL PROTECTED] wrote: Hello, http://developer.osdl.org/shemminger/prototypes/sky2-1.3-rc1.tar.bz2 v0.15: 64 bytes from 10.0.0.138: icmp_seq=2 ttl=64 time=0.467 ms v1.3-rc1: 64 bytes from 10.0.0.138: icmp_seq=4 ttl=64

Re: sky2 1.3-rc1

2006-05-05 Thread Stephen Hemminger
On Fri, 05 May 2006 19:42:27 +0100 Daniel Drake [EMAIL PROTECTED] wrote: Stephen Hemminger wrote: What is happening is that if there is a misconfiguration and irq routing is messed up (ie edge trigged). The driver will degenerate to polling every 100ms. If your system

Re: Please pull upstream-fixes branch of wireless-2.6

2006-05-05 Thread Stephen Hemminger
Linus Torvalds wrote: On Fri, 5 May 2006, Andrew Morton wrote: On Fri, 5 May 2006 21:06:18 -0400 John W. Linville [EMAIL PROTECTED] wrote: These are fixes intended for 2.6.17...thanks! Jeff is offline for a couple of weeks. Please prepare a pull for Linus. Actually,

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread Stephen Hemminger
On Sat, 06 May 2006 18:09:47 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 24 Apr 2006 15:23:41 -0700 This follows after the earlier two patches. Change the initialization of the class device portion of the net device

Re: 2.4 kern: want to print TCP cwnd with every packet

2006-05-08 Thread Stephen Hemminger
On Sat, 6 May 2006 10:19:16 -0400 (EDT) George P Nychis [EMAIL PROTECTED] wrote: Hi, I'd like to print the TCP cwnd for the sender, with every packet before it is sent out. This way i could plot the sender window over time to show TCP's behavior in certain conditions. I see in

Re: [PATCH] netdev: hotplug napi race cleanup

2006-05-08 Thread Stephen Hemminger
On Mon, 08 May 2006 11:37:31 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 8 May 2006 09:54:58 -0700 The issue is are there network devices that can't sleep during register_netdevice? Oh right, I forgot about that. We could

[patch 8/9] Add more support for the Yukon Ultra chip found in dual core centino laptops.

2006-05-08 Thread Stephen Hemminger
The newest Yukon Ultra chipset's require more special tweaks. They seem to be like the Yukon XL chipsets. This code is transliterated from the latest SysKonnect driver; I don't have any Ultra hardware. Signed-off-by: Stephe Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++

[patch 6/9] sky2: dont write status ring

2006-05-08 Thread Stephen Hemminger
It is more efficient not to write the status ring from the processor and just read the active portion. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c2006-05-02 09:49:38.0 -0700 +++ sky2/drivers/net/sky2.c 2006-05-02 09:49:42.0

[patch 5/9] sky2: edge triggered workaround enhancement

2006-05-08 Thread Stephen Hemminger
the driver into pure polling. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c2006-05-02 09:49:37.0 -0700 +++ sky2/drivers/net/sky2.c 2006-05-02 09:49:38.0 -0700 @@ -98,6 +98,10 @@ module_param(disable_msi, int, 0); MODULE_PARM_DESC

[patch 1/9] sky2: backout NAPI reschedule

2006-05-08 Thread Stephen Hemminger
This is a backout of earlier patch. The whole rescheduling hack was a bad idea. It doesn't really solve the problem and it makes the code more complicated for no good reason. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c

[patch 0/9] sky2 update

2006-05-08 Thread Stephen Hemminger
Bug fixes for sky2 driver: * fix NAPI related race that caused hangs * possible fixes for Yukon Ultra PHY support * performance improvement of ring management * fix race with irq on module removal -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

[patch 4/9] sky2: use mask instead of modulo operation

2006-05-08 Thread Stephen Hemminger
Gcc isn't smart enough to know that it can do a modulo operation with power of 2 constant by doing a mask. So add macro to do it for us. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -79,6 +79,8 @@ #define NAPI_WEIGHT

[patch 2/9] sky2: status irq hang fix

2006-05-08 Thread Stephen Hemminger
The status interrupt flag should be cleared before processing, not afterwards to avoid race. Need to process in poll routine even if no new interrupt status. This is a normal occurrence when more than 64 frames (NAPI weight) are processed in one poll routine. Signed-off-by: Stephen Hemminger

[patch 3/9] sky2: tx ring index mask fix

2006-05-08 Thread Stephen Hemminger
Mask for transmit ring status was picking up bits from the unused sync ring. They were always zero, so far... Also, make sure to remind self not to make tx ring too big. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -1927,7

[patch 9/9] sky2: version 1.3

2006-05-08 Thread Stephen Hemminger
Update version number, to track changes. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -51,7 +51,7 @@ #include sky2.h #define DRV_NAME sky2 -#define DRV_VERSION1.2 +#define DRV_VERSION

iproute2 git repository

2006-05-08 Thread Stephen Hemminger
I moved iproute2 out of CVS. New home is: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git Will keep CVS tree up to date until the next release, after that it is will rest in peace. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Please pull updated network drivers

2006-05-08 Thread Stephen Hemminger
in SPROM Stephen Hemminger: sky2: backout NAPI reschedule sky2: status irq hang fix sky2: tx ring index mask fix sky2: use mask instead of modulo operation sky2: edge triggered workaround enhancement sky2: dont write status ring sky2: synchronize irq on remove

Re: tcp compound

2006-05-09 Thread Stephen Hemminger
On Tue, 9 May 2006 19:39:43 +0200 Angelo P. Castellani [EMAIL PROTECTED] wrote: I resend the file because I've sent an old (quite identical) copy Moved discussion over to netdev mailing list.. Could you export symbols in tcp_vegas (and change config dependencies) to allow code reuse rather

Re: iproute2 git repository

2006-05-09 Thread Stephen Hemminger
On Tue, 09 May 2006 21:51:44 +1000 Herbert Xu [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] wrote: I moved iproute2 out of CVS. New home is: git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/iproute2.git Thanks Stephen. BTW, how come there is a checked out

Re: [RFC] netdev sysfs failure handling

2006-05-09 Thread Stephen Hemminger
Something like this would handle errors better, but introduce possible problems for drivers that call register_netdevice with irq's disabled. There was some comment about racing with linkwatch, but don't see how that could happen during creation. For 2.6.18? ---

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Stephen Hemminger
The stuff in /proc could easily just be added attributes to the class_device kobject of the net device (and then show up in sysfs). + +#define GRANT_INVALID_REF0 + +#define NET_TX_RING_SIZE __RING_SIZE((struct netif_tx_sring *)0, PAGE_SIZE) +#define NET_RX_RING_SIZE __RING_SIZE((struct

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Stephen Hemminger
+static int setup_device(struct xenbus_device *dev, struct netfront_info *info) +{ + struct netif_tx_sring *txs; + struct netif_rx_sring *rxs; + int err; + struct net_device *netdev = info-netdev; + + info-tx_ring_ref = GRANT_INVALID_REF; + info-rx_ring_ref =

Re: [RFC] netdev sysfs failure handling

2006-05-09 Thread Stephen Hemminger
On Tue, 09 May 2006 14:05:01 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 9 May 2006 12:01:07 -0700 Something like this would handle errors better, but introduce possible problems for drivers that call register_netdevice

[PATCH] sky2: ifdown kills irq mask

2006-05-09 Thread Stephen Hemminger
Bringing down a port also masks off the status and other IRQ's needed for device to function due to missing paren's. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -128,6 +128,7 @@ MODULE_DEVICE_TABLE(pci, sky2_id_table

Re: [RFC] netdev sysfs failure handling

2006-05-09 Thread Stephen Hemminger
On Tue, 09 May 2006 15:43:22 -0700 (PDT) David S. Miller [EMAIL PROTECTED] wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 9 May 2006 14:40:49 -0700 Agreed, especially since rtnl is now a real mutex. The case, that I was worried about: rtnl_lock() spin_lock_irq

[PATCH 0/2] register_netdevice and sysfs changes

2006-05-10 Thread Stephen Hemminger
This is a signed-off version of yesterday's fix, plus the bridge code no longer needs to be so tricky. -- - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] bridge: do sysfs registration inside rtnl

2006-05-10 Thread Stephen Hemminger
Now that netdevice sysfs registration is done as part of register_netdevice; bridge code no longer has to be tricky when adding it's kobjects to bridges. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- bridge.orig/net/bridge/br_if.c 2006-05-04 16:22:29.0 -0700 +++ bridge/net

[PATCH 1/2] netdev: do sysfs registration as part of register_netdevice

2006-05-10 Thread Stephen Hemminger
class_device registration/hotplug * code in netdev_run_todo only does unregistration so it is simpler. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- bridge.orig/include/linux/netdevice.h 2006-05-09 11:17:08.0 -0700 +++ bridge/include/linux/netdevice.h2006-05-09 11:18

please pull upstream branch of netdev-2.6

2006-05-10 Thread Stephen Hemminger
: use DMA_48BIT_MASK constant Herbert Valerio Riedel: phy: mdiobus_register(): initialize all phy_map entries James Cameron: sis900: phy for FoxCon motherboard Stephen Hemminger: sky2: ifdown kills irq mask drivers/net/dl2k.c | 12 ++-- drivers/net/phy

Re: [PATCH 3/6] myri10ge - Driver header files

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 23:36:18 +0200 Brice Goglin [EMAIL PROTECTED] wrote: [PATCH 3/6] myri10ge - Driver header files myri10ge driver header files. myri10ge_mcp.h is the generic header, while myri10ge_mcp_gen_header.h is automatically generated from our firmware image. Then clean it up after

Re: [PATCH 4/6] myri10ge - First half of the driver

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 14:40:22 -0700 (PDT) Brice Goglin [EMAIL PROTECTED] wrote: [PATCH 4/6] myri10ge - First half of the driver The first half of the myri10ge driver core. Splitting it in half, might help email restrictions, but it kills future users of 'git bisect' who expect to have every

Re: [PATCH 5/6] myri10ge - Second half of the driver

2006-05-10 Thread Stephen Hemminger
On Wed, 10 May 2006 14:42:41 -0700 (PDT) Brice Goglin [EMAIL PROTECTED] wrote: [PATCH 5/6] myri10ge - Second half of the driver The second half of the myri10ge driver core. Signed-off-by: Brice Goglin [EMAIL PROTECTED] Signed-off-by: Andrew J. Gallatin [EMAIL PROTECTED] myri10ge.c |

[PATCH] bonding: fix sparse warnings

2006-05-10 Thread Stephen Hemminger
Fix warning from sparse in bonding code about incorrect type in assignment Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- orig/drivers/net/bonding/bond_main.c2006-05-04 16:22:10.0 -0700 +++ new/drivers/net/bonding/bond_main.c 2006-05-10 16:04:38.0 -0700

Re: [PATCH] bonding: fix sparse warnings

2006-05-10 Thread Stephen Hemminger
On Thu, 11 May 2006 00:22:03 +0100 Al Viro [EMAIL PROTECTED] wrote: On Wed, May 10, 2006 at 04:14:05PM -0700, Stephen Hemminger wrote: Fix warning from sparse in bonding code about incorrect type in assignment *snerk* Only if you are building without -Wcast-to-as. It _is_ incorrect type

Re: [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-11 Thread Stephen Hemminger
On Thu, 11 May 2006 11:47:52 +0200 Andi Kleen [EMAIL PROTECTED] wrote: On Thursday 11 May 2006 09:49, Keir Fraser wrote: On 11 May 2006, at 01:33, Herbert Xu wrote: But if sampling virtual events for randomness is really unsafe (is it really?) then native guests in Xen would also get bad

[PATCH] expose simplified skb_checksum_recalc

2006-05-11 Thread Stephen Hemminger
Many users of skb_checksum_help() are just using it to recalculate outbound checksum, so why not expose the interface in a more useful way. Suggested by Ingo Oeser. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.orig/include/linux/skbuff.h 2006-04-27 11:12:53.0

[PATCH] sky2: prevent dual port receiver problems

2006-05-11 Thread Stephen Hemminger
a hardware bug because status arrives for a packet but no data is there. Until this bug is worked out, block the user from bringing up both ports at once. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- sky2.orig/drivers/net/sky2.c +++ sky2/drivers/net/sky2.c @@ -1020,8 +1020,19 @@ static

Re: skge driver oops

2006-05-12 Thread Stephen Hemminger
On Fri, 12 May 2006 11:36:24 +1000 David Arnold [EMAIL PROTECTED] wrote: i've been getting semi-regular lockups on my machine over 2.6.16 series. I recently attached a serial console in an attempt to capture an OOPS. i got one yesterday. it's copied manually from the console, but

Re: ixp2000: handle enp2611s with two gigabit ports

2006-05-15 Thread Stephen Hemminger
On Thu, 27 Apr 2006 00:24:11 +0200 Lennert Buytenhek [EMAIL PROTECTED] wrote: The ixp2000 driver for the enp2611 was developed on a board with three gigabit ports, but some enp2611 models only have two ports (and only one onboard PM3386.) The current driver assumes there are always three

[PATCH] net_sched: potential jiffy wrap bug in dev_watchdog

2006-05-15 Thread Stephen Hemminger
There is a potential jiffy wraparound bug in the transmit watchdog that is easily avoided by using time_after(). Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- linux-2.6.orig/net/sched/sch_generic.c +++ linux-2.6/net/sched/sch_generic.c @@ -193,8 +193,10 @@ static void dev_watchdog

[PATCH 1/2] skge: bad checksums on big-endian platforms

2006-05-15 Thread Stephen Hemminger
Skge driver always causes bad checksums on big-endian. The checksum in the receive control block was being swapped when it doesn't need to be. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c @@ -2717,8 +2717,7 @@ static int

[PATCH 2/2] skge: don't allow transmit ring to be too small

2006-05-15 Thread Stephen Hemminger
The driver will get stuck (permanent transmit timeout), if the transmit ring size is set too small. It needs to have enough ring elements to hold one maximum size transmit. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- skge-2.6.orig/drivers/net/skge.c +++ skge-2.6/drivers/net/skge.c

Re: send(), sendmsg(), sendto() not thread-safe

2006-05-15 Thread Stephen Hemminger
On Mon, 15 May 2006 16:17:48 -0700 Rick Jones [EMAIL PROTECTED] wrote: David S. Miller wrote: From: Mark A Smith [EMAIL PROTECTED] Date: Mon, 15 May 2006 14:39:06 -0700 I discovered that in some cases, send(), sendmsg(), and sendto() are not thread-safe. Although the man page for

Re: [PATCH] tcpdump may trace some outbound packets twice.

2006-05-15 Thread Stephen Hemminger
On Mon, 15 May 2006 16:11:05 -0700 (PDT) Ranjit Manomohan [EMAIL PROTECTED] wrote: On Mon, 15 May 2006, David S. Miller wrote: From: Ranjit Manomohan [EMAIL PROTECTED] Date: Mon, 15 May 2006 14:19:06 -0700 (PDT) Heres a new version which does a copy instead of the clone to avoid

Re: [PATCH] Enabling standard compliant behaviour in the Linux TCP implementation

2006-05-16 Thread Stephen Hemminger
On Tue, 16 May 2006 16:24:22 +0200 Angelo P. Castellani [EMAIL PROTECTED] wrote: Hi all, I'm a student doing a thesis about TCP performance over high BDP links and so about congestion control in TCP. To do this work I've built a testbed using the latest Linux release (2.6.16). Anyway

Re: ifIndex allocation

2006-05-16 Thread Stephen Hemminger
On Tue, 16 May 2006 08:11:01 +0200 Sven Schnelle [EMAIL PROTECTED] wrote: Hi List, Redirecting to netdev investigating a problem with an snmp software for linux, i was wondering why the kernel allocates a new ifindex Number, even if the old one is still available. For example, if i unload

Re: kernel panic (on DHCP discover?) in sky2 driver of 2.6.17-rc1

2006-05-16 Thread Stephen Hemminger
Could you try the 2.6.17-rc4 version with this patch. It turns out the board seems to give out of order status responses. Ignore the vendor sk98lin driver, when I try the stock version it spends it's life resetting itself because it sets up PCI bus wrong. If I fix that, it spends it's time

Re: skge driver oops

2006-05-16 Thread Stephen Hemminger
On Fri, 12 May 2006 11:36:24 +1000 David Arnold [EMAIL PROTECTED] wrote: i've been getting semi-regular lockups on my machine over 2.6.16 series. I recently attached a serial console in an attempt to capture an OOPS. i got one yesterday. it's copied manually from the console, but

<    1   2   3   4   5   6   7   8   9   10   >