Begin forwarded message:
Date: Sat, 08 Dec 2018 18:20:01 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201933] New: r8169 hangs with Oops/null pointer deref on shutdown
https://bugzilla.kernel.org/show_bug.cgi?id=201933
Bug ID:
On Thu, 6 Dec 2018 11:36:05 +0100
Andrew Lunn wrote:
> +void dsa_master_set_mtu(struct net_device *dev, struct dsa_port *cpu_dp)
> +{
> + unsigned int mtu = ETH_DATA_LEN + cpu_dp->tag_ops->overhead;
> + int err;
> +
> + rtnl_lock();
> + if (mtu <= dev->max_mtu) {
> +
On Mon, 3 Dec 2018 12:13:06 +0100
Emeric Dupont wrote:
> When performing make install in iproute2 (current git master),
> if $(HAVE_MNL) is not selected, some Makefiles try to call
> install with an empty target, which causes a non-critical make error.
>
> Signed-off-by: Emeric
On Tue, 4 Dec 2018 16:07:41 +
Petr Machata wrote:
> When no error is reported in the first iov, do not prematurely return,
> but process further iovs. This fixes batch processing.
>
> Fixes: c60389e4f9ea ("libnetlink: fix leak and using unused memory on error")
> Signed-off-by: Petr Machata
+ q->t_head = skb->next;
> + if (!q->t_head)
> + q->t_tail = NULL;
> + } else
> + rb_erase(>rbnode, >t_root);
Checkpatch wants both sides of if/else to have brackets.
Personally, don't care.
Reviewed-by: Stephen Hemminger
On Thu, 29 Nov 2018 13:20:37 +0100
Phil Sutter wrote:
> When fixing for shift/reduce conflicts, possibility to invert the last
> expression by prefixing with '!' or 'not' was accidentally removed.
>
> Fix this by allowing for expr to be an inverted expr so that any
> reference to it in exprlist
On Fri, 30 Nov 2018 05:57:02 -0800
Eric Dumazet wrote:
> When a rate estimator is active, "tc -s qd" displays
> something like :
>
> rate 12616bit 11ppsbacklog 0b 0p requeues 2
>
> instead of :
>
> rate 12616bit 11pps backlog 0b 0p requeues 2
>
> Fixes: 4fcec7f3665b ("tc: jsonify stats2")
>
On Sat, 01 Dec 2018 16:55:40 -0800 (PST)
David Miller wrote:
> Stephen please actually read the reports your forward here.
>
> This is a report about arch/x86/lib/inat.c which is a set of CPU
> instruction attributes and has nothing to do with networkig.
Yes, bug moved to x86 platform.
On Mon, 03 Dec 2018 13:19:20 -0800
Jeff Kirsher wrote:
> On Fri, 2018-11-30 at 15:26 -0800, Stephen Hemminger wrote:
> > On my box with Debian testing, I see a new problem with
> > suspend/resume of wired network device.
> > Using stock Debian kernel 4.18.0-2-amd64
> >
More checksum changes fallout?
Begin forwarded message:
Date: Mon, 03 Dec 2018 04:23:36 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201849] New: hw csum failure - reproducible error
https://bugzilla.kernel.org/show_bug.cgi?id=201849
Begin forwarded message:
Date: Sat, 01 Dec 2018 17:20:33 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201829] New: Failed build kernel with nat
https://bugzilla.kernel.org/show_bug.cgi?id=201829
Bug ID: 201829
Summary:
d-off-by: Jouke Witteveen
Makes sense. I am also working on tracepoints for netdev changes.
Reviewed-by: Stephen Hemminger
On my box with Debian testing, I see a new problem with suspend/resume of wired
network device.
Using stock Debian kernel 4.18.0-2-amd64
After suspend/resume cycle, IP address is lost.
Device Info:
$ /sbin/ethtool -i enp12s0
driver: igb
version: 5.4.0-k
firmware-version: 0. 6-1
On Fri, 30 Nov 2018 20:22:35 +0100
Alexis Vachette wrote:
> Hi Stephen,
>
> Thanks for your kind reply.
>
> It's sad to hear that, I am aware of your concern too.
>
> But it's not the best behavior for a network engineer.
>
> Is it possible to add a new option or everything is stone graved ?
On Fri, 30 Nov 2018 14:33:49 +0100
Alexis Vachette wrote:
> When using:
>
> - ip -s link
>
> I think it should be better to print errors stats without adding -s
> option twice.
>
> This option print stats for each network interfaces and we want to see
> if something is off and especially
On Thu, 29 Nov 2018 02:27:54 -0800
Eric Dumazet wrote:
> Wei Wang added these fields in linux-4.19
>
> Tested:
>
> ss -ti ...
>
> ts sack cubic wscale:8,8 rto:7 rtt:2.678/0.267 mss:1428 pmtu:1500
> rcvmss:536 advmss:1428 cwnd:91 ssthresh:65
> (*) bytes_sent:17470606104
On Mon, 26 Nov 2018 14:29:53 -0800
Eric Dumazet wrote:
> Kernel support was added in linux-4.18 in commit feb5f2ec6464
> ("tcp: export packets delivery info")
>
> Tested:
>
> ss -ti
> ...
> ESTAB 0 2270520 [2607:f8b0:8099:e16::]:47646
> [2607:f8b0:8099:e18::]:38953
>ts sack
On Tue, 27 Nov 2018 18:02:52 -0800
Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> commit c7c1a1ef51ae ("bridge: colorize output and use JSON print library")
> broke previous use of -c to represent compressvlans. This restores
> previous use of -c to represent compressvlans. Understand the
On Mon, 26 Nov 2018 18:58:31 +0100
Phil Sutter wrote:
> All rdma-related man pages list each other in SEE ALSO section, only
> rdma-resource.8 is missing. Add it for the sake of consistency.
>
> Signed-off-by: Phil Sutter
Applied
On Mon, 26 Nov 2018 17:56:10 -0800
"Nambiar, Amritha" wrote:
> On 11/26/2018 4:43 PM, David Ahern wrote:
> > On 11/26/18 5:23 PM, Nambiar, Amritha wrote:
> >>> Can tc flower use something similar to ip ru with single port or port
> >>> range handled like this?
> >>>
> >>> },{
> >>>
On Sat, 24 Nov 2018 17:12:48 -0700
David Ahern wrote:
> IPX was moved to staging at the end of last year. Can decnet follow
> suit? git log seems to indicate no active development in a very long time.
>
> David
I have no problem with dropping decnet support from iproute first.
Presumably
On Tue, 31 Oct 2017 16:28:20 -0700
Cong Wang wrote:
> On Tue, Oct 31, 2017 at 2:10 PM, Stephen Hemminger
> wrote:
> >
> > IPPROTO_MH comes from include/uapi/linux/in6.h
> > Maybe it is trying to use old kernel headers from libc.
>
> So newer iproute2 is n
Could be a bug, or just how it works?
Begin forwarded message:
Date: Thu, 22 Nov 2018 22:51:12 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201773] New: IP_FREEBIND doesn’t counteract global
https://bugzilla.kernel.org/show_bug.cgi?id=201773
On Wed, 21 Nov 2018 10:44:27 +0100
Nicolas Dichtel wrote:
> Don't confuse the user, nsid is a signed integer, this kind of command
> should return an error: 'ip netns set foo 0x'.
>
> Also, a valid value is a positive value. To let the kernel chooses a value,
> the keyword 'auto' must
On Tue, 20 Nov 2018 01:26:27 +
Quentin Monnet wrote:
> In order to compare BPF map symbol type correctly in regard to the
> latest LLVM, commit 7a04dd84a7f9 ("bpf: check map symbol type properly
> with newer llvm compiler") compares map symbol type to both NOTYPE and
> OBJECT. To do so, it
Begin forwarded message:
Date: Tue, 20 Nov 2018 07:09:26 +
From: bugzilla-dae...@bugzilla.kernel.org
To: step...@networkplumber.org
Subject: [Bug 201735] New: serial8250: too much work for irq4
https://bugzilla.kernel.org/show_bug.cgi?id=201735
Bug ID: 201735
On Mon, 19 Nov 2018 15:03:29 -0800
Jakub Kicinski wrote:
> Add helpers for printing char-size values.
>
> Signed-off-by: Jakub Kicinski
> Reviewed-by: Quentin Monnet
> ---
> include/json_print.h | 1 +
> include/json_writer.h | 2 ++
> lib/json_print.c | 1 +
> lib/json_writer.c
On Fri, 16 Nov 2018 11:17:40 -0800
yupeng wrote:
> +* TcpInSegs
> +Defined in `RFC1213 tcpInSegs`_
> +
> +.. _RFC1213 tcpInSegs: https://tools.ietf.org/html/rfc1213#page-48
> +
> +The number of packets received by the TCP layer. As mentioned in
> +RFC1213, it includes the packets received in
Trivial spelling errors found by codespell.
Signed-off-by: Stephen Hemminger
---
include/uapi/linux/ethtool.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h
index c8f8e2455bf3..17be76aeb468 100644
--- a/include
Make functions only used in ipxfrm.c static.
Signed-off-by: Stephen Hemminger
---
ip/ipxfrm.c | 11 ++-
ip/xfrm.h | 9 -
ip/xfrm_monitor.c | 2 +-
3 files changed, 7 insertions(+), 15 deletions(-)
diff --git a/ip/ipxfrm.c b/ip/ipxfrm.c
index 17ab4abef4be
Several functions only used inside utils.c
Signed-off-by: Stephen Hemminger
---
rdma/rdma.h | 11 ---
rdma/utils.c | 12 ++--
2 files changed, 6 insertions(+), 17 deletions(-)
diff --git a/rdma/rdma.h b/rdma/rdma.h
index c3b7530b6cc7..05c3c69b07fd 100644
--- a/rdma/rdma.h
Several variables only used in this code.
Signed-off-by: Stephen Hemminger
---
misc/ss.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/misc/ss.c b/misc/ss.c
index 4d12fb5d19df..e4d6ae489e79 100644
--- a/misc/ss.c
+++ b/misc/ss.c
@@ -96,20
The function genl_ctrl_resolve_family is defined but never used
in current code.
Signed-off-by: Stephen Hemminger
---
genl/ctrl.c | 71 ---
genl/genl_utils.h | 2 --
2 files changed, 73 deletions(-)
diff --git a/genl/ctrl.c b/genl/ctrl.c
index
color_enable etc, only used here.
Signed-off-by: Stephen Hemminger
---
include/color.h | 2 --
lib/color.c | 6 --
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/color.h b/include/color.h
index e30f28c51c84..17ec56f3d7b4 100644
--- a/include/color.h
+++ b/include
ll_idx_a2n is only used in ll_map.
Signed-off-by: Stephen Hemminger
---
include/ll_map.h | 1 -
lib/ll_map.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/ll_map.h b/include/ll_map.h
index fb708191c22c..511fe00b8567 100644
--- a/include/ll_map.h
+++ b/include
prefix_banner only used in one file.
Signed-off-by: Stephen Hemminger
---
ip/ipmonitor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipmonitor.c b/ip/ipmonitor.c
index 9d5ac2b5e4d2..743632cc5569 100644
--- a/ip/ipmonitor.c
+++ b/ip/ipmonitor.c
@@ -24,7 +24,7
Not used in current code.
Signed-off-by: Stephen Hemminger
---
include/names.h | 1 -
lib/names.c | 28
2 files changed, 29 deletions(-)
diff --git a/include/names.h b/include/names.h
index 3e5d3b146a23..2fcaacc398d4 100644
--- a/include/names.h
+++ b/include
Function only used in one file.
Signed-off-by: Stephen Hemminger
---
tipc/cmdl.c | 2 +-
tipc/cmdl.h | 2 --
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/tipc/cmdl.c b/tipc/cmdl.c
index 4a2f4fd92f48..f2f259cc5320 100644
--- a/tipc/cmdl.c
+++ b/tipc/cmdl.c
@@ -17,7 +17,7
Only used in this file.
Signed-off-by: Stephen Hemminger
---
tc/tc_class.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tc/tc_class.c b/tc/tc_class.c
index 7e4e17fd7f39..7ac700d7ab31 100644
--- a/tc/tc_class.c
+++ b/tc/tc_class.c
@@ -153,9 +153,9 @@ static int
Signed-off-by: Stephen Hemminger
---
tc/m_action.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tc/m_action.c b/tc/m_action.c
index e90867fc6c25..d5fd5affe703 100644
--- a/tc/m_action.c
+++ b/tc/m_action.c
@@ -30,9 +30,9 @@
static struct action_util *action_list
The pedit callback structure table should be iniatialized using
structure initialization to avoid structure changes problems.
Signed-off-by: Stephen Hemminger
---
tc/p_eth.c | 5 ++---
tc/p_icmp.c | 5 ++---
tc/p_ip.c | 5 ++---
tc/p_ip6.c | 5 ++---
tc/p_tcp.c | 5 ++---
tc/p_udp.c | 5
print_police function only used by m_police.
Signed-off-by: Stephen Hemminger
---
tc/m_police.c | 10 +++---
tc/tc_util.h | 3 ---
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/tc/m_police.c b/tc/m_police.c
index f3b07f7b0439..d645999ba08b 100644
--- a/tc/m_police.c
+++ b
The parse and pack functions are only used by the pedit routines.
Signed-off-by: Stephen Hemminger
---
tc/m_pedit.c | 33 ++---
tc/m_pedit.h | 15 ---
2 files changed, 14 insertions(+), 34 deletions(-)
diff --git a/tc/m_pedit.c b/tc/m_pedit.c
index
The mapping table is only used by em_meta.
Signed-off-by: Stephen Hemminger
---
tc/em_meta.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/tc/em_meta.c b/tc/em_meta.c
index d94fe88d9b2f..2ddc65ed6cb6 100644
--- a/tc/em_meta.c
+++ b/tc/em_meta.c
@@ -38,7 +38,7
enable_color and set_color_palette only used here.
Signed-off-by: Stephen Hemminger
---
bridge/bridge.c | 5 ++---
bridge/monitor.c | 2 +-
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/bridge/bridge.c b/bridge/bridge.c
index ac4d6a14f510..389f1bd5382b 100644
--- a/bridge
The tc util library parse/print has functions only used locally
(and some dead code removed).
Signed-off-by: Stephen Hemminger
---
tc/tc_util.c | 17 +++--
tc/tc_util.h | 5 -
2 files changed, 3 insertions(+), 19 deletions(-)
diff --git a/tc/tc_util.c b/tc/tc_util.c
index
The print handling is only used in tc/m_ematch.c
Remove unused function to print_ematch_tree.
Signed-off-by: Stephen Hemminger
---
tc/m_ematch.c | 30 +++---
tc/m_ematch.h | 1 -
2 files changed, 3 insertions(+), 28 deletions(-)
diff --git a/tc/m_ematch.c b/tc
The table of filter flags is only used in ipaddress
Signed-off-by: Stephen Hemminger
---
ip/ipaddress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index cd8cc76a3473..2671c4e162e3 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
Code cleanup including:
* make local functions static
* drop dead code
* whitespace code style cleanup
Stephen Hemminger (22):
lib/ll_addr: whitespace and indent cleanup
lib/utils: make local functions static
lib/color: make local functions static
lib/ll_map: make local function
Some of the print/parsing is only used internally.
Drop unused get_s8/get_s16.
Signed-off-by: Stephen Hemminger
---
include/utils.h | 5 -
lib/utils.c | 48 +++-
2 files changed, 7 insertions(+), 46 deletions(-)
diff --git a/include/utils.h
Run old ll_addr through kernel Lindent.
Signed-off-by: Stephen Hemminger
---
lib/ll_addr.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/lib/ll_addr.c b/lib/ll_addr.c
index 84de64e2e053..00b562aeda22 100644
--- a/lib/ll_addr.c
+++ b/lib/ll_addr.c
rntl_talk_extack and parse_rtattr_index not used in current code.
rtnl_dump_filter_l is only used in this file.
Signed-off-by: Stephen Hemminger
---
include/libnetlink.h | 7 ---
lib/libnetlink.c | 28 ++--
2 files changed, 2 insertions(+), 33 deletions(-)
diff
The testsuite directory had a directory of ancient kernel configs.
Signed-off-by: Stephen Hemminger
---
testsuite/configs/all-2.4| 848 -
testsuite/configs/all-no-act | 1499 -
testsuite/configs/all-police-act | 1504
IPX has been depracted then removed from upstream kernels.
Drop support from ip route as well.
Signed-off-by: Stephen Hemminger
---
Makefile | 3 --
include/utils.h| 10 -
ip/ip.c| 4 +-
ip/iproute.c | 2 +-
lib/ipx_ntop.c | 71
The function genl_ctrl_resolve_family is defined but never used
in current code.
Signed-off-by: Stephen Hemminger
---
genl/ctrl.c | 71 ---
genl/genl_utils.h | 2 --
2 files changed, 73 deletions(-)
diff --git a/genl/ctrl.c b/genl/ctrl.c
index
On Wed, 14 Nov 2018 11:52:51 +0100
Phil Sutter wrote:
> Hi Stephen,
>
> On Tue, Nov 13, 2018 at 02:47:59PM -0800, Stephen Hemminger wrote:
> > On Tue, 13 Nov 2018 16:12:01 +0100
> > Phil Sutter wrote:
> >
> > > + if (arg[0] == '-') {
> > &
On Tue, 13 Nov 2018 13:39:04 +0100
Phil Sutter wrote:
> When parsing nexthop parameters, a buffer of 4k bytes is provided. Yet,
> in lwt_parse_encap() and some functions called by it, buffer size was
> assumed to be 1k despite the actual size was provided. This led to
> spurious buffer size
On Mon, 12 Nov 2018 23:21:01 +0100
Phil Sutter wrote:
> Add a note to 'nexthop' description stating the maximum number of
> nexthops per command and pointing at 'append' command as a workaround.
>
> Signed-off-by: Phil Sutter
Applied
On Tue, 13 Nov 2018 16:12:01 +0100
Phil Sutter wrote:
> + if (arg[0] == '-') {
> + inv = true;
> + arg++;
> + }
The inverse logic needs to be moved into the loop handling filter names.
Otherwise, you get weirdness like "-dynamic" being accepted and not
doing what
On Sat, 10 Nov 2018 22:48:44 +0100
Phil Sutter wrote:
> Hi Stefano,
>
> On Sat, Nov 10, 2018 at 10:21:59AM +0100, Stefano Brivio wrote:
> > Since commit 00240899ec0b ("ss: Actually print left delimiter for
> > columns") changes spacing in ss output, we also need to adjust for that in
> > the ss
When running testsuite it is easy as a human to miss failure.
Add symbol colorizing to SKIPED/PASS/FAIL output.
Signed-off-by: Stephen Hemminger
---
testsuite/Makefile | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/testsuite/Makefile b/testsuite/Makefile
index
On Mon, 29 Oct 2018 23:04:25 +0100
Stefano Brivio wrote:
> While rendering columns, we use a local variable to keep track of the
> field currently being printed, without touching current_field, which is
> used for buffering.
>
> Use the right pointer to access the left delimiter for the current
On Mon, 5 Nov 2018 19:23:27 -0800
Jakub Kicinski wrote:
> u32 uses NEXT_ARG() incorrectly when parsing skip_hw and skip_sw
> flags. NEXT_ARG() ensures there is another argument on the command
> line, and is used in handling syntax to move past
> and ensure there is a to read.
>
> Commit
On Wed, 07 Nov 2018 13:22:50 -0800
Amritha Nambiar wrote:
> Added support for filtering based on port ranges.
>
> Example:
> 1. Match on a port range:
> -
> $ tc filter add dev enp4s0 protocol ip parent :\
> prio 1 flower ip_proto tcp dst_port range 20-30 skip_hw\
On Fri, 2 Nov 2018 12:35:43 +
Luca Boccassi wrote:
> Follow the standard pattern, and respect user's verbosity setting.
>
> Signed-off-by: Luca Boccassi
Both applied
On Fri, 2 Nov 2018 10:57:41 +
Luca Boccassi wrote:
> ". If" gets interpreted as a macro, so move the period to the previous
> line:
>
> 33: warning: macro `If' not defined
>
> Fixes: 141b55f8544e ("Add SKB Priority qdisc support in tc(8)")
>
> Signed-off-by: Luca Boccassi
Applied
On Fri, 2 Nov 2018 13:27:48 +
Luca Boccassi wrote:
> Fixes groff warning:
> ss.8 92: warning [p 2, 2.8i]: can't break line
>
> And makes the line also more readable.
>
> Signed-off-by: Luca Boccassi
Applied
On Wed, 7 Nov 2018 15:14:09 -0800
Roopa Prabhu wrote:
> From: Roopa Prabhu
>
> After commit 4abb8c723a64 ("bridge: fdb: Fix for missing
> keywords in non-JSON output"), I am seeing a double print for dev
> in bridge fdb show. eg:
> "44:38:39:00:6a:82 dev dev bridge vlan 1 master bridge
On Fri, 9 Nov 2018 14:23:27 +0100
"Johannes C. Schulz" wrote:
> Hello all!
>
> I like to please you to bring back IPX and NCPFS modules to the kernel.
> Whyever my admins using Novell-shares on our network which I'm not be
> able to use anymore - I'm forced to use cifs instead (and the admins
>
On Fri, 9 Nov 2018 04:24:43 +0100
Andrew Lunn wrote:
> Hi Roopa, Nikolay
>
> br_handle_frame() looks out for frames with a destination MAC
> addresses with is Ethernet link local, those which fit
> 01-80-C2-00-00-XX. It does not normally forward these, but it will
> deliver them locally.
>
>
On Thu, 8 Nov 2018 10:35:05 +0100
Phil Sutter wrote:
> Hi Roopa,
>
> On Wed, Nov 07, 2018 at 03:14:09PM -0800, Roopa Prabhu wrote:
> > From: Roopa Prabhu
> >
> > After commit 4abb8c723a64 ("bridge: fdb: Fix for missing
> > keywords in non-JSON output"), I am seeing a double print for dev
> >
On Tue, 6 Nov 2018 22:38:59 +0100
Stefano Brivio wrote:
> df = htons(IP_DF);
> }
>
> + if (!df) {
> + if (vxlan->cfg.df == VXLAN_DF_SET) {
> + df = htons(IP_DF);
I am confused, this looks like
On Thu, 1 Nov 2018 10:35:05 +0200
Leon Romanovsky wrote:
> From: Leon Romanovsky
>
> After commit 4060e4c0d257 ("rdma: Add PD resource tracking
> information"), the resource information shows PDs and MRs,
> but help pages didn't fully reflect it.
>
> Signed-off-by: Leon Romanovsky
Applied
On Thu, 1 Nov 2018 22:25:27 +
Luca Boccassi wrote:
> This is simpler and cleaner, and avoids having to include the header
> from every file where the functions are used. The prototypes of the
> internal implementation are in this header, so utils.h will have to be
> included anyway for
On Thu, 1 Nov 2018 15:18:03 -0600
David Ahern wrote:
> On 11/1/18 3:06 PM, Jakub Kicinski wrote:
> > On Wed, 31 Oct 2018 20:48:05 -0600, David Ahern wrote:
> >>> spacing with a special character in the format string, that is:
> >>>
> >>> "%S.%Qr.%Qs %Al:%Pl %Ar:%Pr %p\n"
> >>>
> >>>
On Tue, 30 Oct 2018 13:59:05 -0700
David Ahern wrote:
> From: David Ahern
>
> 'ip rule add' with no additional arguments just adds another rule
> for the main table - which exists by default. Require at least
> 1 argument similar to delete.
>
> Signed-off-by: David Ahern
Applied these two
On Thu, 1 Nov 2018 00:14:38 +
Jeff Barnhill <0xeff...@gmail.com> wrote:
> diff --git a/include/net/addrconf.h b/include/net/addrconf.h
> index 14b789a123e7..799af1a037d1 100644
> --- a/include/net/addrconf.h
> +++ b/include/net/addrconf.h
> @@ -317,6 +317,8 @@ bool ipv6_chk_acast_addr(struct
On Wed, 31 Oct 2018 21:49:30 +0530
Leslie Monis wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index c84e91e..b68b367 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -57,6 +57,7 @@ struct pie_vars {
> psched_time_t dq_tstamp;/* drain rate */
>
On Wed, 31 Oct 2018 21:49:29 +0530
Leslie Monis wrote:
> From: "Mohit P. Tahiliani"
>
> The update in drop probability depends on the parameters
> alpha and beta, which in turn reflect the current congestion
> level. However, the previous if-else cases were recommended
> when the supported
On Wed, 31 Oct 2018 21:49:31 +0530
Leslie Monis wrote:
> diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
> index b68b367..88e605c 100644
> --- a/net/sched/sch_pie.c
> +++ b/net/sched/sch_pie.c
> @@ -58,6 +58,7 @@ struct pie_vars {
> u32 avg_dq_rate;/* bytes per pschedtime
On Wed, 31 Oct 2018 21:49:24 +0530
Leslie Monis wrote:
> The current implementation of PIE queueing discipline is according to an IETF
> draft [http://tools.ietf.org/html/draft-pan-aqm-pie-00] and the paper
> [PIE: A Lightweight Control Scheme to Address the Bufferbloat Problem].
> However, a
On Mon, 29 Oct 2018 15:32:03 -0700
Yonghong Song wrote:
> With llvm 7.0 or earlier, the map symbol type is STT_NOTYPE.
> -bash-4.4$ cat t.c
> __attribute__((section("maps"))) int g;
> -bash-4.4$ clang -target bpf -O2 -c t.c
> -bash-4.4$ readelf -s t.o
>
> Symbol table '.symtab'
On Mon, 29 Oct 2018 23:04:25 +0100
Stefano Brivio wrote:
> While rendering columns, we use a local variable to keep track of the
> field currently being printed, without touching current_field, which is
> used for buffering.
>
> Use the right pointer to access the left delimiter for the current
On Mon, 29 Oct 2018 10:46:50 +
Luca Boccassi wrote:
> If libc does not provide strlcpy check for libbsd with pkg-config to
> avoid relying on inline version.
>
> Signed-off-by: Luca Boccassi
> ---
> This allows distro maintainers to be able to choose to reduce
> duplication and let this
On Tue, 30 Oct 2018 10:34:45 -0600
David Ahern wrote:
> On 10/30/18 9:05 AM, Stefano Brivio wrote:
> > Now that we have an abstraction for columns, it's relatively easy to
> > selectively display only some of them, and Yoann has a use case for it.
> >
> > Patch 1/3 fixes a rendering issue that
On Fri, 26 Oct 2018 22:53:32 +0200
"Yoann P." wrote:
> When using ss -Hutn4 or -utn3, Netid and State columns are sometime merged,
> it
> can be confusing when trying to pipe into awk or column.
> Details (before and after output) are available on this github issue: https://
>
On Fri, 26 Oct 2018 23:51:03 +0200
Tobias Jungel wrote:
> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> v2: fixed too greedy deletion that caused a -Wmaybe-uninitialized
>
> Signed-off-by: Tobias Jungel
Applied
On Sat, 27 Oct 2018 17:31:02 +0200
Peter Korsgaard wrote:
> q_{etf,taprio}.c uses CLOCK_TAI, which isn't exposed by glibc < 2.21 or
> uClibc, breaking the build. Provide a fallback definition like it is done
> for IPPROTO_MPLS and others.
>
> Signed-off-by: Peter Korsgaard
> ---
Applied,
On Wed, 24 Oct 2018 14:29:34 +0800
Shawn Lin wrote:
> On 2018/10/24 13:54, David Miller wrote:
> > From: Shawn Lin
> > Date: Wed, 24 Oct 2018 13:48:55 +0800
> >
> >> Hi David,
> >>
> >> On 2018/10/24 10:19, David Miller wrote:
> >>> From: Shawn Lin
> >>> Date: Wed, 24 Oct 2018 09:46:47
On Tue, 23 Oct 2018 12:36:24 +0200
Phil Sutter wrote:
> Value of 'default' is assumed to be hexadecimal when parsing, so
> consequently it should be printed in hex as well. This is a regression
> introduced when adding JSON output.
>
> As requested, also change JSON output to print the value as
On Mon, 22 Oct 2018 19:03:41 +0200
Petr Vorel wrote:
> Hi Stephen,
>
> > Applied, it seem to have gotten lost somewhere between my laptop and the
> > repo.
> Thanks a lot for merging :).
>
> There is a patchset "Minor shell code cleanup", which has state Accepted, but
> not in git
>
On Thu, 18 Oct 2018 15:48:48 +0200
Phil Sutter wrote:
> All these assignments are later overwritten without reading in between,
> so just drop them.
>
> Fixes: 485d0c6001c4a ("tc: Add batchsize feature for filter and actions")
> Signed-off-by: Phil Sutter
Applied
On Thu, 18 Oct 2018 15:48:09 +0200
Phil Sutter wrote:
> Although initialized by call to libmnl, the variable is used only in a
> call to sizeof(). Drop it and call sizeof with its type instead.
>
> Fixes: f043759dd4928 ("tipc: add new TIPC configuration tool")
> Signed-off-by: Phil Sutter
On Thu, 18 Oct 2018 15:44:14 +0200
Phil Sutter wrote:
> In case caller did not specify 'segs' parameter, parse_srh() would read
> garbage while iterating over 'segbuf'. Avoid this by initializing
> 'segbuf' to an empty string.
>
> Fixes: e8493916a8ede ("iproute: add support for SR-IPv6 lwtunnel
On Thu, 18 Oct 2018 14:35:50 +0200
Phil Sutter wrote:
> Variables 'src_port' and 'dst_port' are initialized only if attributes
> RDMA_NLDEV_ATTR_RES_SRC_ADDR or RDMA_NLDEV_ATTR_RES_DST_ADDR are
> present. Make sure to pass them over to rd_check_is_filtered() only if
> that is the case.
>
>
On Thu, 18 Oct 2018 13:41:54 +0200
Phil Sutter wrote:
> With 'name' field defined as array in struct filters, it will always
> contain a value irrespective of whether a name was assigned or not.
>
> Fix this by turning the field into a const char pointer.
>
> Fixes: 8cd644095842a ("devlink:
On Thu, 18 Oct 2018 14:30:31 +0200
Phil Sutter wrote:
> If call to rta_addattr_l() failed, parse_encap_seg6() would leak memory.
> Fix this by making sure calls to free() are not skipped.
>
> Fixes: bd59e5b1517b0 ("ip-route: Fix segfault with many nexthops")
> Signed-off-by: Phil Sutter
On Sat, 20 Oct 2018 15:42:33 +0200
Tobias Jungel wrote:
> The output of -statistics vlan show was broken previous change for json
> output. This aligns the format to vlan show.
>
> Signed-off-by: Tobias Jungel
This patch causes new warning:
CC vlan.o
vlan.c: In function
On Fri, 19 Oct 2018 17:42:55 +0200
Phil Sutter wrote:
> Value of 'default' is assumed to be hexadecimal when parsing, so
> consequently it should be printed in hex as well. This is a regression
> introduced when adding JSON output.
>
> Fixes: f354fa6aa5ff0 ("tc: jsonify htb qdisc")
>
On Tue, 25 Sep 2018 14:49:56 +0200
Petr Vorel wrote:
> make check from top level Makefile defines several flags which break
> building generate_nlmsg:
>
> $ make check
> make -C tools
> gcc -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations
> -Wold-style-definition
1 - 100 of 5336 matches
Mail list logo
