Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-31 Thread Andi Kleen
Venki Pallipadi [EMAIL PROTECTED] writes: If this does not work: Another option is to use 'deferrable timer' here which will be called at same as before time when CPU is busy and on idle CPU it will be delayed until CPU comes out of idle due to any other events. That would sound like a good

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Andrew Morton
On Tue, 29 May 2007 11:01:13 -0700 Venki Pallipadi [EMAIL PROTECTED] wrote: round_jiffies for net dev watchdog timer. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c ===

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 10:59:36 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Tue, 29 May 2007 11:01:13 -0700 Venki Pallipadi [EMAIL PROTECTED] wrote: round_jiffies for net dev watchdog timer. Signed-off-by: Venkatesh Pallipadi [EMAIL PROTECTED] Index:

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Patrick McHardy
Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c 2007-05-24 11:16:03.0 -0700 +++ linux-2.6.22-rc-mm/net/sched/sch_generic.c 2007-05-25

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Venki Pallipadi
On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote: Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Patrick McHardy
Venki Pallipadi wrote: On Wed, May 30, 2007 at 08:42:32PM +0200, Patrick McHardy wrote: It seems wasteful to add per-packet overhead for tx timeouts, which should be an exception. Do drivers really care about the exact timeout value? Compared to a packet transmission time its incredibly long

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === --- linux-2.6.22-rc-mm.orig/net/sched/sch_generic.c2007-05-24

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Stephen Hemminger
On Wed, 30 May 2007 12:55:51 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Venki Pallipadi
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === ---

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Venki Pallipadi
On Wed, May 30, 2007 at 01:30:39PM -0700, Stephen Hemminger wrote: On Wed, 30 May 2007 12:55:51 -0700 (PDT) David Miller [EMAIL PROTECTED] wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index:

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Matt Mackall
On Wed, May 30, 2007 at 12:55:51PM -0700, David Miller wrote: From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 30 May 2007 20:42:32 +0200 Stephen Hemminger wrote: Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c === ---

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread David Miller
From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 30 May 2007 17:10:39 -0500 Are you agreeing that it seems wasteful to add per-packet overhead? This patch is not doing that. Yes, and I know that :-) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [PATCH 3/4] Make net watchdog timers 1 sec jiffy aligned

2007-05-30 Thread Matt Mackall
On Wed, May 30, 2007 at 03:29:39PM -0700, David Miller wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 30 May 2007 17:10:39 -0500 Are you agreeing that it seems wasteful to add per-packet overhead? This patch is not doing that. Yes, and I know that :-) Is there a real reason for